rails_pulse 0.1.2 → 0.1.3

data/app/services/rails_pulse/analysis/suggestion_generator.rb

@@ -0,0 +1,217 @@
+# Consolidates analysis results into prioritized, actionable optimization suggestions.
+# Combines insights from all analyzers and categorizes suggestions by impact and implementation complexity.
+module RailsPulse
+  module Analysis
+    class SuggestionGenerator
+      attr_reader :analysis_results
+
+      def initialize(analysis_results)
+        @analysis_results = analysis_results
+      end
+
+      def generate
+        suggestions = []
+
+        # Suggestions from pattern issues
+        suggestions.concat(generate_issue_suggestions)
+
+        # Suggestions from index recommendations
+        suggestions.concat(generate_index_suggestions)
+
+        # Suggestions from N+1 analysis
+        suggestions.concat(generate_n_plus_one_suggestions)
+
+        # Suggestions from query characteristics
+        suggestions.concat(generate_query_characteristic_suggestions)
+
+        # Suggestions from explain plan issues
+        suggestions.concat(generate_explain_plan_suggestions)
+
+        # Prioritize and deduplicate suggestions
+        prioritize_suggestions(suggestions)
+      end
+
+      private
+
+      def generate_issue_suggestions
+        issues = analysis_results.dig(:query_characteristics, :pattern_issues) || []
+
+        issues.map do |issue|
+          case issue[:type]
+          when "select_star"
+            {
+              type: "optimization",
+              action: "Specify only needed columns instead of SELECT *",
+              benefit: "Reduced memory usage and faster data transfer",
+              priority: "medium",
+              category: "sql_optimization"
+            }
+          when "missing_limit"
+            {
+              type: "optimization",
+              action: "Add LIMIT clause to prevent large result sets",
+              benefit: "Controlled memory usage and faster response times",
+              priority: "high",
+              category: "sql_optimization"
+            }
+          when "missing_where_clause"
+            {
+              type: "optimization",
+              action: "Add WHERE clause to filter results",
+              benefit: "Avoid full table scans and reduce data transfer",
+              priority: "high",
+              category: "sql_optimization"
+            }
+          when "complex_where_clause"
+            {
+              type: "refactoring",
+              action: "Simplify WHERE clause by breaking into multiple queries or using views",
+              benefit: "Easier maintenance and potentially better performance",
+              priority: "medium",
+              category: "code_quality"
+            }
+          end
+        end.compact
+      end
+
+      def generate_index_suggestions
+        recommendations = analysis_results[:index_recommendations] || []
+
+        recommendations.map do |rec|
+          {
+            type: "index",
+            action: "Add #{rec[:type]} index: #{rec[:migration_code]}",
+            benefit: rec[:estimated_benefit],
+            priority: rec[:priority],
+            migration_code: rec[:migration_code],
+            table: rec[:table],
+            columns: rec[:columns],
+            category: "database_optimization"
+          }
+        end
+      end
+
+      def generate_n_plus_one_suggestions
+        n_plus_one = analysis_results[:n_plus_one_analysis] || {}
+        return [] unless n_plus_one[:is_likely_n_plus_one]
+
+        suggestions = n_plus_one[:suggested_fixes] || []
+
+        suggestions.map do |fix|
+          {
+            type: "n_plus_one",
+            action: fix[:description],
+            benefit: "Eliminate N+1 queries and reduce database load",
+            priority: "high",
+            code_example: fix[:code_example],
+            confidence: n_plus_one[:confidence_score],
+            category: "performance_critical"
+          }
+        end
+      end
+
+      def generate_query_characteristic_suggestions
+        stats = analysis_results[:query_characteristics] || {}
+        suggestions = []
+
+        if stats[:join_count] && stats[:join_count] > 3
+          suggestions << {
+            type: "optimization",
+            action: "Review if all #{stats[:join_count]} JOINs are necessary",
+            benefit: "Simplified query execution and better performance",
+            priority: "medium",
+            category: "sql_optimization"
+          }
+        end
+
+        if stats[:estimated_complexity] && stats[:estimated_complexity] > 10
+          suggestions << {
+            type: "refactoring",
+            action: "Consider breaking complex query (complexity: #{stats[:estimated_complexity]}) into smaller parts",
+            benefit: "Easier maintenance and potentially better performance",
+            priority: "medium",
+            category: "code_quality"
+          }
+        end
+
+        if stats[:has_subqueries] && stats[:join_count] && stats[:join_count] > 1
+          suggestions << {
+            type: "optimization",
+            action: "Consider converting subqueries to JOINs for better performance",
+            benefit: "More efficient query execution in most databases",
+            priority: "medium",
+            category: "sql_optimization"
+          }
+        end
+
+        suggestions
+      end
+
+      def generate_explain_plan_suggestions
+        explain_issues = analysis_results.dig(:explain_plan, :issues) || []
+
+        explain_issues.map do |issue|
+          case issue[:type]
+          when "sequential_scan"
+            {
+              type: "index",
+              action: "Consider adding database indexes for WHERE clause columns",
+              benefit: "Dramatically faster query execution",
+              priority: "high",
+              category: "database_optimization"
+            }
+          when "temporary_table"
+            {
+              type: "optimization",
+              action: "Optimize query to avoid temporary tables and filesort operations",
+              benefit: "Reduced memory usage and faster execution",
+              priority: "medium",
+              category: "sql_optimization"
+            }
+          when "high_cost_operation"
+            {
+              type: "optimization",
+              action: "Review query execution plan for high-cost operations",
+              benefit: "Identify specific bottlenecks for targeted optimization",
+              priority: "high",
+              category: "performance_critical"
+            }
+          when "where_without_index"
+            {
+              type: "index",
+              action: "Add indexes to support WHERE clause conditions",
+              benefit: "Eliminate row-by-row filtering during query execution",
+              priority: "high",
+              category: "database_optimization"
+            }
+          end
+        end.compact
+      end
+
+      def prioritize_suggestions(suggestions)
+        # Remove duplicates based on action
+        unique_suggestions = suggestions.uniq { |s| s[:action] }
+
+        # Sort by priority and category
+        unique_suggestions.sort_by do |suggestion|
+          priority_score = case suggestion[:priority]
+          when "high" then 3
+          when "medium" then 2
+          when "low" then 1
+          else 0
+          end
+
+          category_score = case suggestion[:category]
+          when "performance_critical" then 4
+          when "database_optimization" then 3
+          when "sql_optimization" then 2
+          when "code_quality" then 1
+          else 0
+          end
+
+          [ -priority_score, -category_score, suggestion[:action] ]
+        end
+      end
+    end
+  end
+end

data/app/services/rails_pulse/query_analysis_service.rb

@@ -0,0 +1,125 @@
+# Orchestrates comprehensive query analysis using modular analyzers.
+# Coordinates multiple specialized analyzers and consolidates results into actionable insights.
+module RailsPulse
+  class QueryAnalysisService
+    def self.analyze_query(query_id)
+      query = RailsPulse::Query.find(query_id)
+      new(query).analyze
+    end
+
+    def initialize(query)
+      @query = query
+      @operations = fetch_recent_operations
+    end
+
+    def analyze
+      # Run all analyzers
+      results = {
+        analyzed_at: Time.current,
+        query_characteristics: analyze_query_characteristics,
+        index_recommendations: analyze_index_recommendations,
+        n_plus_one_analysis: analyze_n_plus_one,
+        explain_plan: analyze_explain_plan,
+        backtrace_analysis: analyze_backtraces
+      }
+
+      # Generate consolidated suggestions
+      results[:suggestions] = generate_suggestions(results)
+
+      # Build compatible format for query model
+      compatible_results = build_compatible_results(results)
+
+      # Save results to query
+      save_results_to_query(compatible_results)
+
+      results
+    end
+
+    private
+
+    def fetch_recent_operations
+      @query.operations
+            .where("occurred_at > ?", 48.hours.ago)
+            .order(occurred_at: :desc)
+            .limit(50)
+    end
+
+    def analyze_query_characteristics
+      Analysis::QueryCharacteristicsAnalyzer.new(@query, @operations).analyze
+    end
+
+    def analyze_index_recommendations
+      Analysis::IndexRecommendationEngine.new(@query, @operations).analyze
+    end
+
+    def analyze_n_plus_one
+      Analysis::NPlusOneDetector.new(@query, @operations).analyze
+    end
+
+    def analyze_explain_plan
+      return { explain_plan: nil, issues: [] } if @operations.empty?
+      Analysis::ExplainPlanAnalyzer.new(@query, @operations).analyze
+    end
+
+    def analyze_backtraces
+      return {} if @operations.empty?
+      Analysis::BacktraceAnalyzer.new(@query, @operations).analyze
+    end
+
+    def generate_suggestions(analysis_results)
+      Analysis::SuggestionGenerator.new(analysis_results).generate
+    end
+
+    # Build compatible format for query model storage
+    def build_compatible_results(results)
+      characteristics = results[:query_characteristics]
+      explain_result = results[:explain_plan]
+
+      {
+        analyzed_at: results[:analyzed_at],
+        explain_plan: explain_result[:explain_plan],
+        issues: extract_all_issues(characteristics, explain_result),
+        metadata: build_metadata(results),
+        query_stats: extract_query_stats(characteristics),
+        backtrace_analysis: results[:backtrace_analysis],
+        index_recommendations: results[:index_recommendations],
+        n_plus_one_analysis: results[:n_plus_one_analysis],
+        suggestions: results[:suggestions]
+      }
+    end
+
+    def extract_all_issues(characteristics, explain_result)
+      issues = []
+      issues.concat(characteristics[:pattern_issues] || [])
+      issues.concat(explain_result[:issues] || [])
+      issues
+    end
+
+    def extract_query_stats(characteristics)
+      characteristics.except(:pattern_issues)
+    end
+
+    def build_metadata(results)
+      {
+        analyzers_used: results.keys.reject { |k| k.in?([ :analyzed_at, :suggestions ]) },
+        analysis_version: "2.0",
+        total_recommendations: results[:index_recommendations]&.count || 0,
+        n_plus_one_detected: results.dig(:n_plus_one_analysis, :is_likely_n_plus_one) || false
+      }
+    end
+
+    def save_results_to_query(results)
+      @query.update!(
+        analyzed_at: results[:analyzed_at],
+        explain_plan: results[:explain_plan],
+        issues: results[:issues],
+        metadata: results[:metadata],
+        query_stats: results[:query_stats],
+        backtrace_analysis: results[:backtrace_analysis],
+        index_recommendations: results[:index_recommendations],
+        n_plus_one_analysis: results[:n_plus_one_analysis],
+        suggestions: results[:suggestions]
+      )
+    end
+  end
+end

data/app/views/layouts/rails_pulse/_sidebar_menu.html.erb

@@ -5,7 +5,6 @@
     </div>
     <div class="flex flex-col text-start leading-tight overflow-hidden">
       <span class="overflow-ellipsis font-semibold">Rails Pulse</span>
-      <span class="overflow-ellipsis text-xs">Open Source</span>
     </div>
   </a>
 

data/app/views/layouts/rails_pulse/application.html.erb

@@ -22,7 +22,6 @@
         <div class="hide@md" data-controller="rails-pulse--dialog">
           <button type="button" class="btn btn--icon" data-action="rails-pulse--dialog#showModal">
             <%= rails_pulse_icon 'menu', width: '20' %>
-            <span class="sr-only">Open menu</span>
           </button>
 
         <dialog class="sheet sheet--left" style="--sheet-size: 288px;" data-rails-pulse--dialog-target="menu" data-action="click->rails-pulse--dialog#closeOnClickOutside">
@@ -31,7 +30,6 @@
               <%= link_to rails_pulse.root_path, class: "btn sidebar-menu__button" do %>
                 <div class="flex flex-col text-start leading-tight overflow-hidden">
                   <span class="overflow-ellipsis font-semibold">Rails Pulse</span>
-                  <span class="overflow-ellipsis text-xs">Open Source</span>
                 </div>
               <% end %>
               <div class="sidebar-menu__content">

data/app/views/rails_pulse/components/_breadcrumbs.html.erb

@@ -1,4 +1,4 @@
-<nav class="breadcrumb" aria-label="Breadcrumb">
+<nav class="breadcrumb mis-2" aria-label="Breadcrumb">
   <% breadcrumbs.each_with_index do |crumb, index| %>
     <% if crumb[:current] %>
       <span class="text-primary" aria-disabled="true" aria-current="page" role="link"><%= crumb[:title] %></span>

data/app/views/rails_pulse/components/_code_panel.html.erb

@@ -2,11 +2,25 @@
   title ||= nil
 %>
 
-<div>
+<div
+  data-controller="rails-pulse--collapsible"
+  data-rails-pulse--collapsible-collapsed-class="collapsed"
+  class="collapsible-code"
+>
   <% if title %>
-    <h2 class="grow font-semibold leading-none mbe-1 uppercase text-xs"><%= title %></h2>
+    <h2 class="grow font-semibold leading-none mbe-1 uppercase text-xs">
+      <%= title %>
+      <button
+        type="button"
+        class="collapsible-toggle"
+        data-rails-pulse--collapsible-target="toggle"
+        data-action="click->rails-pulse--collapsible#toggle"
+      >
+        show more
+      </button>
+    </h2>
   <% end %>
-  <div class="prose max-i-none">
+  <div class="prose max-i-none" data-rails-pulse--collapsible-target="content">
     <pre class="mbs-0" style="white-space: normal; margin-block-end: 0; margin-block-start: 0;"><code><%= html_escape(value) %></code></pre>
   </div>
 </div>

data/app/views/rails_pulse/components/_empty_state.html.erb

@@ -1,7 +1,7 @@
 <div class="flex items-center justify-center pbs-12 pbe-12 pis-6 pie-6 mb-8">
   <div class="flex items-center gap">
     <div class="shrink-0">
-      <img src="<%= asset_path('search.svg') %>" class="w-32 h-24 opacity-50" alt="No data available" />
+      <img src="<%= asset_path('search.svg') %>" class="w-48 h-48" alt="No data available" />
     </div>
     <div class="text-subtle pis-8">
       <p class="text-lg font-semibold mbe-2"><%= title %></p>

data/app/views/rails_pulse/components/_metric_card.html.erb

@@ -11,12 +11,35 @@
 %>
 <div class="grid-item" data-controller="rails-pulse--chart" id="<%= id %>">
   <%= render 'rails_pulse/components/panel', { title: title, card_classes: 'card-compact' } do %>
-    <div class="row mbs-2" style="height: 50px; margin-bottom: 0;">
+    <div class="row mbs-2" style="--columns: 2; align-items: center; margin-bottom: 0;">
       <div class="grid-item">
         <h4 class="text-xl mbs-1 font-bold"><%= summary %></h4>
       </div>
       <div class="grid-item">
-        <%= line_chart line_chart_data, height: "100%", options: sparkline_chart_options %>
+        <div class="chart-container chart-container--slim">
+          <%
+            # Match chart color to trending icon - use hex equivalents of CSS variables
+            # These colors match the badge colors exactly
+            chart_color = case trend_icon
+            when "trending-up"
+              "#dc2626" # equivalent to --red-600 (negative trend)
+            when "trending-down"
+              "#16a34a" # equivalent to --green-600 (positive trend)
+            else
+              "#ffc91f" # equivalent to --zinc-900 (neutral/primary)
+            end
+
+            chart_options = sparkline_chart_options.deep_merge(
+              color: [chart_color],
+              series: {
+                itemStyle: {
+                  color: chart_color
+                }
+              }
+            )
+          %>
+          <%= bar_chart line_chart_data, height: "100%", options: chart_options %>
+        </div>
       </div>
     </div>
     <div class="mbs-2" style="height: 10px;">
@@ -30,9 +53,9 @@
           end
       %>
       <div class="flex items-center justify-between">
-        <span class="badge <%= badge %> p-0">
+        <span class="badge <%= badge %> badge--trend p-0">
           <%= rails_pulse_icon trend_icon, height: "15px", width: "15px", class: "mie-2" %>
-          <%= trend_amount %>
+          <span class="badge__trend-amount"><%= trend_amount %></span>
           <p class="mis-2 text-subtle text-xs"><%= trend_text %></p>
         </span>
       </div>

data/app/views/rails_pulse/components/_panel.html.erb

@@ -15,7 +15,7 @@
       <% end %>
       <div class="flex gap items-center">
         <% if help_heading %>
-          <div data-controller="rails-pulse--popover" data-rails-pulse--popover-placement-value="bottom-end">
+          <div data-controller="rails-pulse--popover" data-rails-pulse--popover-placement-value="bottom-start">
             <a href="#"
               data-rails-pulse--popover-target="button"
               data-action="rails-pulse--popover#toggle"

data/app/views/rails_pulse/components/_sparkline_stats.html.erb

@@ -1,10 +1,8 @@
-<div class="row mbs-2" style="height: 50px; margin-bottom: 0;">
-  <div class="grid-item">
-    <h4 class="text-xl mbs-1 font-bold"><%= summary %></h4>
-  </div>
-  <div class="grid-item">
-    <%= line_chart line_chart_data, height: "100%", options: sparkline_chart_options %>
-  </div>
+<div class="mbs-2">
+  <h4 class="text-xl mbs-1 font-bold"><%= summary %></h4>
+</div>
+<div class="chart-container chart-container--slim">
+  <%= bar_chart line_chart_data, height: "100%", options: sparkline_chart_options %>
 </div>
 <div>
   <span class="badge badge--<%= trend_direction == "down" ? "positive" : "negative" %>-inverse p-0">

data/app/views/rails_pulse/components/_table_head.html.erb

@@ -8,10 +8,15 @@
           <% sort_params = {} %>
           <% sort_params[:zoom_start_time] = @zoom_start if @zoom_start.present? %>
           <% sort_params[:zoom_end_time] = @zoom_end if @zoom_end.present? %>
+          <% sort_params[:selected_column_time] = params[:selected_column_time] if params[:selected_column_time].present? %>
           <%= sort_link @ransack_query, column[:field], column[:label],
             sort_params.merge(
               class: "flex items-center",
-              data: { turbo_prefetch: "false", turbo_action: "replace" }
+              data: {
+                turbo_prefetch: "false",
+                turbo_frame: "index_table",
+                action: "click->rails-pulse--table-sort#updateUrl"
+              }
             ) %>
         <% end %>
       </th>

data/app/views/rails_pulse/dashboard/index.html.erb

@@ -6,7 +6,7 @@
 </div>
 
 <div class="row">
-  <div class="grid-item" style="height:300px">
+  <div class="grid-item">
     <%= render 'rails_pulse/components/panel', {
       title: 'Average Response Time',
       card_classes: 'b-full',

data/app/views/rails_pulse/operations/show.html.erb

@@ -4,23 +4,25 @@
 
 <div class="card">
   <%= turbo_frame_tag "operation_#{@operation.id}_details" do %>
+    <% if @operation.operation_type == "sql" %>
+      <div class="mbe-4">
+        <%= render 'rails_pulse/components/code_panel', { value: @operation.label } %>
+      </div>
+    <% end %>
+
     <dl class="descriptive-list">
-      <dt>
-        <% if @operation.operation_type == "sql" %>
-          Query
-        <% elsif ["template", "partial", "layout", "collection"].include?(@operation.operation_type) %>
-          View Render
-        <% else %>
-          <%= html_escape(@operation.label) %>
-        <% end %>
-      </dt>
-      <dd>
-        <% if @operation.operation_type == "sql" %>
-          <%= render 'rails_pulse/components/code_panel', { value: @operation.label } %>
-        <% else %>
+      <% if @operation.operation_type != "sql" %>
+        <dt>
+          <% if ["template", "partial", "layout", "collection"].include?(@operation.operation_type) %>
+            View Render
+          <% else %>
+            <%= html_escape(@operation.label) %>
+          <% end %>
+        </dt>
+        <dd>
           <%= html_escape(@operation.label) %>
-        <% end %>
-      </dd>
+        </dd>
+      <% end %>
 
       <dt>Operation Type</dt>
       <dd><pre><%= @operation.operation_type %></pre></dd>

data/app/views/rails_pulse/queries/_analysis_error.html.erb

@@ -0,0 +1,15 @@
+<div class="panel panel--danger">
+  <div>
+    <h3 class="text-sm bold">Analysis Failed</h3>
+    <p class="text-sm mt-1">
+      <%= error_message %>
+    </p>
+    <div class="mt-3">
+      <%= button_to analyze_query_path(query), method: :post,
+          data: { turbo_frame: "query_analysis" },
+          class: "btn btn--sm" do %>
+        Try Again
+      <% end %>
+    </div>
+  </div>
+</div>

data/app/views/rails_pulse/queries/_analysis_prompt.html.erb

@@ -0,0 +1,27 @@
+<div class="center py-4">
+  <h3 class="text-lg mb-2">Analyze Query Performance</h3>
+  <p class="mb-4">
+    Get detailed insights about this query's performance, potential issues, and optimization suggestions.
+  </p>
+
+  <% if query.has_recent_operations? %>
+    <%= button_to analyze_query_path(query), method: :post,
+        data: { turbo_frame: "query_analysis" },
+        class: "btn btn--primary" do %>
+      Analyze Query
+    <% end %>
+
+    <p class="text-sm mt-2">
+      Analysis will examine recent executions and provide performance insights.
+    </p>
+  <% else %>
+    <div class="badge badge--warning p-3 mt-3">
+      <div>
+        <h4 class="text-sm bold">No Recent Data Available</h4>
+        <p class="text-sm mt-1">
+          This query hasn't been executed recently. Analysis requires recent execution data to provide meaningful insights.
+        </p>
+      </div>
+    </div>
+  <% end %>
+</div>