rails_best_practices 1.3.0 → 1.4.0

data/spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 
 describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::AlwaysAddDbIndexReview.new) }
+  let(:runner) { RailsBestPractices::Core::Runner.new(
+    :reviews => RailsBestPractices::Reviews::AlwaysAddDbIndexReview.new
+  ) }
 
   it "should always add db index" do
     content = <<-EOF
@@ -14,6 +16,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(2).errors
     runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (comments => [post_id])"
     runner.errors[1].to_s.should == "db/schema.rb:2 - always add db index (comments => [user_id])"
@@ -30,6 +33,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(1).errors
     runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
   end
@@ -45,6 +49,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(1).errors
     runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (versions => [versioned_id, versioned_type])"
   end
@@ -62,6 +67,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(1).errors
     runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [taggable_id, taggable_type])"
   end
@@ -79,6 +85,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(1).errors
     runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (taggings => [tag_id])"
   end
@@ -95,6 +102,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(1).errors
     runner.errors[0].to_s.should == "db/schema.rb:2 - always add db index (websites => [user_id])"
   end
@@ -109,6 +117,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(0).errors
   end
 
@@ -126,6 +135,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(0).errors
   end
 
@@ -138,6 +148,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(0).errors
   end
 
@@ -154,6 +165,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(0).errors
   end
 
@@ -170,6 +182,7 @@ describe RailsBestPractices::Reviews::AlwaysAddDbIndexReview do
     end
     EOF
     runner.review('db/schema.rb', content)
+    runner.on_complete
     runner.should have(0).errors
   end
 end

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 
 describe RailsBestPractices::Reviews::OveruseRouteCustomizationsReview do
-  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::OveruseRouteCustomizationsReview.new) }
+  let(:runner) { RailsBestPractices::Core::Runner.new(
+    :reviews => RailsBestPractices::Reviews::OveruseRouteCustomizationsReview.new
+  ) }
 
   describe "rails2" do
     it "should overuse route customizations" do
@@ -18,13 +20,27 @@ describe RailsBestPractices::Reviews::OveruseRouteCustomizationsReview do
       runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
     end
 
-    it "should overuse route customizations with collection" do
+    it "should overuse route customizations with member" do
       content = <<-EOF
       ActionController::Routing::Routes.draw do |map|
         map.resources :posts, :member => { :create_comment => :post,
                                            :update_comment => :update,
-                                           :delete_comment => :delete },
-                              :collection => { :comments => :get }
+                                           :delete_comment => :delete,
+                                           :disable_comment => :post }
+      end
+      EOF
+      runner.review('config/routes.rb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "config/routes.rb:2 - overuse route customizations (customize_count > 3)"
+    end
+
+    it "should overuse route customizations with collection" do
+      content = <<-EOF
+      ActionController::Routing::Routes.draw do |map|
+        map.resources :posts, :collection => { :list_comments => :get,
+                                               :update_comments => :get,
+                                               :delete_comments => :get,
+                                               :disable_comments  => :get }
       end
       EOF
       runner.review('config/routes.rb', content)

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -0,0 +1,120 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Reviews::RemoveUnusedMethodsInControllersReview do
+  let(:runner) { RailsBestPractices::Core::Runner.new(
+    :prepares => [RailsBestPractices::Prepares::ControllerPrepare.new, RailsBestPractices::Prepares::RoutePrepare.new],
+    :reviews => RailsBestPractices::Reviews::RemoveUnusedMethodsInControllersReview.new({'except_methods' => []})
+  ) }
+
+  context "private/protected" do
+    it "should remove unused methods" do
+      content =<<-EOF
+      RailsBestPracticesCom::Application.routes.draw do
+        resources :posts
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      content =<<-EOF
+      class PostsController < ActiveRecord::Base
+        def show; end
+        protected
+        def load_post; end
+        private
+        def load_user; end
+      end
+      EOF
+      runner.prepare('app/controllers/posts_controller.rb', content)
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.on_complete
+      runner.should have(2).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:4 - remove unused methods (PostsController#load_post)"
+      runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:6 - remove unused methods (PostsController#load_user)"
+    end
+
+    it "should not remove unused methods for before_filter" do
+      content =<<-EOF
+      RailsBestPracticesCom::Application.routes.draw do
+        resources :posts
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      content =<<-EOF
+      class PostsController < ActiveRecord::Base
+        before_filter :load_post, :load_user
+        def show; end
+        protected
+        def load_post; end
+        def load_user; end
+      end
+      EOF
+      runner.prepare('app/controllers/posts_controller.rb', content)
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.on_complete
+      runner.should have(0).errors
+    end
+
+    it "should not remove inherited_resources methods" do
+      content =<<-EOF
+      RailsBestPracticesCom::Application.routes.draw do
+        resources :posts
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      content =<<-EOF
+      class PostsController < InheritedResources::Base
+        def show; end
+        protected
+        def resource; end
+        def collection; end
+        def begin_of_association_chain; end
+      end
+      EOF
+      runner.prepare('app/controllers/posts_controller.rb', content)
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.on_complete
+      runner.should have(0).errors
+    end
+  end
+
+  context "public" do
+    it "should remove unused methods" do
+      content =<<-EOF
+      RailsBestPracticesCom::Application.routes.draw do
+        resources :posts
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      content =<<-EOF
+      class PostsController < ApplicationController
+        def show; end
+        def list; end
+      end
+      EOF
+      runner.prepare('app/controllers/posts_controller.rb', content)
+      runner.review('app/controllers/posts_controller.rb', content)
+      runner.on_complete
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - remove unused methods (PostsController#list)"
+    end
+
+    it "should not remove unused methods if all actions are used in route" do
+      content =<<-EOF
+      ActionController::Routing::Routes.draw do |map|
+        map.connect 'internal/:action/*whatever', :controller => "internal"
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      content =<<-EOF
+      class InternalController < ApplicationController
+        def list; end
+        def delete; end
+        def whatever; end
+      end
+      EOF
+      runner.prepare('app/controllers/internal_controller.rb', content)
+      runner.review('app/controllers/internal_controller.rb', content)
+      runner.on_complete
+      runner.should have(0).errors
+    end
+  end
+end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview do
   let(:runner) { RailsBestPractices::Core::Runner.new(
-    :prepares => [RailsBestPractices::Prepares::ModelPrepare.new, RailsBestPractices::Prepares::ControllerPrepare.new],
+    :prepares => RailsBestPractices::Prepares::ModelPrepare.new,
     :reviews => RailsBestPractices::Reviews::RemoveUnusedMethodsInModelsReview.new({'except_methods' => ['set_cache']})
   ) }
 

metadata

@@ -1,149 +1,145 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: rails_best_practices
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 1.4.0
   prerelease: 
-  version: 1.3.0
 platform: ruby
-authors: 
+authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-11-13 00:00:00 +08:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-11-20 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: sexp_processor
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2152381700 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152381700
+- !ruby/object:Gem::Dependency
   name: progressbar
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &2152380940 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152380940
+- !ruby/object:Gem::Dependency
   name: colored
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &2152380200 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152380200
+- !ruby/object:Gem::Dependency
   name: erubis
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &2152379500 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152379500
+- !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &2152378620 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152378620
+- !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &2152373900 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152373900
+- !ruby/object:Gem::Dependency
   name: rake
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: &2152373120 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id007
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152373120
+- !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  requirement: &2152372280 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id008
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152372280
+- !ruby/object:Gem::Dependency
   name: watchr
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: &2152371480 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id009
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152371480
+- !ruby/object:Gem::Dependency
   name: haml
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  requirement: &2152370380 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id010
-- !ruby/object:Gem::Dependency 
+  version_requirements: *2152370380
+- !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &id011 !ruby/object:Gem::Requirement 
+  requirement: &2152369500 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id011
+  version_requirements: *2152369500
 description: a code metric tool for rails codes, written in Ruby.
-email: 
+email:
 - flyerhzm@gmail.com
-executables: 
+executables:
 - rails_best_practices
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gemtest
 - .gitignore
 - .rspec.example
@@ -174,6 +170,7 @@ files:
 - lib/rails_best_practices/core/model_attributes.rb
 - lib/rails_best_practices/core/models.rb
 - lib/rails_best_practices/core/nil.rb
+- lib/rails_best_practices/core/routes.rb
 - lib/rails_best_practices/core/runner.rb
 - lib/rails_best_practices/core_ext/enumerable.rb
 - lib/rails_best_practices/core_ext/sexp.rb
@@ -184,6 +181,7 @@ files:
 - lib/rails_best_practices/prepares/controller_prepare.rb
 - lib/rails_best_practices/prepares/mailer_prepare.rb
 - lib/rails_best_practices/prepares/model_prepare.rb
+- lib/rails_best_practices/prepares/route_prepare.rb
 - lib/rails_best_practices/prepares/schema_prepare.rb
 - lib/rails_best_practices/reviews.rb
 - lib/rails_best_practices/reviews/add_model_virtual_attribute_review.rb
@@ -201,6 +199,7 @@ files:
 - lib/rails_best_practices/reviews/not_use_default_route_review.rb
 - lib/rails_best_practices/reviews/overuse_route_customizations_review.rb
 - lib/rails_best_practices/reviews/remove_empty_helpers_review.rb
+- lib/rails_best_practices/reviews/remove_unused_methods_in_controllers_review.rb
 - lib/rails_best_practices/reviews/remove_unused_methods_in_models_review.rb
 - lib/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review.rb
 - lib/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review.rb
@@ -231,6 +230,7 @@ files:
 - spec/rails_best_practices/core/model_attributes_spec.rb
 - spec/rails_best_practices/core/models_spec.rb
 - spec/rails_best_practices/core/nil_spec.rb
+- spec/rails_best_practices/core/routes_spec.rb
 - spec/rails_best_practices/core/runner_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
 - spec/rails_best_practices/core_ext/sexp_spec.rb
@@ -239,6 +239,7 @@ files:
 - spec/rails_best_practices/prepares/controller_prepare_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
+- spec/rails_best_practices/prepares/route_prepare_spec.rb
 - spec/rails_best_practices/prepares/schema_prepare_spec.rb
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
@@ -255,6 +256,7 @@ files:
 - spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb
 - spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb
 - spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb
+- spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb
 - spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb
 - spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb
 - spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb
@@ -270,52 +272,37 @@ files:
 - spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
 - spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: http://rails-bestpractices.com
 licenses: []
-
-post_install_message: |
-  ********************************************************************************
-  
-    rails_best_practices is a code metric tool to check the quality of rails codes.
-  
-    I highly recommend you browse the Rails Best Practices website first.
-  
-        http://rails-bestpractices.com
-  
-    Enjoy!
-  
-        Richard Huang (flyerhzm@gmail.com)
-  
-  ********************************************************************************
-
+post_install_message: ! "********************************************************************************\n\n
+  \ rails_best_practices is a code metric tool to check the quality of rails codes.\n\n
+  \ I highly recommend you browse the Rails Best Practices website first.\n\n      http://rails-bestpractices.com\n\n
+  \ Enjoy!\n\n      Richard Huang (flyerhzm@gmail.com)\n\n********************************************************************************\n"
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3527788243321139328
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: 1634590398891543727
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: a code metric tool for rails codes.
-test_files: 
+test_files:
 - spec/fixtures/lib/rails_best_practices/plugins/reviews/not_use_rails_root_review.rb
 - spec/rails_best_practices/core/check_spec.rb
 - spec/rails_best_practices/core/checking_visitor_spec.rb
@@ -328,6 +315,7 @@ test_files:
 - spec/rails_best_practices/core/model_attributes_spec.rb
 - spec/rails_best_practices/core/models_spec.rb
 - spec/rails_best_practices/core/nil_spec.rb
+- spec/rails_best_practices/core/routes_spec.rb
 - spec/rails_best_practices/core/runner_spec.rb
 - spec/rails_best_practices/core_ext/enumerable_spec.rb
 - spec/rails_best_practices/core_ext/sexp_spec.rb
@@ -336,6 +324,7 @@ test_files:
 - spec/rails_best_practices/prepares/controller_prepare_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
+- spec/rails_best_practices/prepares/route_prepare_spec.rb
 - spec/rails_best_practices/prepares/schema_prepare_spec.rb
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
@@ -352,6 +341,7 @@ test_files:
 - spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb
 - spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb
 - spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb
+- spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb
 - spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb
 - spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb
 - spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb