rails_best_practices 1.3.0 → 1.4.0

data/lib/rails_best_practices/reviews/restrict_auto_generated_routes_review.rb

@@ -15,6 +15,9 @@ module RailsBestPractices
     #   if there is a route generated, but there is not action in that controller,
     #   then you should restrict your routes.
     class RestrictAutoGeneratedRoutesReview < Review
+      interesting_nodes :command, :command_call, :method_add_block
+      interesting_files ROUTE_FILES
+
       RESOURCE_METHODS = ["show", "new", "create", "edit", "update", "destroy"]
       RESOURCES_METHODS = RESOURCE_METHODS + ["index"]
 
@@ -22,14 +25,6 @@ module RailsBestPractices
         "http://rails-bestpractices.com/posts/86-restrict-auto-generated-routes"
       end
 
-      def interesting_nodes
-        [:command, :command_call, :method_add_block]
-      end
-
-      def interesting_files
-        ROUTE_FILES
-      end
-
       def initialize
         super
         @namespaces = []

data/lib/rails_best_practices/reviews/simplify_render_in_controllers_review.rb

@@ -14,18 +14,13 @@ module RailsBestPractices
     #   if there is a key 'action', 'template' or 'file' in the argument,
     #   then they should be replaced by simplified syntax.
     class SimplifyRenderInControllersReview < Review
+      interesting_nodes :command
+      interesting_files CONTROLLER_FILES
+
       def url
         "http://rails-bestpractices.com/posts/62-simplify-render-in-controllers"
       end
 
-      def interesting_nodes
-        [:command]
-      end
-
-      def interesting_files
-        CONTROLLER_FILES
-      end
-
       # check command node in the controller file,
       # if its message is render and the arguments contain a key action, template or file,
       # then it should be replaced by simplified syntax.

data/lib/rails_best_practices/reviews/simplify_render_in_views_review.rb

@@ -13,18 +13,13 @@ module RailsBestPractices
     #   check all render method commands in view files,
     #   if there is a key 'partial' in the argument, then they should be replaced by simplified syntax.
     class SimplifyRenderInViewsReview < Review
+      interesting_nodes :command
+      interesting_files VIEW_FILES
+
       def url
         "http://rails-bestpractices.com/posts/61-simplify-render-in-views"
       end
 
-      def interesting_nodes
-        [:command]
-      end
-
-      def interesting_files
-        VIEW_FILES
-      end
-
       # check command node in view file,
       # if its message is render and the arguments contain a key partial,
       # then it should be replaced by simplified syntax.

data/lib/rails_best_practices/reviews/use_before_filter_review.rb

@@ -13,18 +13,13 @@ module RailsBestPractices
     #   check all first code line in method definitions (actions),
     #   if they are duplicated, then they should be moved to before_filter.
     class UseBeforeFilterReview < Review
+      interesting_nodes :class
+      interesting_files CONTROLLER_FILES
+
       def url
         "http://rails-bestpractices.com/posts/22-use-before_filter"
       end
 
-      def interesting_nodes
-        [:class]
-      end
-
-      def interesting_files
-        CONTROLLER_FILES
-      end
-
       def initialize(options = {})
         super()
         @customize_count = options['customize_count'] || 2

data/lib/rails_best_practices/reviews/use_model_association_review.rb

@@ -16,18 +16,13 @@ module RailsBestPractices
     #   and the subjects of attribute assignment node and call node are the same,
     #   then model association should be used instead of xxx_id assignment.
     class UseModelAssociationReview < Review
+      interesting_nodes :def
+      interesting_files CONTROLLER_FILES
+
       def url
         "http://rails-bestpractices.com/posts/2-use-model-association"
       end
 
-      def interesting_nodes
-        [:def]
-      end
-
-      def interesting_files
-        CONTROLLER_FILES
-      end
-
       # check method define nodes to see if there are some attribute assignments that can use model association instead.
       #
       # it will check attribute assignment node with message xxx_id=, and call node with message "save" or "save!"

data/lib/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review.rb

@@ -14,18 +14,13 @@ module RailsBestPractices
     #   check class node to remember the class name,
     #   and check the method definition nodes to see if the corresponding mailer views exist or not.
     class UseMultipartAlternativeAsContentTypeOfEmailReview < Review
+      interesting_nodes :class, :def
+      interesting_files MAILER_FILES
+
       def url
         "http://rails-bestpractices.com/posts/41-use-multipart-alternative-as-content_type-of-email"
       end
 
-      def interesting_nodes
-        [:class, :def]
-      end
-
-      def interesting_files
-        MAILER_FILES
-      end
-
       # check class node to remember the ActionMailer class name.
       def start_class(node)
         @klazz_name = node.class_name.to_s

data/lib/rails_best_practices/reviews/use_observer_review.rb

@@ -20,18 +20,13 @@ module RailsBestPractices
     #   and there is a mailer deliver call,
     #   then the method should be replaced by using observer.
     class UseObserverReview < Review
+      interesting_nodes :def, :command
+      interesting_files MODEL_FILES
+
       def url
         "http://rails-bestpractices.com/posts/19-use-observer"
       end
 
-      def interesting_nodes
-        [:def, :command]
-      end
-
-      def interesting_files
-        MODEL_FILES
-      end
-
       def initialize
         super
         @callbacks = []

data/lib/rails_best_practices/reviews/use_query_attribute_review.rb

@@ -16,6 +16,8 @@ module RailsBestPractices
     #   and their messages of second call are one of nil?, blank?, present?, or they are == ""
     #   then you can use query attribute instead.
     class UseQueryAttributeReview < Review
+      interesting_nodes :if, :unless, :elsif
+      interesting_files ALL_FILES
 
       QUERY_METHODS = %w(nil? blank? present?)
 
@@ -23,10 +25,6 @@ module RailsBestPractices
         "http://rails-bestpractices.com/posts/56-use-query-attribute"
       end
 
-      def interesting_nodes
-        [:if, :unless, :elsif]
-      end
-
       # check if node to see whose conditional statement nodes contain nodes that can use query attribute instead.
       #
       # it will check every call nodes in the if nodes. If the call node is

data/lib/rails_best_practices/reviews/use_say_with_time_in_migrations_review.rb

@@ -15,6 +15,8 @@ module RailsBestPractices
     #   and the message of method call is not say, say_with_time and default migration methods (such as add_column and create_table),
     #   then the method call should be wrapped by say or say_with_time.
     class UseSayWithTimeInMigrationsReview < Review
+      interesting_nodes :defs
+      interesting_files MIGRATION_FILES
 
       WITH_SAY_METHODS = %w(say say_with_time)
 
@@ -22,14 +24,6 @@ module RailsBestPractices
         "http://rails-bestpractices.com/posts/46-use-say-and-say_with_time-in-migrations-to-make-a-useful-migration-log"
       end
 
-      def interesting_nodes
-        [:defs]
-      end
-
-      def interesting_files
-        MIGRATION_FILES
-      end
-
       # check a class method define node to see if there are method calls that need to be wrapped by say or say_with_time.
       #
       # it will check the first block node,

data/lib/rails_best_practices/reviews/use_scope_access_review.rb

@@ -16,18 +16,13 @@ module RailsBestPractices
     #   and there is redirect_to method call in if block body,
     #   then it should be replaced by using scope access.
     class UseScopeAccessReview < Review
+      interesting_nodes :if, :unless, :elsif
+      interesting_files CONTROLLER_FILES
+
       def url
         "http://rails-bestpractices.com/posts/3-use-scope-access"
       end
 
-      def interesting_nodes
-        [:if, :unless, :elsif]
-      end
-
-      def interesting_files
-        CONTROLLER_FILES
-      end
-
       # check if node.
       #
       # if it is a method call compared with current_user or current_user.id,

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
 end

data/rails_best_practices.yml

@@ -28,3 +28,4 @@ RemoveEmptyHelpersCheck: { }
 RemoveTabCheck: { }
 RestrictAutoGeneratedRoutesCheck: { }
 RemoveUnusedMethodsInModelsCheck: { except_methods: [] }
+RemoveUnusedMethodsInControllersCheck: { except_methods: [] }

data/spec/rails_best_practices/core/check_spec.rb

@@ -7,8 +7,8 @@ describe RailsBestPractices::Core::Check do
     check.interesting_nodes.should == []
   end
 
-  it "should match all files of interesting files" do
-    check.interesting_files.should == /.*/
+  it "should match none of interesting files" do
+    check.interesting_files.should == []
   end
 
   context "node_start" do

data/spec/rails_best_practices/core/checking_visitor_spec.rb

@@ -5,44 +5,24 @@ class TestLexical1
 end
 class TestLexical2
 end
-class TestPrepare1
-  def interesting_nodes
-    [:call]
-  end
-
-  def interesting_files
-    RailsBestPractices::Core::Check::MODEL_FILES
-  end
+class TestPrepare1 < RailsBestPractices::Core::Check
+  interesting_nodes :call
+  interesting_files MODEL_FILES
 end
 
-class TestPrepare2
-  def interesting_nodes
-    [:class]
-  end
-
-  def interesting_files
-    RailsBestPractices::Core::Check::MAILER_FILES
-  end
+class TestPrepare2 < RailsBestPractices::Core::Check
+  interesting_nodes :class
+  interesting_files MAILER_FILES
 end
 
-class TestReview1
-  def interesting_nodes
-    [:defn]
-  end
-
-  def interesting_files
-    RailsBestPractices::Core::Check::CONTROLLER_FILES
-  end
+class TestReview1 < RailsBestPractices::Core::Check
+  interesting_nodes :defn
+  interesting_files CONTROLLER_FILES
 end
 
-class TestReview2
-  def interesting_nodes
-    [:call]
-  end
-
-  def interesting_files
-    RailsBestPractices::Core::Check::VIEW_FILES
-  end
+class TestReview2 < RailsBestPractices::Core::Check
+  interesting_nodes :call
+  interesting_files VIEW_FILES
 end
 
 describe RailsBestPractices::Core::CheckingVisitor do

data/spec/rails_best_practices/core/nil_spec.rb

@@ -20,4 +20,16 @@ describe RailsBestPractices::Core::Nil do
       core_nil.undefined.should == core_nil
     end
   end
+
+  context "present?" do
+    it "should return false" do
+      core_nil.should_not be_present
+    end
+  end
+
+  context "blank?" do
+    it "should return true" do
+      core_nil.should be_blank
+    end
+  end
 end

data/spec/rails_best_practices/core/routes_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Core::Routes do
+  let(:routes) { RailsBestPractices::Core::Routes.new }
+
+  it "should add route" do
+    routes.add_route(["admin", "test"], "posts", "new")
+    routes.map(&:to_s).should == ["Admin::Test::PostsController#new"]
+  end
+end

data/spec/rails_best_practices/core_ext/sexp_spec.rb

@@ -523,6 +523,20 @@ describe Sexp do
     end
   end
 
+  describe "present?" do
+    it "should return true" do
+      node = parse_content("hello world")
+      node.should be_present
+    end
+  end
+
+  describe "blank?" do
+    it "should return false" do
+      node = parse_content("hello world")
+      node.should_not be_blank
+    end
+  end
+
   describe "remove_line_and_column" do
     it "should remove" do
       s(:@ident, "test", s(2, 12)).remove_line_and_column.should_equal s(:@ident, "test")

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -0,0 +1,502 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Prepares::RoutePrepare do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:prepares => RailsBestPractices::Prepares::RoutePrepare.new) }
+
+  context "rails2" do
+    context "resources" do
+      it "should add resources route" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 7
+        routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+      end
+
+      it "should add multiple resources route" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :users
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 14
+      end
+
+      it "should add resources route with explict controller" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :controller => :blog_posts
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 7
+        routes.map(&:to_s).should == ["BlogPostsController#index", "BlogPostsController#show", "BlogPostsController#new", "BlogPostsController#create", "BlogPostsController#edit", "BlogPostsController#update", "BlogPostsController#destroy"]
+      end
+
+      it "should add resources route with only option" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :only => [:index, :show, :new, :create]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 4
+        routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should add resources route with except option" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :except => [:edit, :update, :destroy]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 4
+        routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should not add resources routes with :only => :none" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :only => :none
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should not add resources routes with :except => :all" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :except => :all
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should add resource routes with hash collection/member routes" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :only => [:show], :collection => { :list => :get }, :member => { :create => :post, :update => :put, :destroy => :delete }
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 5
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "PostsController#list"]
+      end
+
+      it "should add resource routes with array collection/member routes" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts, :only => [:show], :collection => [:list], :member => [:create, :update, :destroy]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 5
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "PostsController#list"]
+      end
+
+      it "should add route with nested routes" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resources :posts do |post|
+            post.resources :comments
+          end
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 14
+      end
+
+      it "should add rout with namespace" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.namespace :admin do |admin|
+            admin.namespace :test do |test|
+              test.resources :posts, :only => [:index]
+            end
+          end
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["Admin::Test::PostsController#index"]
+      end
+    end
+
+    context "resource" do
+      it "should add resource route" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resource :posts
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 6
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+      end
+
+      it "should add multiple resource route" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resource :posts, :users
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 12
+      end
+
+      it "should add resource route with only option" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resource :posts, :only => [:show, :new, :create]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 3
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should add resource route with except option" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resource :posts, :except => [:edit, :update, :destroy]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 3
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should not add resource routes with :only => :none" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resource :posts, :only => :none
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should not add resource routes with :except => :all" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.resource :posts, :except => :all
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+    end
+
+    it "should add connect route" do
+      content =<<-EOF
+      ActionController::Routing::Routes.draw do |map|
+        map.connect 'vote', :controller => "votes", :action => "create", :method => :post
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      routes = RailsBestPractices::Prepares.routes
+      routes.map(&:to_s).should == ["VotesController#create"]
+    end
+
+    it "should add connect route with all actions" do
+      content =<<-EOF
+      ActionController::Routing::Routes.draw do |map|
+        map.connect 'internal/:action/*whatever', :controller => "internal"
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      routes = RailsBestPractices::Prepares.routes
+      routes.map(&:to_s).should == ["InternalController#*"]
+    end
+
+    it "should add named route" do
+      content =<<-EOF
+      ActionController::Routing::Routes.draw do |map|
+        map.login '/player/login', :controller => 'sessions', :action => 'new', :conditions => { :method => :get }
+      end
+      EOF
+      runner.prepare('config/routes.rb', content)
+      routes = RailsBestPractices::Prepares.routes
+      routes.map(&:to_s).should == ["SessionsController#new"]
+    end
+  end
+
+  context "rails3" do
+    context "resources" do
+      it "should add resources route" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 7
+        routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+      end
+
+      it "should add multiple resources route" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :users
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 14
+      end
+
+      it "should add resources route with explict controller" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :controller => :blog_posts
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 7
+        routes.map(&:to_s).should == ["BlogPostsController#index", "BlogPostsController#show", "BlogPostsController#new", "BlogPostsController#create", "BlogPostsController#edit", "BlogPostsController#update", "BlogPostsController#destroy"]
+      end
+
+      it "should add resources route with only option" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :only => [:index, :show, :new, :create]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 4
+        routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should add resources route with except option" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :except => [:edit, :update, :destroy]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 4
+        routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should not add resources routes with :only => :none" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :only => :none
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should not add resources routes with :except => :all" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :except => :all
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should add connect route" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.connect 'vote', :controller => "votes", :action => "create", :method => :post
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["VotesController#create"]
+      end
+
+      it "should add named route" do
+        content =<<-EOF
+        ActionController::Routing::Routes.draw do |map|
+          map.login '/player/login', :controller => 'sessions', :action => 'new', :conditions => { :method => :get }
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["SessionsController#new"]
+      end
+    end
+
+    context "resource" do
+      it "should add resource route" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resource :posts
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 6
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+      end
+
+      it "should add multiple resource route" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resource :posts, :users
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 12
+      end
+
+      it "should add resource route with only option" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resource :posts, :only => [:show, :new, :create]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 3
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should add resource route with except option" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resource :posts, :except => [:edit, :update, :destroy]
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 3
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+      end
+
+      it "should not add resource routes with :only => :none" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resource :posts, :only => :none
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should not add resource routes with :except => :all" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resource :posts, :except => :all
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 0
+      end
+
+      it "should add resource routes with get/post/put/delete routes" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts, :only => [:show] do
+            get :list, :on => :collection
+            post :create, :on => :member
+            put :update, :on => :member
+            delete :destroy, :on => :memeber
+          end
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 5
+        routes.map(&:to_s).should == ["PostsController#show", "PostsController#list", "PostsController#create", "PostsController#update", "PostsController#destroy"]
+      end
+
+      it "should add route with nested routes" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          resources :posts
+            resources :comments
+          end
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.size.should == 14
+      end
+
+      it "should add rout with namespace" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          namespace :admin do
+            namespace :test do
+              resources :posts, :only => [:index]
+            end
+          end
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["Admin::Test::PostsController#index"]
+      end
+
+      it "should add match route" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          match '/auth/:provider/callback' => 'authentications#create'
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["AuthenticationsController#create"]
+      end
+
+      it "should add match route with all actions" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          match 'internal/:action/*whatever', :controller => "internal"
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["InternalController#*"]
+      end
+
+      it "should add root route" do
+        content =<<-EOF
+        RailsBestPracticesCom::Application.routes.draw do
+          root :to => 'home#index'
+        end
+        EOF
+        runner.prepare('config/routes.rb', content)
+        routes = RailsBestPractices::Prepares.routes
+        routes.map(&:to_s).should == ["HomeController#index"]
+      end
+    end
+  end
+end