rails_best_practices 1.18.1 → 1.19.0

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -11,142 +11,10 @@ module RailsBestPractices
         allow(Dir).to receive(:entries).with("./app/views/project_mailer").and_return(entry_files)
       end
 
-      context "rails2" do
-        before do
-        content = <<-EOF
+      before do
+      content = <<-EOF
 GEM
-  remote: http://rubygems.org
-  specs:
-    rails (2.3.14)
-      actionmailer (= 2.3.14)
-      actionpack (= 2.3.14)
-      activerecord (= 2.3.14)
-      activeresource (= 2.3.14)
-      activesupport (= 2.3.14)
-      bundler (~> 1.0)
-      railties (= 2.3.14)
-        EOF
-        runner.prepare('Gemfile.lock', content)
-        end
-
-        context "project_mailer" do
-          let(:content) {
-            <<-EOF
-            class ProjectMailer < ActionMailer::Base
-              def send_email(email)
-                receiver      email.receiver
-                from          email.from
-                recipients    email.recipients
-                sent_on       Time.now
-                body          email: email
-              end
-            end
-            EOF
-          }
-
-          context "erb" do
-            it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(1)
-              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
-            end
-
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.plain.erb", "send_email.text.html.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-          end
-
-          context "haml" do
-            it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(1)
-              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
-            end
-
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.plain.haml", "send_email.text.html.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-          end
-
-          context "slim" do
-            it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.slim"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(1)
-              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
-            end
-
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.slim"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.plain.slim", "send_email.text.html.slim"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-          end
-
-          context "rhtml" do
-            it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.rhtml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(1)
-              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
-            end
-
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.rhtml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.plain.rhtml", "send_email.text.html.rhtml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
-          end
-        end
-
-        it "should not use mulipart/alternative as content_type of email for non deliver method" do
-          content =<<-EOF
-          class ProjectMailer < ActionMailer::Base
-            def no_deliver
-            end
-          end
-          EOF
-          mock_email_files([])
-          runner.review('app/mailers/project_mailer.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
-      end
-
-      context "rails3" do
-        before do
-        content = <<-EOF
-GEM
-  remote: http://rubygems.org
+  remote: https://rubygems.org
   specs:
     rails (3.2.13)
       actionmailer (= 3.2.13)
@@ -156,98 +24,97 @@ GEM
       activesupport (= 3.2.13)
       bundler (~> 1.0)
       railties (= 3.2.13)
-        EOF
-        runner.prepare('Gemfile.lock', content)
-        end
-
-        context "project_mailer" do
-          let(:content) {
-            <<-EOF
-            class ProjectMailer < ActionMailer::Base
-              def send_email(email)
-                receiver      email.receiver
-                from          email.from
-                recipients    email.recipients
-                sent_on       Time.now
-                body          email: email
-              end
-            end
-            EOF
-          }
-
-          context "erb" do
-            it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(1)
-              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
-            end
+      EOF
+      runner.prepare('Gemfile.lock', content)
+      end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
+      context "project_mailer" do
+        let(:content) {
+          <<-EOF
+          class ProjectMailer < ActionMailer::Base
+            def send_email(email)
+              receiver      email.receiver
+              from          email.from
+              recipients    email.recipients
+              sent_on       Time.now
+              body          email: email
             end
+          end
+          EOF
+        }
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.erb", "send_email.html.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
+        context "erb" do
+          it "should use mulipart/alternative as content_type of email" do
+            mock_email_files(["send_email.html.erb"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(1)
+            expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
           end
 
-          context "haml" do
-            it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(1)
-              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
-            end
+          it "should not use multiple/alternative as content_type of email when only plain text" do
+            mock_email_files(["send_email.text.erb"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
+          end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
+          it "should not use multipart/alternative as content_type of email" do
+            mock_email_files(["send_email.text.erb", "send_email.html.erb"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
+          end
+        end
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.haml", "send_email.text.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
+        context "haml" do
+          it "should use mulipart/alternative as content_type of email" do
+            mock_email_files(["send_email.html.haml"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(1)
+            expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
+          end
 
-            it "should not use multipart/alternative as content_type of email with text locale" do
-              mock_email_files(["send_email.html.haml", "send_email.de.text.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
+          it "should not use multiple/alternative as content_type of email when only plain text" do
+            mock_email_files(["send_email.text.haml"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
+          end
 
-            it "should not use multipart/alternative as content_type of email with html locale" do
-              mock_email_files(["send_email.de.html.haml", "send_email.text.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
+          it "should not use multipart/alternative as content_type of email" do
+            mock_email_files(["send_email.html.haml", "send_email.text.haml"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
           end
 
-          context "haml/erb mix" do
-            it "should not suggest using multipart/alternative when mixing html.haml and text.erb" do
-              mock_email_files(["send_email.html.haml", "send_email.text.erb"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
+          it "should not use multipart/alternative as content_type of email with text locale" do
+            mock_email_files(["send_email.html.haml", "send_email.de.text.haml"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
+          end
 
-              mock_email_files(["send_email.html.erb", "send_email.text.haml"])
-              runner.review('app/mailers/project_mailer.rb', content)
-              expect(runner.errors.size).to eq(0)
-            end
+          it "should not use multipart/alternative as content_type of email with html locale" do
+            mock_email_files(["send_email.de.html.haml", "send_email.text.haml"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
           end
+        end
 
-          it "should not check ignored files" do
-            runner = Core::Runner.new(reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new(ignored_files: /project_mailer/))
-            mock_email_files(["send_email.html.haml"])
+        context "haml/erb mix" do
+          it "should not suggest using multipart/alternative when mixing html.haml and text.erb" do
+            mock_email_files(["send_email.html.haml", "send_email.text.erb"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
+
+            mock_email_files(["send_email.html.erb", "send_email.text.haml"])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
         end
+
+        it "should not check ignored files" do
+          runner = Core::Runner.new(reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new(ignored_files: /project_mailer/))
+          mock_email_files(["send_email.html.haml"])
+          runner.review('app/mailers/project_mailer.rb', content)
+          expect(runner.errors.size).to eq(0)
+        end
       end
     end
   end

data/spec/rails_best_practices/reviews/use_observer_review_spec.rb

@@ -13,134 +13,67 @@ module RailsBestPractices
         runner.prepare('app/models/project_mailer.rb', content)
       end
 
-      describe "rails2" do
-        it "should use observer" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            after_create :send_create_notification
-
-            private
-            def send_create_notification
-              self.members.each do |member|
-                ProjectMailer.deliver_notification(self, member)
-              end
-            end
-          end
-          EOF
-          runner.review('app/models/project.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
-        end
+      it "should use observer" do
+        content =<<-EOF
+        class Project < ActiveRecord::Base
+          after_create :send_create_notification
 
-        it "should not use observer without callback" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            private
-            def send_create_notification
-              self.members.each do |member|
-                ProjectMailer.deliver_notification(self, member)
-              end
+          private
+          def send_create_notification
+            self.members.each do |member|
+              ProjectMailer.notification(self, member).deliver
             end
           end
-          EOF
-          runner.review('app/models/project.rb', content)
-          expect(runner.errors.size).to eq(0)
         end
+        EOF
+        runner.review('app/models/project.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
+      end
 
-        it "should use observer with two after_create" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            after_create :send_create_notification, :update_author
-
-            private
-            def send_create_notification
-              self.members.each do |member|
-                ProjectMailer.deliver_notification(self, member)
-              end
-            end
-
-            def update_author
+      it "should not use observer without callback" do
+        content =<<-EOF
+        class Project < ActiveRecord::Base
+          private
+          def send_create_notification
+            self.members.each do |member|
+              ProjectMailer.notification(self, member).deliver
             end
           end
-          EOF
-          runner.review('app/models/project.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
-        end
-
-        it "should not raise when initiate an object in callback" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            after_create ProjectMailer.new
-          end
-          EOF
-          expect { runner.review('app/models/project.rb', content) }.not_to raise_error
         end
+        EOF
+        runner.review('app/models/project.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
 
-      describe "rails3" do
-        it "should use observer" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            after_create :send_create_notification
+      it "should use observer with two after_create" do
+        content =<<-EOF
+        class Project < ActiveRecord::Base
+          after_create :send_create_notification, :update_author
 
-            private
-            def send_create_notification
-              self.members.each do |member|
-                ProjectMailer.notification(self, member).deliver
-              end
+          private
+          def send_create_notification
+            self.members.each do |member|
+              ProjectMailer.notification(self, member).deliver
             end
           end
-          EOF
-          runner.review('app/models/project.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
-        end
 
-        it "should not use observer without callback" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            private
-            def send_create_notification
-              self.members.each do |member|
-                ProjectMailer.notification(self, member).deliver
-              end
-            end
+          def update_author
           end
-          EOF
-          runner.review('app/models/project.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
-
-        it "should use observer with two after_create" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            after_create :send_create_notification, :update_author
-
-            private
-            def send_create_notification
-              self.members.each do |member|
-                ProjectMailer.notification(self, member).deliver
-              end
-            end
-
-            def update_author
-            end
-          end
-          EOF
-          runner.review('app/models/project.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
         end
+        EOF
+        runner.review('app/models/project.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
+      end
 
-        it "should not raise when initiate an object in callback" do
-          content =<<-EOF
-          class Project < ActiveRecord::Base
-            after_create ProjectMailer.new
-          end
-          EOF
-          expect { runner.review('app/models/project.rb', content) }.not_to raise_error
+      it "should not raise when initiate an object in callback" do
+        content =<<-EOF
+        class Project < ActiveRecord::Base
+          after_create ProjectMailer.new
         end
+        EOF
+        expect { runner.review('app/models/project.rb', content) }.not_to raise_error
       end
     end
   end