rails_best_practices 1.18.1 → 1.19.0

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -5,166 +5,85 @@ module RailsBestPractices
     describe NeedlessDeepNestingReview do
       let(:runner) { Core::Runner.new(reviews: NeedlessDeepNestingReview.new) }
 
-      describe "rails2" do
-        it "should needless deep nesting" do
-          content = <<-EOF
-          map.resources :posts do |post|
-            post.resources :comments do |comment|
-              comment.resources :favorites
-            end
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
-        end
-
-        it "should not needless deep nesting for shallow" do
-          content = <<-EOF
-          map.resources :posts, shallow: true do |post|
-            post.resources :comments do |comment|
-              comment.resources :favorites
-            end
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
-
-        it "should needless deep nesting with resource" do
-          content = <<-EOF
-          map.resources :posts do |post|
-            post.resources :comments do |comment|
-              comment.resource :vote
-            end
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
-        end
-
-        it "should needless deep nesting with block node" do
-          content = <<-EOF
-          map.resources :posts do |post|
-            post.resources :comments do |comment|
-              comment.resources :favorites
-            end
-            post.resources :votes
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
-        end
-
-        it "should no needless deep nesting" do
-          content = <<-EOF
-          map.resources :posts do |post|
-            post.resources :comments
-          end
-
-          map.resources :comments do |comment|
-            comment.resources :favorites
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
-
-        it "should no needless deep nesting with block node" do
-          content = <<-EOF
-          map.resources :comments do |comment|
-            comment.resources :favorites
-            comment.resources :votes
+      it "should needless deep nesting" do
+        content = <<-EOF
+        resources :posts do
+          resources :comments do
+            resources :favorites
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
       end
 
-      describe "rails3" do
-        it "should needless deep nesting" do
-          content = <<-EOF
-          resources :posts do
-            resources :comments do
-              resources :favorites
-            end
+      it "should not needless deep nesting for shallow" do
+        content = <<-EOF
+        resources :posts, shallow: true do
+          resources :comments do
+            resources :favorites
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
+      end
 
-        it "should not needless deep nesting for shallow" do
-          content = <<-EOF
-          resources :posts, shallow: true do
-            resources :comments do
-              resources :favorites
+      it "should not needless deep nesting for shallow 4 levels" do
+        content = <<-EOF
+        resources :applications, shallow: true, only: [:index, :show, :create] do
+          resources :events, only: [:index, :show, :create, :subscribe, :push] do
+            resources :executions, only: [:index, :show] do
+              resources :execution_statuses, only: :index
             end
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
+      end
 
-        it "should not needless deep nesting for shallow 4 levels" do
-          content = <<-EOF
-          resources :applications, shallow: true, only: [:index, :show, :create] do
-            resources :events, only: [:index, :show, :create, :subscribe, :push] do
-              resources :executions, only: [:index, :show] do
-                resources :execution_statuses, only: :index
-              end
-            end
+      it "should needless deep nesting with resource" do
+        content = <<-EOF
+        resources :posts do
+          resources :comments do
+            resource :vote
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+      end
 
-        it "should needless deep nesting with resource" do
-          content = <<-EOF
-          resources :posts do
-            resources :comments do
-              resource :vote
-            end
+      it "should needless deep nesting with block node" do
+        content = <<-EOF
+        resources :posts do
+          resources :comments do
+            resources :favorites
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+          resources :votes
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+      end
 
-        it "should needless deep nesting with block node" do
-          content = <<-EOF
-          resources :posts do
-            resources :comments do
-              resources :favorites
-            end
-            resources :votes
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+      it "should no needless deep nesting" do
+        content = <<-EOF
+        resources :posts do
+          resources :comments
+          resources :votes
         end
 
-        it "should no needless deep nesting" do
-          content = <<-EOF
-          resources :posts do
-            resources :comments
-            resources :votes
-          end
-
-          resources :comments do
-            resources :favorites
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
+        resources :comments do
+          resources :favorites
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not check ignored files" do

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -5,83 +5,40 @@ module RailsBestPractices
     describe NotUseDefaultRouteReview do
       let(:runner) { Core::Runner.new(reviews: NotUseDefaultRouteReview.new) }
 
-      describe "rails2" do
-        it "should not use default route" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, member: { push: :post }
+      it "should not use default route" do
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do |map|
+          resources :posts
 
-            map.connect ':controller/:action/:id'
-            map.connect ':controller/:action/:id.:format'
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(2)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:4 - not use default route")
-          expect(runner.errors[1].to_s).to eq("config/routes.rb:5 - not use default route")
-        end
-
-        it "should no not use default route" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, member: { push: :post }
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
-
-        it "should not check ignored files" do
-          runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, member: { push: :post }
-
-            map.connect ':controller/:action/:id'
-            map.connect ':controller/:action/:id.:format'
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
+          match ':controller(/:action(/:id(.:format)))'
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("config/routes.rb:4 - not use default route")
       end
 
-      describe "rails3" do
-        it "should not use default route" do
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do |map|
-            resources :posts
-
-            match ':controller(/:action(/:id(.:format)))'
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:4 - not use default route")
-        end
-
-        it "should no not use default route" do
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do |map|
-            resources :posts
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
+      it "should no not use default route" do
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do |map|
+          resources :posts
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
+      end
 
-        it "should not check ignored files" do
-          runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do |map|
-            resources :posts
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do |map|
+          resources :posts
 
-            match ':controller(/:action(/:id(.:format)))'
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
+          match ':controller(/:action(/:id(.:format)))'
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -5,174 +5,65 @@ module RailsBestPractices
     describe OveruseRouteCustomizationsReview do
       let(:runner) { Core::Runner.new(reviews: OveruseRouteCustomizationsReview.new) }
 
-      describe "rails2" do
-        it "should overuse route customizations" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, member: { comments: :get,
-                                               create_comment: :post,
-                                               update_comment: :update,
-                                               delete_comment: :delete }
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
-        end
-
-        it "should overuse route customizations with member" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, member: { create_comment: :post,
-                                               update_comment: :update,
-                                               delete_comment: :delete,
-                                               disable_comment: :post }
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
-        end
-
-        it "should overuse route customizations with collection" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, collection: { list_comments: :get,
-                                                   update_comments: :get,
-                                                   delete_comments: :get,
-                                                   disable_comments: :get }
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
-        end
-
-        it "should overuse route customizations with hash member and collection" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :categories do |category|
-              category.resources :posts, member: { create_comment: :post,
-                                                      update_comment: :update,
-                                                      delete_comment: :delete },
-                                         collection: { comments: :get }
-            end
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - overuse route customizations (customize_count > 3)")
-        end
-
-        it "should overuse route customizations with array member and collection" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :categories do |category|
-              category.resources :posts, member: [:create_comment, :update_comment, :delete_comment],
-                                         collection: [:comments]
+      it "should overuse route customizations" do
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do
+          resources :posts do
+            member do
+              post :create_comment
+              update :update_comment
+              delete :delete_comment
             end
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - overuse route customizations (customize_count > 3)")
-        end
-
-        it "should not overuse route customizations without customization" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
 
-        it "should not overuse route customizations when customize route is only one" do
-          content = <<-EOF
-          ActionController::Routing::Routes.draw do |map|
-            map.resources :posts, member: { vote: :post }
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
-        end
-
-        it "should not raise error for constants in routes" do
-          content =<<-EOF
-          IP_PATTERN = /(((25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2})\.){3}(25[0-5]|2[0-4][0-9]|1[0-9]{2}|[0-9]{1,2}))|[\d]+/.freeze
-          map.resources :vlans do |vlan|
-            vlan.resources :ip_ranges, member: {move: [:get, :post]} do |range|
-              range.resources :ips, requirements: { id: IP_PATTERN }
+            collection do
+              get :comments
             end
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
       end
 
-      describe "rails3" do
-        it "should overuse route customizations" do
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do
-            resources :posts do
-              member do
-                post :create_comment
-                update :update_comment
-                delete :delete_comment
-              end
-
-              collection do
-                get :comments
-              end
-            end
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
-        end
-
-        it "should overuse route customizations another way" do
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do
-            resources :posts do
-              post :create_comment, on: :member
-              update :update_comment, on: :member
-              delete :delete_comment, on: :member
-              get :comments, on: :collection
-            end
+      it "should overuse route customizations another way" do
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do
+          resources :posts do
+            post :create_comment, on: :member
+            update :update_comment, on: :member
+            delete :delete_comment, on: :member
+            get :comments, on: :collection
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
+      end
 
-        it "should not overuse route customizations without customization" do
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do
-            resources :posts
-          end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
+      it "should not overuse route customizations without customization" do
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do
+          resources :posts
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
+      end
 
-        it "should not overuse route customizations when customize route is only one" do
-          content = <<-EOF
-          RailsBestpracticesCom::Application.routes.draw do
-            resources :posts do
-              member do
-                post :vote
-              end
+      it "should not overuse route customizations when customize route is only one" do
+        content = <<-EOF
+        RailsBestpracticesCom::Application.routes.draw do
+          resources :posts do
+            member do
+              post :vote
             end
           end
-          EOF
-          runner.review('config/routes.rb', content)
-          expect(runner.errors.size).to eq(0)
         end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not check ignored files" do