puppet_forge 1.0.6 → 2.0.0

data/spec/unit/forge/v3/module_spec.rb

@@ -2,9 +2,16 @@ require 'spec_helper'
 
 describe PuppetForge::V3::Module do
   before do
-    stub_api_for(PuppetForge::V3::Module) do |api|
-      stub_fixture(api, :get, '/v3/modules/puppetlabs-apache')
-      stub_fixture(api, :get, '/v3/modules/absent-apache')
+    stub_api_for(PuppetForge::V3::Base) do |stubs|
+      stub_fixture(stubs, :get, '/v3/modules/puppetlabs-apache')
+      stub_fixture(stubs, :get, '/v3/modules/absent-apache')
+      stub_fixture(stubs, :get, '/v3/users/puppetlabs')
+      stub_fixture(stubs, :get, '/v3/releases/puppetlabs-apache-0.0.1')
+      stub_fixture(stubs, :get, '/v3/releases/puppetlabs-apache-0.0.2')
+      stub_fixture(stubs, :get, '/v3/releases/puppetlabs-apache-0.0.3')
+      stub_fixture(stubs, :get, '/v3/releases/puppetlabs-apache-0.0.4')
+      stub_fixture(stubs, :get, '/v3/releases/puppetlabs-apache-0.1.1')
+      stub_fixture(stubs, :get, '/v3/releases?module=puppetlabs-apache')
     end
   end
 
@@ -17,19 +24,13 @@ describe PuppetForge::V3::Module do
     end
 
     it 'returns nil for non-existent modules' do
-      expect(missing_mod).to be_nil
+      expect { missing_mod }.to raise_error(Faraday::ResourceNotFound)
     end
   end
 
   describe '#owner' do
     let(:mod) { PuppetForge::V3::Module.find('puppetlabs-apache') }
 
-    before do
-      stub_api_for(PuppetForge::V3::User) do |api|
-        stub_fixture(api, :get, '/v3/users/puppetlabs')
-      end
-    end
-
     it 'exposes the related module as a property' do
       expect(mod.owner).to_not be nil
     end
@@ -57,32 +58,11 @@ describe PuppetForge::V3::Module do
       expect(mod.current_release.version).to_not be nil
     end
 
-    it 'transparently makes API calls for other attributes' do
-      stub_api_for(PuppetForge::V3::Release) do |api|
-        api.get(mod.current_release.uri) do
-          load_fixture('/v3/releases/puppetlabs-apache-0.0.1')
-        end
-      end
-
-      mod.attributes[:current_release].delete :created_at
-      expect(mod.current_release.created_at).to_not be nil
-    end
   end
 
   describe '#releases' do
     let(:mod) { PuppetForge::V3::Module.find('puppetlabs-apache') }
 
-    before do
-      stub_api_for(PuppetForge::V3::Release) do |api|
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.1')
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.2')
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.3')
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.4')
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.1.1')
-        stub_fixture(api, :get, '/v3/releases?module=puppetlabs-apache')
-      end
-    end
-
     it 'exposes the related releases as a property' do
       expect(mod.releases).to be_an Array
     end
@@ -96,15 +76,13 @@ describe PuppetForge::V3::Module do
       expect(mod.releases.map(&:version)).to_not include nil
     end
 
-    it 'transparently makes API calls for other attributes' do
+    it 'loads releases lazily' do
       versions = %w[ 0.0.1 0.0.2 0.0.3 0.0.4 0.1.1 ]
       releases = mod.releases.select { |x| versions.include? x.version }
 
-      expect(PuppetForge::V3::Release).to receive(:request) \
-                        .exactly(5).times \
-                        .and_call_original
+      expect(PuppetForge::V3::Base).to receive(:request).exactly(5).times.and_call_original
 
-      expect(releases.map(&:created_at)).to_not include nil
+      expect(releases.map(&:downloads)).to_not include nil
     end
   end
 

data/spec/unit/forge/v3/release_spec.rb

@@ -3,9 +3,12 @@ require 'fileutils'
 
 describe PuppetForge::V3::Release do
   before do
-    stub_api_for(PuppetForge::V3::Release) do |api|
-      stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.1')
-      stub_fixture(api, :get, '/v3/releases/absent-apache-0.0.1')
+    stub_api_for(PuppetForge::V3::Base) do |stubs|
+      stub_fixture(stubs, :get, '/v3/releases/puppetlabs-apache-0.0.1')
+      stub_fixture(stubs, :get, '/v3/releases/absent-apache-0.0.1')
+      stub_fixture(stubs, :get, '/v3/files/puppetlabs-apache-0.0.1.tar.gz')
+      stub_fixture(stubs, :get, '/v3/modules/puppetlabs-apache')
+      stub_fixture(stubs, :get, '/v3/releases?module=puppetlabs-apache')
     end
   end
 
@@ -17,20 +20,14 @@ describe PuppetForge::V3::Release do
       expect(release.version).to eql('0.0.1')
     end
 
-    it 'returns nil for non-existent releases' do
-      expect(missing_release).to be nil
+    it 'raises Faraday::ResourceNotFound for non-existent releases' do
+      expect { missing_release }.to raise_error(Faraday::ResourceNotFound)
     end
   end
 
   describe '#module' do
     let(:release) { PuppetForge::V3::Release.find('puppetlabs-apache-0.0.1') }
 
-    before do
-      stub_api_for(PuppetForge::V3::Module) do |api|
-        stub_fixture(api, :get, '/v3/modules/puppetlabs-apache')
-      end
-    end
-
     it 'exposes the related module as a property' do
       expect(release.module).to_not be nil
     end
@@ -49,12 +46,6 @@ describe PuppetForge::V3::Release do
   describe '#download_url' do
     let(:release) { PuppetForge::V3::Release.find('puppetlabs-apache-0.0.1') }
 
-    before do
-      stub_api_for(PuppetForge::V3::Release) do |api|
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.1')
-      end
-    end
-
     it 'handles an API response that does not include a scheme and host' do
       release.file_uri = '/v3/files/puppetlabs-apache-0.0.1.tar.gz'
       expect(release.download_url).to eql(PuppetForge.host + '/v3/files/puppetlabs-apache-0.0.1.tar.gz')
@@ -72,16 +63,10 @@ describe PuppetForge::V3::Release do
 
     before { FileUtils.rm tarball rescue nil }
     after  { FileUtils.rm tarball rescue nil }
-    before do
-      stub_api_for(PuppetForge::V3::Release) do |api|
-        stub_fixture(api, :get, '/v3/releases/puppetlabs-apache-0.0.1')
-        stub_fixture(api, :get, '/v3/files/puppetlabs-apache-0.0.1.tar.gz')
-      end
-    end
 
     it 'downloads the file to the specified location' do
       expect(File.exist?(tarball)).to be false
-      release.download(tarball)
+      release.download(Pathname.new(tarball))
       expect(File.exist?(tarball)).to be true
     end
   end
@@ -89,12 +74,6 @@ describe PuppetForge::V3::Release do
   describe '#metadata' do
     let(:release) { PuppetForge::V3::Release.find('puppetlabs-apache-0.0.1') }
 
-    before do
-      stub_api_for(PuppetForge::V3::Module) do |api|
-        stub_fixture(api, :get, '/v3/modules/puppetlabs-apache')
-      end
-    end
-
     it 'is lazy and repeatable' do
       3.times do
         expect(release.module.releases.last.metadata).to_not be_nil

data/spec/unit/forge/v3/user_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 describe PuppetForge::V3::User do
   before do
-    stub_api_for(PuppetForge::V3::User) do |api|
-      stub_fixture(api, :get, '/v3/users/puppetlabs')
-      stub_fixture(api, :get, '/v3/users/absent')
+    stub_api_for(PuppetForge::V3::User) do |stubs|
+      stub_fixture(stubs, :get, '/v3/users/puppetlabs')
+      stub_fixture(stubs, :get, '/v3/users/absent')
     end
   end
 
@@ -16,15 +16,15 @@ describe PuppetForge::V3::User do
       expect(user.username).to eq('puppetlabs')
     end
 
-    it 'returns nil for non-existent users' do
-      expect(missing_user).to be_nil
+    it 'raises Faraday::ResourceNotFound for non-existent users' do
+      expect { missing_user }.to raise_error(Faraday::ResourceNotFound)
     end
   end
 
   describe '#modules' do
     before do
-      stub_api_for(PuppetForge::V3::Module) do |api|
-        stub_fixture(api, :get, '/v3/modules?owner=puppetlabs')
+      stub_api_for(PuppetForge::V3::Module) do |stubs|
+        stub_fixture(stubs, :get, '/v3/modules?owner=puppetlabs')
       end
     end
 

metadata

@@ -1,160 +1,221 @@
 --- !ruby/object:Gem::Specification
 name: puppet_forge
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 2.0.0
+  prerelease: 
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2015-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
-  name: her
+  name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.6.8
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.6.8
+        version: 0.9.0
+- !ruby/object:Gem::Dependency
+  name: semantic_puppet
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.1.0
+- !ruby/object:Gem::Dependency
+  name: minitar
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: cane
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description: Tools that can be used to access Forge API information on Modules, Users,
+  and Releases. As well as download, unpack, and install Releases to a directory.
 email:
 - forge-team+api@puppetlabs.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
+- .gitignore
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
+- MAINTAINERS
 - README.md
 - Rakefile
-- lib/her/lazy_accessors.rb
-- lib/her/lazy_relations.rb
 - lib/puppet_forge.rb
-- lib/puppet_forge/middleware/json_for_her.rb
+- lib/puppet_forge/connection.rb
+- lib/puppet_forge/connection/connection_failure.rb
+- lib/puppet_forge/error.rb
+- lib/puppet_forge/lazy_accessors.rb
+- lib/puppet_forge/lazy_relations.rb
+- lib/puppet_forge/middleware/symbolify_json.rb
+- lib/puppet_forge/tar.rb
+- lib/puppet_forge/tar/mini.rb
+- lib/puppet_forge/unpacker.rb
 - lib/puppet_forge/v3.rb
 - lib/puppet_forge/v3/base.rb
 - lib/puppet_forge/v3/base/paginated_collection.rb
+- lib/puppet_forge/v3/metadata.rb
 - lib/puppet_forge/v3/module.rb
 - lib/puppet_forge/v3/release.rb
 - lib/puppet_forge/v3/user.rb
@@ -186,39 +247,54 @@ files:
 - spec/fixtures/v3/releases__module=puppetlabs-apache.json
 - spec/fixtures/v3/users/puppetlabs.headers
 - spec/fixtures/v3/users/puppetlabs.json
+- spec/integration/forge/v3/module_spec.rb
+- spec/integration/forge/v3/release_spec.rb
+- spec/integration/forge/v3/user_spec.rb
 - spec/spec_helper.rb
 - spec/tmp/.gitkeep
+- spec/unit/forge/connection/connection_failure_spec.rb
+- spec/unit/forge/connection_spec.rb
+- spec/unit/forge/lazy_accessors_spec.rb
+- spec/unit/forge/lazy_relations_spec.rb
+- spec/unit/forge/middleware/symbolify_json_spec.rb
+- spec/unit/forge/tar/mini_spec.rb
+- spec/unit/forge/tar_spec.rb
+- spec/unit/forge/unpacker_spec.rb
 - spec/unit/forge/v3/base/paginated_collection_spec.rb
 - spec/unit/forge/v3/base_spec.rb
+- spec/unit/forge/v3/metadata_spec.rb
 - spec/unit/forge/v3/module_spec.rb
 - spec/unit/forge/v3/release_spec.rb
 - spec/unit/forge/v3/user_spec.rb
-- spec/unit/her/lazy_accessors_spec.rb
-- spec/unit/her/lazy_relations_spec.rb
 homepage: https://github.com/puppetlabs/forge-ruby
 licenses:
 - Apache-2.0
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2116773441322079787
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 1.8.23.2
 signing_key: 
-specification_version: 4
-summary: Access and manipulate the Puppet Forge API from Ruby.
+specification_version: 3
+summary: Access the Puppet Forge API from Ruby for resource information and to download
+  releases.
 test_files:
 - spec/fixtures/v3/files/puppetlabs-apache-0.0.1.tar.gz.headers
 - spec/fixtures/v3/files/puppetlabs-apache-0.0.1.tar.gz.json
@@ -246,13 +322,23 @@ test_files:
 - spec/fixtures/v3/releases__module=puppetlabs-apache.json
 - spec/fixtures/v3/users/puppetlabs.headers
 - spec/fixtures/v3/users/puppetlabs.json
+- spec/integration/forge/v3/module_spec.rb
+- spec/integration/forge/v3/release_spec.rb
+- spec/integration/forge/v3/user_spec.rb
 - spec/spec_helper.rb
 - spec/tmp/.gitkeep
+- spec/unit/forge/connection/connection_failure_spec.rb
+- spec/unit/forge/connection_spec.rb
+- spec/unit/forge/lazy_accessors_spec.rb
+- spec/unit/forge/lazy_relations_spec.rb
+- spec/unit/forge/middleware/symbolify_json_spec.rb
+- spec/unit/forge/tar/mini_spec.rb
+- spec/unit/forge/tar_spec.rb
+- spec/unit/forge/unpacker_spec.rb
 - spec/unit/forge/v3/base/paginated_collection_spec.rb
 - spec/unit/forge/v3/base_spec.rb
+- spec/unit/forge/v3/metadata_spec.rb
 - spec/unit/forge/v3/module_spec.rb
 - spec/unit/forge/v3/release_spec.rb
 - spec/unit/forge/v3/user_spec.rb
-- spec/unit/her/lazy_accessors_spec.rb
-- spec/unit/her/lazy_relations_spec.rb
 has_rdoc: