puppet_forge 1.0.6 → 2.0.0

data/spec/fixtures/v3/releases/puppetlabs-apache-0.0.1.json

@@ -1,10 +1,13 @@
 {
   "uri": "/v3/releases/puppetlabs-apache-0.0.1",
+  "slug": "puppetlabs-apache-0.0.1",
   "module": {
     "uri": "/v3/modules/puppetlabs-apache",
+    "slug": "puppetlabs-apache",
     "name": "apache",
     "owner": {
       "uri": "/v3/users/puppetlabs",
+      "slug": "puppetlabs",
       "username": "puppetlabs",
       "gravatar_id": "fdd009b7c1ec96e088b389f773e87aec"
     }
@@ -90,4 +93,4 @@
   "created_at": "2010-05-20 22:43:44 -0700",
   "updated_at": "2010-05-20 22:43:44 -0700",
   "deleted_at": null
-}
+}

data/spec/integration/forge/v3/module_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe PuppetForge::V3::Module do
+  before do
+
+    PuppetForge.host = "https://forge-aio01-petest.puppetlabs.com/"
+    PuppetForge::V3::Base.conn = PuppetForge::Connection.make_connection(PuppetForge.host, nil, {:ssl => {:verify => false} })
+  end
+
+  context "::find" do
+    context "gets information on an existing module and" do
+      let (:mod) { PuppetForge::V3::Module.find('puppetforgegemtesting-thorin') }
+
+      it "returns a PuppetForge::V3::Module." do
+        expect(mod).to be_a(PuppetForge::V3::Module)
+      end
+
+      it "exposes the API information." do
+        expect(mod).to respond_to(:uri)
+        expect(mod).to respond_to(:owner)
+        expect(mod).to respond_to(:current_release)
+        expect(mod).to respond_to(:releases)
+
+        expect(mod.uri).to be_a(String)
+        expect(mod.owner).to be_a(PuppetForge::V3::User)
+        expect(mod.current_release).to be_a(PuppetForge::V3::Release)
+        expect(mod.releases.first).to be_a(PuppetForge::V3::Release)
+      end
+
+    end
+
+    context "raises Faraday::ResourceNotFound when" do
+      let (:mod) { PuppetForge::V3::Module.find('puppetforgegemtesting-bilbo') }
+
+      it "the module does not exist" do
+        expect { mod }.to raise_error(Faraday::ResourceNotFound)
+      end
+
+    end
+
+  end
+
+  context "::where" do
+    context "finds matching resources" do
+
+      it "only returns modules that match the query" do
+        modules = PuppetForge::V3::Module.where(:owner => 'puppetforgegemtesting')
+
+        expect(modules).to be_a(PuppetForge::V3::Base::PaginatedCollection)
+        modules.each do |mod|
+          expect(mod.owner.username).to eq('puppetforgegemtesting')
+        end
+
+      end
+
+      it "returns a paginated response" do
+        modules = PuppetForge::V3::Module.where(:owner => 'puppetforgegemtesting', :limit => 1)
+
+        expect(modules.limit).to eq(1)
+        expect(modules.total).to eq(2)
+
+        expect(modules.next).not_to be_nil
+      end
+
+    end
+
+    context "does not find matching resources" do
+      it "returns an empty PaginatedCollection" do
+        modules = PuppetForge::V3::Module.where(:owner => 'absentuser')
+
+        expect(modules).to be_a(PuppetForge::V3::Base::PaginatedCollection)
+
+        expect(modules.size).to eq(0)
+        expect(modules.empty?).to be(true)
+      end
+    end
+  end
+end
+

data/spec/integration/forge/v3/release_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe PuppetForge::V3::Release do
+  before do
+    PuppetForge.host = "https://forge-aio01-petest.puppetlabs.com/"
+    PuppetForge::V3::Base.conn = PuppetForge::Connection.make_connection(PuppetForge.host, nil, {:ssl => {:verify => false} })
+  end
+
+  context "#find" do
+    context "when the release exists," do
+
+      it "find returns a PuppetForge::V3::Release." do
+        release = PuppetForge::V3::Release.find('puppetforgegemtesting-thorin-0.0.1')
+
+        expect(release).to be_a(PuppetForge::V3::Release)
+      end
+
+      it "it exposes the API information." do
+        release = PuppetForge::V3::Release.find('puppetforgegemtesting-thorin-0.0.1')
+
+        expect(release).to respond_to(:uri)
+
+        expect(release.uri).to be_a(String)
+      end
+
+    end
+
+    context "when the release doesn't exist," do
+      let (:release) { PuppetForge::V3::Release.find('puppetforgegemtesting-bilbo-0.0.1') }
+
+      it "find returns nil." do
+        expect { release }.to raise_error(Faraday::ResourceNotFound)
+      end
+
+    end
+
+  end
+
+  context "::where" do
+    context "finds matching resources" do
+
+      it "only returns releases that match the query" do
+        releases = PuppetForge::V3::Release.where(:module => 'puppetforgegemtesting-thorin')
+
+        expect(releases).to be_a(PuppetForge::V3::Base::PaginatedCollection)
+
+        expect(releases.first.version).to eq("0.0.2")
+        expect(releases[1].version).to eq("0.0.1")
+
+      end
+
+      it "returns a paginated response" do
+        releases = PuppetForge::V3::Release.where(:module => 'puppetforgegemtesting-thorin', :limit => 1)
+
+        expect(releases.limit).to eq(1)
+        expect(releases.total).to eq(2)
+
+        expect(releases.next).not_to be_nil
+      end
+
+    end
+
+    context "does not find matching resources" do
+      it "returns an empty PaginatedCollection" do
+        releases = PuppetForge::V3::Release.where(:module => 'puppetforgegemtesting-notamodule')
+
+        expect(releases).to be_a(PuppetForge::V3::Base::PaginatedCollection)
+
+        expect(releases.size).to eq(0)
+        expect(releases.empty?).to be(true)
+      end
+    end
+  end
+end
+

data/spec/integration/forge/v3/user_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe PuppetForge::V3::User do
+  before do
+    PuppetForge.host = "https://forge-aio01-petest.puppetlabs.com/"
+    PuppetForge::V3::Base.conn = PuppetForge::Connection.make_connection(PuppetForge.host, nil, {:ssl => {:verify => false} })
+  end
+
+  context "#find" do
+    context "when the user exists," do
+
+      it "find returns a PuppetForge::V3::User." do
+        user = PuppetForge::V3::User.find('puppetforgegemtesting')
+        expect(user).to be_a(PuppetForge::V3::User)
+      end
+
+      it "it exposes the API information." do
+        user = PuppetForge::V3::User.find('puppetforgegemtesting')
+
+        expect(user).to respond_to(:uri)
+        expect(user).to respond_to(:modules)
+
+        expect(user.uri).to be_a(String)
+        expect(user.modules).to be_a(PuppetForge::V3::Base::PaginatedCollection)
+      end
+
+    end
+
+    context "when the user doesn't exists," do
+      let (:user) { PuppetForge::V3::User.find('notauser') }
+
+      it "find returns nil." do
+        expect { user }.to raise_error(Faraday::ResourceNotFound)
+      end
+
+    end
+  end
+
+  context "::where" do
+    context "finds matching resources" do
+
+      it "returns sorted users" do
+        users = PuppetForge::V3::User.where(:sort_by => 'releases')
+
+        expect(users).to be_a(PuppetForge::V3::Base::PaginatedCollection)
+
+        previous_releases = users.first.release_count
+        users.each do |user|
+          expect(user.release_count).to be <= previous_releases
+          previous_releases = user.release_count
+        end
+
+      end
+
+      it "returns a paginated response" do
+        users = PuppetForge::V3::User.where(:limit => 1)
+
+        expect(users.limit).to eq(1)
+
+        2.times do
+          expect(users).not_to be_nil
+          users = users.next
+        end
+      end
+
+    end
+
+  end
+end
+

data/spec/spec_helper.rb

@@ -10,18 +10,25 @@ end
 
 require 'puppet_forge'
 
-module StubbingHer
+module StubbingFaraday
+
   def stub_api_for(klass)
-    klass.use_api begin
-      Her::API.new :url => "http://api.example.com" do |c|
-        c.use PuppetForge::Middleware::JSONForHer
-        c.adapter(:test) { |s| yield(s) }
+    allow(klass).to receive(:conn) do
+      Faraday.new :url => "http://api.example.com" do |builder|
+        builder.use PuppetForge::Middleware::SymbolifyJson
+        builder.response(:json, :content_type => /\bjson$/)
+        builder.response(:raise_error)
+        builder.use(:connection_failure)
+
+        builder.adapter(:test) { |s| yield(s) }
       end
     end
+
+    stubs = Faraday::Adapter::Test::Stubs.new
   end
 
-  def stub_fixture(api, method, path)
-    api.send(method, path) do |env|
+  def stub_fixture(stubs, method, path)
+    stubs.send(method, path) do |env|
       load_fixture([ env[:url].path, env[:url].query ].compact.join('?'))
     end
   end
@@ -51,7 +58,7 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 
-  config.include StubbingHer
+  config.include StubbingFaraday
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing

data/spec/unit/forge/connection/connection_failure_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+# The adapter NetHttp must be required before the SocketError (used below) is accessible
+require 'faraday/adapter/net_http'
+
+describe PuppetForge::Connection::ConnectionFailure do
+
+  subject do
+    Faraday.new('https://my-site.url/some-path') do |builder|
+      builder.use(:connection_failure)
+
+      builder.adapter :test do |stub|
+        stub.get('/connectfail') { raise Faraday::ConnectionFailed.new(SocketError.new("getaddrinfo: Name or service not known"), :hi) }
+      end
+    end
+  end
+
+  it "includes the base URL in the error message" do
+    expect {
+      subject.get('/connectfail')
+    }.to raise_error(Faraday::ConnectionFailed, "Unable to connect to https://my-site.url: getaddrinfo: Name or service not known")
+  end
+
+  it "includes the proxy host in the error message when set" do
+    subject.proxy('https://some-unreachable.proxy:3128')
+    expect {
+      subject.get('/connectfail')
+    }.to raise_error(Faraday::ConnectionFailed, "Unable to connect to https://my-site.url (using proxy https://some-unreachable.proxy:3128): getaddrinfo: Name or service not known")
+  end
+end

data/spec/unit/forge/connection_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe PuppetForge::Connection do
+  before(:each) do
+    PuppetForge.host = "https://forgeapi.puppetlabs.com"
+  end
+
+  let(:test_conn) do
+    PuppetForge::Connection
+  end
+
+  describe 'creating a new connection' do
+
+    let(:faraday_stubs) { Faraday::Adapter::Test::Stubs.new }
+
+    subject { test_conn.make_connection('https://some.site/url', [:test, faraday_stubs]) }
+
+    it 'parses response bodies with a JSON content-type into a hash' do
+      faraday_stubs.get('/json') { [200, {'Content-Type' => 'application/json'}, '{"hello": "world"}'] }
+      expect(subject.get('/json').body).to eq(:hello => 'world')
+    end
+
+    it 'returns the response body as-is when the content-type is not JSON' do
+      faraday_stubs.get('/binary') { [200, {'Content-Type' => 'application/octet-stream'}, 'I am a big bucket of binary data'] }
+      expect(subject.get('/binary').body).to eq('I am a big bucket of binary data')
+    end
+
+    it 'raises errors when the request has an error status code' do
+      faraday_stubs.get('/error') { [503, {}, "The server caught fire and cannot service your request right now"] }
+
+      expect {
+        subject.get('/error')
+      }.to raise_error(Faraday::ClientError, "the server responded with status 503")
+    end
+
+    context 'when an authorization value is provided' do
+      before(:each) do
+        allow(described_class).to receive(:authorization).and_return("auth-test value")
+      end
+
+      it 'sets authorization header on requests' do
+        expect(subject.headers).to include(:authorization => "auth-test value")
+      end
+    end
+  end
+
+  describe 'creating a default connection' do
+    it 'creates a connection with the PuppetForge host' do
+      conn = test_conn.default_connection
+      expect(conn.url_prefix.to_s).to eq 'https://forgeapi.puppetlabs.com/'
+    end
+  end
+end

data/spec/unit/{her → forge}/lazy_accessors_spec.rb

@@ -1,14 +1,17 @@
 require 'spec_helper'
-require 'json'
 
-describe Her::LazyAccessors do
+describe PuppetForge::LazyAccessors do
   let(:klass) do
-    Class.new do
-      include Her::Model
-      include Her::LazyAccessors
+    class PuppetForge::V3::Thing < PuppetForge::V3::Base
 
-      def request_path
-        "/things/#{id}"
+      # Needed for #inspect
+      def uri
+        "/things/1"
+      end
+
+      # Needed for fetch
+      def slug
+        "1"
       end
 
       def standalone_method
@@ -30,9 +33,13 @@ describe Her::LazyAccessors do
       def remote_shadow
         "-#{super}-"
       end
+
     end
+
+    PuppetForge::V3::Thing
   end
 
+  let(:base_class) { PuppetForge::V3::Base }
   let(:local_data)  { { :id => 1, :local => 'data', :shadow => 'x' } }
   let(:remote_data) { local_data.merge(:remote => 'DATA', :remote_shadow => 'X') }
 
@@ -80,9 +87,9 @@ describe Her::LazyAccessors do
 
   describe 'remote attributes' do
     before do
-      stub_api_for(klass) do |api|
-        api.get('/things/1') do
-          [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+      stub_api_for(base_class) do |api|
+        api.get('/v3/things/1') do
+          [ 200, { 'Content-Type' => 'json' }, remote_data ]
         end
       end
     end
@@ -122,9 +129,9 @@ describe Her::LazyAccessors do
 
   describe 'unsatisfiable attributes' do
     before do
-      stub_api_for(klass) do |api|
-        api.get('/things/1') do
-          [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+      stub_api_for(base_class) do |api|
+        api.get('/v3/things/1') do
+          [ 200, { 'Content-Type' => 'json' }, remote_data ]
         end
       end
     end

data/spec/unit/{her → forge}/lazy_relations_spec.rb

@@ -1,31 +1,32 @@
 require 'spec_helper'
-require 'json'
 
-describe Her::LazyRelations do
-  let(:klass) do |*args|
-    ctx = self
+describe PuppetForge::LazyRelations do
+    class PuppetForge::V3::Parent < PuppetForge::V3::Base
 
-    Class.new do
-      include Her::Model
-      include Her::LazyRelations
+      lazy :relation, 'Thing'
+      lazy :chained, 'Parent'
+      lazy_collection :relations, 'Thing'
+      lazy_collection :parents, 'Parent'
 
-      lazy :relation, ctx.related_class
-      lazy :chained, self
-      lazy_collection :relations, ctx.related_class
-      lazy_collection :parents, self
+      def uri
+        "/parents/#{slug}"
+      end
 
-      def request_path
-        "/parents/#{id}"
+      def slug
+        "1"
       end
     end
-  end
 
-  let(:related_class) do
-    Class.new do
-      include Her::Model
+    class PuppetForge::V3::Thing < PuppetForge::V3::Base
+
+      # Needed for #inspect
+      def uri
+        "/things/1"
+      end
 
-      def request_path
-        "/things/#{id}"
+      # Needed for fetch
+      def slug
+        "1"
       end
 
       def standalone_method
@@ -47,7 +48,16 @@ describe Her::LazyRelations do
       def remote_shadow
         "-#{super}-"
       end
+
     end
+
+  let(:base_class) { PuppetForge::V3::Base }
+  let(:klass) do |*args|
+    PuppetForge::V3::Parent
+  end
+
+  let(:related_class) do
+    PuppetForge::V3::Thing
   end
 
   let(:local_data)  { { :id => 1, :local => 'data', :shadow => 'x' } }
@@ -56,7 +66,9 @@ describe Her::LazyRelations do
   describe '.lazy' do
     subject { klass.new(:relation => local_data).relation }
 
-    it { should be_a(related_class) }
+    it do
+      should be_a(related_class)
+    end
 
     it 'does not call methods to #inspect' do
       expect(subject).not_to receive(:shadow)
@@ -94,9 +106,9 @@ describe Her::LazyRelations do
 
     describe 'remote attributes' do
       before do
-        stub_api_for(related_class) do |api|
-          api.get('/things/1') do
-            [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+        stub_api_for(base_class) do |stubs|
+          stubs.get('/v3/things/1') do
+            [ 200, { 'Content-Type' => 'json' }, remote_data ]
           end
         end
       end
@@ -136,18 +148,17 @@ describe Her::LazyRelations do
 
     describe 'remote relations' do
       before do
-        stub_api_for(klass) do |api|
-          api.get('/parents/1') do
+        stub_api_for(base_class) do |api|
+          api.get('/v3/parents/1') do
             data = { :id => 1, :relation => local_data }
-            [ 200, { 'Content-Type' => 'json' }, data.to_json ]
+            [ 200, { 'Content-Type' => 'json' }, data ]
           end
-        end
 
-        stub_api_for(related_class) do |api|
-          api.get('/things/1') do
-            [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+          api.get('/v3/things/1') do
+            [ 200, { 'Content-Type' => 'json' }, remote_data ]
           end
         end
+
       end
 
       subject { klass.new(:chained => { :id => 1 }) }
@@ -167,13 +178,15 @@ describe Her::LazyRelations do
 
     describe 'unsatisfiable attributes' do
       before do
-        stub_api_for(klass) do |api|
-          api.get('/things/1') do
-            [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+        stub_api_for(base_class) do |api|
+          api.get('/v3/parents/1') do
+            [ 200, { 'Content-Type' => 'json' }, remote_data ]
           end
         end
       end
 
+      subject { klass.new(local_data) }
+
       example 'raise an exception when accessing an unknown attribute' do
         expect { subject.unknown_attribute }.to raise_error(NoMethodError)
       end
@@ -221,9 +234,9 @@ describe Her::LazyRelations do
 
     describe 'remote attributes' do
       before do
-        stub_api_for(related_class) do |api|
-          api.get('/things/1') do
-            [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+        stub_api_for(base_class) do |api|
+          api.get('/v3/things/1') do
+            [ 200, { 'Content-Type' => 'json' }, remote_data ]
           end
         end
       end
@@ -263,18 +276,17 @@ describe Her::LazyRelations do
 
     describe 'remote relations' do
       before do
-        stub_api_for(klass) do |api|
-          api.get('/parents/1') do
+        stub_api_for(base_class) do |api|
+          api.get('/v3/parents/1') do
             data = { :id => 1, :parents => [{ :id => 1, :relation => local_data }] }
-            [ 200, { 'Content-Type' => 'json' }, data.to_json ]
+            [ 200, { 'Content-Type' => 'json' }, data ]
           end
-        end
 
-        stub_api_for(related_class) do |api|
-          api.get('/things/1') do
-            [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+          api.get('/v3/things/1') do
+            [ 200, { 'Content-Type' => 'json' }, remote_data ]
           end
         end
+
       end
 
       subject { klass.new(:id => 1) }
@@ -294,13 +306,15 @@ describe Her::LazyRelations do
 
     describe 'unsatisfiable attributes' do
       before do
-        stub_api_for(klass) do |api|
-          api.get('/things/1') do
-            [ 200, { 'Content-Type' => 'json' }, remote_data.to_json ]
+        stub_api_for(base_class) do |api|
+          api.get('/v3/parents/1') do
+            [ 200, { 'Content-Type' => 'json' }, remote_data ]
           end
         end
       end
 
+      subject { klass.new(local_data) }
+
       example 'raise an exception when accessing an unknown attribute' do
         expect { subject.unknown_attribute }.to raise_error(NoMethodError)
       end