puppet 8.4.0 → 8.5.0

data/lib/puppet/util/logging.rb

@@ -7,7 +7,7 @@ require_relative '../../puppet/error'
 module Puppet::Util
 module Logging
   def send_log(level, message)
-    Puppet::Util::Log.create({:level => level, :source => log_source, :message => message}.merge(log_metadata))
+    Puppet::Util::Log.create({ :level => level, :source => log_source, :message => message }.merge(log_metadata))
   end
 
   # Create a method for each log level.
@@ -77,7 +77,7 @@ module Logging
     built_trace = format_backtrace(exception, combined_trace, puppet_trace)
 
     if exception.respond_to?(:original)
-      original =  exception.original
+      original = exception.original
       unless original.nil?
         built_trace << _('Wrapped exception:')
         built_trace << original.message
@@ -183,7 +183,7 @@ module Logging
 
     $unique_warnings ||= {}
     if $unique_warnings.length < 100 then
-      if (! $unique_warnings.has_key?(key)) then
+      if (!$unique_warnings.has_key?(key)) then
         $unique_warnings[key] = message
         call_trace = if file == :default and line == :default
                        # Suppress the file and line number output
@@ -201,7 +201,7 @@ module Logging
     end
   end
 
-  def get_deprecation_offender()
+  def get_deprecation_offender
     # we have to put this in its own method to simplify testing; we need to be able to mock the offender results in
     # order to test this class, and our framework does not appear to enjoy it if you try to mock Kernel.caller
     #
@@ -240,7 +240,7 @@ module Logging
     Puppet::FileSystem.open(deprecations_file, nil, "a:UTF-8") do |f|
       if ($deprecation_warnings) then
         $deprecation_warnings.each do |offender, message|
-          if (! $logged_deprecation_warnings.has_key?(offender)) then
+          if (!$logged_deprecation_warnings.has_key?(offender)) then
             $logged_deprecation_warnings[offender] = true
             if ((pattern.nil?) || (message =~ pattern)) then
               f.puts(message)
@@ -290,9 +290,8 @@ module Logging
   end
 
   def log_metadata
-    [:file, :line, :tags].inject({}) do |result, attr|
+    [:file, :line, :tags].each_with_object({}) do |attr, result|
       result[attr] = send(attr) if respond_to?(attr)
-      result
     end
   end
 

data/lib/puppet/util/metaid.rb

@@ -20,4 +20,3 @@ class Object
     class_eval { define_method name, &blk }
   end
 end
-

data/lib/puppet/util/metric.rb

@@ -42,7 +42,7 @@ class Puppet::Util::Metric
     end
   end
 
-  def initialize(name,label = nil)
+  def initialize(name, label = nil)
     @name = name.to_s
 
     @label = label || self.class.labelize(name)
@@ -50,11 +50,11 @@ class Puppet::Util::Metric
     @values = []
   end
 
-  def newvalue(name,value,label = nil)
+  def newvalue(name, value, label = nil)
     raise ArgumentError.new("metric name #{name.inspect} is not a string") unless name.is_a? String
 
     label ||= self.class.labelize(name)
-    @values.push [name,label,value]
+    @values.push [name, label, value]
   end
 
   def values

data/lib/puppet/util/monkey_patches.rb

@@ -14,7 +14,7 @@ rescue NotImplementedError
 end
 
 module RDoc
-  def self.caller(skip=nil)
+  def self.caller(skip = nil)
     in_gem_wrapper = false
     Kernel.caller.reject { |call|
       in_gem_wrapper ||= call =~ /#{Regexp.escape $0}:\d+:in `load'/

data/lib/puppet/util/multi_match.rb

@@ -2,7 +2,7 @@
 
 # MultiMatch allows multiple values to be tested at once in a case expression.
 # This class is needed since Array does not implement the === operator to mean
-# "each v === other.each v". 
+# "each v === other.each v".
 #
 # This class is useful in situations when the Puppet Type System cannot be used
 # (e.g. in Logging, since it needs to be able to log very early in the initialization
@@ -12,7 +12,7 @@
 # NOT_NIL
 # TUPLE
 # TRIPLE
-# 
+#
 # which test against single NOT_NIL value, Array with two NOT_NIL, and Array with three NOT_NIL
 #
 module Puppet::Util
@@ -29,11 +29,11 @@ class MultiMatch
     when MultiMatch
       return false unless other.values.size == values.size
 
-      other.values.each_with_index {|v, i| return false unless lv[i] === v || v === lv[i]}
+      other.values.each_with_index { |v, i| return false unless lv[i] === v || v === lv[i] }
     when Array
       return false unless other.size == values.size
 
-      other.each_with_index {|v, i| return false unless lv[i] === v || v === lv[i]}
+      other.each_with_index { |v, i| return false unless lv[i] === v || v === lv[i] }
     else
       false
     end

data/lib/puppet/util/network_device/base.rb

@@ -16,7 +16,7 @@ class Puppet::Util::NetworkDevice::Base
     if @autoloader.load(@url.scheme, Puppet.lookup(:current_environment))
       @transport = Puppet::Util::NetworkDevice::Transport.const_get(@url.scheme.capitalize).new(options[:debug])
       @transport.host = @url.host
-      @transport.port = @url.port || case @url.scheme ; when "ssh" ; 22 ; when "telnet" ; 23 ; end
+      @transport.port = @url.port || case @url.scheme; when "ssh"; 22; when "telnet"; 23; end
       @transport.user = @url.user
       @transport.password = @url.password
     end

data/lib/puppet/util/network_device/config.rb

@@ -57,7 +57,7 @@ class Puppet::Util::NetworkDevice::Config
               file_error_location = Puppet::Util::Errors.error_location(nil, file_line_count)
               device_error_location = Puppet::Util::Errors.error_location(nil, device.line)
               raise Puppet::Error, _("Duplicate device found at %{file_error_location}, already found at %{device_error_location}") %
-                  { file_error_location: file_error_location, device_error_location: device_error_location }
+                                   { file_error_location: file_error_location, device_error_location: device_error_location }
             end
             device = OpenStruct.new
             device.name = name
@@ -70,7 +70,7 @@ class Puppet::Util::NetworkDevice::Config
           else
             error_location_str = Puppet::Util::Errors.error_location(nil, file_line_count)
             raise Puppet::Error, _("Invalid entry at %{error_location}: %{file_text}") %
-                { error_location: error_location_str, file_text: line }
+                                 { error_location: error_location_str, file_text: line }
           end
         end
       end

data/lib/puppet/util/package/version/pip.rb

@@ -113,7 +113,7 @@ module Puppet::Util::Package::Version
     end
 
     def parse_local_version(local_version)
-      local_version.split(/[\\._-]/).map{|part| part =~ /[0-9]+/ && part !~ /[a-zA-Z]+/ ? part.to_i : part.downcase} if local_version
+      local_version.split(/[\\._-]/).map { |part| part =~ /[0-9]+/ && part !~ /[a-zA-Z]+/ ? part.to_i : part.downcase } if local_version
     end
 
     def compose_key(epoch, release, pre, post, dev, local)
@@ -138,7 +138,7 @@ module Puppet::Util::Package::Version
       if !local
         local_key = [[-Float::INFINITY, ""]]
       else
-        local_key = local.map{|i| (i.is_a? Integer) ? [i, ""] : [-Float::INFINITY, i]}
+        local_key = local.map { |i| (i.is_a? Integer) ? [i, ""] : [-Float::INFINITY, i] }
       end
 
       [epoch, release_key, pre_key, post_key, dev_key, local_key]

data/lib/puppet/util/package/version/range/lt.rb

@@ -4,7 +4,7 @@ require_relative '../../../../../puppet/util/package/version/range/simple'
 
 module Puppet::Util::Package::Version
   class Range
-    class Lt< Simple
+    class Lt < Simple
       def to_s
         "<#{@version}"
       end

data/lib/puppet/util/package/version/range.rb

@@ -38,15 +38,15 @@ module Puppet::Util::Package::Version
 
         case operator
         when '>'
-          Gt.new(version_class::parse(version))
+          Gt.new(version_class.parse(version))
         when '>='
-          GtEq.new(version_class::parse(version))
+          GtEq.new(version_class.parse(version))
         when '<'
-          Lt.new(version_class::parse(version))
+          Lt.new(version_class.parse(version))
         when '<='
-          LtEq.new(version_class::parse(version))
+          LtEq.new(version_class.parse(version))
         when ''
-          Eq.new(version_class::parse(version))
+          Eq.new(version_class.parse(version))
         else
           raise ValidationFailure, "Operator '#{operator}' is not implemented"
         end

data/lib/puppet/util/package.rb

@@ -12,7 +12,7 @@ module Puppet::Util::Package
     ax = version_a.scan(vre)
     bx = version_b.scan(vre)
 
-    while (ax.length>0 && bx.length>0)
+    while (ax.length > 0 && bx.length > 0)
       a = ax.shift
       b = bx.shift
 

data/lib/puppet/util/pidlock.rb

@@ -93,7 +93,7 @@ class Puppet::Util::Pidlock
       # On Windows, we're checking if the filesystem path name of the running
       # process is our vendored ruby:
       begin
-        exe_path = Puppet::Util::Windows::Process::get_process_image_name_by_pid(pid)
+        exe_path = Puppet::Util::Windows::Process.get_process_image_name_by_pid(pid)
         @lockfile.unlock unless exe_path =~ /\\bin\\ruby.exe$/
       rescue Puppet::Util::Windows::Error => e
         Puppet.debug("Failed to read pidfile #{file_path}: #{e.message}")

data/lib/puppet/util/plist.rb

@@ -43,7 +43,7 @@ module Puppet::Util::Plist
         Puppet.debug "Plist #{file_path} ill-formatted, converting with plutil"
         begin
           plist = Puppet::Util::Execution.execute(['/usr/bin/plutil', '-convert', 'xml1', '-o', '-', file_path],
-                                                  {:failonfail => true, :combine => true})
+                                                  { :failonfail => true, :combine => true })
           return parse_plist(plist)
         rescue Puppet::ExecutionFailure => detail
           message = _("Cannot read file %{file_path}; Puppet is skipping it.") % { file_path: file_path }
@@ -65,7 +65,7 @@ module Puppet::Util::Plist
 
       begin
         if plist_data =~ bad_xml_doctype
-          plist_data.gsub!( bad_xml_doctype, plist_xml_doctype )
+          plist_data.gsub!(bad_xml_doctype, plist_xml_doctype)
           Puppet.debug("Had to fix plist with incorrect DOCTYPE declaration: #{file_path}")
         end
       rescue ArgumentError => e
@@ -130,11 +130,12 @@ module Puppet::Util::Plist
     end
 
     def to_format(format)
-      if format.to_sym == :xml
+      case format.to_sym
+      when :xml
         CFPropertyList::List::FORMAT_XML
-      elsif format.to_sym == :binary
+      when :binary
         CFPropertyList::List::FORMAT_BINARY
-      elsif format.to_sym == :plain
+      when :plain
         CFPropertyList::List::FORMAT_PLAIN
       else
         raise FormatError.new "Unknown plist format #{format}"

data/lib/puppet/util/posix.rb

@@ -41,13 +41,13 @@ module Puppet::Util::POSIX
       user_gid = Puppet::Etc.getpwnam(user).gid
       ngroups = Puppet::FFI::POSIX::Constants::MAXIMUM_NUMBER_OF_GROUPS
 
-      while true do
+      loop do
         FFI::MemoryPointer.new(:int) do |ngroups_ptr|
           FFI::MemoryPointer.new(:uint, ngroups) do |groups_ptr|
             old_ngroups = ngroups
             ngroups_ptr.write_int(ngroups)
 
-            if Puppet::FFI::POSIX::Functions::getgrouplist(user, user_gid, groups_ptr, ngroups_ptr) != -1
+            if Puppet::FFI::POSIX::Functions.getgrouplist(user, user_gid, groups_ptr, ngroups_ptr) != -1
               groups_gids = groups_ptr.get_array_of_uint(0, ngroups_ptr.read_int)
 
               result = []
@@ -167,7 +167,7 @@ module Puppet::Util::POSIX
 
   private
 
-  # Get the specified id_field of a given field (user or group), 
+  # Get the specified id_field of a given field (user or group),
   # whether an ID name is provided
   def get_posix_value(location, id_field, field)
     begin
@@ -204,4 +204,3 @@ module Puppet::Util::POSIX
     end
   end
 end
-

data/lib/puppet/util/profiler/aggregate.rb

@@ -9,7 +9,7 @@ class Puppet::Util::Profiler::Aggregate < Puppet::Util::Profiler::WallClock
     @metrics_hash = Metric.new
   end
 
-  def shutdown()
+  def shutdown
     super
     @logger.call("AGGREGATE PROFILING RESULTS:")
     @logger.call("----------------------------")
@@ -40,7 +40,7 @@ class Puppet::Util::Profiler::Aggregate < Puppet::Util::Profiler::WallClock
   end
 
   def print_metrics(metrics_hash, prefix)
-    metrics_hash.sort_by {|_k,v| v.time }.reverse_each do |k,v|
+    metrics_hash.sort_by { |_k, v| v.time }.reverse_each do |k, v|
       @logger.call("#{prefix}#{k}: #{v.time} s (#{v.count} calls)")
       print_metrics(metrics_hash[k], "#{prefix}#{k} -> ")
     end
@@ -80,4 +80,3 @@ class Puppet::Util::Profiler::Aggregate < Puppet::Util::Profiler::WallClock
     end
   end
 end
-

data/lib/puppet/util/profiler/logging.rb

@@ -19,7 +19,7 @@ class Puppet::Util::Profiler::Logging
     @logger.call("PROFILE [#{@identifier}] #{@sequence} #{description}: #{profile_explanation}")
   end
 
-  def shutdown()
+  def shutdown
     # nothing to do
   end
 

data/lib/puppet/util/profiler/wall_clock.rb

@@ -13,8 +13,8 @@ class Puppet::Util::Profiler::WallClock < Puppet::Util::Profiler::Logging
   end
 
   def do_finish(context, description, metric_id)
-    {:time => context.stop,
-     :msg => _("took %{context} seconds") % { context: context }}
+    { :time => context.stop,
+      :msg => _("took %{context} seconds") % { context: context } }
   end
 
   class Timer
@@ -34,4 +34,3 @@ class Puppet::Util::Profiler::WallClock < Puppet::Util::Profiler::Logging
     end
   end
 end
-

data/lib/puppet/util/provider_features.rb

@@ -153,7 +153,7 @@ module Puppet::Util::ProviderFeatures
       @features.each do |name, feature|
         method = name.to_s + "?"
         @feature_module.send(:define_method, method) do
-          (is_a?(Class) ?  declared_feature?(name) : self.class.declared_feature?(name)) or feature.available?(self)
+          (is_a?(Class) ? declared_feature?(name) : self.class.declared_feature?(name)) or feature.available?(self)
         end
       end
 
@@ -181,4 +181,3 @@ module Puppet::Util::ProviderFeatures
     @features[name]
   end
 end
-

data/lib/puppet/util/rdoc/code_objects.rb

@@ -30,11 +30,11 @@ module RDoc
 
     attr_accessor :facts, :plugins
 
-    def initialize(name,superclass=nil)
+    def initialize(name, superclass = nil)
       @facts = []
       @plugins = []
       @nodes = {}
-      super(name,superclass)
+      super(name, superclass)
     end
 
     def add_plugin(plugin)
@@ -46,10 +46,11 @@ module RDoc
       meth.document_self = true
       meth.singleton = false
       meth.comment = plugin.comment
-      if type == 'function'
+      case type
+      when 'function'
         @function_container ||= add_module(NormalModule, "__functions__")
         @function_container.add_method(meth)
-      elsif type == 'type'
+      when 'type'
         @type_container ||= add_module(NormalModule, "__types__")
         @type_container.add_method(meth)
       end
@@ -64,7 +65,7 @@ module RDoc
 
     # Adds a module called __nodes__ and adds nodes to it as classes
     #
-    def add_node(name,superclass)
+    def add_node(name, superclass)
       cls = @nodes[name]
       if cls
         return cls
@@ -77,15 +78,15 @@ module RDoc
     end
 
     def each_fact
-      @facts.each {|c| yield c}
+      @facts.each { |c| yield c }
     end
 
     def each_plugin
-      @plugins.each {|c| yield c}
+      @plugins.each { |c| yield c }
     end
 
     def each_node
-      @nodes.each {|c| yield c}
+      @nodes.each { |c| yield c }
     end
 
     def nodes
@@ -102,7 +103,7 @@ module RDoc
     attr_accessor :resource_list, :requires, :childs, :realizes
 
     def initialize(name, superclass)
-      super(name,superclass)
+      super(name, superclass)
       @resource_list = []
       @requires = []
       @realizes = []
@@ -144,7 +145,7 @@ module RDoc
     # or class1::class2#method. Since our definitions are mapped to RDoc methods
     # but are written class1::class2::define we need to perform the lookup by
     # ourselves.
-    def find_symbol(symbol, method=nil)
+    def find_symbol(symbol, method = nil)
       result = super(symbol)
       if not result and symbol =~ /::/
         modules = symbol.split(/::/)

data/lib/puppet/util/rdoc/generators/puppet_generator.rb

@@ -37,11 +37,11 @@ module Generators
   module MarkUp
     alias :old_markup :markup
 
-    def new_markup(str, remove_para=false)
+    def new_markup(str, remove_para = false)
       first = @markup.nil?
       res = old_markup(str, remove_para)
       if first and not @markup.nil?
-        @markup.add_special(/\b([a-z]\w+(::\w+)*)/,:CROSSREF)
+        @markup.add_special(/\b([a-z]\w+(::\w+)*)/, :CROSSREF)
         # we need to call it again, since we added a rule
         res = old_markup(str, remove_para)
       end
@@ -52,9 +52,9 @@ module Generators
 
   # This is a specialized HTMLGenerator tailored to Puppet manifests
   class PuppetGenerator < HTMLGenerator
-    def PuppetGenerator.for(options)
-      AllReferences::reset
-      HtmlMethod::reset
+    def self.for(options)
+      AllReferences.reset
+      HtmlMethod.reset
 
       if options.all_one_file
         PuppetGeneratorInOne.new(options)
@@ -144,7 +144,7 @@ module Generators
         # generate nodes and plugins found
         classes.each do |k|
           if k.context.is_module?
-            k.context.each_node do |_name,node|
+            k.context.each_node do |_name, node|
               nodes << HTMLPuppetNode.new(node, toplevel, NODE_DIR, @options)
               @nodes << nodes.last
             end
@@ -216,7 +216,7 @@ module Generators
       res = []
       collection.sort.each do |f|
         if f.document_self
-          res << { "classlist" => CGI.escapeHTML("#{MODULE_DIR}/fr_#{f.index_name}.html"), "module" => CGI.escapeHTML("#{CLASS_DIR}/#{f.index_name}.html"),"name" => CGI.escapeHTML(f.index_name) }
+          res << { "classlist" => CGI.escapeHTML("#{MODULE_DIR}/fr_#{f.index_name}.html"), "module" => CGI.escapeHTML("#{CLASS_DIR}/#{f.index_name}.html"), "name" => CGI.escapeHTML(f.index_name) }
         end
       end
 
@@ -242,7 +242,8 @@ module Generators
           gen_composite_index(
             file,
             RDoc::Page::COMBO_INDEX,
-            "#{MODULE_DIR}/fr_#{file["file"].context.module_name}.html")
+            "#{MODULE_DIR}/fr_#{file["file"].context.module_name}.html"
+          )
         end
       end
     end
@@ -254,35 +255,35 @@ module Generators
       res1 = []
       collection['classes'].sort.each do |f|
         if f.document_self
-          res1 << { "href" => "../"+CGI.escapeHTML(f.path), "name" => CGI.escapeHTML(f.index_name) } unless f.context.is_module?
+          res1 << { "href" => "../" + CGI.escapeHTML(f.path), "name" => CGI.escapeHTML(f.index_name) } unless f.context.is_module?
         end
       end
 
       res2 = []
       collection['methods'].sort.each do |f|
-        res2 << { "href" => "../#{f.path}", "name" => f.index_name.sub(/\(.*\)$/,'') } if f.document_self
+        res2 << { "href" => "../#{f.path}", "name" => f.index_name.sub(/\(.*\)$/, '') } if f.document_self
       end
 
       module_name = []
       res3 = []
       res4 = []
       collection['modules'].sort.each do |f|
-        module_name << { "href" => "../"+CGI.escapeHTML(f.path), "name" => CGI.escapeHTML(f.index_name) }
+        module_name << { "href" => "../" + CGI.escapeHTML(f.path), "name" => CGI.escapeHTML(f.index_name) }
         unless f.facts.nil?
           f.facts.each do |fact|
-            res3 << {"href" => "../"+CGI.escapeHTML(AllReferences["PLUGIN(#{fact.name})"].path), "name" => CGI.escapeHTML(fact.name)}
+            res3 << { "href" => "../" + CGI.escapeHTML(AllReferences["PLUGIN(#{fact.name})"].path), "name" => CGI.escapeHTML(fact.name) }
           end
         end
         unless f.plugins.nil?
           f.plugins.each do |plugin|
-            res4 << {"href" => "../"+CGI.escapeHTML(AllReferences["PLUGIN(#{plugin.name})"].path), "name" => CGI.escapeHTML(plugin.name)}
+            res4 << { "href" => "../" + CGI.escapeHTML(AllReferences["PLUGIN(#{plugin.name})"].path), "name" => CGI.escapeHTML(plugin.name) }
           end
         end
       end
 
       res5 = []
       collection['nodes'].sort.each do |f|
-        res5 << { "href" => "../"+CGI.escapeHTML(f.path), "name" => CGI.escapeHTML(f.name) } if f.document_self
+        res5 << { "href" => "../" + CGI.escapeHTML(f.path), "name" => CGI.escapeHTML(f.name) } if f.document_self
       end
 
       values = {
@@ -298,10 +299,10 @@ module Generators
         'style_url' => style_url('', @options.css),
       }
 
-      values["defines"] = res2 if res2.size>0
-      values["facts"] = res3 if res3.size>0
-      values["plugins"] = res4 if res4.size>0
-      values["nodes"] = res5 if res5.size>0
+      values["defines"] = res2 if res2.size > 0
+      values["facts"] = res3 if res3.size > 0
+      values["plugins"] = res4 if res4.size > 0
+      values["nodes"] = res5 if res5.size > 0
 
       Puppet::FileSystem.open(filename, nil, "w:UTF-8") do |f|
         template.write_html_on(f, values)
@@ -322,7 +323,7 @@ module Generators
       end
 
       unless ref
-        for file in @files
+        @files.each do |file|
           if file.document_self and file.context.global
             ref = CGI.escapeHTML("#{CLASS_DIR}/#{file.context.module_name}.html")
             break
@@ -331,7 +332,7 @@ module Generators
       end
 
       unless ref
-        for file in @files
+        @files.each do |file|
           if file.document_self and !file.context.global
             ref = CGI.escapeHTML("#{CLASS_DIR}/#{file.context.module_name}.html")
             break
@@ -374,17 +375,17 @@ module Generators
   module ResourceContainer
     def collect_resources
       list = @context.resource_list
-      @resources = list.collect {|m| HTMLPuppetResource.new(m, self, @options) }
+      @resources = list.collect { |m| HTMLPuppetResource.new(m, self, @options) }
     end
 
-    def build_resource_summary_list(path_prefix='')
+    def build_resource_summary_list(path_prefix = '')
       collect_resources unless @resources
       resources = @resources.sort
       res = []
       resources.each do |r|
         res << {
           "name" => CGI.escapeHTML(r.name),
-          "aref" => Puppet::Util.uri_encode(path_prefix)+"\#"+Puppet::Util.uri_query_encode(r.aref)
+          "aref" => Puppet::Util.uri_encode(path_prefix) + "\#" + Puppet::Util.uri_query_encode(r.aref)
         }
       end
       res
@@ -500,7 +501,8 @@ module Generators
       template = TemplatePage.new(
         RDoc::Page::BODYINC,
         RDoc::Page::NODE_PAGE,
-        RDoc::Page::METHOD_LIST)
+        RDoc::Page::METHOD_LIST
+      )
       template.write_html_on(f, @values)
     end
 
@@ -620,7 +622,7 @@ module Generators
         res["full_path"]     = full_path
         res["full_path_url"] = aref_to(f.viewer.path) if f.document_self
 
-        res["cvsurl"] = cvs_url( @options.webcvs, full_path ) if @options.webcvs
+        res["cvsurl"] = cvs_url(@options.webcvs, full_path) if @options.webcvs
 
         files << res
       end
@@ -668,21 +670,21 @@ module Generators
       context.nodes.sort.each do |node|
         if node.document_self
           res <<
-          prefix <<
-          "Node " <<
-          href(url(node.viewer.path), "link", node.full_name) <<
-          "<br />\n"
+            prefix <<
+            "Node " <<
+            href(url(node.viewer.path), "link", node.full_name) <<
+            "<br />\n"
         end
       end
       res
     end
 
     def build_facts_summary_list
-      potentially_referenced_list(context.facts) {|fn| ["PLUGIN(#{fn})"] }
+      potentially_referenced_list(context.facts) { |fn| ["PLUGIN(#{fn})"] }
     end
 
     def build_plugins_summary_list
-      potentially_referenced_list(context.plugins) {|fn| ["PLUGIN(#{fn})"] }
+      potentially_referenced_list(context.plugins) { |fn| ["PLUGIN(#{fn})"] }
     end
 
     def facts
@@ -741,7 +743,8 @@ module Generators
       template = TemplatePage.new(
         RDoc::Page::BODYINC,
         RDoc::Page::PLUGIN_PAGE,
-        RDoc::Page::PLUGIN_LIST)
+        RDoc::Page::PLUGIN_LIST
+      )
       template.write_html_on(f, @values)
     end
 
@@ -798,7 +801,7 @@ module Generators
         res["full_path"]     = full_path
         res["full_path_url"] = aref_to(f.viewer.path) if f.document_self
 
-        res["cvsurl"] = cvs_url( @options.webcvs, full_path ) if @options.webcvs
+        res["cvsurl"] = cvs_url(@options.webcvs, full_path) if @options.webcvs
 
         files << res
       end
@@ -886,7 +889,7 @@ module Generators
       @context.document_self
     end
 
-    def find_symbol(symbol, method=nil)
+    def find_symbol(symbol, method = nil)
       res = @context.parent.find_symbol(symbol, method)
       res && res.viewer
     end