puppet 8.3.1 → 8.4.0

data/lib/puppet/pops/utils.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Provides utility methods
 module Puppet::Pops
 module Utils

data/lib/puppet/pops/validation/checker4_0.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/pops/evaluator/external_syntax_support'
 
 module Puppet::Pops
 module Validation
-
 # A Validator validates a model.
 #
 # Validation is performed on each model element in isolation. Each method should validate the model element's state
@@ -236,7 +236,9 @@ class Checker4_0 < Evaluator::LiteralEvaluator
     p = container
     case p
     when Model::AbstractResource
+      # do nothing
     when Model::CollectExpression
+      # do nothing
     else
       # protect against just testing a snippet that has no parent, error message will be a bit strange
       # but it is not for a real program.
@@ -282,6 +284,7 @@ class Checker4_0 < Evaluator::LiteralEvaluator
       # ok (a call to a type)
       return nil
     end
+
     case functor
     when Model::QualifiedName
       # ok
@@ -535,7 +538,7 @@ class Checker4_0 < Evaluator::LiteralEvaluator
 
   def internal_check_file_namespace(o)
     file = o.locator.file
-    return if file.nil? || file == '' #e.g. puppet apply -e '...'
+    return if file.nil? || file == '' # e.g. puppet apply -e '...'
 
     file_namespace = namespace_for_file(file)
     return if file_namespace == NO_NAMESPACE
@@ -549,13 +552,13 @@ class Checker4_0 < Evaluator::LiteralEvaluator
   def internal_check_top_construct_in_module(prog)
     return unless prog.is_a?(Model::Program) && !prog.body.nil?
 
-    #Check that this is a module autoloaded file
+    # Check that this is a module autoloaded file
     file = prog.locator.file
     return if file.nil?
     return if namespace_for_file(file) == NO_NAMESPACE
 
     body = prog.body
-    return if prog.body.is_a?(Model::Nop) #Ignore empty or comment-only files
+    return if prog.body.is_a?(Model::Nop) # Ignore empty or comment-only files
 
     if(body.is_a?(Model::BlockExpression))
       body.statements.each { |s| acceptor.accept(Issues::ILLEGAL_TOP_CONSTRUCT_LOCATION, s) unless valid_top_construct?(s) }
@@ -596,12 +599,12 @@ class Checker4_0 < Evaluator::LiteralEvaluator
 
     return adapter.file_to_namespace[file] = NO_NAMESPACE if initial_manifest?(path, env.manifest)
 
-    #All auto-loaded files from modules come from a module search path dir
+    # All auto-loaded files from modules come from a module search path dir
     relative_path = get_module_relative_path(path, env.full_modulepath)
 
     return adapter.file_to_namespace[file] = NO_NAMESPACE if relative_path == NO_PATH
 
-    #If a file comes from a module, but isn't in the right place, always error
+    # If a file comes from a module, but isn't in the right place, always error
     names = dir_to_names(relative_path)
 
     return adapter.file_to_namespace[file] = (names == BAD_MODULE_FILE ? BAD_MODULE_FILE : names.join("::").freeze)
@@ -620,20 +623,20 @@ class Checker4_0 < Evaluator::LiteralEvaluator
   # if none is found.
   def get_module_relative_path(file_path, modulepath_directories)
     clean_file = file_path.cleanpath.to_s
-    parent_path = modulepath_directories.find { |path_dir| is_parent_dir_of(path_dir, clean_file) }
+    parent_path = modulepath_directories.find { |path_dir| is_parent_dir_of?(path_dir, clean_file) }
     return NO_PATH if parent_path.nil?
 
     file_path.relative_path_from(Pathname.new(parent_path))
   end
   private :get_module_relative_path
 
-  def is_parent_dir_of(parent_dir, child_dir)
+  def is_parent_dir_of?(parent_dir, child_dir)
     parent_dir_path = Pathname.new(parent_dir)
     clean_parent = parent_dir_path.cleanpath.to_s + File::SEPARATOR
 
     return child_dir.start_with?(clean_parent)
   end
-  private :is_parent_dir_of
+  private :is_parent_dir_of?
 
   def dir_to_names(relative_path)
     # Downcasing here because check is case-insensitive
@@ -750,7 +753,7 @@ class Checker4_0 < Evaluator::LiteralEvaluator
   end
 
   def check_QueryExpression(o)
-    query(o.expr) if o.expr  # is optional
+    query(o.expr) if o.expr # is optional
   end
 
   def relation_Object(o)
@@ -784,7 +787,7 @@ class Checker4_0 < Evaluator::LiteralEvaluator
     end
   end
 
-  #relationship_side: resource
+  # relationship_side: resource
   #  | resourceref
   #  | collection
   #  | variable
@@ -870,6 +873,7 @@ class Checker4_0 < Evaluator::LiteralEvaluator
     # The expression must be a qualified name or an integer
     name_expr = o.expr
     return if name_expr.is_a?(Model::LiteralInteger)
+
     if !name_expr.is_a?(Model::QualifiedName)
       acceptor.accept(Issues::ILLEGAL_EXPRESSION, o, :feature => 'name', :container => o)
     else
@@ -1108,12 +1112,14 @@ class Checker4_0 < Evaluator::LiteralEvaluator
   # Case expression is idem, if test, and all options are idem
   def idem_CaseExpression(o)
     return false if !idem(o.test)
+
     ! o.options.any? {|opt| !idem(opt) }
   end
 
   # An option is idem if values and the then_expression are idem
   def idem_CaseOption(o)
     return false if o.values.any? { |value| !idem(value) }
+
     idem(o.then_expr)
   end
 

data/lib/puppet/pops/validation/tasks_checker.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
+
 module Puppet::Pops
 module Validation
-
 # Validator that limits the set of allowed expressions to not include catalog related operations
 # @api private
 class TasksChecker < Checker4_0
@@ -10,6 +10,7 @@ class TasksChecker < Checker4_0
     step = -1
     until container(step) == top do
       return true if container(step).is_a? Puppet::Pops::Model::ApplyBlockExpression
+
       step -= 1
     end
   end

data/lib/puppet/pops/validation/validator_factory_4_0.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
+
 module Puppet::Pops
 module Validation
 # Configures validation suitable for 4.0
 #
 class ValidatorFactory_4_0 < Factory
-  Issues = Issues
-
   # Produces the checker to use
   def checker diagnostic_producer
     if Puppet[:tasks]

data/lib/puppet/pops/validation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Puppet::Pops
 # A module with base functionality for validation of a model.
 #
@@ -9,7 +10,6 @@ module Puppet::Pops
 # * **DiagnosticFormatter** - produces human readable output for a Diagnostic
 #
 module Validation
-
   # This class is an abstract base implementation of a _model validation factory_ that creates a validator instance
   # and associates it with a fully configured DiagnosticProducer.
   #
@@ -26,7 +26,6 @@ module Validation
   # @api public
   #
   class Factory
-
     # Produces a validator with the given acceptor as the recipient of produced diagnostics.
     # The acceptor is where detected issues are received (and typically collected).
     #
@@ -135,6 +134,7 @@ module Validation
       unless issue.demotable? || level == :error
         raise Puppet::DevError.new(_("Attempt to demote the hard issue '%{issue_code}' to %{level}") % { issue_code: issue.issue_code, level: level })
       end
+
       @severities[issue] = level
     end
 
@@ -169,7 +169,6 @@ module Validation
   # sets keys in the given argument hash that may be used in the formatting of the issue message.
   #
   class DiagnosticProducer
-
     # A producer of severity for a given issue
     # @return [SeverityProducer]
     #
@@ -179,6 +178,7 @@ module Validation
     # @return [LabelProvider]
     #
     attr_reader :label_provider
+
     # Initializes this producer.
     #
     # @param acceptor [Acceptor] a sink/collector of diagnostic results
@@ -229,6 +229,7 @@ module Validation
     attr_reader :exception
     attr_reader :file
     attr_reader :source_pos
+
     def initialize severity, issue, file, source_pos, arguments={}, exception=nil
       @severity = severity
       @issue = issue
@@ -242,7 +243,7 @@ module Validation
 
     # Two diagnostics are considered equal if the have the same issue, location and severity
     # (arguments and exception are ignored)
-    #
+    # rubocop:disable Layout/ExtraSpacing
     def ==(o)
       self.class            == o.class             &&
         same_position?(o)                          &&
@@ -251,6 +252,7 @@ module Validation
         severity            == o.severity
     end
     alias eql? ==
+    # rubocop:enable Layout/ExtraSpacing
 
     # Position is equal if the diagnostic is not located or if referring to the same offset
     def same_position?(o)
@@ -353,7 +355,6 @@ module Validation
   # answer questions about what was diagnosed.
   #
   class Acceptor
-
     # All diagnostic in the order they were issued
     attr_reader :diagnostics
 
@@ -362,6 +363,7 @@ module Validation
 
     # The number of :error severity issues
     attr_reader :error_count
+
     # Initializes this diagnostics acceptor.
     # By default, the acceptor is configured with a default severity producer.
     # @param severity_producer [SeverityProducer] the severity producer to use to determine severity of an issue
@@ -438,7 +440,7 @@ module Validation
           @error_count -= 1
         when :warning
           @warning_count -= 1
-        # there is not ignore_count
+          # there is not ignore_count
         end
       end
       removed.empty? ? nil : removed

data/lib/puppet/pops/visitable.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Visitable is a mix-in module that makes a class visitable by a Visitor
 module Puppet::Pops::Visitable
   def accept(visitor, *arguments)

data/lib/puppet/pops/visitor.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Puppet::Pops
 # A Visitor performs delegation to a given receiver based on the configuration of the Visitor.
 # A new visitor is created with a given receiver, a method prefix, min, and max argument counts.
@@ -13,6 +14,7 @@ module Puppet::Pops
 #
 class Visitor
   attr_reader :receiver, :message, :min_args, :max_args, :cache
+
   def initialize(receiver, message, min_args=0, max_args=nil)
     raise ArgumentError.new("min_args must be >= 0") if min_args < 0
     raise ArgumentError.new("max_args must be >= min_args or nil") if max_args && max_args < min_args
@@ -34,6 +36,7 @@ class Visitor
   # Visit an explicit receiver
   def visit_this(receiver, thing, args)
     raise "Visitor Error: Too few arguments passed. min = #{@min_args}" unless args.length >= @min_args
+
     if @max_args
       raise "Visitor Error: Too many arguments passed. max = #{@max_args}" unless args.length <= @max_args
     end
@@ -44,18 +47,22 @@ class Visitor
       thing.class.ancestors().each do |ancestor|
         name = ancestor.name
         next if name.nil?
+
         method_name = :"#{@message}_#{name.split(DOUBLE_COLON).last}"
         next unless receiver.respond_to?(method_name, true)
+
         @cache[thing.class] = method_name
         return receiver.send(method_name, thing, *args)
       end
     end
+
     raise "Visitor Error: the configured receiver (#{receiver.class}) can't handle instance of: #{thing.class}"
   end
 
   # Visit an explicit receiver
   def visit_this_class(receiver, clazz, args)
     raise "Visitor Error: Too few arguments passed. min = #{@min_args}" unless args.length >= @min_args
+
     if @max_args
       raise "Visitor Error: Too many arguments passed. max = #{@max_args}" unless args.length <= @max_args
     end
@@ -66,12 +73,15 @@ class Visitor
       clazz.ancestors().each do |ancestor|
         name = ancestor.name
         next if name.nil?
+
         method_name = :"#{@message}_#{name.split(DOUBLE_COLON).last}"
         next unless receiver.respond_to?(method_name, true)
+
         @cache[clazz] = method_name
         return receiver.send(method_name, clazz, *args)
       end
     end
+
     raise "Visitor Error: the configured receiver (#{receiver.class}) can't handle instance of: #{clazz}"
   end
 
@@ -83,6 +93,7 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing)
     end
+
     visit_this(receiver, thing, NO_ARGS)
   end
 
@@ -94,6 +105,7 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing, arg)
     end
+
     visit_this(receiver, thing, [arg])
   end
 
@@ -105,6 +117,7 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing, arg1, arg2)
     end
+
     visit_this(receiver, thing, [arg1, arg2])
   end
 
@@ -116,8 +129,8 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing, arg1, arg2, arg3)
     end
+
     visit_this(receiver, thing, [arg1, arg2, arg3])
   end
-
 end
 end

data/lib/puppet/pops.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Puppet
   # The Pops language system. This includes the parser, evaluator, AST model, and
   # Binder.
@@ -61,6 +62,7 @@ module Puppet
     module Resource
       require_relative 'pops/resource/resource_type_impl'
     end
+
     module Evaluator
       require_relative 'pops/evaluator/literal_evaluator'
       require_relative 'pops/evaluator/callable_signature'

data/lib/puppet/property/boolean.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/coercion'
 
 class Puppet::Property::Boolean < Puppet::Property

data/lib/puppet/property/ensure.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/property'
 
 # This property is automatically added to any {Puppet::Type} that responds
@@ -39,7 +40,9 @@ class Puppet::Property::Ensure < Puppet::Property
     end
 
     # This doc will probably get overridden
+    # rubocop:disable Naming/MemoizedInstanceVariableName
     @doc ||= "The basic property that the resource should be in."
+    # rubocop:enable Naming/MemoizedInstanceVariableName
   end
 
   def self.inherited(sub)
@@ -95,7 +98,7 @@ class Puppet::Property::Ensure < Puppet::Property
 
   # If they're talking about the thing at all, they generally want to
   # say it should exist.
-  #defaultto :present
+  # defaultto :present
   defaultto do
     if @resource.managed?
       :present

data/lib/puppet/property/keyvalue.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/property'
 
 module Puppet
@@ -33,7 +34,7 @@ module Puppet
         hash_to_key_value_s(should_value)
       end
 
-      def is_to_s(current_value)
+      def is_to_s(current_value) # rubocop:disable Naming/PredicateName
         hash_to_key_value_s(current_value)
       end
 
@@ -65,7 +66,7 @@ module Puppet
       def process_current_hash(current)
         return {} if current == :absent
 
-        #inclusive means we are managing everything so if it isn't in should, its gone
+        # inclusive means we are managing everything so if it isn't in should, its gone
         current.each_key { |key| current[key] = nil } if inclusive?
         current
       end
@@ -76,7 +77,7 @@ module Puppet
         members = hashify_should
         current = process_current_hash(retrieve)
 
-        #shared keys will get overwritten by members
+        # shared keys will get overwritten by members
         should_value = current.merge(members)
 
         # Figure out the keys that will actually change in our Puppet run.
@@ -107,7 +108,7 @@ module Puppet
       # @return [Hash] the hash from the provider, or `:absent`
       #
       def retrieve
-        #ok, some 'convention' if the keyvalue property is named properties, provider should implement a properties method
+        # ok, some 'convention' if the keyvalue property is named properties, provider should implement a properties method
         key_hash = provider.send(name) if provider
         if key_hash && key_hash != :absent
           return key_hash

data/lib/puppet/property/list.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/property'
 
 module Puppet
@@ -7,8 +8,7 @@ module Puppet
     # For an ordered list see {Puppet::Property::OrderedList}.
     #
     class List < Property
-
-      def is_to_s(currentvalue)
+      def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
         currentvalue == :absent ? super(currentvalue) : currentvalue.join(delimiter)
       end
 
@@ -25,7 +25,7 @@ module Puppet
         @resource[membership] == :inclusive
       end
 
-      #dearrayify was motivated because to simplify the implementation of the OrderedList property
+      # dearrayify was motivated because to simplify the implementation of the OrderedList property
       def dearrayify(array)
         array.sort.join(delimiter)
       end
@@ -34,7 +34,7 @@ module Puppet
         return nil unless @should
 
         members = @should
-        #inclusive means we are managing everything so if it isn't in should, its gone
+        # inclusive means we are managing everything so if it isn't in should, its gone
         members = add_should_with_current(members, retrieve) if ! inclusive?
 
         dearrayify(members)
@@ -45,7 +45,7 @@ module Puppet
       end
 
       def retrieve
-        #ok, some 'convention' if the list property is named groups, provider should implement a groups method
+        # ok, some 'convention' if the list property is named groups, provider should implement a groups method
         tmp = provider.send(name) if provider
         if tmp && tmp != :absent
           return tmp.instance_of?(Array) ? tmp : tmp.split(delimiter)

data/lib/puppet/property/ordered_list.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/property/list'
 
 module Puppet
@@ -11,12 +12,11 @@ module Puppet
     # For an unordered list see {Puppet::Property::List}.
     #
     class OrderedList < List
-
       def add_should_with_current(should, current)
         if current.is_a?(Array)
-          #tricky trick
-          #Preserve all the current items in the list
-          #but move them to the back of the line
+          # tricky trick
+          # Preserve all the current items in the list
+          # but move them to the back of the line
           should = should + (current - should)
         end
         should

data/lib/puppet/property.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # The virtual base class for properties, which are the self-contained building
 # blocks for actually doing work on the system.
 
@@ -96,8 +97,9 @@ class Puppet::Property < Puppet::Parameter
     #
     def array_matching=(value)
       value = value.intern if value.is_a?(String)
-      #TRANSLATORS 'Property#array_matching', 'first', and 'all' should not be translated
+      # TRANSLATORS 'Property#array_matching', 'first', and 'all' should not be translated
       raise ArgumentError, _("Supported values for Property#array_matching are 'first' and 'all'") unless [:first, :all].include?(value)
+
       @array_matching = value
     end
 
@@ -169,6 +171,7 @@ class Puppet::Property < Puppet::Parameter
         if instance_methods(false).include?(method)
           raise ArgumentError, _("Attempt to redefine method %{method} with block") % { method: method }
         end
+
         define_method(method, &value.block)
       else
         # Let the method be an alias for calling the providers setter unless we already have this method
@@ -231,11 +234,10 @@ class Puppet::Property < Puppet::Parameter
     name == :ensure or return (name.to_s + "_changed").to_sym
 
     return (resource.type.to_s + case value
-    when :present; "_created"
-    when :absent; "_removed"
-    else
-      "_changed"
-    end).to_sym
+                                 when :present; "_created"
+                                 when :absent;  "_removed"
+                                 else           "_changed"
+                                 end).to_sym
   end
 
   # Produces an event describing a change of this property.
@@ -367,7 +369,7 @@ class Puppet::Property < Puppet::Parameter
     rescue
       # Certain operations may fail, but we don't want to fail the transaction if we can
       # avoid it
-      #TRANSLATORS 'insync_values?' should not be translated
+      # TRANSLATORS 'insync_values?' should not be translated
       msg = _("Unknown failure using insync_values? on type: %{type} / property: %{name} to compare values %{should} and %{is}") %
           { type: self.resource.ref, name: self.name, should: should, is: is }
       Puppet.info(msg)
@@ -403,7 +405,7 @@ class Puppet::Property < Puppet::Parameter
   # are not already in suitable form.
   # @param value [Object] the value to format as a string
   # @return [String] a pretty printing string
-  def is_to_s(value)
+  def is_to_s(value) # rubocop:disable Naming/PredicateName
     self.class.format_value_for_display(value)
   end
 
@@ -414,9 +416,9 @@ class Puppet::Property < Puppet::Parameter
   #
   def log(msg)
     Puppet::Util::Log.create(
-      :level   => resource[:loglevel],
+      :level => resource[:loglevel],
       :message => msg,
-      :source  => self
+      :source => self
     )
   end
 
@@ -593,7 +595,7 @@ class Puppet::Property < Puppet::Parameter
       features = Array(features)
       needed_features = features.collect { |f| f.to_s }.join(", ")
       unless provider.satisfies?(features)
-        #TRANSLATORS 'Provider' refers to a Puppet provider class
+        # TRANSLATORS 'Provider' refers to a Puppet provider class
         raise ArgumentError, _("Provider %{provider} must have features '%{needed_features}' to set '%{property}' to '%{value}'") %
             { provider: provider.class.name, needed_features: needed_features, property: self.class.name, value: value }
       end

data/lib/puppet/provider/aix_object.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Common code for AIX user/group providers.
 class Puppet::Provider::AixObject < Puppet::Provider
   desc "Generic AIX resource provider"
@@ -334,6 +335,7 @@ class Puppet::Provider::AixObject < Puppet::Provider
     raise ArgumentError, _("Cannot have both 'forcelocal' and 'ia_load_module' at the same time!") if @resource[:ia_load_module] && @resource[:forcelocal]
     return ["-R", @resource[:ia_load_module].to_s] if @resource[:ia_load_module]
     return ["-R", "files"] if @resource[:forcelocal]
+
     []
   end
 
@@ -364,6 +366,7 @@ class Puppet::Provider::AixObject < Puppet::Provider
   # Gets a Puppet property's value from object_info
   def get(property)
     return :absent unless exists?
+
     object_info[property] || :absent
   end
 
@@ -418,6 +421,7 @@ class Puppet::Provider::AixObject < Puppet::Provider
   # the attributes property.
   def object_info(refresh = false)
     return @object_info if @object_info && ! refresh
+
     @object_info = nil
 
     begin
@@ -464,6 +468,7 @@ class Puppet::Provider::AixObject < Puppet::Provider
     mappings[:aix_attribute].each do |property, aix_attribute|
       property_should = @resource.should(property)
       next if property_should.nil?
+
       attributes[aix_attribute.name] = aix_attribute.convert_property_value(property_should)
     end
 

data/lib/puppet/provider/command.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # A command that can be executed on the system
 class Puppet::Provider::Command
   attr_reader :executable

data/lib/puppet/provider/confine.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Confines have been moved out of the provider as they are also used for other things.
 # This provides backwards compatibility for people still including this old location.
 require_relative '../../puppet/provider'

data/lib/puppet/provider/exec/posix.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/provider/exec'
 
 Puppet::Type.type(:exec).provide :posix, :parent => Puppet::Provider::Exec do
@@ -37,6 +38,7 @@ Puppet::Type.type(:exec).provide :posix, :parent => Puppet::Provider::Exec do
       elsif !File.executable?(exe)
         raise ArgumentError, _("'%{exe}' is not executable") % { exe: exe }
       end
+
       return
     end
 

data/lib/puppet/provider/exec/shell.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Puppet::Type.type(:exec).provide :shell, :parent => :posix do
   include Puppet::Util::Execution
 

data/lib/puppet/provider/exec/windows.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/provider/exec'
 
 Puppet::Type.type(:exec).provide :windows, :parent => Puppet::Provider::Exec do
-
   confine    'os.name' => :windows
   defaultfor 'os.name' => :windows
 
@@ -42,6 +42,7 @@ Puppet::Type.type(:exec).provide :windows, :parent => Puppet::Provider::Exec do
       elsif !File.file?(exe)
         raise ArgumentError, _("'%{exe}' is a %{klass}, not a file") % { exe: exe, klass: File.ftype(exe) }
       end
+
       return
     end