puppet 8.3.1 → 8.4.0

data/lib/puppet/face/epp.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/pops'
 require_relative '../../puppet/parser/files'
@@ -102,8 +103,7 @@ Puppet::Face.define(:epp, '0.0.1') do
     end
   end
 
-
-  action (:dump) do
+  action(:dump) do
     summary _("Outputs a dump of the internal template parse tree for debugging")
     arguments "[--format <old|pn|json>] [--pretty] { -e <source> | [<templates> ...] } "
     returns _("A dump of the resulting AST model unless there are syntax or validation errors.")
@@ -197,14 +197,14 @@ Puppet::Face.define(:epp, '0.0.1') do
 
         if !missing_files.empty?
           raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{missing_files_list}") %
-              { missing_files_list:  missing_files.collect { |f| "   #{f}" }.join("\n") }
+              { missing_files_list: missing_files.collect { |f| "   #{f}" }.join("\n") }
         end
       end
       buffer.string
     end
   end
 
-  action (:render) do
+  action(:render) do
     summary _("Renders an epp template as text")
     arguments "-e <source> | [<templates> ...] "
     returns _("A rendered result of one or more given templates.")
@@ -334,7 +334,6 @@ Puppet::Face.define(:epp, '0.0.1') do
 
       compiler = create_compiler(options)
       compiler.with_context_overrides('For rendering epp') do
-
         # Print to a buffer since the face needs to return the resulting string
         # and the face API is "all or nothing"
         #
@@ -361,6 +360,7 @@ Puppet::Face.define(:epp, '0.0.1') do
           end
         end
         raise Puppet::Error, _("error while rendering epp") unless status
+
         buffer.string
       end
     end
@@ -530,6 +530,7 @@ Puppet::Face.define(:epp, '0.0.1') do
       unless given_facts.instance_of?(Hash)
         raise _("Incorrect formatted data in %{fact_file} given via the --facts flag") % { fact_file: fact_file }
       end
+
       # It is difficult to add to or modify the set of facts once the node is created
       # as changes does not show up in parameters. Rather than manually patching up
       # a node and risking future regressions, a new node is created from scratch
@@ -563,5 +564,4 @@ Puppet::Face.define(:epp, '0.0.1') do
       nil
     end
   end
-
 end

data/lib/puppet/face/facts.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/indirector/face'
 require_relative '../../puppet/node/facts'
 
@@ -59,7 +60,7 @@ Puppet::Indirector::Face.define(:facts, '0.0.1') do
 
     render_as :json
 
-    when_invoked do |options|
+    when_invoked do |_options|
       # Use `agent` sections  settings for certificates, Puppet Server URL,
       # etc. instead of `user` section settings.
       Puppet.settings.preferred_run_mode = :agent
@@ -76,8 +77,8 @@ Puppet::Indirector::Face.define(:facts, '0.0.1') do
       puppet = session.route_to(:puppet)
 
       Puppet.notice(_("Uploading facts for '%{node}' to '%{server}'") % {
-                    node: Puppet[:node_name_value],
-                    server: puppet.url.hostname})
+        node: Puppet[:node_name_value],
+        server: puppet.url.hostname})
 
       puppet.put_facts(Puppet[:node_name_value], facts: facts, environment: Puppet.lookup(:current_environment).name.to_s)
       nil

data/lib/puppet/face/generate.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/generate/type'
 
@@ -56,6 +57,7 @@ Puppet::Face.define(:generate, '0.1.0') do
       if Puppet::FileSystem.exist?(outputdir) && !Puppet::FileSystem.directory?(outputdir)
         raise ArgumentError, _("The output directory '%{outputdir}' exists and is not a directory") % { outputdir: outputdir }
       end
+
       Puppet::FileSystem::mkpath(outputdir)
 
       generator.generate(inputs, outputdir, options[:force])

data/lib/puppet/face/help.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/application/face_base'
 require_relative '../../puppet/util/constant_inflector'
@@ -41,7 +42,7 @@ Puppet::Face.define(:help, '0.0.1') do
       end
 
       if args.length > 2
-        #TRANSLATORS 'puppet help' is a command line and should not be translated
+        # TRANSLATORS 'puppet help' is a command line and should not be translated
         raise ArgumentError, _("The 'puppet help' command takes two (optional) arguments: a subcommand and an action")
       end
 
@@ -51,7 +52,7 @@ Puppet::Face.define(:help, '0.0.1') do
           version = options[:version]
         else
           if args.length == 0
-            #TRANSLATORS '--version' is a command line option and should not be translated
+            # TRANSLATORS '--version' is a command line option and should not be translated
             raise ArgumentError, _("Supplying a '--version' only makes sense when a Faces subcommand is given")
           end
         end
@@ -62,6 +63,7 @@ Puppet::Face.define(:help, '0.0.1') do
         if actionname
           raise ArgumentError, _("The legacy subcommand '%{sub_command}' does not support supplying an action") % { sub_command: facename }
         end
+
         # legacy apps already emit ronn output
         return render_application_help(facename)
       else
@@ -209,7 +211,7 @@ Puppet::Face.define(:help, '0.0.1') do
     # depends on the implementation coincidence of how our pages are
     # formatted.  If we can't match the pattern we expect we return the empty
     # string to ensure we don't blow up in the summary. --daniel 2011-04-11
-    while line = help.shift do #rubocop:disable Lint/AssignmentInCondition
+    while line = help.shift do # rubocop:disable Lint/AssignmentInCondition
       md = /^puppet-#{appname}\([^\)]+\) -- (.*)$/.match(line)
       if md
         return md[1]
@@ -220,7 +222,7 @@ Puppet::Face.define(:help, '0.0.1') do
   # This should absolutely be a private method, but for some reason it appears
   #  that you can't use the 'private' keyword inside of a Face definition.
   #  See #14205.
-  #private :horribly_extract_summary_from
+  # private :horribly_extract_summary_from
 
   def exclude_from_docs?(appname)
     %w{face_base indirection_base report status}.include? appname
@@ -228,7 +230,7 @@ Puppet::Face.define(:help, '0.0.1') do
   # This should absolutely be a private method, but for some reason it appears
   #  that you can't use the 'private' keyword inside of a Face definition.
   #  See #14205.
-  #private :exclude_from_docs?
+  # private :exclude_from_docs?
 
   def is_face_app?(appname)
     clazz = Puppet::Application.find(appname)
@@ -238,6 +240,5 @@ Puppet::Face.define(:help, '0.0.1') do
   # This should probably be a private method, but for some reason it appears
   #  that you can't use the 'private' keyword inside of a Face definition.
   #  See #14205.
-  #private :is_face_app?
-
+  # private :is_face_app?
 end

data/lib/puppet/face/module/changes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Puppet::Face.define(:module, '1.0.0') do
   action(:changes) do
     summary _("Show modified files of an installed module.")
@@ -27,6 +28,7 @@ Puppet::Face.define(:module, '1.0.0') do
       unless root_path
         raise ArgumentError, _("Could not find a valid module at %{path}") % { path: path.inspect }
       end
+
       Puppet::ModuleTool::Applications::Checksummer.run(root_path, options)
     end
 

data/lib/puppet/face/module/install.rb

@@ -1,5 +1,6 @@
 # encoding: UTF-8
 # frozen_string_literal: true
+
 require_relative '../../../puppet/forge'
 require_relative '../../../puppet/module_tool/install_directory'
 require 'pathname'
@@ -129,7 +130,7 @@ Puppet::Face.define(:module, '1.0.0') do
       Puppet::ModuleTool::Applications::Installer.run(name, install_dir, options)
     end
 
-    when_rendering :console do |return_value, name, options|
+    when_rendering :console do |return_value, name, _options|
       if return_value[:result] == :noop
         Puppet.notice _("Module %{name} %{version} is already installed.") % { name: name, version: return_value[:version] }
         exit 0

data/lib/puppet/face/module/list.rb

@@ -64,7 +64,7 @@ Puppet::Face.define(:module, '1.0.0') do
       modules_by_path = environment.modules_by_path
 
       {
-        :environment     => environment,
+        :environment => environment,
         :modules_by_path => modules_by_path,
         :unmet_dependencies => unmet_dependencies(environment),
       }
@@ -90,12 +90,12 @@ Puppet::Face.define(:module, '1.0.0') do
           modules_by_num_requires = modules.sort_by {|m| m.required_by.size}
           @seen = {}
           tree = list_build_tree(modules_by_num_requires, [], nil,
-            :label_unmet => true, :path => path, :label_invalid => false)
+                                 :label_unmet => true, :path => path, :label_invalid => false)
         else
           tree = []
-          modules.sort_by { |mod| mod.forge_name or mod.name  }.each do |mod|
+          modules.sort_by { |mod| mod.forge_name or mod.name }.each do |mod|
             tree << list_build_node(mod, path, :label_unmet => false,
-                      :path => path, :label_invalid => true)
+                                               :path => path, :label_invalid => true)
           end
         end
 
@@ -106,7 +106,6 @@ Puppet::Face.define(:module, '1.0.0') do
     end
   end
 
-
   def unmet_dependencies(environment)
     error_types = [:non_semantic_version, :version_mismatch, :missing]
 
@@ -136,7 +135,7 @@ Puppet::Face.define(:module, '1.0.0') do
             msg = _("'%{parent_name}' (%{parent_version}) requires '%{dependency_name}' (%{dependency_version})") % { parent_name: parent_name, parent_version: parent_version, dependency_name: dep_name, dependency_version: version_constraint }
             unmet_deps[type][dep[:name]][:errors] << msg
             unmet_deps[type][dep[:name]][:parent] = {
-              :name    => dep[:parent][:name],
+              :name => dep[:parent][:name],
               :version => parent_version
             }
             unmet_deps[type][dep[:name]][:version] = installed_version
@@ -147,7 +146,6 @@ Puppet::Face.define(:module, '1.0.0') do
     unmet_deps
   end
 
-
   def warn_unmet_dependencies(environment)
     @unmet_deps = unmet_dependencies(environment)
 
@@ -215,6 +213,7 @@ Puppet::Face.define(:module, '1.0.0') do
   def list_build_tree(list, ancestors=[], parent=nil, params={})
     list.map do |mod|
       next if @seen[(mod.forge_name or mod.name)]
+
       node = list_build_node(mod, parent, params)
       @seen[(mod.forge_name or mod.name)] = true
 
@@ -229,7 +228,7 @@ Puppet::Face.define(:module, '1.0.0') do
           node[:dependencies] << { :text => str }
         end
         node[:dependencies] += list_build_tree(mod.dependencies_as_modules,
-          ancestors + [mod], mod, params)
+                                               ancestors + [mod], mod, params)
       end
 
       node

data/lib/puppet/face/module/uninstall.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Puppet::Face.define(:module, '1.0.0') do
   action(:uninstall) do
     summary _("Uninstall a puppet module.")

data/lib/puppet/face/module.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/module_tool'
 require_relative '../../puppet/util/colors'

data/lib/puppet/face/node/clean.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
+
 Puppet::Face.define(:node, '0.0.1') do
   action(:clean) do
-
     summary _("Clean up signed certs, cached facts, node objects, and reports for a node stored by the puppetmaster")
     arguments _("<host1> [<host2> ...]")
     description <<-'EOT'
@@ -103,6 +103,7 @@ Puppet::Face.define(:node, '0.0.1') do
       type = environment.known_resource_types.find_definition(resource.restype)
       return true if type && type.arguments.keys.include?('ensure')
     end
+
     return false
   end
 end

data/lib/puppet/face/node.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/indirector/face'
 Puppet::Indirector::Face.define(:node, '0.0.1') do
   copyright "Puppet Inc.", 2011
@@ -18,7 +19,7 @@ Puppet::Indirector::Face.define(:node, '0.0.1') do
   find = get_action(:find)
   find.summary _("Retrieve a node object.")
   find.arguments _("<host>")
-  #TRANSLATORS the following are specific names and should not be translated `classes`, `environment`, `expiration`, `name`, `parameters`, Puppet::Node
+  # TRANSLATORS the following are specific names and should not be translated `classes`, `environment`, `expiration`, `name`, `parameters`, Puppet::Node
   find.returns _(<<-'EOT')
     A hash containing the node's `classes`, `environment`, `expiration`, `name`,
     `parameters` (its facts, combined with any ENC-set parameters), and `time`.

data/lib/puppet/face/parser.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/parser'
 
@@ -100,8 +101,7 @@ Puppet::Face.define(:parser, '0.0.1') do
     end
   end
 
-
-  action (:dump) do
+  action(:dump) do
     summary _("Outputs a dump of the internal parse tree for debugging")
     arguments "[--format <old|pn|json>] [--pretty] { -e <source> | [<templates> ...] } "
     returns _("A dump of the resulting AST model unless there are syntax or validation errors.")

data/lib/puppet/face/plugin.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/configurer/plugin_handler'
 
@@ -39,7 +40,7 @@ Puppet::Face.define(:plugin, '0.0.1') do
       $ Puppet::Face[:plugin, '0.0.1'].download
     EOT
 
-    when_invoked do |options|
+    when_invoked do |_options|
       remote_environment_for_plugins = Puppet::Node::Environment.remote(Puppet[:environment])
 
       begin

data/lib/puppet/face/report.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/indirector/face'
 
 Puppet::Indirector::Face.define(:report, '0.0.1') do
@@ -39,7 +40,7 @@ Puppet::Indirector::Face.define(:report, '0.0.1') do
           Puppet::Face[:report, '0.0.1'].submit(report)
           return report
     EOT
-    when_invoked do |report, options|
+    when_invoked do |report, _options|
       begin
         Puppet::Transaction::Report.indirection.terminus_class = :rest
         Puppet::Face[:report, "0.0.1"].save(report)

data/lib/puppet/face/resource.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/indirector/face'
 
 Puppet::Indirector::Face.define(:resource, '0.0.1') do

data/lib/puppet/face.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # The public name of this feature is 'face', but we have hidden all the
 # plumbing over in the 'interfaces' namespace to make clear the distinction
 # between the two.

data/lib/puppet/feature/base.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 # Add the simple features, all in one file.
@@ -57,7 +58,7 @@ Puppet.features.add(:manages_symlinks) do
       require 'ffi'
       extend FFI::Library
 
-      def self.is_implemented
+      def self.is_implemented # rubocop:disable Naming/PredicateName
         begin
           ffi_lib :kernel32
           attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean

data/lib/puppet/feature/bolt.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:bolt, :libs => ['bolt'])

data/lib/puppet/feature/cfpropertylist.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:cfpropertylist, :libs => ['cfpropertylist'])

data/lib/puppet/feature/eventlog.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 if Puppet::Util::Platform.windows?

data/lib/puppet/feature/hiera_eyaml.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:hiera_eyaml, :libs => ['hiera/backend/eyaml/parser/parser'])

data/lib/puppet/feature/hocon.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:hocon, :libs => ['hocon'])

data/lib/puppet/feature/libuser.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 require_relative '../../puppet/util/libuser'
 
 Puppet.features.add(:libuser) {
-   File.executable?("/usr/sbin/lgroupadd") and
-   File.executable?("/usr/sbin/luseradd")  and
-   Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
+  File.executable?("/usr/sbin/lgroupadd") and
+  File.executable?("/usr/sbin/luseradd")  and
+  Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
 }

data/lib/puppet/feature/msgpack.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:msgpack, :libs => ["msgpack"])

data/lib/puppet/feature/pe_license.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
-#Is the pe license library installed providing the ability to read licenses.
+# Is the pe license library installed providing the ability to read licenses.
 Puppet.features.add(:pe_license, :libs => %{pe_license})

data/lib/puppet/feature/pson.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 # PSON is deprecated, use JSON instead

data/lib/puppet/feature/selinux.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:selinux, :libs => ["selinux"])

data/lib/puppet/feature/ssh.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:ssh, :libs => %{net/ssh})

data/lib/puppet/feature/telnet.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add :telnet do

data/lib/puppet/feature/zlib.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 # We want this to load if possible, but it's not automatically

data/lib/puppet/ffi/posix/constants.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/posix'
 
 module Puppet::FFI::POSIX

data/lib/puppet/ffi/posix/functions.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/posix'
 
 module Puppet::FFI::POSIX
   module Functions
-
     extend FFI::Library
 
     ffi_convention :stdcall

data/lib/puppet/ffi/posix.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'ffi'
 
 module Puppet

data/lib/puppet/ffi/windows/api_types.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/windows'
 require_relative '../../../puppet/util/windows/string'