puppet 8.3.1-universal-darwin → 8.5.0-universal-darwin

data/lib/puppet/ffi/windows/functions.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::FFI::Windows
   module Functions
-
     extend FFI::Library
     include Puppet::FFI::Windows::Constants
 
@@ -40,8 +40,8 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :CreateProcessW,
-      [:lpcwstr, :lpwstr, :pointer, :pointer, :win32_bool,
-       :dword, :lpvoid, :lpcwstr, :pointer, :pointer], :bool
+                            [:lpcwstr, :lpwstr, :pointer, :pointer, :win32_bool,
+                             :dword, :lpvoid, :lpcwstr, :pointer, :pointer], :bool
 
     # https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-openprocess
     # HANDLE OpenProcess(
@@ -76,8 +76,8 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :CreateProcessWithLogonW,
-      [:lpcwstr, :lpcwstr, :lpcwstr, :dword, :lpcwstr, :lpwstr,
-       :dword, :lpvoid, :lpcwstr, :pointer, :pointer], :bool
+                            [:lpcwstr, :lpcwstr, :lpcwstr, :dword, :lpcwstr, :lpwstr,
+                             :dword, :lpvoid, :lpcwstr, :pointer, :pointer], :bool
 
     # https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-osfhandle?view=vs-2019
     # intptr_t _get_osfhandle(
@@ -103,7 +103,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :WaitForSingleObject,
-      [:handle, :dword], :dword, :blocking => true
+                            [:handle, :dword], :dword, :blocking => true
 
     # https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-waitformultipleobjects
     #   DWORD WaitForMultipleObjects(
@@ -114,7 +114,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :WaitForMultipleObjects,
-      [:dword, :phandle, :win32_bool, :dword], :dword
+                            [:dword, :phandle, :win32_bool, :dword], :dword
 
     # https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-createeventw
     # HANDLE CreateEventW(
@@ -125,7 +125,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :CreateEventW,
-      [:pointer, :win32_bool, :win32_bool, :lpcwstr], :handle
+                            [:pointer, :win32_bool, :win32_bool, :lpcwstr], :handle
 
     # https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createthread
     # HANDLE CreateThread(
@@ -138,7 +138,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :CreateThread,
-      [:pointer, :size_t, :pointer, :lpvoid, :dword, :lpdword], :handle, :blocking => true
+                            [:pointer, :size_t, :pointer, :lpvoid, :dword, :lpdword], :handle, :blocking => true
 
     # https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-setevent
     # BOOL SetEvent(
@@ -146,7 +146,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :SetEvent,
-      [:handle], :win32_bool
+                            [:handle], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms683189(v=vs.85).aspx
     # BOOL WINAPI GetExitCodeProcess(
@@ -155,7 +155,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetExitCodeProcess,
-      [:handle, :lpdword], :win32_bool
+                            [:handle, :lpdword], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms683179(v=vs.85).aspx
     # HANDLE WINAPI GetCurrentProcess(void);
@@ -173,7 +173,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :FreeEnvironmentStringsW,
-      [:pointer], :win32_bool
+                            [:pointer], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms686206(v=vs.85).aspx
     # BOOL WINAPI SetEnvironmentVariableW(
@@ -182,7 +182,7 @@ module Puppet::FFI::Windows
     #   );
     ffi_lib :kernel32
     attach_function_private :SetEnvironmentVariableW,
-      [:lpcwstr, :lpcwstr], :win32_bool
+                            [:lpcwstr, :lpcwstr], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms684320(v=vs.85).aspx
     # HANDLE WINAPI OpenProcess(
@@ -192,7 +192,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :OpenProcess,
-      [:dword, :win32_bool, :dword], :handle
+                            [:dword, :win32_bool, :dword], :handle
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa379295(v=vs.85).aspx
     # BOOL WINAPI OpenProcessToken(
@@ -202,7 +202,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :OpenProcessToken,
-      [:handle, :dword, :phandle], :win32_bool
+                            [:handle, :dword, :phandle], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-queryfullprocessimagenamew
     # BOOL WINAPI QueryFullProcessImageName(
@@ -213,7 +213,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :QueryFullProcessImageNameW,
-      [:handle, :dword, :lpwstr, :pdword], :win32_bool
+                            [:handle, :dword, :lpwstr, :pdword], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/Windows/desktop/aa379180(v=vs.85).aspx
     # BOOL WINAPI LookupPrivilegeValue(
@@ -223,7 +223,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :LookupPrivilegeValueW,
-      [:lpcwstr, :lpcwstr, :pointer], :win32_bool
+                            [:lpcwstr, :lpcwstr, :pointer], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa446671(v=vs.85).aspx
     # BOOL WINAPI GetTokenInformation(
@@ -235,7 +235,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :GetTokenInformation,
-      [:handle, TOKEN_INFORMATION_CLASS, :lpvoid, :dword, :pdword ], :win32_bool
+                            [:handle, TOKEN_INFORMATION_CLASS, :lpvoid, :dword, :pdword], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx
     # BOOL WINAPI GetVersionEx(
@@ -243,7 +243,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetVersionExW,
-      [:pointer], :win32_bool
+                            [:pointer], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/dd318123(v=vs.85).aspx
     # LANGID GetSystemDefaultUILanguage(void);
@@ -258,7 +258,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :OpenSCManagerW,
-      [:lpcwstr, :lpcwstr, :dword], :handle
+                            [:lpcwstr, :lpcwstr, :dword], :handle
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/Winsvc/nf-winsvc-openservicew
     # SC_HANDLE OpenServiceW(
@@ -268,7 +268,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :OpenServiceW,
-      [:handle, :lpcwstr, :dword], :handle
+                            [:handle, :lpcwstr, :dword], :handle
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/Winsvc/nf-winsvc-closeservicehandle
     # BOOL CloseServiceHandle(
@@ -276,7 +276,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :CloseServiceHandle,
-      [:handle], :win32_bool
+                            [:handle], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/winsvc/nf-winsvc-queryservicestatusex
     # BOOL QueryServiceStatusEx(
@@ -291,7 +291,7 @@ module Puppet::FFI::Windows
     )
     ffi_lib :advapi32
     attach_function_private :QueryServiceStatusEx,
-      [:handle, SC_STATUS_TYPE, :lpbyte, :dword, :lpdword], :win32_bool
+                            [:handle, SC_STATUS_TYPE, :lpbyte, :dword, :lpdword], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/Winsvc/nf-winsvc-queryserviceconfigw
     # BOOL QueryServiceConfigW(
@@ -302,7 +302,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :QueryServiceConfigW,
-      [:handle, :lpbyte, :dword, :lpdword], :win32_bool
+                            [:handle, :lpbyte, :dword, :lpdword], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/win32/api/winsvc/nf-winsvc-queryserviceconfig2w
     # BOOL QueryServiceConfig2W(
@@ -314,7 +314,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :QueryServiceConfig2W,
-      [:handle, :dword, :lpbyte, :dword, :lpdword], :win32_bool
+                            [:handle, :dword, :lpbyte, :dword, :lpdword], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/Winsvc/nf-winsvc-startservicew
     # BOOL StartServiceW(
@@ -324,7 +324,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :StartServiceW,
-      [:handle, :dword, :pointer], :win32_bool
+                            [:handle, :dword, :pointer], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/win32/api/winsvc/nf-winsvc-startservicectrldispatcherw
     # BOOL StartServiceCtrlDispatcherW(
@@ -332,7 +332,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :StartServiceCtrlDispatcherW,
-      [:pointer], :win32_bool, :blocking => true
+                            [:pointer], :win32_bool, :blocking => true
 
     # https://docs.microsoft.com/en-us/windows/win32/api/winsvc/nf-winsvc-setservicestatus
     # BOOL SetServiceStatus(
@@ -341,7 +341,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :SetServiceStatus,
-      [:handle, :pointer], :win32_bool
+                            [:handle, :pointer], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/winsvc/nf-winsvc-controlservice
     # BOOL ControlService(
@@ -351,7 +351,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :ControlService,
-      [:handle, :dword, :pointer], :win32_bool
+                            [:handle, :dword, :pointer], :win32_bool
 
     #   DWORD LphandlerFunctionEx(
     #   DWORD dwControl,
@@ -369,7 +369,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :RegisterServiceCtrlHandlerExW,
-      [:lpcwstr, :handler_ex, :lpvoid], :handle
+                            [:lpcwstr, :handler_ex, :lpvoid], :handle
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/winsvc/nf-winsvc-changeserviceconfigw
     # BOOL ChangeServiceConfigW(
@@ -387,19 +387,19 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :ChangeServiceConfigW,
-      [
-        :handle,
-        :dword,
-        :dword,
-        :dword,
-        :lpcwstr,
-        :lpcwstr,
-        :lpdword,
-        :lpcwstr,
-        :lpcwstr,
-        :lpcwstr,
-        :lpcwstr
-      ], :win32_bool
+                            [
+                              :handle,
+                              :dword,
+                              :dword,
+                              :dword,
+                              :lpcwstr,
+                              :lpcwstr,
+                              :lpdword,
+                              :lpcwstr,
+                              :lpcwstr,
+                              :lpcwstr,
+                              :lpcwstr
+                            ], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/win32/api/winsvc/nf-winsvc-changeserviceconfig2w
     # BOOL ChangeServiceConfig2W(
@@ -409,7 +409,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :ChangeServiceConfig2W,
-      [:handle, :dword, :lpvoid], :win32_bool
+                            [:handle, :dword, :lpvoid], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/desktop/api/winsvc/nf-winsvc-enumservicesstatusexw
     # BOOL EnumServicesStatusExW(
@@ -429,18 +429,18 @@ module Puppet::FFI::Windows
     )
     ffi_lib :advapi32
     attach_function_private :EnumServicesStatusExW,
-      [
-        :handle,
-        SC_ENUM_TYPE,
-        :dword,
-        :dword,
-        :lpbyte,
-        :dword,
-        :lpdword,
-        :lpdword,
-        :lpdword,
-        :lpcwstr
-      ], :win32_bool
+                            [
+                              :handle,
+                              SC_ENUM_TYPE,
+                              :dword,
+                              :dword,
+                              :lpbyte,
+                              :dword,
+                              :lpdword,
+                              :lpdword,
+                              :lpdword,
+                              :lpcwstr
+                            ], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa365512(v=vs.85).aspx
     # BOOL WINAPI ReplaceFile(
@@ -455,7 +455,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :ReplaceFileW,
-      [:lpcwstr, :lpcwstr, :lpcwstr, :dword, :lpvoid, :lpvoid], :win32_bool
+                            [:lpcwstr, :lpcwstr, :lpcwstr, :dword, :lpvoid, :lpvoid], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa365240(v=vs.85).aspx
     # BOOL WINAPI MoveFileEx(
@@ -465,7 +465,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :MoveFileExW,
-      [:lpcwstr, :lpcwstr, :dword], :win32_bool
+                            [:lpcwstr, :lpcwstr, :dword], :win32_bool
 
     # BOOLEAN WINAPI CreateSymbolicLink(
     #   _In_  LPTSTR lpSymlinkFileName, - symbolic link to be created
@@ -476,7 +476,7 @@ module Puppet::FFI::Windows
     begin
       ffi_lib :kernel32
       attach_function_private :CreateSymbolicLinkW,
-        [:lpwstr, :lpwstr, :dword], :boolean
+                              [:lpwstr, :lpwstr, :dword], :boolean
     rescue LoadError
     end
 
@@ -487,7 +487,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetCurrentDirectoryW,
-      [:dword, :lpwstr], :dword
+                            [:dword, :lpwstr], :dword
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa364944(v=vs.85).aspx
     # DWORD WINAPI GetFileAttributes(
@@ -495,7 +495,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetFileAttributesW,
-      [:lpcwstr], :dword
+                            [:lpcwstr], :dword
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa365535(v=vs.85).aspx
     # BOOL WINAPI SetFileAttributes(
@@ -504,7 +504,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :SetFileAttributesW,
-      [:lpcwstr, :dword], :win32_bool
+                            [:lpcwstr, :dword], :win32_bool
 
     # HANDLE WINAPI CreateFile(
     #   _In_      LPCTSTR lpFileName,
@@ -517,7 +517,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :CreateFileW,
-      [:lpcwstr, :dword, :dword, :pointer, :dword, :dword, :handle], :handle
+                            [:lpcwstr, :dword, :dword, :pointer, :dword, :dword, :handle], :handle
 
     # https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createdirectoryw
     # BOOL CreateDirectoryW(
@@ -526,7 +526,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :CreateDirectoryW,
-      [:lpcwstr, :pointer], :win32_bool
+                            [:lpcwstr, :pointer], :win32_bool
 
     # https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-removedirectoryw
     # BOOL RemoveDirectoryW(
@@ -534,7 +534,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :RemoveDirectoryW,
-      [:lpcwstr], :win32_bool
+                            [:lpcwstr], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa363216(v=vs.85).aspx
     # BOOL WINAPI DeviceIoControl(
@@ -549,7 +549,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :DeviceIoControl,
-      [:handle, :dword, :lpvoid, :dword, :lpvoid, :dword, :lpdword, :pointer], :win32_bool
+                            [:handle, :dword, :lpvoid, :dword, :lpvoid, :dword, :lpdword, :pointer], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa364980(v=vs.85).aspx
     # DWORD WINAPI GetLongPathName(
@@ -559,7 +559,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetLongPathNameW,
-      [:lpcwstr, :lpwstr, :dword], :dword
+                            [:lpcwstr, :lpwstr, :dword], :dword
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa364989(v=vs.85).aspx
     # DWORD WINAPI GetShortPathName(
@@ -569,7 +569,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetShortPathNameW,
-      [:lpcwstr, :lpwstr, :dword], :dword
+                            [:lpcwstr, :lpwstr, :dword], :dword
 
     # https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfullpathnamew
     # DWORD GetFullPathNameW(
@@ -580,7 +580,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :kernel32
     attach_function_private :GetFullPathNameW,
-      [:lpcwstr, :dword, :lpwstr, :pointer], :dword
+                            [:lpcwstr, :dword, :lpwstr, :pointer], :dword
 
     # https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpathw
     # SHFOLDERAPI SHGetFolderPathW(
@@ -592,7 +592,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :shell32
     attach_function_private :SHGetFolderPathW,
-      [:hwnd, :int, :handle, :dword, :lpwstr], :dword
+                            [:hwnd, :int, :handle, :dword, :lpwstr], :dword
 
     # https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderlocation
     # SHSTDAPI SHGetFolderLocation(
@@ -604,7 +604,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :shell32
     attach_function_private :SHGetFolderLocation,
-      [:hwnd, :int, :handle, :dword, :pointer], :dword
+                            [:hwnd, :int, :handle, :dword, :pointer], :dword
 
     # https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa
     # DWORD_PTR SHGetFileInfoA(
@@ -616,7 +616,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :shell32
     attach_function_private :SHGetFileInfo,
-      [:dword, :dword, :pointer, :uint, :uint], :dword
+                            [:dword, :dword, :pointer, :uint, :uint], :dword
 
     # https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-pathisdirectoryemptyw
     # BOOL PathIsDirectoryEmptyW(
@@ -624,6 +624,6 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :shlwapi
     attach_function_private :PathIsDirectoryEmptyW,
-      [:lpcwstr], :win32_bool
+                            [:lpcwstr], :win32_bool
   end
 end

data/lib/puppet/ffi/windows/structs.rb

@@ -1,10 +1,10 @@
 # coding: utf-8
 # frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::FFI::Windows
   module Structs
-
     extend FFI::Library
     extend Puppet::FFI::Windows::APITypes
 
@@ -116,7 +116,7 @@ module Puppet::FFI::Windows
     # } TOKEN_PRIVILEGES, *PTOKEN_PRIVILEGES;
     class TOKEN_PRIVILEGES < FFI::Struct
       layout :PrivilegeCount, :dword,
-             :Privileges, [LUID_AND_ATTRIBUTES, 1]    # placeholder for offset
+             :Privileges, [LUID_AND_ATTRIBUTES, 1] # placeholder for offset
     end
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/bb530717(v=vs.85).aspx
@@ -258,7 +258,7 @@ module Puppet::FFI::Windows
       )
     end
 
-	MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
+    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
 
     # SYMLINK_REPARSE_DATA_BUFFER
     # https://msdn.microsoft.com/en-us/library/cc232006.aspx

data/lib/puppet/ffi/windows.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'ffi'
 
 module Puppet

data/lib/puppet/file_bucket/dipper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'pathname'
 require_relative '../../puppet/file_bucket'
 require_relative '../../puppet/file_bucket/file'
@@ -31,13 +32,14 @@ class Puppet::FileBucket::Dipper
   end
 
   def local?
-    !! @local_path
+    !!@local_path
   end
 
   # Backs up a file to the file bucket
   def backup(file)
     file_handle = Puppet::FileSystem.pathname(file)
     raise(ArgumentError, _("File %{file} does not exist") % { file: file }) unless Puppet::FileSystem.exist?(file_handle)
+
     begin
       file_bucket_file = Puppet::FileBucket::File.new(file_handle, :bucket_path => @local_path)
       files_original_path = absolutize_path(file)
@@ -61,13 +63,15 @@ class Puppet::FileBucket::Dipper
   # Diffs two filebucket files identified by their sums
   def diff(checksum_a, checksum_b, file_a, file_b)
     raise RuntimeError, _("Diff is not supported on this platform") if Puppet[:diff] == ""
+
     if checksum_a
       source_path = "#{@rest_path}#{@checksum_type}/#{checksum_a}"
       if checksum_b
         file_diff = Puppet::FileBucket::File.indirection.find(
           source_path,
           :bucket_path => @local_path,
-          :diff_with => checksum_b)
+          :diff_with => checksum_b
+        )
       elsif file_b
         tmp_file = ::Tempfile.new('diff')
         begin
@@ -95,6 +99,7 @@ class Puppet::FileBucket::Dipper
       end
     end
     raise Puppet::Error, _("Failed to diff files") unless file_diff
+
     file_diff.to_s
   end
 
@@ -109,6 +114,7 @@ class Puppet::FileBucket::Dipper
     file_bucket_file = Puppet::FileBucket::File.indirection.find(source_path, :bucket_path => @local_path)
 
     raise Puppet::Error, _("File not found") unless file_bucket_file
+
     file_bucket_file
   end
 
@@ -131,11 +137,11 @@ class Puppet::FileBucket::Dipper
       if newcontents
         newsum = newcontents.checksum_data
         changed = nil
-        if Puppet::FileSystem.exist?(file_handle) and ! Puppet::FileSystem.writable?(file_handle)
+        if Puppet::FileSystem.exist?(file_handle) and !Puppet::FileSystem.writable?(file_handle)
           changed = Puppet::FileSystem.stat(file_handle).mode
           ::File.chmod(changed | 0200, file)
         end
-        ::File.open(file, ::File::WRONLY|::File::TRUNC|::File::CREAT) { |of|
+        ::File.open(file, ::File::WRONLY | ::File::TRUNC | ::File::CREAT) { |of|
           of.binmode
           newcontents.stream do |source_stream|
             FileUtils.copy_stream(source_stream, of)
@@ -162,14 +168,16 @@ class Puppet::FileBucket::Dipper
       :bucket_path => @local_path,
       :list_all => true,
       :fromdate => fromdate,
-      :todate => todate)
+      :todate => todate
+    )
     raise Puppet::Error, _("File not found") unless file_bucket_list
+
     file_bucket_list.to_s
   end
 
   private
-  def absolutize_path( path )
+
+  def absolutize_path(path)
     Pathname.new(path).realpath
   end
-
 end

data/lib/puppet/file_bucket/file.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../../puppet/file_bucket'
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/util/checksums'
@@ -12,7 +13,7 @@ class Puppet::FileBucket::File
   extend Puppet::Indirector
   indirects :file_bucket_file, :terminus_class => :selector
 
-  attr :bucket_path
+  attr_reader :bucket_path
 
   def self.supported_formats
     [:binary]
@@ -124,7 +125,7 @@ class Puppet::FileBucket::File
     end
 
     def to_binary
-      Puppet::FileSystem::binread(@path)
+      Puppet::FileSystem.binread(@path)
     end
   end
 end

data/lib/puppet/file_bucket.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # stub
 module Puppet::FileBucket
   class BucketError < RuntimeError; end