puppet 7.28.0-x64-mingw32 → 8.0.1-x64-mingw32

data/lib/puppet/pops/evaluator/evaluator_impl.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/parser/scope'
 require_relative '../../../puppet/pops/evaluator/compare_operator'
 require_relative '../../../puppet/pops/evaluator/relationship_operator'
@@ -33,7 +34,7 @@ class EvaluatorImpl
   include Runtime3Support
   include ExternalSyntaxSupport
 
-  COMMA_SEPARATOR = ', '.freeze
+  COMMA_SEPARATOR = ', '
 
   # Reference to Issues name space makes it easier to refer to issues
   # (Issues are shared with the validator).

data/lib/puppet/pops/evaluator/external_syntax_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This module is an integral part of the evaluator. It deals with the concern of validating
 # external syntax in text produced by heredoc and templates.
 #

data/lib/puppet/pops/evaluator/json_strict_literal_evaluator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Literal values for
 #
 #   * String
@@ -19,7 +20,7 @@
 class Puppet::Pops::Evaluator::JsonStrictLiteralEvaluator
   #include Puppet::Pops::Utils
 
-  COMMA_SEPARATOR = ', '.freeze
+  COMMA_SEPARATOR = ', '
 
   def initialize
     @@literal_visitor ||= Puppet::Pops::Visitor.new(self, "literal", 0, 0)

data/lib/puppet/pops/evaluator/literal_evaluator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Evaluator
 # Literal values for
@@ -16,7 +17,7 @@ module Evaluator
 #
 class LiteralEvaluator
 
-  COMMA_SEPARATOR = ', '.freeze
+  COMMA_SEPARATOR = ', '
 
   def initialize
     @@literal_visitor ||= Visitor.new(self, "literal", 0, 0)

data/lib/puppet/pops/evaluator/puppet_proc.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Complies with Proc API by mapping a Puppet::Pops::Evaluator::Closure to a ruby Proc.
 # Creating and passing an instance of this class instead of just a plain block makes
 # it possible to inherit the parameter info and arity from the closure. Advanced users

data/lib/puppet/pops/evaluator/relationship_operator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Evaluator
 # The RelationshipOperator implements the semantics of the -> <- ~> <~ operators creating relationships or notification

data/lib/puppet/pops/evaluator/runtime3_converter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Evaluator
 # Converts nested 4x supported values to 3x values. This is required because
 # resources and other objects do not know about the new type system, and does not support

data/lib/puppet/pops/evaluator/runtime3_resource_support.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Evaluator
 
 # @api private
 module Runtime3ResourceSupport
-  CLASS_STRING = 'class'.freeze
+  CLASS_STRING = 'class'
 
   def self.create_resources(file, line, scope, virtual, exported, type_name, resource_titles, evaluated_parameters)
 

data/lib/puppet/pops/evaluator/runtime3_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Evaluator
 # A module with bindings between the new evaluator and the 3x runtime.
@@ -7,7 +8,7 @@ module Evaluator
 # @api private
 module Runtime3Support
 
-  NAME_SPACE_SEPARATOR = '::'.freeze
+  NAME_SPACE_SEPARATOR = '::'
 
   # Fails the evaluation of _semantic_ with a given issue.
   #

data/lib/puppet/pops/functions/dispatch.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Functions
 # Defines a connection between a implementation method and the signature that

data/lib/puppet/pops/functions/dispatcher.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Evaluate the dispatches defined as {Puppet::Pops::Functions::Dispatch}
 # instances to call the appropriate method on the
 # {Puppet::Pops::Functions::Function} instance.

data/lib/puppet/pops/functions/function.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # @note WARNING: This new function API is still under development and may change at
 #   any time
 #

data/lib/puppet/pops/issue_reporter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 class IssueReporter
 

data/lib/puppet/pops/issues.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Defines classes to deal with issues, and message formatting and defines constants with Issues.
 # @api public
 #

data/lib/puppet/pops/label_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Provides a label for an object.
 # This simple implementation calls #to_s on the given object, and handles articles 'a/an/the'.
 #

data/lib/puppet/pops/loader/base_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # BaseLoader

data/lib/puppet/pops/loader/dependency_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # =DependencyLoader
 # This loader provides visibility into a set of other loaders. It is used as a child of a ModuleLoader (or other
 # loader) to make its direct dependencies visible for loading from contexts that have access to this dependency loader.

data/lib/puppet/pops/loader/gem_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # GemSupport offers methods to find a gem's location by name or gem://gemname URI.
 #
 # TODO: The Puppet 3x, uses Puppet::Util::RubyGems to do this, and obtain paths, and avoids using ::Gems

data/lib/puppet/pops/loader/generic_plan_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The GenericPlanInstantiator dispatches to either PuppetPlanInstantiator or a

data/lib/puppet/pops/loader/loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Loader
 # ===
 # A Loader is responsible for loading "entities" ("instantiable and executable objects in the puppet language" which
@@ -22,8 +23,8 @@
 module Puppet::Pops
 module Loader
 
-ENVIRONMENT = 'environment'.freeze
-ENVIRONMENT_PRIVATE = 'environment private'.freeze
+ENVIRONMENT = 'environment'
+ENVIRONMENT_PRIVATE = 'environment private'
 
 class Loader
   attr_reader :environment, :loader_name

data/lib/puppet/pops/loader/loader_paths.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 # LoaderPaths
 # ===
@@ -87,7 +88,7 @@ module LoaderPaths
 
     def typed_name(type, name_authority, relative_path, module_name)
       # Module name is assumed to be included in the path and therefore not added here
-      n = ''
+      n = String.new
       unless extension.empty?
         # Remove extension
         relative_path = relative_path[0..-(extension.length+1)]
@@ -117,7 +118,7 @@ module LoaderPaths
   end
 
   class RubySmartPath < SmartPath
-    EXTENSION = '.rb'.freeze
+    EXTENSION = '.rb'
 
     def extension
       EXTENSION
@@ -133,7 +134,7 @@ module LoaderPaths
   # path (which is a reference to its 'lib' directory.
   #
   class PuppetSmartPath < SmartPath
-    EXTENSION = '.pp'.freeze
+    EXTENSION = '.pp'
 
     def extension
       EXTENSION
@@ -152,7 +153,7 @@ module LoaderPaths
     end
 
     def typed_name(type, name_authority, relative_path, module_name)
-      n = ''
+      n = String.new
       n << module_name unless module_name.nil?
       unless extension.empty?
         # Remove extension
@@ -193,7 +194,7 @@ module LoaderPaths
   end
 
   class FunctionPathPP < PuppetSmartPath
-    FUNCTION_PATH_PP = 'functions'.freeze
+    FUNCTION_PATH_PP = 'functions'
 
     def relative_path
       FUNCTION_PATH_PP
@@ -218,7 +219,7 @@ module LoaderPaths
   end
 
   class TypePathPP < PuppetSmartPath
-    TYPE_PATH_PP = 'types'.freeze
+    TYPE_PATH_PP = 'types'
 
     def relative_path
       TYPE_PATH_PP
@@ -232,7 +233,7 @@ module LoaderPaths
   # TaskPath is like PuppetSmartPath but it does not use an extension and may
   # match more than one path with one name
   class TaskPath < PuppetSmartPath
-    TASKS_PATH = 'tasks'.freeze
+    TASKS_PATH = 'tasks'
     FORBIDDEN_EXTENSIONS = %w{.conf .md}.freeze
 
     def extension
@@ -248,7 +249,7 @@ module LoaderPaths
     end
 
     def typed_name(type, name_authority, relative_path, module_name)
-      n = ''
+      n = String.new
       n << module_name unless module_name.nil?
 
       # Remove the file extension, defined as everything after the *last* dot.
@@ -285,7 +286,7 @@ module LoaderPaths
   end
 
   class ResourceTypeImplPP < PuppetSmartPath
-    RESOURCE_TYPES_PATH_PP = '.resource_types'.freeze
+    RESOURCE_TYPES_PATH_PP = '.resource_types'
 
     def relative_path
       RESOURCE_TYPES_PATH_PP
@@ -312,8 +313,8 @@ module LoaderPaths
 
   class PlanPath < PuppetSmartPath
     PLAN_PATH = File.join('plans')
-    PP_EXT = '.pp'.freeze
-    YAML_EXT = '.yaml'.freeze
+    PP_EXT = '.pp'
+    YAML_EXT = '.yaml'
 
     def initialize(loader)
       super
@@ -350,7 +351,7 @@ module LoaderPaths
       if @init_filenames.include?(relative_path) && !(module_name.nil? || module_name.empty?)
         TypedName.new(type, module_name, name_authority)
       else
-        n = ''
+        n = String.new
         n << module_name unless module_name.nil?
         ext = @extensions.find { |extension| relative_path.end_with?(extension) }
         relative_path = relative_path[0..-(ext.length+1)]

data/lib/puppet/pops/loader/module_loaders.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # =ModuleLoaders
@@ -21,7 +22,7 @@ module Loader
 module ModuleLoaders
 
   # Wildcard module name for module loaders, makes loading possible from any namespace.
-  NAMESPACE_WILDCARD = '*'.freeze
+  NAMESPACE_WILDCARD = '*'
 
   # This is exactly the same as the #system_loader_from method, but the argument for path is changed to
   # location where pluginsync stores functions. It also accepts definitions in any namespace since pluginsync

data/lib/puppet/pops/loader/predefined_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Loader
 
 # A PredefinedLoader is a loader that is manually populated with loaded elements

data/lib/puppet/pops/loader/puppet_function_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The PuppetFunctionInstantiator instantiates a Puppet::Functions::PuppetFunction given a Puppet Programming language

data/lib/puppet/pops/loader/puppet_plan_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The PuppetPlanInstantiator instantiates a Puppet::Functions::PuppetFunction given a Puppet Programming language

data/lib/puppet/pops/loader/puppet_resource_type_impl_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The PuppetResourceTypeImplInstantiator instantiates a Puppet::Pops::ResourceTypeImpl object.

data/lib/puppet/pops/loader/ruby_data_type_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The RubyTypeInstantiator instantiates a data type from the ruby source
 # that calls Puppet::DataTypes.create_type.
 #
@@ -19,7 +20,7 @@ class Puppet::Pops::Loader::RubyDataTypeInstantiator
     # make the private loader available in a binding to allow it to be passed on
     loader_for_type = loader.private_loader
     here = get_binding(loader_for_type)
-    created = eval(ruby_code_string, here, source_ref, 1) # rubocop:disable Security/Eval
+    created = eval(ruby_code_string, here, source_ref, 1)
     unless created.is_a?(Puppet::Pops::Types::PAnyType)
       raise ArgumentError, _("The code loaded from %{source_ref} did not produce a data type when evaluated. Got '%{klass}'") % { source_ref: source_ref, klass: created.class }
     end

data/lib/puppet/pops/loader/ruby_function_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The RubyFunctionInstantiator instantiates a Puppet::Functions::Function given the ruby source
 # that calls Puppet::Functions.create_function.
 #
@@ -19,7 +20,7 @@ class Puppet::Pops::Loader::RubyFunctionInstantiator
     # make the private loader available in a binding to allow it to be passed on
     loader_for_function = loader.private_loader
     here = get_binding(loader_for_function)
-    created = eval(ruby_code_string, here, source_ref, 1) # rubocop:disable Security/Eval
+    created = eval(ruby_code_string, here, source_ref, 1)
     unless created.is_a?(Class)
       raise ArgumentError, _("The code loaded from %{source_ref} did not produce a Function class when evaluated. Got '%{klass}'") % { source_ref: source_ref, klass: created.class }
     end

data/lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 # The RubyLegacyFunctionInstantiator instantiates a Puppet::Functions::Function given the ruby source
 # that calls Puppet::Functions.create_function.
 #
 require 'ripper'
 class Puppet::Pops::Loader::RubyLegacyFunctionInstantiator
-  UNKNOWN = '<unknown>'.freeze
+  UNKNOWN = '<unknown>'
 
   # Produces an instance of the Function class with the given typed_name, or fails with an error if the
   # given ruby source does not produce this instance when evaluated.
@@ -37,7 +38,7 @@ class Puppet::Pops::Loader::RubyLegacyFunctionInstantiator
       # This will do the 3x loading and define the "function_<name>" and "real_function_<name>" methods
       # in the anonymous module used to hold function definitions.
       #
-      func_info = eval(ruby_code_string, here, source_ref, 1) # rubocop:disable Security/Eval
+      func_info = eval(ruby_code_string, here, source_ref, 1)
 
       # Validate what was loaded
       unless func_info.is_a?(Hash)

data/lib/puppet/pops/loader/runtime3_type_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 

data/lib/puppet/pops/loader/simple_environment_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # SimpleEnvironmentLoader
 # ===
 # This loader does not load anything and it is populated by the bootstrapping logic that loads

data/lib/puppet/pops/loader/static_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
   # Static Loader contains constants, basic data types and other types required for the system
   # to boot.
   #

data/lib/puppet/pops/loader/task_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The TypeDefinitionInstantiator instantiates a type alias or a type definition
 #
 require_relative '../../../puppet/module/task'

data/lib/puppet/pops/loader/type_definition_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The TypeDefinitionInstantiator instantiates a type alias or a type definition
 #
 module Puppet::Pops

data/lib/puppet/pops/loader/typed_name.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # A namespace/name/type combination that can be used as a compound hash key
@@ -26,7 +27,7 @@ class TypedName
     @name_parts = parts.freeze
 
     # Use a frozen compound key for the hash and comparison. Most varying part first
-    @compound_name = "#{@name}/#{@type}/#{@name_authority}".freeze
+    @compound_name = "#{@name}/#{@type}/#{@name_authority}"
     @hash = @compound_name.hash
     freeze
   end

data/lib/puppet/pops/loader/uri_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Loader::UriHelper
   # Raises an exception if specified gem can not be located
   #

data/lib/puppet/pops/loaders.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 # This is the container for all Loader instances. Each Loader instance has a `loader_name` by which it can be uniquely
 # identified within this container.

data/lib/puppet/pops/lookup/configured_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'hiera_config'
 require_relative 'data_provider'
 

data/lib/puppet/pops/lookup/context.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'interpolation'
 
 module Puppet::Pops

data/lib/puppet/pops/lookup/data_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 # A class that adapts a Hash

data/lib/puppet/pops/lookup/data_dig_function_provider.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require_relative 'function_provider'
 
 module Puppet::Pops
 module Lookup
 # @api private
 class DataDigFunctionProvider < FunctionProvider
-  TAG = 'data_dig'.freeze
+  TAG = 'data_dig'
 
   # Performs a lookup with the assumption that a recursive check has been made.
   #
@@ -63,7 +64,7 @@ end
 
 # @api private
 class V3BackendFunctionProvider < DataDigFunctionProvider
-  TAG = 'hiera3_backend'.freeze
+  TAG = 'hiera3_backend'
 
   def data_dig(key, lookup_invocation, location, merge)
     @backend ||= instantiate_backend(lookup_invocation)

data/lib/puppet/pops/lookup/data_hash_function_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'function_provider'
 require_relative 'interpolation'
 
@@ -8,7 +9,7 @@ class DataHashFunctionProvider < FunctionProvider
   include SubLookup
   include Interpolation
 
-  TAG = 'data_hash'.freeze
+  TAG = 'data_hash'
 
   def self.trusted_return_type
     @trusted_return_type ||= Types::PHashType.new(DataProvider.key_type, DataProvider.value_type)
@@ -80,7 +81,7 @@ end
 
 # @api private
 class V3DataHashFunctionProvider < DataHashFunctionProvider
-  TAG = 'v3_data_hash'.freeze
+  TAG = 'v3_data_hash'
 
   def initialize(name, parent_data_provider, function_name, options, locations)
     @datadir = options.delete(HieraConfig::KEY_DATADIR)
@@ -108,7 +109,7 @@ end
 # TODO: API 5.0, remove this class
 # @api private
 class V4DataHashFunctionProvider < DataHashFunctionProvider
-  TAG = 'v4_data_hash'.freeze
+  TAG = 'v4_data_hash'
 
   def name
     "Deprecated API function \"#{function_name}\""

data/lib/puppet/pops/lookup/data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 # @api private

data/lib/puppet/pops/lookup/environment_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'configured_data_provider'
 
 module Puppet::Pops

data/lib/puppet/pops/lookup/explainer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 
@@ -19,7 +20,7 @@ module Lookup
     end
 
     def explain
-      io = ''
+      io = String.new
       dump_on(io, '', '')
       io
     end
@@ -585,7 +586,7 @@ module Lookup
     end
 
     def emit_debug_info(preamble)
-      io = ''
+      io = String.new
       io << preamble << "\n"
       dump_on(io, '  ', '  ')
       Puppet.debug(io.chomp!)

data/lib/puppet/pops/lookup/function_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'data_adapter'
 require_relative 'context'
 require_relative 'data_provider'

data/lib/puppet/pops/lookup/global_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'hiera/scope'
 require_relative 'configured_data_provider'