puppet 7.28.0-x64-mingw32 → 8.0.1-x64-mingw32

data/lib/puppet/face/config.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/settings/ini_file'
 
@@ -81,7 +82,7 @@ Puppet::Face.define(:config, '0.0.1') do
     end
 
     when_rendering :console do |to_be_rendered|
-      output = ''
+      output = String.new
       if to_be_rendered.keys.length > 1
         to_be_rendered.keys.sort.each do |setting|
           output << "#{setting} = #{to_be_rendered[setting]}\n"

data/lib/puppet/face/epp.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/pops'
 require_relative '../../puppet/parser/files'
@@ -366,7 +367,7 @@ Puppet::Face.define(:epp, '0.0.1') do
   end
 
   def dump_parse(source, filename, options, show_filename = true)
-    output = ""
+    output = String.new
     evaluating_parser = Puppet::Pops::Parser::EvaluatingParser::EvaluatingEppParser.new
     begin
       if options[:validate]
@@ -450,7 +451,7 @@ Puppet::Face.define(:epp, '0.0.1') do
 
   def render_file(epp_template_name, compiler, options, show_filename, file_nbr)
     template_args = get_values(compiler, options)
-    output = ""
+    output = String.new
     begin
       if show_filename && options[:header]
         output << "\n" unless file_nbr == 1

data/lib/puppet/face/facts.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/indirector/face'
 require_relative '../../puppet/node/facts'
 

data/lib/puppet/face/generate.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/generate/type'
 

data/lib/puppet/face/help/action.erb

@@ -54,7 +54,6 @@ undocumented option
 	end
 	unless action.options.empty?
       action.options.sort.each do |name|
-        next if name == :extra
         option = action.get_option name -%>
 <%= "  " + option.optparse.join(" | ")[0,(optionroom - 1)].ljust(optionroom) + ' - ' -%>
 <%     if !(option.summary) -%>

data/lib/puppet/face/help/face.erb

@@ -49,7 +49,6 @@ undocumented option
 	end
  	unless face.options.empty?
       face.options.sort.each do |name|
-        next if name == :extra
         option = face.get_option name -%>
 <%= "  " + option.optparse.join(" | ")[0,(optionroom - 1)].ljust(optionroom) + ' - ' -%>
 <%     if !(option.summary) -%>

data/lib/puppet/face/help.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/application/face_base'
 require_relative '../../puppet/util/constant_inflector'
@@ -190,9 +191,9 @@ Puppet::Face.define(:help, '0.0.1') do
     end
   end
 
-  COMMON = 'Common:'.freeze
-  SPECIALIZED = 'Specialized:'.freeze
-  BLANK = "\n".freeze
+  COMMON = 'Common:'
+  SPECIALIZED = 'Specialized:'
+  BLANK = "\n"
   def available_application_names_special_sort()
     full_list = Puppet::Application.available_application_names
     a_list = full_list & %w{apply agent config help lookup module resource}

data/lib/puppet/face/module/changes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Face.define(:module, '1.0.0') do
   action(:changes) do
     summary _("Show modified files of an installed module.")

data/lib/puppet/face/module/install.rb

@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 require_relative '../../../puppet/forge'
 require_relative '../../../puppet/module_tool/install_directory'
 require 'pathname'

data/lib/puppet/face/module/list.rb

@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 Puppet::Face.define(:module, '1.0.0') do
   action(:list) do
@@ -73,7 +74,7 @@ Puppet::Face.define(:module, '1.0.0') do
       environment     = result[:environment]
       modules_by_path = result[:modules_by_path]
 
-      output = ''
+      output = String.new
 
       warn_unmet_dependencies(environment)
 
@@ -247,7 +248,7 @@ Puppet::Face.define(:module, '1.0.0') do
   # Returns a Hash
   #
   def list_build_node(mod, parent, params)
-    str = ''
+    str = String.new
     str << (mod.forge_name ? mod.forge_name.tr('/', '-') : mod.name)
     str << ' (' + colorize(:cyan, mod.version ? "v#{mod.version}" : '???') + ')'
 

data/lib/puppet/face/module/uninstall.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Face.define(:module, '1.0.0') do
   action(:uninstall) do
     summary _("Uninstall a puppet module.")

data/lib/puppet/face/module/upgrade.rb

@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 Puppet::Face.define(:module, '1.0.0') do
   action(:upgrade) do

data/lib/puppet/face/module.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/module_tool'
 require_relative '../../puppet/util/colors'

data/lib/puppet/face/node/clean.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Face.define(:node, '0.0.1') do
   action(:clean) do
 

data/lib/puppet/face/node.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/indirector/face'
 Puppet::Indirector::Face.define(:node, '0.0.1') do
   copyright "Puppet Inc.", 2011

data/lib/puppet/face/parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/parser'
 
@@ -173,7 +174,7 @@ Puppet::Face.define(:parser, '0.0.1') do
   end
 
   def dump_parse(source, filename, options, show_filename = true)
-    output = ""
+    output = String.new
     evaluating_parser = Puppet::Pops::Parser::EvaluatingParser.new
     begin
       if options[:validate]

data/lib/puppet/face/plugin.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/face'
 require_relative '../../puppet/configurer/plugin_handler'
 

data/lib/puppet/face/report.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/indirector/face'
 
 Puppet::Indirector::Face.define(:report, '0.0.1') do

data/lib/puppet/face/resource.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/indirector/face'
 
 Puppet::Indirector::Face.define(:resource, '0.0.1') do

data/lib/puppet/face.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The public name of this feature is 'face', but we have hidden all the
 # plumbing over in the 'interfaces' namespace to make clear the distinction
 # between the two.

data/lib/puppet/feature/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 # Add the simple features, all in one file.

data/lib/puppet/feature/bolt.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:bolt, :libs => ['bolt'])

data/lib/puppet/feature/cfpropertylist.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:cfpropertylist, :libs => ['cfpropertylist'])

data/lib/puppet/feature/eventlog.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 if Puppet::Util::Platform.windows?

data/lib/puppet/feature/hiera_eyaml.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:hiera_eyaml, :libs => ['hiera/backend/eyaml/parser/parser'])

data/lib/puppet/feature/hocon.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:hocon, :libs => ['hocon'])

data/lib/puppet/feature/libuser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 require_relative '../../puppet/util/libuser'
 

data/lib/puppet/feature/msgpack.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:msgpack, :libs => ["msgpack"])

data/lib/puppet/feature/pe_license.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 #Is the pe license library installed providing the ability to read licenses.

data/lib/puppet/feature/pson.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+require_relative '../../puppet/util/feature'
+
+# PSON is deprecated, use JSON instead
+Puppet.features.add(:pson, :libs => ['puppet/external/pson'])

data/lib/puppet/feature/selinux.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:selinux, :libs => ["selinux"])

data/lib/puppet/feature/ssh.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:ssh, :libs => %{net/ssh})

data/lib/puppet/feature/telnet.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add :telnet do

data/lib/puppet/feature/zlib.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/feature'
 
 # We want this to load if possible, but it's not automatically

data/lib/puppet/ffi/posix/constants.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/posix'
 
 module Puppet::FFI::POSIX

data/lib/puppet/ffi/posix/functions.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/posix'
 
 module Puppet::FFI::POSIX

data/lib/puppet/ffi/posix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ffi'
 
 module Puppet

data/lib/puppet/ffi/windows/api_types.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 require_relative '../../../puppet/util/windows/string'
 
@@ -20,7 +21,7 @@ module Puppet::FFI::Windows
 
     class ::FFI::Pointer
       NULL_HANDLE = 0
-      WCHAR_NULL = "\0\0".force_encoding('UTF-16LE').freeze
+      WCHAR_NULL = String.new("\0\0").force_encoding('UTF-16LE').freeze
 
       def self.from_string_to_wide_string(str, &block)
         str = Puppet::Util::Windows::String.wide_string(str)

data/lib/puppet/ffi/windows/constants.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::FFI::Windows

data/lib/puppet/ffi/windows/functions.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::FFI::Windows

data/lib/puppet/ffi/windows/structs.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::FFI::Windows

data/lib/puppet/ffi/windows.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ffi'
 
 module Puppet

data/lib/puppet/file_bucket/dipper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'pathname'
 require_relative '../../puppet/file_bucket'
 require_relative '../../puppet/file_bucket/file'

data/lib/puppet/file_bucket/file.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_bucket'
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/util/checksums'

data/lib/puppet/file_bucket.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # stub
 module Puppet::FileBucket
   class BucketError < RuntimeError; end

data/lib/puppet/file_serving/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/util'
 

data/lib/puppet/file_serving/configuration/parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/configuration'
 require_relative '../../../puppet/util/watched_file'
 

data/lib/puppet/file_serving/configuration.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/mount'

data/lib/puppet/file_serving/content.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/base'

data/lib/puppet/file_serving/fileset.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'find'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/metadata'

data/lib/puppet/file_serving/http_metadata.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_serving/metadata'
 
 # Simplified metadata representation, suitable for the information

data/lib/puppet/file_serving/metadata.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/file_serving'

data/lib/puppet/file_serving/mount/file.rb

@@ -1,14 +1,15 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/mount'
 
 class Puppet::FileServing::Mount::File < Puppet::FileServing::Mount
   def self.localmap
     @localmap ||= {
-      "h" => Puppet.runtime[:facter].value("hostname"),
+      "h" => Puppet.runtime[:facter].value('networking.hostname'),
       "H" => [
-               Puppet.runtime[:facter].value("hostname"),
-               Puppet.runtime[:facter].value("domain")
+               Puppet.runtime[:facter].value('networking.hostname'),
+               Puppet.runtime[:facter].value('networking.domain')
              ].join("."),
-      "d" => Puppet.runtime[:facter].value("domain")
+      "d" => Puppet.runtime[:facter].value('networking.domain')
     }
   end
 

data/lib/puppet/file_serving/mount/locales.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/mount'
 
 # Find files in the modules' locales directories.

data/lib/puppet/file_serving/mount/modules.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/mount'
 
 # This is the modules-specific mount: it knows how to search through

data/lib/puppet/file_serving/mount/pluginfacts.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/mount'
 
 # Find files in the modules' pluginfacts directories.

data/lib/puppet/file_serving/mount/plugins.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/mount'
 
 # Find files in the modules' plugins directories.

data/lib/puppet/file_serving/mount/scripts.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'puppet/file_serving/mount'
 
 class Puppet::FileServing::Mount::Scripts < Puppet::FileServing::Mount

data/lib/puppet/file_serving/mount/tasks.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/mount'
 
 class Puppet::FileServing::Mount::Tasks < Puppet::FileServing::Mount

data/lib/puppet/file_serving/mount.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/logging'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/metadata'

data/lib/puppet/file_serving/terminus_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/fileset'
 

data/lib/puppet/file_serving/terminus_selector.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_serving'
 
 # This module is used to pick the appropriate terminus

data/lib/puppet/file_serving.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Just a stub class.
 class Puppet::FileServing # :nodoc:
 end

data/lib/puppet/file_system/file_impl.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Abstract implementation of the Puppet::FileSystem
 #
 class Puppet::FileSystem::FileImpl
@@ -150,7 +151,7 @@ class Puppet::FileSystem::FileImpl
   end
 
   def compare_stream(path, stream)
-    ::File.open(path, 0, 'rb') { |this| FileUtils.compare_stream(this, stream) }
+    open(path, 0, 'rb') { |this| FileUtils.compare_stream(this, stream) }
   end
 
   def chmod(mode, path)

data/lib/puppet/file_system/jruby.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_system/posix'
 
 class Puppet::FileSystem::JRuby < Puppet::FileSystem::Posix

data/lib/puppet/file_system/memory_file.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # An in-memory file abstraction. Commonly used with Puppet::FileSystem::File#overlay
 # @api private
 class Puppet::FileSystem::MemoryFile

data/lib/puppet/file_system/memory_impl.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::FileSystem::MemoryImpl
   def initialize(*files)
     @files = files + all_children_of(files)

data/lib/puppet/file_system/path_pattern.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'pathname'
 require_relative '../../puppet/error'
 
@@ -5,7 +6,7 @@ module Puppet::FileSystem
   class PathPattern
     class InvalidPattern < Puppet::Error; end
 
-    DOTDOT = '..'.freeze
+    DOTDOT = '..'
     ABSOLUTE_UNIX = /^\//
     ABSOLUTE_WINDOWS = /^[a-z]:/i
     CURRENT_DRIVE_RELATIVE_WINDOWS = /^\\/

data/lib/puppet/file_system/posix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::FileSystem::Posix < Puppet::FileSystem::FileImpl
   def binread(path)
     path.binread
@@ -10,10 +11,10 @@ class Puppet::FileSystem::Posix < Puppet::FileSystem::FileImpl
   # issue this method reimplements the faster 2.0 version that will correctly
   # compare binary File and StringIO streams.
   def compare_stream(path, stream)
-    ::File.open(path, 'rb') do |this|
+    open(path, 0, 'rb') do |this|
       bsize = stream_blksize(this, stream)
-      sa = "".force_encoding('ASCII-8BIT')
-      sb = "".force_encoding('ASCII-8BIT')
+      sa = String.new.force_encoding('ASCII-8BIT')
+      sb = String.new.force_encoding('ASCII-8BIT')
       loop do
         this.read(bsize, sa)
         stream.read(bsize, sb)

data/lib/puppet/file_system/uniquefile.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_system'
 require 'delegate'
 require 'tmpdir'
@@ -150,7 +151,7 @@ class Puppet::FileSystem::Uniquefile < DelegateClass(File)
 
   def tmpdir
     tmp = '.'
-    for dir in [ Puppet::Util.get_env('TMPDIR'), Puppet::Util.get_env('TMP'), Puppet::Util.get_env('TEMP'), @@systmpdir, '/tmp']
+    for dir in [ ENV['TMPDIR'], ENV['TMP'], ENV['TEMP'], @@systmpdir, '/tmp']
       stat = File.stat(dir) if dir
       if stat && stat.directory? && stat.writable?
         tmp = dir

data/lib/puppet/file_system/windows.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/file_system/posix'
 require_relative '../../puppet/util/windows'
 

data/lib/puppet/file_system.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::FileSystem
   require_relative '../puppet/util'
   require_relative 'file_system/path_pattern'

data/lib/puppet/forge/cache.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'uri'
 
 require_relative '../../puppet/forge'

data/lib/puppet/forge/errors.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/json'
 require_relative '../../puppet/error'
 require_relative '../../puppet/forge'

data/lib/puppet/forge/repository.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl/openssl_loader'
 require 'digest/sha1'
 require 'uri'

data/lib/puppet/forge.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../puppet/vendor'
 Puppet::Vendor.load_vendored
 
@@ -15,7 +16,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
 
   include Puppet::Forge::Errors
 
-  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)".freeze
+  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)"
 
   # From https://forgeapi.puppet.com/#!/release/getReleases
   MODULE_RELEASE_EXCLUSIONS=%w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze

data/lib/puppet/functions/abs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Returns the absolute value of a Numeric value, for example -34.56 becomes
 # 34.56. Takes a single `Integer` or `Float` value as an argument.
 #