puppet 7.27.0-x64-mingw32 → 8.0.1-x64-mingw32

data/lib/puppet/pops/types/p_uri_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 class PURIType < PAnyType
@@ -5,14 +6,14 @@ class PURIType < PAnyType
   # Tell evaluator that an members of instances of this type can be invoked using dot notation
   include TypeWithMembers
 
-  SCHEME = 'scheme'.freeze
-  USERINFO = 'userinfo'.freeze
-  HOST = 'host'.freeze
-  PORT = 'port'.freeze
-  PATH = 'path'.freeze
-  QUERY = 'query'.freeze
-  FRAGMENT = 'fragment'.freeze
-  OPAQUE = 'opaque'.freeze
+  SCHEME = 'scheme'
+  USERINFO = 'userinfo'
+  HOST = 'host'
+  PORT = 'port'
+  PATH = 'path'
+  QUERY = 'query'
+  FRAGMENT = 'fragment'
+  OPAQUE = 'opaque'
 
   URI_MEMBERS = {
     SCHEME => AttrReader.new(SCHEME),

data/lib/puppet/pops/types/puppet_object.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/recursion_guard.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 # Keeps track of self recursion of conceptual 'this' and 'that' instances using two separate maps and

data/lib/puppet/pops/types/ruby_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 
@@ -59,7 +60,7 @@ class RubyGenerator < TypeFormatter
       if cls.nil?
         rp = key.resolved_parent
         parent_class = rp.is_a?(PObjectType) ? rp.implementation_class : Object
-        class_def = ''
+        class_def = String.new
         class_body(key, EMPTY_ARRAY, class_def)
         cls = Class.new(parent_class)
         cls.class_eval(class_def)
@@ -108,7 +109,7 @@ class RubyGenerator < TypeFormatter
     end
 
     # Create class definition of all contained types
-    bld = ''
+    bld = String.new
     start_module(common_prefix, comment, bld)
     class_names = []
     names_by_prefix.each_pair do |seg_array, index_and_name_array|

data/lib/puppet/pops/types/ruby_method.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
   class RubyMethod < Annotation

data/lib/puppet/pops/types/string_converter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops
@@ -263,14 +264,14 @@ class StringConverter
   }.freeze
 
   DEFAULT_ARRAY_FORMAT                          = Format.new('%a')
-  DEFAULT_ARRAY_FORMAT.separator                = ', '.freeze
-  DEFAULT_ARRAY_FORMAT.separator2               = ', '.freeze
+  DEFAULT_ARRAY_FORMAT.separator                = ', '
+  DEFAULT_ARRAY_FORMAT.separator2               = ', '
   DEFAULT_ARRAY_FORMAT.container_string_formats = DEFAULT_CONTAINER_FORMATS
   DEFAULT_ARRAY_FORMAT.freeze
 
   DEFAULT_HASH_FORMAT                           = Format.new('%h')
-  DEFAULT_HASH_FORMAT.separator                 = ', '.freeze
-  DEFAULT_HASH_FORMAT.separator2                = ' => '.freeze
+  DEFAULT_HASH_FORMAT.separator                 = ', '
+  DEFAULT_HASH_FORMAT.separator2                = ' => '
   DEFAULT_HASH_FORMAT.container_string_formats  = DEFAULT_CONTAINER_FORMATS
   DEFAULT_HASH_FORMAT.freeze
 
@@ -700,7 +701,7 @@ class StringConverter
   # Performs post-processing of literals to apply width and precision flags
   def apply_string_flags(f, literal_str)
     if f.left || f.width || f.prec
-      fmt = '%'
+      fmt = String.new('%')
       fmt << '-' if f.left
       fmt << f.width.to_s if f.width
       fmt << '.' << f.prec.to_s if f.prec
@@ -852,7 +853,7 @@ class StringConverter
     end
 
     # Assume that the string can be single quoted
-    bld = '\''
+    bld = String.new('\'')
     bld.force_encoding(str.encoding)
     escaped = false
     str.each_codepoint do |codepoint|
@@ -883,7 +884,7 @@ class StringConverter
   end
 
   def puppet_double_quote(str)
-    bld = '"'
+    bld = String.new('"')
     str.each_codepoint do |codepoint|
       case codepoint
       when 0x09
@@ -939,7 +940,7 @@ class StringConverter
 
     case format.format
     when :a, :s, :p
-      buf = ''
+      buf = String.new
       if indentation.breaks?
         buf << "\n"
         buf << indentation.padding
@@ -1054,7 +1055,7 @@ class StringConverter
 
     when :h, :s, :p
       indentation = indentation.indenting(format.alt? || indentation.is_indenting?)
-      buf = ''
+      buf = String.new
       if indentation.breaks?
         buf << "\n"
         buf << indentation.padding

data/lib/puppet/pops/types/tree_iterators.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Types
 module Iterable
 

data/lib/puppet/pops/types/type_acceptor.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 # Implements a standard visitor patter for the Puppet Type system.

data/lib/puppet/pops/types/type_asserter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Utility module for type assertion
 #
 module Puppet::Pops::Types

data/lib/puppet/pops/types/type_assertion_error.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 module Puppet::Pops::Types
   # Raised when an assertion of actual type against an expected type fails.

data/lib/puppet/pops/types/type_calculator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops
@@ -233,7 +234,7 @@ class TypeCalculator
     when c == Hash
       # Assume hash of any
       type = PHashType::DEFAULT
-   else
+    else
       type = PRuntimeType.new(:ruby, c.name)
     end
     type

data/lib/puppet/pops/types/type_conversion_error.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 module Puppet::Pops::Types
   # Raised when a conversion of a value to another type failed.

data/lib/puppet/pops/types/type_factory.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 # Helper module that makes creation of type objects simpler.
@@ -281,7 +282,7 @@ module TypeFactory
       when PPatternType
         re.patterns
 
-     else
+      else
        raise ArgumentError, "Only String, Regexp, Pattern-Type, and Regexp-Type are allowed: got '#{re.class}"
       end
     end.flatten.uniq

data/lib/puppet/pops/types/type_formatter.rb

@@ -50,7 +50,7 @@ class TypeFormatter
   # @api public
   #
   def string(t)
-    @bld = ''.dup
+    @bld = String.new
     append_string(t)
     @bld
   end
@@ -64,7 +64,7 @@ class TypeFormatter
   #
   # @api public
   def indented_string(t, indent = 0, indent_width = 2)
-    @bld = ''.dup
+    @bld = String.new
     append_indented_string(t, indent, indent_width)
     @bld
   end

data/lib/puppet/pops/types/type_mismatch_describer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
   # @api private

data/lib/puppet/pops/types/type_parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 # This class provides parsing of Type Specification from a string into the Type

data/lib/puppet/pops/types/type_set_reference.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 class TypeSetReference

data/lib/puppet/pops/types/type_with_members.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/types.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'iterable'
 require_relative 'recursion_guard'
 require_relative 'type_acceptor'
@@ -1712,7 +1713,7 @@ class PRegexpType < PScalarType
     if options == 0
       rx_string
     else
-      bld = '(?'
+      bld = String.new('(?')
       bld << 'i' if (options & Regexp::IGNORECASE) != 0
       bld << 'm' if (options & Regexp::MULTILINE) != 0
       bld << 'x' if (options & Regexp::EXTENDED) != 0
@@ -1919,7 +1920,7 @@ end
 #
 class PStructElement < TypedModelObject
   def self.register_ptype(loader, ir)
-    @type = Pcore::create_object_type(loader, ir, self, 'Pcore::StructElement'.freeze, nil,
+    @type = Pcore::create_object_type(loader, ir, self, 'Pcore::StructElement', nil,
       'key_type' => PTypeType::DEFAULT,
       'value_type' => PTypeType::DEFAULT)
   end

data/lib/puppet/pops/utils.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Provides utility methods
 module Puppet::Pops
 module Utils
@@ -105,11 +106,11 @@ module Utils
 
   # is the name absolute (i.e. starts with ::)
   def self.is_absolute? name
-    name.start_with? "::".freeze
+    name.start_with? "::"
   end
 
   def self.name_to_segments name
-    name.split("::".freeze)
+    name.split("::")
   end
 
   def self.relativize_name name

data/lib/puppet/pops/validation/checker4_0.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/pops/evaluator/external_syntax_support'
 
 module Puppet::Pops

data/lib/puppet/pops/validation/tasks_checker.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Validation
 

data/lib/puppet/pops/validation/validator_factory_4_0.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Validation
 # Configures validation suitable for 4.0

data/lib/puppet/pops/validation.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 # A module with base functionality for validation of a model.
 #

data/lib/puppet/pops/visitable.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Visitable is a mix-in module that makes a class visitable by a Visitor
 module Puppet::Pops::Visitable
   def accept(visitor, *arguments)

data/lib/puppet/pops/visitor.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 # A Visitor performs delegation to a given receiver based on the configuration of the Visitor.
 # A new visitor is created with a given receiver, a method prefix, min, and max argument counts.

data/lib/puppet/pops.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   # The Pops language system. This includes the parser, evaluator, AST model, and
   # Binder.
@@ -12,13 +13,13 @@ module Puppet
   module Pops
     EMPTY_HASH = {}.freeze
     EMPTY_ARRAY = [].freeze
-    EMPTY_STRING = ''.freeze
+    EMPTY_STRING = ''
 
     MAX_INTEGER =  0x7fffffffffffffff
     MIN_INTEGER = -0x8000000000000000
 
-    DOUBLE_COLON = '::'.freeze
-    USCORE = '_'.freeze
+    DOUBLE_COLON = '::'
+    USCORE = '_'
 
     require 'semantic_puppet'
 

data/lib/puppet/property/boolean.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/coercion'
 
 class Puppet::Property::Boolean < Puppet::Property

data/lib/puppet/property/ensure.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/property'
 
 # This property is automatically added to any {Puppet::Type} that responds

data/lib/puppet/property/keyvalue.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/property'
 
 module Puppet

data/lib/puppet/property/list.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/property'
 
 module Puppet

data/lib/puppet/property/ordered_list.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/property/list'
 
 module Puppet

data/lib/puppet/property.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The virtual base class for properties, which are the self-contained building
 # blocks for actually doing work on the system.
 

data/lib/puppet/provider/aix_object.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Common code for AIX user/group providers.
 class Puppet::Provider::AixObject < Puppet::Provider
   desc "Generic AIX resource provider"

data/lib/puppet/provider/command.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A command that can be executed on the system
 class Puppet::Provider::Command
   attr_reader :executable

data/lib/puppet/provider/confine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Confines have been moved out of the provider as they are also used for other things.
 # This provides backwards compatibility for people still including this old location.
 require_relative '../../puppet/provider'

data/lib/puppet/provider/exec/posix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/exec'
 
 Puppet::Type.type(:exec).provide :posix, :parent => Puppet::Provider::Exec do

data/lib/puppet/provider/exec/shell.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Type.type(:exec).provide :shell, :parent => :posix do
   include Puppet::Util::Execution
 

data/lib/puppet/provider/exec/windows.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/exec'
 
 Puppet::Type.type(:exec).provide :windows, :parent => Puppet::Provider::Exec do
 
-  confine    :operatingsystem => :windows
-  defaultfor :operatingsystem => :windows
+  confine    'os.name' => :windows
+  defaultfor 'os.name' => :windows
 
   desc <<-'EOT'
     Execute external binaries on Windows systems. As with the `posix`
@@ -45,7 +46,7 @@ Puppet::Type.type(:exec).provide :windows, :parent => Puppet::Provider::Exec do
     end
 
     if resource[:path]
-      Puppet::Util.withenv( {'PATH' => resource[:path].join(File::PATH_SEPARATOR)}, :windows) do
+      Puppet::Util.withenv('PATH' => resource[:path].join(File::PATH_SEPARATOR)) do
         return if which(exe)
       end
     end

data/lib/puppet/provider/exec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/provider'
 require_relative '../../puppet/util/execution'
 

data/lib/puppet/provider/file/posix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Type.type(:file).provide :posix do
   desc "Uses POSIX functionality to manage file ownership and permissions."
 

data/lib/puppet/provider/file/windows.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 Puppet::Type.type(:file).provide :windows do
   desc "Uses Microsoft Windows functionality to manage file ownership and permissions."
 
-  confine :operatingsystem => :windows
+  confine 'os.name' => :windows
   has_feature :manages_symlinks if Puppet.features.manages_symlinks?
 
   include Puppet::Util::Warnings

data/lib/puppet/provider/group/aix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Group Puppet provider for AIX. It uses standard commands to manage groups:
 #  mkgroup, rmgroup, lsgroup, chgroup
 require_relative '../../../puppet/provider/aix_object'
@@ -6,8 +7,8 @@ Puppet::Type.type(:group).provide :aix, :parent => Puppet::Provider::AixObject d
   desc "Group management for AIX."
 
   # This will the default provider for this platform
-  defaultfor :operatingsystem => :aix
-  confine :operatingsystem => :aix
+  defaultfor 'os.name' => :aix
+  confine 'os.name' => :aix
 
   # Commands that manage the element
   commands :list      => "/usr/sbin/lsgroup"

data/lib/puppet/provider/group/directoryservice.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/nameservice/directoryservice'
 
 Puppet::Type.type(:group).provide :directoryservice, :parent => Puppet::Provider::NameService::DirectoryService do
@@ -6,8 +7,8 @@ Puppet::Type.type(:group).provide :directoryservice, :parent => Puppet::Provider
   "
 
   commands :dscl => "/usr/bin/dscl"
-  confine :operatingsystem => :darwin
-  defaultfor :operatingsystem => :darwin
+  confine 'os.name' => :darwin
+  defaultfor 'os.name' => :darwin
   has_feature :manages_members
 
   def members_insync?(current, should)

data/lib/puppet/provider/group/groupadd.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/nameservice/objectadd'
 require_relative '../../../puppet/util/libuser'
 
@@ -9,7 +10,7 @@ Puppet::Type.type(:group).provide :groupadd, :parent => Puppet::Provider::NameSe
 
   commands :add => "groupadd", :delete => "groupdel", :modify => "groupmod"
 
-  has_feature :system_groups unless %w{HP-UX Solaris}.include? Puppet.runtime[:facter].value(:operatingsystem)
+  has_feature :system_groups unless %w{HP-UX Solaris}.include? Puppet.runtime[:facter].value('os.name')
 
   verify :gid, _("GID must be an integer") do |value|
     value.is_a? Integer

data/lib/puppet/provider/group/ldap.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/ldap'
 
 Puppet::Type.type(:group).provide :ldap, :parent => Puppet::Provider::Ldap do

data/lib/puppet/provider/group/pw.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/nameservice/pw'
 
 Puppet::Type.type(:group).provide :pw, :parent => Puppet::Provider::NameService::PW do
@@ -6,8 +7,8 @@ Puppet::Type.type(:group).provide :pw, :parent => Puppet::Provider::NameService:
   commands :pw => "pw"
   has_features :manages_members
 
-  defaultfor :operatingsystem => [:freebsd, :dragonfly]
-  confine    :operatingsystem => [:freebsd, :dragonfly]
+  defaultfor 'os.name' => [:freebsd, :dragonfly]
+  confine    'os.name' => [:freebsd, :dragonfly]
 
   options :members, :flag => "-M", :method => :mem
 

data/lib/puppet/provider/group/windows_adsi.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 
 Puppet::Type.type(:group).provide :windows_adsi do
   desc "Local group management for Windows. Group members can be both users and groups.
     Additionally, local groups can contain domain users."
 
-  defaultfor :operatingsystem => :windows
-  confine    :operatingsystem => :windows
+  defaultfor 'os.name' => :windows
+  confine    'os.name' => :windows
 
   has_features :manages_members
 

data/lib/puppet/provider/ldap.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/provider'
 
 # The base class for LDAP providers.

data/lib/puppet/provider/nameservice/directoryservice.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet'
 require_relative '../../../puppet/provider/nameservice'
 require_relative '../../../puppet/util/plist' if Puppet.features.cfpropertylist?
@@ -18,9 +19,9 @@ class Puppet::Provider::NameService::DirectoryService < Puppet::Provider::NameSe
   commands :dscl => "/usr/bin/dscl"
   commands :dseditgroup => "/usr/sbin/dseditgroup"
   commands :sw_vers => "/usr/bin/sw_vers"
-  confine :operatingsystem => :darwin
+  confine 'os.name' => :darwin
   confine :feature         => :cfpropertylist
-  defaultfor :operatingsystem => :darwin
+  defaultfor 'os.name' => :darwin
 
   # There is no generalized mechanism for provider cache management, but we can
   # use post_resource_eval, which will be run for each suitable provider at the
@@ -217,8 +218,8 @@ class Puppet::Provider::NameService::DirectoryService < Puppet::Provider::NameSe
         password_hash_plist = users_plist['ShadowHashData'][0]
         converted_hash_plist = convert_binary_to_hash(password_hash_plist)
       else
-        users_plist['ShadowHashData'] = ''
-        converted_hash_plist = {'SALTED-SHA512' => ''}
+        users_plist['ShadowHashData'] = String.new
+        converted_hash_plist = {'SALTED-SHA512' => String.new}
       end
 
       # converted_hash_plist['SALTED-SHA512'] expects a Base64 encoded

data/lib/puppet/provider/nameservice/objectadd.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/nameservice'
 
 class Puppet::Provider::NameService

data/lib/puppet/provider/nameservice/pw.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/nameservice/objectadd'
 
 class Puppet::Provider::NameService

data/lib/puppet/provider/nameservice.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 
 # This is the parent class of all NSS classes.  They're very different in

data/lib/puppet/provider/network_device.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 # This is the base class of all prefetched network device provider
 class Puppet::Provider::NetworkDevice < Puppet::Provider

data/lib/puppet/provider/package/aix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/provider/package'
 require_relative '../../../puppet/util/package'
 
@@ -24,8 +25,8 @@ Puppet::Type.type(:package).provide :aix, :parent => Puppet::Provider::Package d
   # AIX supports versionable packages with and without a NIM server
   has_feature :versionable
 
-  confine  :operatingsystem => [ :aix ]
-  defaultfor :operatingsystem => :aix
+  confine  'os.name' => [ :aix ]
+  defaultfor 'os.name' => :aix
 
   attr_accessor   :latest_info
 

data/lib/puppet/provider/package/appdmg.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Jeff McCune <mccune.jeff@gmail.com>
 # Changed to app.dmg by: Udo Waechter <root@zoide.net>
 # Mac OS X Package Installer which handles application (.app)
@@ -17,7 +18,7 @@ require_relative '../../../puppet/util/plist' if Puppet.features.cfpropertylist?
 Puppet::Type.type(:package).provide(:appdmg, :parent => Puppet::Provider::Package) do
   desc "Package management which copies application bundles to a target."
 
-  confine :operatingsystem => :darwin
+  confine 'os.name' => :darwin
   confine :feature         => :cfpropertylist
 
   commands :hdiutil => "/usr/bin/hdiutil"