puppet 7.27.0-x64-mingw32 → 8.0.1-x64-mingw32

data/lib/puppet/pops/model/model_tree_dumper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Dumps a Pops::Model in reverse polish notation; i.e. LISP style
 # The intention is to use this for debugging output
 # TODO: BAD NAME - A DUMP is a Ruby Serialization

data/lib/puppet/pops/model/pn_transformer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops

data/lib/puppet/pops/model/tree_dumper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Base class for formatted textual dump of a "model"
 #
 class Puppet::Pops::Model::TreeDumper
@@ -20,7 +21,7 @@ class Puppet::Pops::Model::TreeDumper
   end
 
   def format(x)
-    result = ""
+    result = String.new
     parts = format_r(x)
     parts.each_index do |i|
       if i > 0

data/lib/puppet/pops/parser/code_merger.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 class Puppet::Pops::Parser::CodeMerger
 

data/lib/puppet/pops/parser/epp_parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The EppParser is a specialized Puppet Parser that starts parsing in Epp Text mode
 class Puppet::Pops::Parser::EppParser < Puppet::Pops::Parser::Parser
 

data/lib/puppet/pops/parser/epp_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Parser
 # This module is an integral part of the Lexer.
@@ -182,7 +183,7 @@ module EppSupport
       @skip_leading = skip_leading
 
       return nil if scanner.eos?
-      s = ""
+      s = String.new
       until scanner.eos?
         part = @scanner.scan_until(/(<%)|\z/)
         if @skip_leading

data/lib/puppet/pops/parser/evaluating_parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops
@@ -124,7 +125,7 @@ class EvaluatingParser
   # @return [String] The quoted string
   #
   def self.quote(x)
-    escaped = '"'
+    escaped = String.new('"')
     p = nil
     x.each_char do |c|
       case p

data/lib/puppet/pops/parser/heredoc_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Parser
 module HeredocSupport

data/lib/puppet/pops/parser/interpolation_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This module is an integral part of the Lexer.
 # It defines interpolation support
 # PERFORMANCE NOTE: There are 4 very similar methods in this module that are designed to be as

data/lib/puppet/pops/parser/lexer_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 module Puppet::Pops
 module Parser

data/lib/puppet/pops/parser/locatable.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Interface for something that is "locatable" (holds offset and length).
 class Puppet::Pops::Parser::Locatable
 

data/lib/puppet/pops/parser/locator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Parser
 # Helper class that keeps track of where line breaks are located and can answer questions about positions.

data/lib/puppet/pops/parser/parser_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/parser/functions'
 require_relative '../../../puppet/parser/files'
 require_relative '../../../puppet/resource/type_collection'

data/lib/puppet/pops/parser/pn_parser.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Parser
 
 class PNParser
-  LIT_TRUE = 'true'.freeze
-  LIT_FALSE = 'false'.freeze
-  LIT_NIL = 'nil'.freeze
+  LIT_TRUE = 'true'
+  LIT_FALSE = 'false'
+  LIT_NIL = 'nil'
 
   TOKEN_END = 0
   TOKEN_BOOL = 1
@@ -217,7 +218,7 @@ class PNParser
 
   def consume_string
     s = @pos
-    b = ''
+    b = String.new
     loop do
       c = next_cp
       case c

data/lib/puppet/pops/patterns.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The Patterns module contains common regular expression patters for the Puppet DSL language
 module Puppet::Pops::Patterns
 

data/lib/puppet/pops/pcore.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'uri'
 
 module Puppet::Pops
@@ -11,8 +12,8 @@ module Pcore
   TYPE_QUALIFIED_REFERENCE = Types::TypeFactory.pattern(/\A[A-Z][\w]*(?:::[A-Z][\w]*)*\z/)
   TYPE_MEMBER_NAME = Types::PPatternType.new([Types::PRegexpType.new(Patterns::PARAM_NAME)])
 
-  KEY_PCORE_URI = 'pcore_uri'.freeze
-  KEY_PCORE_VERSION = 'pcore_version'.freeze
+  KEY_PCORE_URI = 'pcore_uri'
+  KEY_PCORE_VERSION = 'pcore_version'
 
   PCORE_URI = 'http://puppet.com/2016.1/pcore'
   PCORE_VERSION = SemanticPuppet::Version.new(1,0,0)

data/lib/puppet/pops/pn.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module PN
   KEY_PATTERN = /^[A-Za-z_-][0-9A-Za-z_-]*$/
@@ -19,7 +20,7 @@ module PN
   end
 
   def to_s
-    s = ''
+    s = String.new
     format(nil, s)
     s
   end

data/lib/puppet/pops/puppet_stack.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/thread_local'
 
 module Puppet

data/lib/puppet/pops/resource/param.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # An implementation of the interface Puppet::Resource
 # that adapts the 3.x compiler and catalog expectations on
 # a resource instance. This instance is backed by a

data/lib/puppet/pops/resource/resource_type_impl.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'param'
 
 module Puppet::Pops

data/lib/puppet/pops/semantic_error.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Error that is used to raise an Issue. See {Puppet::Pops::Issues}.
 #
 class Puppet::Pops::SemanticError < RuntimeError

data/lib/puppet/pops/serialization/abstract_reader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'extension'
 require_relative 'time_factory'
 

data/lib/puppet/pops/serialization/abstract_writer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'extension'
 
 module Puppet::Pops

data/lib/puppet/pops/serialization/deserializer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'extension'
 
 module Puppet::Pops

data/lib/puppet/pops/serialization/extension.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
 module Extension

data/lib/puppet/pops/serialization/from_data_converter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
   class Builder

data/lib/puppet/pops/serialization/instance_reader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
   # An InstanceReader is responsible for reading an instance of a complex object using a deserializer. The read involves creating the

data/lib/puppet/pops/serialization/instance_writer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
   # An instance writer is responsible for writing complex objects using a {Serializer}

data/lib/puppet/pops/serialization/json.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/json'
 
 module Puppet::Pops

data/lib/puppet/pops/serialization/json_path.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops
@@ -10,7 +11,7 @@ module JsonPath
   #
   # @api private
   def self.to_json_path(path)
-    p = '$'
+    p = String.new('$')
     path.each do |seg|
       if seg.nil?
         p << '[null]'

data/lib/puppet/pops/serialization/object.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'instance_reader'
 require_relative 'instance_writer'
 

data/lib/puppet/pops/serialization/serializer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'extension'
 
 module Puppet::Pops

data/lib/puppet/pops/serialization/time_factory.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
   # Implements all the constructors found in the Time class and ensures that

data/lib/puppet/pops/serialization/to_data_converter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
   # Class that can process an arbitrary object into a value that is assignable to `Data`.
@@ -63,7 +64,7 @@ module Serialization
     private
 
     def path_to_s
-      s = @message_prefix || ''
+      s = String.new(@message_prefix || '')
       s << JsonPath.to_json_path(@path)[1..-1]
       s
     end

data/lib/puppet/pops/serialization/to_stringified_converter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
 

data/lib/puppet/pops/serialization.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Serialization
   def self.not_implemented(impl, method_name)
@@ -7,28 +8,28 @@ module Serialization
   class SerializationError < Puppet::Error
   end
 
-  PCORE_TYPE_KEY = '__ptype'.freeze
+  PCORE_TYPE_KEY = '__ptype'
 
   # Key used when the value can be represented as, and recreated from, a single string that can
   # be passed to a `from_string` method or an array of values that can be passed to the default
   # initializer method.
-  PCORE_VALUE_KEY = '__pvalue'.freeze
+  PCORE_VALUE_KEY = '__pvalue'
 
   # Type key used for hashes that contain keys that are not of type String
-  PCORE_TYPE_HASH = 'Hash'.freeze
+  PCORE_TYPE_HASH = 'Hash'
 
   # Type key used for symbols
-  PCORE_TYPE_SENSITIVE = 'Sensitive'.freeze
-  PCORE_TYPE_BINARY = 'Binary'.freeze
+  PCORE_TYPE_SENSITIVE = 'Sensitive'
+  PCORE_TYPE_BINARY = 'Binary'
 
   # Type key used for symbols
-  PCORE_TYPE_SYMBOL = 'Symbol'.freeze
+  PCORE_TYPE_SYMBOL = 'Symbol'
 
   # Type key used for Default
-  PCORE_TYPE_DEFAULT = 'Default'.freeze
+  PCORE_TYPE_DEFAULT = 'Default'
 
   # Type key used for document local references
-  PCORE_LOCAL_REF_SYMBOL = 'LocalRef'.freeze
+  PCORE_LOCAL_REF_SYMBOL = 'LocalRef'
 end
 end
 

data/lib/puppet/pops/time/timespan.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops
@@ -9,16 +10,16 @@ module Time
   NSECS_PER_HOUR = NSECS_PER_MIN  * 60
   NSECS_PER_DAY  = NSECS_PER_HOUR * 24
 
-  KEY_STRING = 'string'.freeze
-  KEY_FORMAT = 'format'.freeze
-  KEY_NEGATIVE = 'negative'.freeze
-  KEY_DAYS = 'days'.freeze
-  KEY_HOURS = 'hours'.freeze
-  KEY_MINUTES = 'minutes'.freeze
-  KEY_SECONDS = 'seconds'.freeze
-  KEY_MILLISECONDS = 'milliseconds'.freeze
-  KEY_MICROSECONDS = 'microseconds'.freeze
-  KEY_NANOSECONDS = 'nanoseconds'.freeze
+  KEY_STRING = 'string'
+  KEY_FORMAT = 'format'
+  KEY_NEGATIVE = 'negative'
+  KEY_DAYS = 'days'
+  KEY_HOURS = 'hours'
+  KEY_MINUTES = 'minutes'
+  KEY_SECONDS = 'seconds'
+  KEY_MILLISECONDS = 'milliseconds'
+  KEY_MICROSECONDS = 'microseconds'
+  KEY_NANOSECONDS = 'nanoseconds'
 
   # TimeData is a Numeric that stores its value internally as nano-seconds but will be considered to be seconds and fractions of
   # seconds when used in arithmetic or comparison with other Numeric types.
@@ -544,7 +545,7 @@ module Time
       end
 
       def format(timespan)
-        bld = timespan.negative? ? '-' : ''
+        bld = String.new(timespan.negative? ? '-' : '')
         @segments.each { |segment| segment.append_to(bld, timespan) }
         bld
       end
@@ -574,7 +575,7 @@ module Time
       end
 
       def build_regexp
-        bld = '\A-?'
+        bld = String.new('\A-?')
         @segments.each { |segment| segment.append_regexp(bld) }
         bld << '\z'
         Regexp.new(bld)
@@ -612,7 +613,7 @@ module Time
 
       def append_literal(bld, codepoint)
         if bld.empty? || !bld.last.is_a?(Format::LiteralSegment)
-          bld << Format::LiteralSegment.new(''.concat(codepoint))
+          bld << Format::LiteralSegment.new(String.new.concat(codepoint))
         else
           bld.last.concat(codepoint)
         end
@@ -633,7 +634,7 @@ module Time
         position = -1
         fstart = 0
 
-        str.each_codepoint do |codepoint|
+        str.codepoints do |codepoint|
           position += 1
           if state == STATE_LITERAL
             if codepoint == 0x25 # '%'

data/lib/puppet/pops/time/timestamp.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Time
 class Timestamp < TimeData
   DEFAULT_FORMATS_WO_TZ = ['%FT%T.%N', '%FT%T', '%F %T.%N', '%F %T', '%F']
   DEFAULT_FORMATS = ['%FT%T.%N %Z', '%FT%T %Z', '%F %T.%N %Z', '%F %T %Z', '%F %Z'] + DEFAULT_FORMATS_WO_TZ
 
-  CURRENT_TIMEZONE = 'current'.freeze
-  KEY_TIMEZONE = 'timezone'.freeze
+  CURRENT_TIMEZONE = 'current'
+  KEY_TIMEZONE = 'timezone'
 
   # Converts a timezone that strptime can parse using '%z' into '-HH:MM' or '+HH:MM'
   # @param [String] tz the timezone to convert

data/lib/puppet/pops/types/annotatable.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 
-KEY_ANNOTATIONS = 'annotations'.freeze
+KEY_ANNOTATIONS = 'annotations'
 
 # Behaviour common to all Pcore annotatable classes
 #

data/lib/puppet/pops/types/annotation.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
   # Pcore variant of the Adaptable::Adapter. Uses a Pcore Object type instead of a Class
   class Annotation < Adaptable::Adapter
     include Types::PuppetObject
 
-    CLEAR = 'clear'.freeze
+    CLEAR = 'clear'
 
     # Register the Annotation type. This is the type that all custom Annotations will inherit from.
     def self.register_ptype(loader, ir)

data/lib/puppet/pops/types/class_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 # The ClassLoader provides a Class instance given a class name or a meta-type.

data/lib/puppet/pops/types/implementation_registry.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
   # The {ImplementationRegistry} maps names types in the Puppet Type System to names of corresponding implementation

data/lib/puppet/pops/types/iterable.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Types
 
   # Implemented by classes that can produce an iterator to iterate over their contents

data/lib/puppet/pops/types/p_binary_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'base64'
 module Puppet::Pops
 module Types

data/lib/puppet/pops/types/p_init_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/p_meta_type.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
 # @abstract base class for PObjectType and other types that implements lazy evaluation of content
 # @api private
 module Puppet::Pops
 module Types
 
-KEY_NAME = 'name'.freeze
-KEY_TYPE = 'type'.freeze
-KEY_VALUE = 'value'.freeze
+KEY_NAME = 'name'
+KEY_TYPE = 'type'
+KEY_VALUE = 'value'
 
 class PMetaType < PAnyType
   include Annotatable

data/lib/puppet/pops/types/p_object_type.rb

@@ -1,29 +1,30 @@
+# frozen_string_literal: true
 require_relative 'ruby_generator'
 require_relative 'type_with_members'
 
 module Puppet::Pops
 module Types
 
-KEY_ATTRIBUTES = 'attributes'.freeze
-KEY_CHECKS = 'checks'.freeze
-KEY_CONSTANTS = 'constants'.freeze
-KEY_EQUALITY = 'equality'.freeze
-KEY_EQUALITY_INCLUDE_TYPE = 'equality_include_type'.freeze
-KEY_FINAL = 'final'.freeze
-KEY_FUNCTIONS = 'functions'.freeze
-KEY_KIND = 'kind'.freeze
-KEY_OVERRIDE = 'override'.freeze
-KEY_PARENT = 'parent'.freeze
-KEY_TYPE_PARAMETERS = 'type_parameters'.freeze
+KEY_ATTRIBUTES = 'attributes'
+KEY_CHECKS = 'checks'
+KEY_CONSTANTS = 'constants'
+KEY_EQUALITY = 'equality'
+KEY_EQUALITY_INCLUDE_TYPE = 'equality_include_type'
+KEY_FINAL = 'final'
+KEY_FUNCTIONS = 'functions'
+KEY_KIND = 'kind'
+KEY_OVERRIDE = 'override'
+KEY_PARENT = 'parent'
+KEY_TYPE_PARAMETERS = 'type_parameters'
 
 # @api public
 class PObjectType < PMetaType
   include TypeWithMembers
 
-  ATTRIBUTE_KIND_CONSTANT = 'constant'.freeze
-  ATTRIBUTE_KIND_DERIVED = 'derived'.freeze
-  ATTRIBUTE_KIND_GIVEN_OR_DERIVED = 'given_or_derived'.freeze
-  ATTRIBUTE_KIND_REFERENCE = 'reference'.freeze
+  ATTRIBUTE_KIND_CONSTANT = 'constant'
+  ATTRIBUTE_KIND_DERIVED = 'derived'
+  ATTRIBUTE_KIND_GIVEN_OR_DERIVED = 'given_or_derived'
+  ATTRIBUTE_KIND_REFERENCE = 'reference'
   TYPE_ATTRIBUTE_KIND = TypeFactory.enum(ATTRIBUTE_KIND_CONSTANT, ATTRIBUTE_KIND_DERIVED, ATTRIBUTE_KIND_GIVEN_OR_DERIVED, ATTRIBUTE_KIND_REFERENCE)
 
   TYPE_OBJECT_NAME = Pcore::TYPE_QUALIFIED_REFERENCE

data/lib/puppet/pops/types/p_object_type_extension.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/p_runtime_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/p_sem_ver_range_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/p_sem_ver_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/p_sensitive_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 

data/lib/puppet/pops/types/p_timespan_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
   class PAbstractTimeDataType < PScalarType

data/lib/puppet/pops/types/p_timestamp_type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
   class PTimestampType < PAbstractTimeDataType

data/lib/puppet/pops/types/p_type_set_type.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Types
 
-KEY_NAME_AUTHORITY = 'name_authority'.freeze
-KEY_TYPES = 'types'.freeze
-KEY_ALIAS = 'alias'.freeze
-KEY_VERSION = 'version'.freeze
-KEY_VERSION_RANGE = 'version_range'.freeze
-KEY_REFERENCES = 'references'.freeze
+KEY_NAME_AUTHORITY = 'name_authority'
+KEY_TYPES = 'types'
+KEY_ALIAS = 'alias'
+KEY_VERSION = 'version'
+KEY_VERSION_RANGE = 'version_range'
+KEY_REFERENCES = 'references'
 
 class PTypeSetType < PMetaType
 
@@ -290,7 +291,7 @@ class PTypeSetType < PMetaType
     types = result[KEY_TYPES]
     if types.is_a?(Hash)
       types.each do |type_name, value|
-        full_name = "#{@name}::#{type_name}".freeze
+        full_name = "#{@name}::#{type_name}"
         typed_name = Loader::TypedName.new(:type, full_name, name_auth)
         if value.is_a?(Model::ResourceDefaultsExpression)
           # This is actually a <Parent> { <key-value entries> } notation. Convert to a literal hash that contains the parent
@@ -330,7 +331,7 @@ class PTypeSetType < PMetaType
     types = result[KEY_TYPES]
     if types.is_a?(Hash)
       types.each do |type_name, value|
-        full_name = "#{@name}::#{type_name}".freeze
+        full_name = "#{@name}::#{type_name}"
         typed_name = Loader::TypedName.new(:type, full_name, name_auth)
         meta_name = value.is_a?(Hash) ? 'Object' : 'TypeAlias'
         type = Loader::TypeDefinitionInstantiator.create_named_type(full_name, meta_name, value, name_auth)