puppet 6.4.0-x64-mingw32 → 6.4.1-x64-mingw32

data/spec/unit/application/facts_spec.rb

@@ -1,16 +1,15 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 require 'puppet/application/facts'
 
 describe Puppet::Application::Facts do
   before :each do
-    subject.command_line.stubs(:subcommand_name).returns 'facts'
+    allow(subject.command_line).to receive(:subcommand_name).and_return('facts')
   end
 
   it "should return facts if a key is given to find" do
     Puppet::Node::Facts.indirection.reset_terminus_class
-    Puppet::Node::Facts.indirection.expects(:find).returns(Puppet::Node::Facts.new('whatever', {}))
-    subject.command_line.stubs(:args).returns %w{find whatever --render-as yaml}
+    expect(Puppet::Node::Facts.indirection).to receive(:find).and_return(Puppet::Node::Facts.new('whatever', {}))
+    allow(subject.command_line).to receive(:args).and_return(%w{find whatever --render-as yaml})
 
     expect {
       expect {

data/spec/unit/application/filebucket_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 
 require 'puppet/application/filebucket'
@@ -35,53 +34,51 @@ describe Puppet::Application::Filebucket do
     end
 
     it "should store argument value when calling handle_#{option}" do
-      @filebucket.options.expects(:[]=).with("#{option}".to_sym, 'arg')
+      expect(@filebucket.options).to receive(:[]=).with("#{option}".to_sym, 'arg')
       @filebucket.send("handle_#{option}".to_sym, 'arg')
     end
   end
 
   describe "during setup" do
-
     before :each do
-      Puppet::Log.stubs(:newdestination)
-      Puppet.stubs(:settraps)
-      Puppet::FileBucket::Dipper.stubs(:new)
-      @filebucket.options.stubs(:[]).with(any_parameters)
+      allow(Puppet::Log).to receive(:newdestination)
+      allow(Puppet).to receive(:settraps)
+      allow(Puppet::FileBucket::Dipper).to receive(:new)
+      allow(@filebucket.options).to receive(:[])
     end
 
-
     it "should set console as the log destination" do
-      Puppet::Log.expects(:newdestination).with(:console)
+      expect(Puppet::Log).to receive(:newdestination).with(:console)
 
       @filebucket.setup
     end
 
     it "should trap INT" do
-      Signal.expects(:trap).with(:INT)
+      expect(Signal).to receive(:trap).with(:INT)
 
       @filebucket.setup
     end
 
     it "should set log level to debug if --debug was passed" do
-      @filebucket.options.stubs(:[]).with(:debug).returns(true)
+      allow(@filebucket.options).to receive(:[]).with(:debug).and_return(true)
       @filebucket.setup
       expect(Puppet::Log.level).to eq(:debug)
     end
 
     it "should set log level to info if --verbose was passed" do
-      @filebucket.options.stubs(:[]).with(:verbose).returns(true)
+      allow(@filebucket.options).to receive(:[]).with(:verbose).and_return(true)
       @filebucket.setup
       expect(Puppet::Log.level).to eq(:info)
     end
 
     it "should print puppet config if asked to in Puppet config" do
-      Puppet.settings.stubs(:print_configs?).returns(true)
-      Puppet.settings.expects(:print_configs).returns(true)
+      allow(Puppet.settings).to receive(:print_configs?).and_return(true)
+      expect(Puppet.settings).to receive(:print_configs).and_return(true)
       expect { @filebucket.setup }.to exit_with 0
     end
 
     it "should exit after printing puppet config if asked to in Puppet config" do
-      Puppet.settings.stubs(:print_configs?).returns(true)
+      allow(Puppet.settings).to receive(:print_configs?).and_return(true)
       expect { @filebucket.setup }.to exit_with 1
     end
 
@@ -89,123 +86,119 @@ describe Puppet::Application::Filebucket do
       let(:path) { File.expand_path("path") }
 
       before :each do
-        @filebucket.options.stubs(:[]).with(:local).returns(true)
+        allow(@filebucket.options).to receive(:[]).with(:local).and_return(true)
       end
 
       it "should create a client with the default bucket if none passed" do
         Puppet[:clientbucketdir] = path
         Puppet[:bucketdir] = path + "2"
 
-        Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Path] == path }
+        expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Path: path))
 
         @filebucket.setup
       end
 
       it "should create a local Dipper with the given bucket" do
-        @filebucket.options.stubs(:[]).with(:bucket).returns(path)
+        allow(@filebucket.options).to receive(:[]).with(:bucket).and_return(path)
 
-        Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Path] == path }
+        expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Path: path))
 
         @filebucket.setup
       end
-
     end
 
     describe "with remote bucket" do
       it "should create a remote Client to the configured server" do
         Puppet[:server] = "puppet.reductivelabs.com"
-        Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Server] == "puppet.reductivelabs.com" }
+        expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Server: "puppet.reductivelabs.com"))
         @filebucket.setup
       end
 
       it "should default to the first server_list entry if set" do
         Puppet[:server_list] = "foo,bar,baz"
-        Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Server] == "foo" }
+        expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Server: "foo"))
         @filebucket.setup
       end
 
       it "should fall back to server if server_list is empty" do
         Puppet[:server_list] = ""
-        Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Server] == "puppet" }
+        expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Server: "puppet"))
         @filebucket.setup
       end
 
       it "should take both the server and port specified in server_list" do
         Puppet[:server_list] = "foo:632,bar:6215,baz:351"
-        Puppet::FileBucket::Dipper.expects(:new).with({ :Server => "foo", :Port => "632" })
+        expect(Puppet::FileBucket::Dipper).to receive(:new).with({ :Server => "foo", :Port => "632" })
         @filebucket.setup
       end
     end
   end
 
   describe "when running" do
-
     before :each do
-      Puppet::Log.stubs(:newdestination)
-      Puppet.stubs(:settraps)
-      Puppet::FileBucket::Dipper.stubs(:new)
-      @filebucket.options.stubs(:[]).with(any_parameters)
+      allow(Puppet::Log).to receive(:newdestination)
+      allow(Puppet).to receive(:settraps)
+      allow(Puppet::FileBucket::Dipper).to receive(:new)
+      allow(@filebucket.options).to receive(:[])
 
-      @client = stub 'client'
-      Puppet::FileBucket::Dipper.stubs(:new).returns(@client)
+      @client = double('client')
+      allow(Puppet::FileBucket::Dipper).to receive(:new).and_return(@client)
 
       @filebucket.setup
     end
 
     it "should use the first non-option parameter as the dispatch" do
-      @filebucket.command_line.stubs(:args).returns(['get'])
+      allow(@filebucket.command_line).to receive(:args).and_return(['get'])
 
-      @filebucket.expects(:get)
+      expect(@filebucket).to receive(:get)
 
       @filebucket.run_command
     end
 
     describe "the command get" do
-
       before :each do
-        @filebucket.stubs(:print)
-        @filebucket.stubs(:args).returns([])
+        allow(@filebucket).to receive(:print)
+        allow(@filebucket).to receive(:args).and_return([])
       end
 
       it "should call the client getfile method" do
-        @client.expects(:getfile)
+        expect(@client).to receive(:getfile)
 
         @filebucket.get
       end
 
       it "should call the client getfile method with the given md5" do
         md5="DEADBEEF"
-        @filebucket.stubs(:args).returns([md5])
+        allow(@filebucket).to receive(:args).and_return([md5])
 
-        @client.expects(:getfile).with(md5)
+        expect(@client).to receive(:getfile).with(md5)
 
         @filebucket.get
       end
 
       it "should print the file content" do
-        @client.stubs(:getfile).returns("content")
+        allow(@client).to receive(:getfile).and_return("content")
 
-        @filebucket.expects(:print).returns("content")
+        expect(@filebucket).to receive(:print).and_return("content")
 
         @filebucket.get
       end
-
     end
 
     describe "the command backup" do
       it "should fail if no arguments are specified" do
-        @filebucket.stubs(:args).returns([])
+        allow(@filebucket).to receive(:args).and_return([])
         expect { @filebucket.backup }.to raise_error(RuntimeError, /You must specify a file to back up/)
       end
 
       it "should call the client backup method for each given parameter" do
-        @filebucket.stubs(:puts)
-        Puppet::FileSystem.stubs(:exist?).returns(true)
-        FileTest.stubs(:readable?).returns(true)
-        @filebucket.stubs(:args).returns(["file1", "file2"])
+        allow(@filebucket).to receive(:puts)
+        allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
+        allow(FileTest).to receive(:readable?).and_return(true)
+        allow(@filebucket).to receive(:args).and_return(["file1", "file2"])
 
-        @client.expects(:backup).with("file1")
-        @client.expects(:backup).with("file2")
+        expect(@client).to receive(:backup).with("file1")
+        expect(@client).to receive(:backup).with("file2")
 
         @filebucket.backup
       end
@@ -215,9 +208,9 @@ describe Puppet::Application::Filebucket do
       it "should call the client getfile method with the given md5" do
         md5="DEADBEEF"
         file="testfile"
-        @filebucket.stubs(:args).returns([file, md5])
+        allow(@filebucket).to receive(:args).and_return([file, md5])
 
-        @client.expects(:restore).with(file,md5)
+        expect(@client).to receive(:restore).with(file,md5)
 
         @filebucket.restore
       end
@@ -227,10 +220,10 @@ describe Puppet::Application::Filebucket do
       it "should call the client diff method with 2 given checksums" do
         md5a="DEADBEEF"
         md5b="BEEF"
-        Puppet::FileSystem.stubs(:exist?).returns(false)
-        @filebucket.stubs(:args).returns([md5a, md5b])
+        allow(Puppet::FileSystem).to receive(:exist?).and_return(false)
+        allow(@filebucket).to receive(:args).and_return([md5a, md5b])
 
-        @client.expects(:diff).with(md5a,md5b, nil, nil)
+        expect(@client).to receive(:diff).with(md5a,md5b, nil, nil)
 
         @filebucket.diff
       end
@@ -238,11 +231,11 @@ describe Puppet::Application::Filebucket do
       it "should call the clien diff with a path if the second argument is a file" do
         md5a="DEADBEEF"
         md5b="BEEF"
-        Puppet::FileSystem.stubs(:exist?).with(md5a).returns(false)
-        Puppet::FileSystem.stubs(:exist?).with(md5b).returns(true)
-        @filebucket.stubs(:args).returns([md5a, md5b])
+        allow(Puppet::FileSystem).to receive(:exist?).with(md5a).and_return(false)
+        allow(Puppet::FileSystem).to receive(:exist?).with(md5b).and_return(true)
+        allow(@filebucket).to receive(:args).and_return([md5a, md5b])
 
-        @client.expects(:diff).with(md5a, nil, nil, md5b)
+        expect(@client).to receive(:diff).with(md5a, nil, nil, md5b)
 
         @filebucket.diff
       end
@@ -250,11 +243,11 @@ describe Puppet::Application::Filebucket do
       it "should call the clien diff with a path if the first argument is a file" do
         md5a="DEADBEEF"
         md5b="BEEF"
-        Puppet::FileSystem.stubs(:exist?).with(md5a).returns(true)
-        Puppet::FileSystem.stubs(:exist?).with(md5b).returns(false)
-        @filebucket.stubs(:args).returns([md5a, md5b])
+        allow(Puppet::FileSystem).to receive(:exist?).with(md5a).and_return(true)
+        allow(Puppet::FileSystem).to receive(:exist?).with(md5b).and_return(false)
+        allow(@filebucket).to receive(:args).and_return([md5a, md5b])
 
-        @client.expects(:diff).with(nil, md5b, md5a, nil)
+        expect(@client).to receive(:diff).with(nil, md5b, md5a, nil)
 
         @filebucket.diff
       end
@@ -262,28 +255,30 @@ describe Puppet::Application::Filebucket do
       it "should call the clien diff with paths if the both arguments are files" do
         md5a="DEADBEEF"
         md5b="BEEF"
-        Puppet::FileSystem.stubs(:exist?).with(md5a).returns(true)
-        Puppet::FileSystem.stubs(:exist?).with(md5b).returns(true)
-        @filebucket.stubs(:args).returns([md5a, md5b])
+        allow(Puppet::FileSystem).to receive(:exist?).with(md5a).and_return(true)
+        allow(Puppet::FileSystem).to receive(:exist?).with(md5b).and_return(true)
+        allow(@filebucket).to receive(:args).and_return([md5a, md5b])
 
-        @client.expects(:diff).with(nil, nil, md5a, md5b)
+        expect(@client).to receive(:diff).with(nil, nil, md5a, md5b)
 
         @filebucket.diff
       end
 
       it "should fail if only one checksum is given" do
         md5a="DEADBEEF"
-        @filebucket.stubs(:args).returns([md5a])
+        allow(@filebucket).to receive(:args).and_return([md5a])
 
         expect { @filebucket.diff }.to raise_error Puppet::Error
       end
     end
+
     describe "the command list" do
       it "should call the client list method with nil dates" do
-        @client.expects(:list).with(nil, nil)
+        expect(@client).to receive(:list).with(nil, nil)
 
         @filebucket.list
       end
+
       it "should call the client list method with the given dates" do
         # 3 Hours ago
         threehours = 60*60*3
@@ -292,16 +287,13 @@ describe Puppet::Application::Filebucket do
         onehour = 60*60
         todate = (Time.now - onehour).strftime("%F %T")
 
-        @filebucket.options.stubs(:[]).with(:fromdate).returns(fromdate)
-        @filebucket.options.stubs(:[]).with(:todate).returns(todate)
+        allow(@filebucket.options).to receive(:[]).with(:fromdate).and_return(fromdate)
+        allow(@filebucket.options).to receive(:[]).with(:todate).and_return(todate)
 
-        @client.expects(:list).with(fromdate, todate)
+        expect(@client).to receive(:list).with(fromdate, todate)
 
         @filebucket.list
       end
     end
-
   end
-
-
 end

data/spec/unit/application/indirection_base_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 require 'puppet/util/command_line'
 require 'puppet/application/indirection_base'
@@ -32,11 +31,14 @@ describe Puppet::Application::IndirectionBase do
   it "should accept a terminus command line option" do
     # It would be nice not to have to stub this, but whatever... writing an
     # entire indirection stack would cause us more grief. --daniel 2011-03-31
-    terminus = stub_everything("test indirection terminus")
-    terminus.stubs(:name).returns(:test_indirection)
-
-    Puppet::Indirector::Indirection.expects(:instance).
-      with(:test_indirection).returns(terminus)
+    terminus = double("test indirection terminus")
+    allow(terminus).to receive(:name).and_return(:test_indirection)
+    allow(terminus).to receive(:terminus_class=)
+    allow(terminus).to receive(:save)
+    allow(terminus).to receive(:reset_terminus_class)
+
+    expect(Puppet::Indirector::Indirection).to receive(:instance).
+      with(:test_indirection).and_return(terminus)
 
     command_line = Puppet::Util::CommandLine.new("puppet", %w{test_indirection --terminus foo save bar})
     application = Puppet::Application::TestIndirection.new(command_line)

data/spec/unit/application/lookup_spec.rb

@@ -30,7 +30,7 @@ describe Puppet::Application::Lookup do
     it "does not allow invalid arguments for '--merge'" do
       lookup.options[:node] = 'dantooine.local'
       lookup.options[:merge] = 'something_bad'
-      lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
+      allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
 
       expected_error = "The --merge option only accepts 'first', 'hash', 'unique', or 'deep'\nRun 'puppet lookup --help' for more details"
 
@@ -41,7 +41,7 @@ describe Puppet::Application::Lookup do
       lookup.options[:node] = 'dantooine.local'
       lookup.options[:merge_hash_arrays] = true
       lookup.options[:merge] = 'hash'
-      lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
+      allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
 
       expected_error = "The options --knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays are only available with '--merge deep'\nRun 'puppet lookup --help' for more details"
 
@@ -57,12 +57,12 @@ describe Puppet::Application::Lookup do
       lookup.options[:render_as] = :s;
       lookup.options[:merge_hash_arrays] = true
       lookup.options[:merge] = 'deep'
-      lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
-      lookup.stubs(:generate_scope).yields('scope')
+      allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
+      allow(lookup).to receive(:generate_scope).and_yield('scope')
 
       expected_merge = { "strategy" => "deep", "sort_merged_arrays" => false, "merge_hash_arrays" => true }
 
-      (Puppet::Pops::Lookup).expects(:lookup).with(['atton', 'kreia'], nil, nil, false, expected_merge, anything).returns('rand')
+      expect(Puppet::Pops::Lookup).to receive(:lookup).with(['atton', 'kreia'], nil, nil, false, expected_merge, anything).and_return('rand')
 
       expect(run_lookup(lookup)).to eql("rand")
     end
@@ -73,9 +73,9 @@ describe Puppet::Application::Lookup do
         lookup.options[:node] = 'dantooine.local'
         lookup.options[:merge] = opt
         lookup.options[:render_as] = :s
-        lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
-        lookup.stubs(:generate_scope).yields('scope')
-        Puppet::Pops::Lookup.stubs(:lookup).returns('rand')
+        allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
+        allow(lookup).to receive(:generate_scope).and_yield('scope')
+        allow(Puppet::Pops::Lookup).to receive(:lookup).and_return('rand')
         expect(run_lookup(lookup)).to eql("rand")
       end
     end
@@ -83,10 +83,10 @@ describe Puppet::Application::Lookup do
     it "prints the value found by lookup" do
       lookup.options[:node] = 'dantooine.local'
       lookup.options[:render_as] = :s
-      lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
-      lookup.stubs(:generate_scope).yields('scope')
+      allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
+      allow(lookup).to receive(:generate_scope).and_yield('scope')
 
-      Puppet::Pops::Lookup.stubs(:lookup).returns('rand')
+      allow(Puppet::Pops::Lookup).to receive(:lookup).and_return('rand')
 
       expect(run_lookup(lookup)).to eql("rand")
     end
@@ -271,7 +271,7 @@ describe Puppet::Application::Lookup do
     it '--explain produces human readable text by default and does not produce output to debug logger' do
       lookup.options[:node] = node
       lookup.options[:explain] = true
-      lookup.command_line.stubs(:args).returns(['a'])
+      allow(lookup.command_line).to receive(:args).and_return(['a'])
       logs = []
       Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
         expect(run_lookup(lookup)).to eql(<<-EXPLANATION.chomp)
@@ -300,7 +300,7 @@ Searching for "a"
 
     it '--debug using multiple interpolation functions produces output to the logger' do
       lookup.options[:node] = node
-      lookup.command_line.stubs(:args).returns(['ab'])
+      allow(lookup.command_line).to receive(:args).and_return(['ab'])
       Puppet.debug = true
       logs = []
       begin
@@ -320,7 +320,7 @@ Searching for "a"
     it '--explain produces human readable text by default and --debug produces the same output to debug logger' do
       lookup.options[:node] = node
       lookup.options[:explain] = true
-      lookup.command_line.stubs(:args).returns(['a'])
+      allow(lookup.command_line).to receive(:args).and_return(['a'])
       Puppet.debug = true
       logs = []
       Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
@@ -434,7 +434,7 @@ Lookup of '__global__'
       lookup.options[:node] = node
       lookup.options[:explain] = true
       lookup.options[:explain_options] = true
-      lookup.command_line.stubs(:args).returns(['a'])
+      allow(lookup.command_line).to receive(:args).and_return(['a'])
       expect(run_lookup(lookup)).to eql(<<-EXPLANATION.chomp)
 Searching for "lookup_options"
   Global Data Provider (hiera configuration version 5)
@@ -461,7 +461,7 @@ Searching for "a"
       lookup.options[:node] = node
       lookup.options[:explain] = true
       lookup.options[:render_as] = :yaml
-      lookup.command_line.stubs(:args).returns(['a'])
+      allow(lookup.command_line).to receive(:args).and_return(['a'])
       output = run_lookup(lookup)
       expect(Puppet::Util::Yaml.safe_load(output, [Symbol])).to eq(expected_yaml_hash)
     end
@@ -470,7 +470,7 @@ Searching for "a"
       lookup.options[:node] = node
       lookup.options[:explain] = true
       lookup.options[:render_as] = :json
-      lookup.command_line.stubs(:args).returns(['a'])
+      allow(lookup.command_line).to receive(:args).and_return(['a'])
       output = run_lookup(lookup)
       expect(JSON.parse(output)).to eq(expected_json_hash)
     end
@@ -478,7 +478,7 @@ Searching for "a"
     it 'can access values using dotted keys' do
       lookup.options[:node] = node
       lookup.options[:render_as] = :json
-      lookup.command_line.stubs(:args).returns(['d.one.two.three'])
+      allow(lookup.command_line).to receive(:args).and_return(['d.one.two.three'])
       output = run_lookup(lookup)
       expect(JSON.parse("[#{output}]")).to eq(['the value'])
     end
@@ -486,7 +486,7 @@ Searching for "a"
     it 'can access values using quoted dotted keys' do
       lookup.options[:node] = node
       lookup.options[:render_as] = :json
-      lookup.command_line.stubs(:args).returns(['"e.one.two.three"'])
+      allow(lookup.command_line).to receive(:args).and_return(['"e.one.two.three"'])
       output = run_lookup(lookup)
       expect(JSON.parse("[#{output}]")).to eq(['the value'])
     end
@@ -494,7 +494,7 @@ Searching for "a"
     it 'can access values using mix of dotted keys and quoted dotted keys' do
       lookup.options[:node] = node
       lookup.options[:render_as] = :json
-      lookup.command_line.stubs(:args).returns(['"f.one"."two.three".1'])
+      allow(lookup.command_line).to receive(:args).and_return(['"f.one"."two.three".1'])
       output = run_lookup(lookup)
       expect(JSON.parse("[#{output}]")).to eq(['second value'])
     end
@@ -505,7 +505,7 @@ Searching for "a"
       it "is unaffected by global variables unless '--compile' is used" do
         lookup.options[:node] = node
         lookup.options[:render_as] = :s
-        lookup.command_line.stubs(:args).returns(['c'])
+        allow(lookup.command_line).to receive(:args).and_return(['c'])
         expect(run_lookup(lookup)).to eql("This is")
       end
 
@@ -513,7 +513,7 @@ Searching for "a"
         lookup.options[:node] = node
         lookup.options[:compile] = true
         lookup.options[:render_as] = :s
-        lookup.command_line.stubs(:args).returns(['c'])
+        allow(lookup.command_line).to receive(:args).and_return(['c'])
         expect(run_lookup(lookup)).to eql("This is C from site.pp")
       end
 
@@ -528,7 +528,7 @@ Searching for "a"
         lookup.options[:node] = node
         lookup.options[:fact_file] = filename
         lookup.options[:render_as] = :s
-        lookup.command_line.stubs(:args).returns(['c'])
+        allow(lookup.command_line).to receive(:args).and_return(['c'])
         expect(run_lookup(lookup)).to eql("This is C from facts")
       end
 
@@ -543,7 +543,7 @@ Searching for "a"
         lookup.options[:node] = node
         lookup.options[:fact_file] = filename
         lookup.options[:render_as] = :s
-        lookup.command_line.stubs(:args).returns(['g'])
+        allow(lookup.command_line).to receive(:args).and_return(['g'])
         expect(run_lookup(lookup)).to eql("This is G from facts in facts hash")
       end
     end
@@ -553,7 +553,7 @@ Searching for "a"
 
       it "works OK in the absense of '--compile'" do
         lookup.options[:node] = node
-        lookup.command_line.stubs(:args).returns(['c'])
+        allow(lookup.command_line).to receive(:args).and_return(['c'])
         lookup.options[:render_as] = :s
         expect(run_lookup(lookup)).to eql("This is C from data.pp")
       end
@@ -562,7 +562,7 @@ Searching for "a"
         lookup.options[:node] = node
         lookup.options[:compile] = true
         lookup.options[:render_as] = :s
-        lookup.command_line.stubs(:args).returns(['c'])
+        allow(lookup.command_line).to receive(:args).and_return(['c'])
         expect(run_lookup(lookup)).to eql("This is C from site.pp")
       end
     end