puppet 6.4.0-x64-mingw32 → 6.4.1-x64-mingw32

data/spec/unit/application/agent_spec.rb

@@ -1,4 +1,3 @@
-#! /usr/bin/env ruby
 require 'spec_helper'
 
 require 'puppet/agent'
@@ -12,25 +11,25 @@ describe Puppet::Application::Agent do
     @puppetd = Puppet::Application[:agent]
 
     @daemon = Puppet::Daemon.new(nil)
-    @daemon.stubs(:daemonize)
-    @daemon.stubs(:start)
-    @daemon.stubs(:stop)
-    Puppet::Daemon.stubs(:new).returns(@daemon)
+    allow(@daemon).to receive(:daemonize)
+    allow(@daemon).to receive(:start)
+    allow(@daemon).to receive(:stop)
+    allow(Puppet::Daemon).to receive(:new).and_return(@daemon)
     Puppet[:daemonize] = false
 
-    @agent = stub_everything 'agent'
-    Puppet::Agent.stubs(:new).returns(@agent)
+    @agent = double('agent')
+    allow(Puppet::Agent).to receive(:new).and_return(@agent)
 
     @puppetd.preinit
-    Puppet::Util::Log.stubs(:newdestination)
+    allow(Puppet::Util::Log).to receive(:newdestination)
 
-    Puppet::Node.indirection.stubs(:terminus_class=)
-    Puppet::Node.indirection.stubs(:cache_class=)
-    Puppet::Node::Facts.indirection.stubs(:terminus_class=)
+    allow(Puppet::Node.indirection).to receive(:terminus_class=)
+    allow(Puppet::Node.indirection).to receive(:cache_class=)
+    allow(Puppet::Node::Facts.indirection).to receive(:terminus_class=)
 
-    $stderr.expects(:puts).never
+    expect($stderr).not_to receive(:puts)
 
-    Puppet.settings.stubs(:use)
+    allow(Puppet.settings).to receive(:use)
   end
 
   it "should operate in agent run_mode" do
@@ -55,7 +54,7 @@ describe Puppet::Application::Agent do
 
   describe "in preinit" do
     it "should catch INT" do
-      Signal.expects(:trap).with { |arg,block| arg == :INT }
+      expect(Signal).to receive(:trap).with(:INT)
 
       @puppetd.preinit
     end
@@ -93,7 +92,7 @@ describe Puppet::Application::Agent do
 
   describe "when handling options" do
     before do
-      @puppetd.command_line.stubs(:args).returns([])
+      allow(@puppetd.command_line).to receive(:args).and_return([])
     end
 
     [:enable, :debug, :fqdn, :test, :verbose, :digest].each do |option|
@@ -123,26 +122,26 @@ describe Puppet::Application::Agent do
     end
 
     it "should set waitforcert to 0 with --onetime and if --waitforcert wasn't given" do
-      @agent.stubs(:run).returns(2)
+      allow(@agent).to receive(:run).and_return(2)
       Puppet[:onetime] = true
 
-      Puppet::SSL::StateMachine.expects(:new).with(waitforcert: 0).returns(stub(ensure_client_certificate: nil))
+      expect(Puppet::SSL::StateMachine).to receive(:new).with(waitforcert: 0).and_return(double(ensure_client_certificate: nil))
 
       expect { execute_agent }.to exit_with 0
     end
 
     it "should use supplied waitforcert when --onetime is specified" do
-      @agent.stubs(:run).returns(2)
+      allow(@agent).to receive(:run).and_return(2)
       Puppet[:onetime] = true
       @puppetd.handle_waitforcert(60)
 
-      Puppet::SSL::StateMachine.expects(:new).with(waitforcert: 60).returns(stub(ensure_client_certificate: nil))
+      expect(Puppet::SSL::StateMachine).to receive(:new).with(waitforcert: 60).and_return(double(ensure_client_certificate: nil))
 
       expect { execute_agent }.to exit_with 0
     end
 
     it "should use a default value for waitforcert when --onetime and --waitforcert are not specified" do
-      Puppet::SSL::StateMachine.expects(:new).with(waitforcert: 120).returns(stub(ensure_client_certificate: nil))
+      expect(Puppet::SSL::StateMachine).to receive(:new).with(waitforcert: 120).and_return(double(ensure_client_certificate: nil))
 
       execute_agent
     end
@@ -150,13 +149,13 @@ describe Puppet::Application::Agent do
     it "should use the waitforcert setting when checking for a signed certificate" do
       Puppet[:waitforcert] = 10
 
-      Puppet::SSL::StateMachine.expects(:new).with(waitforcert: 10).returns(stub(ensure_client_certificate: nil))
+      expect(Puppet::SSL::StateMachine).to receive(:new).with(waitforcert: 10).and_return(double(ensure_client_certificate: nil))
 
       execute_agent
     end
 
     it "should set the log destination with --logdest" do
-      Puppet::Log.expects(:newdestination).with("console")
+      expect(Puppet::Log).to receive(:newdestination).with("console")
 
       @puppetd.handle_logdest("console")
     end
@@ -168,9 +167,9 @@ describe Puppet::Application::Agent do
     end
 
     it "should parse the log destination from the command line" do
-      @puppetd.command_line.stubs(:args).returns(%w{--logdest /my/file})
+      allow(@puppetd.command_line).to receive(:args).and_return(%w{--logdest /my/file})
 
-      Puppet::Util::Log.expects(:newdestination).with("/my/file")
+      expect(Puppet::Util::Log).to receive(:newdestination).with("/my/file")
 
       @puppetd.parse_options
     end
@@ -184,25 +183,25 @@ describe Puppet::Application::Agent do
 
   describe "during setup" do
     before :each do
-      Puppet.stubs(:info)
+      allow(Puppet).to receive(:info)
       Puppet[:libdir] = "/dev/null/lib"
-      Puppet::Transaction::Report.indirection.stubs(:terminus_class=)
-      Puppet::Transaction::Report.indirection.stubs(:cache_class=)
-      Puppet::Resource::Catalog.indirection.stubs(:terminus_class=)
-      Puppet::Resource::Catalog.indirection.stubs(:cache_class=)
-      Puppet::Node::Facts.indirection.stubs(:terminus_class=)
-      Puppet.stubs(:settraps)
+      allow(Puppet::Transaction::Report.indirection).to receive(:terminus_class=)
+      allow(Puppet::Transaction::Report.indirection).to receive(:cache_class=)
+      allow(Puppet::Resource::Catalog.indirection).to receive(:terminus_class=)
+      allow(Puppet::Resource::Catalog.indirection).to receive(:cache_class=)
+      allow(Puppet::Node::Facts.indirection).to receive(:terminus_class=)
+      allow(Puppet).to receive(:settraps)
     end
 
     it "should not run with extra arguments" do
-      @puppetd.command_line.stubs(:args).returns(%w{disable})
+      allow(@puppetd.command_line).to receive(:args).and_return(%w{disable})
       expect{@puppetd.setup}.to raise_error ArgumentError, /does not take parameters/
     end
 
     describe "with --test" do
       it "should call setup_test" do
         @puppetd.options[:test] = true
-        @puppetd.expects(:setup_test)
+        expect(@puppetd).to receive(:setup_test)
 
         @puppetd.setup
       end
@@ -225,13 +224,13 @@ describe Puppet::Application::Agent do
     end
 
     it "should call setup_logs" do
-      @puppetd.expects(:setup_logs)
+      expect(@puppetd).to receive(:setup_logs)
       @puppetd.setup
     end
 
     describe "when setting up logs" do
       before :each do
-        Puppet::Util::Log.stubs(:newdestination)
+        allow(Puppet::Util::Log).to receive(:newdestination)
       end
 
       it "should set log level to debug if --debug was passed" do
@@ -250,8 +249,8 @@ describe Puppet::Application::Agent do
         it "should set console as the log destination with level #{level}" do
           @puppetd.options[level] = true
 
-          Puppet::Util::Log.expects(:newdestination).at_least_once
-          Puppet::Util::Log.expects(:newdestination).with(:console).once
+          allow(Puppet::Util::Log).to receive(:newdestination)
+          expect(Puppet::Util::Log).to receive(:newdestination).with(:console).exactly(:once)
 
           @puppetd.setup_logs
         end
@@ -260,16 +259,15 @@ describe Puppet::Application::Agent do
       it "should set a default log destination if no --logdest" do
         @puppetd.options[:setdest] = false
 
-        Puppet::Util::Log.expects(:setup_default)
+        expect(Puppet::Util::Log).to receive(:setup_default)
 
         @puppetd.setup_logs
       end
-
     end
 
     it "should print puppet config if asked to in Puppet config" do
       Puppet[:configprint] = "plugindest"
-      Puppet.settings.expects(:print_configs).returns true
+      expect(Puppet.settings).to receive(:print_configs).and_return(true)
       expect { execute_agent }.to exit_with 0
     end
 
@@ -277,32 +275,31 @@ describe Puppet::Application::Agent do
       path = make_absolute('/my/path')
       Puppet[:modulepath] = path
       Puppet[:configprint] = "modulepath"
-      Puppet::Settings.any_instance.expects(:puts).with(path)
+      expect_any_instance_of(Puppet::Settings).to receive(:puts).with(path)
       expect { execute_agent }.to exit_with 0
     end
 
     it "should use :main, :puppetd, and :ssl" do
-      Puppet.settings.unstub(:use)
-      Puppet.settings.expects(:use).with(:main, :agent, :ssl)
+      expect(Puppet.settings).to receive(:use).with(:main, :agent, :ssl)
 
       @puppetd.setup
     end
 
     it "should setup an agent in fingerprint mode" do
       @puppetd.options[:fingerprint] = true
-      @puppetd.expects(:setup_agent).never
+      expect(@puppetd).not_to receive(:setup_agent)
 
       @puppetd.setup
     end
 
     it "should tell the report handler to use REST" do
-      Puppet::Transaction::Report.indirection.expects(:terminus_class=).with(:rest)
+      expect(Puppet::Transaction::Report.indirection).to receive(:terminus_class=).with(:rest)
 
       @puppetd.setup
     end
 
     it "should tell the report handler to cache locally as yaml" do
-      Puppet::Transaction::Report.indirection.expects(:cache_class=).with(:yaml)
+      expect(Puppet::Transaction::Report.indirection).to receive(:cache_class=).with(:yaml)
 
       @puppetd.setup
     end
@@ -318,7 +315,7 @@ describe Puppet::Application::Agent do
     end
 
     it "has an application default :catalog_cache_terminus setting of 'json'" do
-      Puppet::Resource::Catalog.indirection.expects(:cache_class=).with(:json)
+      expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:json)
 
       @puppetd.initialize_app_defaults
       @puppetd.setup
@@ -326,7 +323,7 @@ describe Puppet::Application::Agent do
 
     it "should tell the catalog cache class based on the :catalog_cache_terminus setting" do
       Puppet[:catalog_cache_terminus] = "yaml"
-      Puppet::Resource::Catalog.indirection.expects(:cache_class=).with(:yaml)
+      expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:yaml)
 
       @puppetd.initialize_app_defaults
       @puppetd.setup
@@ -334,8 +331,7 @@ describe Puppet::Application::Agent do
 
     it "should not set catalog cache class if :catalog_cache_terminus is explicitly nil" do
       Puppet[:catalog_cache_terminus] = nil
-      Puppet::Resource::Catalog.indirection.unstub(:cache_class=)
-      Puppet::Resource::Catalog.indirection.expects(:cache_class=).never
+      expect(Puppet::Resource::Catalog.indirection).not_to receive(:cache_class=)
 
       @puppetd.initialize_app_defaults
       @puppetd.setup
@@ -347,7 +343,7 @@ describe Puppet::Application::Agent do
     end
 
     it "should create an agent" do
-      Puppet::Agent.stubs(:new).with(Puppet::Configurer)
+      allow(Puppet::Agent).to receive(:new).with(Puppet::Configurer)
 
       @puppetd.setup
     end
@@ -355,7 +351,7 @@ describe Puppet::Application::Agent do
     [:enable, :disable].each do |action|
       it "should delegate to enable_disable_client if we #{action} the agent" do
         @puppetd.options[action] = true
-        @puppetd.expects(:enable_disable_client).with(@agent)
+        expect(@puppetd).to receive(:enable_disable_client).with(@agent)
 
         @puppetd.setup
       end
@@ -365,7 +361,7 @@ describe Puppet::Application::Agent do
       [:enable, :disable].each do |action|
         it "should call client.#{action}" do
           @puppetd.options[action] = true
-          @agent.expects(action)
+          expect(@agent).to receive(action)
           expect { execute_agent }.to exit_with 0
         end
       end
@@ -373,7 +369,7 @@ describe Puppet::Application::Agent do
       it "should pass the disable message when disabling" do
         @puppetd.options[:disable] = true
         @puppetd.options[:disable_message] = "message"
-        @agent.expects(:disable).with("message")
+        expect(@agent).to receive(:disable).with("message")
 
         expect { execute_agent }.to exit_with 0
       end
@@ -381,7 +377,7 @@ describe Puppet::Application::Agent do
       it "should pass the default disable message when disabling without a message" do
         @puppetd.options[:disable] = true
         @puppetd.options[:disable_message] = nil
-        @agent.expects(:disable).with("reason not specified")
+        expect(@agent).to receive(:disable).with("reason not specified")
 
         expect { execute_agent }.to exit_with 0
       end
@@ -390,7 +386,7 @@ describe Puppet::Application::Agent do
     it "should inform the daemon about our agent if :client is set to 'true'" do
       @puppetd.options[:client] = true
 
-      Puppet::SSL::StateMachine.stubs(:new).returns(stub(ensure_client_certificate: nil))
+      allow(Puppet::SSL::StateMachine).to receive(:new).and_return(double(ensure_client_certificate: nil))
 
       execute_agent
 
@@ -398,13 +394,13 @@ describe Puppet::Application::Agent do
     end
 
     it "should daemonize if needed" do
-      Puppet::Util::Platform.stubs(:windows?).returns false
+      allow(Puppet::Util::Platform).to receive(:windows?).and_return(false)
       Puppet[:daemonize] = true
-      Signal.stubs(:trap)
+      allow(Signal).to receive(:trap)
 
-      Puppet::SSL::StateMachine.stubs(:new).returns(stub(ensure_client_certificate: nil))
+      allow(Puppet::SSL::StateMachine).to receive(:new).and_return(double(ensure_client_certificate: nil))
 
-      @daemon.expects(:daemonize)
+      expect(@daemon).to receive(:daemonize)
 
       execute_agent
     end
@@ -412,7 +408,7 @@ describe Puppet::Application::Agent do
     it "should wait for a certificate" do
       @puppetd.options[:waitforcert] = 123
 
-      Puppet::SSL::StateMachine.expects(:new).with(waitforcert: 123).returns(stub(ensure_client_certificate: nil))
+      expect(Puppet::SSL::StateMachine).to receive(:new).with(waitforcert: 123).and_return(double(ensure_client_certificate: nil))
 
       execute_agent
     end
@@ -422,12 +418,12 @@ describe Puppet::Application::Agent do
       @puppetd.options[:waitforcert] = 123
       @puppetd.options[:digest] = 'MD5'
 
-      certificate = mock 'certificate'
-      certificate.stubs(:to_der).returns('ABCDE')
-      ssl_context = mock('ssl_context', client_cert: certificate)
-      Puppet::SSL::StateMachine.stubs(:new).with(onetime: true).returns(stub(ensure_client_certificate: ssl_context))
+      certificate = double('certificate')
+      allow(certificate).to receive(:to_der).and_return('ABCDE')
+      ssl_context = double('ssl_context', client_cert: certificate)
+      allow(Puppet::SSL::StateMachine).to receive(:new).with(onetime: true).and_return(double(ensure_client_certificate: ssl_context))
 
-      @puppetd.expects(:puts).with('(MD5) 2E:CD:DE:39:59:05:1D:91:3F:61:B1:45:79:EA:13:6D')
+      expect(@puppetd).to receive(:puts).with('(MD5) 2E:CD:DE:39:59:05:1D:91:3F:61:B1:45:79:EA:13:6D')
 
       execute_agent
     end
@@ -438,36 +434,35 @@ describe Puppet::Application::Agent do
       end
 
       it "should not setup as an agent" do
-        @puppetd.expects(:setup_agent).never
+        expect(@puppetd).not_to receive(:setup_agent)
         @puppetd.setup
       end
 
       it "should not create an agent" do
-        Puppet::Agent.stubs(:new).with(Puppet::Configurer).never
+        expect(Puppet::Agent).not_to receive(:new).with(Puppet::Configurer)
         @puppetd.setup
       end
 
       it "should not daemonize" do
-        @daemon.expects(:daemonize).never
+        expect(@daemon).not_to receive(:daemonize)
         @puppetd.setup
       end
     end
 
     describe "when configuring agent for catalog run" do
       it "should set should_fork as true when running normally" do
-        Puppet::Agent.expects(:new).with(anything, true)
+        expect(Puppet::Agent).to receive(:new).with(anything, true)
         @puppetd.setup
       end
 
       it "should not set should_fork as false for --onetime" do
         Puppet[:onetime] = true
-        Puppet::Agent.expects(:new).with(anything, false)
+        expect(Puppet::Agent).to receive(:new).with(anything, false)
         @puppetd.setup
       end
     end
   end
 
-
   describe "when running" do
     before :each do
       @puppetd.options[:fingerprint] = false
@@ -476,61 +471,60 @@ describe Puppet::Application::Agent do
     it "should dispatch to fingerprint if --fingerprint is used" do
       @puppetd.options[:fingerprint] = true
 
-      @puppetd.expects(:fingerprint)
+      expect(@puppetd).to receive(:fingerprint)
 
       execute_agent
     end
 
     it "should dispatch to onetime if --onetime is used" do
       Puppet[:onetime] = true
-      Puppet::SSL::StateMachine.stubs(:new).returns(stub(ensure_client_certificate: nil))
+      allow(Puppet::SSL::StateMachine).to receive(:new).and_return(double(ensure_client_certificate: nil))
 
-      @puppetd.expects(:onetime)
+      expect(@puppetd).to receive(:onetime)
 
       execute_agent
     end
 
     it "should dispatch to main if --onetime and --fingerprint are not used" do
       Puppet[:onetime] = false
-      Puppet::SSL::StateMachine.stubs(:new).returns(stub(ensure_client_certificate: nil))
+      allow(Puppet::SSL::StateMachine).to receive(:new).and_return(double(ensure_client_certificate: nil))
 
-      @puppetd.expects(:main)
+      expect(@puppetd).to receive(:main)
 
       execute_agent
     end
 
     describe "with --onetime" do
-
       before :each do
-        @agent.stubs(:run).returns(:report)
+        allow(@agent).to receive(:run).and_return(:report)
         Puppet[:onetime] = true
         @puppetd.options[:client] = :client
         @puppetd.options[:detailed_exitcodes] = false
 
-        Puppet::SSL::StateMachine.stubs(:new).returns(stub(ensure_client_certificate: nil))
+        allow(Puppet::SSL::StateMachine).to receive(:new).and_return(double(ensure_client_certificate: nil))
       end
 
       it "should setup traps" do
-        @daemon.expects(:set_signal_traps)
+        expect(@daemon).to receive(:set_signal_traps)
 
         expect { execute_agent }.to exit_with 0
       end
 
       it "should let the agent run" do
-        @agent.expects(:run).returns(:report)
+        expect(@agent).to receive(:run).and_return(:report)
 
         expect { execute_agent }.to exit_with 0
       end
 
       it "should run the agent with the supplied job_id" do
         @puppetd.options[:job_id] = 'special id'
-        @agent.expects(:run).with(:job_id => 'special id').returns(:report)
+        expect(@agent).to receive(:run).with(:job_id => 'special id').and_return(:report)
 
         expect { execute_agent }.to exit_with 0
       end
 
       it "should stop the daemon" do
-        @daemon.expects(:stop).with(:exit => false)
+        expect(@daemon).to receive(:stop).with(:exit => false)
 
         expect { execute_agent }.to exit_with 0
       end
@@ -542,14 +536,14 @@ describe Puppet::Application::Agent do
 
         it "should exit with agent computed exit status" do
           Puppet[:noop] = false
-          @agent.stubs(:run).returns(666)
+          allow(@agent).to receive(:run).and_return(666)
 
           expect { execute_agent }.to exit_with 666
         end
 
         it "should exit with the agent's exit status, even if --noop is set." do
           Puppet[:noop] = true
-          @agent.stubs(:run).returns(666)
+          allow(@agent).to receive(:run).and_return(666)
 
           expect { execute_agent }.to exit_with 666
         end
@@ -558,17 +552,17 @@ describe Puppet::Application::Agent do
 
     describe "with --fingerprint" do
       before :each do
-        @cert = mock 'cert'
+        @cert = double('cert')
         @puppetd.options[:fingerprint] = true
         @puppetd.options[:digest] = :MD5
       end
 
       it "should fingerprint the certificate if it exists" do
-        @cert.stubs(:to_der).returns('ABCDE')
-        ssl_context = mock('ssl_context', client_cert: @cert)
-        Puppet::SSL::StateMachine.stubs(:new).with(onetime: true).returns(stub(ensure_client_certificate: ssl_context))
+        allow(@cert).to receive(:to_der).and_return('ABCDE')
+        ssl_context = double('ssl_context', client_cert: @cert)
+        allow(Puppet::SSL::StateMachine).to receive(:new).with(onetime: true).and_return(double(ensure_client_certificate: ssl_context))
 
-        @puppetd.expects(:puts).with('(MD5) 2E:CD:DE:39:59:05:1D:91:3F:61:B1:45:79:EA:13:6D')
+        expect(@puppetd).to receive(:puts).with('(MD5) 2E:CD:DE:39:59:05:1D:91:3F:61:B1:45:79:EA:13:6D')
 
         @puppetd.fingerprint
       end
@@ -576,12 +570,12 @@ describe Puppet::Application::Agent do
 
     describe "without --onetime and --fingerprint" do
       before :each do
-        Puppet.stubs(:notice)
-        Puppet::SSL::StateMachine.stubs(:new).returns(stub(ensure_client_certificate: nil))
+        allow(Puppet).to receive(:notice)
+        allow(Puppet::SSL::StateMachine).to receive(:new).and_return(double(ensure_client_certificate: nil))
       end
 
       it "should start our daemon" do
-        @daemon.expects(:start)
+        expect(@daemon).to receive(:start)
 
         execute_agent
       end