puppet 6.0.10-universal-darwin → 6.1.0-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (748) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -0
  3. data/Gemfile.lock +31 -27
  4. data/Guardfile.example +76 -0
  5. data/LICENSE +189 -4
  6. data/MAINTAINERS +47 -0
  7. data/README.md +3 -3
  8. data/lib/hiera/scope.rb +0 -7
  9. data/lib/puppet.rb +6 -5
  10. data/lib/puppet/application.rb +3 -3
  11. data/lib/puppet/application/cert.rb +2 -2
  12. data/lib/puppet/application/device.rb +83 -109
  13. data/lib/puppet/application/filebucket.rb +1 -10
  14. data/lib/puppet/application/ssl.rb +0 -2
  15. data/lib/puppet/configurer.rb +9 -10
  16. data/lib/puppet/confine/false.rb +1 -7
  17. data/lib/puppet/confine/true.rb +1 -7
  18. data/lib/puppet/defaults.rb +39 -51
  19. data/lib/puppet/forge.rb +1 -4
  20. data/lib/puppet/functions/abs.rb +1 -1
  21. data/lib/puppet/functions/call.rb +1 -2
  22. data/lib/puppet/functions/new.rb +1 -1
  23. data/lib/puppet/indirector/request.rb +15 -26
  24. data/lib/puppet/network/http/connection.rb +12 -32
  25. data/lib/puppet/network/http/factory.rb +0 -5
  26. data/lib/puppet/pal/catalog_compiler.rb +96 -0
  27. data/lib/puppet/pal/compiler.rb +221 -0
  28. data/lib/puppet/pal/function_signature.rb +52 -0
  29. data/lib/puppet/pal/json_catalog_encoder.rb +67 -0
  30. data/lib/puppet/pal/pal_api.rb +15 -0
  31. data/lib/puppet/pal/pal_impl.rb +523 -0
  32. data/lib/puppet/pal/plan_signature.rb +71 -0
  33. data/lib/puppet/pal/script_compiler.rb +71 -0
  34. data/lib/puppet/pal/task_signature.rb +58 -0
  35. data/lib/puppet/parser/functions/generate.rb +7 -6
  36. data/lib/puppet/plugins/configuration.rb +5 -1
  37. data/lib/puppet/pops/evaluator/evaluator_impl.rb +5 -1
  38. data/lib/puppet/pops/evaluator/external_syntax_support.rb +3 -3
  39. data/lib/puppet/pops/issues.rb +0 -4
  40. data/lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb +4 -60
  41. data/lib/puppet/pops/model/factory.rb +4 -38
  42. data/lib/puppet/pops/model/pn_transformer.rb +0 -5
  43. data/lib/puppet/pops/parser/egrammar.ra +2 -2
  44. data/lib/puppet/pops/parser/heredoc_support.rb +7 -17
  45. data/lib/puppet/pops/parser/lexer2.rb +1 -6
  46. data/lib/puppet/pops/parser/locator.rb +86 -106
  47. data/lib/puppet/pops/parser/parser_support.rb +2 -11
  48. data/lib/puppet/pops/types/string_converter.rb +7 -2
  49. data/lib/puppet/pops/types/type_mismatch_describer.rb +1 -1
  50. data/lib/puppet/pops/types/types.rb +3 -5
  51. data/lib/puppet/pops/validation/checker4_0.rb +13 -0
  52. data/lib/puppet/provider.rb +2 -1
  53. data/lib/puppet/provider/exec.rb +6 -1
  54. data/lib/puppet/provider/file/windows.rb +1 -49
  55. data/lib/puppet/provider/group/windows_adsi.rb +1 -4
  56. data/lib/puppet/provider/package.rb +0 -2
  57. data/lib/puppet/provider/package/dpkg.rb +2 -15
  58. data/lib/puppet/provider/package/gem.rb +42 -102
  59. data/lib/puppet/provider/package/pip.rb +111 -135
  60. data/lib/puppet/provider/package/pip3.rb +1 -1
  61. data/lib/puppet/provider/package/pkgng.rb +37 -21
  62. data/lib/puppet/provider/package/puppet_gem.rb +1 -1
  63. data/lib/puppet/provider/package/rpm.rb +16 -27
  64. data/lib/puppet/provider/package/windows.rb +1 -5
  65. data/lib/puppet/provider/package/yum.rb +1 -2
  66. data/lib/puppet/provider/service/systemd.rb +17 -0
  67. data/lib/puppet/provider/service/upstart.rb +5 -17
  68. data/lib/puppet/provider/service/windows.rb +8 -3
  69. data/lib/puppet/provider/user/directoryservice.rb +4 -16
  70. data/lib/puppet/provider/user/useradd.rb +13 -16
  71. data/lib/puppet/resource.rb +3 -1
  72. data/lib/puppet/rest/client.rb +83 -0
  73. data/lib/puppet/rest/route.rb +1 -1
  74. data/lib/puppet/settings.rb +5 -10
  75. data/lib/puppet/settings/server_list_setting.rb +0 -9
  76. data/lib/puppet/ssl/host.rb +11 -0
  77. data/lib/puppet/ssl/validator/default_validator.rb +0 -31
  78. data/lib/puppet/syntax_checkers/epp.rb +34 -0
  79. data/lib/puppet/syntax_checkers/pp.rb +34 -0
  80. data/lib/puppet/transaction.rb +7 -12
  81. data/lib/puppet/transaction/event_manager.rb +5 -1
  82. data/lib/puppet/transaction/resource_harness.rb +0 -1
  83. data/lib/puppet/type.rb +6 -0
  84. data/lib/puppet/type/exec.rb +5 -27
  85. data/lib/puppet/type/file/mode.rb +1 -6
  86. data/lib/puppet/type/file/source.rb +1 -0
  87. data/lib/puppet/type/filebucket.rb +8 -12
  88. data/lib/puppet/type/package.rb +11 -44
  89. data/lib/puppet/type/schedule.rb +0 -4
  90. data/lib/puppet/type/service.rb +12 -0
  91. data/lib/puppet/type/user.rb +1 -1
  92. data/lib/puppet/util/command_line.rb +1 -5
  93. data/lib/puppet/util/connection.rb +6 -15
  94. data/lib/puppet/util/http_proxy.rb +2 -3
  95. data/lib/puppet/util/log.rb +2 -7
  96. data/lib/puppet/util/pidlock.rb +1 -15
  97. data/lib/puppet/util/windows/process.rb +5 -73
  98. data/lib/puppet/util/windows/registry.rb +1 -7
  99. data/lib/puppet/util/windows/security.rb +8 -29
  100. data/lib/puppet/util/windows/service.rb +33 -27
  101. data/lib/puppet/util/windows/user.rb +4 -14
  102. data/lib/puppet/version.rb +1 -1
  103. data/lib/puppet_pal.rb +5 -1132
  104. data/locales/ja/puppet.po +297 -363
  105. data/locales/puppet.pot +445 -517
  106. data/man/man5/puppet.conf.5 +12 -20
  107. data/man/man8/puppet-agent.8 +1 -1
  108. data/man/man8/puppet-apply.8 +1 -1
  109. data/man/man8/puppet-catalog.8 +1 -1
  110. data/man/man8/puppet-config.8 +1 -1
  111. data/man/man8/puppet-describe.8 +1 -1
  112. data/man/man8/puppet-device.8 +1 -1
  113. data/man/man8/puppet-doc.8 +1 -1
  114. data/man/man8/puppet-epp.8 +1 -1
  115. data/man/man8/puppet-facts.8 +1 -1
  116. data/man/man8/puppet-filebucket.8 +2 -6
  117. data/man/man8/puppet-generate.8 +1 -1
  118. data/man/man8/puppet-help.8 +1 -1
  119. data/man/man8/puppet-key.8 +1 -1
  120. data/man/man8/puppet-lookup.8 +1 -1
  121. data/man/man8/puppet-man.8 +1 -1
  122. data/man/man8/puppet-module.8 +1 -1
  123. data/man/man8/puppet-node.8 +1 -1
  124. data/man/man8/puppet-parser.8 +1 -1
  125. data/man/man8/puppet-plugin.8 +1 -1
  126. data/man/man8/puppet-report.8 +1 -1
  127. data/man/man8/puppet-resource.8 +1 -1
  128. data/man/man8/puppet-script.8 +1 -1
  129. data/man/man8/puppet-ssl.8 +1 -1
  130. data/man/man8/puppet-status.8 +1 -1
  131. data/man/man8/puppet.8 +2 -2
  132. data/spec/fixtures/unit/provider/package/pkgng/pkg.query +7 -1
  133. data/spec/fixtures/unit/provider/package/pkgng/pkg.query.zsh +1 -0
  134. data/spec/integration/agent/logging_spec.rb +7 -5
  135. data/spec/integration/application/apply_spec.rb +16 -18
  136. data/spec/integration/application/doc_spec.rb +2 -1
  137. data/spec/integration/application/lookup_spec.rb +5 -5
  138. data/spec/integration/configurer_spec.rb +6 -5
  139. data/spec/integration/defaults_spec.rb +6 -5
  140. data/spec/integration/directory_environments_spec.rb +1 -1
  141. data/spec/integration/faces/config_spec.rb +4 -3
  142. data/spec/integration/faces/documentation_spec.rb +1 -0
  143. data/spec/integration/faces/plugin_spec.rb +1 -1
  144. data/spec/integration/file_bucket/file_spec.rb +4 -2
  145. data/spec/integration/file_serving/content_spec.rb +1 -0
  146. data/spec/integration/file_serving/fileset_spec.rb +1 -0
  147. data/spec/integration/file_serving/metadata_spec.rb +1 -0
  148. data/spec/integration/file_serving/terminus_helper_spec.rb +1 -0
  149. data/spec/integration/indirector/catalog/compiler_spec.rb +11 -10
  150. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  151. data/spec/integration/indirector/facts/facter_spec.rb +5 -4
  152. data/spec/integration/indirector/file_content/file_server_spec.rb +8 -7
  153. data/spec/integration/indirector/file_metadata/file_server_spec.rb +8 -7
  154. data/spec/integration/network/authconfig_spec.rb +24 -23
  155. data/spec/integration/network/formats_spec.rb +1 -0
  156. data/spec/integration/node/environment_spec.rb +1 -0
  157. data/spec/integration/node/facts_spec.rb +10 -9
  158. data/spec/integration/node_spec.rb +7 -6
  159. data/spec/integration/parser/catalog_spec.rb +5 -1
  160. data/spec/integration/parser/collection_spec.rb +2 -1
  161. data/spec/integration/parser/compiler_spec.rb +6 -6
  162. data/spec/integration/parser/scope_spec.rb +1 -1
  163. data/spec/integration/parser/undef_param_spec.rb +1 -1
  164. data/spec/integration/provider/service/init_spec.rb +5 -4
  165. data/spec/integration/provider/service/systemd_spec.rb +2 -0
  166. data/spec/integration/provider/service/windows_spec.rb +2 -1
  167. data/spec/integration/reference/providers_spec.rb +2 -1
  168. data/spec/integration/reports_spec.rb +2 -1
  169. data/spec/integration/resource/catalog_spec.rb +17 -14
  170. data/spec/integration/resource/type_collection_spec.rb +5 -4
  171. data/spec/integration/ssl/certificate_request_spec.rb +1 -0
  172. data/spec/integration/ssl/host_spec.rb +2 -1
  173. data/spec/integration/ssl/key_spec.rb +1 -0
  174. data/spec/integration/test/test_helper_spec.rb +1 -0
  175. data/spec/integration/transaction/report_spec.rb +11 -6
  176. data/spec/integration/transaction_spec.rb +19 -18
  177. data/spec/integration/type/exec_spec.rb +1 -0
  178. data/spec/integration/type/file_spec.rb +33 -13
  179. data/spec/integration/type/package_spec.rb +24 -20
  180. data/spec/integration/type/tidy_spec.rb +2 -1
  181. data/spec/integration/type_spec.rb +1 -0
  182. data/spec/integration/util/autoload_spec.rb +2 -1
  183. data/spec/integration/util/rdoc/parser_spec.rb +1 -0
  184. data/spec/integration/util/settings_spec.rb +1 -0
  185. data/spec/integration/util/windows/adsi_spec.rb +5 -3
  186. data/spec/integration/util/windows/principal_spec.rb +1 -0
  187. data/spec/integration/util/windows/process_spec.rb +6 -4
  188. data/spec/integration/util/windows/registry_spec.rb +51 -93
  189. data/spec/integration/util/windows/security_spec.rb +4 -2
  190. data/spec/integration/util/windows/user_spec.rb +20 -37
  191. data/spec/integration/util_spec.rb +7 -4
  192. data/spec/lib/puppet_spec/compiler.rb +1 -1
  193. data/spec/lib/puppet_spec/files.rb +1 -0
  194. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  195. data/spec/lib/puppet_spec/scope.rb +2 -1
  196. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  197. data/spec/shared_behaviours/file_server_terminus.rb +9 -8
  198. data/spec/shared_behaviours/file_serving.rb +8 -6
  199. data/spec/shared_behaviours/file_serving_model.rb +5 -3
  200. data/spec/shared_behaviours/hiera_indirections.rb +4 -3
  201. data/spec/shared_behaviours/iterative_functions.rb +1 -0
  202. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  203. data/spec/shared_examples/rhel_package_provider.rb +70 -112
  204. data/spec/spec_helper.rb +2 -11
  205. data/spec/unit/agent/disabler_spec.rb +5 -4
  206. data/spec/unit/agent/locker_spec.rb +13 -12
  207. data/spec/unit/agent_spec.rb +85 -80
  208. data/spec/unit/application/agent_spec.rb +93 -88
  209. data/spec/unit/application/apply_spec.rb +83 -82
  210. data/spec/unit/application/config_spec.rb +1 -0
  211. data/spec/unit/application/describe_spec.rb +7 -6
  212. data/spec/unit/application/device_spec.rb +419 -395
  213. data/spec/unit/application/doc_spec.rb +46 -44
  214. data/spec/unit/application/face_base_spec.rb +62 -61
  215. data/spec/unit/application/facts_spec.rb +4 -3
  216. data/spec/unit/application/filebucket_spec.rb +74 -66
  217. data/spec/unit/application/indirection_base_spec.rb +6 -8
  218. data/spec/unit/application/lookup_spec.rb +26 -26
  219. data/spec/unit/application/resource_spec.rb +48 -42
  220. data/spec/unit/application/ssl_spec.rb +3 -8
  221. data/spec/unit/application_spec.rb +98 -86
  222. data/spec/unit/capability_spec.rb +6 -6
  223. data/spec/unit/certificate_factory_spec.rb +5 -3
  224. data/spec/unit/configurer/downloader_spec.rb +21 -20
  225. data/spec/unit/configurer/fact_handler_spec.rb +3 -2
  226. data/spec/unit/configurer/plugin_handler_spec.rb +8 -41
  227. data/spec/unit/configurer_spec.rb +198 -194
  228. data/spec/unit/confine/exists_spec.rb +15 -17
  229. data/spec/unit/confine/false_spec.rb +6 -32
  230. data/spec/unit/confine/feature_spec.rb +5 -7
  231. data/spec/unit/confine/true_spec.rb +6 -32
  232. data/spec/unit/confine/variable_spec.rb +15 -14
  233. data/spec/unit/confine_collection_spec.rb +29 -28
  234. data/spec/unit/confine_spec.rb +14 -13
  235. data/spec/unit/confiner_spec.rb +11 -10
  236. data/spec/unit/context/trusted_information_spec.rb +1 -1
  237. data/spec/unit/daemon_spec.rb +36 -35
  238. data/spec/unit/data_providers/function_data_provider_spec.rb +1 -0
  239. data/spec/unit/data_providers/hiera_data_provider_spec.rb +1 -0
  240. data/spec/unit/datatypes_spec.rb +4 -3
  241. data/spec/unit/defaults_spec.rb +27 -18
  242. data/spec/unit/environments_spec.rb +7 -7
  243. data/spec/unit/etc_spec.rb +32 -30
  244. data/spec/unit/external/pson_spec.rb +1 -0
  245. data/spec/unit/face/catalog_spec.rb +1 -0
  246. data/spec/unit/face/config_spec.rb +35 -31
  247. data/spec/unit/face/epp_face_spec.rb +4 -3
  248. data/spec/unit/face/facts_spec.rb +6 -5
  249. data/spec/unit/face/generate_spec.rb +5 -4
  250. data/spec/unit/face/help_spec.rb +8 -7
  251. data/spec/unit/face/key_spec.rb +1 -0
  252. data/spec/unit/face/man_spec.rb +2 -1
  253. data/spec/unit/face/module/install_spec.rb +5 -3
  254. data/spec/unit/face/module/list_spec.rb +12 -2
  255. data/spec/unit/face/module/search_spec.rb +9 -11
  256. data/spec/unit/face/module/uninstall_spec.rb +8 -4
  257. data/spec/unit/face/node_spec.rb +24 -23
  258. data/spec/unit/face/parser_spec.rb +18 -3
  259. data/spec/unit/face/plugin_spec.rb +9 -36
  260. data/spec/unit/face/status_spec.rb +1 -0
  261. data/spec/unit/file_bucket/dipper_spec.rb +20 -24
  262. data/spec/unit/file_bucket/file_spec.rb +2 -0
  263. data/spec/unit/file_serving/base_spec.rb +15 -14
  264. data/spec/unit/file_serving/configuration/parser_spec.rb +28 -27
  265. data/spec/unit/file_serving/configuration_spec.rb +66 -63
  266. data/spec/unit/file_serving/content_spec.rb +11 -10
  267. data/spec/unit/file_serving/fileset_spec.rb +58 -63
  268. data/spec/unit/file_serving/http_metadata_spec.rb +7 -8
  269. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  270. data/spec/unit/file_serving/mount/file_spec.rb +32 -31
  271. data/spec/unit/file_serving/mount/locales_spec.rb +24 -23
  272. data/spec/unit/file_serving/mount/modules_spec.rb +15 -14
  273. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +24 -23
  274. data/spec/unit/file_serving/mount/plugins_spec.rb +24 -23
  275. data/spec/unit/file_serving/mount/tasks_spec.rb +15 -14
  276. data/spec/unit/file_serving/mount_spec.rb +1 -0
  277. data/spec/unit/file_serving/terminus_helper_spec.rb +42 -37
  278. data/spec/unit/file_serving/terminus_selector_spec.rb +13 -12
  279. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  280. data/spec/unit/file_system_spec.rb +2 -2
  281. data/spec/unit/forge/errors_spec.rb +1 -1
  282. data/spec/unit/forge/forge_spec.rb +16 -17
  283. data/spec/unit/forge/module_release_spec.rb +18 -18
  284. data/spec/unit/forge/repository_spec.rb +30 -29
  285. data/spec/unit/forge_spec.rb +11 -15
  286. data/spec/unit/functions/binary_file_spec.rb +3 -3
  287. data/spec/unit/functions/contain_spec.rb +2 -0
  288. data/spec/unit/functions/defined_spec.rb +1 -0
  289. data/spec/unit/functions/epp_spec.rb +2 -2
  290. data/spec/unit/functions/find_file_spec.rb +7 -7
  291. data/spec/unit/functions/include_spec.rb +4 -0
  292. data/spec/unit/functions/lookup_fixture_spec.rb +1 -0
  293. data/spec/unit/functions/lookup_spec.rb +2 -1
  294. data/spec/unit/functions/module_directory_spec.rb +12 -12
  295. data/spec/unit/functions/new_spec.rb +0 -15
  296. data/spec/unit/functions/require_spec.rb +3 -0
  297. data/spec/unit/functions/shared.rb +8 -5
  298. data/spec/unit/functions/versioncmp_spec.rb +2 -1
  299. data/spec/unit/functions4_spec.rb +10 -9
  300. data/spec/unit/gettext/config_spec.rb +4 -4
  301. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  302. data/spec/unit/graph/rb_tree_map_spec.rb +2 -0
  303. data/spec/unit/graph/relationship_graph_spec.rb +2 -1
  304. data/spec/unit/graph/simple_graph_spec.rb +10 -9
  305. data/spec/unit/hiera/scope_spec.rb +0 -7
  306. data/spec/unit/hiera_puppet_spec.rb +20 -20
  307. data/spec/unit/indirector/catalog/compiler_spec.rb +149 -147
  308. data/spec/unit/indirector/catalog/json_spec.rb +2 -1
  309. data/spec/unit/indirector/catalog/msgpack_spec.rb +1 -0
  310. data/spec/unit/indirector/catalog/rest_spec.rb +1 -0
  311. data/spec/unit/indirector/catalog/store_configs_spec.rb +1 -0
  312. data/spec/unit/indirector/catalog/yaml_spec.rb +1 -0
  313. data/spec/unit/indirector/certificate/file_spec.rb +1 -0
  314. data/spec/unit/indirector/certificate/rest_spec.rb +10 -8
  315. data/spec/unit/indirector/certificate_request/file_spec.rb +1 -0
  316. data/spec/unit/indirector/certificate_request/rest_spec.rb +1 -0
  317. data/spec/unit/indirector/direct_file_server_spec.rb +18 -17
  318. data/spec/unit/indirector/envelope_spec.rb +2 -1
  319. data/spec/unit/indirector/exec_spec.rb +5 -4
  320. data/spec/unit/indirector/face_spec.rb +9 -9
  321. data/spec/unit/indirector/facts/facter_spec.rb +43 -37
  322. data/spec/unit/indirector/facts/network_device_spec.rb +9 -8
  323. data/spec/unit/indirector/facts/rest_spec.rb +8 -7
  324. data/spec/unit/indirector/facts/store_configs_spec.rb +1 -0
  325. data/spec/unit/indirector/facts/yaml_spec.rb +1 -0
  326. data/spec/unit/indirector/file_bucket_file/file_spec.rb +4 -3
  327. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +1 -0
  328. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +5 -4
  329. data/spec/unit/indirector/file_content/file_server_spec.rb +1 -0
  330. data/spec/unit/indirector/file_content/file_spec.rb +1 -0
  331. data/spec/unit/indirector/file_content/rest_spec.rb +1 -0
  332. data/spec/unit/indirector/file_content/selector_spec.rb +1 -0
  333. data/spec/unit/indirector/file_metadata/file_server_spec.rb +1 -0
  334. data/spec/unit/indirector/file_metadata/file_spec.rb +13 -12
  335. data/spec/unit/indirector/file_metadata/rest_spec.rb +1 -0
  336. data/spec/unit/indirector/file_metadata/selector_spec.rb +1 -0
  337. data/spec/unit/indirector/file_server_spec.rb +87 -87
  338. data/spec/unit/indirector/indirection_spec.rb +226 -242
  339. data/spec/unit/indirector/json_spec.rb +9 -7
  340. data/spec/unit/indirector/key/file_spec.rb +22 -21
  341. data/spec/unit/indirector/memory_spec.rb +7 -6
  342. data/spec/unit/indirector/msgpack_spec.rb +9 -7
  343. data/spec/unit/indirector/node/exec_spec.rb +3 -2
  344. data/spec/unit/indirector/node/memory_spec.rb +4 -2
  345. data/spec/unit/indirector/node/msgpack_spec.rb +1 -0
  346. data/spec/unit/indirector/node/plain_spec.rb +4 -2
  347. data/spec/unit/indirector/node/rest_spec.rb +1 -0
  348. data/spec/unit/indirector/node/store_configs_spec.rb +1 -0
  349. data/spec/unit/indirector/node/yaml_spec.rb +1 -0
  350. data/spec/unit/indirector/none_spec.rb +5 -5
  351. data/spec/unit/indirector/plain_spec.rb +8 -7
  352. data/spec/unit/indirector/report/msgpack_spec.rb +1 -0
  353. data/spec/unit/indirector/report/processor_spec.rb +22 -21
  354. data/spec/unit/indirector/report/rest_spec.rb +12 -11
  355. data/spec/unit/indirector/report/yaml_spec.rb +1 -0
  356. data/spec/unit/indirector/request_spec.rb +12 -11
  357. data/spec/unit/indirector/resource/ral_spec.rb +54 -47
  358. data/spec/unit/indirector/resource/store_configs_spec.rb +1 -0
  359. data/spec/unit/indirector/rest_spec.rb +110 -113
  360. data/spec/unit/indirector/ssl_file_spec.rb +65 -64
  361. data/spec/unit/indirector/status/local_spec.rb +1 -0
  362. data/spec/unit/indirector/status/rest_spec.rb +1 -0
  363. data/spec/unit/indirector/store_configs_spec.rb +1 -0
  364. data/spec/unit/indirector/terminus_spec.rb +27 -27
  365. data/spec/unit/indirector/yaml_spec.rb +6 -5
  366. data/spec/unit/indirector_spec.rb +2 -1
  367. data/spec/unit/info_service_spec.rb +1 -1
  368. data/spec/unit/interface/action_builder_spec.rb +1 -0
  369. data/spec/unit/interface/action_manager_spec.rb +1 -0
  370. data/spec/unit/interface/action_spec.rb +3 -2
  371. data/spec/unit/interface/documentation_spec.rb +1 -0
  372. data/spec/unit/interface/face_collection_spec.rb +12 -19
  373. data/spec/unit/interface_spec.rb +3 -3
  374. data/spec/unit/man_spec.rb +4 -3
  375. data/spec/unit/module_spec.rb +51 -46
  376. data/spec/unit/module_tool/applications/installer_spec.rb +11 -10
  377. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  378. data/spec/unit/module_tool/applications/uninstaller_spec.rb +2 -1
  379. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  380. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  381. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  382. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  383. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  384. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  385. data/spec/unit/module_tool/tar_spec.rb +13 -12
  386. data/spec/unit/module_tool_spec.rb +12 -7
  387. data/spec/unit/network/auth_config_parser_spec.rb +13 -11
  388. data/spec/unit/network/authconfig_spec.rb +18 -17
  389. data/spec/unit/network/authorization_spec.rb +5 -4
  390. data/spec/unit/network/authstore_spec.rb +1 -0
  391. data/spec/unit/network/format_handler_spec.rb +1 -0
  392. data/spec/unit/network/format_spec.rb +10 -9
  393. data/spec/unit/network/format_support_spec.rb +29 -28
  394. data/spec/unit/network/formats_spec.rb +5 -4
  395. data/spec/unit/network/http/api/indirected_routes_spec.rb +29 -24
  396. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  397. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  398. data/spec/unit/network/http/api/master/v3/environments_spec.rb +7 -6
  399. data/spec/unit/network/http/api_spec.rb +2 -0
  400. data/spec/unit/network/http/compression_spec.rb +22 -21
  401. data/spec/unit/network/http/connection_spec.rb +121 -30
  402. data/spec/unit/network/http/factory_spec.rb +6 -11
  403. data/spec/unit/network/http/handler_spec.rb +18 -9
  404. data/spec/unit/network/http/nocache_pool_spec.rb +7 -6
  405. data/spec/unit/network/http/pool_spec.rb +29 -28
  406. data/spec/unit/network/http/request_spec.rb +2 -0
  407. data/spec/unit/network/http/response_spec.rb +13 -11
  408. data/spec/unit/network/http/route_spec.rb +1 -0
  409. data/spec/unit/network/http/session_spec.rb +2 -1
  410. data/spec/unit/network/http/site_spec.rb +1 -0
  411. data/spec/unit/network/http_pool_spec.rb +9 -18
  412. data/spec/unit/network/http_spec.rb +1 -0
  413. data/spec/unit/network/resolver_spec.rb +26 -25
  414. data/spec/unit/network/rights_spec.rb +53 -52
  415. data/spec/unit/node/environment_spec.rb +15 -14
  416. data/spec/unit/node/facts_spec.rb +7 -5
  417. data/spec/unit/node_spec.rb +10 -4
  418. data/spec/unit/other/selinux_spec.rb +1 -0
  419. data/spec/unit/parameter/boolean_spec.rb +2 -1
  420. data/spec/unit/parameter/package_options_spec.rb +2 -1
  421. data/spec/unit/parameter/path_spec.rb +1 -0
  422. data/spec/unit/parameter/value_collection_spec.rb +1 -0
  423. data/spec/unit/parameter/value_spec.rb +1 -0
  424. data/spec/unit/parameter_spec.rb +9 -9
  425. data/spec/unit/parser/ast/block_expression_spec.rb +8 -6
  426. data/spec/unit/parser/ast/leaf_spec.rb +21 -20
  427. data/spec/unit/parser/compiler_spec.rb +96 -84
  428. data/spec/unit/parser/environment_compiler_spec.rb +8 -7
  429. data/spec/unit/parser/files_spec.rb +1 -0
  430. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  431. data/spec/unit/parser/functions/digest_spec.rb +1 -0
  432. data/spec/unit/parser/functions/fail_spec.rb +2 -1
  433. data/spec/unit/parser/functions/file_spec.rb +14 -13
  434. data/spec/unit/parser/functions/fqdn_rand_spec.rb +6 -5
  435. data/spec/unit/parser/functions/generate_spec.rb +8 -7
  436. data/spec/unit/parser/functions/inline_template_spec.rb +1 -0
  437. data/spec/unit/parser/functions/regsubst_spec.rb +1 -0
  438. data/spec/unit/parser/functions/scanf_spec.rb +1 -0
  439. data/spec/unit/parser/functions/shellquote_spec.rb +1 -0
  440. data/spec/unit/parser/functions/split_spec.rb +1 -0
  441. data/spec/unit/parser/functions/sprintf_spec.rb +1 -0
  442. data/spec/unit/parser/functions/tag_spec.rb +2 -1
  443. data/spec/unit/parser/functions/tagged_spec.rb +3 -2
  444. data/spec/unit/parser/functions/template_spec.rb +13 -13
  445. data/spec/unit/parser/functions/versioncmp_spec.rb +2 -1
  446. data/spec/unit/parser/functions_spec.rb +7 -6
  447. data/spec/unit/parser/relationship_spec.rb +1 -0
  448. data/spec/unit/parser/resource_spec.rb +42 -42
  449. data/spec/unit/parser/scope_spec.rb +35 -39
  450. data/spec/unit/parser/templatewrapper_spec.rb +12 -11
  451. data/spec/unit/parser/type_loader_spec.rb +19 -17
  452. data/spec/unit/pops/adaptable_spec.rb +1 -0
  453. data/spec/unit/pops/benchmark_spec.rb +1 -0
  454. data/spec/unit/pops/evaluator/access_ops_spec.rb +1 -0
  455. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +1 -0
  456. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +1 -0
  457. data/spec/unit/pops/evaluator/collections_ops_spec.rb +1 -0
  458. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +1 -0
  459. data/spec/unit/pops/evaluator/conditionals_spec.rb +1 -0
  460. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +47 -10
  461. data/spec/unit/pops/evaluator/logical_ops_spec.rb +1 -0
  462. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +1 -0
  463. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +1 -0
  464. data/spec/unit/pops/evaluator/variables_spec.rb +1 -0
  465. data/spec/unit/pops/factory_spec.rb +4 -3
  466. data/spec/unit/pops/issues_spec.rb +20 -19
  467. data/spec/unit/pops/loaders/loader_spec.rb +4 -8
  468. data/spec/unit/pops/loaders/loaders_spec.rb +31 -101
  469. data/spec/unit/pops/lookup/context_spec.rb +1 -0
  470. data/spec/unit/pops/lookup/interpolation_spec.rb +3 -2
  471. data/spec/unit/pops/merge_strategy_spec.rb +1 -0
  472. data/spec/unit/pops/migration_spec.rb +5 -3
  473. data/spec/unit/pops/model/model_spec.rb +1 -0
  474. data/spec/unit/pops/model/pn_transformer_spec.rb +1 -4
  475. data/spec/unit/pops/parser/locator_spec.rb +6 -48
  476. data/spec/unit/pops/parser/parse_application_spec.rb +1 -0
  477. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +1 -0
  478. data/spec/unit/pops/parser/parse_calls_spec.rb +1 -0
  479. data/spec/unit/pops/parser/parse_capabilities_spec.rb +1 -0
  480. data/spec/unit/pops/parser/parse_conditionals_spec.rb +1 -0
  481. data/spec/unit/pops/parser/parse_containers_spec.rb +1 -0
  482. data/spec/unit/pops/parser/parse_heredoc_spec.rb +15 -111
  483. data/spec/unit/pops/parser/parse_plan_spec.rb +1 -0
  484. data/spec/unit/pops/parser/parse_resource_spec.rb +1 -0
  485. data/spec/unit/pops/parser/parse_site_spec.rb +1 -0
  486. data/spec/unit/pops/parser/pn_parser_spec.rb +1 -0
  487. data/spec/unit/pops/pn_spec.rb +1 -0
  488. data/spec/unit/pops/resource/resource_type_impl_spec.rb +1 -0
  489. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  490. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  491. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  492. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  493. data/spec/unit/pops/types/string_converter_spec.rb +5 -1
  494. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  495. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  496. data/spec/unit/pops/types/type_mismatch_describer_spec.rb +0 -9
  497. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  498. data/spec/unit/pops/validator/validator_spec.rb +2 -1
  499. data/spec/unit/pops/visitor_spec.rb +1 -0
  500. data/spec/unit/property/boolean_spec.rb +1 -1
  501. data/spec/unit/property/ensure_spec.rb +1 -0
  502. data/spec/unit/property/keyvalue_spec.rb +34 -32
  503. data/spec/unit/property/list_spec.rb +27 -26
  504. data/spec/unit/property/ordered_list_spec.rb +14 -10
  505. data/spec/unit/property_spec.rb +43 -42
  506. data/spec/unit/provider/aix_object_spec.rb +45 -47
  507. data/spec/unit/provider/command_spec.rb +9 -9
  508. data/spec/unit/provider/exec/posix_spec.rb +31 -6
  509. data/spec/unit/provider/exec/shell_spec.rb +1 -0
  510. data/spec/unit/provider/exec/windows_spec.rb +4 -2
  511. data/spec/unit/provider/exec_spec.rb +1 -0
  512. data/spec/unit/provider/file/posix_spec.rb +24 -22
  513. data/spec/unit/provider/file/windows_spec.rb +17 -15
  514. data/spec/unit/provider/group/aix_spec.rb +2 -3
  515. data/spec/unit/provider/group/groupadd_spec.rb +26 -30
  516. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  517. data/spec/unit/provider/group/pw_spec.rb +11 -11
  518. data/spec/unit/provider/group/windows_adsi_spec.rb +53 -59
  519. data/spec/unit/provider/ldap_spec.rb +62 -61
  520. data/spec/unit/provider/nameservice/directoryservice_spec.rb +36 -35
  521. data/spec/unit/provider/nameservice_spec.rb +40 -38
  522. data/spec/unit/provider/package/aix_spec.rb +15 -15
  523. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  524. data/spec/unit/provider/package/apt_spec.rb +27 -44
  525. data/spec/unit/provider/package/aptitude_spec.rb +7 -6
  526. data/spec/unit/provider/package/aptrpm_spec.rb +12 -7
  527. data/spec/unit/provider/package/base_spec.rb +4 -4
  528. data/spec/unit/provider/package/dnf_spec.rb +20 -18
  529. data/spec/unit/provider/package/dpkg_spec.rb +53 -70
  530. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  531. data/spec/unit/provider/package/gem_spec.rb +55 -132
  532. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  533. data/spec/unit/provider/package/macports_spec.rb +42 -46
  534. data/spec/unit/provider/package/nim_spec.rb +39 -30
  535. data/spec/unit/provider/package/openbsd_spec.rb +39 -36
  536. data/spec/unit/provider/package/opkg_spec.rb +26 -23
  537. data/spec/unit/provider/package/pacman_spec.rb +118 -97
  538. data/spec/unit/provider/package/pip3_spec.rb +0 -17
  539. data/spec/unit/provider/package/pip_spec.rb +106 -95
  540. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  541. data/spec/unit/provider/package/pkgdmg_spec.rb +63 -65
  542. data/spec/unit/provider/package/pkgin_spec.rb +8 -10
  543. data/spec/unit/provider/package/pkgng_spec.rb +31 -22
  544. data/spec/unit/provider/package/pkgutil_spec.rb +49 -45
  545. data/spec/unit/provider/package/portage_spec.rb +74 -70
  546. data/spec/unit/provider/package/puppet_gem_spec.rb +13 -37
  547. data/spec/unit/provider/package/rpm_spec.rb +76 -154
  548. data/spec/unit/provider/package/sun_spec.rb +18 -16
  549. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  550. data/spec/unit/provider/package/up2date_spec.rb +4 -2
  551. data/spec/unit/provider/package/urpmi_spec.rb +17 -15
  552. data/spec/unit/provider/package/windows/exe_package_spec.rb +15 -12
  553. data/spec/unit/provider/package/windows/msi_package_spec.rb +22 -19
  554. data/spec/unit/provider/package/windows/package_spec.rb +42 -37
  555. data/spec/unit/provider/package/windows_spec.rb +32 -47
  556. data/spec/unit/provider/package/yum_spec.rb +7 -7
  557. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  558. data/spec/unit/provider/parsedfile_spec.rb +45 -44
  559. data/spec/unit/provider/service/base_spec.rb +5 -4
  560. data/spec/unit/provider/service/bsd_spec.rb +29 -27
  561. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  562. data/spec/unit/provider/service/debian_spec.rb +38 -38
  563. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  564. data/spec/unit/provider/service/gentoo_spec.rb +55 -50
  565. data/spec/unit/provider/service/init_spec.rb +52 -53
  566. data/spec/unit/provider/service/launchd_spec.rb +116 -138
  567. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  568. data/spec/unit/provider/service/openrc_spec.rb +45 -43
  569. data/spec/unit/provider/service/openwrt_spec.rb +31 -26
  570. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  571. data/spec/unit/provider/service/redhat_spec.rb +43 -45
  572. data/spec/unit/provider/service/runit_spec.rb +27 -29
  573. data/spec/unit/provider/service/smf_spec.rb +66 -74
  574. data/spec/unit/provider/service/src_spec.rb +47 -46
  575. data/spec/unit/provider/service/systemd_spec.rb +136 -109
  576. data/spec/unit/provider/service/upstart_spec.rb +93 -77
  577. data/spec/unit/provider/service/windows_spec.rb +41 -33
  578. data/spec/unit/provider/user/aix_spec.rb +31 -31
  579. data/spec/unit/provider/user/directoryservice_spec.rb +114 -146
  580. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  581. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  582. data/spec/unit/provider/user/openbsd_spec.rb +12 -10
  583. data/spec/unit/provider/user/pw_spec.rb +35 -37
  584. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  585. data/spec/unit/provider/user/useradd_spec.rb +92 -93
  586. data/spec/unit/provider/user/windows_adsi_spec.rb +60 -59
  587. data/spec/unit/provider_spec.rb +35 -35
  588. data/spec/unit/puppet_pal_2pec.rb +5 -4
  589. data/spec/unit/puppet_pal_spec.rb +1 -0
  590. data/spec/unit/puppet_spec.rb +7 -6
  591. data/spec/unit/relationship_spec.rb +1 -0
  592. data/spec/unit/reports/http_spec.rb +23 -21
  593. data/spec/unit/reports/store_spec.rb +4 -3
  594. data/spec/unit/reports_spec.rb +14 -12
  595. data/spec/unit/resource/capability_finder_spec.rb +17 -15
  596. data/spec/unit/resource/catalog_spec.rb +68 -72
  597. data/spec/unit/resource/status_spec.rb +8 -6
  598. data/spec/unit/resource/type_collection_spec.rb +18 -17
  599. data/spec/unit/resource/type_spec.rb +35 -34
  600. data/spec/unit/resource_spec.rb +63 -36
  601. data/spec/unit/rest/client_spec.rb +135 -0
  602. data/spec/unit/rest/route_spec.rb +6 -6
  603. data/spec/unit/scheduler/job_spec.rb +1 -0
  604. data/spec/unit/scheduler/scheduler_spec.rb +1 -0
  605. data/spec/unit/scheduler/splay_job_spec.rb +2 -1
  606. data/spec/unit/settings/array_setting_spec.rb +1 -1
  607. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  608. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  609. data/spec/unit/settings/config_file_spec.rb +1 -0
  610. data/spec/unit/settings/directory_setting_spec.rb +7 -2
  611. data/spec/unit/settings/duration_setting_spec.rb +2 -1
  612. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  613. data/spec/unit/settings/environment_conf_spec.rb +6 -4
  614. data/spec/unit/settings/file_setting_spec.rb +46 -44
  615. data/spec/unit/settings/path_setting_spec.rb +2 -1
  616. data/spec/unit/settings/priority_setting_spec.rb +2 -1
  617. data/spec/unit/settings/string_setting_spec.rb +15 -14
  618. data/spec/unit/settings/terminus_setting_spec.rb +2 -1
  619. data/spec/unit/settings/value_translator_spec.rb +1 -0
  620. data/spec/unit/settings_spec.rb +224 -253
  621. data/spec/unit/ssl/base_spec.rb +15 -14
  622. data/spec/unit/ssl/certificate_request_spec.rb +58 -62
  623. data/spec/unit/ssl/certificate_spec.rb +25 -23
  624. data/spec/unit/ssl/digest_spec.rb +1 -0
  625. data/spec/unit/ssl/host_spec.rb +149 -166
  626. data/spec/unit/ssl/key_spec.rb +31 -30
  627. data/spec/unit/ssl/validator_spec.rb +39 -40
  628. data/spec/unit/task_spec.rb +45 -44
  629. data/spec/unit/transaction/additional_resource_generator_spec.rb +5 -3
  630. data/spec/unit/transaction/event_manager_spec.rb +88 -87
  631. data/spec/unit/transaction/event_spec.rb +15 -16
  632. data/spec/unit/transaction/persistence_spec.rb +17 -16
  633. data/spec/unit/transaction/report_spec.rb +12 -11
  634. data/spec/unit/transaction/resource_harness_spec.rb +31 -52
  635. data/spec/unit/transaction_spec.rb +87 -140
  636. data/spec/unit/type/component_spec.rb +1 -0
  637. data/spec/unit/type/exec_spec.rb +50 -101
  638. data/spec/unit/type/file/checksum_spec.rb +10 -9
  639. data/spec/unit/type/file/checksum_value_spec.rb +32 -31
  640. data/spec/unit/type/file/content_spec.rb +61 -58
  641. data/spec/unit/type/file/ctime_spec.rb +1 -0
  642. data/spec/unit/type/file/ensure_spec.rb +13 -12
  643. data/spec/unit/type/file/group_spec.rb +7 -5
  644. data/spec/unit/type/file/mode_spec.rb +6 -4
  645. data/spec/unit/type/file/mtime_spec.rb +1 -0
  646. data/spec/unit/type/file/owner_spec.rb +8 -6
  647. data/spec/unit/type/file/selinux_spec.rb +19 -17
  648. data/spec/unit/type/file/source_spec.rb +101 -104
  649. data/spec/unit/type/file/type_spec.rb +1 -0
  650. data/spec/unit/type/file_spec.rb +185 -195
  651. data/spec/unit/type/filebucket_spec.rb +10 -11
  652. data/spec/unit/type/group_spec.rb +8 -6
  653. data/spec/unit/type/noop_metaparam_spec.rb +2 -1
  654. data/spec/unit/type/package/package_settings_spec.rb +23 -44
  655. data/spec/unit/type/package_spec.rb +57 -56
  656. data/spec/unit/type/resources_spec.rb +74 -72
  657. data/spec/unit/type/schedule_spec.rb +26 -24
  658. data/spec/unit/type/service_spec.rb +75 -49
  659. data/spec/unit/type/stage_spec.rb +1 -0
  660. data/spec/unit/type/tidy_spec.rb +62 -61
  661. data/spec/unit/type/user_spec.rb +25 -24
  662. data/spec/unit/type/whit_spec.rb +1 -0
  663. data/spec/unit/type_spec.rb +54 -55
  664. data/spec/unit/util/at_fork_spec.rb +19 -18
  665. data/spec/unit/util/autoload_spec.rb +56 -55
  666. data/spec/unit/util/backups_spec.rb +35 -34
  667. data/spec/unit/util/character_encoding_spec.rb +5 -5
  668. data/spec/unit/util/checksums_spec.rb +39 -38
  669. data/spec/unit/util/colors_spec.rb +2 -1
  670. data/spec/unit/util/command_line_spec.rb +20 -40
  671. data/spec/unit/util/constant_inflector_spec.rb +1 -0
  672. data/spec/unit/util/diff_spec.rb +8 -7
  673. data/spec/unit/util/errors_spec.rb +1 -0
  674. data/spec/unit/util/execution_spec.rb +163 -187
  675. data/spec/unit/util/execution_stub_spec.rb +1 -0
  676. data/spec/unit/util/feature_spec.rb +14 -21
  677. data/spec/unit/util/filetype_spec.rb +49 -49
  678. data/spec/unit/util/http_proxy_spec.rb +12 -12
  679. data/spec/unit/util/inifile_spec.rb +31 -26
  680. data/spec/unit/util/json_lockfile_spec.rb +5 -3
  681. data/spec/unit/util/ldap/connection_spec.rb +25 -26
  682. data/spec/unit/util/ldap/generator_spec.rb +1 -0
  683. data/spec/unit/util/ldap/manager_spec.rb +101 -102
  684. data/spec/unit/util/lockfile_spec.rb +1 -0
  685. data/spec/unit/util/log/destinations_spec.rb +33 -30
  686. data/spec/unit/util/log_spec.rb +34 -48
  687. data/spec/unit/util/logging_spec.rb +72 -58
  688. data/spec/unit/util/metric_spec.rb +1 -0
  689. data/spec/unit/util/monkey_patches_spec.rb +9 -7
  690. data/spec/unit/util/multi_match_spec.rb +1 -0
  691. data/spec/unit/util/network_device/config_spec.rb +1 -0
  692. data/spec/unit/util/network_device/transport/base_spec.rb +6 -5
  693. data/spec/unit/util/network_device_spec.rb +9 -7
  694. data/spec/unit/util/package_spec.rb +1 -0
  695. data/spec/unit/util/pidlock_spec.rb +15 -60
  696. data/spec/unit/util/plist_spec.rb +33 -40
  697. data/spec/unit/util/posix_spec.rb +51 -54
  698. data/spec/unit/util/rdoc_spec.rb +10 -9
  699. data/spec/unit/util/reference_spec.rb +1 -0
  700. data/spec/unit/util/resource_template_spec.rb +20 -20
  701. data/spec/unit/util/retry_action_spec.rb +8 -7
  702. data/spec/unit/util/rubygems_spec.rb +8 -7
  703. data/spec/unit/util/run_mode_spec.rb +4 -3
  704. data/spec/unit/util/selinux_spec.rb +72 -79
  705. data/spec/unit/util/splayer_spec.rb +9 -8
  706. data/spec/unit/util/ssl_spec.rb +1 -0
  707. data/spec/unit/util/storage_spec.rb +23 -22
  708. data/spec/unit/util/suidmanager_spec.rb +54 -45
  709. data/spec/unit/util/symbolic_file_mode_spec.rb +1 -0
  710. data/spec/unit/util/tag_set_spec.rb +1 -0
  711. data/spec/unit/util/tagging_spec.rb +1 -0
  712. data/spec/unit/util/terminal_spec.rb +10 -9
  713. data/spec/unit/util/user_attr_spec.rb +2 -1
  714. data/spec/unit/util/warnings_spec.rb +4 -3
  715. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  716. data/spec/unit/util/watcher_spec.rb +21 -51
  717. data/spec/unit/util/windows/access_control_entry_spec.rb +1 -0
  718. data/spec/unit/util/windows/access_control_list_spec.rb +1 -0
  719. data/spec/unit/util/windows/adsi_spec.rb +138 -136
  720. data/spec/unit/util/windows/api_types_spec.rb +1 -0
  721. data/spec/unit/util/windows/eventlog_spec.rb +12 -9
  722. data/spec/unit/util/windows/file_spec.rb +1 -0
  723. data/spec/unit/util/windows/root_certs_spec.rb +1 -0
  724. data/spec/unit/util/windows/security_descriptor_spec.rb +2 -0
  725. data/spec/unit/util/windows/service_spec.rb +103 -100
  726. data/spec/unit/util/windows/sid_spec.rb +13 -11
  727. data/spec/unit/util/windows/string_spec.rb +1 -0
  728. data/spec/unit/util_spec.rb +57 -55
  729. data/spec/unit/version_spec.rb +6 -6
  730. metadata +20 -32
  731. data/CODEOWNERS +0 -30
  732. data/ext/autotest/Rakefile +0 -8
  733. data/ext/autotest/config +0 -43
  734. data/ext/autotest/readme.rst +0 -16
  735. data/lib/puppet/confine/boolean.rb +0 -45
  736. data/lib/puppet/provider/package_targetable.rb +0 -68
  737. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load2.rb +0 -11
  738. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load3.rb +0 -11
  739. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load4.rb +0 -11
  740. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load5.rb +0 -12
  741. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/good_func_load.rb +0 -9
  742. data/spec/fixtures/unit/provider/package/pkgng/pkg.info +0 -7
  743. data/spec/fixtures/unit/provider/package/pkgng/pkg.query_absent +0 -1
  744. data/spec/integration/network/http_pool_spec.rb +0 -120
  745. data/spec/integration/provider/file/windows_spec.rb +0 -162
  746. data/spec/lib/puppet_spec/https.rb +0 -166
  747. data/spec/unit/settings/server_list_setting_spec.rb +0 -21
  748. data/spec/watchr.rb +0 -137
@@ -1,3 +1,4 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  describe 'Puppet::Util::AtFork' do
@@ -18,7 +19,7 @@ describe 'Puppet::Util::AtFork' do
18
19
  describe '.get_handler' do
19
20
  context 'when on Solaris' do
20
21
  before :each do
21
- expect(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
22
+ Facter.expects(:value).with(:operatingsystem).returns('Solaris')
22
23
  end
23
24
 
24
25
  after :each do
@@ -28,7 +29,7 @@ describe 'Puppet::Util::AtFork' do
28
29
  end
29
30
 
30
31
  def stub_solaris_handler(stub_noop_too = false)
31
- allow(Puppet::Util::AtFork).to receive(:require).with(anything) do |lib|
32
+ Puppet::Util::AtFork.stubs(:require).with() do |lib|
32
33
  if lib == 'puppet/util/at_fork/solaris'
33
34
  load lib + '.rb'
34
35
  true
@@ -40,7 +41,7 @@ describe 'Puppet::Util::AtFork' do
40
41
  else
41
42
  false
42
43
  end
43
- end.and_return(true)
44
+ end.returns(true)
44
45
 
45
46
  unless stub_noop_too
46
47
  Object.class_exec do
@@ -55,18 +56,18 @@ describe 'Puppet::Util::AtFork' do
55
56
  end
56
57
  end
57
58
 
58
- allow(TOPLEVEL_BINDING.eval('self')).to receive(:require).with(anything) do |lib|
59
+ TOPLEVEL_BINDING.eval('self').stubs(:require).with() do |lib|
59
60
  if lib == 'fiddle'
60
61
  raise LoadError, 'no fiddle' if stub_noop_too
61
62
  else
62
63
  Kernel.require lib
63
64
  end
64
65
  true
65
- end.and_return(true)
66
+ end.returns(true)
66
67
  end
67
68
 
68
69
  it %q(should return the Solaris specific AtFork handler) do
69
- allow(Puppet::Util::AtFork).to receive(:require).with(anything) do |lib|
70
+ Puppet::Util::AtFork.stubs(:require).with() do |lib|
70
71
  if lib == 'puppet/util/at_fork/solaris'
71
72
  Puppet::Util::AtFork.class_exec do
72
73
  const_set(:Solaris, Class.new)
@@ -75,7 +76,7 @@ describe 'Puppet::Util::AtFork' do
75
76
  else
76
77
  false
77
78
  end
78
- end.and_return(true)
79
+ end.returns(true)
79
80
  load 'puppet/util/at_fork.rb'
80
81
  expect(Puppet::Util::AtFork.get_handler.class).to eq(Puppet::Util::AtFork::Solaris)
81
82
  end
@@ -88,24 +89,24 @@ describe 'Puppet::Util::AtFork' do
88
89
 
89
90
  it %q(should fail when libcontract cannot be loaded) do
90
91
  stub_solaris_handler
91
- expect(Fiddle::Handle).to receive(:new).with(/^libcontract.so.*/).and_raise(Fiddle::DLError, 'no such library')
92
+ Fiddle::Handle.expects(:new).with(regexp_matches(/^libcontract.so.*/)).raises(Fiddle::DLError, 'no such library')
92
93
  expect { load 'puppet/util/at_fork.rb' }.to raise_error(Fiddle::DLError, 'no such library')
93
94
  end
94
95
 
95
96
  it %q(should fail when libcontract doesn't define all the necessary functions) do
96
97
  stub_solaris_handler
97
- handle = double('Fiddle::Handle')
98
- expect(Fiddle::Handle).to receive(:new).with(/^libcontract.so.*/).and_return(handle)
99
- expect(handle).to receive(:[]).and_raise(Fiddle::DLError, 'no such method')
98
+ handle = stub('Fiddle::Handle')
99
+ Fiddle::Handle.expects(:new).with(regexp_matches(/^libcontract.so.*/)).returns(handle)
100
+ handle.expects(:[]).raises(Fiddle::DLError, 'no such method')
100
101
  expect { load 'puppet/util/at_fork.rb' }.to raise_error(Fiddle::DLError, 'no such method')
101
102
  end
102
103
 
103
104
  it %q(the returned Solaris specific handler should respond to the expected methods) do
104
105
  stub_solaris_handler
105
- handle = double('Fiddle::Handle')
106
- expect(Fiddle::Handle).to receive(:new).with(/^libcontract.so.*/).and_return(handle)
107
- allow(handle).to receive(:[]).and_return(nil)
108
- allow(Fiddle::Function).to receive(:new).and_return(Proc.new {})
106
+ handle = stub('Fiddle::Handle')
107
+ Fiddle::Handle.expects(:new).with(regexp_matches(/^libcontract.so.*/)).returns(handle)
108
+ handle.stubs(:[]).returns(nil)
109
+ Fiddle::Function.stubs(:new).returns(Proc.new {})
109
110
  load 'puppet/util/at_fork.rb'
110
111
  expect(Puppet::Util::AtFork.get_handler.public_methods).to include(*EXPECTED_HANDLER_METHODS)
111
112
  end
@@ -113,11 +114,11 @@ describe 'Puppet::Util::AtFork' do
113
114
 
114
115
  context 'when NOT on Solaris' do
115
116
  before :each do
116
- expect(Facter).to receive(:value).with(:operatingsystem).and_return(nil)
117
+ Facter.expects(:value).with(:operatingsystem).returns(nil)
117
118
  end
118
119
 
119
120
  def stub_noop_handler(namespace_only = false)
120
- allow(Puppet::Util::AtFork).to receive(:require).with(anything) do |lib|
121
+ Puppet::Util::AtFork.stubs(:require).with() do |lib|
121
122
  if lib == 'puppet/util/at_fork/noop'
122
123
  if namespace_only
123
124
  Puppet::Util::AtFork.class_exec do
@@ -130,7 +131,7 @@ describe 'Puppet::Util::AtFork' do
130
131
  else
131
132
  false
132
133
  end
133
- end.and_return(true)
134
+ end.returns(true)
134
135
  end
135
136
 
136
137
  it %q(should return the Noop AtFork handler) do
@@ -1,3 +1,4 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
  require 'fileutils'
3
4
 
@@ -12,13 +13,13 @@ describe Puppet::Util::Autoload do
12
13
  @autoload = Puppet::Util::Autoload.new("foo", "tmp")
13
14
 
14
15
  @loaded = {}
15
- allow(@autoload.class).to receive(:loaded).and_return(@loaded)
16
+ @autoload.class.stubs(:loaded).returns(@loaded)
16
17
  end
17
18
 
18
19
  describe "when building the search path" do
19
20
  before :each do
20
21
  ## modulepath/libdir can't be used until after app settings are initialized, so we need to simulate that:
21
- allow(Puppet.settings).to receive(:app_defaults_initialized?).and_return(true)
22
+ Puppet.settings.stubs(:app_defaults_initialized?).returns(true)
22
23
  end
23
24
 
24
25
  def with_libdir(libdir)
@@ -85,8 +86,8 @@ describe Puppet::Util::Autoload do
85
86
  Puppet[:vendormoduledir] = vendor_dir
86
87
 
87
88
  with_libdir(libdir) do
88
- expect(@autoload.class).to receive(:gem_directories).and_return(%w{/one /two})
89
- expect(@autoload.class).to receive(:module_directories).and_return(%w{/three /four})
89
+ @autoload.class.expects(:gem_directories).returns %w{/one /two}
90
+ @autoload.class.expects(:module_directories).returns %w{/three /four}
90
91
  dirs = @autoload.class.search_directories(nil)
91
92
  expect(dirs[0..4]).to eq(%w{/one /two /three /four} + [libdir])
92
93
  expect(dirs.last).to eq(module_libdir)
@@ -96,8 +97,8 @@ describe Puppet::Util::Autoload do
96
97
  it "does not split the Puppet[:libdir]" do
97
98
  dir = File.expand_path("/libdir1#{File::PATH_SEPARATOR}/libdir2")
98
99
  with_libdir(dir) do
99
- expect(@autoload.class).to receive(:gem_directories).and_return(%w{/one /two})
100
- expect(@autoload.class).to receive(:module_directories).and_return(%w{/three /four})
100
+ @autoload.class.expects(:gem_directories).returns %w{/one /two}
101
+ @autoload.class.expects(:module_directories).returns %w{/three /four}
101
102
  dirs = @autoload.class.search_directories(nil)
102
103
  expect(dirs).to include(dir)
103
104
  end
@@ -106,10 +107,10 @@ describe Puppet::Util::Autoload do
106
107
 
107
108
  describe "when loading a file" do
108
109
  before do
109
- allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a")])
110
- allow(FileTest).to receive(:directory?).and_return(true)
110
+ @autoload.class.stubs(:search_directories).returns [make_absolute("/a")]
111
+ FileTest.stubs(:directory?).returns true
111
112
  @time_a = Time.utc(2010, 'jan', 1, 6, 30)
112
- allow(File).to receive(:mtime).and_return(@time_a)
113
+ File.stubs(:mtime).returns @time_a
113
114
  end
114
115
 
115
116
  after(:each) do
@@ -118,9 +119,9 @@ describe Puppet::Util::Autoload do
118
119
 
119
120
  [RuntimeError, LoadError, SyntaxError].each do |error|
120
121
  it "should die with Puppet::Error if a #{error.to_s} exception is thrown" do
121
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
122
+ Puppet::FileSystem.stubs(:exist?).returns true
122
123
 
123
- expect(Kernel).to receive(:load).and_raise(error)
124
+ Kernel.expects(:load).raises error
124
125
 
125
126
  expect { @autoload.load("foo", env) }.to raise_error(Puppet::Error)
126
127
  end
@@ -131,24 +132,24 @@ describe Puppet::Util::Autoload do
131
132
  end
132
133
 
133
134
  it "should register loaded files with the autoloader" do
134
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
135
- allow(Kernel).to receive(:load)
135
+ Puppet::FileSystem.stubs(:exist?).returns true
136
+ Kernel.stubs(:load)
136
137
  @autoload.load("myfile", env)
137
138
 
138
139
  expect(@autoload.class.loaded?("tmp/myfile.rb")).to be
139
140
  end
140
141
 
141
142
  it "should be seen by loaded? on the instance using the short name" do
142
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
143
- allow(Kernel).to receive(:load)
143
+ Puppet::FileSystem.stubs(:exist?).returns true
144
+ Kernel.stubs(:load)
144
145
  @autoload.load("myfile", env)
145
146
 
146
147
  expect(@autoload.loaded?("myfile.rb")).to be
147
148
  end
148
149
 
149
150
  it "should register loaded files with the main loaded file list so they are not reloaded by ruby" do
150
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
151
- allow(Kernel).to receive(:load)
151
+ Puppet::FileSystem.stubs(:exist?).returns true
152
+ Kernel.stubs(:load)
152
153
 
153
154
  @autoload.load("myfile", env)
154
155
 
@@ -156,17 +157,17 @@ describe Puppet::Util::Autoload do
156
157
  end
157
158
 
158
159
  it "should load the first file in the searchpath" do
159
- allow(@autoload).to receive(:search_directories).and_return([make_absolute("/a"), make_absolute("/b")])
160
- allow(FileTest).to receive(:directory?).and_return(true)
161
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
162
- expect(Kernel).to receive(:load).with(make_absolute("/a/tmp/myfile.rb"), any_args)
160
+ @autoload.stubs(:search_directories).returns [make_absolute("/a"), make_absolute("/b")]
161
+ FileTest.stubs(:directory?).returns true
162
+ Puppet::FileSystem.stubs(:exist?).returns true
163
+ Kernel.expects(:load).with(make_absolute("/a/tmp/myfile.rb"), optionally(anything))
163
164
 
164
165
  @autoload.load("myfile", env)
165
166
  end
166
167
 
167
168
  it "should treat equivalent paths to a loaded file as loaded" do
168
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
169
- allow(Kernel).to receive(:load)
169
+ Puppet::FileSystem.stubs(:exist?).returns true
170
+ Kernel.stubs(:load)
170
171
  @autoload.load("myfile", env)
171
172
 
172
173
  expect(@autoload.class.loaded?("tmp/myfile")).to be
@@ -178,26 +179,26 @@ describe Puppet::Util::Autoload do
178
179
 
179
180
  describe "when loading all files" do
180
181
  before do
181
- allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a")])
182
- allow(FileTest).to receive(:directory?).and_return(true)
183
- allow(Dir).to receive(:glob).and_return([make_absolute("/a/foo/file.rb")])
184
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
182
+ @autoload.class.stubs(:search_directories).returns [make_absolute("/a")]
183
+ FileTest.stubs(:directory?).returns true
184
+ Dir.stubs(:glob).returns [make_absolute("/a/foo/file.rb")]
185
+ Puppet::FileSystem.stubs(:exist?).returns true
185
186
  @time_a = Time.utc(2010, 'jan', 1, 6, 30)
186
- allow(File).to receive(:mtime).and_return(@time_a)
187
+ File.stubs(:mtime).returns @time_a
187
188
 
188
- allow(@autoload.class).to receive(:loaded?).and_return(false)
189
+ @autoload.class.stubs(:loaded?).returns(false)
189
190
  end
190
191
 
191
192
  [RuntimeError, LoadError, SyntaxError].each do |error|
192
193
  it "should die an if a #{error.to_s} exception is thrown" do
193
- expect(Kernel).to receive(:load).and_raise(error)
194
+ Kernel.expects(:load).raises error
194
195
 
195
196
  expect { @autoload.loadall(env) }.to raise_error(Puppet::Error)
196
197
  end
197
198
  end
198
199
 
199
200
  it "should require the full path to the file" do
200
- expect(Kernel).to receive(:load).with(make_absolute("/a/foo/file.rb"), any_args)
201
+ Kernel.expects(:load).with(make_absolute("/a/foo/file.rb"), optionally(anything))
201
202
 
202
203
  @autoload.loadall(env)
203
204
  end
@@ -221,14 +222,14 @@ describe Puppet::Util::Autoload do
221
222
  end
222
223
 
223
224
  it "changes should be seen by changed? on the instance using the short name" do
224
- allow(File).to receive(:mtime).and_return(@first_time)
225
- allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
226
- allow(Kernel).to receive(:load)
225
+ File.stubs(:mtime).returns(@first_time)
226
+ Puppet::FileSystem.stubs(:exist?).returns true
227
+ Kernel.stubs(:load)
227
228
  @autoload.load("myfile", env)
228
229
  expect(@autoload.loaded?("myfile")).to be
229
230
  expect(@autoload.changed?("myfile", env)).not_to be
230
231
 
231
- allow(File).to receive(:mtime).and_return(@second_time)
232
+ File.stubs(:mtime).returns(@second_time)
232
233
  expect(@autoload.changed?("myfile", env)).to be
233
234
 
234
235
  $LOADED_FEATURES.delete("tmp/myfile.rb")
@@ -236,51 +237,51 @@ describe Puppet::Util::Autoload do
236
237
 
237
238
  describe "in one directory" do
238
239
  before :each do
239
- allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a")])
240
- expect(File).to receive(:mtime).with(@file_a).and_return(@first_time)
240
+ @autoload.class.stubs(:search_directories).returns [make_absolute("/a")]
241
+ File.expects(:mtime).with(@file_a).returns(@first_time)
241
242
  @autoload.class.mark_loaded("file", @file_a)
242
243
  end
243
244
 
244
245
  it "should reload if mtime changes" do
245
- allow(File).to receive(:mtime).with(@file_a).and_return(@first_time + 60)
246
- allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(true)
247
- expect(Kernel).to receive(:load).with(@file_a, any_args)
246
+ File.stubs(:mtime).with(@file_a).returns(@first_time + 60)
247
+ Puppet::FileSystem.stubs(:exist?).with(@file_a).returns true
248
+ Kernel.expects(:load).with(@file_a, optionally(anything))
248
249
  @autoload.class.reload_changed(env)
249
250
  end
250
251
 
251
252
  it "should do nothing if the file is deleted" do
252
- allow(File).to receive(:mtime).with(@file_a).and_raise(Errno::ENOENT)
253
- allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(false)
254
- expect(Kernel).not_to receive(:load)
253
+ File.stubs(:mtime).with(@file_a).raises(Errno::ENOENT)
254
+ Puppet::FileSystem.stubs(:exist?).with(@file_a).returns false
255
+ Kernel.expects(:load).never
255
256
  @autoload.class.reload_changed(env)
256
257
  end
257
258
  end
258
259
 
259
260
  describe "in two directories" do
260
261
  before :each do
261
- allow(@autoload.class).to receive(:search_directories).and_return([make_absolute("/a"), make_absolute("/b")])
262
+ @autoload.class.stubs(:search_directories).returns [make_absolute("/a"), make_absolute("/b")]
262
263
  end
263
264
 
264
265
  it "should load b/file when a/file is deleted" do
265
- expect(File).to receive(:mtime).with(@file_a).and_return(@first_time)
266
+ File.expects(:mtime).with(@file_a).returns(@first_time)
266
267
  @autoload.class.mark_loaded("file", @file_a)
267
- allow(File).to receive(:mtime).with(@file_a).and_raise(Errno::ENOENT)
268
- allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(false)
269
- allow(Puppet::FileSystem).to receive(:exist?).with(@file_b).and_return(true)
270
- allow(File).to receive(:mtime).with(@file_b).and_return(@first_time)
271
- expect(Kernel).to receive(:load).with(@file_b, any_args)
268
+ File.stubs(:mtime).with(@file_a).raises(Errno::ENOENT)
269
+ Puppet::FileSystem.stubs(:exist?).with(@file_a).returns false
270
+ Puppet::FileSystem.stubs(:exist?).with(@file_b).returns true
271
+ File.stubs(:mtime).with(@file_b).returns @first_time
272
+ Kernel.expects(:load).with(@file_b, optionally(anything))
272
273
  @autoload.class.reload_changed(env)
273
274
  expect(@autoload.class.send(:loaded)["file"]).to eq([@file_b, @first_time])
274
275
  end
275
276
 
276
277
  it "should load a/file when b/file is loaded and a/file is created" do
277
- allow(File).to receive(:mtime).with(@file_b).and_return(@first_time)
278
- allow(Puppet::FileSystem).to receive(:exist?).with(@file_b).and_return(true)
278
+ File.stubs(:mtime).with(@file_b).returns @first_time
279
+ Puppet::FileSystem.stubs(:exist?).with(@file_b).returns true
279
280
  @autoload.class.mark_loaded("file", @file_b)
280
281
 
281
- allow(File).to receive(:mtime).with(@file_a).and_return(@first_time)
282
- allow(Puppet::FileSystem).to receive(:exist?).with(@file_a).and_return(true)
283
- expect(Kernel).to receive(:load).with(@file_a, any_args)
282
+ File.stubs(:mtime).with(@file_a).returns @first_time
283
+ Puppet::FileSystem.stubs(:exist?).with(@file_a).returns true
284
+ Kernel.expects(:load).with(@file_a, optionally(anything))
284
285
  @autoload.class.reload_changed(env)
285
286
  expect(@autoload.class.send(:loaded)["file"]).to eq([@file_a, @first_time])
286
287
  end
@@ -1,3 +1,4 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  require 'puppet/util/backups'
@@ -5,10 +6,10 @@ require 'puppet/util/backups'
5
6
  describe Puppet::Util::Backups do
6
7
  include PuppetSpec::Files
7
8
 
8
- let(:bucket) { double('bucket', :name => "foo") }
9
+ let(:bucket) { stub('bucket', :name => "foo") }
9
10
  let!(:file) do
10
11
  f = Puppet::Type.type(:file).new(:name => path, :backup => 'foo')
11
- allow(f).to receive(:bucket).and_return(bucket)
12
+ f.stubs(:bucket).returns(bucket)
12
13
  f
13
14
  end
14
15
 
@@ -18,8 +19,8 @@ describe Puppet::Util::Backups do
18
19
  it "should noop if the file does not exist" do
19
20
  file = Puppet::Type.type(:file).new(:name => path)
20
21
 
21
- expect(file).not_to receive(:bucket)
22
- expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(false)
22
+ file.expects(:bucket).never
23
+ Puppet::FileSystem.expects(:exist?).with(path).returns false
23
24
 
24
25
  file.perform_backup
25
26
  end
@@ -27,24 +28,24 @@ describe Puppet::Util::Backups do
27
28
  it "should succeed silently if self[:backup] is false" do
28
29
  file = Puppet::Type.type(:file).new(:name => path, :backup => false)
29
30
 
30
- expect(file).not_to receive(:bucket)
31
- expect(Puppet::FileSystem).not_to receive(:exist?)
31
+ file.expects(:bucket).never
32
+ Puppet::FileSystem.expects(:exist?).never
32
33
 
33
34
  file.perform_backup
34
35
  end
35
36
 
36
37
  it "a bucket should be used when provided" do
37
38
  lstat_path_as(path, 'file')
38
- expect(bucket).to receive(:backup).with(path).and_return("mysum")
39
- expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
39
+ bucket.expects(:backup).with(path).returns("mysum")
40
+ Puppet::FileSystem.expects(:exist?).with(path).returns(true)
40
41
 
41
42
  file.perform_backup
42
43
  end
43
44
 
44
45
  it "should propagate any exceptions encountered when backing up to a filebucket" do
45
46
  lstat_path_as(path, 'file')
46
- expect(bucket).to receive(:backup).and_raise(ArgumentError)
47
- expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
47
+ bucket.expects(:backup).raises ArgumentError
48
+ Puppet::FileSystem.expects(:exist?).with(path).returns(true)
48
49
 
49
50
  expect { file.perform_backup }.to raise_error(ArgumentError)
50
51
  end
@@ -56,42 +57,42 @@ describe Puppet::Util::Backups do
56
57
 
57
58
  it "should remove any local backup if one exists" do
58
59
  lstat_path_as(backup, 'file')
59
- expect(Puppet::FileSystem).to receive(:unlink).with(backup)
60
- allow(FileUtils).to receive(:cp_r)
61
- expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
60
+ Puppet::FileSystem.expects(:unlink).with(backup)
61
+ FileUtils.stubs(:cp_r)
62
+ Puppet::FileSystem.expects(:exist?).with(path).returns(true)
62
63
 
63
64
  file.perform_backup
64
65
  end
65
66
 
66
67
  it "should fail when the old backup can't be removed" do
67
68
  lstat_path_as(backup, 'file')
68
- expect(Puppet::FileSystem).to receive(:unlink).with(backup).and_raise(ArgumentError)
69
- expect(FileUtils).not_to receive(:cp_r)
70
- expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
69
+ Puppet::FileSystem.expects(:unlink).with(backup).raises ArgumentError
70
+ FileUtils.expects(:cp_r).never
71
+ Puppet::FileSystem.expects(:exist?).with(path).returns(true)
71
72
 
72
73
  expect { file.perform_backup }.to raise_error(Puppet::Error)
73
74
  end
74
75
 
75
76
  it "should not try to remove backups that don't exist" do
76
- expect(Puppet::FileSystem).to receive(:lstat).with(backup).and_raise(Errno::ENOENT)
77
- expect(Puppet::FileSystem).not_to receive(:unlink).with(backup)
78
- allow(FileUtils).to receive(:cp_r)
79
- expect(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
77
+ Puppet::FileSystem.expects(:lstat).with(backup).raises(Errno::ENOENT)
78
+ Puppet::FileSystem.expects(:unlink).with(backup).never
79
+ FileUtils.stubs(:cp_r)
80
+ Puppet::FileSystem.expects(:exist?).with(path).returns(true)
80
81
 
81
82
  file.perform_backup
82
83
  end
83
84
 
84
85
  it "a copy should be created in the local directory" do
85
- expect(FileUtils).to receive(:cp_r).with(path, backup, :preserve => true)
86
- allow(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
86
+ FileUtils.expects(:cp_r).with(path, backup, :preserve => true)
87
+ Puppet::FileSystem.stubs(:exist?).with(path).returns(true)
87
88
 
88
89
  expect(file.perform_backup).to be_truthy
89
90
  end
90
91
 
91
92
  it "should propagate exceptions if no backup can be created" do
92
- expect(FileUtils).to receive(:cp_r).and_raise(ArgumentError)
93
+ FileUtils.expects(:cp_r).raises ArgumentError
93
94
 
94
- allow(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
95
+ Puppet::FileSystem.stubs(:exist?).with(path).returns(true)
95
96
  expect { file.perform_backup }.to raise_error(Puppet::Error)
96
97
  end
97
98
  end
@@ -102,15 +103,15 @@ describe Puppet::Util::Backups do
102
103
  let(:filename) { File.join(path, 'file') }
103
104
 
104
105
  it "a bucket should work when provided" do
105
- allow(File).to receive(:file?).with(filename).and_return(true)
106
- expect(Find).to receive(:find).with(path).and_yield(filename)
106
+ File.stubs(:file?).with(filename).returns true
107
+ Find.expects(:find).with(path).yields(filename)
107
108
 
108
- expect(bucket).to receive(:backup).with(filename).and_return(true)
109
+ bucket.expects(:backup).with(filename).returns true
109
110
 
110
111
  lstat_path_as(path, 'directory')
111
112
 
112
- allow(Puppet::FileSystem).to receive(:exist?).with(path).and_return(true)
113
- allow(Puppet::FileSystem).to receive(:exist?).with(filename).and_return(true)
113
+ Puppet::FileSystem.stubs(:exist?).with(path).returns(true)
114
+ Puppet::FileSystem.stubs(:exist?).with(filename).returns(true)
114
115
 
115
116
  file.perform_backup
116
117
  end
@@ -118,16 +119,16 @@ describe Puppet::Util::Backups do
118
119
  it "should do nothing when recursing" do
119
120
  file = Puppet::Type.type(:file).new(:name => path, :backup => 'foo', :recurse => true)
120
121
 
121
- expect(bucket).not_to receive(:backup)
122
- stub_file = double('file', :stat => double('stat', :ftype => 'directory'))
123
- allow(Puppet::FileSystem).to receive(:new).with(path).and_return(stub_file)
124
- expect(Find).not_to receive(:find)
122
+ bucket.expects(:backup).never
123
+ stub_file = stub('file', :stat => stub('stat', :ftype => 'directory'))
124
+ Puppet::FileSystem.stubs(:new).with(path).returns stub_file
125
+ Find.expects(:find).never
125
126
 
126
127
  file.perform_backup
127
128
  end
128
129
  end
129
130
 
130
131
  def lstat_path_as(path, ftype)
131
- expect(Puppet::FileSystem).to receive(:lstat).with(path).and_return(double('File::Stat', :ftype => ftype))
132
+ Puppet::FileSystem.expects(:lstat).with(path).returns(stub('File::Stat', :ftype => ftype))
132
133
  end
133
134
  end