puppet 5.5.22 → 6.0.0

data/spec/unit/type/selmodule_spec.rb

@@ -1,16 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:selmodule), "when validating attributes" do
-  [:name, :selmoduledir, :selmodulepath].each do |param|
-    it "should have a #{param} parameter" do
-      expect(Puppet::Type.type(:selmodule).attrtype(param)).to eq(:param)
-    end
-  end
-
-  [:ensure, :syncversion].each do |param|
-    it "should have a #{param} property" do
-      expect(Puppet::Type.type(:selmodule).attrtype(param)).to eq(:property)
-    end
-  end
-end
-

data/spec/unit/type/ssh_authorized_key_spec.rb

@@ -1,228 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:ssh_authorized_key), :unless => Puppet.features.microsoft_windows? do
-  include PuppetSpec::Files
-
-  before do
-    provider_class = double('provider_class', :name => "fake", :suitable? => true, :supports_parameter? => true)
-    allow(described_class).to receive(:defaultprovider).and_return(provider_class)
-    allow(described_class).to receive(:provider).and_return(provider_class)
-
-    provider = double('provider', :class => provider_class, :file_path => make_absolute("/tmp/whatever"), :clear => nil)
-    allow(provider_class).to receive(:new).and_return(provider)
-  end
-
-  it "has :name as its namevar" do
-    expect(described_class.key_attributes).to eq [:name]
-  end
-
-  describe "when validating attributes" do
-    [:name, :provider].each do |param|
-      it "has a #{param} parameter" do
-        expect(described_class.attrtype(param)).to eq :param
-      end
-    end
-
-    [:type, :key, :user, :target, :options, :ensure].each do |property|
-      it "has a #{property} property" do
-        expect(described_class.attrtype(property)).to eq :property
-      end
-    end
-  end
-
-  describe "when validating values" do
-    describe "for name" do
-      it "supports valid names" do
-        described_class.new(:name => "username", :ensure => :present, :user => "nobody")
-        described_class.new(:name => "username@hostname", :ensure => :present, :user => "nobody")
-      end
-
-      it "supports whitespace" do
-        described_class.new(:name => "my test", :ensure => :present, :user => "nobody")
-      end
-    end
-
-    describe "for ensure" do
-      it "supports :present" do
-        described_class.new(:name => "whev", :ensure => :present, :user => "nobody")
-      end
-
-      it "supports :absent" do
-        described_class.new(:name => "whev", :ensure => :absent, :user => "nobody")
-      end
-
-      it "nots support other values" do
-        expect { described_class.new(:name => "whev", :ensure => :foo, :user => "nobody") }.to raise_error(Puppet::Error, /Invalid value/)
-      end
-    end
-
-    describe "for type" do
-      [
-        :'ssh-dss', :dsa,
-        :'ssh-rsa', :rsa,
-        :'ecdsa-sha2-nistp256',
-        :'ecdsa-sha2-nistp384',
-        :'ecdsa-sha2-nistp521',
-        :ed25519, :'ssh-ed25519',
-      ].each do |keytype|
-        it "supports #{keytype}" do
-          described_class.new(:name => "whev", :type => keytype, :user => "nobody")
-        end
-      end
-
-      it "aliases :rsa to :ssh-rsa" do
-        key = described_class.new(:name => "whev", :type => :rsa, :user => "nobody")
-        expect(key.should(:type)).to eq :'ssh-rsa'
-      end
-
-      it "aliases :dsa to :ssh-dss" do
-        key = described_class.new(:name => "whev", :type => :dsa, :user => "nobody")
-        expect(key.should(:type)).to eq :'ssh-dss'
-      end
-
-      it "doesn't support values other than ssh-dss, ssh-rsa, dsa, rsa" do
-        expect { described_class.new(:name => "whev", :type => :something) }.to raise_error(Puppet::Error,/Invalid value/)
-      end
-    end
-
-    describe "for key" do
-      it "supports a valid key like a 1024 bit rsa key" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :key => 'AAAAB3NzaC1yc2EAAAADAQABAAAAgQDCPfzW2ry7XvMc6E5Kj2e5fF/YofhKEvsNMUogR3PGL/HCIcBlsEjKisrY0aYgD8Ikp7ZidpXLbz5dBsmPy8hJiBWs5px9ZQrB/EOQAwXljvj69EyhEoGawmxQMtYw+OAIKHLJYRuk1QiHAMHLp5piqem8ZCV2mLb9AsJ6f7zUVw==')}.to_not raise_error
-      end
-
-      it "supports a valid key like a 4096 bit rsa key" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :key => 'AAAAB3NzaC1yc2EAAAADAQABAAACAQDEY4pZFyzSfRc9wVWI3DfkgT/EL033UZm/7x1M+d+lBD00qcpkZ6CPT7lD3Z+vylQlJ5S8Wcw6C5Smt6okZWY2WXA9RCjNJMIHQbJAzwuQwgnwU/1VMy9YPp0tNVslg0sUUgpXb13WW4mYhwxyGmIVLJnUrjrQmIFhtfHsJAH8ZVqCWaxKgzUoC/YIu1u1ScH93lEdoBPLlwm6J0aiM7KWXRb7Oq1nEDZtug1zpX5lhgkQWrs0BwceqpUbY+n9sqeHU5e7DCyX/yEIzoPRW2fe2Gx1Iq6JKM/5NNlFfaW8rGxh3Z3S1NpzPHTRjw8js3IeGiV+OPFoaTtM1LsWgPDSBlzIdyTbSQR7gKh0qWYCNV/7qILEfa0yIFB5wIo4667iSPZw2pNgESVtenm8uXyoJdk8iWQ4mecdoposV/znknNb2GPgH+n/2vme4btZ0Sl1A6rev22GQjVgbWOn8zaDglJ2vgCN1UAwmq41RXprPxENGeLnWQppTnibhsngu0VFllZR5kvSIMlekLRSOFLFt92vfd+tk9hZIiKm9exxcbVCGGQPsf6dZ27rTOmg0xM2Sm4J6RRKuz79HQgA4Eg18+bqRP7j/itb89DmtXEtoZFAsEJw8IgIfeGGDtHTkfAlAC92mtK8byeaxGq57XCTKbO/r5gcOMElZHy1AcB8kw==')}.to_not raise_error
-      end
-
-      it "supports a valid key like a 1024 bit dsa key" do
-        expect { described_class.new(:name => "whev", :type => :dsa, :user => "nobody", :key => 'AAAAB3NzaC1kc3MAAACBAI80iR78QCgpO4WabVqHHdEDigOjUEHwIjYHIubR/7u7DYrXY+e+TUmZ0CVGkiwB/0yLHK5dix3Y/bpj8ZiWCIhFeunnXccOdE4rq5sT2V3l1p6WP33RpyVYbLmeuHHl5VQ1CecMlca24nHhKpfh6TO/FIwkMjghHBfJIhXK+0w/AAAAFQDYzLupuMY5uz+GVrcP+Kgd8YqMmwAAAIB3SVN71whLWjFPNTqGyyIlMy50624UfNOaH4REwO+Of3wm/cE6eP8n75vzTwQGBpJX3BPaBGW1S1Zp/DpTOxhCSAwZzAwyf4WgW7YyAOdxN3EwTDJZeyiyjWMAOjW9/AOWt9gtKg0kqaylbMHD4kfiIhBzo31ZY81twUzAfN7angAAAIBfva8sTSDUGKsWWIXkdbVdvM4X14K4gFdy0ZJVzaVOtZ6alysW6UQypnsl6jfnbKvsZ0tFgvcX/CPyqNY/gMR9lyh/TCZ4XQcbqeqYPuceGehz+jL5vArfqsW2fJYFzgCcklmr/VxtP5h6J/T0c9YcDgc/xIfWdZAlznOnphI/FA==')}.to_not raise_error
-      end
-
-      it "doesn't support whitespaces" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :key => 'AAA FA==')}.to raise_error(Puppet::Error,/Key must not contain whitespace/)
-      end
-    end
-
-    describe "for options" do
-      it "supports flags as options" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => 'cert-authority')}.to_not raise_error
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => 'no-port-forwarding')}.to_not raise_error
-      end
-
-      it "supports key-value pairs as options" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => 'command="command"')}.to_not raise_error
-      end
-
-      it "supports key-value pairs where value consist of multiple items" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => 'from="*.domain1,host1.domain2"')}.to_not raise_error
-      end
-
-      it "supports environments as options" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => 'environment="NAME=value"')}.to_not raise_error
-      end
-
-      it "supports multiple options as an array" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => ['cert-authority','environment="NAME=value"'])}.to_not raise_error
-      end
-
-      it "doesn't support a comma separated list" do
-        expect { described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => 'cert-authority,no-port-forwarding')}.to raise_error(Puppet::Error, /must be provided as an array/)
-      end
-
-      it "uses :absent as a default value" do
-        expect(described_class.new(:name => "whev", :type => :rsa, :user => "nobody").should(:options)).to eq [:absent]
-      end
-
-      it "property should return well formed string of arrays from is_to_s" do
-        resource = described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => ["a","b","c"])
-        expect(resource.property(:options).is_to_s(["a","b","c"])).to eq "['a', 'b', 'c']"
-      end
-
-      it "property should return well formed string of arrays from should_to_s" do
-        resource = described_class.new(:name => "whev", :type => :rsa, :user => "nobody", :options => ["a","b","c"])
-        expect(resource.property(:options).should_to_s(["a","b","c"])).to eq "['a', 'b', 'c']"
-      end
-    end
-
-    describe "for user" do
-      it "supports present users" do
-        described_class.new(:name => "whev", :type => :rsa, :user => "root")
-      end
-
-      it "supports absent users" do
-        described_class.new(:name => "whev", :type => :rsa, :user => "ihopeimabsent")
-      end
-    end
-
-    describe "for target" do
-      it "supports absolute paths" do
-        described_class.new(:name => "whev", :type => :rsa, :target => "/tmp/here")
-      end
-
-      it "uses the user's path if not explicitly specified" do
-        expect(described_class.new(:name => "whev", :user => 'root').should(:target)).to eq File.expand_path("~root/.ssh/authorized_keys")
-      end
-
-      it "doesn't consider the user's path if explicitly specified" do
-        expect(described_class.new(:name => "whev", :user => 'root', :target => '/tmp/here').should(:target)).to eq '/tmp/here'
-      end
-
-      it "informs about an absent user" do
-        Puppet::Log.level = :debug
-        described_class.new(:name => "whev", :user => 'idontexist').should(:target)
-        expect(@logs.map(&:message)).to include("The required user is not yet present on the system")
-      end
-    end
-  end
-
-  describe "when neither user nor target is specified" do
-    it "raises an error" do
-      expect do
-        described_class.new(
-          :name   => "Test",
-          :key    => "AAA",
-          :type   => "ssh-rsa",
-          :ensure => :present)
-      end.to raise_error(Puppet::Error,/user.*or.*target.*mandatory/)
-    end
-  end
-
-  describe "when both target and user are specified" do
-    it "uses target" do
-      resource = described_class.new(
-        :name => "Test",
-        :user => "root",
-        :target => "/tmp/blah"
-      )
-      expect(resource.should(:target)).to eq "/tmp/blah"
-    end
-  end
-
-  describe "when user is specified" do
-    it "determines target" do
-      resource = described_class.new(
-        :name   => "Test",
-        :user   => "root"
-      )
-      target = File.expand_path("~root/.ssh/authorized_keys")
-      expect(resource.should(:target)).to eq target
-    end
-
-    # Bug #2124 - ssh_authorized_key always changes target if target is not defined
-    it "doesn't raise spurious change events" do
-      resource = described_class.new(:name => "Test", :user => "root")
-      target = File.expand_path("~root/.ssh/authorized_keys")
-      expect(resource.property(:target).safe_insync?(target)).to eq true
-    end
-  end
-
-  describe "when calling validate" do
-    it "doesn't crash on a non-existent user" do
-      resource = described_class.new(
-        :name   => "Test",
-        :user   => "ihopesuchuserdoesnotexist"
-      )
-      resource.validate
-    end
-  end
-end

data/spec/unit/type/sshkey_spec.rb

@@ -1,75 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:sshkey) do
-
-  it "uses :name as its namevar" do
-    expect(described_class.key_attributes).to eq [:name]
-  end
-
-  describe "when validating attributes" do
-    [:name, :provider].each do |param|
-      it "has a #{param} parameter" do
-        expect(described_class.attrtype(param)).to eq :param
-      end
-    end
-
-    [:host_aliases, :ensure, :key, :type].each do |property|
-      it "has a #{property} property" do
-        expect(described_class.attrtype(property)).to eq :property
-      end
-    end
-  end
-
-  describe "when validating values" do
-
-    [
-      :'ssh-dss', :dsa,
-      :'ssh-rsa', :rsa,
-      :'ecdsa-sha2-nistp256',
-      :'ecdsa-sha2-nistp384',
-      :'ecdsa-sha2-nistp521',
-      :'ssh-ed25519', :ed25519,
-    ].each do |keytype|
-      it "supports #{keytype} as a type value" do
-        described_class.new(:name => "foo", :type => keytype)
-      end
-    end
-
-    it "aliases :rsa to :ssh-rsa" do
-      key = described_class.new(:name => "foo", :type => :rsa)
-      expect(key.should(:type)).to eq :'ssh-rsa'
-    end
-
-    it "aliases :dsa to :ssh-dss" do
-      key = described_class.new(:name => "foo", :type => :dsa)
-      expect(key.should(:type)).to eq :'ssh-dss'
-    end
-
-    it "doesn't support values other than ssh-dss, ssh-rsa, dsa, rsa for type" do
-      expect {
-        described_class.new(:name => "whev", :type => :'ssh-dsa')
-      }.to raise_error(Puppet::Error, /Invalid value.*ssh-dsa/)
-    end
-
-    it "accepts one host_alias" do
-      described_class.new(:name => "foo", :host_aliases => 'foo.bar.tld')
-    end
-
-    it "accepts multiple host_aliases as an array" do
-      described_class.new(:name => "foo", :host_aliases => ['foo.bar.tld','10.0.9.9'])
-    end
-
-    it "doesn't accept spaces in any host_alias" do
-      expect {
-        described_class.new(:name => "foo", :host_aliases => ['foo.bar.tld','foo bar'])
-      }.to raise_error(Puppet::Error, /cannot include whitespace/)
-    end
-
-    it "doesn't accept aliases in the resourcename" do
-      expect {
-        described_class.new(:name => 'host,host.domain,ip')
-      }.to raise_error(Puppet::Error, /No comma in resourcename/)
-    end
-
-  end
-end

data/spec/unit/type/vlan_spec.rb

@@ -1,42 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:vlan) do
-  it "should have a 'name' parameter'" do
-    expect(Puppet::Type.type(:vlan).new(:name => "200")[:name]).to eq("200")
-  end
-
-  it "should have a 'device_url' parameter'" do
-    expect(Puppet::Type.type(:vlan).new(:name => "200", :device_url => :device)[:device_url]).to eq(:device)
-  end
-
-  it "should be applied on device" do
-    expect(Puppet::Type.type(:vlan).new(:name => "200")).to be_appliable_to_device
-  end
-
-  it "should have an ensure property" do
-    expect(Puppet::Type.type(:vlan).attrtype(:ensure)).to eq(:property)
-  end
-
-  it "should have a description property" do
-    expect(Puppet::Type.type(:vlan).attrtype(:description)).to eq(:property)
-  end
-
-  describe "when validating attribute values" do
-    before do
-      @provider = double('provider', :class => Puppet::Type.type(:vlan).defaultprovider, :clear => nil)
-      allow(Puppet::Type.type(:vlan).defaultprovider).to receive(:new).and_return(@provider)
-    end
-
-    it "should support :present as a value to :ensure" do
-      Puppet::Type.type(:vlan).new(:name => "200", :ensure => :present)
-    end
-
-    it "should support :absent as a value to :ensure" do
-      Puppet::Type.type(:vlan).new(:name => "200", :ensure => :absent)
-    end
-
-    it "should fail if vlan name is not a number" do
-      expect { Puppet::Type.type(:vlan).new(:name => "notanumber", :ensure => :present) }.to raise_error(Puppet::ResourceError, /Parameter name failed on Vlan/)
-    end
-  end
-end

data/spec/unit/type/yumrepo_spec.rb

@@ -1,476 +0,0 @@
-require 'spec_helper'
-require 'puppet'
-
-shared_examples_for "a yumrepo parameter that can be absent" do |param|
-  it "can be set as :absent" do
-    described_class.new(:name => 'puppetlabs', param => :absent)
-  end
-  it "can be set as \"absent\"" do
-    described_class.new(:name => 'puppetlabs', param => 'absent')
-  end
-end
-
-shared_examples_for "a yumrepo parameter that can be an integer" do |param|
-  it "accepts a valid positive integer" do
-    instance = described_class.new(:name => 'puppetlabs', param => '12')
-    expect(instance[param]).to eq '12'
-  end
-  it "accepts zero" do
-    instance = described_class.new(:name => 'puppetlabs', param => '0')
-    expect(instance[param]).to eq '0'
-  end
-  it "rejects invalid positive float" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => '12.5'
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-  it "rejects invalid non-integer" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => 'I\'m a six'
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-  it "rejects invalid string with integers inside" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => 'I\'m a 6'
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-end
-
-shared_examples_for "a yumrepo parameter that can't be a negative integer" do |param|
-  it "rejects invalid negative integer" do
-    expect {
-      described_class.new(
-          :name => 'puppetlabs',
-          param => '-12'
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-end
-
-shared_examples_for "a yumrepo parameter that expects a boolean parameter" do |param|
-  valid_values = %w[true false 0 1 no yes]
-
-  valid_values.each do |value|
-    it "accepts #{value} downcased to #{value.downcase} and capitalizes it" do
-      instance = described_class.new(:name => 'puppetlabs', param => value.downcase)
-      expect(instance[param]).to eq value.downcase.capitalize
-    end
-    it "fails on valid value #{value} contained in another value" do
-        expect {
-          described_class.new(
-            :name => 'puppetlabs',
-            param => "bla#{value}bla"
-          )
-        }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-    end
-  end
-
-  it "rejects invalid boolean values" do
-    expect {
-      described_class.new(:name => 'puppetlabs', param => 'flase')
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-end
-
-shared_examples_for "a yumrepo parameter that accepts a single URL" do |param|
-  it "can accept a single URL" do
-    described_class.new(
-      :name => 'puppetlabs',
-      param => 'http://localhost/yumrepos'
-    )
-  end
-
-  it "fails if an invalid URL is provided" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => "that's no URL!"
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-
-  it "fails if a valid URL uses an invalid URI scheme" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => 'ldap://localhost/yumrepos'
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-end
-
-shared_examples_for "a yumrepo parameter that accepts multiple URLs" do |param|
-  it "can accept multiple URLs" do
-    described_class.new(
-      :name => 'puppetlabs',
-      param => 'http://localhost/yumrepos http://localhost/more-yumrepos'
-    )
-  end
-
-  it "fails if multiple URLs are given and one is invalid" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => "http://localhost/yumrepos That's no URL!"
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-end
-
-shared_examples_for "a yumrepo parameter that accepts kMG units" do |param|
-  %w[k M G].each do |unit|
-    it "can accept an integer with #{unit} units" do
-      described_class.new(
-        :name => 'puppetlabs',
-        param => "123#{unit}"
-      )
-    end
-  end
-
-  it "fails if wrong unit passed" do
-    expect {
-      described_class.new(
-        :name => 'puppetlabs',
-        param => '123J'
-      )
-    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
-  end
-end
-
-describe Puppet::Type.type(:yumrepo) do
-  it "has :name as its namevar" do
-    expect(described_class.key_attributes).to eq [:name]
-  end
-
-  describe "validating" do
-
-    describe "name" do
-      it "is a valid parameter" do
-        instance = described_class.new(:name => 'puppetlabs')
-        expect(instance.name).to eq 'puppetlabs'
-      end
-    end
-
-    describe "target" do
-      it_behaves_like "a yumrepo parameter that can be absent", :target
-    end
-
-    describe "descr" do
-      it_behaves_like "a yumrepo parameter that can be absent", :descr
-    end
-
-    describe "mirrorlist" do
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :mirrorlist
-      it_behaves_like "a yumrepo parameter that can be absent", :mirrorlist
-    end
-
-    describe "baseurl" do
-      it_behaves_like "a yumrepo parameter that can be absent", :baseurl
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :baseurl
-      it_behaves_like "a yumrepo parameter that accepts multiple URLs", :baseurl
-    end
-
-    describe "enabled" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :enabled
-      it_behaves_like "a yumrepo parameter that can be absent", :enabled
-    end
-
-    describe "gpgcheck" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :gpgcheck
-      it_behaves_like "a yumrepo parameter that can be absent", :gpgcheck
-    end
-
-    describe "payload_gpgcheck" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :payload_gpgcheck
-      it_behaves_like "a yumrepo parameter that can be absent", :payload_gpgcheck
-    end
-
-    describe "repo_gpgcheck" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :repo_gpgcheck
-      it_behaves_like "a yumrepo parameter that can be absent", :repo_gpgcheck
-    end
-
-    describe "gpgkey" do
-      it_behaves_like "a yumrepo parameter that can be absent", :gpgkey
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :gpgkey
-      it_behaves_like "a yumrepo parameter that accepts multiple URLs", :gpgkey
-    end
-
-    describe "include" do
-      it_behaves_like "a yumrepo parameter that can be absent", :include
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :include
-    end
-
-    describe "exclude" do
-      it_behaves_like "a yumrepo parameter that can be absent", :exclude
-    end
-
-    describe "includepkgs" do
-      it_behaves_like "a yumrepo parameter that can be absent", :includepkgs
-    end
-
-    describe "enablegroups" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :enablegroups
-      it_behaves_like "a yumrepo parameter that can be absent", :enablegroups
-    end
-
-    describe "failovermethod" do
-
-      %w[roundrobin priority].each do |value|
-        it "accepts a value of #{value}" do
-          described_class.new(:name => "puppetlabs", :failovermethod => value)
-        end
-        it "fails on valid value #{value} contained in another value" do
-          expect {
-            described_class.new(
-              :name => 'puppetlabs',
-              :failovermethod => "bla#{value}bla"
-            )
-          }.to raise_error(Puppet::ResourceError, /Parameter failovermethod failed/)
-        end
-      end
-
-      it "raises an error if an invalid value is given" do
-        expect {
-          described_class.new(:name => "puppetlabs", :failovermethod => "notavalidvalue")
-        }.to raise_error(Puppet::ResourceError, /Parameter failovermethod failed/)
-      end
-
-      it_behaves_like "a yumrepo parameter that can be absent", :failovermethod
-    end
-
-    describe "keepalive" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :keepalive
-      it_behaves_like "a yumrepo parameter that can be absent", :keepalive
-    end
-
-    describe "http_caching" do
-      %w[packages all none].each do |value|
-        it "accepts a valid value of #{value}" do
-          described_class.new(:name => 'puppetlabs', :http_caching => value)
-        end
-        it "fails on valid value #{value} contained in another value" do
-          expect {
-            described_class.new(
-              :name => 'puppetlabs',
-              :http_caching => "bla#{value}bla"
-            )
-          }.to raise_error(Puppet::ResourceError, /Parameter http_caching failed/)
-        end
-      end
-
-      it "rejects invalid values" do
-        expect {
-          described_class.new(:name => 'puppetlabs', :http_caching => 'yes')
-        }.to raise_error(Puppet::ResourceError, /Parameter http_caching failed/)
-      end
-
-      it_behaves_like "a yumrepo parameter that can be absent", :http_caching
-    end
-
-    describe "timeout" do
-      it_behaves_like "a yumrepo parameter that can be absent", :timeout
-      it_behaves_like "a yumrepo parameter that can be an integer", :timeout
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :timeout
-    end
-
-    describe "metadata_expire" do
-      it_behaves_like "a yumrepo parameter that can be absent", :metadata_expire
-      it_behaves_like "a yumrepo parameter that can be an integer", :metadata_expire
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :metadata_expire
-
-      it "accepts dhm units" do
-        %W[d h m].each do |unit|
-          described_class.new(
-            :name            => 'puppetlabs',
-            :metadata_expire => "123#{unit}"
-          )
-        end
-      end
-
-      it "accepts never as value" do
-        described_class.new(:name => 'puppetlabs', :metadata_expire => 'never')
-      end
-    end
-
-    describe "protect" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :protect
-      it_behaves_like "a yumrepo parameter that can be absent", :protect
-    end
-
-    describe "priority" do
-      it_behaves_like "a yumrepo parameter that can be absent", :priority
-      it_behaves_like "a yumrepo parameter that can be an integer", :priority
-    end
-
-    describe "proxy" do
-      it_behaves_like "a yumrepo parameter that can be absent", :proxy
-      it "accepts _none_" do
-        described_class.new(
-          :name  => 'puppetlabs',
-          :proxy => "_none_"
-        )
-      end
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :proxy
-    end
-
-    describe "proxy_username" do
-      it_behaves_like "a yumrepo parameter that can be absent", :proxy_username
-    end
-
-    describe "proxy_password" do
-      it_behaves_like "a yumrepo parameter that can be absent", :proxy_password
-
-      context "for password information in the logs" do
-        let(:transaction) { Puppet::Transaction.new(Puppet::Resource::Catalog.new, nil, nil) }
-        let(:harness) { Puppet::Transaction::ResourceHarness.new(transaction) }
-        let(:provider_class) { described_class.provide(:simple) do
-          mk_resource_methods
-          def create; end
-          def delete; end
-          def exists?; get(:ensure) != :absent; end
-          def flush; end
-          def self.instances; []; end
-        end
-        }
-        let(:provider) { provider_class.new(:name => 'foo', :ensure => :present) }
-        let(:resource) { described_class.new(:name => 'puppetlabs', :proxy_password => 'top secret', :provider => provider) }
-
-        it "redacts on creation" do
-          status = harness.evaluate(resource)
-          sync_event = status.events[0]
-          expect(sync_event.message).to eq 'changed [redacted] to [redacted]'
-        end
-
-        it "redacts on update" do
-          harness.evaluate(resource)
-          resource[:proxy_password] = 'super classified'
-          status = harness.evaluate(resource)
-          sync_event = status.events[0]
-          expect(sync_event.message).to eq 'changed [redacted] to [redacted]'
-        end
-      end
-    end
-
-    describe "s3_enabled" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :s3_enabled
-      it_behaves_like "a yumrepo parameter that can be absent", :s3_enabled
-    end
-
-    describe "skip_if_unavailable" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :skip_if_unavailable
-      it_behaves_like "a yumrepo parameter that can be absent", :skip_if_unavailable
-    end
-
-    describe "sslcacert" do
-      it_behaves_like "a yumrepo parameter that can be absent", :sslcacert
-    end
-
-    describe "sslverify" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :sslverify
-      it_behaves_like "a yumrepo parameter that can be absent", :sslverify
-    end
-
-    describe "sslclientcert" do
-      it_behaves_like "a yumrepo parameter that can be absent", :sslclientcert
-    end
-
-    describe "sslclientkey" do
-      it_behaves_like "a yumrepo parameter that can be absent", :sslclientkey
-    end
-
-    describe "metalink" do
-      it_behaves_like "a yumrepo parameter that can be absent", :metalink
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :metalink
-    end
-
-    describe "assumeyes" do
-      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :assumeyes
-      it_behaves_like "a yumrepo parameter that can be absent", :assumeyes
-    end
-
-
-    describe "cost" do
-      it_behaves_like "a yumrepo parameter that can be absent", :cost
-      it_behaves_like "a yumrepo parameter that can be an integer", :cost
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :cost
-    end
-
-    describe "throttle" do
-      it_behaves_like "a yumrepo parameter that can be absent", :throttle
-      it_behaves_like "a yumrepo parameter that can be an integer", :throttle
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :throttle
-      it_behaves_like "a yumrepo parameter that accepts kMG units", :throttle
-
-      it "accepts percentage as unit" do
-        described_class.new(
-          :name     => 'puppetlabs',
-          :throttle => '123%'
-        )
-      end
-    end
-
-    describe "bandwidth" do
-      it_behaves_like "a yumrepo parameter that can be absent", :bandwidth
-      it_behaves_like "a yumrepo parameter that can be an integer", :bandwidth
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :bandwidth
-      it_behaves_like "a yumrepo parameter that accepts kMG units", :bandwidth
-    end
-
-    describe "gpgcakey" do
-      it_behaves_like "a yumrepo parameter that can be absent", :gpgcakey
-      it_behaves_like "a yumrepo parameter that accepts a single URL", :gpgcakey
-    end
-
-    describe "retries" do
-      it_behaves_like "a yumrepo parameter that can be absent", :retries
-      it_behaves_like "a yumrepo parameter that can be an integer", :retries
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :retries
-    end
-
-    describe "mirrorlist_expire" do
-      it_behaves_like "a yumrepo parameter that can be absent", :mirrorlist_expire
-      it_behaves_like "a yumrepo parameter that can be an integer", :mirrorlist_expire
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :mirrorlist_expire
-    end
-
-    describe "deltarpm_percentage" do
-      it_behaves_like "a yumrepo parameter that can be absent", :deltarpm_percentage
-      it_behaves_like "a yumrepo parameter that can be an integer", :deltarpm_percentage
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :deltarpm_percentage
-    end
-
-    describe "deltarpm_metadata_percentage" do
-      it_behaves_like "a yumrepo parameter that can be absent", :deltarpm_metadata_percentage
-      it_behaves_like "a yumrepo parameter that can be an integer", :deltarpm_metadata_percentage
-      it_behaves_like "a yumrepo parameter that can't be a negative integer", :deltarpm_metadata_percentage
-    end
-
-    describe "username" do
-      it_behaves_like "a yumrepo parameter that can be absent", :username
-    end
-
-    describe "password" do
-      it_behaves_like "a yumrepo parameter that can be absent", :password
-
-      it "redacts password information from the logs" do
-        resource = described_class.new(:name => 'puppetlabs', :password => 'top secret')
-        harness = Puppet::Transaction::ResourceHarness.new(Puppet::Transaction.new(Puppet::Resource::Catalog.new, nil, nil))
-        harness.evaluate(resource)
-        resource[:password] = 'super classified'
-        status = harness.evaluate(resource)
-        sync_event = status.events[0]
-        expect(sync_event.message).to eq 'changed [redacted] to [redacted]'
-      end
-    end
-  end
-end