puppet 5.5.12 → 5.5.13

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:filebucket) do
@@ -77,26 +76,26 @@ describe Puppet::Type.type(:filebucket) do
77
76
 
78
77
  describe "when creating the filebucket" do
79
78
  before do
80
- @bucket = stub 'bucket', :name= => nil
79
+ @bucket = double('bucket', :name= => nil)
81
80
  end
82
81
 
83
82
  it "should use any provided path" do
84
83
  path = make_absolute("/foo/bar")
85
84
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :path => path
86
- Puppet::FileBucket::Dipper.expects(:new).with(:Path => path).returns @bucket
85
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Path => path).and_return(@bucket)
87
86
  bucket.bucket
88
87
  end
89
88
 
90
89
  it "should use any provided server and port" do
91
90
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :server => "myserv", :port => "myport", :path => false
92
- Puppet::FileBucket::Dipper.expects(:new).with(:Server => "myserv", :Port => "myport").returns @bucket
91
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Server => "myserv", :Port => "myport").and_return(@bucket)
93
92
  bucket.bucket
94
93
  end
95
94
 
96
95
  it "should not try to guess server or port if the path is unset and no server is provided" do
97
96
  Puppet.settings[:server] = "myserv"
98
97
  Puppet.settings[:server_list] = ['server_list_0', 'server_list_1']
99
- Puppet::FileBucket::Dipper.expects(:new).with(:Server => nil, :Port => nil).returns @bucket
98
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Server => nil, :Port => nil).and_return(@bucket)
100
99
 
101
100
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :path => false
102
101
  bucket.bucket
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:group) do
@@ -50,20 +49,20 @@ describe Puppet::Type.type(:group) do
50
49
 
51
50
  it "should call 'create' to create the group" do
52
51
  group = @class.new(:name => "foo", :ensure => :present)
53
- group.provider.expects(:create)
52
+ expect(group.provider).to receive(:create)
54
53
  group.parameter(:ensure).sync
55
54
  end
56
55
 
57
56
  it "should call 'delete' to remove the group" do
58
57
  group = @class.new(:name => "foo", :ensure => :absent)
59
- group.provider.expects(:delete)
58
+ expect(group.provider).to receive(:delete)
60
59
  group.parameter(:ensure).sync
61
60
  end
62
61
 
63
62
  it "delegates the existence check to its provider" do
64
63
  provider = @class.provide(:testing) {}
65
64
  provider_instance = provider.new
66
- provider_instance.expects(:exists?).returns true
65
+ expect(provider_instance).to receive(:exists?).and_return(true)
67
66
 
68
67
  type = @class.new(:name => "group", :provider => provider_instance)
69
68
 
@@ -71,7 +70,6 @@ describe Puppet::Type.type(:group) do
71
70
  end
72
71
 
73
72
  describe "should delegate :members implementation to the provider:" do
74
-
75
73
  let (:provider) do
76
74
  @class.provide(:testing) do
77
75
  has_features :manages_members
@@ -85,13 +83,13 @@ describe Puppet::Type.type(:group) do
85
83
  let (:type) { @class.new(:name => "group", :provider => provider_instance, :members => ['user1']) }
86
84
 
87
85
  it "insync? calls members_insync?" do
88
- provider_instance.expects(:members_insync?).with(['user1'], ['user1']).returns true
86
+ expect(provider_instance).to receive(:members_insync?).with(['user1'], ['user1']).and_return(true)
89
87
  expect(type.property(:members).insync?(['user1'])).to be_truthy
90
88
  end
91
89
 
92
90
  it "is_to_s and should_to_s call members_to_s" do
93
- provider_instance.expects(:members_to_s).with(['user1', 'user2']).returns "user1 (), user2 ()"
94
- provider_instance.expects(:members_to_s).with(['user1']).returns "user1 ()"
91
+ expect(provider_instance).to receive(:members_to_s).with(['user1', 'user2']).and_return("user1 (), user2 ()")
92
+ expect(provider_instance).to receive(:members_to_s).with(['user1']).and_return("user1 ()")
95
93
 
96
94
  expect(type.property(:members).is_to_s('user1')).to eq('user1 ()')
97
95
  expect(type.property(:members).should_to_s('user1,user2')).to eq('user1 (), user2 ()')
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  host = Puppet::Type.type(:host)
@@ -9,7 +8,7 @@ describe host do
9
8
  @class = host
10
9
  @catalog = Puppet::Resource::Catalog.new
11
10
  @provider = FakeHostProvider.new
12
- @resource = stub 'resource', :resource => nil, :provider => @provider
11
+ @resource = double('resource', :resource => nil, :provider => @provider)
13
12
  end
14
13
 
15
14
  it "should have :name be its namevar" do
@@ -659,7 +658,7 @@ describe host do
659
658
 
660
659
  it "should also use the specified delimiter for joining" do
661
660
  @host_aliases = @class.attrclass(:host_aliases).new(:resource => @resource, :should => %w{foo bar})
662
- @host_aliases.stubs(:delimiter).returns "\t"
661
+ allow(@host_aliases).to receive(:delimiter).and_return("\t")
663
662
 
664
663
  @host_aliases.sync
665
664
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:interface) do
@@ -27,8 +26,8 @@ describe Puppet::Type.type(:interface) do
27
26
 
28
27
  describe "when validating attribute values" do
29
28
  before do
30
- @provider = stub 'provider', :class => Puppet::Type.type(:interface).defaultprovider, :clear => nil
31
- Puppet::Type.type(:interface).defaultprovider.stubs(:new).returns(@provider)
29
+ @provider = double('provider', :class => Puppet::Type.type(:interface).defaultprovider, :clear => nil)
30
+ allow(Puppet::Type.type(:interface).defaultprovider).to receive(:new).and_return(@provider)
32
31
  end
33
32
 
34
33
  it "should support :present as a value to :ensure" do
@@ -1,4 +1,3 @@
1
- #!/usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'fileutils'
4
3
  require 'puppet/type'
@@ -84,7 +83,7 @@ describe Puppet::Type.type(:k5login), :unless => Puppet.features.microsoft_windo
84
83
 
85
84
  context "with selinux" do
86
85
  it "should return correct values based on SELinux state" do
87
- sel_param.stubs(:debug)
86
+ allow(sel_param).to receive(:debug)
88
87
  expectedresult = case param
89
88
  when :seluser; "user_u"
90
89
  when :selrole; "object_r"
@@ -97,14 +96,14 @@ describe Puppet::Type.type(:k5login), :unless => Puppet.features.microsoft_windo
97
96
 
98
97
  context 'without selinux' do
99
98
  it 'should not try to determine the initial state' do
100
- Puppet::Type::K5login::ProviderK5login.any_instance.stubs(:selinux_support?).returns false
99
+ allow_any_instance_of(Puppet::Type::K5login::ProviderK5login).to receive(:selinux_support?).and_return(false)
101
100
 
102
101
  expect(subject[:selrole]).to be_nil
103
102
  end
104
103
 
105
104
  it "should do nothing for safe_insync? if no SELinux support" do
106
105
  sel_param.should = 'newcontext'
107
- sel_param.expects(:selinux_support?).returns false
106
+ expect(sel_param).to receive(:selinux_support?).and_return(false)
108
107
  expect(sel_param.safe_insync?('oldcontext')).to eq(true)
109
108
  end
110
109
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  module Puppet::Util::Plist
@@ -7,19 +6,17 @@ end
7
6
  macauth_type = Puppet::Type.type(:macauthorization)
8
7
 
9
8
  describe Puppet::Type.type(:macauthorization), "when checking macauthorization objects" do
10
-
11
9
  before do
12
10
  authplist = {}
13
11
  authplist["rules"] = { "foorule" => "foo" }
14
12
  authplist["rights"] = { "fooright" => "foo" }
15
13
  provider_class = macauth_type.provider(macauth_type.providers[0])
16
- Puppet::Util::Plist.stubs(:parse_plist).with("/etc/authorization").returns(authplist)
17
- macauth_type.stubs(:defaultprovider).returns provider_class
14
+ allow(Puppet::Util::Plist).to receive(:parse_plist).with("/etc/authorization").and_return(authplist)
15
+ allow(macauth_type).to receive(:defaultprovider).and_return(provider_class)
18
16
  @resource = macauth_type.new(:name => 'foo')
19
17
  end
20
18
 
21
19
  describe "when validating attributes" do
22
-
23
20
  parameters = [:name,]
24
21
  properties = [:auth_type, :allow_root, :authenticate_user, :auth_class,
25
22
  :comment, :group, :k_of_n, :mechanisms, :rule,
@@ -44,11 +41,9 @@ describe Puppet::Type.type(:macauthorization), "when checking macauthorization o
44
41
  expect(macauth_type.attrclass(property).doc).to be_instance_of(String)
45
42
  end
46
43
  end
47
-
48
44
  end
49
45
 
50
46
  describe "when validating properties" do
51
-
52
47
  it "should have a default provider inheriting from Puppet::Provider" do
53
48
  expect(macauth_type.defaultprovider.ancestors).to be_include(Puppet::Provider)
54
49
  end
@@ -70,7 +65,6 @@ describe Puppet::Type.type(:macauthorization), "when checking macauthorization o
70
65
  macauth_type.new(:name => "foo", :ensure => :absent)
71
66
  }.not_to raise_error
72
67
  end
73
-
74
68
  end
75
69
 
76
70
  [:k_of_n, :timeout, :tries].each do |property|
@@ -80,11 +74,13 @@ describe Puppet::Type.type(:macauthorization), "when checking macauthorization o
80
74
  prop.should = "300"
81
75
  expect(prop.should).to eq(300)
82
76
  end
77
+
83
78
  it "should support integers as a value" do
84
79
  prop = macauth_type.attrclass(property).new(:resource => @resource)
85
80
  prop.should = 300
86
81
  expect(prop.should).to eq(300)
87
82
  end
83
+
88
84
  it "should raise an error for non-integer values" do
89
85
  prop = macauth_type.attrclass(property).new(:resource => @resource)
90
86
  expect { prop.should = "foo" }.to raise_error(Puppet::Error)
@@ -99,11 +95,13 @@ describe Puppet::Type.type(:macauthorization), "when checking macauthorization o
99
95
  prop.should = "false"
100
96
  expect(prop.should).to eq(:false)
101
97
  end
98
+
102
99
  it "should convert boolean-looking true strings into actual booleans" do
103
100
  prop = macauth_type.attrclass(property).new(:resource => @resource)
104
101
  prop.should = "true"
105
102
  expect(prop.should).to eq(:true)
106
103
  end
104
+
107
105
  it "should raise an error for non-boolean values" do
108
106
  prop = macauth_type.attrclass(property).new(:resource => @resource)
109
107
  expect { prop.should = "foo" }.to raise_error(Puppet::Error)
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:mailalias) do
@@ -24,13 +23,13 @@ describe Puppet::Type.type(:mailalias) do
24
23
 
25
24
  it "should try and set the recipient when it does the sync" do
26
25
  expect(recipient_resource.retrieve_resource[:recipient]).to eq(:absent)
27
- recipient_resource.property(:recipient).expects(:set).with(["yay"])
26
+ expect(recipient_resource.property(:recipient)).to receive(:set).with(["yay"])
28
27
  recipient_resource.property(:recipient).sync
29
28
  end
30
29
 
31
30
  it "should try and set the included file when it does the sync" do
32
31
  expect(file_resource.retrieve_resource[:file]).to eq(:absent)
33
- file_resource.property(:file).expects(:set).with(tmpfile_path)
32
+ expect(file_resource.property(:file)).to receive(:set).with(tmpfile_path)
34
33
  file_resource.property(:file).sync
35
34
  end
36
35
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  maillist = Puppet::Type.type(:maillist)
@@ -7,12 +6,12 @@ describe maillist do
7
6
  before do
8
7
  @provider_class = Puppet::Type.type(:maillist).provider(:mailman)
9
8
 
10
- @provider = stub 'provider', :class => @provider_class, :clear => nil
11
- @provider.stubs(:respond_to).with(:aliases).returns(true)
9
+ @provider = double('provider', :class => @provider_class, :clear => nil)
10
+ allow(@provider).to receive(:respond_to).with(:aliases).and_return(true)
12
11
 
13
- @provider_class.stubs(:new).returns(@provider)
12
+ allow(@provider_class).to receive(:new).and_return(@provider)
14
13
 
15
- Puppet::Type.type(:maillist).stubs(:defaultprovider).returns(@provider_class)
14
+ allow(Puppet::Type.type(:maillist)).to receive(:defaultprovider).and_return(@provider_class)
16
15
 
17
16
  @maillist = Puppet::Type.type(:maillist).new( :name => 'test' )
18
17
 
@@ -24,18 +23,16 @@ describe maillist do
24
23
  # Mail List aliases are careful not to stomp on managed Mail Alias aliases
25
24
 
26
25
  # test1 is an unmanaged alias from /etc/aliases
27
- Puppet::Type.type(:mailalias).provider(:aliases).stubs(:target_object).returns( StringIO.new("test1: root\n") )
26
+ allow(Puppet::Type.type(:mailalias).provider(:aliases)).to receive(:target_object).and_return(StringIO.new("test1: root\n"))
28
27
 
29
28
  # test2 is a managed alias from the manifest
30
29
  dupe = Puppet::Type.type(:mailalias).new( :name => 'test2' )
31
30
  @catalog.add_resource dupe
32
31
 
33
- @provider.stubs(:aliases).returns({"test1" => 'this will get included', "test2" => 'this will dropped', "test3" => 'this will get included'})
32
+ allow(@provider).to receive(:aliases).and_return({"test1" => 'this will get included', "test2" => 'this will dropped', "test3" => 'this will get included'})
34
33
 
35
34
  generated = @maillist.generate
36
35
  expect(generated.map{ |x| x.name }.sort).to eq(['test1', 'test3'])
37
36
  expect(generated.map{ |x| x.class }).to eq([Puppet::Type::Mailalias, Puppet::Type::Mailalias])
38
-
39
37
  end
40
-
41
38
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/type/mcx'
@@ -6,7 +5,6 @@ require 'puppet/type/mcx'
6
5
  mcx_type = Puppet::Type.type(:mcx)
7
6
 
8
7
  describe mcx_type, "when validating attributes" do
9
-
10
8
  properties = [:ensure, :content]
11
9
  parameters = [:name, :ds_type, :ds_name]
12
10
 
@@ -14,6 +12,7 @@ describe mcx_type, "when validating attributes" do
14
12
  it "should have a #{p} parameter" do
15
13
  expect(mcx_type.attrclass(p).ancestors).to be_include(Puppet::Parameter)
16
14
  end
15
+
17
16
  it "should have documentation for its #{p} parameter" do
18
17
  expect(mcx_type.attrclass(p).doc).to be_instance_of(String)
19
18
  end
@@ -23,6 +22,7 @@ describe mcx_type, "when validating attributes" do
23
22
  it "should have a #{p} property" do
24
23
  expect(mcx_type.attrclass(p).ancestors).to be_include(Puppet::Property)
25
24
  end
25
+
26
26
  it "should have documentation for its #{p} property" do
27
27
  expect(mcx_type.attrclass(p).doc).to be_instance_of(String)
28
28
  end
@@ -31,10 +31,9 @@ describe mcx_type, "when validating attributes" do
31
31
  end
32
32
 
33
33
  describe mcx_type, "default values" do
34
-
35
34
  before :each do
36
35
  provider_class = mcx_type.provider(mcx_type.providers[0])
37
- mcx_type.stubs(:defaultprovider).returns provider_class
36
+ allow(mcx_type).to receive(:defaultprovider).and_return(provider_class)
38
37
  end
39
38
 
40
39
  it "should be nil for :ds_type" do
@@ -48,14 +47,12 @@ describe mcx_type, "default values" do
48
47
  it "should be nil for :content" do
49
48
  expect(mcx_type.new(:name => '/Foo/bar')[:content]).to be_nil
50
49
  end
51
-
52
50
  end
53
51
 
54
52
  describe mcx_type, "when validating properties" do
55
-
56
53
  before :each do
57
54
  provider_class = mcx_type.provider(mcx_type.providers[0])
58
- mcx_type.stubs(:defaultprovider).returns provider_class
55
+ allow(mcx_type).to receive(:defaultprovider).and_return(provider_class)
59
56
  end
60
57
 
61
58
  it "should be able to create an instance" do
@@ -75,5 +72,4 @@ describe mcx_type, "when validating properties" do
75
72
  mcx_type.new(:name => "/Foo/bar", :ensure => :absent)
76
73
  }.not_to raise_error
77
74
  end
78
-
79
75
  end
@@ -1,10 +1,8 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows? do
5
-
6
4
  before :each do
7
- Puppet::Type.type(:mount).stubs(:defaultprovider).returns providerclass
5
+ allow(Puppet::Type.type(:mount)).to receive(:defaultprovider).and_return(providerclass)
8
6
  end
9
7
 
10
8
  let :providerclass do
@@ -64,7 +62,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
64
62
  end
65
63
 
66
64
  describe "when validating values" do
67
-
68
65
  describe "for name" do
69
66
  it "should allow full qualified paths" do
70
67
  expect(described_class.new(:name => "/mnt/foo")[:name]).to eq('/mnt/foo')
@@ -145,8 +142,8 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
145
142
  describe "for blockdevice" do
146
143
  before :each do
147
144
  # blockdevice is only used on Solaris
148
- Facter.stubs(:value).with(:operatingsystem).returns 'Solaris'
149
- Facter.stubs(:value).with(:osfamily).returns 'Solaris'
145
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
146
+ allow(Facter).to receive(:value).with(:osfamily).and_return('Solaris')
150
147
  end
151
148
 
152
149
  it "should support normal /dev/rdsk paths for blockdevice" do
@@ -229,20 +226,20 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
229
226
  end
230
227
 
231
228
  it "should support - on Solaris" do
232
- Facter.stubs(:value).with(:operatingsystem).returns 'Solaris'
233
- Facter.stubs(:value).with(:osfamily).returns 'Solaris'
229
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
230
+ allow(Facter).to receive(:value).with(:osfamily).and_return('Solaris')
234
231
  expect { described_class.new(:name => "/foo", :ensure => :present, :pass => '-') }.to_not raise_error
235
232
  end
236
233
 
237
234
  it "should default to 0 on non Solaris" do
238
- Facter.stubs(:value).with(:osfamily).returns nil
239
- Facter.stubs(:value).with(:operatingsystem).returns 'HP-UX'
235
+ allow(Facter).to receive(:value).with(:osfamily).and_return(nil)
236
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return('HP-UX')
240
237
  expect(described_class.new(:name => "/foo", :ensure => :present)[:pass]).to eq(0)
241
238
  end
242
239
 
243
240
  it "should default to - on Solaris" do
244
- Facter.stubs(:value).with(:operatingsystem).returns 'Solaris'
245
- Facter.stubs(:value).with(:osfamily).returns 'Solaris'
241
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
242
+ allow(Facter).to receive(:value).with(:osfamily).and_return('Solaris')
246
243
  expect(described_class.new(:name => "/foo", :ensure => :present)[:pass]).to eq('-')
247
244
  end
248
245
  end
@@ -301,15 +298,14 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
301
298
  end
302
299
  end
303
300
 
304
-
305
301
  describe "when changing the host" do
306
302
  def test_ensure_change(options)
307
303
  provider.set(:ensure => options[:from])
308
- provider.expects(:create).times(options[:create] || 0)
309
- provider.expects(:destroy).times(options[:destroy] || 0)
310
- provider.expects(:mount).never
311
- provider.expects(:unmount).times(options[:unmount] || 0)
312
- ensureprop.stubs(:syncothers)
304
+ expect(provider).to receive(:create).exactly(options[:create] || 0).times()
305
+ expect(provider).to receive(:destroy).exactly((options[:destroy] || 0)).times()
306
+ expect(provider).not_to receive(:mount)
307
+ expect(provider).to receive(:unmount).exactly(options[:unmount] || 0).times()
308
+ allow(ensureprop).to receive(:syncothers)
313
309
  ensureprop.should = options[:to]
314
310
  ensureprop.sync
315
311
  expect(!!provider.property_hash[:needs_mount]).to eq(!!options[:mount])
@@ -359,7 +355,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
359
355
  test_ensure_change(:from => :unmounted, :to => :mounted, :mount => 1)
360
356
  end
361
357
 
362
-
363
358
  it "should be in sync if it is :absent and should be :absent" do
364
359
  ensureprop.should = :absent
365
360
  expect(ensureprop.safe_insync?(:absent)).to eq(true)
@@ -400,7 +395,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
400
395
  expect(ensureprop.safe_insync?(:mounted)).to eq(false)
401
396
  end
402
397
 
403
-
404
398
  it "should be out of sync if it is :unmounted and should be :absent" do
405
399
  ensureprop.should = :absent
406
400
  expect(ensureprop.safe_insync?(:unmounted)).to eq(false)
@@ -421,7 +415,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
421
415
  expect(ensureprop.safe_insync?(:unmounted)).to eq(true)
422
416
  end
423
417
 
424
-
425
418
  it "should be out of sync if it is :ghost and should be :absent" do
426
419
  ensureprop.should = :absent
427
420
  expect(ensureprop.safe_insync?(:ghost)).to eq(false)
@@ -447,35 +440,35 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
447
440
  pending "2.6.x specifies slightly different behavior and the desired behavior needs to be clarified and revisited. See ticket #4904" do
448
441
  it "should remount if it is supposed to be mounted" do
449
442
  resource[:ensure] = "mounted"
450
- provider.expects(:remount)
443
+ expect(provider).to receive(:remount)
451
444
 
452
445
  resource.refresh
453
446
  end
454
447
 
455
448
  it "should not remount if it is supposed to be present" do
456
449
  resource[:ensure] = "present"
457
- provider.expects(:remount).never
450
+ expect(provider).not_to receive(:remount)
458
451
 
459
452
  resource.refresh
460
453
  end
461
454
 
462
455
  it "should not remount if it is supposed to be absent" do
463
456
  resource[:ensure] = "absent"
464
- provider.expects(:remount).never
457
+ expect(provider).not_to receive(:remount)
465
458
 
466
459
  resource.refresh
467
460
  end
468
461
 
469
462
  it "should not remount if it is supposed to be defined" do
470
463
  resource[:ensure] = "defined"
471
- provider.expects(:remount).never
464
+ expect(provider).not_to receive(:remount)
472
465
 
473
466
  resource.refresh
474
467
  end
475
468
 
476
469
  it "should not remount if it is supposed to be unmounted" do
477
470
  resource[:ensure] = "unmounted"
478
- provider.expects(:remount).never
471
+ expect(provider).not_to receive(:remount)
479
472
 
480
473
  resource.refresh
481
474
  end
@@ -483,7 +476,7 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
483
476
  it "should not remount swap filesystems" do
484
477
  resource[:ensure] = "mounted"
485
478
  resource[:fstype] = "swap"
486
- provider.expects(:remount).never
479
+ expect(provider).not_to receive(:remount)
487
480
 
488
481
  resource.refresh
489
482
  end
@@ -491,7 +484,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
491
484
  end
492
485
 
493
486
  describe "when modifying an existing mount entry" do
494
-
495
487
  let :initial_values do
496
488
  {
497
489
  :ensure => :mounted,
@@ -506,7 +498,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
506
498
  }
507
499
  end
508
500
 
509
-
510
501
  let :resource do
511
502
  described_class.new(initial_values.merge(:provider => provider))
512
503
  end
@@ -516,14 +507,14 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
516
507
  end
517
508
 
518
509
  def run_in_catalog(*resources)
519
- Puppet::Util::Storage.stubs(:store)
510
+ allow(Puppet::Util::Storage).to receive(:store)
520
511
  catalog = Puppet::Resource::Catalog.new
521
512
  catalog.add_resource(*resources)
522
513
  catalog.apply
523
514
  end
524
515
 
525
516
  it "should use the provider to change the dump value" do
526
- provider.expects(:dump=).with(1)
517
+ expect(provider).to receive(:dump=).with(1)
527
518
 
528
519
  resource[:dump] = 1
529
520
 
@@ -531,12 +522,10 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
531
522
  end
532
523
 
533
524
  it "should umount before flushing changes to disk" do
534
- syncorder = sequence('syncorder')
535
-
536
- provider.expects(:unmount).in_sequence(syncorder)
537
- provider.expects(:options=).in_sequence(syncorder).with 'hard'
538
- resource.expects(:flush).in_sequence(syncorder) # Call inside syncothers
539
- resource.expects(:flush).in_sequence(syncorder) # I guess transaction or anything calls flush again
525
+ expect(provider).to receive(:unmount).ordered()
526
+ expect(provider).to receive(:options=).ordered().with('hard')
527
+ expect(resource).to receive(:flush).ordered() # Call inside syncothers
528
+ expect(resource).to receive(:flush).ordered() # I guess transaction or anything calls flush again
540
529
 
541
530
  resource[:ensure] = :unmounted
542
531
  resource[:options] = 'hard'
@@ -546,7 +535,6 @@ describe Puppet::Type.type(:mount), :unless => Puppet.features.microsoft_windows
546
535
  end
547
536
 
548
537
  describe "establishing autorequires and autobefores" do
549
-
550
538
  def create_mount_resource(path)
551
539
  described_class.new(
552
540
  :name => path,