puppet 5.5.12 → 5.5.13

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (733) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -5
  3. data/Gemfile.lock +11 -11
  4. data/lib/puppet/application/filebucket.rb +4 -0
  5. data/lib/puppet/configurer.rb +9 -3
  6. data/lib/puppet/indirector/request.rb +26 -15
  7. data/lib/puppet/indirector/rest.rb +16 -7
  8. data/lib/puppet/network/http/connection.rb +15 -7
  9. data/lib/puppet/transaction/event_manager.rb +1 -5
  10. data/lib/puppet/type/file/source.rb +0 -1
  11. data/lib/puppet/util/http_proxy.rb +3 -2
  12. data/lib/puppet/version.rb +1 -1
  13. data/locales/puppet.pot +108 -36
  14. data/man/man5/puppet.conf.5 +2 -2
  15. data/man/man8/puppet-agent.8 +1 -1
  16. data/man/man8/puppet-apply.8 +1 -1
  17. data/man/man8/puppet-ca.8 +1 -1
  18. data/man/man8/puppet-catalog.8 +1 -1
  19. data/man/man8/puppet-cert.8 +1 -1
  20. data/man/man8/puppet-certificate.8 +1 -1
  21. data/man/man8/puppet-certificate_request.8 +1 -1
  22. data/man/man8/puppet-certificate_revocation_list.8 +1 -1
  23. data/man/man8/puppet-config.8 +1 -1
  24. data/man/man8/puppet-describe.8 +1 -1
  25. data/man/man8/puppet-device.8 +1 -1
  26. data/man/man8/puppet-doc.8 +1 -1
  27. data/man/man8/puppet-epp.8 +1 -1
  28. data/man/man8/puppet-facts.8 +1 -1
  29. data/man/man8/puppet-filebucket.8 +1 -1
  30. data/man/man8/puppet-generate.8 +1 -1
  31. data/man/man8/puppet-help.8 +1 -1
  32. data/man/man8/puppet-key.8 +1 -1
  33. data/man/man8/puppet-lookup.8 +1 -1
  34. data/man/man8/puppet-man.8 +1 -1
  35. data/man/man8/puppet-master.8 +1 -1
  36. data/man/man8/puppet-module.8 +1 -1
  37. data/man/man8/puppet-node.8 +1 -1
  38. data/man/man8/puppet-parser.8 +1 -1
  39. data/man/man8/puppet-plugin.8 +1 -1
  40. data/man/man8/puppet-report.8 +1 -1
  41. data/man/man8/puppet-resource.8 +1 -1
  42. data/man/man8/puppet-script.8 +1 -1
  43. data/man/man8/puppet-status.8 +1 -1
  44. data/man/man8/puppet.8 +2 -2
  45. data/spec/integration/agent/logging_spec.rb +5 -7
  46. data/spec/integration/application/apply_spec.rb +28 -26
  47. data/spec/integration/application/doc_spec.rb +1 -2
  48. data/spec/integration/application/lookup_spec.rb +5 -5
  49. data/spec/integration/configurer_spec.rb +5 -6
  50. data/spec/integration/defaults_spec.rb +5 -6
  51. data/spec/integration/directory_environments_spec.rb +1 -1
  52. data/spec/integration/faces/ca_spec.rb +2 -3
  53. data/spec/integration/faces/config_spec.rb +3 -4
  54. data/spec/integration/faces/documentation_spec.rb +0 -1
  55. data/spec/integration/faces/plugin_spec.rb +1 -1
  56. data/spec/integration/file_bucket/file_spec.rb +3 -5
  57. data/spec/integration/file_serving/content_spec.rb +0 -1
  58. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  59. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  60. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  61. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  62. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  63. data/spec/integration/indirector/facts/facter_spec.rb +5 -5
  64. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  65. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  66. data/spec/integration/indirector/node/ldap_spec.rb +2 -3
  67. data/spec/integration/network/authconfig_spec.rb +23 -24
  68. data/spec/integration/network/formats_spec.rb +0 -1
  69. data/spec/integration/network/http/api/indirected_routes_spec.rb +0 -1
  70. data/spec/integration/node/environment_spec.rb +0 -1
  71. data/spec/integration/node/facts_spec.rb +9 -10
  72. data/spec/integration/node_spec.rb +6 -7
  73. data/spec/integration/parser/catalog_spec.rb +4 -2
  74. data/spec/integration/parser/collection_spec.rb +1 -2
  75. data/spec/integration/parser/compiler_spec.rb +6 -6
  76. data/spec/integration/parser/scope_spec.rb +1 -1
  77. data/spec/integration/parser/undef_param_spec.rb +1 -1
  78. data/spec/integration/provider/cron/crontab_spec.rb +8 -10
  79. data/spec/integration/provider/mailalias/aliases_spec.rb +0 -1
  80. data/spec/integration/provider/mount_spec.rb +9 -9
  81. data/spec/integration/provider/service/init_spec.rb +4 -5
  82. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  83. data/spec/integration/provider/service/windows_spec.rb +1 -2
  84. data/spec/integration/provider/ssh_authorized_key_spec.rb +6 -8
  85. data/spec/integration/provider/sshkey_spec.rb +6 -12
  86. data/spec/integration/provider/yumrepo_spec.rb +8 -12
  87. data/spec/integration/reference/providers_spec.rb +0 -1
  88. data/spec/integration/reports_spec.rb +1 -2
  89. data/spec/integration/resource/catalog_spec.rb +14 -17
  90. data/spec/integration/resource/type_collection_spec.rb +4 -5
  91. data/spec/integration/ssl/certificate_authority_spec.rb +0 -1
  92. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  93. data/spec/integration/ssl/certificate_revocation_list_spec.rb +0 -1
  94. data/spec/integration/ssl/host_spec.rb +0 -1
  95. data/spec/integration/ssl/key_spec.rb +0 -1
  96. data/spec/integration/test/test_helper_spec.rb +1 -2
  97. data/spec/integration/transaction/report_spec.rb +6 -11
  98. data/spec/integration/transaction_spec.rb +18 -19
  99. data/spec/integration/type/exec_spec.rb +0 -1
  100. data/spec/integration/type/file_spec.rb +13 -14
  101. data/spec/integration/type/nagios_spec.rb +3 -5
  102. data/spec/integration/type/package_spec.rb +19 -23
  103. data/spec/integration/type/tidy_spec.rb +1 -2
  104. data/spec/integration/type/user_spec.rb +0 -1
  105. data/spec/integration/type_spec.rb +0 -1
  106. data/spec/integration/util/autoload_spec.rb +1 -2
  107. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  108. data/spec/integration/util/settings_spec.rb +0 -1
  109. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  110. data/spec/integration/util/windows/principal_spec.rb +0 -1
  111. data/spec/integration/util/windows/process_spec.rb +4 -6
  112. data/spec/integration/util/windows/registry_spec.rb +41 -51
  113. data/spec/integration/util/windows/security_spec.rb +2 -4
  114. data/spec/integration/util/windows/user_spec.rb +18 -20
  115. data/spec/integration/util_spec.rb +4 -7
  116. data/spec/lib/puppet_spec/compiler.rb +1 -1
  117. data/spec/lib/puppet_spec/files.rb +0 -1
  118. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  119. data/spec/lib/puppet_spec/scope.rb +1 -2
  120. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  121. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  122. data/spec/shared_behaviours/file_serving.rb +6 -8
  123. data/spec/shared_behaviours/file_serving_model.rb +4 -6
  124. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  125. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  126. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  127. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  128. data/spec/spec_helper.rb +11 -2
  129. data/spec/unit/agent/disabler_spec.rb +4 -5
  130. data/spec/unit/agent/locker_spec.rb +12 -13
  131. data/spec/unit/agent_spec.rb +80 -85
  132. data/spec/unit/application/agent_spec.rb +88 -93
  133. data/spec/unit/application/apply_spec.rb +78 -79
  134. data/spec/unit/application/cert_spec.rb +42 -49
  135. data/spec/unit/application/certificate_spec.rb +2 -3
  136. data/spec/unit/application/config_spec.rb +0 -1
  137. data/spec/unit/application/describe_spec.rb +6 -7
  138. data/spec/unit/application/device_spec.rb +175 -184
  139. data/spec/unit/application/doc_spec.rb +44 -46
  140. data/spec/unit/application/face_base_spec.rb +61 -62
  141. data/spec/unit/application/facts_spec.rb +3 -4
  142. data/spec/unit/application/filebucket_spec.rb +66 -74
  143. data/spec/unit/application/indirection_base_spec.rb +8 -6
  144. data/spec/unit/application/lookup_spec.rb +26 -26
  145. data/spec/unit/application/master_spec.rb +95 -95
  146. data/spec/unit/application/resource_spec.rb +42 -48
  147. data/spec/unit/application_spec.rb +74 -84
  148. data/spec/unit/capability_spec.rb +9 -6
  149. data/spec/unit/configurer/downloader_spec.rb +20 -21
  150. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  151. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  152. data/spec/unit/configurer_spec.rb +190 -193
  153. data/spec/unit/confine/exists_spec.rb +17 -15
  154. data/spec/unit/confine/false_spec.rb +5 -6
  155. data/spec/unit/confine/feature_spec.rb +7 -5
  156. data/spec/unit/confine/true_spec.rb +5 -6
  157. data/spec/unit/confine/variable_spec.rb +14 -15
  158. data/spec/unit/confine_collection_spec.rb +28 -29
  159. data/spec/unit/confine_spec.rb +13 -14
  160. data/spec/unit/confiner_spec.rb +10 -11
  161. data/spec/unit/context/trusted_information_spec.rb +1 -1
  162. data/spec/unit/daemon_spec.rb +34 -35
  163. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  164. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  165. data/spec/unit/datatypes_spec.rb +3 -4
  166. data/spec/unit/defaults_spec.rb +17 -12
  167. data/spec/unit/environments_spec.rb +7 -7
  168. data/spec/unit/etc_spec.rb +30 -32
  169. data/spec/unit/external/pson_spec.rb +0 -1
  170. data/spec/unit/face/ca_spec.rb +0 -1
  171. data/spec/unit/face/catalog_spec.rb +0 -1
  172. data/spec/unit/face/certificate_request_spec.rb +0 -1
  173. data/spec/unit/face/certificate_revocation_list_spec.rb +0 -1
  174. data/spec/unit/face/certificate_spec.rb +7 -10
  175. data/spec/unit/face/config_spec.rb +31 -35
  176. data/spec/unit/face/epp_face_spec.rb +3 -4
  177. data/spec/unit/face/facts_spec.rb +5 -6
  178. data/spec/unit/face/generate_spec.rb +4 -5
  179. data/spec/unit/face/help_spec.rb +7 -8
  180. data/spec/unit/face/key_spec.rb +0 -1
  181. data/spec/unit/face/man_spec.rb +1 -2
  182. data/spec/unit/face/module/build_spec.rb +17 -17
  183. data/spec/unit/face/module/install_spec.rb +3 -5
  184. data/spec/unit/face/module/list_spec.rb +2 -12
  185. data/spec/unit/face/module/search_spec.rb +11 -9
  186. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  187. data/spec/unit/face/node_spec.rb +33 -34
  188. data/spec/unit/face/parser_spec.rb +3 -3
  189. data/spec/unit/face/plugin_spec.rb +36 -9
  190. data/spec/unit/face/status_spec.rb +0 -1
  191. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  192. data/spec/unit/file_bucket/file_spec.rb +0 -2
  193. data/spec/unit/file_serving/base_spec.rb +16 -17
  194. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  195. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  196. data/spec/unit/file_serving/content_spec.rb +10 -11
  197. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  198. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  199. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  200. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  201. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  202. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  203. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  204. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  205. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  206. data/spec/unit/file_serving/mount_spec.rb +0 -1
  207. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  208. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  209. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  210. data/spec/unit/file_system_spec.rb +2 -2
  211. data/spec/unit/forge/errors_spec.rb +1 -1
  212. data/spec/unit/forge/forge_spec.rb +13 -14
  213. data/spec/unit/forge/module_release_spec.rb +18 -18
  214. data/spec/unit/forge/repository_spec.rb +29 -30
  215. data/spec/unit/forge_spec.rb +15 -11
  216. data/spec/unit/functions/binary_file_spec.rb +3 -3
  217. data/spec/unit/functions/contain_spec.rb +0 -2
  218. data/spec/unit/functions/defined_spec.rb +0 -1
  219. data/spec/unit/functions/epp_spec.rb +2 -2
  220. data/spec/unit/functions/find_file_spec.rb +7 -7
  221. data/spec/unit/functions/include_spec.rb +0 -4
  222. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  223. data/spec/unit/functions/lookup_spec.rb +1 -2
  224. data/spec/unit/functions/module_directory_spec.rb +12 -12
  225. data/spec/unit/functions/require_spec.rb +0 -3
  226. data/spec/unit/functions/shared.rb +5 -8
  227. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  228. data/spec/unit/functions4_spec.rb +7 -8
  229. data/spec/unit/gettext/config_spec.rb +4 -4
  230. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  231. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  232. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  233. data/spec/unit/graph/simple_graph_spec.rb +8 -9
  234. data/spec/unit/hiera_puppet_spec.rb +20 -20
  235. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  236. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  237. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  238. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  239. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/certificate/ca_spec.rb +2 -4
  242. data/spec/unit/indirector/certificate/disabled_ca_spec.rb +1 -2
  243. data/spec/unit/indirector/certificate/file_spec.rb +2 -3
  244. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  245. data/spec/unit/indirector/certificate_request/ca_spec.rb +0 -1
  246. data/spec/unit/indirector/certificate_request/disabled_ca_spec.rb +1 -2
  247. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  248. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  249. data/spec/unit/indirector/certificate_revocation_list/ca_spec.rb +1 -2
  250. data/spec/unit/indirector/certificate_revocation_list/disabled_ca_spec.rb +1 -2
  251. data/spec/unit/indirector/certificate_revocation_list/file_spec.rb +1 -2
  252. data/spec/unit/indirector/certificate_revocation_list/rest_spec.rb +2 -3
  253. data/spec/unit/indirector/certificate_status/file_spec.rb +2 -3
  254. data/spec/unit/indirector/certificate_status/rest_spec.rb +0 -1
  255. data/spec/unit/indirector/code_spec.rb +5 -6
  256. data/spec/unit/indirector/direct_file_server_spec.rb +33 -27
  257. data/spec/unit/indirector/envelope_spec.rb +1 -2
  258. data/spec/unit/indirector/exec_spec.rb +15 -14
  259. data/spec/unit/indirector/face_spec.rb +9 -9
  260. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  261. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  262. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  263. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/facts/yaml_spec.rb +2 -4
  265. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  266. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  267. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  268. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  269. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  270. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  271. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  272. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  273. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  274. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  275. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  276. data/spec/unit/indirector/file_server_spec.rb +99 -93
  277. data/spec/unit/indirector/indirection_spec.rb +242 -226
  278. data/spec/unit/indirector/json_spec.rb +7 -9
  279. data/spec/unit/indirector/key/ca_spec.rb +2 -3
  280. data/spec/unit/indirector/key/disabled_ca_spec.rb +1 -2
  281. data/spec/unit/indirector/key/file_spec.rb +25 -26
  282. data/spec/unit/indirector/ldap_spec.rb +34 -41
  283. data/spec/unit/indirector/memory_spec.rb +6 -7
  284. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  285. data/spec/unit/indirector/node/exec_spec.rb +6 -6
  286. data/spec/unit/indirector/node/ldap_spec.rb +74 -76
  287. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  288. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  289. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  290. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  291. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  292. data/spec/unit/indirector/node/write_only_yaml_spec.rb +1 -2
  293. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  294. data/spec/unit/indirector/none_spec.rb +5 -5
  295. data/spec/unit/indirector/plain_spec.rb +7 -8
  296. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  297. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  298. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  299. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  300. data/spec/unit/indirector/request_spec.rb +11 -12
  301. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  302. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  303. data/spec/unit/indirector/rest_spec.rb +113 -110
  304. data/spec/unit/indirector/ssl_file_spec.rb +74 -77
  305. data/spec/unit/indirector/status/local_spec.rb +0 -1
  306. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  307. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  308. data/spec/unit/indirector/terminus_spec.rb +31 -29
  309. data/spec/unit/indirector/yaml_spec.rb +33 -32
  310. data/spec/unit/indirector_spec.rb +1 -2
  311. data/spec/unit/info_service_spec.rb +3 -1
  312. data/spec/unit/interface/action_builder_spec.rb +0 -1
  313. data/spec/unit/interface/action_manager_spec.rb +0 -1
  314. data/spec/unit/interface/action_spec.rb +2 -3
  315. data/spec/unit/interface/documentation_spec.rb +0 -1
  316. data/spec/unit/interface/face_collection_spec.rb +19 -12
  317. data/spec/unit/interface_spec.rb +3 -3
  318. data/spec/unit/man_spec.rb +3 -4
  319. data/spec/unit/module_spec.rb +46 -51
  320. data/spec/unit/module_tool/applications/builder_spec.rb +5 -5
  321. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  322. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  323. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  324. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  325. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  326. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  327. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  328. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  329. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  330. data/spec/unit/module_tool/tar_spec.rb +12 -13
  331. data/spec/unit/module_tool_spec.rb +7 -12
  332. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  333. data/spec/unit/network/authconfig_spec.rb +17 -18
  334. data/spec/unit/network/authorization_spec.rb +4 -5
  335. data/spec/unit/network/authstore_spec.rb +0 -1
  336. data/spec/unit/network/format_handler_spec.rb +0 -1
  337. data/spec/unit/network/format_spec.rb +9 -10
  338. data/spec/unit/network/format_support_spec.rb +28 -29
  339. data/spec/unit/network/formats_spec.rb +4 -5
  340. data/spec/unit/network/http/api/ca/v1_spec.rb +1 -1
  341. data/spec/unit/network/http/api/indirected_routes_spec.rb +22 -29
  342. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  343. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  344. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  345. data/spec/unit/network/http/api_spec.rb +1 -3
  346. data/spec/unit/network/http/compression_spec.rb +21 -22
  347. data/spec/unit/network/http/connection_spec.rb +39 -36
  348. data/spec/unit/network/http/factory_spec.rb +5 -6
  349. data/spec/unit/network/http/handler_spec.rb +9 -18
  350. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  351. data/spec/unit/network/http/pool_spec.rb +28 -29
  352. data/spec/unit/network/http/rack/rest_spec.rb +24 -27
  353. data/spec/unit/network/http/rack_spec.rb +5 -6
  354. data/spec/unit/network/http/request_spec.rb +0 -2
  355. data/spec/unit/network/http/response_spec.rb +11 -13
  356. data/spec/unit/network/http/route_spec.rb +0 -1
  357. data/spec/unit/network/http/session_spec.rb +1 -2
  358. data/spec/unit/network/http/site_spec.rb +0 -1
  359. data/spec/unit/network/http/webrick/rest_spec.rb +40 -41
  360. data/spec/unit/network/http/webrick_spec.rb +49 -52
  361. data/spec/unit/network/http_pool_spec.rb +18 -9
  362. data/spec/unit/network/http_spec.rb +0 -1
  363. data/spec/unit/network/resolver_spec.rb +16 -17
  364. data/spec/unit/network/rights_spec.rb +52 -53
  365. data/spec/unit/network/server_spec.rb +12 -13
  366. data/spec/unit/node/environment_spec.rb +16 -14
  367. data/spec/unit/node/facts_spec.rb +5 -7
  368. data/spec/unit/node_spec.rb +4 -10
  369. data/spec/unit/other/selinux_spec.rb +2 -3
  370. data/spec/unit/parameter/boolean_spec.rb +1 -2
  371. data/spec/unit/parameter/package_options_spec.rb +1 -2
  372. data/spec/unit/parameter/path_spec.rb +0 -1
  373. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  374. data/spec/unit/parameter/value_spec.rb +0 -1
  375. data/spec/unit/parameter_spec.rb +9 -9
  376. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  377. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  378. data/spec/unit/parser/compiler_spec.rb +84 -96
  379. data/spec/unit/parser/environment_compiler_spec.rb +11 -9
  380. data/spec/unit/parser/files_spec.rb +0 -1
  381. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  382. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  383. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  384. data/spec/unit/parser/functions/file_spec.rb +13 -14
  385. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  386. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  387. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  388. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  389. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  390. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  391. data/spec/unit/parser/functions/split_spec.rb +0 -1
  392. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  393. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  394. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  395. data/spec/unit/parser/functions/template_spec.rb +13 -13
  396. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  397. data/spec/unit/parser/functions_spec.rb +3 -4
  398. data/spec/unit/parser/relationship_spec.rb +0 -1
  399. data/spec/unit/parser/resource_spec.rb +42 -42
  400. data/spec/unit/parser/scope_spec.rb +39 -35
  401. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  402. data/spec/unit/parser/type_loader_spec.rb +17 -19
  403. data/spec/unit/pops/adaptable_spec.rb +0 -1
  404. data/spec/unit/pops/benchmark_spec.rb +0 -1
  405. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  406. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  407. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  408. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  409. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  410. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  411. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +6 -6
  412. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  413. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  414. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  415. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  416. data/spec/unit/pops/factory_spec.rb +3 -4
  417. data/spec/unit/pops/issues_spec.rb +19 -20
  418. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  419. data/spec/unit/pops/loaders/loaders_spec.rb +30 -27
  420. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  421. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  422. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  423. data/spec/unit/pops/migration_spec.rb +3 -5
  424. data/spec/unit/pops/model/model_spec.rb +0 -1
  425. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  426. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  427. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  428. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  429. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  430. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  431. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  432. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  433. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  434. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  435. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  436. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  437. data/spec/unit/pops/pn_spec.rb +0 -1
  438. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  439. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  440. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  441. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  442. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  443. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  444. data/spec/unit/pops/types/type_calculator_spec.rb +36 -36
  445. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  446. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  447. data/spec/unit/pops/visitor_spec.rb +0 -1
  448. data/spec/unit/property/boolean_spec.rb +1 -1
  449. data/spec/unit/property/ensure_spec.rb +0 -1
  450. data/spec/unit/property/keyvalue_spec.rb +32 -34
  451. data/spec/unit/property/list_spec.rb +26 -27
  452. data/spec/unit/property/ordered_list_spec.rb +10 -14
  453. data/spec/unit/property_spec.rb +42 -43
  454. data/spec/unit/provider/aix_object_spec.rb +47 -45
  455. data/spec/unit/provider/augeas/augeas_spec.rb +192 -192
  456. data/spec/unit/provider/cisco_spec.rb +1 -2
  457. data/spec/unit/provider/command_spec.rb +9 -9
  458. data/spec/unit/provider/cron/crontab_spec.rb +10 -11
  459. data/spec/unit/provider/cron/parsed_spec.rb +22 -24
  460. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  461. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  462. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  463. data/spec/unit/provider/exec_spec.rb +0 -1
  464. data/spec/unit/provider/file/posix_spec.rb +22 -24
  465. data/spec/unit/provider/file/windows_spec.rb +15 -17
  466. data/spec/unit/provider/group/aix_spec.rb +3 -2
  467. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  468. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  469. data/spec/unit/provider/group/pw_spec.rb +11 -11
  470. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  471. data/spec/unit/provider/host/parsed_spec.rb +6 -6
  472. data/spec/unit/provider/interface/cisco_spec.rb +20 -24
  473. data/spec/unit/provider/ldap_spec.rb +61 -62
  474. data/spec/unit/provider/macauthorization_spec.rb +26 -47
  475. data/spec/unit/provider/mcx/mcxcontent_spec.rb +45 -47
  476. data/spec/unit/provider/mount/parsed_spec.rb +18 -24
  477. data/spec/unit/provider/mount_spec.rb +57 -66
  478. data/spec/unit/provider/naginator_spec.rb +13 -14
  479. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  480. data/spec/unit/provider/nameservice_spec.rb +38 -40
  481. data/spec/unit/provider/network_device_spec.rb +28 -28
  482. data/spec/unit/provider/package/aix_spec.rb +15 -15
  483. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  484. data/spec/unit/provider/package/apt_spec.rb +44 -27
  485. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  486. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  487. data/spec/unit/provider/package/base_spec.rb +4 -4
  488. data/spec/unit/provider/package/dnf_spec.rb +14 -16
  489. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  490. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  491. data/spec/unit/provider/package/gem_spec.rb +51 -43
  492. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  493. data/spec/unit/provider/package/macports_spec.rb +46 -42
  494. data/spec/unit/provider/package/nim_spec.rb +30 -39
  495. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  496. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  497. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  498. data/spec/unit/provider/package/pip_spec.rb +69 -71
  499. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  500. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  501. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  502. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  503. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  504. data/spec/unit/provider/package/portage_spec.rb +70 -74
  505. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  506. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  507. data/spec/unit/provider/package/sun_spec.rb +16 -18
  508. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  509. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  510. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  511. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  512. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  513. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  514. data/spec/unit/provider/package/windows_spec.rb +36 -32
  515. data/spec/unit/provider/package/yum_spec.rb +4 -4
  516. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  517. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  518. data/spec/unit/provider/scheduled_task/win32_taskscheduler_spec.rb +120 -130
  519. data/spec/unit/provider/selboolean_spec.rb +9 -11
  520. data/spec/unit/provider/selmodule_spec.rb +20 -22
  521. data/spec/unit/provider/service/base_spec.rb +4 -5
  522. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  523. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  524. data/spec/unit/provider/service/debian_spec.rb +37 -37
  525. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  526. data/spec/unit/provider/service/gentoo_spec.rb +50 -56
  527. data/spec/unit/provider/service/init_spec.rb +55 -55
  528. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  529. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  530. data/spec/unit/provider/service/openrc_spec.rb +43 -46
  531. data/spec/unit/provider/service/openwrt_spec.rb +26 -32
  532. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  533. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  534. data/spec/unit/provider/service/runit_spec.rb +29 -27
  535. data/spec/unit/provider/service/smf_spec.rb +74 -66
  536. data/spec/unit/provider/service/src_spec.rb +46 -47
  537. data/spec/unit/provider/service/systemd_spec.rb +93 -98
  538. data/spec/unit/provider/service/upstart_spec.rb +74 -72
  539. data/spec/unit/provider/service/windows_spec.rb +33 -41
  540. data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb +54 -68
  541. data/spec/unit/provider/sshkey/parsed_spec.rb +7 -8
  542. data/spec/unit/provider/user/aix_spec.rb +31 -31
  543. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  544. data/spec/unit/provider/user/hpux_spec.rb +15 -15
  545. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  546. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  547. data/spec/unit/provider/user/pw_spec.rb +37 -35
  548. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  549. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  550. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  551. data/spec/unit/provider/vlan/cisco_spec.rb +10 -12
  552. data/spec/unit/provider/yumrepo/inifile_spec.rb +75 -80
  553. data/spec/unit/provider/zfs/zfs_spec.rb +26 -21
  554. data/spec/unit/provider/zone/solaris_spec.rb +56 -42
  555. data/spec/unit/provider/zpool/zpool_spec.rb +19 -20
  556. data/spec/unit/provider_spec.rb +29 -29
  557. data/spec/unit/puppet_pal_2pec.rb +4 -5
  558. data/spec/unit/puppet_pal_spec.rb +0 -1
  559. data/spec/unit/puppet_spec.rb +7 -8
  560. data/spec/unit/relationship_spec.rb +0 -1
  561. data/spec/unit/reports/http_spec.rb +21 -23
  562. data/spec/unit/reports/store_spec.rb +3 -4
  563. data/spec/unit/reports_spec.rb +12 -14
  564. data/spec/unit/resource/capability_finder_spec.rb +18 -16
  565. data/spec/unit/resource/catalog_spec.rb +72 -68
  566. data/spec/unit/resource/status_spec.rb +6 -8
  567. data/spec/unit/resource/type_collection_spec.rb +17 -18
  568. data/spec/unit/resource/type_spec.rb +34 -35
  569. data/spec/unit/resource_spec.rb +36 -32
  570. data/spec/unit/scheduler/job_spec.rb +0 -1
  571. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  572. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  573. data/spec/unit/settings/array_setting_spec.rb +1 -1
  574. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  575. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  576. data/spec/unit/settings/config_file_spec.rb +0 -1
  577. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  578. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  579. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  580. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  581. data/spec/unit/settings/file_setting_spec.rb +44 -46
  582. data/spec/unit/settings/path_setting_spec.rb +1 -2
  583. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  584. data/spec/unit/settings/string_setting_spec.rb +14 -15
  585. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  586. data/spec/unit/settings/value_translator_spec.rb +0 -1
  587. data/spec/unit/settings_spec.rb +226 -233
  588. data/spec/unit/ssl/base_spec.rb +14 -15
  589. data/spec/unit/ssl/certificate_authority/autosign_command_spec.rb +6 -7
  590. data/spec/unit/ssl/certificate_authority/interface_spec.rb +116 -113
  591. data/spec/unit/ssl/certificate_authority_spec.rb +258 -268
  592. data/spec/unit/ssl/certificate_factory_spec.rb +3 -5
  593. data/spec/unit/ssl/certificate_request_attributes_spec.rb +2 -3
  594. data/spec/unit/ssl/certificate_request_spec.rb +66 -67
  595. data/spec/unit/ssl/certificate_revocation_list_spec.rb +3 -4
  596. data/spec/unit/ssl/certificate_spec.rb +23 -25
  597. data/spec/unit/ssl/configuration_spec.rb +1 -4
  598. data/spec/unit/ssl/digest_spec.rb +0 -1
  599. data/spec/unit/ssl/host_spec.rb +217 -188
  600. data/spec/unit/ssl/inventory_spec.rb +25 -21
  601. data/spec/unit/ssl/key_spec.rb +30 -31
  602. data/spec/unit/ssl/validator_spec.rb +40 -40
  603. data/spec/unit/task_spec.rb +6 -7
  604. data/spec/unit/transaction/additional_resource_generator_spec.rb +6 -5
  605. data/spec/unit/transaction/event_manager_spec.rb +88 -88
  606. data/spec/unit/transaction/event_spec.rb +16 -15
  607. data/spec/unit/transaction/persistence_spec.rb +16 -17
  608. data/spec/unit/transaction/report_spec.rb +11 -12
  609. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  610. data/spec/unit/transaction_spec.rb +98 -100
  611. data/spec/unit/type/augeas_spec.rb +11 -10
  612. data/spec/unit/type/component_spec.rb +0 -1
  613. data/spec/unit/type/computer_spec.rb +7 -10
  614. data/spec/unit/type/cron_spec.rb +3 -7
  615. data/spec/unit/type/exec_spec.rb +60 -56
  616. data/spec/unit/type/file/checksum_spec.rb +9 -10
  617. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  618. data/spec/unit/type/file/content_spec.rb +58 -61
  619. data/spec/unit/type/file/ctime_spec.rb +0 -1
  620. data/spec/unit/type/file/ensure_spec.rb +12 -13
  621. data/spec/unit/type/file/group_spec.rb +5 -7
  622. data/spec/unit/type/file/mode_spec.rb +4 -6
  623. data/spec/unit/type/file/mtime_spec.rb +0 -1
  624. data/spec/unit/type/file/owner_spec.rb +6 -8
  625. data/spec/unit/type/file/selinux_spec.rb +17 -19
  626. data/spec/unit/type/file/source_spec.rb +104 -101
  627. data/spec/unit/type/file/type_spec.rb +0 -1
  628. data/spec/unit/type/file_spec.rb +195 -185
  629. data/spec/unit/type/filebucket_spec.rb +4 -5
  630. data/spec/unit/type/group_spec.rb +6 -8
  631. data/spec/unit/type/host_spec.rb +2 -3
  632. data/spec/unit/type/interface_spec.rb +2 -3
  633. data/spec/unit/type/k5login_spec.rb +3 -4
  634. data/spec/unit/type/macauthorization_spec.rb +6 -8
  635. data/spec/unit/type/mailalias_spec.rb +2 -3
  636. data/spec/unit/type/maillist_spec.rb +6 -9
  637. data/spec/unit/type/mcx_spec.rb +4 -8
  638. data/spec/unit/type/mount_spec.rb +26 -38
  639. data/spec/unit/type/nagios_spec.rb +0 -1
  640. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  641. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  642. data/spec/unit/type/package_spec.rb +53 -54
  643. data/spec/unit/type/resources_spec.rb +86 -88
  644. data/spec/unit/type/schedule_spec.rb +24 -26
  645. data/spec/unit/type/scheduled_task_spec.rb +1 -2
  646. data/spec/unit/type/selboolean_spec.rb +5 -6
  647. data/spec/unit/type/selmodule_spec.rb +0 -1
  648. data/spec/unit/type/service_spec.rb +47 -47
  649. data/spec/unit/type/ssh_authorized_key_spec.rb +5 -35
  650. data/spec/unit/type/sshkey_spec.rb +0 -2
  651. data/spec/unit/type/stage_spec.rb +0 -1
  652. data/spec/unit/type/tidy_spec.rb +61 -62
  653. data/spec/unit/type/user_spec.rb +41 -27
  654. data/spec/unit/type/vlan_spec.rb +2 -4
  655. data/spec/unit/type/whit_spec.rb +0 -1
  656. data/spec/unit/type/zfs_spec.rb +6 -7
  657. data/spec/unit/type/zone_spec.rb +14 -4
  658. data/spec/unit/type/zpool_spec.rb +4 -5
  659. data/spec/unit/type_spec.rb +54 -53
  660. data/spec/unit/util/at_fork_spec.rb +18 -19
  661. data/spec/unit/util/autoload_spec.rb +53 -54
  662. data/spec/unit/util/backups_spec.rb +34 -35
  663. data/spec/unit/util/character_encoding_spec.rb +8 -8
  664. data/spec/unit/util/checksums_spec.rb +38 -39
  665. data/spec/unit/util/colors_spec.rb +1 -2
  666. data/spec/unit/util/command_line_spec.rb +24 -25
  667. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  668. data/spec/unit/util/diff_spec.rb +7 -8
  669. data/spec/unit/util/errors_spec.rb +0 -1
  670. data/spec/unit/util/execution_spec.rb +187 -162
  671. data/spec/unit/util/execution_stub_spec.rb +0 -1
  672. data/spec/unit/util/feature_spec.rb +13 -13
  673. data/spec/unit/util/filetype_spec.rb +49 -49
  674. data/spec/unit/util/http_proxy_spec.rb +12 -12
  675. data/spec/unit/util/inifile_spec.rb +26 -31
  676. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  677. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  678. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  679. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  680. data/spec/unit/util/lockfile_spec.rb +0 -1
  681. data/spec/unit/util/log/destinations_spec.rb +30 -33
  682. data/spec/unit/util/log_spec.rb +35 -36
  683. data/spec/unit/util/logging_spec.rb +58 -66
  684. data/spec/unit/util/metric_spec.rb +0 -1
  685. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  686. data/spec/unit/util/multi_match_spec.rb +0 -1
  687. data/spec/unit/util/nagios_maker_spec.rb +35 -36
  688. data/spec/unit/util/network_device/cisco/device_spec.rb +59 -50
  689. data/spec/unit/util/network_device/cisco/facts_spec.rb +4 -5
  690. data/spec/unit/util/network_device/cisco/interface_spec.rb +29 -20
  691. data/spec/unit/util/network_device/config_spec.rb +0 -1
  692. data/spec/unit/util/network_device/ipcalc_spec.rb +0 -1
  693. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  694. data/spec/unit/util/network_device/transport/ssh_spec.rb +94 -60
  695. data/spec/unit/util/network_device/transport/telnet_spec.rb +18 -14
  696. data/spec/unit/util/network_device_spec.rb +7 -9
  697. data/spec/unit/util/package_spec.rb +0 -1
  698. data/spec/unit/util/pidlock_spec.rb +13 -14
  699. data/spec/unit/util/plist_spec.rb +40 -33
  700. data/spec/unit/util/posix_spec.rb +54 -51
  701. data/spec/unit/util/rdoc_spec.rb +9 -10
  702. data/spec/unit/util/reference_spec.rb +0 -1
  703. data/spec/unit/util/resource_template_spec.rb +20 -20
  704. data/spec/unit/util/retry_action_spec.rb +7 -8
  705. data/spec/unit/util/rubygems_spec.rb +14 -14
  706. data/spec/unit/util/run_mode_spec.rb +3 -4
  707. data/spec/unit/util/selinux_spec.rb +79 -72
  708. data/spec/unit/util/splayer_spec.rb +8 -9
  709. data/spec/unit/util/ssl_spec.rb +0 -1
  710. data/spec/unit/util/storage_spec.rb +3 -4
  711. data/spec/unit/util/suidmanager_spec.rb +45 -54
  712. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  713. data/spec/unit/util/tag_set_spec.rb +0 -1
  714. data/spec/unit/util/tagging_spec.rb +0 -1
  715. data/spec/unit/util/terminal_spec.rb +9 -10
  716. data/spec/unit/util/user_attr_spec.rb +1 -2
  717. data/spec/unit/util/warnings_spec.rb +3 -4
  718. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  719. data/spec/unit/util/watcher_spec.rb +51 -21
  720. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  721. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  722. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  723. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  724. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  725. data/spec/unit/util/windows/file_spec.rb +0 -1
  726. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  727. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  728. data/spec/unit/util/windows/service_spec.rb +66 -68
  729. data/spec/unit/util/windows/sid_spec.rb +11 -13
  730. data/spec/unit/util/windows/string_spec.rb +0 -1
  731. data/spec/unit/util_spec.rb +55 -59
  732. data/spec/unit/version_spec.rb +6 -6
  733. metadata +2 -2
@@ -1,16 +1,15 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/application/facts'
4
3
 
5
4
  describe Puppet::Application::Facts do
6
5
  before :each do
7
- subject.command_line.stubs(:subcommand_name).returns 'facts'
6
+ allow(subject.command_line).to receive(:subcommand_name).and_return('facts')
8
7
  end
9
8
 
10
9
  it "should return facts if a key is given to find" do
11
10
  Puppet::Node::Facts.indirection.reset_terminus_class
12
- Puppet::Node::Facts.indirection.expects(:find).returns(Puppet::Node::Facts.new('whatever', {}))
13
- subject.command_line.stubs(:args).returns %w{find whatever --render-as yaml}
11
+ expect(Puppet::Node::Facts.indirection).to receive(:find).and_return(Puppet::Node::Facts.new('whatever', {}))
12
+ allow(subject.command_line).to receive(:args).and_return(%w{find whatever --render-as yaml})
14
13
 
15
14
  expect {
16
15
  expect {
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/application/filebucket'
@@ -35,53 +34,51 @@ describe Puppet::Application::Filebucket do
35
34
  end
36
35
 
37
36
  it "should store argument value when calling handle_#{option}" do
38
- @filebucket.options.expects(:[]=).with("#{option}".to_sym, 'arg')
37
+ expect(@filebucket.options).to receive(:[]=).with("#{option}".to_sym, 'arg')
39
38
  @filebucket.send("handle_#{option}".to_sym, 'arg')
40
39
  end
41
40
  end
42
41
 
43
42
  describe "during setup" do
44
-
45
43
  before :each do
46
- Puppet::Log.stubs(:newdestination)
47
- Puppet.stubs(:settraps)
48
- Puppet::FileBucket::Dipper.stubs(:new)
49
- @filebucket.options.stubs(:[]).with(any_parameters)
44
+ allow(Puppet::Log).to receive(:newdestination)
45
+ allow(Puppet).to receive(:settraps)
46
+ allow(Puppet::FileBucket::Dipper).to receive(:new)
47
+ allow(@filebucket.options).to receive(:[])
50
48
  end
51
49
 
52
-
53
50
  it "should set console as the log destination" do
54
- Puppet::Log.expects(:newdestination).with(:console)
51
+ expect(Puppet::Log).to receive(:newdestination).with(:console)
55
52
 
56
53
  @filebucket.setup
57
54
  end
58
55
 
59
56
  it "should trap INT" do
60
- Signal.expects(:trap).with(:INT)
57
+ expect(Signal).to receive(:trap).with(:INT)
61
58
 
62
59
  @filebucket.setup
63
60
  end
64
61
 
65
62
  it "should set log level to debug if --debug was passed" do
66
- @filebucket.options.stubs(:[]).with(:debug).returns(true)
63
+ allow(@filebucket.options).to receive(:[]).with(:debug).and_return(true)
67
64
  @filebucket.setup
68
65
  expect(Puppet::Log.level).to eq(:debug)
69
66
  end
70
67
 
71
68
  it "should set log level to info if --verbose was passed" do
72
- @filebucket.options.stubs(:[]).with(:verbose).returns(true)
69
+ allow(@filebucket.options).to receive(:[]).with(:verbose).and_return(true)
73
70
  @filebucket.setup
74
71
  expect(Puppet::Log.level).to eq(:info)
75
72
  end
76
73
 
77
74
  it "should print puppet config if asked to in Puppet config" do
78
- Puppet.settings.stubs(:print_configs?).returns(true)
79
- Puppet.settings.expects(:print_configs).returns(true)
75
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
76
+ expect(Puppet.settings).to receive(:print_configs).and_return(true)
80
77
  expect { @filebucket.setup }.to exit_with 0
81
78
  end
82
79
 
83
80
  it "should exit after printing puppet config if asked to in Puppet config" do
84
- Puppet.settings.stubs(:print_configs?).returns(true)
81
+ allow(Puppet.settings).to receive(:print_configs?).and_return(true)
85
82
  expect { @filebucket.setup }.to exit_with 1
86
83
  end
87
84
 
@@ -89,123 +86,119 @@ describe Puppet::Application::Filebucket do
89
86
  let(:path) { File.expand_path("path") }
90
87
 
91
88
  before :each do
92
- @filebucket.options.stubs(:[]).with(:local).returns(true)
89
+ allow(@filebucket.options).to receive(:[]).with(:local).and_return(true)
93
90
  end
94
91
 
95
92
  it "should create a client with the default bucket if none passed" do
96
93
  Puppet[:clientbucketdir] = path
97
94
  Puppet[:bucketdir] = path + "2"
98
95
 
99
- Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Path] == path }
96
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Path: path))
100
97
 
101
98
  @filebucket.setup
102
99
  end
103
100
 
104
101
  it "should create a local Dipper with the given bucket" do
105
- @filebucket.options.stubs(:[]).with(:bucket).returns(path)
102
+ allow(@filebucket.options).to receive(:[]).with(:bucket).and_return(path)
106
103
 
107
- Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Path] == path }
104
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Path: path))
108
105
 
109
106
  @filebucket.setup
110
107
  end
111
-
112
108
  end
113
109
 
114
110
  describe "with remote bucket" do
115
111
  it "should create a remote Client to the configured server" do
116
112
  Puppet[:server] = "puppet.reductivelabs.com"
117
- Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Server] == "puppet.reductivelabs.com" }
113
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Server: "puppet.reductivelabs.com"))
118
114
  @filebucket.setup
119
115
  end
120
116
 
121
117
  it "should default to the first server_list entry if set" do
122
118
  Puppet[:server_list] = "foo,bar,baz"
123
- Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Server] == "foo" }
119
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Server: "foo"))
124
120
  @filebucket.setup
125
121
  end
126
122
 
127
123
  it "should fall back to server if server_list is empty" do
128
124
  Puppet[:server_list] = ""
129
- Puppet::FileBucket::Dipper.expects(:new).with { |h| h[:Server] == "puppet" }
125
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with(hash_including(Server: "puppet"))
130
126
  @filebucket.setup
131
127
  end
132
128
 
133
129
  it "should take both the server and port specified in server_list" do
134
130
  Puppet[:server_list] = "foo:632,bar:6215,baz:351"
135
- Puppet::FileBucket::Dipper.expects(:new).with({ :Server => "foo", :Port => "632" })
131
+ expect(Puppet::FileBucket::Dipper).to receive(:new).with({ :Server => "foo", :Port => "632" })
136
132
  @filebucket.setup
137
133
  end
138
134
  end
139
135
  end
140
136
 
141
137
  describe "when running" do
142
-
143
138
  before :each do
144
- Puppet::Log.stubs(:newdestination)
145
- Puppet.stubs(:settraps)
146
- Puppet::FileBucket::Dipper.stubs(:new)
147
- @filebucket.options.stubs(:[]).with(any_parameters)
139
+ allow(Puppet::Log).to receive(:newdestination)
140
+ allow(Puppet).to receive(:settraps)
141
+ allow(Puppet::FileBucket::Dipper).to receive(:new)
142
+ allow(@filebucket.options).to receive(:[])
148
143
 
149
- @client = stub 'client'
150
- Puppet::FileBucket::Dipper.stubs(:new).returns(@client)
144
+ @client = double('client')
145
+ allow(Puppet::FileBucket::Dipper).to receive(:new).and_return(@client)
151
146
 
152
147
  @filebucket.setup
153
148
  end
154
149
 
155
150
  it "should use the first non-option parameter as the dispatch" do
156
- @filebucket.command_line.stubs(:args).returns(['get'])
151
+ allow(@filebucket.command_line).to receive(:args).and_return(['get'])
157
152
 
158
- @filebucket.expects(:get)
153
+ expect(@filebucket).to receive(:get)
159
154
 
160
155
  @filebucket.run_command
161
156
  end
162
157
 
163
158
  describe "the command get" do
164
-
165
159
  before :each do
166
- @filebucket.stubs(:print)
167
- @filebucket.stubs(:args).returns([])
160
+ allow(@filebucket).to receive(:print)
161
+ allow(@filebucket).to receive(:args).and_return([])
168
162
  end
169
163
 
170
164
  it "should call the client getfile method" do
171
- @client.expects(:getfile)
165
+ expect(@client).to receive(:getfile)
172
166
 
173
167
  @filebucket.get
174
168
  end
175
169
 
176
170
  it "should call the client getfile method with the given md5" do
177
171
  md5="DEADBEEF"
178
- @filebucket.stubs(:args).returns([md5])
172
+ allow(@filebucket).to receive(:args).and_return([md5])
179
173
 
180
- @client.expects(:getfile).with(md5)
174
+ expect(@client).to receive(:getfile).with(md5)
181
175
 
182
176
  @filebucket.get
183
177
  end
184
178
 
185
179
  it "should print the file content" do
186
- @client.stubs(:getfile).returns("content")
180
+ allow(@client).to receive(:getfile).and_return("content")
187
181
 
188
- @filebucket.expects(:print).returns("content")
182
+ expect(@filebucket).to receive(:print).and_return("content")
189
183
 
190
184
  @filebucket.get
191
185
  end
192
-
193
186
  end
194
187
 
195
188
  describe "the command backup" do
196
189
  it "should fail if no arguments are specified" do
197
- @filebucket.stubs(:args).returns([])
190
+ allow(@filebucket).to receive(:args).and_return([])
198
191
  expect { @filebucket.backup }.to raise_error(RuntimeError, /You must specify a file to back up/)
199
192
  end
200
193
 
201
194
  it "should call the client backup method for each given parameter" do
202
- @filebucket.stubs(:puts)
203
- Puppet::FileSystem.stubs(:exist?).returns(true)
204
- FileTest.stubs(:readable?).returns(true)
205
- @filebucket.stubs(:args).returns(["file1", "file2"])
195
+ allow(@filebucket).to receive(:puts)
196
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
197
+ allow(FileTest).to receive(:readable?).and_return(true)
198
+ allow(@filebucket).to receive(:args).and_return(["file1", "file2"])
206
199
 
207
- @client.expects(:backup).with("file1")
208
- @client.expects(:backup).with("file2")
200
+ expect(@client).to receive(:backup).with("file1")
201
+ expect(@client).to receive(:backup).with("file2")
209
202
 
210
203
  @filebucket.backup
211
204
  end
@@ -215,9 +208,9 @@ describe Puppet::Application::Filebucket do
215
208
  it "should call the client getfile method with the given md5" do
216
209
  md5="DEADBEEF"
217
210
  file="testfile"
218
- @filebucket.stubs(:args).returns([file, md5])
211
+ allow(@filebucket).to receive(:args).and_return([file, md5])
219
212
 
220
- @client.expects(:restore).with(file,md5)
213
+ expect(@client).to receive(:restore).with(file,md5)
221
214
 
222
215
  @filebucket.restore
223
216
  end
@@ -227,10 +220,10 @@ describe Puppet::Application::Filebucket do
227
220
  it "should call the client diff method with 2 given checksums" do
228
221
  md5a="DEADBEEF"
229
222
  md5b="BEEF"
230
- Puppet::FileSystem.stubs(:exist?).returns(false)
231
- @filebucket.stubs(:args).returns([md5a, md5b])
223
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(false)
224
+ allow(@filebucket).to receive(:args).and_return([md5a, md5b])
232
225
 
233
- @client.expects(:diff).with(md5a,md5b, nil, nil)
226
+ expect(@client).to receive(:diff).with(md5a,md5b, nil, nil)
234
227
 
235
228
  @filebucket.diff
236
229
  end
@@ -238,11 +231,11 @@ describe Puppet::Application::Filebucket do
238
231
  it "should call the clien diff with a path if the second argument is a file" do
239
232
  md5a="DEADBEEF"
240
233
  md5b="BEEF"
241
- Puppet::FileSystem.stubs(:exist?).with(md5a).returns(false)
242
- Puppet::FileSystem.stubs(:exist?).with(md5b).returns(true)
243
- @filebucket.stubs(:args).returns([md5a, md5b])
234
+ allow(Puppet::FileSystem).to receive(:exist?).with(md5a).and_return(false)
235
+ allow(Puppet::FileSystem).to receive(:exist?).with(md5b).and_return(true)
236
+ allow(@filebucket).to receive(:args).and_return([md5a, md5b])
244
237
 
245
- @client.expects(:diff).with(md5a, nil, nil, md5b)
238
+ expect(@client).to receive(:diff).with(md5a, nil, nil, md5b)
246
239
 
247
240
  @filebucket.diff
248
241
  end
@@ -250,11 +243,11 @@ describe Puppet::Application::Filebucket do
250
243
  it "should call the clien diff with a path if the first argument is a file" do
251
244
  md5a="DEADBEEF"
252
245
  md5b="BEEF"
253
- Puppet::FileSystem.stubs(:exist?).with(md5a).returns(true)
254
- Puppet::FileSystem.stubs(:exist?).with(md5b).returns(false)
255
- @filebucket.stubs(:args).returns([md5a, md5b])
246
+ allow(Puppet::FileSystem).to receive(:exist?).with(md5a).and_return(true)
247
+ allow(Puppet::FileSystem).to receive(:exist?).with(md5b).and_return(false)
248
+ allow(@filebucket).to receive(:args).and_return([md5a, md5b])
256
249
 
257
- @client.expects(:diff).with(nil, md5b, md5a, nil)
250
+ expect(@client).to receive(:diff).with(nil, md5b, md5a, nil)
258
251
 
259
252
  @filebucket.diff
260
253
  end
@@ -262,28 +255,30 @@ describe Puppet::Application::Filebucket do
262
255
  it "should call the clien diff with paths if the both arguments are files" do
263
256
  md5a="DEADBEEF"
264
257
  md5b="BEEF"
265
- Puppet::FileSystem.stubs(:exist?).with(md5a).returns(true)
266
- Puppet::FileSystem.stubs(:exist?).with(md5b).returns(true)
267
- @filebucket.stubs(:args).returns([md5a, md5b])
258
+ allow(Puppet::FileSystem).to receive(:exist?).with(md5a).and_return(true)
259
+ allow(Puppet::FileSystem).to receive(:exist?).with(md5b).and_return(true)
260
+ allow(@filebucket).to receive(:args).and_return([md5a, md5b])
268
261
 
269
- @client.expects(:diff).with(nil, nil, md5a, md5b)
262
+ expect(@client).to receive(:diff).with(nil, nil, md5a, md5b)
270
263
 
271
264
  @filebucket.diff
272
265
  end
273
266
 
274
267
  it "should fail if only one checksum is given" do
275
268
  md5a="DEADBEEF"
276
- @filebucket.stubs(:args).returns([md5a])
269
+ allow(@filebucket).to receive(:args).and_return([md5a])
277
270
 
278
271
  expect { @filebucket.diff }.to raise_error Puppet::Error
279
272
  end
280
273
  end
274
+
281
275
  describe "the command list" do
282
276
  it "should call the client list method with nil dates" do
283
- @client.expects(:list).with(nil, nil)
277
+ expect(@client).to receive(:list).with(nil, nil)
284
278
 
285
279
  @filebucket.list
286
280
  end
281
+
287
282
  it "should call the client list method with the given dates" do
288
283
  # 3 Hours ago
289
284
  threehours = 60*60*3
@@ -292,16 +287,13 @@ describe Puppet::Application::Filebucket do
292
287
  onehour = 60*60
293
288
  todate = (Time.now - onehour).strftime("%F %T")
294
289
 
295
- @filebucket.options.stubs(:[]).with(:fromdate).returns(fromdate)
296
- @filebucket.options.stubs(:[]).with(:todate).returns(todate)
290
+ allow(@filebucket.options).to receive(:[]).with(:fromdate).and_return(fromdate)
291
+ allow(@filebucket.options).to receive(:[]).with(:todate).and_return(todate)
297
292
 
298
- @client.expects(:list).with(fromdate, todate)
293
+ expect(@client).to receive(:list).with(fromdate, todate)
299
294
 
300
295
  @filebucket.list
301
296
  end
302
297
  end
303
-
304
298
  end
305
-
306
-
307
299
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/util/command_line'
4
3
  require 'puppet/application/indirection_base'
@@ -32,11 +31,14 @@ describe Puppet::Application::IndirectionBase do
32
31
  it "should accept a terminus command line option" do
33
32
  # It would be nice not to have to stub this, but whatever... writing an
34
33
  # entire indirection stack would cause us more grief. --daniel 2011-03-31
35
- terminus = stub_everything("test indirection terminus")
36
- terminus.stubs(:name).returns(:test_indirection)
37
-
38
- Puppet::Indirector::Indirection.expects(:instance).
39
- with(:test_indirection).returns(terminus)
34
+ terminus = double("test indirection terminus")
35
+ allow(terminus).to receive(:name).and_return(:test_indirection)
36
+ allow(terminus).to receive(:terminus_class=)
37
+ allow(terminus).to receive(:save)
38
+ allow(terminus).to receive(:reset_terminus_class)
39
+
40
+ expect(Puppet::Indirector::Indirection).to receive(:instance).
41
+ with(:test_indirection).and_return(terminus)
40
42
 
41
43
  command_line = Puppet::Util::CommandLine.new("puppet", %w{test_indirection --terminus foo save bar})
42
44
  application = Puppet::Application::TestIndirection.new(command_line)
@@ -30,7 +30,7 @@ describe Puppet::Application::Lookup do
30
30
  it "does not allow invalid arguments for '--merge'" do
31
31
  lookup.options[:node] = 'dantooine.local'
32
32
  lookup.options[:merge] = 'something_bad'
33
- lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
33
+ allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
34
34
 
35
35
  expected_error = "The --merge option only accepts 'first', 'hash', 'unique', or 'deep'\nRun 'puppet lookup --help' for more details"
36
36
 
@@ -41,7 +41,7 @@ describe Puppet::Application::Lookup do
41
41
  lookup.options[:node] = 'dantooine.local'
42
42
  lookup.options[:merge_hash_arrays] = true
43
43
  lookup.options[:merge] = 'hash'
44
- lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
44
+ allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
45
45
 
46
46
  expected_error = "The options --knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays are only available with '--merge deep'\nRun 'puppet lookup --help' for more details"
47
47
 
@@ -57,12 +57,12 @@ describe Puppet::Application::Lookup do
57
57
  lookup.options[:render_as] = :s;
58
58
  lookup.options[:merge_hash_arrays] = true
59
59
  lookup.options[:merge] = 'deep'
60
- lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
61
- lookup.stubs(:generate_scope).yields('scope')
60
+ allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
61
+ allow(lookup).to receive(:generate_scope).and_yield('scope')
62
62
 
63
63
  expected_merge = { "strategy" => "deep", "sort_merged_arrays" => false, "merge_hash_arrays" => true }
64
64
 
65
- (Puppet::Pops::Lookup).expects(:lookup).with(['atton', 'kreia'], nil, nil, false, expected_merge, anything).returns('rand')
65
+ expect(Puppet::Pops::Lookup).to receive(:lookup).with(['atton', 'kreia'], nil, nil, false, expected_merge, anything).and_return('rand')
66
66
 
67
67
  expect(run_lookup(lookup)).to eql("rand")
68
68
  end
@@ -72,19 +72,19 @@ describe Puppet::Application::Lookup do
72
72
  it "accepts --merge #{opt}" do
73
73
  lookup.options[:node] = 'dantooine.local'
74
74
  lookup.options[:merge] = opt
75
- lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
76
- lookup.stubs(:generate_scope).yields('scope')
77
- Puppet::Pops::Lookup.stubs(:lookup).returns('rand')
75
+ allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
76
+ allow(lookup).to receive(:generate_scope).and_yield('scope')
77
+ allow(Puppet::Pops::Lookup).to receive(:lookup).and_return('rand')
78
78
  expect(run_lookup(lookup)).to eql("--- rand")
79
79
  end
80
80
  end
81
81
 
82
82
  it "prints the value found by lookup" do
83
83
  lookup.options[:node] = 'dantooine.local'
84
- lookup.command_line.stubs(:args).returns(['atton', 'kreia'])
85
- lookup.stubs(:generate_scope).yields('scope')
84
+ allow(lookup.command_line).to receive(:args).and_return(['atton', 'kreia'])
85
+ allow(lookup).to receive(:generate_scope).and_yield('scope')
86
86
 
87
- Puppet::Pops::Lookup.stubs(:lookup).returns('rand')
87
+ allow(Puppet::Pops::Lookup).to receive(:lookup).and_return('rand')
88
88
 
89
89
  expect(run_lookup(lookup)).to eql("--- rand")
90
90
  end
@@ -269,7 +269,7 @@ describe Puppet::Application::Lookup do
269
269
  it '--explain produces human readable text by default and does not produce output to debug logger' do
270
270
  lookup.options[:node] = node
271
271
  lookup.options[:explain] = true
272
- lookup.command_line.stubs(:args).returns(['a'])
272
+ allow(lookup.command_line).to receive(:args).and_return(['a'])
273
273
  logs = []
274
274
  Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
275
275
  expect(run_lookup(lookup)).to eql(<<-EXPLANATION.chomp)
@@ -298,7 +298,7 @@ Searching for "a"
298
298
 
299
299
  it '--debug using multiple interpolation functions produces output to the logger' do
300
300
  lookup.options[:node] = node
301
- lookup.command_line.stubs(:args).returns(['ab'])
301
+ allow(lookup.command_line).to receive(:args).and_return(['ab'])
302
302
  Puppet.debug = true
303
303
  logs = []
304
304
  begin
@@ -318,7 +318,7 @@ Searching for "a"
318
318
  it '--explain produces human readable text by default and --debug produces the same output to debug logger' do
319
319
  lookup.options[:node] = node
320
320
  lookup.options[:explain] = true
321
- lookup.command_line.stubs(:args).returns(['a'])
321
+ allow(lookup.command_line).to receive(:args).and_return(['a'])
322
322
  Puppet.debug = true
323
323
  logs = []
324
324
  Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
@@ -432,7 +432,7 @@ Lookup of '__global__'
432
432
  lookup.options[:node] = node
433
433
  lookup.options[:explain] = true
434
434
  lookup.options[:explain_options] = true
435
- lookup.command_line.stubs(:args).returns(['a'])
435
+ allow(lookup.command_line).to receive(:args).and_return(['a'])
436
436
  expect(run_lookup(lookup)).to eql(<<-EXPLANATION.chomp)
437
437
  Searching for "lookup_options"
438
438
  Global Data Provider (hiera configuration version 5)
@@ -459,7 +459,7 @@ Searching for "a"
459
459
  lookup.options[:node] = node
460
460
  lookup.options[:explain] = true
461
461
  lookup.options[:render_as] = :yaml
462
- lookup.command_line.stubs(:args).returns(['a'])
462
+ allow(lookup.command_line).to receive(:args).and_return(['a'])
463
463
  output = run_lookup(lookup)
464
464
  expect(YAML.load(output)).to eq(expected_yaml_hash)
465
465
  end
@@ -468,7 +468,7 @@ Searching for "a"
468
468
  lookup.options[:node] = node
469
469
  lookup.options[:explain] = true
470
470
  lookup.options[:render_as] = :json
471
- lookup.command_line.stubs(:args).returns(['a'])
471
+ allow(lookup.command_line).to receive(:args).and_return(['a'])
472
472
  output = run_lookup(lookup)
473
473
  expect(JSON.parse(output)).to eq(expected_json_hash)
474
474
  end
@@ -476,7 +476,7 @@ Searching for "a"
476
476
  it 'can access values using dotted keys' do
477
477
  lookup.options[:node] = node
478
478
  lookup.options[:render_as] = :json
479
- lookup.command_line.stubs(:args).returns(['d.one.two.three'])
479
+ allow(lookup.command_line).to receive(:args).and_return(['d.one.two.three'])
480
480
  output = run_lookup(lookup)
481
481
  expect(JSON.parse("[#{output}]")).to eq(['the value'])
482
482
  end
@@ -484,7 +484,7 @@ Searching for "a"
484
484
  it 'can access values using quoted dotted keys' do
485
485
  lookup.options[:node] = node
486
486
  lookup.options[:render_as] = :json
487
- lookup.command_line.stubs(:args).returns(['"e.one.two.three"'])
487
+ allow(lookup.command_line).to receive(:args).and_return(['"e.one.two.three"'])
488
488
  output = run_lookup(lookup)
489
489
  expect(JSON.parse("[#{output}]")).to eq(['the value'])
490
490
  end
@@ -492,7 +492,7 @@ Searching for "a"
492
492
  it 'can access values using mix of dotted keys and quoted dotted keys' do
493
493
  lookup.options[:node] = node
494
494
  lookup.options[:render_as] = :json
495
- lookup.command_line.stubs(:args).returns(['"f.one"."two.three".1'])
495
+ allow(lookup.command_line).to receive(:args).and_return(['"f.one"."two.three".1'])
496
496
  output = run_lookup(lookup)
497
497
  expect(JSON.parse("[#{output}]")).to eq(['second value'])
498
498
  end
@@ -502,14 +502,14 @@ Searching for "a"
502
502
 
503
503
  it "is unaffected by global variables unless '--compile' is used" do
504
504
  lookup.options[:node] = node
505
- lookup.command_line.stubs(:args).returns(['c'])
505
+ allow(lookup.command_line).to receive(:args).and_return(['c'])
506
506
  expect(run_lookup(lookup)).to eql("--- This is")
507
507
  end
508
508
 
509
509
  it "is affected by global variables when '--compile' is used" do
510
510
  lookup.options[:node] = node
511
511
  lookup.options[:compile] = true
512
- lookup.command_line.stubs(:args).returns(['c'])
512
+ allow(lookup.command_line).to receive(:args).and_return(['c'])
513
513
  expect(run_lookup(lookup)).to eql("--- This is C from site.pp")
514
514
  end
515
515
 
@@ -523,7 +523,7 @@ Searching for "a"
523
523
 
524
524
  lookup.options[:node] = node
525
525
  lookup.options[:fact_file] = filename
526
- lookup.command_line.stubs(:args).returns(['c'])
526
+ allow(lookup.command_line).to receive(:args).and_return(['c'])
527
527
  expect(run_lookup(lookup)).to eql("--- This is C from facts")
528
528
  end
529
529
 
@@ -537,7 +537,7 @@ Searching for "a"
537
537
 
538
538
  lookup.options[:node] = node
539
539
  lookup.options[:fact_file] = filename
540
- lookup.command_line.stubs(:args).returns(['g'])
540
+ allow(lookup.command_line).to receive(:args).and_return(['g'])
541
541
  expect(run_lookup(lookup)).to eql("--- This is G from facts in facts hash")
542
542
  end
543
543
  end
@@ -547,14 +547,14 @@ Searching for "a"
547
547
 
548
548
  it "works OK in the absense of '--compile'" do
549
549
  lookup.options[:node] = node
550
- lookup.command_line.stubs(:args).returns(['c'])
550
+ allow(lookup.command_line).to receive(:args).and_return(['c'])
551
551
  expect(run_lookup(lookup)).to eql("--- This is C from data.pp")
552
552
  end
553
553
 
554
554
  it "global scope is affected by global variables when '--compile' is used" do
555
555
  lookup.options[:node] = node
556
556
  lookup.options[:compile] = true
557
- lookup.command_line.stubs(:args).returns(['c'])
557
+ allow(lookup.command_line).to receive(:args).and_return(['c'])
558
558
  expect(run_lookup(lookup)).to eql("--- This is C from site.pp")
559
559
  end
560
560
  end