puppet 0.24.6 → 0.24.7

data/spec/unit/provider/user/user_role_add.rb

@@ -0,0 +1,249 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+provider_class = Puppet::Type.type(:user).provider(:user_role_add)
+
+describe provider_class do
+    before do
+        @resource = stub("resource", :name => "myuser", :managehome? => nil)
+        @resource.stubs(:should).returns "fakeval"
+        @resource.stubs(:[]).returns "fakeval"
+        @resource.stubs(:allowdupe?).returns false
+        @provider = provider_class.new(@resource)
+    end
+
+    describe "when calling command" do
+        before do
+            klass = stub("provider")
+            klass.stubs(:command).with(:foo).returns("userfoo")
+            klass.stubs(:command).with(:role_foo).returns("rolefoo")
+            @provider.stubs(:class).returns(klass)
+        end
+
+        it "should use the command if not a role and ensure!=role" do
+            @provider.stubs(:is_role?).returns(false)
+            @provider.stubs(:exists?).returns(false)
+            @resource.stubs(:[]).with(:ensure).returns(:present)
+            @provider.command(:foo).should == "userfoo"
+        end
+
+        it "should use the role command when a role" do
+            @provider.stubs(:is_role?).returns(true)
+            @provider.command(:foo).should == "rolefoo"
+        end
+
+        it "should use the role command when !exists and ensure=role" do
+            @provider.stubs(:is_role?).returns(false)
+            @provider.stubs(:exists?).returns(false)
+            @resource.stubs(:[]).with(:ensure).returns(:role)
+            @provider.command(:foo).should == "rolefoo"
+        end
+    end
+
+    describe "when calling transition" do
+        it "should return the type set to whatever is passed in" do
+            @provider.expects(:command).with(:modify).returns("foomod")
+            @provider.transition("bar").include?("type=bar")
+        end
+    end
+
+    describe "when calling create" do
+        before do
+            @provider.stubs(:password=)
+        end
+
+        it "should use the add command when the user is not a role" do
+            @provider.stubs(:is_role?).returns(false)
+            @provider.expects(:addcmd).returns("useradd")
+            @provider.expects(:run)
+            @provider.create
+        end
+
+        it "should use transition(normal) when the user is a role" do
+            @provider.stubs(:is_role?).returns(true)
+            @provider.expects(:transition).with("normal")
+            @provider.expects(:run)
+            @provider.create
+        end
+    end
+
+   describe "when calling destroy" do
+       it "should use the delete command if the user exists and is not a role" do
+            @provider.stubs(:exists?).returns(true)
+            @provider.stubs(:is_role?).returns(false)
+            @provider.expects(:deletecmd)
+            @provider.expects(:run)
+            @provider.destroy
+       end
+
+       it "should use the delete command if the user is a role" do
+            @provider.stubs(:exists?).returns(true)
+            @provider.stubs(:is_role?).returns(true)
+            @provider.expects(:deletecmd)
+            @provider.expects(:run)
+            @provider.destroy
+       end
+   end
+
+   describe "when calling create_role" do
+       it "should use the transition(role) if the user exists" do
+            @provider.stubs(:exists?).returns(true)
+            @provider.stubs(:is_role?).returns(false)
+            @provider.expects(:transition).with("role")
+            @provider.expects(:run)
+            @provider.create_role
+       end
+
+       it "should use the add command when role doesn't exists" do
+            @provider.stubs(:exists?).returns(false)
+            @provider.expects(:addcmd)
+            @provider.expects(:run)
+            @provider.create_role
+       end
+   end
+
+    describe "when allow duplicate is enabled" do
+        before do
+            @resource.expects(:allowdupe?).returns true
+            @provider.stubs(:is_role?).returns(false)
+            @provider.expects(:execute).with { |args| args.include?("-o") }
+        end
+
+        it "should add -o when the user is being created" do
+            @provider.stubs(:password=)
+            @provider.create
+        end
+
+        it "should add -o when the uid is being modified" do
+            @provider.uid = 150
+        end
+    end
+
+    [:roles, :auths, :profiles].each do |val|
+        describe "when getting #{val}" do
+            it "should get the user_attributes" do
+                @provider.expects(:user_attributes)
+                @provider.send(val)
+            end
+
+            it "should get the #{val} attribute" do
+                attributes = mock("attributes")
+                attributes.expects(:[]).with(val)
+                @provider.stubs(:user_attributes).returns(attributes)
+                @provider.send(val)
+            end
+        end
+    end
+
+    describe "when getting the keys" do
+        it "should get the user_attributes" do
+            @provider.expects(:user_attributes)
+            @provider.keys
+        end
+
+        it "should call removed_managed_attributes" do
+            @provider.stubs(:user_attributes).returns({ :type => "normal", :foo => "something" })
+            @provider.expects(:remove_managed_attributes)
+            @provider.keys
+        end
+
+        it "should removed managed attribute (type, auths, roles, etc)" do
+            @provider.stubs(:user_attributes).returns({ :type => "normal", :foo => "something" })
+            @provider.keys.should == { :foo => "something" }
+        end
+    end
+
+    describe "when adding properties" do
+        it "should call build_keys_cmd" do
+            @resource.stubs(:should).returns ""
+            @resource.expects(:should).with(:keys).returns({ :foo => "bar" })
+            @provider.expects(:build_keys_cmd).returns([])
+            @provider.add_properties
+        end
+
+        it "should add the elements of the keys hash to an array" do
+            @resource.stubs(:should).returns ""
+            @resource.expects(:should).with(:keys).returns({ :foo => "bar"})
+            @provider.add_properties.must == ["-K", "foo=bar"]
+        end
+    end
+
+    describe "when calling build_keys_cmd" do
+        it "should build cmd array with keypairs seperated by -K ending with user" do
+            @provider.build_keys_cmd({"foo" => "bar", "baz" => "boo"}).should.eql? ["-K", "foo=bar", "-K", "baz=boo"]
+        end
+    end
+
+    describe "when setting the keys" do
+        before do
+            @provider.stubs(:is_role?).returns(false)
+        end
+
+        it "should run a command" do
+            @provider.expects(:run)
+            @provider.keys=({})
+        end
+
+        it "should build the command" do
+            @resource.stubs(:[]).with(:name).returns("someuser")
+            @provider.stubs(:command).returns("usermod")
+            @provider.expects(:build_keys_cmd).returns(["-K", "foo=bar"])
+            @provider.expects(:run).with(["usermod", "-K", "foo=bar", "someuser"], "modify attribute key pairs")
+            @provider.keys=({})
+        end
+    end
+
+    describe "when getting the hashed password" do
+        before do
+            @array = mock "array"
+        end
+
+        it "should readlines of /etc/shadow" do
+            File.expects(:readlines).with("/etc/shadow").returns([])
+            @provider.password
+        end
+
+        it "should reject anything that doesn't start with alpha numerics" do
+            @array.expects(:reject).returns([])
+            File.stubs(:readlines).with("/etc/shadow").returns(@array)
+            @provider.password
+        end
+
+        it "should collect splitting on ':'" do
+            @array.stubs(:reject).returns(@array)
+            @array.expects(:collect).returns([])
+            File.stubs(:readlines).with("/etc/shadow").returns(@array)
+            @provider.password
+        end
+
+        it "should find the matching user" do
+            @resource.stubs(:[]).with(:name).returns("username")
+            @array.stubs(:reject).returns(@array)
+            @array.stubs(:collect).returns([["username", "hashedpassword"], ["someoneelse", "theirpassword"]])
+            File.stubs(:readlines).with("/etc/shadow").returns(@array)
+            @provider.password.must == "hashedpassword"
+        end
+
+        it "should get the right password" do
+            @resource.stubs(:[]).with(:name).returns("username")
+            File.stubs(:readlines).with("/etc/shadow").returns(["#comment", "   nonsense", "  ", "username:hashedpassword:stuff:foo:bar:::", "other:pword:yay:::"])
+            @provider.password.must == "hashedpassword"
+        end
+    end
+
+    describe "when setting the password" do
+        #how can you mock these blocks up?
+        it "should open /etc/shadow for reading and /etc/shadow_tmp for writing" do
+            File.expects(:open).with("/etc/shadow", "r")
+            File.stubs(:rename)
+            @provider.password=("hashedpassword")
+        end
+        
+        it "should rename the /etc/shadow_tmp to /etc/shadow" do
+            File.stubs(:open).with("/etc/shadow", "r")
+            File.expects(:rename).with("/etc/shadow_tmp", "/etc/shadow")
+            @provider.password=("hashedpassword")
+        end
+    end
+end

data/spec/unit/provider/user/useradd.rb

@@ -0,0 +1,115 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+provider_class = Puppet::Type.type(:user).provider(:useradd)
+
+describe provider_class do
+    before do
+        @resource = stub("resource", :name => "myuser", :managehome? => nil)
+        @resource.stubs(:should).returns "fakeval"
+        @resource.stubs(:[]).returns "fakeval"
+        @provider = provider_class.new(@resource)
+    end
+
+    # #1360
+    it "should add -o when allowdupe is enabled and the user is being created" do
+        @resource.expects(:allowdupe?).returns true
+        @provider.expects(:execute).with { |args| args.include?("-o") }
+        @provider.create
+    end
+
+    it "should add -o when allowdupe is enabled and the uid is being modified" do
+        @resource.expects(:allowdupe?).returns true
+        @provider.expects(:execute).with { |args| args.include?("-o") }
+
+        @provider.uid = 150
+    end
+
+    describe "when checking to add allow dup" do
+        it "should check allow dup" do
+            @resource.expects(:allowdupe?)
+            @provider.check_allow_dup
+        end
+
+        it "should return an array with a flag if dup is allowed" do
+            @resource.stubs(:allowdupe?).returns true
+            @provider.check_allow_dup.must == ["-o"]
+        end
+
+        it "should return an empty array if no dup is allowed" do
+            @resource.stubs(:allowdupe?).returns false
+            @provider.check_allow_dup.must == []
+        end
+    end
+
+    describe "when checking manage home" do
+        it "should check manage home" do
+            @resource.expects(:managehome?)
+            @provider.check_manage_home
+        end
+
+        it "should return an array with -m flag if home is managed" do
+            @resource.stubs(:managehome?).returns true
+            @provider.check_manage_home.must == ["-m"]
+        end
+
+        it "should return an array with -M if home is not managed and on Redhat" do
+            Facter.stubs(:value).with("operatingsystem").returns("RedHat")
+            @resource.stubs(:managehome?).returns false
+            @provider.check_manage_home.must == ["-M"]
+        end
+
+        it "should return an empty array if home is not managed and not on Redhat" do
+            Facter.stubs(:value).with("operatingsystem").returns("some OS")
+            @resource.stubs(:managehome?).returns false
+            @provider.check_manage_home.must == []
+        end
+    end
+
+    describe "when adding properties" do
+        it "should get the valid properties"
+        it "should not add the ensure property"
+        it "should add the flag and value to an array"
+        it "should return and array of flags and values"
+    end
+
+    describe "when calling addcmd" do
+        before do
+            @resource.stubs(:allowdupe?).returns true
+            @resource.stubs(:managehome?).returns true
+        end
+
+        it "should call command with :add" do
+            @provider.expects(:command).with(:add)
+            @provider.addcmd
+        end
+
+        it "should add properties" do
+            @provider.expects(:add_properties).returns([])
+            @provider.addcmd
+        end
+
+        it "should check and add if dup allowed" do
+            @provider.expects(:check_allow_dup).returns([])
+            @provider.addcmd
+        end
+
+        it "should check and add if home is managed" do
+            @provider.expects(:check_manage_home).returns([])
+            @provider.addcmd
+        end
+
+        it "should add the resource :name" do
+            @resource.expects(:[]).with(:name)
+            @provider.addcmd
+        end
+
+        it "should return an array with full command" do
+            @provider.stubs(:command).with(:add).returns("useradd")
+            @provider.stubs(:add_properties).returns(["-G", "somegroup"])
+            @resource.stubs(:[]).with(:name).returns("someuser")
+            @provider.addcmd.must == ["useradd", "-G", "somegroup", "-o", "-m", "someuser"]
+        end
+    end
+end

data/spec/unit/provider/zfs/solaris.rb

@@ -0,0 +1,87 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+provider_class = Puppet::Type.type(:zfs).provider(:solaris)
+
+describe provider_class do
+    before do
+        @resource = stub("resource", :name => "myzfs")
+        @resource.stubs(:[]).with(:name).returns "myzfs"
+        @resource.stubs(:[]).returns "shouldvalue"
+        @provider = provider_class.new(@resource)
+    end
+
+    describe "when calling add_properties" do
+        it "should add -o and the key=value for each properties with a value" do
+            @resource.stubs(:[]).with(:quota).returns ""
+            @resource.stubs(:[]).with(:mountpoint).returns "/foo"
+            properties = @provider.add_properties
+            properties.include?("-o").should == true
+            properties.include?("mountpoint=/foo").should == true
+            properties.detect { |a| a.include?("quota") }.should == nil
+        end
+    end
+
+    describe "when calling create" do
+        it "should call add_properties" do
+            @provider.stubs(:zfs)
+            @provider.expects(:add_properties).returns([])
+            @provider.create
+        end
+
+        it "should call zfs with create, properties and this zfs" do
+            @provider.stubs(:add_properties).returns(%w{a b})
+            @provider.expects(:zfs).with(:create, "a", "b", @resource[:name])
+            @provider.create
+        end
+    end
+
+    describe "when calling delete" do
+        it "should call zfs with :destroy and this zfs" do
+            @provider.expects(:zfs).with(:destroy, @resource[:name])
+            @provider.delete
+        end
+    end
+   
+    describe "when calling exist?" do
+        it "should call zfs with :list" do
+            #return stuff because we have to slice and dice it
+            @provider.expects(:zfs).with(:list).returns("NAME USED AVAIL REFER MOUNTPOINT\nmyzfs 100K 27.4M /myzfs")
+            @provider.exists?
+        end
+        
+        it "should return true if returned values match the name" do 
+            @provider.stubs(:zfs).with(:list).returns("NAME USED AVAIL REFER MOUNTPOINT\n#{@resource[:name]} 100K 27.4M /myzfs")
+            @provider.exists?.should == true
+        end
+
+        it "should return false if returned values don't match the name" do
+            @provider.stubs(:zfs).with(:list).returns("no soup for you")
+            @provider.exists?.should == false
+        end
+            
+    end
+
+    [:mountpoint, :compression, :copies, :quota, :reservation, :sharenfs, :snapdir].each do |prop|
+        describe "when getting the #{prop} value" do
+            it "should call zfs with :get, #{prop} and this zfs" do
+                @provider.expects(:zfs).with(:get, "-H", "-o", "value", prop, @resource[:name]).returns("value\n")
+                @provider.send(prop)
+            end
+
+            it "should get the third value of the second line from the output" do
+                @provider.stubs(:zfs).with(:get, "-H", "-o", "value", prop, @resource[:name]).returns("value\n")
+                @provider.send(prop).should == "value"
+            end
+        end
+
+        describe "when setting the #{prop} value" do
+            it "should call zfs with :set, #{prop}=value and this zfs" do
+                @provider.expects(:zfs).with(:set, "#{prop}=value", @resource[:name])
+                @provider.send("#{prop}=".intern, "value")
+            end
+        end
+    end
+
+end