puppet 0.24.6 → 0.24.7

data/spec/unit/indirector/code.rb

@@ -0,0 +1,33 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+require 'puppet/indirector/code'
+
+describe Puppet::Indirector::Code do
+    before do
+        Puppet::Indirector::Terminus.stubs(:register_terminus_class)
+        @model = mock 'model'
+        @indirection = stub 'indirection', :name => :mystuff, :register_terminus_type => nil, :model => @model
+        Puppet::Indirector::Indirection.stubs(:instance).returns(@indirection)
+
+        @code_class = Class.new(Puppet::Indirector::Code) do
+            def self.to_s
+                "Mystuff::Testing"
+            end
+        end
+
+        @searcher = @code_class.new
+    end
+
+    it "should not have a find() method defined" do
+        @searcher.should_not respond_to(:find)
+    end
+
+    it "should not have a save() method defined" do
+        @searcher.should_not respond_to(:save)
+    end
+
+    it "should not have a destroy() method defined" do
+        @searcher.should_not respond_to(:destroy)
+    end
+end

data/spec/unit/indirector/direct_file_server.rb

@@ -0,0 +1,89 @@
+#!/usr/bin/env ruby
+#
+#  Created by Luke Kanies on 2007-10-24.
+#  Copyright (c) 2007. All rights reserved.
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+require 'puppet/indirector/direct_file_server'
+
+describe Puppet::Indirector::DirectFileServer do
+    before :each do
+        Puppet::Indirector::Terminus.stubs(:register_terminus_class)
+        @model = mock 'model'
+        @indirection = stub 'indirection', :name => :mystuff, :register_terminus_type => nil, :model => @model
+        Puppet::Indirector::Indirection.stubs(:instance).returns(@indirection)
+
+        @direct_file_class = Class.new(Puppet::Indirector::DirectFileServer) do
+            def self.to_s
+                "Testing::Mytype"
+            end
+        end
+
+        @server = @direct_file_class.new
+
+        @uri = "file:///my/local"
+
+        @request = stub 'request', :key => @uri, :options => {}
+    end
+
+    describe Puppet::Indirector::DirectFileServer, "when finding a single file" do
+
+        it "should return nil if the file does not exist" do
+            FileTest.expects(:exists?).with("/my/local").returns false
+            @server.find(@request).should be_nil
+        end
+
+        it "should return a Content instance created with the full path to the file if the file exists" do
+            FileTest.expects(:exists?).with("/my/local").returns true
+            @model.expects(:new).returns(:mycontent)
+            @server.find(@request).should == :mycontent
+        end
+    end
+
+    describe Puppet::Indirector::DirectFileServer, "when creating the instance for a single found file" do
+
+        before do
+            @data = mock 'content'
+            @data.stubs(:collect_attributes)
+            FileTest.expects(:exists?).with("/my/local").returns true
+        end
+
+        it "should create the Content instance with the original key as the key" do
+            @model.expects(:new).with { |key, options| key == @uri }.returns(@data)
+            @server.find(@request)
+        end
+
+        it "should pass the full path to the instance" do
+            @model.expects(:new).with { |key, options| options[:path] == "/my/local" }.returns(@data)
+            @server.find(@request)
+        end
+
+        it "should pass the :links setting on to the created Content instance if the file exists and there is a value for :links" do
+            @model.expects(:new).returns(@data)
+            @data.expects(:links=).with(:manage)
+
+            @request.stubs(:options).returns(:links => :manage)
+            @server.find(@request)
+        end
+    end
+
+    describe Puppet::Indirector::DirectFileServer, "when searching for multiple files" do
+        it "should return nil if the file does not exist" do
+            FileTest.expects(:exists?).with("/my/local").returns false
+            @server.find(@request).should be_nil
+        end
+
+        it "should use :path2instances from the terminus_helper to return instances if the file exists" do
+            FileTest.expects(:exists?).with("/my/local").returns true
+            @server.expects(:path2instances)
+            @server.search(@request)
+        end
+
+        it "should pass the original request to :path2instances" do
+            FileTest.expects(:exists?).with("/my/local").returns true
+            @server.expects(:path2instances).with(@request, "/my/local")
+            @server.search(@request)
+        end
+    end
+end

data/spec/unit/indirector/envelope.rb

@@ -0,0 +1,47 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+require 'puppet/indirector/envelope'
+
+describe Puppet::Indirector::Envelope do
+    before do
+        @instance = Object.new
+        @instance.extend(Puppet::Indirector::Envelope)
+    end
+
+    it "should have an expiration accessor" do
+        @instance.expiration = "testing"
+        @instance.expiration.should == "testing"
+    end
+
+    it "should have an expiration setter" do
+        @instance.should respond_to(:expiration=)
+    end
+
+    it "should have a means of testing whether it is expired" do
+        @instance.should respond_to(:expired?)
+    end
+
+    describe "when testing if it is expired" do
+        it "should return false if there is no expiration set" do
+            @instance.should_not be_expired
+        end
+
+        it "should return true if the current date is after the expiration date" do
+            @instance.expiration = Time.now - 10
+            @instance.should be_expired
+        end
+
+        it "should return false if the current date is prior to the expiration date" do
+            @instance.expiration = Time.now + 10
+            @instance.should_not be_expired
+        end
+
+        it "should return false if the current date is equal to the expiration date" do
+            now = Time.now
+            Time.stubs(:now).returns(now)
+            @instance.expiration = now
+            @instance.should_not be_expired
+        end
+    end
+end

data/spec/unit/indirector/exec.rb

@@ -0,0 +1,51 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+require 'puppet/indirector/exec'
+
+describe Puppet::Indirector::Exec do
+    before do
+        @indirection = stub 'indirection', :name => :testing
+        Puppet::Indirector::Indirection.expects(:instance).with(:testing).returns(@indirection)
+        @exec_class = Class.new(Puppet::Indirector::Exec) do
+            def self.to_s
+                "Testing::Mytype"
+            end
+
+            attr_accessor :command
+        end
+
+        @searcher = @exec_class.new
+        @searcher.command = ["/echo"]
+
+        @request = stub 'request', :key => "foo"
+    end
+
+    it "should throw an exception if the command is not an array" do
+        @searcher.command = "/usr/bin/echo"
+        proc { @searcher.find(@request) }.should raise_error(Puppet::DevError)
+    end
+
+    it "should throw an exception if the command is not fully qualified" do
+        @searcher.command = ["mycommand"]
+        proc { @searcher.find(@request) }.should raise_error(ArgumentError)
+    end
+
+    it "should execute the command with the object name as the only argument" do
+        @searcher.expects(:execute).with(%w{/echo foo})
+        @searcher.find(@request)
+    end
+
+    it "should return the output of the script" do
+        @searcher.expects(:execute).with(%w{/echo foo}).returns("whatever")
+        @searcher.find(@request).should == "whatever"
+    end
+
+    it "should return nil when the command produces no output" do
+        @searcher.expects(:execute).with(%w{/echo foo}).returns(nil)
+        @searcher.find(@request).should be_nil
+    end
+
+    it "should be able to execute commands with multiple arguments"
+end

data/spec/unit/indirector/facts/facter.rb

@@ -0,0 +1,76 @@
+#!/usr/bin/env ruby
+#
+#  Created by Luke Kanies on 2007-9-23.
+#  Copyright (c) 2007. All rights reserved.
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+require 'puppet/indirector/facts/facter'
+
+describe Puppet::Node::Facts::Facter do
+    it "should be a subclass of the Code terminus" do
+        Puppet::Node::Facts::Facter.superclass.should equal(Puppet::Indirector::Code)
+    end
+
+    it "should have documentation" do
+        Puppet::Node::Facts::Facter.doc.should_not be_nil
+    end
+
+    it "should be registered with the configuration store indirection" do
+        indirection = Puppet::Indirector::Indirection.instance(:facts)
+        Puppet::Node::Facts::Facter.indirection.should equal(indirection)
+    end
+
+    it "should have its name set to :facter" do
+        Puppet::Node::Facts::Facter.name.should == :facter
+    end
+
+    it "should load facts on initialization" do
+        Puppet::Node::Facts::Facter.expects(:loadfacts)
+        Puppet::Node::Facts::Facter.new
+    end
+end
+
+describe Puppet::Node::Facts::Facter do
+    before :each do
+        @facter = Puppet::Node::Facts::Facter.new
+        Facter.stubs(:to_hash).returns({})
+        @name = "me"
+        @request = stub 'request', :key => @name
+    end
+
+    describe Puppet::Node::Facts::Facter, " when finding facts" do
+
+        it "should return a Facts instance" do
+            @facter.find(@request).should be_instance_of(Puppet::Node::Facts)
+        end
+
+        it "should return a Facts instance with the provided key as the name" do
+            @facter.find(@request).name.should == @name
+        end
+
+        it "should return the Facter facts as the values in the Facts instance" do
+            Facter.expects(:to_hash).returns("one" => "two")
+            facts = @facter.find(@request)
+            facts.values["one"].should == "two"
+        end
+    end
+
+    describe Puppet::Node::Facts::Facter, " when saving facts" do
+
+        it "should fail" do
+            proc { @facter.save(@facts) }.should raise_error(Puppet::DevError)
+        end
+    end
+
+    describe Puppet::Node::Facts::Facter, " when destroying facts" do
+
+        it "should fail" do
+            proc { @facter.destroy(@facts) }.should raise_error(Puppet::DevError)
+        end
+    end
+
+    describe Puppet::Node::Facts::Facter, " when loading facts from the factpath" do
+        it "should load every fact in each factpath directory"
+    end
+end

data/spec/unit/indirector/facts/yaml.rb

@@ -0,0 +1,26 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+require 'puppet/node/facts'
+require 'puppet/indirector/facts/yaml'
+
+describe Puppet::Node::Facts::Yaml do
+    it "should be a subclass of the Yaml terminus" do
+        Puppet::Node::Facts::Yaml.superclass.should equal(Puppet::Indirector::Yaml)
+    end
+
+
+    it "should have documentation" do
+        Puppet::Node::Facts::Yaml.doc.should_not be_nil
+    end
+
+    it "should be registered with the facts indirection" do
+        indirection = Puppet::Indirector::Indirection.instance(:facts)
+        Puppet::Node::Facts::Yaml.indirection.should equal(indirection)
+    end
+
+    it "should have its name set to :facts" do
+        Puppet::Node::Facts::Yaml.name.should == :yaml
+    end
+end

data/spec/unit/indirector/file.rb

@@ -0,0 +1,154 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+require 'puppet/indirector/file'
+
+
+describe Puppet::Indirector::File do
+    before :each do
+        Puppet::Indirector::Terminus.stubs(:register_terminus_class)
+        @model = mock 'model'
+        @indirection = stub 'indirection', :name => :mystuff, :register_terminus_type => nil, :model => @model
+        Puppet::Indirector::Indirection.stubs(:instance).returns(@indirection)
+
+        @file_class = Class.new(Puppet::Indirector::File) do
+            def self.to_s
+                "Testing::Mytype"
+            end
+        end
+
+        @searcher = @file_class.new
+
+        @path = "/my/file"
+        @dir = "/my"
+
+        @request = stub 'request', :key => @path
+    end
+  
+    describe Puppet::Indirector::File, " when finding files" do
+
+        it "should provide a method to return file contents at a specified path" do
+            @searcher.should respond_to(:find)
+        end
+
+        it "should return file contents as an instance of the model" do
+            content = "my content"
+
+            file = mock 'file'
+            @model.expects(:new).with(content).returns(file)
+
+            File.expects(:exist?).with(@path).returns(true)
+            File.expects(:read).with(@path).returns(content)
+            @searcher.find(@request)
+        end
+
+        it "should create the model instance with the content as the only argument to initialization" do
+            content = "my content"
+
+            file = mock 'file'
+            @model.expects(:new).with(content).returns(file)
+
+            File.expects(:exist?).with(@path).returns(true)
+            File.expects(:read).with(@path).returns(content)
+            @searcher.find(@request).should equal(file)
+        end
+
+        it "should return nil if no file is found" do
+            File.expects(:exist?).with(@path).returns(false)
+            @searcher.find(@request).should be_nil
+        end
+
+        it "should fail intelligently if a found file cannot be read" do
+            File.expects(:exist?).with(@path).returns(true)
+            File.expects(:read).with(@path).raises(RuntimeError)
+            proc { @searcher.find(@request) }.should raise_error(Puppet::Error)
+        end
+
+        it "should use the path() method to calculate the path if it exists" do
+            @searcher.meta_def(:path) do |name|
+                name.upcase
+            end
+
+            File.expects(:exist?).with(@path.upcase).returns(false)
+            @searcher.find(@request)
+        end
+    end
+
+    describe Puppet::Indirector::File, " when saving files" do
+        before do
+            @content = "my content"
+            @file = stub 'file', :content => @content, :path => @path, :name => @path
+            @request.stubs(:instance).returns @file
+        end
+
+        it "should provide a method to save file contents at a specified path" do
+            filehandle = mock 'file'
+            File.expects(:directory?).with(@dir).returns(true)
+            File.expects(:open).with(@path, "w").yields(filehandle)
+            filehandle.expects(:print).with(@content)
+
+            @searcher.save(@request)
+        end
+
+        it "should fail intelligently if the file's parent directory does not exist" do
+            File.expects(:directory?).with(@dir).returns(false)
+
+            proc { @searcher.save(@request) }.should raise_error(Puppet::Error)
+        end
+
+        it "should fail intelligently if a file cannot be written" do
+            filehandle = mock 'file'
+            File.expects(:directory?).with(@dir).returns(true)
+            File.expects(:open).with(@path, "w").yields(filehandle)
+            filehandle.expects(:print).with(@content).raises(ArgumentError)
+
+            proc { @searcher.save(@request) }.should raise_error(Puppet::Error)
+        end
+
+        it "should use the path() method to calculate the path if it exists" do
+            @searcher.meta_def(:path) do |name|
+                name.upcase
+            end
+
+            # Reset the key to something without a parent dir, so no checks are necessary
+            @request.stubs(:key).returns "/my"
+
+            File.expects(:open).with("/MY", "w")
+            @searcher.save(@request)
+        end
+    end
+
+    describe Puppet::Indirector::File, " when removing files" do
+
+        it "should provide a method to remove files at a specified path" do
+            File.expects(:exist?).with(@path).returns(true)
+            File.expects(:unlink).with(@path)
+
+            @searcher.destroy(@request)
+        end
+
+        it "should throw an exception if the file is not found" do
+            File.expects(:exist?).with(@path).returns(false)
+
+            proc { @searcher.destroy(@request) }.should raise_error(Puppet::Error)
+        end
+
+        it "should fail intelligently if the file cannot be removed" do
+            File.expects(:exist?).with(@path).returns(true)
+            File.expects(:unlink).with(@path).raises(ArgumentError)
+
+            proc { @searcher.destroy(@request) }.should raise_error(Puppet::Error)
+        end
+
+        it "should use the path() method to calculate the path if it exists" do
+            @searcher.meta_def(:path) do |thing|
+                thing.to_s.upcase
+            end
+
+            File.expects(:exist?).with("/MY/FILE").returns(true)
+            File.expects(:unlink).with("/MY/FILE")
+
+            @searcher.destroy(@request)
+        end
+    end
+end