puppet-retrospec 0.11.0 → 0.12.0

data/spec/unit/conditional_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
-describe "conditional" do
-
+describe 'conditional' do
   after :all do
     # enabling the removal slows down tests, but from time to time we may need to
     FileUtils.rm_rf(fixture_modules_path) if ENV['RETROSPEC_CLEAN_UP_TEST_MODULES'] =~ /true/
@@ -12,17 +11,15 @@ describe "conditional" do
     FileUtils.rm_rf(fixture_modules_path) if ENV['RETROSPEC_CLEAN_UP_TEST_MODULES'] =~ /true/
   end
 
-
   describe 'one resource module' do
-
-    let(:instance) {Utilities::PuppetModule.send :new}
+    let(:instance) { Utilities::PuppetModule.send :new }
 
     it 'should initialize ' do
       my_path = File.expand_path(File.join('spec', 'fixtures', 'fixture_modules', 'one_resource_module'))
       m = instance
-      m.module_path =my_path
+      m.module_path = my_path
       m.create_tmp_module_path(my_path)
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       Resource.all(test_type)
       conds = Conditional.find_conditionals(test_type)
       con = Conditional.new(conds.first, test_type.arguments)
@@ -32,27 +29,27 @@ describe "conditional" do
     it 'should generate conditional resources' do
       my_path = File.expand_path(File.join('spec', 'fixtures', 'fixture_modules', 'one_resource_module'))
       m = instance
-      m.module_path =my_path
+      m.module_path = my_path
       m.create_tmp_module_path(my_path)
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       VariableStore.populate(test_type)
       r = Conditional.all(test_type)
       expect(r.length).to eq(1)
-      expect(r[0].parameters).to eq({"ensure"=>"present"})
-      expect(r[0].title).to eq("/tmp/test3/3")
-      expect(r[0].type).to eq("file")
+      expect(r[0].parameters).to eq('ensure' => 'present')
+      expect(r[0].title).to eq('/tmp/test3/3')
+      expect(r[0].type).to eq('file')
     end
   end
 
   describe 'zero module' do
-    let(:instance) {Utilities::PuppetModule.send :new}
+    let(:instance) { Utilities::PuppetModule.send :new }
     it 'should respond correctly when class is empty' do
       my_path = File.expand_path(File.join('spec', 'fixtures', 'fixture_modules', 'zero_resource_module'))
       m = instance
       m.module_path = my_path
       m.create_tmp_module_path(my_path)
-      test_type = m.types.find {|x| x.name == 'empty_class'}
-      expect{Conditional.all(test_type)}.to_not raise_error
+      test_type = m.types.find { |x| x.name == 'empty_class' }
+      expect { Conditional.all(test_type) }.to_not raise_error
     end
   end
 end

data/spec/unit/generators/fact_generater_spec.rb

@@ -4,8 +4,6 @@ describe "fact generator" do
 
   before :each do
     FileUtils.rm_rf(facter_spec_dir)
-    allow(generator).to receive(:facter_dir).and_return(fixtures_facts_path)
-    allow(generator).to receive(:fact_name_path).and_return(File.join(module_path, 'lib', 'facter', "#{generator.fact_name}.rb"))
   end
 
   after :each do
@@ -21,33 +19,67 @@ describe "fact generator" do
   end
 
   let(:context) do
-    {:name => 'datacenter', :template_dir => File.expand_path(File.join(ENV['HOME'], '.retrospec', 'repos', 'retrospec-puppet-templates'))}
+    {:name => 'datacenter', :template_dir => retrospec_templates_path }
   end
 
   let(:generator) do
     Retrospec::Puppet::Generators::FactGenerator.new(module_path, context )
   end
 
-  it 'returns facter dir' do
-    expect(generator.facter_dir).to eq(fixtures_facts_path)
-  end
+  describe :datacenter do
+    before(:each) do
+      allow(generator).to receive(:facter_dir).and_return(fixtures_facts_path)
+      allow(generator).to receive(:fact_name_path).and_return(File.join(module_path, 'lib', 'facter', "#{generator.fact_name}.rb"))
+    end
 
-  it 'returns module path' do
-    expect(generator.facter_spec_dir).to eq(facter_spec_dir)
-  end
+    let(:context) do
+      {:name => 'datacenter', :template_dir => retrospec_templates_path}
+    end
+    it 'returns facter dir' do
+      expect(generator.facter_dir).to eq(fixtures_facts_path)
+    end
 
-  it 'can return fact name' do
-    expect(generator.fact_name).to eq('datacenter')
-  end
+    it 'returns module path' do
+      expect(generator.facter_spec_dir).to eq(facter_spec_dir)
+    end
+
+    it 'can return fact name' do
+      expect(generator.fact_name).to eq('datacenter')
+    end
 
-  it 'can generate a fact file' do
-    expect(generator.generate_fact_file.count).to eq(3)
-    expect(File.exists?(File.join(generator.facter_dir, "#{generator.fact_name}.rb")))
+    it 'can generate a fact file' do
+      expect(generator.generate_fact_file.count).to eq(6)
+      expect(File.exists?(File.join(generator.facter_dir, "#{generator.fact_name}.rb")))
+    end
+
+    it 'can generate a spec file' do
+      expect(generator.generate_fact_spec_files.count).to eq(6)
+    end
   end
 
-  it 'can generate a spec file' do
+  describe :oracle_controls do
+    before(:each) do
+      allow(generator).to receive(:facter_dir).and_return(fixtures_facts_path)
+      allow(generator).to receive(:fact_name_path).and_return(File.join(module_path, 'lib', 'facter', "#{generator.fact_name}.rb"))
+    end
+
+    let(:context) do
+      {:name => 'oracle_controls',:template_dir => retrospec_templates_path}
+    end
 
-    expect(generator.generate_fact_spec_files.count).to eq(3)
+    it 'can generate a spec file' do
+      allow(generator).to receive(:fact_files).and_return([File.join(fixtures_facts_path, 'oracle_controls.rb')])
+      expect(generator.generate_fact_spec_files.count).to eq(2)
+    end
   end
 
+  describe 'real module' do
+    let(:module_path) do
+      sample_module_path
+    end
+
+    it 'can generate a spec file' do
+      expect(generator.generate_fact_spec_files).to eq([File.join(facter_spec_dir, 'fix_installed_spec.rb')])
+    end
+  end
 end

data/spec/unit/generators/function_generator_spec.rb

@@ -0,0 +1,301 @@
+require 'spec_helper'
+
+describe 'function_generator' do
+  before :each do
+    FileUtils.rm_rf(generator.v3_spec_dir)
+    FileUtils.rm_rf(generator.v4_spec_dir)
+    FileUtils.rm_rf(function_path)
+  end
+
+  let(:function_path) do
+    File.join(module_path, 'lib', 'puppet', 'parser', 'functions', "#{function_name}.rb")
+  end
+
+  let(:module_path) do
+    sample_module_path
+  end
+
+  let(:context) do
+    { :module_path => module_path,
+      :template_dir => template_dir }
+  end
+
+  let(:template_dir) do
+    retrospec_templates_path
+  end
+
+  let(:function_name) do
+    'awesome_parser'
+  end
+
+  let(:type_name) do
+    'v4'
+  end
+
+  let(:return_type) do
+    'rvalue'
+  end
+
+  let(:cli_opts) do
+    Retrospec::Puppet::Generators::FunctionGenerator.run_cli(context, opts)
+  end
+
+  let(:generator) do
+    Retrospec::Puppet::Generators::FunctionGenerator.new(module_path, cli_opts)
+  end
+
+  describe 'ruby unit tests' do
+    let(:opts) do
+      ['-n', function_name, '-r', return_type, '-t', type_name, '-u', 'ruby']
+    end
+
+    it 'contain template dir' do
+      expect(generator.template_dir).to match /templates\/functions/
+    end
+
+    it 'returns function name' do
+      expect(generator.function_name).to eq(function_name)
+    end
+
+    it 'generate spec files' do
+      files = [File.join(generator.v3_spec_dir, 'defined_spec.rb'),
+        File.join(generator.v3_spec_dir, 'sha1_spec.rb'),
+        File.join(generator.v4_spec_dir, 'reduce_spec.rb'),
+        File.join(generator.v4_spec_dir, 'awesome_parser_spec.rb')
+
+      ]
+      expect(generator.generate_spec_files).to match_array(files)
+    end
+
+    it 'returns found function files' do
+      files = [
+        File.join(module_path, 'lib', 'puppet', 'functions', 'awesome_parser.rb'),
+        File.join(module_path, 'lib', 'puppet', 'functions', 'reduce.rb'),
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'bad_sha1.rb'),
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'defined.rb'),
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'sha1.rb'),
+      ]
+      expect(generator.discovered_functions).to match_array(files)
+    end
+
+    describe 'v3' do
+      let(:type_name) do
+        'v3'
+      end
+
+      let(:function_path) do
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', "#{function_name}.rb")
+      end
+
+      it 'returns function directory' do
+        path = File.join(module_path, 'lib', 'puppet', 'parser', 'functions')
+        expect(generator.function_dir).to eq(path)
+      end
+
+      it 'returns function path' do
+        path = File.join(module_path, 'lib', 'puppet', 'parser', 'functions', "#{function_name}.rb")
+        expect(generator.function_path).to eq(path)
+      end
+
+      it 'generate function file' do
+        expect(generator.generate_function_file).to eq(function_path)
+      end
+
+      it 'returns spec file directory' do
+        path = File.join(module_path, 'spec', 'unit', 'puppet', 'parser', 'functions')
+        expect(generator.spec_file_dir).to eq(path)
+      end
+
+      it 'return v3 template path' do
+        allow(generator).to receive(:function_type).and_return('v3')
+        path = File.join(gem_template_path, 'functions', 'v3')
+        expect(generator.template_dir).to match(/functions\/v3/)
+      end
+
+      it 'return true when v3 function' do
+        path = File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'bad_sha1.rb')
+        expect(generator.is_v3_function?(path)).to eq (true)
+      end
+
+      it 'return v3 template path when context is changed' do
+        generator.template_dir  # uses v4
+        generator.context.function_type = 'v3'
+        expect(generator.template_dir).to match(/functions\/v3/)
+
+      end
+    end
+
+    describe 'v4' do
+      let(:type_name) do
+        'v4'
+      end
+
+      let(:function_path) do
+        File.join(module_path, 'lib', 'puppet', 'functions', "#{function_name}.rb")
+      end
+
+      it 'return false when v4 function' do
+        path = File.join(module_path, 'lib', 'puppet', 'functions', 'reduce.rb')
+        expect(generator.is_v3_function?(path)).to eq (false)
+      end
+
+      it 'return v4 template path' do
+        allow(generator).to receive(:function_type).and_return('v4')
+        expect(generator.template_dir).to match(/functions\/v4/)
+      end
+
+      it 'return v4 template path when context is changed' do
+        generator.template_dir
+        generator.context.function_type = 'v4'
+        expect(generator.template_dir).to match(/functions\/v4/)
+      end
+
+      it 'returns function path' do
+        path = File.join(module_path, 'lib', 'puppet', 'functions', "#{function_name}.rb")
+        expect(generator.function_path).to eq(path)
+      end
+
+      it 'returns spec file directory' do
+        path = File.join(module_path, 'spec', 'unit', 'puppet', 'functions')
+        expect(generator.spec_file_dir).to eq(path)
+      end
+
+      it 'returns function directory' do
+        path = File.join(module_path, 'lib', 'puppet', 'functions')
+        expect(generator.function_dir).to eq(path)
+      end
+
+      it 'generate function file' do
+        expect(generator.generate_function_file).to eq(function_path)
+      end
+    end
+  end
+
+  describe 'rspec unit tests' do
+    let(:opts) do
+      ['-n', function_name, '-r', 'return_type', '-t', type_name, '-u', 'rspec']
+    end
+
+    it 'contain template dir' do
+      expect(generator.template_dir).to match /templates\/functions/
+    end
+
+    it 'returns function name' do
+      expect(generator.function_name).to eq(function_name)
+    end
+
+    it 'generate spec files' do
+      files = [File.join(generator.v3_spec_dir, 'defined_spec.rb'),
+        File.join(generator.v3_spec_dir, 'sha1_spec.rb'),
+        File.join(generator.v4_spec_dir, 'reduce_spec.rb'),
+        File.join(generator.v4_spec_dir, 'awesome_parser_spec.rb')
+
+      ]
+      expect(generator.generate_spec_files).to match_array(files)
+    end
+
+    it 'returns found function files' do
+      files = [
+        File.join(module_path, 'lib', 'puppet', 'functions', 'awesome_parser.rb'),
+        File.join(module_path, 'lib', 'puppet', 'functions', 'reduce.rb'),
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'bad_sha1.rb'),
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'defined.rb'),
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'sha1.rb'),
+      ]
+      expect(generator.discovered_functions).to match_array(files)
+    end
+
+    describe 'v3' do
+      let(:type_name) do
+        'v3'
+      end
+
+      let(:function_path) do
+        File.join(module_path, 'lib', 'puppet', 'parser', 'functions', "#{function_name}.rb")
+      end
+
+      it 'returns function directory' do
+        path = File.join(module_path, 'lib', 'puppet', 'parser', 'functions')
+        expect(generator.function_dir).to eq(path)
+      end
+
+      it 'returns function path' do
+        path = File.join(module_path, 'lib', 'puppet', 'parser', 'functions', "#{function_name}.rb")
+        expect(generator.function_path).to eq(path)
+      end
+
+      it 'generate function file' do
+        expect(generator.generate_function_file).to eq(function_path)
+      end
+
+      it 'returns spec file directory' do
+        path = File.join(module_path, 'spec', 'functions')
+        expect(generator.spec_file_dir).to eq(path)
+      end
+
+      it 'return v3 template path' do
+        allow(generator).to receive(:function_type).and_return('v3')
+        path = File.join(gem_template_path, 'functions', 'v3')
+        expect(generator.template_dir).to match(/functions\/v3/)
+      end
+
+      it 'return true when v3 function' do
+        path = File.join(module_path, 'lib', 'puppet', 'parser', 'functions', 'bad_sha1.rb')
+        expect(generator.is_v3_function?(path)).to eq (true)
+      end
+
+      it 'return v3 template path when context is changed' do
+        generator.template_dir  # uses v4
+        generator.context.function_type = 'v3'
+        expect(generator.template_dir).to match(/functions\/v3/)
+      end
+    end
+
+    describe 'v4' do
+      let(:type_name) do
+        'v4'
+      end
+
+      let(:function_path) do
+        File.join(module_path, 'lib', 'puppet', 'functions', "#{function_name}.rb")
+      end
+
+      it 'return false when v4 function' do
+        path = File.join(module_path, 'lib', 'puppet', 'functions', 'reduce.rb')
+        expect(generator.is_v3_function?(path)).to eq (false)
+      end
+
+      it 'return v4 template path' do
+        allow(generator).to receive(:function_type).and_return('v4')
+        expect(generator.template_dir).to match(/functions\/v4/)
+      end
+
+      it 'return v4 template path when context is changed' do
+        generator.template_dir
+        generator.context.function_type = 'v4'
+        expect(generator.template_dir).to match(/functions\/v4/)
+      end
+
+      it 'returns function path' do
+        path = File.join(module_path, 'lib', 'puppet', 'functions', "#{function_name}.rb")
+        expect(generator.function_path).to eq(path)
+      end
+
+      it 'returns spec file directory' do
+        path = File.join(module_path, 'spec', 'functions')
+        expect(generator.spec_file_dir).to eq(path)
+      end
+
+      it 'returns function directory' do
+        path = File.join(module_path, 'lib', 'puppet', 'functions')
+        expect(generator.function_dir).to eq(path)
+      end
+
+      it 'generate function file' do
+        expect(generator.generate_function_file).to eq(function_path)
+      end
+    end
+  end
+
+
+  end