puppet-retrospec 0.11.0 → 0.12.0

data/spec/unit/type_code_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "type_code" do
+describe 'type_code' do
   after :all do
     # enabling the removal slows down tests, but from time to time we may need to
     FileUtils.rm_rf(fixture_modules_path) if ENV['RETROSPEC_CLEAN_UP_TEST_MODULES'] =~ /true/
@@ -11,23 +11,22 @@ describe "type_code" do
     FileUtils.rm_rf(fixture_modules_path) if ENV['RETROSPEC_CLEAN_UP_TEST_MODULES'] =~ /true/
   end
 
-
   describe 'one resource module' do
     before :all do
       @path = File.expand_path(File.join('spec', 'fixtures', 'fixture_modules', 'one_resource_module'))
     end
 
     before :each do
-      @opts = {:module_path => @path, :enable_beaker_tests => false,
-               :enable_user_templates => false, :template_dir => nil }
+      @opts = { :module_path => @path, :enable_beaker_tests => false,
+                :enable_user_templates => false, :template_dir => nil }
     end
-    let(:instance) {Utilities::PuppetModule.send :new}
+    let(:instance) { Utilities::PuppetModule.send :new }
 
     it 'should initialize correctly scope name' do
       m = instance
       m.module_path = @opts[:module_path]
       m.create_tmp_module_path(@opts[:module_path])
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       expect(TypeCode.new(test_type).scope_name).to eq('one_resource::another_resource')
       expect(TypeCode.new(test_type).type).to eq(test_type)
     end
@@ -36,21 +35,20 @@ describe "type_code" do
       m = instance
       m.module_path = @opts[:module_path]
       m.create_tmp_module_path(@opts[:module_path])
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       expect(TypeCode.new(test_type).variables.size).to eq(4)
     end
   end
 
   describe 'zero module' do
-    let(:instance) {Utilities::PuppetModule.send :new}
+    let(:instance) { Utilities::PuppetModule.send :new }
     it 'should respond correctly when class is empty' do
       my_path = File.expand_path(File.join('spec', 'fixtures', 'fixture_modules', 'zero_resource_module'))
       m = instance
       m.module_path = my_path
       m.create_tmp_module_path(my_path)
-      test_type = m.types.find {|x| x.name == 'empty_class'}
-      expect{TypeCode.new(test_type).variables}.to_not raise_error
+      test_type = m.types.find { |x| x.name == 'empty_class' }
+      expect { TypeCode.new(test_type).variables }.to_not raise_error
     end
   end
-
 end

data/spec/unit/variable_store_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe "variable_store" do
-  let(:instance) {Utilities::PuppetModule.send :new}
+describe 'variable_store' do
+  let(:instance) { Utilities::PuppetModule.send :new }
 
   after :all do
     # enabling the removal slows down tests, but from time to time we may need to
@@ -15,8 +15,8 @@ describe "variable_store" do
   end
 
   before :each do
-    @opts = {:module_path => @path, :enable_beaker_tests => false,
-             :enable_user_templates => false, :template_dir => nil }
+    @opts = { :module_path => @path, :enable_beaker_tests => false,
+              :enable_user_templates => false, :template_dir => nil }
     @module = instance
     @module.module_path = @opts[:module_path]
     @module.create_tmp_module_path(@opts[:module_path])
@@ -27,46 +27,46 @@ describe "variable_store" do
   end
 
   it 'should resolve a string' do
-    test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
+    test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
     r = Resource.all(test_type).first
-    string1 = ObjectSpace.each_object(Puppet::Parser::AST::String).find {|x| x.to_s == "\"value1\"" }
+    string1 = ObjectSpace.each_object(Puppet::Parser::AST::String).find { |x| x.to_s == "\"value1\"" }
     expect(VariableStore.resolve(string1)).to eq("\"value1\"")
   end
 
   it 'should resolve a variable' do
-    test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
+    test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
     r = Resource.all(test_type).first
-    var1 = ObjectSpace.each_object(Puppet::Parser::AST::Variable).find {|x| x.to_s == '$file_name' }
-    VariableStore.add(var1,'/tmp/test3')
-    expect(VariableStore.resolve(var1)).to eq("/tmp/test3")
+    var1 = ObjectSpace.each_object(Puppet::Parser::AST::Variable).find { |x| x.to_s == '$file_name' }
+    VariableStore.add(var1, '/tmp/test3')
+    expect(VariableStore.resolve(var1)).to eq('/tmp/test3')
   end
 
   it 'should resolve a basic vardef type' do
-    test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
+    test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
     VariableStore.populate(test_type)
-    vardef1 = ObjectSpace.each_object(Puppet::Parser::AST::VarDef).find {|x| x.name.value == 'some_var'}
-    expect(VariableStore.resolve(vardef1)).to eq("oohhhh")
+    vardef1 = ObjectSpace.each_object(Puppet::Parser::AST::VarDef).find { |x| x.name.value == 'some_var' }
+    expect(VariableStore.resolve(vardef1)).to eq('oohhhh')
   end
 
   it 'should resolve a concat vardef type' do
-    test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
+    test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
     VariableStore.populate(test_type)
-    vardef2 =  ObjectSpace.each_object(Puppet::Parser::AST::VarDef).find {|x| x.name.value == 'concat_var'}
-    expect(VariableStore.resolve(vardef2)).to eq("/tmp/test3/test3183/oohhhh")
+    vardef2 = ObjectSpace.each_object(Puppet::Parser::AST::VarDef).find { |x| x.name.value == 'concat_var' }
+    expect(VariableStore.resolve(vardef2)).to eq('/tmp/test3/test3183/oohhhh')
   end
 
   it 'should resolve vardef/concat with parameter value' do
-    test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
+    test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
     VariableStore.populate(test_type)
-    vardef3 =  ObjectSpace.each_object(Puppet::Parser::AST::VarDef).find {|x| x.name.value == 'cli_modules'}
-    expect(VariableStore.resolve(vardef3)).to eq("/etc/hammer/cli.modules.d")
+    vardef3 = ObjectSpace.each_object(Puppet::Parser::AST::VarDef).find { |x| x.name.value == 'cli_modules' }
+    expect(VariableStore.resolve(vardef3)).to eq('/etc/hammer/cli.modules.d')
   end
 
   describe '#add' do
     it 'should store the value correctly' do
-      test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
-      string1 = ObjectSpace.each_object(Puppet::Parser::AST::String).find {|x| x.to_s == "\"value1\"" }
-      expect(VariableStore.add(string1, 'blah')).to eq("blah")
+      test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
+      string1 = ObjectSpace.each_object(Puppet::Parser::AST::String).find { |x| x.to_s == "\"value1\"" }
+      expect(VariableStore.add(string1, 'blah')).to eq('blah')
       expect(VariableStore.lookup(string1)).to eq('blah')
     end
 
@@ -76,61 +76,59 @@ describe "variable_store" do
     end
 
     it 'should store vardef as is' do
-      test_type = @module.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = @module.types.find { |x| x.name == 'one_resource::another_resource' }
       VariableStore.populate(test_type)
     end
   end
 
   describe 'populate' do
-    let(:instance) {Utilities::PuppetModule.send :new}
+    let(:instance) { Utilities::PuppetModule.send :new }
 
     before :each do
-
     end
     it 'should load an resolve vars from the parent type' do
       m = instance
       m.module_path = @opts[:module_path]
       m.create_tmp_module_path(@opts[:module_path])
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       VariableStore.populate(test_type)
-      vars = {"$var1"=>"value1",
-       "$var2"=>"value2",
-       "$file_name"=>"/tmp/test3",
-       "$config_base_path"=>"/etc/hammer",
-       "$config_set"=>"param1_value",
-       "$concat_var"=>"/tmp/test3/test3183/oohhhh",
-       "$one_resource::params::param1_var1"=>"param1_value",
-       "$one_resource::params::var1"=>"params_class_value1",
-       "$one_resource::params::var2"=>"value2",
-       "$some_var"=>"oohhhh",
-       "$cli_modules"=>"/etc/hammer/cli.modules.d",
-       "$inherited_variable"=>"params_class_value1",
+      vars = { '$var1' => 'value1',
+               '$var2' => 'value2',
+               '$file_name' => '/tmp/test3',
+               '$config_base_path' => '/etc/hammer',
+               '$config_set' => 'param1_value',
+               '$concat_var' => '/tmp/test3/test3183/oohhhh',
+               '$one_resource::params::param1_var1' => 'param1_value',
+               '$one_resource::params::var1' => 'params_class_value1',
+               '$one_resource::params::var2' => 'value2',
+               '$some_var' => 'oohhhh',
+               '$cli_modules' => '/etc/hammer/cli.modules.d',
+               '$inherited_variable' => 'params_class_value1',
       }
-      vars.each do |k,v|
+      vars.each do |k, v|
         expect(VariableStore.instance.store.keys.include?(k)).to be true
         expect(VariableStore.instance.store[k]).to eq(v)
       end
     end
 
     xit 'should resolve a fact' do
-      #test_type = @module.types.find {|x| x.name == 'one_resource::inherits_params'}
+      # test_type = @module.types.find {|x| x.name == 'one_resource::inherits_params'}
     end
 
     it 'should resolve a parent parameter' do
       m = instance
       m.module_path = @opts[:module_path]
       m.create_tmp_module_path(@opts[:module_path])
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       VariableStore.populate(test_type)
       expect(VariableStore.instance.store['$config_set']).to eq('param1_value')
-
     end
 
     it 'should resolve a parent variable' do
       m = instance
       m.module_path = @opts[:module_path]
       m.create_tmp_module_path(@opts[:module_path])
-      test_type = m.types.find {|x| x.name == 'one_resource::another_resource'}
+      test_type = m.types.find { |x| x.name == 'one_resource::another_resource' }
       VariableStore.populate(test_type)
       expect(VariableStore.instance.store['$inherited_variable']).to eq('params_class_value1')
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-retrospec
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Corey Osman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-26 00:00:00.000000000 Z
+date: 2016-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trollop
@@ -52,6 +52,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: facets
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -174,8 +188,10 @@ extra_rdoc_files:
 files:
 - .document
 - .rspec
+- .rubocop.yml
 - .travis.yml
 - CHANGELOG.md
+- DEVELOPMENT.md
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -184,9 +200,17 @@ files:
 - VERSION
 - lib/retrospec-puppet.rb
 - lib/retrospec/plugins/v1/plugin/conditional.rb
+- lib/retrospec/plugins/v1/plugin/exceptions.rb
+- lib/retrospec/plugins/v1/plugin/generators.rb
 - lib/retrospec/plugins/v1/plugin/generators/fact_generator.rb
-- lib/retrospec/plugins/v1/plugin/generators/facter.rb
+- lib/retrospec/plugins/v1/plugin/generators/function_generator.rb
 - lib/retrospec/plugins/v1/plugin/generators/module_generator.rb
+- lib/retrospec/plugins/v1/plugin/generators/parsers/facter.rb
+- lib/retrospec/plugins/v1/plugin/generators/parsers/function.rb
+- lib/retrospec/plugins/v1/plugin/generators/parsers/type.rb
+- lib/retrospec/plugins/v1/plugin/generators/provider_generator.rb
+- lib/retrospec/plugins/v1/plugin/generators/schema_generator.rb
+- lib/retrospec/plugins/v1/plugin/generators/type_generator.rb
 - lib/retrospec/plugins/v1/plugin/helpers.rb
 - lib/retrospec/plugins/v1/plugin/puppet.rb
 - lib/retrospec/plugins/v1/plugin/puppet_module.rb
@@ -201,10 +225,19 @@ files:
 - spec/fixtures/facts/datacenter_facts.rb
 - spec/fixtures/facts/facts_with_methods.rb
 - spec/fixtures/facts/node_role.rb
+- spec/fixtures/facts/oracle_controls.rb
 - spec/fixtures/fixture_modules/one_resource_module/manifests/another_resource.pp
 - spec/fixtures/fixture_modules/one_resource_module/manifests/inherits_params.pp
 - spec/fixtures/fixture_modules/one_resource_module/manifests/one_resource_class.pp
 - spec/fixtures/fixture_modules/one_resource_module/manifests/params.pp
+- spec/fixtures/fixture_modules/required_parameters/manifests/init.pp
+- spec/fixtures/fixture_modules/sample_module/lib/facter/fix_installed.rb
+- spec/fixtures/fixture_modules/sample_module/lib/puppet/functions/awesome_parser.rb
+- spec/fixtures/fixture_modules/sample_module/lib/puppet/functions/reduce.rb
+- spec/fixtures/fixture_modules/sample_module/lib/puppet/parser/functions/bad_sha1.rb
+- spec/fixtures/fixture_modules/sample_module/lib/puppet/parser/functions/defined.rb
+- spec/fixtures/fixture_modules/sample_module/lib/puppet/parser/functions/sha1.rb
+- spec/fixtures/fixture_modules/sample_module/spec/unit/facter/fix_installed_spec.rb
 - spec/fixtures/fixture_modules/zero_resource_module/manifests/empty_class.pp
 - spec/fixtures/fixture_modules/zero_resource_module/manifests/not_a_resource_defination.pp
 - spec/fixtures/fixture_modules/zero_resource_module/metadata.json
@@ -680,6 +713,7 @@ files:
 - spec/fixtures/modules/stdlib/tests/has_ip_address.pp
 - spec/fixtures/modules/stdlib/tests/has_ip_network.pp
 - spec/fixtures/modules/stdlib/tests/init.pp
+- spec/fixtures/modules/tomcat/.bundle/config
 - spec/fixtures/modules/tomcat/.gitignore
 - spec/fixtures/modules/tomcat/.puppet-lint.rc
 - spec/fixtures/modules/tomcat/.travis.yml
@@ -698,6 +732,7 @@ files:
 - spec/fixtures/modules/tomcat/examples/instance_with_role_and_user.pp
 - spec/fixtures/modules/tomcat/examples/jsvc_install_from_source.pp
 - spec/fixtures/modules/tomcat/examples/multiple_instances.pp
+- spec/fixtures/modules/tomcat/files/.gitkeep
 - spec/fixtures/modules/tomcat/manifests/config/server.pp
 - spec/fixtures/modules/tomcat/manifests/config/server/connector.pp
 - spec/fixtures/modules/tomcat/manifests/config/server/context.pp
@@ -717,15 +752,30 @@ files:
 - spec/fixtures/modules/tomcat/manifests/setenv/entry.pp
 - spec/fixtures/modules/tomcat/manifests/war.pp
 - spec/fixtures/modules/tomcat/metadata.json
+- spec/fixtures/modules/tomcat/templates/.gitkeep
+- spec/fixtures/modules/tomcat/tests/.gitkeep
+- spec/fixtures/providers/bmc/ipmitool.rb
+- spec/fixtures/providers/bmcuser/ipmitool.rb
+- spec/fixtures/types/bmc.rb
+- spec/fixtures/types/bmcuser.rb
+- spec/fixtures/types/db_opatch.rb
 - spec/integration/retrospec_spec.rb
 - spec/spec_helper.rb
 - spec/unit/conditional_spec.rb
 - spec/unit/generators/fact_generater_spec.rb
-- spec/unit/generators/fact_spec.rb
+- spec/unit/generators/function_generator_spec.rb
+- spec/unit/generators/function_spec.rb
+- spec/unit/generators/parsers/fact_spec.rb
+- spec/unit/generators/parsers/provider_spec.rb
+- spec/unit/generators/parsers/type_spec.rb
+- spec/unit/generators/provider_generator_spec.rb
+- spec/unit/generators/schema_generator_spec.rb
+- spec/unit/generators/type_generator_spec.rb
 - spec/unit/module_spec.rb
 - spec/unit/plugin_spec.rb
 - spec/unit/puppet-retrospec_spec.rb
 - spec/unit/resource_spec.rb
+- spec/unit/spec_object_spec.rb
 - spec/unit/type_code_spec.rb
 - spec/unit/variable_store_spec.rb
 - vendor/gems/puppet-3.7.3/Gemfile

data/spec/unit/generators/fact_spec.rb

@@ -1,58 +0,0 @@
-require 'spec_helper'
-
-describe "facter" do
-
-  let(:file) do
-    File.join(fixtures_facts_path , 'node_role.rb')
-  end
-
-  it 'can eval code' do
-    models = Retrospec::Puppet::Generators::Facter.load_fact(file)
-    fact_name = models.facts.keys.first
-    fact_data = models.facts[fact_name]
-    confines = fact_data.confines
-    model_facts = models.facts[fact_name].used_facts
-    global_used_facts = models.global_used_facts
-    expect(fact_name).to eq(:node_role)
-    expect(confines).to eq([{:kernel=>"Windows"}, {:is_virtual=>true}])
-    expect(model_facts).to eq({})
-    expect(global_used_facts).to eq({})
-  end
-
-  describe 'multiple facts' do
-    let(:file) do
-      File.join(fixtures_facts_path , 'datacenter_facts.rb')
-    end
-
-    it 'can eval code with multiple facts' do
-      models = Retrospec::Puppet::Generators::Facter.load_fact(file)
-      global_used_facts = models[:global_used_facts]
-      fact_name = models.facts.keys.first
-      fact_data = models.facts[fact_name]
-      confines = fact_data.confines
-      model_facts = fact_data.used_facts
-      expect(fact_name).to eq(:fact1)
-      expect(confines).to eq([{:kernel=>"Linux"}])
-      expect(model_facts).to eq({})
-      expect(global_used_facts).to eq({})
-      fact_name = models.facts.keys.last
-      fact_data = models.facts[fact_name]
-      confines = fact_data.confines
-      model_facts = fact_data.used_facts
-      expect(fact_name).to eq(:fact2)
-      expect(confines).to eq([{:kernel=>"Windows"}])
-      expect(model_facts).to eq({})
-      expect(global_used_facts).to eq({})
-    end
-  end
-
-  describe 'fact value' do
-    let(:file) do
-      File.join(fixtures_facts_path , 'facts_with_methods.rb')
-    end
-    it 'can be processed' do
-      Retrospec::Puppet::Generators::Facter.load_fact(file)
-    end
-  end
-
-end