puppet-lint 4.2.0 → 4.2.1

data/spec/unit/puppet-lint/plugins/legacy_facts/legacy_facts_spec.rb

@@ -6,7 +6,7 @@ describe 'legacy_facts' do
       let(:code) { "$facts['os']['family']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -14,7 +14,7 @@ describe 'legacy_facts' do
       let(:code) { "$facts['ssh']['rsa']['key']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -22,87 +22,87 @@ describe 'legacy_facts' do
       let(:code) { '$osfamily' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
     context "fact variable using legacy $facts['osfamily']" do
       let(:code) { "$facts['osfamily']" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy $::osfamily' do
       let(:code) { '$::osfamily' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy $::blockdevice_sda_model' do
       let(:code) { '$::blockdevice_sda_model' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context "fact variable using legacy $facts['ipaddress6_em2']" do
       let(:code) { "$facts['ipaddress6_em2']" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy $::zone_foobar_uuid' do
       let(:code) { '$::zone_foobar_uuid' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy $::processor314' do
       let(:code) { '$::processor314' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy $::sp_l3_cache' do
       let(:code) { '$::sp_l3_cache' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy $::sshrsakey' do
       let(:code) { '$::sshrsakey' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable in interpolated string "${::osfamily}"' do
       let(:code) { '"start ${::osfamily} end"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
     context 'fact variable using legacy variable in double quotes "$::osfamily"' do
       let(:code) { '"$::osfamily"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
     end
 
@@ -110,7 +110,7 @@ describe 'legacy_facts' do
       let(:code) { %("${facts['osfamily']}") }
 
       it 'detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
     end
 
@@ -118,7 +118,7 @@ describe 'legacy_facts' do
       let(:code) { "$::facts['osfamily']" }
 
       it 'detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
     end
 
@@ -126,7 +126,7 @@ describe 'legacy_facts' do
       let(:code) { '$::facts[osfamily]' }
 
       it 'detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
     end
   end
@@ -144,7 +144,7 @@ describe 'legacy_facts' do
       let(:code) { "$facts['os']['family']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -152,7 +152,7 @@ describe 'legacy_facts' do
       let(:code) { "$facts['ssh']['rsa']['key']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -160,7 +160,7 @@ describe 'legacy_facts' do
       let(:code) { '$osfamily' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -168,8 +168,8 @@ describe 'legacy_facts' do
       let(:code) { "$facts['osfamily']" }
       let(:msg) { "legacy fact 'osfamily'" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the problem' do
@@ -185,7 +185,7 @@ describe 'legacy_facts' do
       let(:code) { "$::facts['os']['family']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -194,7 +194,7 @@ describe 'legacy_facts' do
       let(:msg) { "legacy fact 'osfamily'" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the problem' do
@@ -210,8 +210,8 @@ describe 'legacy_facts' do
       let(:code) { '$::osfamily' }
       let(:msg) { "legacy fact 'osfamily'" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the problem' do
@@ -227,8 +227,8 @@ describe 'legacy_facts' do
       let(:code) { '$::sshrsakey' }
       let(:msg) { "legacy fact 'sshrsakey'" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the problem' do
@@ -243,8 +243,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy $::memoryfree_mb' do
       let(:code) { '$::memoryfree_mb' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'continues to use the legacy fact' do
@@ -255,8 +255,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy $::blockdevice_sda_model' do
       let(:code) { '$::blockdevice_sda_model' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -267,8 +267,8 @@ describe 'legacy_facts' do
     context "fact variable using legacy $facts['ipaddress6_em2']" do
       let(:code) { "$facts['ipaddress6_em2']" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -279,8 +279,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy $::zone_foobar_uuid' do
       let(:code) { '$::zone_foobar_uuid' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -291,8 +291,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy $::processor314' do
       let(:code) { '$::processor314' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -303,8 +303,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy $::sp_l3_cache' do
       let(:code) { '$::sp_l3_cache' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -315,8 +315,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy $::sshrsakey' do
       let(:code) { '$::sshrsakey' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -327,8 +327,8 @@ describe 'legacy_facts' do
     context 'fact variable in interpolated string "${::osfamily}"' do
       let(:code) { '"start ${::osfamily} end"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -339,8 +339,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::osfamily"' do
       let(:code) { '"$::osfamily"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -351,8 +351,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::gid"' do
       let(:code) { '"$::gid"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -363,8 +363,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::id"' do
       let(:code) { '"$::id"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -375,8 +375,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbdistcodename"' do
       let(:code) { '"$::lsbdistcodename"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -387,8 +387,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbdistdescription"' do
       let(:code) { '"$::lsbdistdescription"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -399,8 +399,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbdistid"' do
       let(:code) { '"$::lsbdistid"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -411,8 +411,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbdistrelease"' do
       let(:code) { '"$::lsbdistrelease"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -423,8 +423,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbmajdistrelease"' do
       let(:code) { '"$::lsbmajdistrelease"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -435,8 +435,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbminordistrelease"' do
       let(:code) { '"$::lsbminordistrelease"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -447,8 +447,8 @@ describe 'legacy_facts' do
     context 'fact variable using legacy variable in double quotes "$::lsbrelease"' do
       let(:code) { '"$::lsbrelease"' }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
@@ -459,13 +459,21 @@ describe 'legacy_facts' do
     context "fact variable using facts hash in double quotes \"$facts['lsbrelease']\"" do
       let(:code) { "\"${facts['lsbrelease']}\"" }
 
-      it 'onlies detect a single problem' do
-        expect(problems).to have(1).problem
+      it 'only detect a single problem' do
+        expect(problems.size).to eq(1)
       end
 
       it 'uses the facts hash' do
         expect(manifest).to eq("\"${facts['os']['distro']['release']['specification']}\"")
       end
     end
+
+    context 'variable ending in the word fact' do
+      let(:code) { "$interface_facts['netmask']" }
+
+      it 'does not detect any problems' do
+        expect(problems.size).to eq(0)
+      end
+    end
   end
 end

data/spec/unit/puppet-lint/plugins/top_scope_facts/top_scope_facts_spec.rb

@@ -8,7 +8,7 @@ describe 'top_scope_facts' do
       let(:code) { "$facts['operatingsystem']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -16,7 +16,7 @@ describe 'top_scope_facts' do
       let(:code) { '$foo::bar' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -24,7 +24,7 @@ describe 'top_scope_facts' do
       let(:code) { "$::facts['os']['family']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -32,7 +32,7 @@ describe 'top_scope_facts' do
       let(:code) { "$::trusted['certname']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -40,7 +40,7 @@ describe 'top_scope_facts' do
       let(:code) { '$::fqdn' }
 
       it 'does not detect a single problem' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -48,14 +48,14 @@ describe 'top_scope_facts' do
       let(:code) { '$::profile::foo::bar' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
 
       context 'inside double quotes' do
         let(:code) { '"$::profile::foo::bar"' }
 
         it 'does not detect any problems' do
-          expect(problems).to have(0).problem
+          expect(problems).to be_empty
         end
       end
 
@@ -63,7 +63,7 @@ describe 'top_scope_facts' do
         let(:code) { '"${::profile::foo::bar}"' }
 
         it 'does not detect any problems' do
-          expect(problems).to have(0).problem
+          expect(problems).to be_empty
         end
       end
     end
@@ -82,7 +82,7 @@ describe 'top_scope_facts' do
       let(:code) { "$facts['operatingsystem']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -90,7 +90,7 @@ describe 'top_scope_facts' do
       let(:code) { '$foo::bar' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -98,7 +98,7 @@ describe 'top_scope_facts' do
       let(:code) { "$::facts['os']['family']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -106,7 +106,7 @@ describe 'top_scope_facts' do
       let(:code) { "$::trusted['certname']" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problem
+        expect(problems).to be_empty
       end
     end
 
@@ -119,7 +119,7 @@ describe 'top_scope_facts' do
         let(:code) { "$facts['operatingsystem']" }
 
         it 'does not detect any problems' do
-          expect(problems).to have(0).problem
+          expect(problems).to be_empty
         end
       end
 
@@ -127,23 +127,23 @@ describe 'top_scope_facts' do
         let(:code) { "$trusted['certname']" }
 
         it 'does not detect any problems' do
-          expect(problems).to have(0).problem
+          expect(problems).to be_empty
         end
       end
 
-      context 'whitelisted top scope variable $::location' do
+      context 'allowlisted top scope variable $::location' do
         let(:code) { '$::location' }
 
         it 'does not detect any problems' do
-          expect(problems).to have(0).problem
+          expect(problems).to be_empty
         end
       end
 
-      context 'non-whitelisted top scope variable $::application' do
+      context 'non-allowlisted top scope variable $::application' do
         let(:code) { '$::application' }
 
-        it 'does not detect any problems' do
-          expect(problems).to have(1).problem
+        it 'detects a problem' do
+          expect(problems).to contain_fixed('top scope fact instead of facts hash').on_line(1).in_column(1)
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
 platform: ruby
 authors:
 - Tim Sharpe
@@ -10,10 +10,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-29 00:00:00.000000000 Z
+date: 2023-10-09 00:00:00.000000000 Z
 dependencies: []
-description: "    Checks your Puppet manifests against the Puppetlabs style guide
-  and alerts you to any discrepancies.\n"
+description: |2
+      Checks your Puppet manifests against the Puppetlabs style guide and alerts you to any discrepancies.
+      Note: Support for this gem has been moved under a new namespace and as such any future updates from
+      the Puppet team will be released as `puppetlabs-puppet-lint`.
 email:
 - tim@sharpe.id.au
 - modules-team@puppet.com