puppet-lint 4.2.0 → 4.2.1

data/spec/unit/puppet-lint/plugins/check_conditionals/case_without_default_spec.rb

@@ -14,7 +14,7 @@ describe 'case_without_default' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -29,7 +29,7 @@ describe 'case_without_default' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -50,7 +50,7 @@ describe 'case_without_default' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -74,7 +74,7 @@ describe 'case_without_default' do
     end
 
     it 'detects two problems' do
-      expect(problems).to have(2).problems
+      expect(problems.size).to eq(2)
     end
 
     it 'creates two warnings' do
@@ -102,7 +102,7 @@ describe 'case_without_default' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -141,7 +141,7 @@ describe 'case_without_default' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 end

data/spec/unit/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb

@@ -16,7 +16,7 @@ describe 'selector_inside_resource' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -34,7 +34,7 @@ describe 'selector_inside_resource' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 end

data/spec/unit/puppet-lint/plugins/check_documentation/documentation_spec.rb

@@ -8,7 +8,7 @@ describe 'documentation' do
     let(:code) { 'class test {}' }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -25,7 +25,7 @@ describe 'documentation' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -39,7 +39,7 @@ describe 'documentation' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -51,7 +51,7 @@ describe 'documentation' do
     let(:code) { 'define test {}' }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -68,7 +68,7 @@ describe 'documentation' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 end

data/spec/unit/puppet-lint/plugins/check_nodes/unquoted_node_name_spec.rb

@@ -8,7 +8,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node foo { }' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -20,7 +20,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node default { }' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -28,7 +28,7 @@ describe 'unquoted_node_name' do
       let(:code) { "node 'foo' { }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -36,7 +36,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node /foo/ { }' }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -44,7 +44,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node foo, bar, baz { }' }
 
       it 'detects 3 problems' do
-        expect(problems).to have(3).problems
+        expect(problems.size).to eq(3)
       end
 
       it 'creates 3 warnings' do
@@ -58,7 +58,7 @@ describe 'unquoted_node_name' do
       let(:code) { "node foo, 'bar', baz { }" }
 
       it 'detects 2 problems' do
-        expect(problems).to have(2).problems
+        expect(problems.size).to eq(2)
       end
 
       it 'creates 2 warnings' do
@@ -71,7 +71,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node foo { } node bar { }' }
 
       it 'detects 2 problems' do
-        expect(problems).to have(2).problems
+        expect(problems.size).to eq(2)
       end
 
       it 'creates 2 warnings' do
@@ -84,7 +84,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node foo' }
 
       it 'detects a problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates 1 error' do
@@ -106,7 +106,7 @@ describe 'unquoted_node_name' do
       let(:code) { 'node foo { }' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -123,7 +123,7 @@ describe 'unquoted_node_name' do
       let(:fixed) { "node 'foo', 'bar', 'baz' { }" }
 
       it 'detects 3 problems' do
-        expect(problems).to have(3).problems
+        expect(problems.size).to eq(3)
       end
 
       it 'fixes the 3 problems' do
@@ -142,7 +142,7 @@ describe 'unquoted_node_name' do
       let(:fixed) { "node 'foo', 'bar', 'baz' { }" }
 
       it 'detects 2 problems' do
-        expect(problems).to have(2).problems
+        expect(problems.size).to eq(2)
       end
 
       it 'fixes the 2 problems' do

data/spec/unit/puppet-lint/plugins/check_resources/duplicate_params_spec.rb

@@ -16,7 +16,7 @@ describe 'duplicate_params' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates an error' do
@@ -37,7 +37,7 @@ describe 'duplicate_params' do
     end
 
     it 'does not detect any errors' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -54,7 +54,7 @@ describe 'duplicate_params' do
     end
 
     it 'only detects a single error' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates an error' do
@@ -77,7 +77,7 @@ describe 'duplicate_params' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates an error' do
@@ -96,7 +96,7 @@ describe 'duplicate_params' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -104,7 +104,7 @@ describe 'duplicate_params' do
     let(:code) { '}:' }
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 end

data/spec/unit/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb

@@ -8,7 +8,7 @@ describe 'ensure_first_param' do
       let(:code) { "file { 'foo': ensure => present }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -22,7 +22,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -37,7 +37,7 @@ describe 'ensure_first_param' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -56,7 +56,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -77,7 +77,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -93,7 +93,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
   end
@@ -111,7 +111,7 @@ describe 'ensure_first_param' do
       let(:code) { "file { 'foo': ensure => present }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -125,7 +125,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -149,7 +149,7 @@ describe 'ensure_first_param' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -172,7 +172,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -193,7 +193,7 @@ describe 'ensure_first_param' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -229,7 +229,7 @@ describe 'ensure_first_param' do
       end
 
       it 'detects a problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the problem' do

data/spec/unit/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb

@@ -15,7 +15,7 @@ describe 'ensure_not_symlink_target' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -29,7 +29,7 @@ describe 'ensure_not_symlink_target' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -58,7 +58,7 @@ describe 'ensure_not_symlink_target' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
 
       it 'does not modify the manifest' do
@@ -85,7 +85,7 @@ describe 'ensure_not_symlink_target' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the problem' do

data/spec/unit/puppet-lint/plugins/check_resources/file_mode_spec.rb

@@ -8,7 +8,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => '777' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -20,7 +20,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => '0777' }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -28,7 +28,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => $file_mode }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -36,7 +36,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => 'u=rw,og=r' }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -44,7 +44,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => undef }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -52,7 +52,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => 'undef' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -64,7 +64,7 @@ describe 'file_mode' do
       let(:code) { "file { '/etc/passwd': audit => [ owner, mode ], }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -72,7 +72,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => '777' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -84,7 +84,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => '0777' }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -92,7 +92,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => $concat_mode }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -100,7 +100,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => 'u=rw,og=r' }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -108,7 +108,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => undef }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -116,7 +116,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => 'undef' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -128,7 +128,7 @@ describe 'file_mode' do
       let(:code) { "concat { '/etc/passwd': audit => [ owner, mode ], }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -136,7 +136,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => lookup('bar'), }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -156,7 +156,7 @@ describe 'file_mode' do
       end
 
       it 'detects 3 problems' do
-        expect(problems).to have(3).problems
+        expect(problems.size).to eq(3)
       end
 
       it 'creates three warnings' do
@@ -180,7 +180,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => '777' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -196,7 +196,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => 'undef' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -212,7 +212,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => '777' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -228,7 +228,7 @@ describe 'file_mode' do
       let(:code) { "concat { 'foo': mode => 'undef' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -244,7 +244,7 @@ describe 'file_mode' do
       let(:code) { "file { 'foo': mode => lookup('bar'), }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
 
       it 'does not change the manifest' do
@@ -282,7 +282,7 @@ describe 'file_mode' do
       end
 
       it 'detects 3 problems' do
-        expect(problems).to have(3).problems
+        expect(problems.size).to eq(3)
       end
 
       it 'fixes 3 problems' do

data/spec/unit/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb

@@ -8,7 +8,7 @@ describe 'unquoted_file_mode' do
       let(:code) { "file { 'foo': mode => 0777 }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -20,7 +20,7 @@ describe 'unquoted_file_mode' do
       let(:code) { "concat { 'foo': mode => 0777 }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -32,7 +32,7 @@ describe 'unquoted_file_mode' do
       let(:code) { "file { 'foo': mode => lookup('bar'), }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -52,7 +52,7 @@ describe 'unquoted_file_mode' do
       end
 
       it 'detects 3 problems' do
-        expect(problems).to have(3).problems
+        expect(problems.size).to eq(3)
       end
 
       it 'creates three warnings' do
@@ -76,7 +76,7 @@ describe 'unquoted_file_mode' do
       let(:code) { "file { 'foo': mode => 0777 }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -92,7 +92,7 @@ describe 'unquoted_file_mode' do
       let(:code) { "concat { 'foo': mode => 0777 }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -108,7 +108,7 @@ describe 'unquoted_file_mode' do
       let(:code) { "file { 'foo': mode => lookup('bar'), }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
 
       it 'does not change the manifest' do
@@ -146,7 +146,7 @@ describe 'unquoted_file_mode' do
       end
 
       it 'detects 3 problems' do
-        expect(problems).to have(3).problems
+        expect(problems.size).to eq(3)
       end
 
       it 'fixes 3 problems' do