puppet-debugger 0.4.1 → 0.4.2

data/spec/spec_helper.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 require 'simplecov'
 require_relative '../lib/puppet-debugger'
 require 'yaml'
-ENV['COVERAGE'] = "true"
+ENV['COVERAGE'] = 'true'
 
 module SimpleCov::Configuration
   def clean_filters
@@ -15,9 +16,9 @@ SimpleCov.configure do
 end
 
 SimpleCov.start do
-  add_filter "/.rvm/"
-  add_filter "vendor"
-  add_filter "bundler"
+  add_filter '/.rvm/'
+  add_filter 'vendor'
+  add_filter 'bundler'
 end
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
@@ -25,10 +26,10 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 
 require 'rspec'
 require 'puppet-debugger'
-ENV['REPL_FACTERDB_FILTER'] = "operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^2\\.4/"
+ENV['REPL_FACTERDB_FILTER'] = 'operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^2\\.4/'
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 def stdlib_path
   File.join(Puppet[:basemodulepath].split(':').first, 'stdlib')
@@ -53,5 +54,5 @@ def supports_native_functions?
 end
 
 RSpec.configure do |config|
-  config.filter_run_excluding :native_functions => ! supports_native_functions?
+  config.filter_run_excluding native_functions: !supports_native_functions?
 end

data/spec/support_spec.rb

@@ -1,14 +1,14 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'tempfile'
 
 describe 'support' do
-
   let(:output) do
     StringIO.new('', 'w')
   end
 
   let(:debugger) do
-    PuppetDebugger::Cli.new(:out_buffer => output)
+    PuppetDebugger::Cli.new(out_buffer: output)
   end
 
   let(:scope) do
@@ -17,7 +17,7 @@ describe 'support' do
 
   describe 'play' do
     before(:each) do
-      allow(debugger).to receive(:fetch_url_data).with(file_url + ".txt").and_return(File.read(fixtures_file))
+      allow(debugger).to receive(:fetch_url_data).with(file_url + '.txt').and_return(File.read(fixtures_file))
     end
 
     let(:fixtures_file) do
@@ -59,17 +59,15 @@ describe 'support' do
   end
 
   after(:each) do
-    #manifest_file.close
+    # manifest_file.close
   end
 
   context '#function_map' do
-
     it 'should list functions' do
       func = debugger.function_map["#{puppet_version}::hiera"]
       expect(debugger.function_map).to be_instance_of(Hash)
-      expect(func).to eq({:name => 'hiera', :parent => puppet_version})
+      expect(func).to eq(name: 'hiera', parent: puppet_version)
     end
-
   end
 
   it 'should return a puppet version' do
@@ -95,9 +93,8 @@ describe 'support' do
   end
 
   describe 'convert  url' do
-
     describe 'unsupported' do
-      let(:url) { 'https://bitbuck.com/master/lib/log_helper.rb'}
+      let(:url) { 'https://bitbuck.com/master/lib/log_helper.rb' }
       let(:converted) { 'https://bitbuck.com/master/lib/log_helper.rb' }
       it do
         expect(debugger.convert_to_text(url)).to eq(converted)
@@ -105,7 +102,7 @@ describe 'support' do
     end
     describe 'gitlab' do
       describe 'blob' do
-        let(:url) { 'https://gitlab.com/nwops/pdebugger-web/blob/master/lib/log_helper.rb'}
+        let(:url) { 'https://gitlab.com/nwops/pdebugger-web/blob/master/lib/log_helper.rb' }
         let(:converted) { 'https://gitlab.com/nwops/pdebugger-web/raw/master/lib/log_helper.rb' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
@@ -113,7 +110,7 @@ describe 'support' do
       end
 
       describe 'raw' do
-        let(:url) { 'https://gitlab.com/nwops/pdebugger-web/raw/master/lib/log_helper.rb'}
+        let(:url) { 'https://gitlab.com/nwops/pdebugger-web/raw/master/lib/log_helper.rb' }
         let(:converted) { 'https://gitlab.com/nwops/pdebugger-web/raw/master/lib/log_helper.rb' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
@@ -121,18 +118,17 @@ describe 'support' do
       end
 
       describe 'snippet' do
-
         describe 'not raw' do
-          let(:url) { 'https://gitlab.com/snippets/19471'}
-          let(:converted) { 'https://gitlab.com/snippets/19471/raw'}
+          let(:url) { 'https://gitlab.com/snippets/19471' }
+          let(:converted) { 'https://gitlab.com/snippets/19471/raw' }
           it do
             expect(debugger.convert_to_text(url)).to eq(converted)
           end
         end
 
         describe 'raw' do
-          let(:url) { 'https://gitlab.com/snippets/19471/raw'}
-          let(:converted) { 'https://gitlab.com/snippets/19471/raw'}
+          let(:url) { 'https://gitlab.com/snippets/19471/raw' }
+          let(:converted) { 'https://gitlab.com/snippets/19471/raw' }
           it do
             expect(debugger.convert_to_text(url)).to eq(converted)
           end
@@ -141,37 +137,36 @@ describe 'support' do
     end
     describe 'github' do
       describe 'raw' do
-        let(:url) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw'}
+        let(:url) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw' }
         let(:converted) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
         end
       end
       describe 'raw' do
-        let(:url) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0'}
+        let(:url) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0' }
         let(:converted) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0.txt' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
         end
       end
       describe 'raw gist' do
-        let(:url) {'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw/c8f6be52da5b2b0eeaabb9aa75832b75793d35d1/controls.pp'}
-        let(:converted) {'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw/c8f6be52da5b2b0eeaabb9aa75832b75793d35d1/controls.pp'}
+        let(:url) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw/c8f6be52da5b2b0eeaabb9aa75832b75793d35d1/controls.pp' }
+        let(:converted) { 'https://gist.githubusercontent.com/logicminds/f9b1ac65a3a440d562b0/raw/c8f6be52da5b2b0eeaabb9aa75832b75793d35d1/controls.pp' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
         end
       end
       describe 'raw non gist' do
-        let(:url) { 'https://raw.githubusercontent.com/nwops/puppet-debugger/master/lib/puppet-debugger.rb'}
+        let(:url) { 'https://raw.githubusercontent.com/nwops/puppet-debugger/master/lib/puppet-debugger.rb' }
         let(:converted) { 'https://raw.githubusercontent.com/nwops/puppet-debugger/master/lib/puppet-debugger.rb' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
         end
-
       end
 
       describe 'blob' do
-        let(:url) { 'https://github.com/nwops/puppet-debugger/blob/master/lib/puppet-debugger.rb'}
+        let(:url) { 'https://github.com/nwops/puppet-debugger/blob/master/lib/puppet-debugger.rb' }
         let(:converted) { 'https://github.com/nwops/puppet-debugger/raw/master/lib/puppet-debugger.rb' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)
@@ -179,7 +174,7 @@ describe 'support' do
       end
 
       describe 'gist' do
-        let(:url) { 'https://gist.github.com/logicminds/f9b1ac65a3a440d562b0'}
+        let(:url) { 'https://gist.github.com/logicminds/f9b1ac65a3a440d562b0' }
         let(:converted) { 'https://gist.github.com/logicminds/f9b1ac65a3a440d562b0.txt' }
         it do
           expect(debugger.convert_to_text(url)).to eq(converted)

data/test_matrix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'yaml'
 require 'fileutils'
 @threads = {}
@@ -5,14 +6,14 @@ require 'fileutils'
 def run_container(image, puppet_version)
   pversion = puppet_version.match(/([\d\.]+)/)[0]
   ruby_version = image.split(':').last
-  dir = File.join('.','local_test_results', pversion, ruby_version)
+  dir = File.join('.', 'local_test_results', pversion, ruby_version)
   real_dir = File.expand_path(dir)
   FileUtils.rm_rf(real_dir)
   FileUtils.mkdir_p(real_dir)
   cmd = "docker run -e OUT_DIR='#{dir}' -e RUBY_VERSION='#{ruby_version}' -e PUPPET_GEM_VERSION='#{puppet_version}' --rm -ti -v ${PWD}:/module --workdir /module #{image} /bin/bash run_container_test.sh"
   File.write(File.join(real_dir, 'command.txt'), cmd)
   output = `#{cmd}`
-  if $?.success?
+  if $CHILD_STATUS.success?
     File.write(File.join(dir, 'success.txt'), output)
   else
     File.write(File.join(dir, 'error.txt'), output)
@@ -39,4 +40,4 @@ matrix.each do |id, item|
   end
 end
 
-@threads.each {|id, thr| thr.join } # wait on thread to finish
+@threads.each { |_id, thr| thr.join } # wait on thread to finish

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-debugger
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Corey Osman
@@ -79,7 +79,11 @@ files:
 - ".document"
 - ".gitignore"
 - ".gitlab-ci.yml"
+- ".release_me.yaml"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - DEVELOPMENT.md
 - Gemfile
@@ -117,8 +121,8 @@ files:
 - spec/fixtures/sample_manifest.pp
 - spec/fixtures/sample_start_debugger.pp
 - spec/pdb_spec.rb
-- spec/puppet-debugger_spec.rb
 - spec/puppet/application/debugger_spec.rb
+- spec/puppet_debugger_spec.rb
 - spec/remote_node_spec.rb
 - spec/spec_helper.rb
 - spec/support_spec.rb