puppet-debugger 0.4.1 → 0.4.2

data/lib/puppet-debugger.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'puppet-debugger/cli'
 require_relative 'version'
 require 'awesome_print'
@@ -9,13 +10,33 @@ require_relative 'puppet-debugger/debugger_code'
 require_relative 'puppet-debugger/support/errors'
 # monkey patch in some color effects string methods
 class String
-  def red;            "\033[31m#{self}\033[0m" end
-  def green;          "\033[32m#{self}\033[0m" end
-  def cyan;           "\033[36m#{self}\033[0m" end
-  def yellow;         "\033[33m#{self}\033[0m" end
-  def warning;        yellow                   end
-  def fatal;          red                      end
-  def info;           green                    end
+  def red
+    "\033[31m#{self}\033[0m"
+  end
+
+  def green
+    "\033[32m#{self}\033[0m"
+  end
+
+  def cyan
+    "\033[36m#{self}\033[0m"
+  end
+
+  def yellow
+    "\033[33m#{self}\033[0m"
+  end
+
+  def warning
+    yellow
+  end
+
+  def fatal
+    red
+  end
+
+  def info
+    green
+  end
 
   def camel_case
     return self if self !~ /_/ && self =~ /[A-Z]+.*/
@@ -29,25 +50,25 @@ Puppet::Util::Log.newdesttype :buffer do
 
   attr_accessor :err_buffer, :out_buffer
 
-  def initialize(err=$stderr, out=$stdout)
+  def initialize(err = $stderr, out = $stdout)
     @err_buffer = err
     @out_buffer = out
   end
 
   def handle(msg)
     levels = {
-      :emerg   => { :name => 'Emergency', :color => :hred,  :stream => err_buffer },
-      :alert   => { :name => 'Alert',     :color => :hred,  :stream => err_buffer },
-      :crit    => { :name => 'Critical',  :color => :hred,  :stream => err_buffer },
-      :err     => { :name => 'Error',     :color => :hred,  :stream => err_buffer },
-      :warning => { :name => 'Warning',   :color => :hred,  :stream => err_buffer },
-      :notice  => { :name => 'Notice',    :color => :reset, :stream => out_buffer },
-      :info    => { :name => 'Info',      :color => :green, :stream => out_buffer },
-      :debug   => { :name => 'Debug',     :color => :cyan,  :stream => out_buffer },
+      emerg: { name: 'Emergency', color: :hred,  stream: err_buffer },
+      alert: { name: 'Alert',     color: :hred,  stream: err_buffer },
+      crit: { name: 'Critical', color: :hred, stream: err_buffer },
+      err: { name: 'Error', color: :hred, stream: err_buffer },
+      warning: { name: 'Warning', color: :hred, stream: err_buffer },
+      notice: { name: 'Notice', color: :reset, stream: out_buffer },
+      info: { name: 'Info', color: :green, stream: out_buffer },
+      debug: { name: 'Debug', color: :cyan, stream: out_buffer }
     }
 
     str = msg.respond_to?(:multiline) ? msg.multiline : msg.to_s
-    str = msg.source == "Puppet" ? str : "#{msg.source}: #{str}"
+    str = msg.source == 'Puppet' ? str : "#{msg.source}: #{str}"
 
     level = levels[msg.level]
     level[:stream].puts colorize(level[:color], "#{level[:name]}: #{str}")

data/lib/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module PuppetDebugger
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

data/spec/facts_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe 'facts' do
   let(:debugger) do
-    PuppetDebugger::Cli.new(:out_buffer => output)
+    PuppetDebugger::Cli.new(out_buffer: output)
   end
 
   let(:puppet_version) do
@@ -28,7 +29,7 @@ describe 'facts' do
       expect(facter_version).to eq('/^2\.4/')
     end
     it 'return default filter' do
-      expect(debugger.dynamic_facterdb_filter).to eq("operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^2\\.4/")
+      expect(debugger.dynamic_facterdb_filter).to eq('operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^2\\.4/')
     end
     it 'get node_facts' do
       expect(debugger.node_facts).to be_instance_of(Hash)
@@ -58,7 +59,7 @@ describe 'facts' do
       expect(facter_version).to eq('/^3\.1/')
     end
     it 'return default filter' do
-      expect(debugger.dynamic_facterdb_filter).to eq("operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^3\\.1/")
+      expect(debugger.dynamic_facterdb_filter).to eq('operatingsystem=Fedora and operatingsystemrelease=23 and architecture=x86_64 and facterversion=/^3\\.1/')
     end
   end
 
@@ -68,10 +69,10 @@ describe 'facts' do
         ENV['DEBUGGER_FACTERDB_FILTER'] = 'facterversion=/^6\.5/'
       end
       it 'return filter' do
-        expect(debugger.dynamic_facterdb_filter).to eq("facterversion=/^6\\.5/")
+        expect(debugger.dynamic_facterdb_filter).to eq('facterversion=/^6\\.5/')
       end
       it 'throws error' do
-        expect{debugger.default_facts}.to raise_error(PuppetDebugger::Exception::BadFilter)
+        expect { debugger.default_facts }.to raise_error(PuppetDebugger::Exception::BadFilter)
       end
     end
     describe 'good filter' do
@@ -79,7 +80,7 @@ describe 'facts' do
         ENV['DEBUGGER_FACTERDB_FILTER'] = 'facterversion=/^3\.1/'
       end
       it 'return filter' do
-        expect(debugger.dynamic_facterdb_filter).to eq("facterversion=/^3\\.1/")
+        expect(debugger.dynamic_facterdb_filter).to eq('facterversion=/^3\\.1/')
       end
     end
   end

data/spec/pdb_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe 'pdb' do

data/spec/puppet/application/debugger_spec.rb

@@ -1,4 +1,5 @@
 #! /usr/bin/env ruby
+# frozen_string_literal: true
 require 'spec_helper'
 
 require 'puppet/application/debugger'
@@ -24,7 +25,7 @@ describe Puppet::Application::Debugger do
     debugger.initialize_app_defaults
   end
 
-  it "declare a main command" do
+  it 'declare a main command' do
     expect(debugger).to respond_to(:main)
   end
 
@@ -54,7 +55,6 @@ describe Puppet::Application::Debugger do
   # runonce
   # test
 
-
   # it 'create a node' do
   #   require 'pry'; binding.pry
   #   expect(node).to be_a(Puppet::Node::Environment)
@@ -63,5 +63,4 @@ describe Puppet::Application::Debugger do
   # it 'create a scope' do
   #   expect(scope).to be_a(Puppet::Node::Environment)
   # end
-
 end

data/spec/{puppet-debugger_spec.rb → puppet_debugger_spec.rb}

@@ -1,7 +1,7 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'stringio'
-describe "PuppetDebugger" do
-
+describe 'PuppetDebugger' do
   let(:resource) do
     "service{'httpd': ensure => running}"
   end
@@ -15,7 +15,7 @@ describe "PuppetDebugger" do
   end
 
   let(:debugger) do
-    PuppetDebugger::Cli.new({:out_buffer => output}.merge(options))
+    PuppetDebugger::Cli.new({ out_buffer: output }.merge(options))
   end
 
   let(:options) do
@@ -45,7 +45,7 @@ describe "PuppetDebugger" do
       end
       it do
         debugger.handle_input(input)
-        debugger.handle_input("include testfoo")
+        debugger.handle_input('include testfoo')
         expect(debugger.scope.compiler.catalog.classes).to include('testfoo')
       end
       it do
@@ -79,7 +79,7 @@ describe "PuppetDebugger" do
     end
   end
 
-  describe 'native functions', :native_functions => true do
+  describe 'native functions', native_functions: true do
     let(:func) do
       <<-EOF
       function debugger::bool2http($arg) {
@@ -113,10 +113,9 @@ describe "PuppetDebugger" do
   end
 
   describe 'types' do
-
     describe 'string' do
       let(:input) do
-        "String"
+        'String'
       end
       it 'shows type' do
         debugger.handle_input(input)
@@ -125,14 +124,13 @@ describe "PuppetDebugger" do
     end
     describe 'Array' do
       let(:input) do
-        "type_of([1,2,3,4])"
+        'type_of([1,2,3,4])'
       end
       it 'shows type' do
         debugger.handle_input(input)
         expect(output.string).to eq("\n => Tuple[Integer[1, 1], Integer[2, 2], Integer[3, 3], Integer[4, 4]]\n")
       end
     end
-
   end
 
   describe 'multiple lines of input' do
@@ -154,9 +152,9 @@ describe "PuppetDebugger" do
       it do
         debugger.play_back_string(input)
         expect(output.string).to include("$var1 = 'test'")
-        expect(output.string).to include("\"test\"")
+        expect(output.string).to include('"test"')
         expect(output.string).to include("$var2 = 'test2'")
-        expect(output.string).to include("\"test2\"")
+        expect(output.string).to include('"test2"')
       end
     end
     describe '1 lines' do
@@ -166,7 +164,7 @@ describe "PuppetDebugger" do
       it do
         debugger.play_back_string(input)
         expect(output.string).to include("$var1 = 'test'")
-        expect(output.string).to include("\"test\"")
+        expect(output.string).to include('"test"')
       end
     end
   end
@@ -194,7 +192,7 @@ describe "PuppetDebugger" do
 
   describe 'empty' do
     let(:input) do
-      ""
+      ''
     end
     it 'can run' do
       debugger_output = "\n"
@@ -203,7 +201,7 @@ describe "PuppetDebugger" do
     end
     describe 'space' do
       let(:input) do
-        " "
+        ' '
       end
       it 'can run' do
         debugger_output = "\n"
@@ -215,7 +213,7 @@ describe "PuppetDebugger" do
 
   describe 'krt' do
     let(:input) do
-      "krt"
+      'krt'
     end
     it 'can run' do
       debugger_output = /hostclasses/
@@ -269,7 +267,7 @@ describe "PuppetDebugger" do
 
   describe 'bad input' do
     let(:input) do
-      "Service{"
+      'Service{'
     end
     it 'can process' do
       debugger_output = "\n => \e[31mSyntax error at end of file\e[0m\n"
@@ -280,7 +278,7 @@ describe "PuppetDebugger" do
 
   describe 'classification' do
     let(:input) do
-      "classification"
+      'classification'
     end
 
     it 'can process a file' do
@@ -305,7 +303,7 @@ describe "PuppetDebugger" do
 
     describe 'loglevel' do
       it 'has not changed' do
-        debugger.handle_input(":set loglevel debug")
+        debugger.handle_input(':set loglevel debug')
         expect(Puppet::Util::Log.level).to eq(:debug)
         expect(Puppet::Util::Log.destinations[:buffer].name).to eq(:buffer)
         debugger.handle_input('reset')
@@ -339,7 +337,7 @@ describe "PuppetDebugger" do
 
   describe 'facts' do
     let(:input) do
-      "$::fqdn"
+      '$::fqdn'
     end
     it 'should be able to resolve fqdn' do
       debugger_output = /foo\.example\.com/
@@ -350,7 +348,7 @@ describe "PuppetDebugger" do
 
   describe 'print facts' do
     let(:input) do
-      "facts"
+      'facts'
     end
     it 'should be able to print facts' do
       debugger_output = /kernel/
@@ -394,7 +392,7 @@ describe "PuppetDebugger" do
 
   describe 'set' do
     let(:input) do
-      ":set loglevel debug"
+      ':set loglevel debug'
     end
     it 'should set the loglevel' do
       debugger_output = /loglevel debug is set/
@@ -407,7 +405,7 @@ describe "PuppetDebugger" do
 
   describe 'vars' do
     let(:input) do
-      "vars"
+      'vars'
     end
     it 'display facts variable' do
       debugger_output = /facts/
@@ -427,10 +425,9 @@ describe "PuppetDebugger" do
     it 'display local variable' do
       debugger.handle_input("$var1 = 'value1'")
       expect(output.string).to match(/value1/)
-      debugger.handle_input("$var1")
+      debugger.handle_input('$var1')
       expect(output.string).to match(/value1/)
     end
-
   end
 
   describe 'execute functions' do
@@ -438,12 +435,12 @@ describe "PuppetDebugger" do
       "md5('hello')"
     end
     it 'execute md5' do
-      debugger_output =  /5d41402abc4b2a76b9719d911017c592/
+      debugger_output = /5d41402abc4b2a76b9719d911017c592/
       debugger.handle_input(input)
       expect(output.string).to match(debugger_output)
     end
     it 'execute swapcase' do
-      debugger_output =  /HELLO/
+      debugger_output = /HELLO/
       debugger.handle_input("swapcase('hello')")
       expect(output.string).to match(debugger_output)
     end
@@ -455,8 +452,8 @@ describe "PuppetDebugger" do
     end
     let(:options) do
       {
-          source_file: input,
-          source_line: 10,
+        source_file: input,
+        source_line: 10
       }
     end
 
@@ -466,7 +463,6 @@ describe "PuppetDebugger" do
     it 'contains marker' do
       expect(debugger.whereami).to match(/\s+=>\s10/)
     end
-
   end
 
   describe 'error message' do
@@ -475,18 +471,16 @@ describe "PuppetDebugger" do
     end
     if Gem::Version.new(Puppet.version) >= Gem::Version.new('4.0')
       it 'show error message' do
-        debugger_output =  /no\ parameter\ named\ 'contact'/
+        debugger_output = /no\ parameter\ named\ 'contact'/
         debugger.handle_input(input)
         expect(output.string).to match(debugger_output)
       end
     else
       it 'show error message' do
-        debugger_output =  /Invalid\ parameter\ contact/
+        debugger_output = /Invalid\ parameter\ contact/
         debugger.handle_input(input)
         expect(output.string).to match(debugger_output)
       end
     end
-
   end
-
 end

data/spec/remote_node_spec.rb

@@ -1,7 +1,7 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'stringio'
-describe "PuppetDebugger" do
-
+describe 'PuppetDebugger' do
   let(:resource) do
     "service{'httpd': ensure => running}"
   end
@@ -15,7 +15,7 @@ describe "PuppetDebugger" do
   end
 
   let(:debugger) do
-    PuppetDebugger::Cli.new(:out_buffer => output)
+    PuppetDebugger::Cli.new(out_buffer: output)
   end
 
   let(:input) do
@@ -43,13 +43,13 @@ describe "PuppetDebugger" do
         expect(output.string).to eq("\n => Resetting to use node puppetdev.localdomain\n")
       end
 
-      it "return node name" do
+      it 'return node name' do
         output.reopen # removes previous message
         debugger.handle_input('$::hostname')
         expect(output.string).to match(/puppetdev.localdomain/)
       end
 
-      it "return classification" do
+      it 'return classification' do
         output.reopen # removes previous message
         debugger.handle_input('classification')
         expect(output.string).to match(/stdlib/)
@@ -65,7 +65,6 @@ describe "PuppetDebugger" do
         debugger.handle_input(input)
         expect(output.string).to match(debugger_output)
       end
-
     end
     describe 'use defaults when invalid' do
       let(:node_obj) do
@@ -75,12 +74,12 @@ describe "PuppetDebugger" do
         'invalid.localdomain'
       end
       it 'name' do
-        expect{debugger.node.name}.to raise_error(PuppetDebugger::Exception::UndefinedNode)
+        expect { debugger.node.name }.to raise_error(PuppetDebugger::Exception::UndefinedNode)
       end
     end
 
     it 'set node name' do
-      expect(debugger.remote_node_name = 'puppetdev.localdomain').to eq("puppetdev.localdomain")
+      expect(debugger.remote_node_name = 'puppetdev.localdomain').to eq('puppetdev.localdomain')
     end
 
     describe 'print classes' do
@@ -96,7 +95,7 @@ describe "PuppetDebugger" do
 
     describe 'vars' do
       let(:input) do
-        "vars"
+        'vars'
       end
       it 'display facts variable' do
         debugger_output = /facts/
@@ -116,11 +115,11 @@ describe "PuppetDebugger" do
       it 'display local variable' do
         debugger.handle_input("$var1 = 'value1'")
         expect(output.string).to match(/value1/)
-        debugger.handle_input("$var1")
+        debugger.handle_input('$var1')
         expect(output.string).to match(/value1/)
       end
       it 'display productname variable' do
-        debugger.handle_input("$productname")
+        debugger.handle_input('$productname')
         expect(output.string).to match(/VMware Virtual Platform/)
       end
     end
@@ -130,12 +129,12 @@ describe "PuppetDebugger" do
         "md5('hello')"
       end
       it 'execute md5' do
-        debugger_output =  /5d41402abc4b2a76b9719d911017c592/
+        debugger_output = /5d41402abc4b2a76b9719d911017c592/
         debugger.handle_input(input)
         expect(output.string).to match(debugger_output)
       end
       it 'execute swapcase' do
-        debugger_output =  /HELLO/
+        debugger_output = /HELLO/
         debugger.handle_input("swapcase('hello')")
         expect(output.string).to match(debugger_output)
       end
@@ -158,7 +157,7 @@ describe "PuppetDebugger" do
 
     describe 'classification' do
       let(:input) do
-        "classification"
+        'classification'
       end
 
       it 'shows certificate_authority_host' do