publify_core 9.1.0 → 9.2.0

data/app/helpers/blog_helper.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module BlogHelper
   # The base URL for this request, calculated by looking up the URL for the main
   # blog index page.
   def blog_base_url
-    url_for(controller: '/articles', action: 'index').gsub(%r{/$}, '')
+    url_for(controller: "/articles", action: "index").gsub(%r{/$}, "")
   end
 
   # Find the blog whose base_url matches the current location.
   def this_blog
-    @blog ||= Blog.find_blog(blog_base_url)
+    @this_blog ||= Blog.find_blog(blog_base_url)
   end
 end

data/app/helpers/xml_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module XmlHelper
   def collection_lastmod(collection)
     article_updated = collection.contents.order(updated_at: :desc).first

data/app/jobs/application_job.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
 end

data/app/mailers/notification_mailer.rb

@@ -1,4 +1,6 @@
-class NotificationMailer < ActionMailer::Base
+# frozen_string_literal: true
+
+class NotificationMailer < ApplicationMailer
   helper :base
   layout nil
 
@@ -20,7 +22,7 @@ class NotificationMailer < ActionMailer::Base
     @user = user
     # TODO: Make user blog-dependent
     @blog = Blog.first
-    build_mail @blog, @user, 'Welcome to Publify'
+    build_mail @blog, @user, "Welcome to Publify"
   end
 
   private
@@ -30,7 +32,7 @@ class NotificationMailer < ActionMailer::Base
   end
 
   def build_mail(blog, user, subject)
-    headers['X-Mailer'] = "Publify #{PublifyCore::VERSION}"
+    headers["X-Mailer"] = "Publify #{PublifyCore::VERSION}"
     mail(from: blog.email_from,
          to: user.email,
          subject: make_subject(blog, subject))

data/app/models/ability.rb

@@ -1,4 +1,6 @@
-require 'cancancan'
+# frozen_string_literal: true
+
+require "cancancan"
 
 class Ability
   include CanCan::Ability
@@ -7,14 +9,14 @@ class Ability
     return unless user
 
     case user.profile
-    when 'admin'
+    when "admin"
       add_admin_abilities
       add_publisher_abilities
       add_contributor_abilities
-    when 'publisher'
+    when "publisher"
       add_publisher_abilities
       add_contributor_abilities
-    when 'contributor'
+    when "contributor"
       add_contributor_abilities
     end
   end
@@ -22,30 +24,30 @@ class Ability
   private
 
   def add_admin_abilities
-    can :manage, 'admin/migrations'
-    can :manage, 'admin/seo'
-    can :manage, 'admin/settings'
-    can :manage, 'admin/sidebar'
-    can :manage, 'admin/textfilters'
-    can :manage, 'admin/themes'
-    can :manage, 'admin/users'
+    can :manage, "admin/migrations"
+    can :manage, "admin/seo"
+    can :manage, "admin/settings"
+    can :manage, "admin/sidebar"
+    can :manage, "admin/textfilters"
+    can :manage, "admin/themes"
+    can :manage, "admin/users"
   end
 
   def add_publisher_abilities
-    can :manage, 'admin/content'
-    can :manage, 'admin/feedback'
-    can :manage, 'admin/notes'
-    can :manage, 'admin/pages'
-    can :manage, 'admin/post_types'
-    can :manage, 'admin/redirects'
-    can :manage, 'admin/resources'
-    can :manage, 'admin/tags'
-
-    can :manage, 'articles'
+    can :manage, "admin/content"
+    can :manage, "admin/feedback"
+    can :manage, "admin/notes"
+    can :manage, "admin/pages"
+    can :manage, "admin/post_types"
+    can :manage, "admin/redirects"
+    can :manage, "admin/resources"
+    can :manage, "admin/tags"
+
+    can :manage, "articles"
   end
 
   def add_contributor_abilities
-    can :manage, 'admin/dashboard'
-    can :manage, 'admin/profiles'
+    can :manage, "admin/dashboard"
+    can :manage, "admin/profiles"
   end
 end

data/app/models/archives_sidebar.rb

@@ -1,17 +1,20 @@
+# frozen_string_literal: true
+
 class ArchivesSidebar < Sidebar
-  description 'Displays links to monthly archives'
-  setting :title, 'Archives'
-  setting :show_count, true, label: 'Show article counts', input_type: :checkbox
-  setting :count, 10, label: 'Number of Months'
+  description "Displays links to monthly archives"
+  setting :title, "Archives"
+  setting :show_count, true, label: "Show article counts", input_type: :checkbox
+  setting :count, 10, label: "Number of Months"
 
   attr_accessor :archives
 
   def self.date_funcs
-    @date_func ||=
-      if Content.connection.class.name =~ /SQLite3Adapter/
+    @date_funcs ||=
+      if /SQLite3Adapter/.match?(Content.connection.class.name)
         ["strftime('%Y', published_at) as year", "strftime('%m', published_at) as month"]
       else
-        ['extract(year from published_at) as year', 'extract(month from published_at) as month']
+        ["extract(year from published_at) as year",
+         "extract(month from published_at) as month"]
       end
   end
 
@@ -23,17 +26,17 @@ class ArchivesSidebar < Sidebar
     # DB-specific code.
     date_funcs = self.class.date_funcs
 
-    article_counts = Article.published.select('count(*) as count', *date_funcs).
-      group(:year, :month).reorder('year desc', 'month desc').limit(count.to_i)
+    article_counts = Article.published.select("count(*) as count", *date_funcs).
+      group(:year, :month).reorder("year desc", "month desc").limit(count.to_i)
 
     @archives = article_counts.map do |entry|
       month = entry.month.to_i
       year = entry.year.to_i
       {
-        name: I18n.l(Date.new(year, month), format: '%B %Y'),
+        name: I18n.l(Date.new(year, month), format: "%B %Y"),
         month: month,
         year: year,
-        article_count: entry.count
+        article_count: entry.count,
       }
     end
   end

data/app/models/article.rb

@@ -1,6 +1,8 @@
-require 'aasm'
-require 'uri'
-require 'net/http'
+# frozen_string_literal: true
+
+require "aasm"
+require "uri"
+require "net/http"
 
 class Article < Content
   include PublifyGuid
@@ -19,26 +21,26 @@ class Article < Content
   has_many :triggers, as: :pending_item
   has_many :comments, dependent: :destroy
 
-  before_create :create_guid
   before_save :set_permalink
+  before_create :create_guid
   after_save :keywords_to_tags, :shorten_url
 
   scope :child_of, ->(article_id) { where(parent_id: article_id) }
-  scope :published_since, ->(time) { published.where('published_at > ?', time) }
-  scope :withdrawn, -> { where(state: 'withdrawn').order(default_order) }
-  scope :pending, -> { where(state: 'publication_pending'). order(default_order) }
+  scope :published_since, ->(time) { published.where("published_at > ?", time) }
+  scope :withdrawn, -> { where(state: "withdrawn").order(default_order) }
+  scope :pending, -> { where(state: "publication_pending").order(default_order) }
 
   scope :bestof, lambda {
     joins(:feedback).
-      where('feedback.type' => 'Comment',
-            'contents.state' => 'published').
-      group('contents.id').
-      order('count(feedback.id) DESC').
-      select('contents.*, count(feedback.id) as comment_count').
+      where("feedback.type" => "Comment",
+            "contents.state" => "published").
+      group("contents.id").
+      select("contents.*, count(feedback.id) as comment_count").
+      order("comment_count DESC").
       limit(5)
   }
 
-  setting :password, :string, ''
+  setting :password, :string, ""
 
   attr_accessor :draft, :keywords
 
@@ -77,6 +79,7 @@ class Article < Content
 
   def set_permalink
     return if draft? || permalink.present?
+
     self.permalink = title.to_permalink
   end
 
@@ -86,7 +89,7 @@ class Article < Content
 
   def post_type
     post_type = self[:post_type]
-    post_type = 'read' if post_type.blank?
+    post_type = "read" if post_type.blank?
     post_type
   end
 
@@ -99,16 +102,20 @@ class Article < Content
   def self.search_with(params)
     params ||= {}
     scoped = super(params)
-    scoped = scoped.send(params[:state]) if %w(no_draft drafts published withdrawn pending).include?(params[:state])
+    if %w(no_draft drafts published withdrawn pending).include?(params[:state])
+      scoped = scoped.send(params[:state])
+    end
 
-    scoped.order('created_at DESC')
+    scoped.order("created_at DESC")
   end
 
   # FIXME: Use keyword params to clean up call sites.
   def permalink_url(anchor = nil, only_path = false)
     return unless published?
+
     @cached_permalink_url ||= {}
-    @cached_permalink_url["#{anchor}#{only_path}"] ||= blog.url_for(permalink_url_options, anchor: anchor, only_path: only_path)
+    @cached_permalink_url["#{anchor}#{only_path}"] ||=
+      blog.url_for(permalink_url_options, anchor: anchor, only_path: only_path)
   end
 
   def save_attachments!(files)
@@ -129,28 +136,30 @@ class Article < Content
   end
 
   def feed_url(format)
-    "#{permalink_url}.#{format.gsub(/\d/, '')}"
+    "#{permalink_url}.#{format.gsub(/\d/, "")}"
   end
 
   def next
-    Article.where('published_at > ?', published_at).order('published_at asc').limit(1).first
+    Article.where("published_at > ?", published_at).order("published_at asc").
+      limit(1).first
   end
 
   def previous
-    Article.where('published_at < ?', published_at).order('published_at desc').limit(1).first
+    Article.where("published_at < ?", published_at).order("published_at desc").
+      limit(1).first
   end
 
   def publication_month
-    published_at.strftime('%Y-%m')
+    published_at.strftime("%Y-%m")
   end
 
   def self.publication_months
-    result = select('published_at').where('published_at is not NULL').where(type: 'Article')
+    result = select("published_at").where("published_at is not NULL").where(type: "Article")
     result.map { |it| [it.publication_month] }.uniq
   end
 
-  # Finds one article which was posted on a certain date and matches the supplied dashed-title
-  # params is a Hash
+  # Finds one article which was posted on a certain date and matches the
+  # supplied dashed-title params is a Hash
   def self.requested_article(params)
     date_range = PublifyTime.delta(params[:year], params[:month], params[:day])
 
@@ -159,6 +168,7 @@ class Article < Content
     req_params[:published_at] = date_range if date_range
 
     return if req_params.empty? # no search if no params send
+
     article = published.find_by(req_params)
     return article if article
 
@@ -226,7 +236,7 @@ class Article < Content
     if extended.blank?
       body
     else
-      body + "\n<!--more-->\n" + extended
+      "#{body}\n<!--more-->\n#{extended}"
     end
   end
 
@@ -235,7 +245,7 @@ class Article < Content
   def body_and_extended=(value)
     parts = value.split(/\n?<!--more-->\n?/, 2)
     self.body = parts[0]
-    self.extended = parts[1] || ''
+    self.extended = parts[1] || ""
   end
 
   def password_protected?
@@ -252,11 +262,13 @@ class Article < Content
 
   def allow_comments?
     return allow_comments unless allow_comments.nil?
+
     blog.default_allow_comments
   end
 
   def allow_pings?
     return allow_pings unless allow_pings.nil?
+
     blog.default_allow_pings
   end
 
@@ -276,11 +288,11 @@ class Article < Content
 
   def permalink_url_options
     format_url = blog.permalink_format.dup
-    format_url.gsub!('%year%', published_at.year.to_s)
-    format_url.gsub!('%month%', sprintf('%.2d', published_at.month))
-    format_url.gsub!('%day%', sprintf('%.2d', published_at.day))
-    format_url.gsub!('%title%', URI.encode(permalink.to_s))
-    if format_url[0, 1] == '/'
+    format_url.gsub!("%year%", published_at.year.to_s)
+    format_url.gsub!("%month%", sprintf("%<month>.2d", month: published_at.month))
+    format_url.gsub!("%day%", sprintf("%<day>.2d", day: published_at.day))
+    format_url.gsub!("%title%", URI::DEFAULT_PARSER.escape(permalink.to_s))
+    if format_url[0, 1] == "/"
       format_url[1..-1]
     else
       format_url
@@ -289,6 +301,6 @@ class Article < Content
 
   def trigger_publication
     # TODO: Skip if already published, update when published_at changes
-    Trigger.post_action(published_at, self, 'publish!')
+    Trigger.post_action(published_at, self, "publish!")
   end
 end

data/app/models/article/factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Article::Factory
   attr_reader :blog, :user
 
@@ -10,13 +12,14 @@ class Article::Factory
     blog.articles.build.tap do |art|
       art.allow_comments = blog.default_allow_comments
       art.allow_pings = blog.default_allow_pings
-      art.text_filter = user.default_text_filter
-      art.state = 'draft'
+      art.text_filter_name = default_text_filter
+      art.state = "draft"
     end
   end
 
   def get_or_build_from(id)
     return blog.articles.find(id) if id.present?
+
     default
   end
 
@@ -31,10 +34,10 @@ class Article::Factory
   end
 
   def extract_params(path, format)
-    specs = format.split('/')
-    specs.delete('')
-    parts = path.split('/')
-    parts.delete('')
+    specs = format.split("/")
+    specs.delete("")
+    parts = path.split("/")
+    parts.delete("")
 
     return if parts.length != specs.length
 
@@ -45,6 +48,7 @@ class Article::Factory
         after_format = Regexp.last_match[3]
         item =~ /^#{before_format}(.*)#{after_format}$/
         break unless Regexp.last_match
+
         value = Regexp.last_match[1]
         result[format_string.to_sym] = value
       elsif spec != item
@@ -53,4 +57,8 @@ class Article::Factory
       result
     end
   end
+
+  def default_text_filter
+    user.text_filter_name || blog.text_filter
+  end
 end

data/app/models/blog.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The Blog class represents the one and only blog.  It stores most
 # configuration settings and is linked to most of the assorted content
 # classes via has_many.
@@ -13,65 +15,65 @@ class Blog < ApplicationRecord
   has_many :articles
   has_many :feedback, through: :articles
 
-  has_many :published_articles, ->() { published }, class_name: 'Article'
+  has_many :published_articles, ->() { published }, class_name: "Article"
 
   has_many :pages
   has_many :tags
   has_many :notes
 
   has_many :redirects
-  has_many :sidebars, ->() { order('active_position ASC') }
+  has_many :sidebars, ->() { order("active_position ASC") }
 
   attr_accessor :custom_permalink
 
-  default_scope -> { order('id') }
+  default_scope -> { order("id") }
 
   validates :blog_name, presence: true
 
   serialize :settings, Hash
 
   # Description
-  setting :blog_name, :string, 'My Shiny Weblog!'
-  setting :blog_subtitle, :string, ''
-  setting :geourl_location, :string, ''
-  setting :canonical_server_url, :string, '' # Deprecated
-  setting :lang, :string, 'en_US'
-  setting :title_prefix, :integer, 0 # Deprecated but needed for a migration
+  setting :blog_name, :string, "My Shiny Weblog!"
+  setting :blog_subtitle, :string, ""
+  setting :geourl_location, :string, ""
+  setting :canonical_server_url, :string, "" # Deprecated
+  setting :lang, :string, "en_US"
 
   # Spam
   setting :sp_global, :boolean, false
   setting :sp_article_auto_close, :integer, 0
   setting :sp_url_limit, :integer, 0
-  setting :sp_akismet_key, :string, ''
+  setting :sp_akismet_key, :string, ""
   setting :use_recaptcha, :boolean, false
 
   # Mostly Behaviour
-  setting :text_filter, :string, 'markdown smartypants'
-  setting :comment_text_filter, :string, 'markdown smartypants'
+  setting :text_filter, :string, "markdown smartypants"
+  setting :comment_text_filter, :string, "markdown smartypants"
   setting :limit_article_display, :integer, 10
   setting :limit_archives_display, :integer, 20
   setting :limit_rss_display, :integer, 10
   setting :default_allow_pings, :boolean, false
   setting :default_allow_comments, :boolean, true
   setting :default_moderate_comments, :boolean, false
-  setting :show_extended_on_rss, :boolean, true # deprecated but still needed for backward compatibility
+  # deprecated but still needed for backward compatibility
+  setting :show_extended_on_rss, :boolean, true
   setting :hide_extended_on_rss, :boolean, false
-  setting :theme, :string, 'plain'
-  setting :plugin_avatar, :string, ''
+  setting :theme, :string, "plain"
+  setting :plugin_avatar, :string, ""
   setting :global_pings_disable, :boolean, false
   setting :send_outbound_pings, :boolean, true
-  setting :email_from, :string, 'publify@example.com'
+  setting :email_from, :string, "publify@example.com"
   setting :allow_signup, :integer, 0
-  setting :date_format, :string, '%d/%m/%Y'
-  setting :time_format, :string, '%Hh%M'
+  setting :date_format, :string, "%d/%m/%Y"
+  setting :time_format, :string, "%Hh%M"
   setting :image_avatar_size, :integer, 48
   setting :image_thumb_size, :integer, 125
   setting :image_medium_size, :integer, 600
 
   # SEO
-  setting :meta_description, :string, ''
-  setting :meta_keywords, :string, ''
-  setting :google_analytics, :string, ''
+  setting :meta_description, :string, ""
+  setting :meta_keywords, :string, ""
+  setting :google_analytics, :string, ""
   setting :rss_description, :boolean, false
   setting :rss_description_text, :string, <<-HTML.strip_heredoc
     <hr />
@@ -80,7 +82,7 @@ class Blog < ApplicationRecord
     | If you are reading this article anywhere other than on <a href='%blog_url%'>%blog_name%</a>,
       it has been illegally reproduced and without proper authorization.</small></p>
   HTML
-  setting :permalink_format, :string, '/%year%/%month%/%day%/%title%'
+  setting :permalink_format, :string, "/%year%/%month%/%day%/%title%"
   setting :robots, :string, 'User-agent: *\nAllow: /\nDisallow: /admin\n'
   setting :humans, :string, <<-TEXT.strip_heredoc
     /* TEAM */
@@ -89,45 +91,50 @@ class Blog < ApplicationRecord
     Twitter: your Twitter username.
 
     /* SITE */
-    Software: Publify [http://publify.co] #{PublifyCore::VERSION}
+    Software: Publify [https://publify.github.io/] #{PublifyCore::VERSION}
   TEXT
-  setting :index_categories, :boolean, true # deprecated but still needed for backward compatibility
+  # deprecated but still needed for backward compatibility
+  setting :index_categories, :boolean, true
   setting :unindex_categories, :boolean, false
-  setting :index_tags, :boolean, true # deprecated but still needed for backward compatibility
+  # deprecated but still needed for backward compatibility
+  setting :index_tags, :boolean, true
   setting :unindex_tags, :boolean, false
   setting :admin_display_elements, :integer, 10
-  setting :google_verification, :string, ''
-  setting :nofollowify, :boolean, true # deprecated but still needed for backward compatibility
+  setting :google_verification, :string, ""
+  # deprecated but still needed for backward compatibility
+  setting :nofollowify, :boolean, true
   setting :dofollowify, :boolean, false
-  setting :use_canonical_url, :boolean, false
   setting :use_meta_keyword, :boolean, true
-  setting :home_title_template, :string, '%blog_name% | %blog_subtitle%' # spec OK
-  setting :home_desc_template, :string, '%blog_name% | %blog_subtitle% | %meta_keywords%' # OK
-  setting :article_title_template, :string, '%title% | %blog_name%'
-  setting :article_desc_template, :string, '%excerpt%'
-  setting :page_title_template, :string, '%title% | %blog_name%'
-  setting :page_desc_template, :string, '%excerpt%'
-  setting :paginated_title_template, :string, '%blog_name% | %blog_subtitle% %page%'
-  setting :paginated_desc_template, :string, '%blog_name% | %blog_subtitle% | %meta_keywords% %page%'
-  setting :tag_title_template, :string, 'Tag: %name% | %blog_name% %page%'
-  setting :tag_desc_template, :string, '%name% | %blog_name% | %blog_subtitle% %page%'
-  setting :author_title_template, :string, '%author% | %blog_name%'
-  setting :author_desc_template, :string, '%author% | %blog_name% | %blog_subtitle%'
-  setting :archives_title_template, :string, 'Archives for %blog_name% %date% %page%'
-  setting :archives_desc_template, :string, 'Archives for %blog_name% %date% %page% %blog_subtitle%'
-  setting :search_title_template, :string, 'Results for %search% | %blog_name% %page%'
-  setting :search_desc_template, :string, 'Results for %search% | %blog_name% | %blog_subtitle% %page%'
-  setting :statuses_title_template, :string, 'Notes | %blog_name% %page%'
-  setting :statuses_desc_template, :string, 'Notes | %blog_name% | %blog_subtitle% %page%'
-  setting :status_title_template, :string, '%body% | %blog_name%'
-  setting :status_desc_template, :string, '%excerpt%'
-
-  setting :custom_tracking_field, :string, ''
+  setting :home_title_template, :string, "%blog_name% | %blog_subtitle%"
+  setting :home_desc_template, :string, "%blog_name% | %blog_subtitle% | %meta_keywords%"
+  setting :article_title_template, :string, "%title% | %blog_name%"
+  setting :article_desc_template, :string, "%excerpt%"
+  setting :page_title_template, :string, "%title% | %blog_name%"
+  setting :page_desc_template, :string, "%excerpt%"
+  setting :paginated_title_template, :string, "%blog_name% | %blog_subtitle% %page%"
+  setting :paginated_desc_template, :string,
+          "%blog_name% | %blog_subtitle% | %meta_keywords% %page%"
+  setting :tag_title_template, :string, "Tag: %name% | %blog_name% %page%"
+  setting :tag_desc_template, :string, "%name% | %blog_name% | %blog_subtitle% %page%"
+  setting :author_title_template, :string, "%author% | %blog_name%"
+  setting :author_desc_template, :string, "%author% | %blog_name% | %blog_subtitle%"
+  setting :archives_title_template, :string, "Archives for %blog_name% %date% %page%"
+  setting :archives_desc_template, :string,
+          "Archives for %blog_name% %date% %page% %blog_subtitle%"
+  setting :search_title_template, :string, "Results for %search% | %blog_name% %page%"
+  setting :search_desc_template, :string,
+          "Results for %search% | %blog_name% | %blog_subtitle% %page%"
+  setting :statuses_title_template, :string, "Notes | %blog_name% %page%"
+  setting :statuses_desc_template, :string, "Notes | %blog_name% | %blog_subtitle% %page%"
+  setting :status_title_template, :string, "%body% | %blog_name%"
+  setting :status_desc_template, :string, "%excerpt%"
+
+  setting :custom_tracking_field, :string, ""
   # setting :meta_author_template,       :string, "%blog_name% | %nickname%"
 
-  setting :twitter_consumer_key, :string, ''
-  setting :twitter_consumer_secret, :string, ''
-  setting :custom_url_shortener, :string, ''
+  setting :twitter_consumer_key, :string, ""
+  setting :twitter_consumer_secret, :string, ""
+  setting :custom_url_shortener, :string, ""
   setting :statuses_in_timeline, :boolean, true
 
   validate :permalink_has_identifier
@@ -146,13 +153,13 @@ class Blog < ApplicationRecord
 
   # Check that all required blog settings have a value.
   def configured?
-    settings.key?('blog_name')
+    settings.key?("blog_name")
   end
 
   # The +Theme+ object for the current theme.
   def current_theme(reload = nil)
     @current_theme = nil if reload
-    @current_theme ||= Theme.find(theme) || Theme.new('', '')
+    @current_theme ||= Theme.find(theme) || Theme.new("", "")
   end
 
   module BasedUrlFor
@@ -165,21 +172,25 @@ class Blog < ApplicationRecord
     def url_for(options = {}, extra_params = {})
       case options
       when String
+        options = options.sub(%r{^/}, "")
         url_generated = if extra_params[:only_path]
                           root_path
                         else
                           base_url
                         end
-        url_generated += "/#{options}" # They asked for 'url_for "/some/path"', so return it unedited.
+        # They asked for 'url_for "/some/path"', so return it unedited.
+        url_generated += "/#{options}"
         url_generated += "##{extra_params[:anchor]}" if extra_params[:anchor]
         url_generated
       when Hash
-        merged_opts = options.reverse_merge!(only_path: false, controller: '',
-                                             action: 'permalink',
+        merged_opts = options.reverse_merge!(only_path: false, controller: "",
+                                             action: "permalink",
                                              host: host_with_port,
                                              script_name: root_path)
-        cache_key = merged_opts.values.prepend('blog-urlfor-withbaseurl').join('-')
-        Rails.cache.write(cache_key, super(merged_opts)) unless Rails.cache.exist?(cache_key)
+        cache_key = merged_opts.values.prepend("blog-urlfor-withbaseurl").join("-")
+        unless Rails.cache.exist?(cache_key)
+          Rails.cache.write(cache_key, super(merged_opts))
+        end
         Rails.cache.read(cache_key)
       else
         raise "Invalid URL in url_for: #{options.inspect}"
@@ -191,7 +202,7 @@ class Blog < ApplicationRecord
 
   # The URL for a static file.
   def file_url(filename)
-    if CarrierWave.configure { |config| config.storage.name == 'CarrierWave::Storage::Fog' }
+    if CarrierWave.configure { |config| config.storage.name == "CarrierWave::Storage::Fog" }
       filename
     else
       url_for filename, only_path: false
@@ -203,7 +214,8 @@ class Blog < ApplicationRecord
   end
 
   def per_page(format)
-    return limit_article_display if format.nil? || format == 'html'
+    return limit_article_display if format.nil? || format == "html"
+
     limit_rss_display
   end
 
@@ -217,9 +229,13 @@ class Blog < ApplicationRecord
   end
 
   def permalink_has_identifier
-    errors.add(:base, I18n.t('errors.permalink_need_a_title')) unless permalink_format =~ /(%title%)/
+    unless /(%title%)/.match?(permalink_format)
+      errors.add(:base, I18n.t("errors.permalink_need_a_title"))
+    end
 
-    errors.add(:permalink_format, I18n.t('errors.cant_end_with_rss_or_atom')) if permalink_format =~ /\.(atom|rss)$/
+    if /\.(atom|rss)$/.match?(permalink_format)
+      errors.add(:permalink_format, I18n.t("errors.cant_end_with_rss_or_atom"))
+    end
   end
 
   def root_path
@@ -233,6 +249,7 @@ class Blog < ApplicationRecord
   def has_twitter_configured?
     return false if twitter_consumer_key.nil? || twitter_consumer_secret.nil?
     return false if twitter_consumer_key.empty? || twitter_consumer_secret.empty?
+
     true
   end
 
@@ -253,7 +270,10 @@ class Blog < ApplicationRecord
   def split_base_url
     unless @split_base_url
       raise "Invalid base_url: #{base_url}" unless base_url =~ %r{(https?)://([^/]*)(.*)}
-      @split_base_url = { protocol: Regexp.last_match[1], host_with_port: Regexp.last_match[2], root_path: Regexp.last_match[3].gsub(%r{/$}, '') }
+
+      @split_base_url = { protocol: Regexp.last_match[1],
+                          host_with_port: Regexp.last_match[2],
+                          root_path: Regexp.last_match[3].gsub(%r{/$}, "") }
     end
     @split_base_url
   end