proxy_pac_rb 0.3.4 → 0.3.6

data/lib/proxy_pac_rb/exceptions.rb

@@ -1,16 +1,16 @@
 # encoding: utf-8
 module ProxyPacRb
   module Exceptions
-    #raise on error
+    # raise on error
     class ProgramError < StandardError; end
 
-    #raise on java script runtime error
+    # raise on java script runtime error
     class RuntimeUnavailable < StandardError; end
 
-    #raise on invalid argument
+    # raise on invalid argument
     class InvalidArgument < StandardError; end
 
-    #raise on invalid argument
+    # raise on invalid argument
     class UrlInvalid < StandardError; end
   end
 end

data/lib/proxy_pac_rb/file.rb

@@ -1,6 +1,6 @@
 module ProxyPacRb
+  # Proxy pac file
   class File
-
     private
 
     attr_reader :javascript
@@ -13,9 +13,9 @@ module ProxyPacRb
 
     def find(url)
       uri = Addressable::URI.heuristic_parse(url)
-      fail Exceptions::UrlInvalid, "url is missing host" unless uri.host
+      fail Exceptions::UrlInvalid, 'url is missing host' unless uri.host
 
-      javascript.call("FindProxyForURL", url, uri.host)
+      javascript.call('FindProxyForURL', url, uri.host)
     end
   end
 end

data/lib/proxy_pac_rb/parser.rb

@@ -1,7 +1,16 @@
 # encoding: utf-8
 module ProxyPacRb
+  # Proxy Pac parser
+  #
+  # @example Usage
+  #
+  # parser = Parser.new
+  # parser.load('http://example.com/proxy.pac')
+  # parser.read('file.pac')
+  #
+  # string = ''
+  # parser.source(string)
   class Parser
-
     private
 
     attr_reader :runtime, :environment
@@ -16,7 +25,7 @@ module ProxyPacRb
     end
 
     def load(url, options = {})
-      create_file(open(url, { :proxy => false }.merge(options)).read)
+      create_file(open(url, { proxy: false }.merge(options)).read)
     end
 
     def read(file)

data/lib/proxy_pac_rb/proxy_pac_js.rb

@@ -1,5 +1,6 @@
 # encoding: utf-8
 module ProxyPacRb
+  # Javascript-Methods for evaluation of proxy.pac
   class ProxyPacJs
     class << self
       def my_ip_address_template(value)
@@ -10,7 +11,6 @@ module ProxyPacRb
         EOS
       end
 
-
       # taken from  releases-mozilla-release / netwerk / base / src / ProxyAutoConfig.cpp @ bitbucket.org
       # https://bitbucket.org/mozilla/releases-mozilla-release/raw/dece38633cf1adcab2071d69fea264580d24cc9e/netwerk/base/src/ProxyAutoConfig.cpp
       def time_variables
@@ -21,7 +21,7 @@ module ProxyPacRb
       end
 
       def week_day_range_template(value = nil)
-        value = %Q{"#{value}"} if value
+        value = %("#{value}") if value
 
         <<-EOS.strip_heredoc
         function weekdayRange() {
@@ -51,7 +51,7 @@ module ProxyPacRb
       end
 
       def date_range_template(value = nil)
-        value = %Q{"#{value}"} if value
+        value = %("#{value}") if value
 
         <<-EOS.strip_heredoc
         function dateRange() {
@@ -79,7 +79,7 @@ module ProxyPacRb
                              getMonth(arguments[0]));
                 } else if (tmp < 32) {
                     return ((isGMT ? date.getUTCDate() : date.getDate()) == tmp);
-                } else { 
+                } else {
                     return ((isGMT ? date.getUTCFullYear() : date.getFullYear()) ==
                              tmp);
                 }
@@ -132,7 +132,7 @@ module ProxyPacRb
       end
 
       def time_range_template(value = nil)
-        value = %Q{"#{value}"} if value
+        value = %("#{value}") if value
 
         <<-EOS.strip_heredoc
         function timeRange() {

data/lib/proxy_pac_rb/runtime.rb

@@ -1,29 +1,30 @@
 module ProxyPacRb
   # Abstract base class for runtimes
   class Runtime
+    # Context
     class Context
       include Encoding
 
       attr_accessor :context
 
       def include(environment)
-        environment.available_methods.each do |name| 
+        environment.available_methods.each do |name|
           context[name] = environment.method(name)
         end
       end
 
-      def initialize(runtime, source = "")
+      def initialize(_runtime, _source = '')
       end
 
-      def exec(source, options = {})
+      def exec(_source, _options = {})
         fail NotImplementedError
       end
 
-      def eval(source, options = {})
+      def eval(_source, _options = {})
         fail NotImplementedError
       end
 
-      def call(properties, *args)
+      def call(_properties, *_args)
         fail NotImplementedError
       end
     end

data/lib/proxy_pac_rb/runtimes/rubyracer.rb

@@ -1,7 +1,9 @@
 module ProxyPacRb
+  # Ruby Racer Runtime
   class RubyRacerRuntime < Runtime
+    # Context
     class Context < Runtime::Context
-      def initialize(runtime, source = "", environment = nil)
+      def initialize(_runtime, source = '', _environment = nil)
         source = encode(source)
 
         lock do
@@ -13,24 +15,24 @@ module ProxyPacRb
       def exec(source, options = {})
         source = encode(source)
 
-        if /\S/ =~ source
-          eval "(function(){#{source}})()", options
-        end
+        # rubocop:disable Lint/Eval
+        eval "(function(){#{source}})()", options if /\S/ =~ source
+        # rubocop:enable Lint/Eval
       end
 
-      def eval(source, options = {})
+      def eval(source, _options = {})
         source = encode(source)
 
-        if /\S/ =~ source
-          lock do
-            begin
-              unbox context.eval("(#{source})")
-            rescue ::V8::JSError => e
-              if e.value["name"] == "SyntaxError"
-                fail RuntimeError, e.value.to_s
-              else
-                raise Exceptions::ProgramError, e.value.to_s
-              end
+        return nil unless /\S/ =~ source
+
+        lock do
+          begin
+            unbox context.eval("(#{source})")
+          rescue ::V8::JSError => e
+            if e.value['name'] == 'SyntaxError'
+              raise e.value.to_s
+            else
+              raise Exceptions::ProgramError, e.value.to_s
             end
           end
         end
@@ -41,8 +43,8 @@ module ProxyPacRb
           begin
             unbox context.eval(properties).call(*args)
           rescue ::V8::JSError => e
-            if e.value["name"] == "SyntaxError"
-              raise RuntimeError, e.value.to_s
+            if e.value['name'] == 'SyntaxError'
+              raise e.value.to_s
             else
               raise Exceptions::ProgramError, e.value.to_s
             end
@@ -57,44 +59,49 @@ module ProxyPacRb
         when ::V8::Array
           value.map { |v| unbox(v) }
         when ::V8::Object
-          value.inject({}) do |vs, (k, v)|
+          # rubocop:disable Style/EachWithObject
+          value.reduce({}) do |vs, (k, v)|
             vs[k] = unbox(v) unless v.is_a?(::V8::Function)
             vs
           end
+          # rubocop:enable Style/EachWithObject
         when String
-          value.respond_to?(:force_encoding) ?
-            value.force_encoding('UTF-8') :
+          if value.respond_to?(:force_encoding)
+            value.force_encoding('UTF-8')
+          else
             value
+          end
         else
           value
         end
       end
 
       private
-        def lock
-          result, exception = nil, nil
-          V8::C::Locker() do
-            begin
-              result = yield
-            rescue Exception => e
-              exception = e
-            end
-          end
 
-          if exception
-            raise exception
-          else
-            result
+      def lock
+        result, exception = nil, nil
+        V8::C::Locker() do
+          begin
+            result = yield
+          rescue => e
+            exception = e
           end
         end
+
+        if exception
+          fail exception
+        else
+          result
+        end
+      end
     end
 
     def name
-      "therubyracer (V8)"
+      'therubyracer (V8)'
     end
 
     def available?
-      require "v8"
+      require 'v8'
       true
     rescue LoadError
       false

data/lib/proxy_pac_rb/runtimes/rubyrhino.rb

@@ -1,7 +1,9 @@
 module ProxyPacRb
+  # Ruby Rhine Runtime
   class RubyRhinoRuntime < Runtime
+    # Context
     class Context < Runtime::Context
-      def initialize(runtime, source = "")
+      def initialize(_runtime, source = '')
         source = encode(source)
 
         self.context = ::Rhino::Context.new
@@ -12,20 +14,20 @@ module ProxyPacRb
       def exec(source, options = {})
         source = encode(source)
 
-        if /\S/ =~ source
-          eval "(function(){#{source}})()", options
-        end
+        return nil unless /\S/ =~ source
+
+        # rubocop:disable Lint/Eval
+        eval "(function(){#{source}})()", options
+        # rubocop:enable Lint/Eval
       end
 
-      def eval(source, options = {})
+      def eval(source, _options = {})
         source = encode(source)
 
-        if /\S/ =~ source
-          unbox context.eval("(#{source})")
-        end
+        unbox context.eval("(#{source})") if /\S/ =~ source
       rescue ::Rhino::JSError => e
         if e.message =~ /^syntax error/
-          raise RuntimeError, e.message
+          raise e.message
         else
           raise Exceptions::ProgramError, e.message
         end
@@ -34,19 +36,20 @@ module ProxyPacRb
       def call(properties, *args)
         unbox context.eval(properties).call(*args)
       rescue ::Rhino::JSError => e
-        if e.message == "syntax error"
-          raise RuntimeError, e.message
+        if e.message == 'syntax error'
+          raise e.message
         else
           raise Exceptions::ProgramError, e.message
         end
       end
 
       def unbox(value)
-        case value = ::Rhino::to_ruby(value)
+        case value = ::Rhino.to_ruby(value)
         when Java::OrgMozillaJavascript::NativeFunction
           nil
         when Java::OrgMozillaJavascript::NativeObject
-          value.inject({}) do |vs, (k, v)|
+          # rubocop:disable Style/EachWithObject
+          value.reduce({}) do |vs, (k, v)|
             case v
             when Java::OrgMozillaJavascript::NativeFunction, ::Rhino::JS::Function
               nil
@@ -55,6 +58,7 @@ module ProxyPacRb
             end
             vs
           end
+          # rubocop:enable Style/EachWithObject
         when Array
           value.map { |v| unbox(v) }
         else
@@ -63,22 +67,23 @@ module ProxyPacRb
       end
 
       private
-        # Disables bytecode compiling which limits you to 64K scripts
-        def fix_memory_limit!(cxt)
-          if cxt.respond_to?(:optimization_level=)
-            cxt.optimization_level = -1
-          else
-            cxt.instance_eval { @native.setOptimizationLevel(-1) }
-          end
+
+      # Disables bytecode compiling which limits you to 64K scripts
+      def fix_memory_limit!(cxt)
+        if cxt.respond_to?(:optimization_level=)
+          cxt.optimization_level = -1
+        else
+          cxt.instance_eval { @native.setOptimizationLevel(-1) }
         end
+      end
     end
 
     def name
-      "therubyrhino (Rhino)"
+      'therubyrhino (Rhino)'
     end
 
     def available?
-      require "rhino"
+      require 'rhino'
       true
     rescue LoadError
       false

data/lib/proxy_pac_rb/runtimes.rb

@@ -1,4 +1,5 @@
 module ProxyPacRb
+  # JavaScript Runtimes
   module Runtimes
     RubyRacer = RubyRacerRuntime.new
     RubyRhino = RubyRhinoRuntime.new
@@ -6,8 +7,8 @@ module ProxyPacRb
     class << self
       def autodetect
         from_environment || best_available ||
-          fail(Exceptions::RuntimeUnavailable, "Could not find a JavaScript runtime. " +
-                "See https://github.com/sstephenson/execjs for a list of available runtimes.")
+          fail(Exceptions::RuntimeUnavailable, 'Could not find a JavaScript runtime. ' \
+                'See https://github.com/sstephenson/execjs for a list of available runtimes.')
       end
 
       def best_available
@@ -15,27 +16,24 @@ module ProxyPacRb
       end
 
       def from_environment
-        if name = ENV["JS_RUNTIME"]
-          if runtime = const_get(name)
-            if runtime.available?
-              runtime if runtime.available?
-            else
-              fail Exceptions::RuntimeUnavailable, "#{runtime.name} runtime is not available on this system"
-            end
-          elsif !name.empty?
-            fail Exceptions::RuntimeUnavailable, "#{name} runtime is not defined"
-          end
-        end
+        return nil unless ENV['JS_RUNTIME']
+
+        runtime = const_get(ENV['JS_RUNTIME'])
+
+        fail Exceptions::RuntimeUnavailable, "#{ENV['JS_RUNTIME']} runtime is not defined" unless runtime
+        fail Exceptions::RuntimeUnavailable, "#{runtime.name} runtime is not available on this system" unless runtime.available?
+
+        runtime
       end
 
       def names
-        @names ||= constants.inject({}) { |h, name| h.merge(const_get(name) => name) }.values
+        @names ||= constants.reduce({}) { |a, e| a.merge(const_get(e) => e) }.values
       end
 
       def runtimes
         @runtimes ||= [
           RubyRacer,
-          RubyRhino,
+          RubyRhino
         ]
       end
     end

data/lib/proxy_pac_rb/version.rb

@@ -1,4 +1,5 @@
-#main ProxyPacRb
+# encoding: utf-8
+# ProxyPacRb
 module ProxyPacRb
-  VERSION = '0.3.4'
+  VERSION = '0.3.6'
 end