proxy_pac_rb 0.3.4 → 0.3.6

data/bin/pprb

@@ -1,124 +1,9 @@
 #!/usr/bin/env ruby
 # encoding: utf-8
-
 $LOAD_PATH << File.expand_path('../../lib', __FILE__)
 
 require 'proxy_pac_rb'
-require 'ostruct'
-require 'ipaddr'
-require 'optparse'
-require 'addressable/uri'
-require 'open-uri'
-
-module ProxyPacRb
-  class Cli
-
-    class Validator
-      private
-
-      attr_reader :options
-
-      public
-
-      def initialize(options)
-        @options = options
-      end
-
-      def validate
-        exit_with_message 'You need to provide at least one url. Multiple urls need to be separated by a space.' if empty_url? 
-        exit_with_message 'You need to provide a proxy pac file.' if empty_pac_file? 
-      end
-
-      private
-
-      def empty_url?
-        options.urls.empty?
-      end
-
-      def empty_pac_file?
-        options.proxy_pac_file.nil?
-      end
-
-      def exit_with_message(msg)
-        $stderr.puts msg
-        exit 1
-      end
-      
-    end
-
-    attr_accessor :options
-
-    def self.start(argv = $*)
-      cli = new
-      cli.parse(argv)
-
-      Validator.new(cli.options).validate
-
-      environment = ProxyPacRb::Environment.new(client_ip: cli.options.client_ip, time: cli.options.time)
-      file = ProxyPacRb::Parser.new(environment).source(cli.options.proxy_pac_file)
-
-      $stderr.printf("%30s: %-s\n", 'url', 'result')
-      cli.options.urls.each do |u| 
-        begin
-          $stderr.printf("%30s: %-s\n", u, file.find(u))
-        rescue Exceptions::UrlInvalid
-          $stderr.puts "You provide an invalid url \"#{u}\". Please use a correct one."
-        end
-      end
-    end
-
-    def initialize
-      @options = OpenStruct.new
-
-      @options.client_ip = IPAddr.new('127.0.0.1')
-      @options.time      = Time.now
-    end
-
-    def parse(argv)
-      parser = OptionParser.new do |opts|
-        opts.banner = "Usage: parsepac [options] url1 [url2..urln]"
-
-        opts.on('-c', '--client-ip IP', 'Client ip address') do |i|
-          options.client_ip = IPAddr.new(i)
-        end
-
-        opts.on('-t', '--time YYYY-MM-DD HH:MM:SS', 'Time to use during lookup url') do |t|
-          options.time = Time.parse(t)
-        end
-
-        opts.on('-p', '--proxy-pac FILE|URL', 'Proxy.pac-file') do |f|
-          uri = Addressable::URI.parse(f)
-
-          if uri.host.nil?
-            uri.path = ::File.expand_path(uri.path)
-          end
-
-          ENV.delete 'HTTP_PROXY'
-          ENV.delete 'HTTPS_PROXY'
-          ENV.delete 'http_proxy'
-          ENV.delete 'https_proxy'
-
-          options.proxy_pac_file = open(uri, { proxy: false }).read
-        end
-
-        opts.on_tail("-h", "--help", "Show this message") do
-          $stderr.puts opts
-          exit
-        end
-
-        opts.on_tail("--version", "Show version") do
-          $stderr.puts ProxyPacRb::VERSION
-          exit
-        end
-      end
-
-      $stderr.puts parser.help if argv.empty?
-
-      parser.parse!(argv)
-      options.urls = argv
-    end
-  end
-end
 
 ProxyPacRb::Cli.start
+
 exit 0

data/config/license_finder.yml

@@ -0,0 +1,12 @@
+---
+whitelist:
+#- MIT
+#- Apache 2.0
+ignore_groups:
+#- test
+#- development
+ignore_dependencies:
+#- bundler
+dependencies_file_dir: './doc/dependencies'
+project_name: # project name
+gradle_command: # only meaningful if used with a Java/gradle project. Defaults to "gradle".

data/config/rubocop/exclude.yml

@@ -0,0 +1,8 @@
+AllCops:
+  Exclude:
+    - 'tmp/**/*'
+
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MethodName:
+  Exclude:
+    - lib/proxy_pac_rb/environment.rb

data/config/rubocop/include.yml

@@ -0,0 +1,27 @@
+# Configuration parameters: AllowURI.
+Metrics/LineLength:
+  Max: 225
+
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 6
+
+Metrics/BlockNesting:
+  Max: 4
+
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 174
+
+Metrics/CyclomaticComplexity:
+  Max: 7
+
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 76
+
+Metrics/PerceivedComplexity:
+  Max: 8
+
+Style/RegexpLiteral:
+  MaxSlashes: 0

data/cucumber.yml

@@ -0,0 +1,2 @@
+default: --tags @wip:3 --tags ~@broken --tags ~@broken-external
+all: --tags ~@wip --tags ~@broken --tags ~@broken-external

data/features/resolve_proxy.feature

@@ -136,3 +136,20 @@ Feature: Resolve proxy
     """
     DIRECT
     """
+
+  Scenario: dnsResolve + isInNet
+    Given a file named "proxy.pac" with:
+    """
+    function FindProxyForURL(url, host) {
+      hostip = dnsResolve(host);
+      if (isInNet(hostip, "127.0.0.1", "255.255.255.255") ||
+          isInNet(hostip, "127.0.0.1", "255.255.255.255") ||
+          isInNet(hostip, "127.0.0.1", "255.255.255.255") ||
+          isInNet(hostip, "127.0.0.1", "255.255.255.255")) return 'proxy.example.com';
+    }
+    """
+    When I successfully run `pprb -p proxy.pac http://localhost`
+    Then the output should contain:
+    """
+    proxy.example.com
+    """

data/features/support/aruba.rb

@@ -0,0 +1,13 @@
+# encoding: utf-8
+require 'aruba/cucumber'
+
+module FeatureHelper
+  # Helpers for aruba
+  module Aruba
+    def dirs
+      @dirs ||= %w(tmp cucumber)
+    end
+  end
+end
+
+World(FeatureHelper::Aruba)

data/features/support/env.rb

@@ -1,3 +1,12 @@
 # encoding: utf-8
-
 require 'aruba/cucumber'
+
+require 'simplecov'
+SimpleCov.command_name 'cucumber'
+SimpleCov.start
+
+# Pull in all of the gems including those in the `test` group
+require 'bundler'
+Bundler.require :default, :test, :development
+
+ENV['TEST'] = 'true'

data/features/support/fixtures.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+module FeatureHelper
+  # Helper for fixtures
+  module Fixtures
+    def fixtures_manager
+      @fixtures_manager ||= FeduxOrgStdlib::FixturesManagement::FixturesManager.new
+
+      @fixtures_manager.load_fixtures(File.expand_path('../../../fixtures', __FILE__))
+
+      @fixtures_manager
+    end
+  end
+end
+
+World(FeatureHelper::Fixtures)

data/features/support/reporting.rb

@@ -0,0 +1,2 @@
+# encoding: utf-8
+require 'active_support/core_ext/kernel/reporting'

data/lib/proxy_pac_rb/cli.rb

@@ -0,0 +1,75 @@
+# encoding: utf-8
+module ProxyPacRb
+  # Command line interface
+  class Cli
+    attr_accessor :options
+
+    def self.start(argv = ARGV)
+      cli = new
+      cli.parse(argv)
+
+      CliValidator.new(cli.options).validate
+
+      environment = ProxyPacRb::Environment.new(client_ip: cli.options.client_ip, time: cli.options.time)
+      file = ProxyPacRb::Parser.new(environment).source(cli.options.proxy_pac_file)
+
+      $stderr.printf("%30s: %-s\n", 'url', 'result')
+      cli.options.urls.each do |u|
+        begin
+          $stderr.printf("%30s: %-s\n", u, file.find(u))
+        rescue Exceptions::UrlInvalid
+          $stderr.puts "You provide an invalid url \"#{u}\". Please use a correct one."
+        end
+      end
+    end
+
+    def initialize
+      @options = OpenStruct.new
+
+      @options.client_ip = IPAddr.new('127.0.0.1')
+      @options.time      = Time.now
+    end
+
+    def parse(argv)
+      parser = OptionParser.new do |opts|
+        opts.banner = 'Usage: pprb [options] url1 [url2..urln]'
+
+        opts.on('-c', '--client-ip IP', 'Client ip address') do |i|
+          options.client_ip = IPAddr.new(i)
+        end
+
+        opts.on('-t', '--time YYYY-MM-DD HH:MM:SS', 'Time to use during lookup url') do |t|
+          options.time = Time.parse(t)
+        end
+
+        opts.on('-p', '--proxy-pac FILE|URL', 'Proxy.pac-file') do |f|
+          uri = Addressable::URI.parse(f)
+
+          uri.path = ::File.expand_path(uri.path) if uri.host.nil?
+
+          ENV.delete 'HTTP_PROXY'
+          ENV.delete 'HTTPS_PROXY'
+          ENV.delete 'http_proxy'
+          ENV.delete 'https_proxy'
+
+          options.proxy_pac_file = open(uri, proxy: false).read
+        end
+
+        opts.on_tail('-h', '--help', 'Show this message') do
+          $stderr.puts opts
+          exit
+        end
+
+        opts.on_tail('--version', 'Show version') do
+          $stderr.puts ProxyPacRb::VERSION
+          exit
+        end
+      end
+
+      $stderr.puts parser.help if argv.blank?
+
+      parser.parse!(argv)
+      options.urls = argv
+    end
+  end
+end

data/lib/proxy_pac_rb/cli_validator.rb

@@ -0,0 +1,34 @@
+module ProxyPacRb
+  # Validator for commandline options
+  class CliValidator
+    private
+
+    attr_reader :options
+
+    public
+
+    def initialize(options)
+      @options = options
+    end
+
+    def validate
+      exit_with_message 'You need to provide at least one url. Multiple urls need to be separated by a space.' if empty_url?
+      exit_with_message 'You need to provide a proxy pac file.' if empty_pac_file?
+    end
+
+    private
+
+    def empty_url?
+      options.urls.blank?
+    end
+
+    def empty_pac_file?
+      options.proxy_pac_file.blank?
+    end
+
+    def exit_with_message(msg)
+      $stderr.puts msg
+      exit 1
+    end
+  end
+end

data/lib/proxy_pac_rb/encoding.rb

@@ -1,7 +1,7 @@
 module ProxyPacRb
   # Encodes strings as UTF-8
   module Encoding
-    if "".respond_to?(:encode)
+    if ''.respond_to?(:encode)
       if RUBY_ENGINE == 'jruby' || RUBY_ENGINE == 'rbx'
         # workaround for jruby bug http://jira.codehaus.org/browse/JRUBY-6588
         # workaround for rbx bug https://github.com/rubinius/rubinius/issues/1729

data/lib/proxy_pac_rb/environment.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 module ProxyPacRb
+  # Environment in which a proxy.pac will be evaluated
   class Environment
-
     private
 
     attr_reader :days, :months, :client_ip, :time, :io, :javascript_function_templates
@@ -11,8 +11,8 @@ module ProxyPacRb
     attr_reader :available_methods
 
     def initialize(options = {})
-      @days          = { "MON" => 1, "TUE" => 2, "WED" => 3, "THU" => 4, "FRI" => 5, "SAT" => 6, "SUN" => 0 }
-      @months        = { "JAN" => 1, "FEB" => 2, "MAR" => 3, "APR" => 4, "MAY" => 5, "JUN" => 6, "JUL" => 7, "AUG" => 8, "SEP" => 9, "OCT" => 10, "NOV" => 11, "DEC" => 12 }
+      @days          = { 'MON' => 1, 'TUE' => 2, 'WED' => 3, 'THU' => 4, 'FRI' => 5, 'SAT' => 6, 'SUN' => 0 }
+      @months        = { 'JAN' => 1, 'FEB' => 2, 'MAR' => 3, 'APR' => 4, 'MAY' => 5, 'JUN' => 6, 'JUL' => 7, 'AUG' => 8, 'SEP' => 9, 'OCT' => 10, 'NOV' => 11, 'DEC' => 12 }
 
       @client_ip     = options.fetch(:client_ip, '127.0.0.1')
       @time          = options.fetch(:time, Time.now)
@@ -29,7 +29,7 @@ module ProxyPacRb
         :isInNet,
         :dnsResolve,
         :dnsDomainLevels,
-        :shExpMatch,
+        :shExpMatch
       ]
     end
 
@@ -38,7 +38,7 @@ module ProxyPacRb
     end
 
     def isPlainHostName(host)
-      not host.include? "."
+      !host.include? '.'
     end
 
     def dnsDomainIs(host, domain)
@@ -46,11 +46,11 @@ module ProxyPacRb
     end
 
     def localHostOrDomainIs(host, hostdom)
-      host == hostdom or hostdom.include? host
+      host == hostdom || hostdom.include?(host)
     end
 
     def isResolvable(host)
-      !!resolve_host(host)
+      !resolve_host(host).blank?
     end
 
     def isInNet(host, pattern, mask)
@@ -62,7 +62,7 @@ module ProxyPacRb
     end
 
     def dnsDomainLevels(host)
-      host.scan(".").size
+      host.scan('.').size
     end
 
     def shExpMatch(str, shexp)
@@ -77,8 +77,10 @@ module ProxyPacRb
       Resolv.each_address(host.force_encoding('ASCII-8BIT')) do |address|
         begin
           return address if IPAddr.new(address).ipv4?
+        # rubocop:disable Lint/HandleExceptions
         rescue ArgumentError
         end
+        # rubocop:enable Lint/HandleExceptions
       end
 
       # We couldn't find an IPv4 address for the host