primer_view_components 0.43.1 → 0.43.3

data/lib/rubocop/cop/primer/deprecated_label_schemes.rb

@@ -14,6 +14,7 @@ module RuboCop
       # good
       # Primer::Beta::Label.new(scheme: :accent)
       class DeprecatedLabelSchemes < BaseCop
+        extend AutoCorrector
         INVALID_MESSAGE = <<~STR
           Avoid using deprecated schemes: https://primer.style/view-components/deprecated#labelcomponent.
         STR
@@ -44,16 +45,14 @@ module RuboCop
 
             next unless DEPRECATIONS.key?(value)
 
-            add_offense(pair.value, message: INVALID_MESSAGE)
+            add_offense(pair.value, message: INVALID_MESSAGE) do |corrector|
+              replacement = DEPRECATIONS[pair.value.value.to_sym]
+              corrector.replace(pair.value, replacement)
+            end
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            replacement = DEPRECATIONS[node.value.to_sym]
-            corrector.replace(node, replacement)
-          end
-        end
+
 
         private
 

data/lib/rubocop/cop/primer/deprecated_label_variants.rb

@@ -20,6 +20,7 @@ module RuboCop
       # good
       # Primer::Beta::Label.new(inline: true)
       class DeprecatedLabelVariants < BaseCop
+        extend AutoCorrector
         def on_send(node)
           return unless label_node?(node)
           return unless node.arguments?
@@ -37,26 +38,18 @@ module RuboCop
 
             case pair.value.value
             when :large, "large"
-              add_offense(pair, message: "Avoid using `variant: :large` with `LabelComponent`. Use `size: :large` instead.")
+              add_offense(pair, message: "Avoid using `variant: :large` with `LabelComponent`. Use `size: :large` instead.") do |corrector|
+                corrector.replace(pair, "size: :large")
+              end
             when :inline, "inline"
-              add_offense(pair, message: "Avoid using `variant: :inline` with `LabelComponent`. Use `inline: true` instead.")
+              add_offense(pair, message: "Avoid using `variant: :inline` with `LabelComponent`. Use `inline: true` instead.") do |corrector|
+                corrector.replace(pair, "inline: true")
+              end
             end
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            replacement =
-              case node.value.value
-              when :large, "large"
-                "size: :large"
-              when :inline, "inline"
-                "inline: true"
-              end
 
-            corrector.replace(node, replacement)
-          end
-        end
 
         private
 

data/lib/rubocop/cop/primer/no_tag_memoize.rb

@@ -16,7 +16,7 @@ module RuboCop
       #
       # good
       # @system_arguments[:tag] = :h2
-      class NoTagMemoize < RuboCop::Cop::Cop
+      class NoTagMemoize < RuboCop::Cop::Base
         INVALID_MESSAGE = <<~STR
           Avoid `[:tag] ||=`. Instead, try one of the following:
             - Don't allow consumers to update the tag by having a fixed tag (e.g. `system_arguments[:tag] = :div`)

data/lib/rubocop/cop/primer/primer_octicon.rb

@@ -22,7 +22,8 @@ module RuboCop
       # primer_octicon(:"icon-with-daashes")
       # primer_octicon(@ivar)
       # primer_octicon(condition > "icon" : "other-icon")
-      class PrimerOcticon < RuboCop::Cop::Cop
+      class PrimerOcticon < RuboCop::Cop::Base
+        extend AutoCorrector
         INVALID_MESSAGE = <<~STR
           Replace the octicon helper with primer_octicon. See https://primer.style/view-components/components/octicon for details.
         STR
@@ -65,11 +66,7 @@ module RuboCop
             return if invalid_classes.present?
           end
 
-          add_offense(node, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
+          add_offense(node, message: INVALID_MESSAGE) do |corrector|
             kwargs = kwargs(node)
 
             # Converting arguments for the component
@@ -86,6 +83,8 @@ module RuboCop
           end
         end
 
+
+
         private
 
         def transform_sizes(kwargs)

data/previews/primer/alpha/action_menu_preview/multiple_select_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_with(url: action_menu_form_action_path(format: route_format)) do |f| %>
+<%= form_with(url: primer_view_components.action_menu_form_action_path(format: route_format)) do |f| %>
   <%= render(Primer::Alpha::ActionMenu.new(select_variant: :multiple, dynamic_label: true, dynamic_label_prefix: "Strategy", form_arguments: { builder: f, name: "foo" })) do |menu| %>
     <% menu.with_show_button { "Strategy" } %>
     <% menu.with_item(label: "Fast forward", data: { value: "fast_forward" }) %>

data/previews/primer/alpha/action_menu_preview/single_select_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_with(url: action_menu_form_action_path(format: route_format)) do |f| %>
+<%= form_with(url: primer_view_components.action_menu_form_action_path(format: route_format)) do |f| %>
   <%= render(Primer::Alpha::ActionMenu.new(select_variant: :single, dynamic_label: true, dynamic_label_prefix: "Strategy", form_arguments: { builder: f, name: "foo" })) do |menu| %>
     <% menu.with_show_button { "Strategy" } %>
     <% menu.with_item(label: "Fast forward", data: { value: "fast_forward" }) %>

data/previews/primer/alpha/action_menu_preview/single_select_form_items.html.erb

@@ -2,7 +2,7 @@
   <% menu.with_show_button { "Group By" } %>
   <% menu.with_item(
     label: "Repository",
-    href: action_menu_form_action_path(format: route_format),
+    href: primer_view_components.action_menu_form_action_path(format: route_format),
     form_arguments: {
       method: :post,
       inputs: [{
@@ -16,7 +16,7 @@
   ) %>
   <% menu.with_item(
     label: "Date",
-    href: action_menu_form_action_path(format: route_format),
+    href: primer_view_components.action_menu_form_action_path(format: route_format),
     form_arguments: {
       method: :post,
       inputs: [{

data/previews/primer/alpha/action_menu_preview/with_actions.html.erb

@@ -9,11 +9,11 @@
 <%= render(Primer::Alpha::ActionMenu.new) do |component| %>
   <% component.with_show_button { "Trigger" } %>
   <% component.with_item(label: "Alert", tag: :button, id: "alert-item", disabled: disable_items) %>
-  <% component.with_item(label: "Navigate", tag: :a, content_arguments: { href: action_menu_landing_path }, disabled: disable_items) %>
+  <% component.with_item(label: "Navigate", tag: :a, content_arguments: { href: primer_view_components.action_menu_landing_path }, disabled: disable_items) %>
   <% component.with_item(label: "Copy text", tag: :"clipboard-copy", content_arguments: { value: "Text to copy" }, disabled: disable_items) %>
   <% component.with_item(
     label: "Submit form",
-    href: action_menu_form_action_path(format: route_format),
+    href: primer_view_components.action_menu_form_action_path(format: route_format),
     form_arguments: {
       name: "foo", value: "bar", method: :post
     },

data/previews/primer/alpha/action_menu_preview.rb

@@ -267,7 +267,7 @@ module Primer
       # @label With deferred content
       #
       def with_deferred_content
-        render(Primer::Alpha::ActionMenu.new(menu_id: "deferred", src: UrlHelpers.action_menu_deferred_path)) do |menu|
+        render(Primer::Alpha::ActionMenu.new(menu_id: "deferred", src: UrlHelpers.primer_view_components.action_menu_deferred_path)) do |menu|
           menu.with_show_button { "Menu with deferred content" }
         end
       end
@@ -275,7 +275,7 @@ module Primer
       # @label With deferred preloaded content
       #
       def with_deferred_preloaded_content
-        render(Primer::Alpha::ActionMenu.new(menu_id: "deferred-preload", preload: true, src: UrlHelpers.action_menu_deferred_preload_path)) do |menu|
+        render(Primer::Alpha::ActionMenu.new(menu_id: "deferred-preload", preload: true, src: UrlHelpers.primer_view_components.action_menu_deferred_preload_path)) do |menu|
           menu.with_show_button { "Menu with deferred and preloaded content" }
         end
       end

data/previews/primer/alpha/auto_complete_preview.rb

@@ -19,7 +19,7 @@ module Primer
             label_text: label_text,
             input_id: "input-id",
             list_id: "test-id",
-            src: UrlHelpers.autocomplete_index_path(version: "alpha"),
+            src: UrlHelpers.primer_view_components.autocomplete_index_path(version: "alpha"),
             is_label_visible: is_label_visible,
             is_label_inline: is_label_inline,
             with_icon: with_icon,
@@ -43,7 +43,7 @@ module Primer
             label_text: label_text,
             input_id: "input-id",
             list_id: "test-id",
-            src: UrlHelpers.autocomplete_index_path(version: "alpha"),
+            src: UrlHelpers.primer_view_components.autocomplete_index_path(version: "alpha"),
             is_label_visible: is_label_visible,
             is_label_inline: is_label_inline,
             with_icon: with_icon,
@@ -63,7 +63,7 @@ module Primer
             label_text: "Select a fruit",
             input_id: "input-id-1",
             list_id: "test-id-1",
-            src: UrlHelpers.autocomplete_index_path(version: "alpha"),
+            src: UrlHelpers.primer_view_components.autocomplete_index_path(version: "alpha"),
             is_label_visible: false
           )
         )
@@ -78,7 +78,7 @@ module Primer
             label_text: "Select a fruit",
             input_id: "input-id-2",
             list_id: "test-id-2",
-            src: UrlHelpers.autocomplete_index_path(version: "alpha"),
+            src: UrlHelpers.primer_view_components.autocomplete_index_path(version: "alpha"),
             is_label_inline: true
           )
         )
@@ -93,7 +93,7 @@ module Primer
             label_text: "Select a fruit",
             input_id: "input-id-3",
             list_id: "test-id-3",
-            src: UrlHelpers.autocomplete_index_path(version: "alpha"),
+            src: UrlHelpers.primer_view_components.autocomplete_index_path(version: "alpha"),
             with_icon: true
           )
         )
@@ -108,7 +108,7 @@ module Primer
             label_text: "Select a fruit",
             input_id: "input-id-4",
             list_id: "test-id-4",
-            src: UrlHelpers.autocomplete_index_path(version: "alpha"),
+            src: UrlHelpers.primer_view_components.autocomplete_index_path(version: "alpha"),
             is_clearable: true
           )
         )

data/previews/primer/alpha/dialog_preview.rb

@@ -167,7 +167,7 @@ module Primer
                                subtitle: subtitle,
                                button_text: button_text,
                                show_divider: show_divider,
-                               url: UrlHelpers.autocomplete_index_path
+                               url: UrlHelpers.primer_view_components.autocomplete_index_path
                              })
       end
 

data/previews/primer/alpha/include_fragment_preview.rb

@@ -10,12 +10,12 @@ module Primer
       # @label Playground
       # @param loading select [eager, lazy]
       def playground(loading: :eager)
-        render(Primer::Alpha::IncludeFragment.new(loading: loading, src: UrlHelpers.include_fragment_deferred_path)) { "Loading..." }
+        render(Primer::Alpha::IncludeFragment.new(loading: loading, src: UrlHelpers.primer_view_components.include_fragment_deferred_path)) { "Loading..." }
       end
 
       # @label Default options
       def default
-        render(Primer::Alpha::IncludeFragment.new(loading: :eager, src: UrlHelpers.include_fragment_deferred_path)) { "Loading..." }
+        render(Primer::Alpha::IncludeFragment.new(loading: :eager, src: UrlHelpers.primer_view_components.include_fragment_deferred_path)) { "Loading..." }
       end
     end
   end

data/previews/primer/alpha/select_panel_preview/custom_loading_description.html.erb

@@ -4,7 +4,7 @@
 <%= render(Primer::Alpha::SelectPanel.new(
   id: "select-panel",
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(
+  src: primer_view_components.select_panel_items_path(
     select_variant: :multiple,
     selected_items: selected_items,
   ),

data/previews/primer/alpha/select_panel_preview/custom_loading_label.html.erb

@@ -3,7 +3,7 @@
 <%# We set src and fetch_strategy: :local here to make the loading spinner remain visible %>
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(
+  src: primer_view_components.select_panel_items_path(
     select_variant: :multiple,
     selected_items: selected_items,
   ),

data/previews/primer/alpha/select_panel_preview/eventually_local_fetch.html.erb

@@ -2,7 +2,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path,
+  src: primer_view_components.select_panel_items_path,
   select_variant: :multiple,
   fetch_strategy: :eventually_local,
   open_on_load: open_on_load,

data/previews/primer/alpha/select_panel_preview/eventually_local_fetch_initial_failure.html.erb

@@ -2,7 +2,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(fail: "true"),
+  src: primer_view_components.select_panel_items_path(fail: "true"),
   fetch_strategy: :eventually_local,
   open_on_load: open_on_load
 )) do |panel| %>

data/previews/primer/alpha/select_panel_preview/eventually_local_fetch_no_results.html.erb

@@ -2,7 +2,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(show_results: "false"),
+  src: primer_view_components.select_panel_items_path(show_results: "false"),
   select_variant: :multiple,
   fetch_strategy: :eventually_local,
   open_on_load: open_on_load

data/previews/primer/alpha/select_panel_preview/multiselect_form.html.erb

@@ -1,6 +1,6 @@
 <% subject_id = SecureRandom.hex %>
 
-<%= form_with(url: generic_form_submission_path(format: route_format)) do |builder| %>
+<%= form_with(url: primer_view_components.generic_form_submission_path(format: route_format)) do |builder| %>
   <%= render(Primer::Alpha::SelectPanel.new(
     data: { interaction_subject: subject_id },
     select_variant: :multiple,

data/previews/primer/alpha/select_panel_preview/playground.html.erb

@@ -5,7 +5,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(
+  src: primer_view_components.select_panel_items_path(
     select_variant: :single,
     show_results: !simulate_no_results,
     fail: simulate_failure,

data/previews/primer/alpha/select_panel_preview/remote_fetch.html.erb

@@ -2,7 +2,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(
+  src: primer_view_components.select_panel_items_path(
     select_variant: :multiple,
     selected_items: selected_items,
   ),

data/previews/primer/alpha/select_panel_preview/remote_fetch_filter_failure.html.erb

@@ -4,7 +4,7 @@
   data: { interaction_subject: subject_id },
   # passing a uuid here causes the request to succeed the first time and fail all subsequent times
   # set show_results to false to simulate an initial load with no items
-  src: select_panel_items_path(show_results: show_results.to_s, fail: "true", uuid: SecureRandom.uuid),
+  src: primer_view_components.select_panel_items_path(show_results: show_results.to_s, fail: "true", uuid: SecureRandom.uuid),
   fetch_strategy: :remote,
   open_on_load: open_on_load,
   **system_arguments

data/previews/primer/alpha/select_panel_preview/remote_fetch_form.html.erb

@@ -1,10 +1,10 @@
 <% subject_id = SecureRandom.hex %>
 
-<%= form_with(url: generic_form_submission_path(format: route_format)) do |builder| %>
+<%= form_with(url: primer_view_components.generic_form_submission_path(format: route_format)) do |builder| %>
   <%= render(Primer::Alpha::SelectPanel.new(
     data: { interaction_subject: subject_id },
     select_variant: :single,
-    src: select_panel_items_path(
+    src: primer_view_components.select_panel_items_path(
         select_variant: :single,
         selected_items: selected_items,
     ),

data/previews/primer/alpha/select_panel_preview/remote_fetch_initial_failure.html.erb

@@ -2,7 +2,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(fail: "true"),
+  src: primer_view_components.select_panel_items_path(fail: "true"),
   fetch_strategy: :remote,
   open_on_load: open_on_load
 )) do |panel| %>

data/previews/primer/alpha/select_panel_preview/remote_fetch_no_results.html.erb

@@ -2,7 +2,7 @@
 
 <%= render(Primer::Alpha::SelectPanel.new(
   data: { interaction_subject: subject_id },
-  src: select_panel_items_path(show_results: "false"),
+  src: primer_view_components.select_panel_items_path(show_results: "false"),
   select_variant: :multiple,
   fetch_strategy: :remote,
   open_on_load: open_on_load

data/previews/primer/alpha/select_panel_preview/single_select_form.html.erb

@@ -1,6 +1,6 @@
 <% subject_id = SecureRandom.hex %>
 
-<%= form_with(url: generic_form_submission_path(format: route_format)) do |builder| %>
+<%= form_with(url: primer_view_components.generic_form_submission_path(format: route_format)) do |builder| %>
   <%= render(Primer::Alpha::SelectPanel.new(
     data: { interaction_subject: subject_id },
     select_variant: :single,

data/previews/primer/alpha/text_field_preview/input_group_leading_action_menu.html.erb

@@ -1,5 +1,5 @@
  <%= render(Primer::BaseComponent.new(tag: :div, flex_items: :center, display: :flex)) do %>
-  <%= form_with(url: action_menu_form_action_path(format: route_format)) do |f| %>
+  <%= form_with(url: primer_view_components.action_menu_form_action_path(format: route_format)) do |f| %>
     <%= render(Primer::Alpha::ActionMenu.new(select_variant: :single, form_arguments: { builder: f, name: "foo" })) do |menu| %>
       <% menu.with_show_button(classes: "rounded-right-0 border-right-0") { |button| button.with_trailing_action_icon(icon: :"triangle-down"); "Filter" } %>
       <% menu.with_item(label: "Fast forward", data: { value: "fast_forward" }) %>

data/previews/primer/alpha/text_field_preview.rb

@@ -220,17 +220,17 @@ module Primer
       #
       # @label Auto check request ok
       def with_auto_check_ok
-        render(Primer::Alpha::TextField.new(auto_check_src: UrlHelpers.example_check_ok_path, name: "my-text-field-18", label: "My text field"))
+        render(Primer::Alpha::TextField.new(auto_check_src: UrlHelpers.primer_view_components.example_check_ok_path, name: "my-text-field-18", label: "My text field"))
       end
 
       # @label Auto check request accepted
       def with_auto_check_accepted
-        render(Primer::Alpha::TextField.new(auto_check_src: UrlHelpers.example_check_accepted_path, name: "my-text-field-19", label: "My text field"))
+        render(Primer::Alpha::TextField.new(auto_check_src: UrlHelpers.primer_view_components.example_check_accepted_path, name: "my-text-field-19", label: "My text field"))
       end
 
       # @label Auto check request error
       def with_auto_check_error
-        render(Primer::Alpha::TextField.new(auto_check_src: UrlHelpers.example_check_error_path, name: "my-text-field-20", label: "My text field"))
+        render(Primer::Alpha::TextField.new(auto_check_src: UrlHelpers.primer_view_components.example_check_error_path, name: "my-text-field-20", label: "My text field"))
       end
       #
       # @!endgroup

data/previews/primer/alpha/toggle_switch_preview.rb

@@ -9,37 +9,37 @@ module Primer
       include ActionView::Helpers::FormTagHelper
 
       def playground
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path))
       end
 
       # @snapshot
       def default
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path))
       end
 
       # @snapshot
       def checked
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, checked: true))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, checked: true))
       end
 
       # @snapshot
       def disabled
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, enabled: false))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, enabled: false))
       end
 
       # @snapshot
       def checked_disabled
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, checked: true, enabled: false))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, checked: true, enabled: false))
       end
 
       # @snapshot
       def small
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, size: :small))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, size: :small))
       end
 
       # @snapshot
       def with_status_label_position_end
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, status_label_position: :end))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, status_label_position: :end))
       end
 
       # @snapshot
@@ -52,19 +52,19 @@ module Primer
       end
 
       def with_csrf_token
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path))
       end
 
       def with_bad_csrf_token
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, csrf_token: "i_am_a_criminal"))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, csrf_token: "i_am_a_criminal"))
       end
 
       def with_turbo
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, turbo: true))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, turbo: true))
       end
 
       def with_autofocus
-        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.toggle_switch_index_path, autofocus: true))
+        render(Primer::Alpha::ToggleSwitch.new(src: UrlHelpers.primer_view_components.toggle_switch_index_path, autofocus: true))
       end
     end
   end

data/previews/primer/beta/auto_complete_preview/with_submit_button.html.erb

@@ -4,7 +4,7 @@
       label_text: label_text,
       input_id: input_id,
       list_id: list_id,
-      src: autocomplete_index_path,
+      src: primer_view_components.autocomplete_index_path,
       show_clear_button: show_clear_button,
       visually_hide_label: visually_hide_label,
       placeholder: placeholder,