primer_view_components 0.43.1 → 0.43.3

data/app/controllers/primer/view_components/include_fragment_controller.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Primer
+  module ViewComponents
+    # :nodoc:
+    # :nocov:
+    class IncludeFragmentController < ApplicationController
+      layout false
+
+      def landing; end
+
+      def deferred
+        render "primer/view_components/include_fragment/deferred"
+      end
+    end
+  end
+end

data/app/controllers/primer/view_components/multi_controller.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Primer
+  module ViewComponents
+    # works with app/forms/multi_input_form.rb
+    # :nocov:
+    class MultiController < ApplicationController
+      def create
+        respond_to do |format|
+          format.json { render json: params.permit(:country, :region).to_h }
+        end
+      end
+    end
+  end
+end

data/app/controllers/primer/view_components/nav_list_items_controller.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module Primer
+  module ViewComponents
+    # For nav list previews/tests
+    # :nocov:
+    class NavListItemsController < ApplicationController
+      layout false
+
+      FOODS = [
+        { label: "Bachelor Chow", href: "/foods/bachelor-chow" },
+        { label: "LöBrau", href: "/foods/lobrau" },
+        { label: "Taco Bellevue Hospital", href: "/foods/taco-bellevue-hospital" },
+        { label: "Olde Fortran", href: "/foods/olde-fortran" },
+        { label: "Space Honey", href: "/foods/space-honey" },
+        { label: "Spice Weasel", href: "/foods/spice-weasel" },
+      ]
+
+      def index
+        items_per_page = 2
+        # the first page is already shown in the nav list, so we need to offset the starting index
+        start_index = (params[:page].to_i - items_per_page) * items_per_page
+        @data = FOODS.slice(start_index, items_per_page)
+        @list = Primer::Beta::NavList::Group.new  # dummy group
+      end
+    end
+  end
+end

data/app/controllers/primer/view_components/select_panel_items_controller.rb

@@ -0,0 +1,122 @@
+# frozen_string_literal: true
+
+module Primer
+  module ViewComponents
+    # :nodoc:
+    # :nocov:
+    class SelectPanelItemsController < ApplicationController
+      SELECT_PANEL_ITEMS = [
+        { value: 1, title: "Photon torpedo", description: "Starship-mounted missile" },
+        { value: 2, title: "Bat'leth", description: "The Klingon warrior's preferred means of achieving honor" },
+        { value: 3, title: "Phaser", description: "The iconic handheld laser beam" },
+        { value: 4, title: "Lightsaber", description: "An elegant weapon for a more civilized age", recent: true },
+        { value: 5, title: "Proton pack", description: "Ghostbusting equipment" },
+        { value: 6, title: "Sonic screwdriver", description: "The Time Lord's multi-purpose tool" },
+        { value: 7, title: "Tricorder", description: "Handheld sensor device", recent: true },
+        { value: 8, title: "TARDIS", description: "Time and relative dimension in space" }
+      ]
+
+      COOKIE_PREFIX = "select-panel-seen-uuid-"
+
+      def index
+        # delay a bit so loading spinners, etc can be seen
+        sleep 2
+
+        if params.fetch(:fail, "false") == "true"
+          uuid = params[:uuid]
+
+          # use the uuid to succeed for the first request and fail for all subsequent requests
+          if !uuid || seen_uuid?(uuid)
+            render status: :internal_server_error, plain: "An error occurred"
+            return
+          end
+
+          mark_seen_uuid(uuid) if uuid
+        end
+
+        show_results = params.fetch(:show_results, "true") == "true"
+        query = (params[:q] || "").downcase
+
+        results = if show_results
+                    SELECT_PANEL_ITEMS.select do |item|
+                      [item[:title], item[:description]].join(" ").downcase.include?(query)
+                    end
+                  else
+                    []
+                  end
+
+        if allows_selection?
+          results = results.map(&:dup)
+          results.each do |result|
+            if selected_items.any? { |item| result[:title].downcase.include?(item) }
+              result[:selected] = true
+              break if single_select?
+            end
+          end
+        end
+
+        clean_up_old_uuids(uuid)
+
+        respond_to do |format|
+          format.any(:html, :html_fragment) do
+            render(
+              "primer/view_components/select_panel_items/index",
+              locals: { results: results },
+              layout: false,
+              formats: [:html, :html_fragment]
+            )
+          end
+        end
+      end
+
+      private
+
+      def seen_uuid?(uuid)
+        cookies.has_key?(key_for(uuid))
+      end
+
+      def mark_seen_uuid(uuid)
+        cookies[key_for(uuid)] = "true"
+      end
+
+      def clean_up_old_uuids(current_uuid)
+        current_key = key_for(current_uuid)
+        to_delete = []
+
+        cookies.each do |k, _|
+          if k.start_with?(COOKIE_PREFIX) && k != current_key
+            to_delete << k
+          end
+        end
+
+        to_delete.each do |k|
+          cookies.delete(k)
+        end
+      end
+
+      def key_for(uuid)
+        "#{COOKIE_PREFIX}#{uuid}"
+      end
+
+      def selected_items
+        params.fetch(:selected_items, "").downcase.split(",").map(&:strip)
+      end
+
+      def select_variant
+        @select_variant ||= params.fetch(:select_variant, Primer::Alpha::SelectPanel::DEFAULT_SELECT_VARIANT).to_sym
+      end
+
+      def single_select?
+        select_variant == :single
+      end
+
+      def multi_select?
+        select_variant == :multiple
+      end
+
+      def allows_selection?
+        Primer::Alpha::SelectPanel::SELECT_VARIANT_OPTIONS.include?(select_variant)
+      end
+    end
+  end
+end

data/app/controllers/primer/view_components/toggle_switch_controller.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+module Primer
+  module ViewComponents
+    # For toggle switch previews/tests
+    # :nocov:
+    class ToggleSwitchController < ApplicationController
+      class << self
+        attr_accessor :last_request
+      end
+
+      rescue_from ActionController::InvalidAuthenticityToken, with: :handle_invalid_authenticity_token
+
+      before_action :reject_non_ajax_request
+
+      def create
+        # lol this is so not threadsafe
+        self.class.last_request = request
+
+        sleep 1 unless Rails.env.test?
+
+        if params[:fail] == "true"
+          render status: :internal_server_error, plain: "Something went wrong."
+          return
+        end
+
+        head :accepted
+      end
+
+      private
+
+      def handle_invalid_authenticity_token
+        render status: :unauthorized, plain: "Bad CSRF token."
+      end
+
+      # this mimics dotcom behavior
+      def reject_non_ajax_request
+        return if request.headers["HTTP_REQUESTED_WITH"] == "XMLHttpRequest"
+
+        head :unprocessable_entity
+      end
+
+      def form_params
+        params.permit(:value, :authenticity_token)
+      end
+    end
+  end
+end

data/app/forms/auto_complete_form.rb

@@ -9,7 +9,7 @@ class AutoCompleteForm < ApplicationForm
       name: :fruit,
       label: "Fruit",
       caption: "Please enter your favorite fruit",
-      src: Primer::UrlHelpers.autocomplete_index_path,
+      src: Primer::UrlHelpers.primer_view_components.autocomplete_index_path,
       validation_message: "Something went wrong"
     )
 

data/app/forms/immediate_validation_form.rb

@@ -8,14 +8,14 @@ class ImmediateValidationForm < ApplicationForm
       name: :has_error,
       label: "Will have error",
       caption: "Every time this checks with the server, it returns an error",
-      auto_check_src: @view_context.example_check_error_path
+      auto_check_src: @view_context.primer_view_components.example_check_error_path
     )
 
     validation_form.text_field(
       name: :no_error,
       label: "Will not error",
       caption: "Will not have an error when it checks the server",
-      auto_check_src: @view_context.example_check_ok_path,
+      auto_check_src: @view_context.primer_view_components.example_check_ok_path,
       validation_message: "This message will go away once you type something"
     )
 
@@ -23,7 +23,7 @@ class ImmediateValidationForm < ApplicationForm
       name: :random_error,
       label: "Random error or success",
       caption: "Server checks will randomly respond with errors or success",
-      auto_check_src: @view_context.example_check_random_path
+      auto_check_src: @view_context.primer_view_components.example_check_random_path
     )
   end
 end

data/app/lib/primer/forms/acts_as_component.rb

@@ -71,8 +71,6 @@ module Primer
 
         if base_path
           @base_template_path = File.dirname(base_path)
-        else
-          warn "Could not identify the template for #{self}"
         end
       end
 

data/app/lib/primer/forms/dsl/text_field_input.rb

@@ -20,7 +20,7 @@ module Primer
           @leading_visual = system_arguments.delete(:leading_visual)
           @trailing_visual = system_arguments.delete(:trailing_visual)
           @leading_spinner = !!system_arguments.delete(:leading_spinner)
-          @clear_button_id = system_arguments.delete(:clear_button_id)
+          @clear_button_id = system_arguments.delete(:clear_button_id) || SecureRandom.uuid
           @inset = system_arguments.delete(:inset)
           @monospace = system_arguments.delete(:monospace)
           @auto_check_src = system_arguments.delete(:auto_check_src)

data/app/views/primer/view_components/action_menu/deferred.html.erb

@@ -0,0 +1,22 @@
+<%= render(Primer::Alpha::ActionMenu::List.new(menu_id: "deferred")) do |list| %>
+  <% list.with_item(label: "Copy link", value: "", autofocus: true) %>
+  <% list.with_item(label: "Quote reply", value: "") %>
+  <% list.with_item(label: "Reference in new issue", value: "") %>
+  <% list.with_item(
+    label: "Show dialog",
+    tag: :button,
+    content_arguments: { "data-show-dialog-id": "my-dialog" },
+    value: "",
+    scheme: :danger
+  ) %>
+<% end %>
+
+<%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: "Confirm deletion")) do |d| %>
+  <%= render(Primer::Alpha::Dialog::Body.new()) do %>
+    Are you sure you want to delete this?
+  <% end %>
+  <%= render(Primer::Alpha::Dialog::Footer.new()) do %>
+    <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": "my-dialog" })) { "Cancel" } %>
+    <%= render(Primer::Beta::Button.new(scheme: :danger)) { "Delete" } %>
+  <% end %>
+<% end %>

data/app/views/primer/view_components/action_menu/deferred_preload.html.erb

@@ -0,0 +1,5 @@
+<%= render(Primer::Alpha::ActionMenu::List.new(menu_id: "deferred-preload")) do |list| %>
+  <% list.with_item(label: "Copy link", value: "", autofocus: true) %>
+  <% list.with_item(label: "Quote reply", value: "") %>
+  <% list.with_item(label: "Reference in new issue", value: "") %>
+<% end %>

data/app/views/primer/view_components/action_menu/form_action.html.erb

@@ -0,0 +1,2 @@
+You selected <%= @value.inspect %><br>
+Other params sent to server: <%= @other_params.inspect %>

data/app/views/primer/view_components/action_menu/landing.html.erb

@@ -0,0 +1,3 @@
+<div class="action-menu-landing-page">
+  Hello world!
+</div>

data/app/views/primer/view_components/auto_check/_error_message.html.erb

@@ -0,0 +1 @@
+The name <code><%= input_value %></code> is already taken.

data/app/views/primer/view_components/auto_check/_success_message.html.erb

@@ -0,0 +1 @@
+The name <code><%= input_value %></code> is available.

data/app/views/primer/view_components/auto_check/_warning_message.html.erb

@@ -0,0 +1,4 @@
+The name <strong><%= input_value %></strong> is available.
+<div class="color-fg-muted">
+  The name can only contain ASCII letters, digits, and the characters <code>.</code>, <code>-</code> and <code>_</code>.
+</div>

data/app/views/primer/view_components/auto_complete_test/index.html.erb

@@ -0,0 +1,15 @@
+<%# erblint:counter DeprecatedComponentsCounter 2 %>
+<% @fruit_list.each do |fruit| %>
+  <% if params['version'] == "alpha" %>
+    <%= render(Primer::Alpha::AutoComplete::Item.new(value: fruit)) { fruit } %>
+  <% else %>
+    <%= render(Primer::Beta::AutoComplete::Item.new(value: fruit)) do |component| %>
+      <% if @visual_type == "leading" %>
+        <% component.with_leading_visual_icon(icon: :"mark-github") %>
+      <% elsif @visual_type == "trailing" %>
+        <% component.with_trailing_visual_icon(icon: :"mark-github") %>
+      <% end %>
+      <%= fruit %>
+    <% end %>
+  <% end %>
+<% end %>

data/app/views/primer/view_components/auto_complete_test/no_results.html.erb

@@ -0,0 +1,16 @@
+<% if @fruit_list.length > 0 %>
+  <% @fruit_list.each do |fruit| %>
+    <%= render(Primer::Beta::AutoComplete::Item.new(value: fruit)) do |component| %>
+    <% if @visual_type == "leading" %>
+        <% component.with_leading_visual_icon(icon: :"mark-github") %>
+    <% elsif @visual_type == "trailing" %>
+        <% component.with_trailing_visual_icon(icon: :"mark-github") %>
+    <% end %>
+    <%= fruit %>
+    <% end %>
+  <% end %>
+<% else %>
+  <%= render(Primer::Beta::AutoComplete::NoResultItem.new) do %>
+    No results!
+  <% end %>
+<% end %>

data/app/views/primer/view_components/form_handler/form_action.html.erb

@@ -0,0 +1 @@
+Params sent to server: <%= @form_params.inspect %>

data/app/views/primer/view_components/include_fragment/deferred.html.erb

@@ -0,0 +1,3 @@
+<div>
+  Hello world!
+</div>

data/app/views/primer/view_components/nav_list_items/index.html.erb

@@ -0,0 +1,3 @@
+<% @data.each do |item_arguments| %>
+  <%= render(Primer::Beta::NavList::Item.new(list: @list, **item_arguments)) %>
+<% end %>

data/app/views/primer/view_components/select_panel_items/index.html.erb

@@ -0,0 +1,15 @@
+<% unless results.empty? %>
+  <%= render(Primer::Alpha::SelectPanel::ItemList.new(
+    select_variant: (params[:select_variant] || :multiple).to_sym,
+    aria: {
+      label: "options",
+    },
+    )) do |list| %>
+    <% results.each do |result| %>
+      <% list.with_item(content_arguments: { data: { value: result[:value] } }, active: result[:selected] || false) do |item| %>
+        <% item.with_description { result[:description] } %>
+        <%= result[:title] %>
+      <% end %>
+    <% end %>
+  <% end %>
+<% end %>

data/config/routes.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+Primer::ViewComponents::Engine.routes.draw do
+  get "/auto_complete", to: "auto_complete_test#index", as: :autocomplete_index
+  get "/auto_complete_no_results", to: "auto_complete_test#no_results", as: :autocomplete_no_results
+
+  resources :toggle_switch, only: [:create]
+  resources :nav_list_items, only: [:index]
+  resources :multi, only: [:create]
+  resources :select_panel_items, only: [:index]
+  resources :tree_view_items, only: [:index]
+
+  # generic form submission path
+  post "/form_handler", to: "form_handler#form_action", as: :generic_form_submission
+
+  post "/example_check/accepted", to: "auto_check#accepted", as: :example_check_accepted
+  post "/example_check/ok", to: "auto_check#ok", as: :example_check_ok
+  post "/example_check/error", to: "auto_check#error", as: :example_check_error
+  post "/example_check/random", to: "auto_check#random", as: :example_check_random
+
+  get "/action_menu/landing_page", to: "action_menu#landing", as: :action_menu_landing
+  post "/action_menu/form_action", to: "action_menu#form_action", as: :action_menu_form_action
+  get "/action_menu/deferred", to: "action_menu#deferred", as: :action_menu_deferred
+  get "/action_menu/deferred_preload", to: "action_menu#deferred_preload", as: :action_menu_deferred_preload
+
+  get "/include_fragment/deferred", to: "include_fragment#deferred", as: :include_fragment_deferred
+end

data/lib/primer/accessibility.rb

@@ -37,7 +37,10 @@ module Primer
       }
     }.freeze
 
+    # rubocop:disable Style/ClassMethodsDefinitions
     class << self
+    # rubocop:enable Style/ClassMethodsDefinitions
+
       def ignore_preview?(preview_class)
         IGNORED_PREVIEWS.include?(preview_class)
       end

data/lib/primer/view_components/engine.rb

@@ -27,6 +27,10 @@ module Primer
       config.primer_view_components.validate_class_names = !Rails.env.production?
       config.primer_view_components.raise_on_invalid_aria = false
 
+      initializer "primer_view_components.mime_types" do
+        Mime::Type.register "text/fragment+html", :html_fragment
+      end
+
       initializer "primer_view_components.assets" do |app|
         app.config.assets.precompile += %w[primer_view_components] if app.config.respond_to?(:assets)
       end

data/lib/primer/view_components/linters/autocorrectable.rb

@@ -25,7 +25,7 @@ module ERBLint
       def message(args, processed_source)
         return self.class::MESSAGE if args.nil?
 
-        "#{self.class::MESSAGE}\nTry using:\n\n#{correction(args)}\n\nYou can also run erblint in autocorrect mode:\n\nbundle exec erblint -a #{processed_source.filename}\n"
+        "#{self.class::MESSAGE}\nTry using:\n\n#{correction(args)}\n\nYou can also run erb_lint in autocorrect mode:\n\nbundle exec erb_lint -a #{processed_source.filename}\n"
       end
     end
   end

data/lib/primer/view_components/linters/migrations/iconbutton_component.rb

@@ -4,7 +4,8 @@ module RuboCop
   module Cop
     module Migrations
       # Lint and autocorrect deprecated IconButton
-      class IconButtonComponent < RuboCop::Cop::Cop
+      class IconButtonComponent < RuboCop::Cop::Base
+        extend AutoCorrector
         INVALID_MESSAGE = <<~STR
           `Primer::IconButton` is deprecated. Please use `Primer::Beta::IconButton` instead.
         STR
@@ -20,13 +21,9 @@ module RuboCop
         def on_send(node)
           return unless icon_button(node)
 
-          add_offense(node, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          return if hash_with_box_value?(node.arguments.first)
+          add_offense(node, message: INVALID_MESSAGE) do |corrector|
+            next if hash_with_box_value?(node.arguments.first)
 
-          lambda do |corrector|
             corrector.replace(icon_button(node), "Primer::Beta::IconButton")
           end
         end

data/lib/primer/view_components/linters/migrations/truncate_component.rb

@@ -4,7 +4,8 @@ module RuboCop
   module Cop
     module Migrations
       # Lint & autocorrect Truncate components
-      class TruncateComponent < RuboCop::Cop::Cop
+      class TruncateComponent < RuboCop::Cop::Base
+        extend AutoCorrector
         INVALID_MESSAGE = <<~STR
           `Primer::Truncate` is deprecated. Please use `Primer::Beta::Truncate` instead!
         STR
@@ -24,13 +25,9 @@ module RuboCop
         def on_send(node)
           return unless truncate_component(node)
 
-          add_offense(node, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          return if hash_with_inline_value?(node.arguments.first)
+          add_offense(node, message: INVALID_MESSAGE) do |corrector|
+            next if hash_with_inline_value?(node.arguments.first)
 
-          lambda do |corrector|
             if node.arguments.first.nil? == false
               corrector.replace(node.children.first, "Primer::Beta::Truncate")
               corrector.insert_after(node.arguments.first, ", tag: :div") unless truncate_with_tag?(node.arguments.first)

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 43
-      PATCH = 1
+      PATCH = 3
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rubocop/cop/primer/base_cop.rb

@@ -8,7 +8,7 @@ module RuboCop
   module Cop
     module Primer
       # :nodoc:
-      class BaseCop < RuboCop::Cop::Cop
+      class BaseCop < RuboCop::Cop::Base
         # We only verify SystemArguments if it's a `.new` call on a component or
         # a ViewHeleper call.
         def valid_node?(node)

data/lib/rubocop/cop/primer/component_name_migration.rb

@@ -15,20 +15,19 @@ module RuboCop
       # good
       # Primer::Beta::ComponentName.new()
       class ComponentNameMigration < BaseCop
+        extend AutoCorrector
+
         def on_send(node)
           return unless node.method_name == :new && !node.receiver.nil? && ::Primer::Deprecations.deprecated?(node.receiver.const_name)
 
           message = ::Primer::Deprecations.deprecation_message(node.receiver.const_name)
-          add_offense(node.receiver, message: message)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            component_name = node.const_name
-            return unless ::Primer::Deprecations.correctable?(component_name)
+          
+          add_offense(node.receiver, message: message) do |corrector|
+            component_name = node.receiver.const_name
+            next unless ::Primer::Deprecations.correctable?(component_name)
 
             replacement = ::Primer::Deprecations.replacement(component_name)
-            corrector.replace(node, replacement) if replacement.present?
+            corrector.replace(node.receiver, replacement) if replacement.present?
           end
         end
       end

data/lib/rubocop/cop/primer/deprecated_arguments.rb

@@ -14,6 +14,7 @@ module RuboCop
       # good
       # Component.new(foo: :bar)
       class DeprecatedArguments < BaseCop
+        extend AutoCorrector
         INVALID_MESSAGE = <<~STR
           Avoid using deprecated arguments: https://primer.style/view-components/deprecated.
         STR
@@ -283,17 +284,15 @@ module RuboCop
             key, value = extract_kv_from(pair)
             next unless DEPRECATED.key?(key) && DEPRECATED[key].key?(value)
 
-            add_offense(pair, message: INVALID_MESSAGE)
+            add_offense(pair, message: INVALID_MESSAGE) do |corrector|
+              key, value = extract_kv_from(pair)
+              replacement = DEPRECATED[key][value]
+              corrector.replace(pair, replacement) if replacement.present?
+            end
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            key, value = extract_kv_from(node)
-            replacement = DEPRECATED[key][value]
-            corrector.replace(node, replacement) if replacement.present?
-          end
-        end
+
 
         def extract_kv_from(pair)
           key = pair.key.value

data/lib/rubocop/cop/primer/deprecated_button_arguments.rb

@@ -14,6 +14,7 @@ module RuboCop
       # good
       # ButtonComponent.new(size: :small)
       class DeprecatedButtonArguments < BaseCop
+        extend AutoCorrector
         INVALID_MESSAGE = <<~STR
           `variant` is deprecated. Use `size` instead.
         STR
@@ -37,14 +38,12 @@ module RuboCop
 
           return if pair.nil?
 
-          add_offense(pair.key, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node, DEPRECATIONS[node.value])
+          add_offense(pair.key, message: INVALID_MESSAGE) do |corrector|
+            corrector.replace(pair.key, DEPRECATIONS[pair.key.value])
           end
         end
+
+
       end
     end
   end