poseidon 0.0.5.pre1 → 0.0.5

data/spec/unit/messages_to_send_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe MessagesToSend do
+RSpec.describe MessagesToSend do
   before(:each) do
     @messages = []
     @messages << Message.new(:topic => "test1", :value => "hi")
@@ -8,7 +8,7 @@ describe MessagesToSend do
     @messages << Message.new(:topic => "test2", :value => "hi")
 
 
-    @cluster_metadata = stub('cluster_metdata').as_null_object
+    @cluster_metadata = double('cluster_metdata').as_null_object
     @mts = MessagesToSend.new(@messages, @cluster_metadata)
   end
 
@@ -18,21 +18,21 @@ describe MessagesToSend do
     end
 
     it "asks ClusterMetadata about having metadata" do
-      @cluster_metadata.stub!(:have_metadata_for_topics?).and_return(true)
+      allow(@cluster_metadata).to receive(:have_metadata_for_topics?).and_return(true)
 
       expect(@mts.needs_metadata?).to eq(false)
     end
-  end 
+  end
 
   describe "sending" do
     before(:each) do
-      @mfb = stub('mfb', :messages => @messages)
+      @mfb = double('mfb', :messages => @messages)
       @messages_for_brokers = [@mfb]
 
-      @mtsb = stub('messages_to_send_batch').as_null_object
-      @mtsb.stub!(:messages_for_brokers).and_return(@messages_for_brokers)
+      @mtsb = double('messages_to_send_batch').as_null_object
+      allow(@mtsb).to receive(:messages_for_brokers).and_return(@messages_for_brokers)
 
-      MessagesToSendBatch.stub!(:new).and_return(@mtsb)
+      allow(MessagesToSendBatch).to receive(:new).and_return(@mtsb)
     end
 
     context "is successful" do

data/spec/unit/partition_consumer_spec.rb

@@ -1,14 +1,14 @@
 require 'spec_helper'
 
-describe PartitionConsumer do
+RSpec.describe PartitionConsumer do
   before(:each) do
-    @connection = stub('connection')
-    Connection.stub!(:new).and_return(@connection)
+    @connection = double('connection')
+    allow(Connection).to receive(:new).and_return(@connection)
 
     offset = Protocol::Offset.new(100)
     partition_offsets = [Protocol::PartitionOffset.new(0, 0, [offset])]
     @offset_response = [Protocol::TopicOffsetResponse.new("test_topic", partition_offsets)]
-    @connection.stub(:offset).and_return(@offset_response)
+    allow(@connection).to receive(:offset).and_return(@offset_response)
   end
 
   describe "creation" do
@@ -28,7 +28,7 @@ describe PartitionConsumer do
   describe "next offset" do
     context "when offset is not set" do
       it "resolves offset if it's not set" do
-        @connection.should_receive(:offset).and_return(@offset_response)
+        expect(@connection).to receive(:offset).and_return(@offset_response)
         pc = PartitionConsumer.new("test_client", "localhost", 9092, "test_topic",
                                    0, :earliest_offset)
 
@@ -52,7 +52,7 @@ describe PartitionConsumer do
 
     context "when call returns an error" do
       it "is raised" do
-        @offset_response.first.partition_offsets.first.stub!(:error).and_return(2)
+        allow(@offset_response.first.partition_offsets.first).to receive(:error).and_return(2)
         pc = PartitionConsumer.new("test_client", "localhost", 9092, "test_topic",
                                    0, :earliest_offset)
 
@@ -65,7 +65,7 @@ describe PartitionConsumer do
         pc = PartitionConsumer.new("test_client", "localhost", 9092, "test_topic",
                                    0, :earliest_offset)
 
-        @offset_response.first.partition_offsets.first.stub!(:offsets).and_return([])
+        allow(@offset_response.first.partition_offsets.first).to receive(:offsets).and_return([])
         expect(pc.next_offset).to eq(0)
       end
     end
@@ -86,9 +86,9 @@ describe PartitionConsumer do
       partition_fetch_response = Protocol::PartitionFetchResponse.new(0, 0, 100, message_set)
       topic_fetch_response = Protocol::TopicFetchResponse.new('test_topic',
                                                     [partition_fetch_response])
-      @response = Protocol::FetchResponse.new(stub('common'), [topic_fetch_response])
+      @response = Protocol::FetchResponse.new(double('common'), [topic_fetch_response])
 
-      @connection.stub(:fetch).and_return(@response)
+      allow(@connection).to receive(:fetch).and_return(@response)
       @pc = PartitionConsumer.new("test_client", "localhost", 9092, "test_topic", 0, :earliest_offset)
     end
 
@@ -97,13 +97,13 @@ describe PartitionConsumer do
     end
 
     it "uses object defaults" do
-      @connection.should_receive(:fetch).with(10_000, 1, anything)
+      expect(@connection).to receive(:fetch).with(10_000, 1, anything)
       @pc.fetch
     end
 
     context "when options are passed" do
       it "overrides object defaults" do
-        @connection.should_receive(:fetch).with(20_000, 1, anything)
+        expect(@connection).to receive(:fetch).with(20_000, 1, anything)
         @pc = PartitionConsumer.new("test_client", "localhost", 9092, "test_topic", 0, :earliest_offset, :max_wait_ms => 20_000)
 
         @pc.fetch
@@ -114,7 +114,7 @@ describe PartitionConsumer do
       it "starts from the earliest offset" do
         @pc = PartitionConsumer.new("test_client", "localhost", 9092, "test_topic", 0, -10000)
         pfr = @response.topic_fetch_responses.first.partition_fetch_responses.first
-        pfr.stub!(:error).and_return(1, 1, 0)
+        allow(pfr).to receive(:error).and_return(1, 1, 0)
 
         @pc.fetch
       end
@@ -123,7 +123,7 @@ describe PartitionConsumer do
     context "when call returns an error" do
       it "is raised" do
         pfr = @response.topic_fetch_responses.first.partition_fetch_responses.first
-        pfr.stub!(:error).and_return(2)
+        allow(pfr).to receive(:error).and_return(2)
 
         expect { @pc.fetch }.to raise_error(Errors::InvalidMessage)
       end

data/spec/unit/producer_compression_config_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ProducerCompressionConfig do
+RSpec.describe ProducerCompressionConfig do
   describe "creation" do
     it "raises ArgumentError when codec is unknown" do
       expect { ProducerCompressionConfig.new(:ripple, nil) }.to raise_error(ArgumentError)
@@ -14,6 +14,13 @@ describe ProducerCompressionConfig do
     end
   end
 
+  describe "none compression codec" do
+    it "compresses no topics" do
+      pcc = ProducerCompressionConfig.new(:none,nil)
+      expect(pcc.compression_codec_for_topic("test")).to eq(false)
+    end
+  end
+
   describe "compression codec no topics specified" do
     it "compresses any topic" do
       pcc = ProducerCompressionConfig.new(:gzip,nil)

data/spec/unit/producer_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Producer do
+RSpec.describe Producer do
   it "requires brokers and client_id" do
     expect { Producer.new }.to raise_error
   end
@@ -15,7 +15,7 @@ describe Producer do
 
   it "raises ProducerShutdown if we try to send to a shutdown producer" do
     p = Producer.new(["host:port"],"client_id")
-    p.shutdown
+    p.close
     expect { p.send_messages([]) }.to raise_error(Errors::ProducerShutdownError)
   end
 
@@ -23,16 +23,22 @@ describe Producer do
     expect { Producer.new([],"client_id", Producer::OPTION_DEFAULTS.dup) }.not_to raise_error
   end
 
+  it "accepts socket_timeout_ms option" do
+    expect { Producer.new([],"client_id", socket_timeout_ms: 10_000) }.not_to raise_error
+  end
+
   describe "sending messages" do
     before(:each) do
       @sync_producer = double('sync_producer').as_null_object
-      SyncProducer.stub!(:new).and_return(@sync_producer)
+      allow(SyncProducer).to receive(:new).and_return(@sync_producer)
 
       @producer = Producer.new([], "client_id", :type => :sync)
     end
 
     it "turns MessagesToSend into Message objects" do
-      @sync_producer.should_receive(:send_messages).with([an_instance_of(Message)])
+      expect(@sync_producer).to receive(:send_messages).with(an_instance_of(Array)) do |array|
+        array.each { |obj| expect(obj).to be_an_instance_of(Message) }
+      end
 
       m = MessageToSend.new("topic", "value")
       @producer.send_messages([m])

data/spec/unit/protocol/request_buffer_spec.rb

@@ -0,0 +1,16 @@
+# -*- coding: utf-8 -*-
+
+require 'spec_helper'
+include Protocol
+
+RSpec.describe RequestBuffer do
+  subject(:buffer) { Poseidon::Protocol::RequestBuffer.new }
+
+  it 'appends UTF-8 strings' do
+    expect do
+      str = 'hello ümlaut'
+      buffer.append(str)
+      buffer.append(str.force_encoding(Encoding::BINARY))
+    end.to_not raise_error
+  end
+end

data/spec/unit/protocol_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 include Protocol
-describe RequestCommon do
+RSpec.describe RequestCommon do
   it "roundtrips" do
     rc = RequestCommon.new(0,1,2,"client_id")
 
@@ -14,7 +14,7 @@ describe RequestCommon do
   end
 end
 
-describe MetadataRequest do
+RSpec.describe MetadataRequest do
   it "roundtrips" do
     rc = RequestCommon.new(0,1,2,"client_id")
     mr = MetadataRequest.new(rc, ["topic1","topic2"])
@@ -29,14 +29,14 @@ describe MetadataRequest do
   end
 end
 
-describe "objects with errors" do
+RSpec.describe "objects with errors" do
   it "returns objects that have errors" do
     message_set = MessageSet.new
     message_set << Message.new(:value => "value", :key => "key")
     partition_fetch_response = PartitionFetchResponse.new(0, 5, 100, message_set)
     topic_fetch_response = TopicFetchResponse.new('test_topic',
                                                   [partition_fetch_response])
-    response = FetchResponse.new(stub('common'), [topic_fetch_response])
+    response = FetchResponse.new(double('common'), [topic_fetch_response])
 
     expect(response.objects_with_errors).to eq([partition_fetch_response])
   end
@@ -47,7 +47,7 @@ describe "objects with errors" do
     partition_fetch_response = PartitionFetchResponse.new(0, 5, 100, message_set)
     topic_fetch_response = TopicFetchResponse.new('test_topic',
                                                   [partition_fetch_response])
-    response = FetchResponse.new(stub('common'), [topic_fetch_response])
+    response = FetchResponse.new(double('common'), [topic_fetch_response])
 
     expect { response.raise_error_if_one_exists }.to raise_error
   end

data/spec/unit/sync_producer_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe SyncProducer do
+RSpec.describe SyncProducer do
   describe "creation" do
 
     it "sets correct defaults" do
@@ -22,21 +22,21 @@ describe SyncProducer do
 
   describe "sending" do
     before(:each) do
-      Kernel.stub!(:sleep)
+      allow(Kernel).to receive(:sleep)
 
-      @broker_pool = stub('broker_pool').as_null_object
-      BrokerPool.stub!(:new).and_return(@broker_pool)
+      @broker_pool = double('broker_pool').as_null_object
+      allow(BrokerPool).to receive(:new).and_return(@broker_pool)
 
-      @cluster_metadata = stub('cluster_metadata', :last_refreshed_at => Time.now).as_null_object
-      ClusterMetadata.stub!(:new).and_return(@cluster_metadata)
+      @cluster_metadata = double('cluster_metadata', :last_refreshed_at => Time.now).as_null_object
+      allow(ClusterMetadata).to receive(:new).and_return(@cluster_metadata)
 
-      @mbts = stub('messages_to_send', :needs_metadata? => false).as_null_object
-      MessagesToSend.stub!(:new).and_return(@mbts)
+      @mbts = double('messages_to_send', :needs_metadata? => false).as_null_object
+      allow(MessagesToSend).to receive(:new).and_return(@mbts)
     end
 
     context "needs metadata" do
       before(:each) do
-        @mbts.stub!(:needs_metadata?).and_return(true)
+        allow(@mbts).to receive(:needs_metadata?).and_return(true)
       end
 
       it "fetches metadata" do
@@ -49,7 +49,7 @@ describe SyncProducer do
 
     context "there are messages to send" do
       before(:each) do
-        @mbts.stub!(:messages_for_brokers).and_return([double('mfb').as_null_object])
+        allow(@mbts).to receive(:messages_for_brokers).and_return([double('mfb').as_null_object])
       end
 
       it "sends messages" do
@@ -62,22 +62,22 @@ describe SyncProducer do
 
     context "always fails" do
       before(:each) do
-        @mbts.stub!(:pending_messages?).and_return(true)
+        allow(@mbts).to receive(:pending_messages?).and_return(true)
         @sp = SyncProducer.new("test_client", [])
       end
 
       it "retries the correct number of times" do
-        @mbts.should_receive(:messages_for_brokers).exactly(4).times
+        expect(@mbts).to receive(:messages_for_brokers).exactly(4).times
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")]) rescue StandardError
       end
 
       it "sleeps the correct amount between retries" do
-        Kernel.should_receive(:sleep).with(0.1).exactly(4).times
+        expect(Kernel).to receive(:sleep).with(0.1).exactly(4).times
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")]) rescue StandardError
       end
 
       it "refreshes metadata between retries" do
-        @cluster_metadata.should_receive(:update).exactly(4).times
+        expect(@cluster_metadata).to receive(:update).exactly(4).times
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")]) rescue StandardError
       end
 
@@ -90,19 +90,19 @@ describe SyncProducer do
 
     context "no retries" do
       before(:each) do
-        @mbts.stub!(:pending_messages?).and_return(true)
+        allow(@mbts).to receive(:pending_messages?).and_return(true)
         @sp = SyncProducer.new("test_client", [], max_send_retries: 0)
       end
 
       it "does not call sleep" do
-        Kernel.should_receive(:sleep).exactly(0).times
+        expect(Kernel).to receive(:sleep).exactly(0).times
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")]) rescue Errors::UnableToFetchMetadata
       end
     end
 
     context "succeeds on first attempt" do
       before(:each) do
-        @mbts.stub!(:pending_messages?).and_return(false)
+        allow(@mbts).to receive(:pending_messages?).and_return(false)
         @sp = SyncProducer.new("test_client", [])
       end
 
@@ -111,19 +111,19 @@ describe SyncProducer do
       end
 
       it "does not sleep" do
-        Kernel.should_not_receive(:sleep)
+        expect(Kernel).not_to receive(:sleep)
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")])
       end
 
       it "only attempts to send once" do
-        @mbts.should_receive(:messages_for_brokers).once
+        expect(@mbts).to receive(:messages_for_brokers).once
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")])
       end
     end
 
     context "succeeds on second attempt" do
       before(:each) do
-        @mbts.stub!(:pending_messages?).and_return(true, false)
+        allow(@mbts).to receive(:pending_messages?).and_return(true, false)
         @sp = SyncProducer.new("test_client", [])
       end
 
@@ -132,12 +132,12 @@ describe SyncProducer do
       end
 
       it "sleeps once" do
-        Kernel.should_receive(:sleep).once
+        expect(Kernel).to receive(:sleep).once
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")])
       end
 
       it "attempts to send twice" do
-        @mbts.should_receive(:messages_for_brokers).twice
+        expect(@mbts).to receive(:messages_for_brokers).twice
         @sp.send_messages([Message.new(:topic => "topic", :value => "value")])
       end
     end

data/spec/unit/topic_metadata_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe TopicMetadata do
+RSpec.describe TopicMetadata do
   context "encoding" do
     it "roundtrips" do
       partition_metadata = Protocol::PartitionMetadata.new(0, 0, 0, [0], [0])

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: poseidon
 version: !ruby/object:Gem::Version
-  version: 0.0.5.pre1
+  version: 0.0.5
 platform: ruby
 authors:
 - Bob Potter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-08 00:00:00.000000000 Z
+date: 2014-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: snappy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Kafka (http://kafka.apache.org/) producer and consumer
 email:
 - bobby.potter@gmail.com
@@ -115,6 +129,8 @@ files:
 - spec/test_cluster.rb
 - spec/unit/broker_pool_spec.rb
 - spec/unit/cluster_metadata_spec.rb
+- spec/unit/compression/gzip_codec_spec.rb
+- spec/unit/compression/snappy_codec_spec.rb
 - spec/unit/compression_spec.rb
 - spec/unit/connection_spec.rb
 - spec/unit/fetched_message_spec.rb
@@ -128,6 +144,7 @@ files:
 - spec/unit/partition_consumer_spec.rb
 - spec/unit/producer_compression_config_spec.rb
 - spec/unit/producer_spec.rb
+- spec/unit/protocol/request_buffer_spec.rb
 - spec/unit/protocol_spec.rb
 - spec/unit/sync_producer_spec.rb
 - spec/unit/topic_metadata_spec.rb
@@ -146,9 +163,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2
@@ -172,6 +189,8 @@ test_files:
 - spec/test_cluster.rb
 - spec/unit/broker_pool_spec.rb
 - spec/unit/cluster_metadata_spec.rb
+- spec/unit/compression/gzip_codec_spec.rb
+- spec/unit/compression/snappy_codec_spec.rb
 - spec/unit/compression_spec.rb
 - spec/unit/connection_spec.rb
 - spec/unit/fetched_message_spec.rb
@@ -185,7 +204,7 @@ test_files:
 - spec/unit/partition_consumer_spec.rb
 - spec/unit/producer_compression_config_spec.rb
 - spec/unit/producer_spec.rb
+- spec/unit/protocol/request_buffer_spec.rb
 - spec/unit/protocol_spec.rb
 - spec/unit/sync_producer_spec.rb
 - spec/unit/topic_metadata_spec.rb
-has_rdoc: