poseidon 0.0.5.pre1 → 0.0.5

data/spec/integration/multiple_brokers/round_robin_spec.rb

@@ -1,6 +1,6 @@
 require 'integration/multiple_brokers/spec_helper'
 
-describe "round robin sending" do
+RSpec.describe "round robin sending", :type => :request do
   describe "with small message batches" do
     it "evenly distributes messages across brokers" do
       c = Connection.new("localhost", 9092, "metadata_fetcher", 10_000)

data/spec/integration/simple/compression_spec.rb

@@ -1,6 +1,6 @@
 require 'integration/simple/spec_helper'
 
-describe "compression" do
+RSpec.describe "compression", :type => :request do
   it "roundtrips" do
     i = rand(1000)
 
@@ -12,7 +12,7 @@ describe "compression" do
                              :type => :sync,
                              :compression_codec => :gzip)
     messages = [MessageToSend.new("test12", "Hello World: #{i}")]
-    
+
     expect(@producer.send_messages(messages)).to eq(true)
     sleep 1
     messages = @consumer.fetch

data/spec/integration/simple/connection_spec.rb

@@ -1,7 +1,7 @@
 require 'integration/simple/spec_helper'
 
 include Protocol
-describe Connection do
+RSpec.describe Connection, :type => :request do
   before(:each) do
     @connection = Connection.new("localhost", 9092, "test", 10_000)
   end
@@ -11,10 +11,10 @@ describe Connection do
   end
 
   it 'sends and parsers produce requests' do
-    message = MessageStruct.new(0, 0, nil, "hello") 
+    message = MessageStruct.new(0, 0, nil, "hello")
     message_with_offset = MessageWithOffsetStruct.new(0, message)
     message_set = MessageSetStruct.new([message_with_offset])
-    messages_for_partitions = [MessagesForPartition.new(0,message_set)] 
+    messages_for_partitions = [MessagesForPartition.new(0,message_set)]
     messages_for_topics = [MessagesForTopic.new("test2",messages_for_partitions)]
     @connection.produce(1, 10_000, messages_for_topics)
   end
@@ -24,7 +24,7 @@ describe Connection do
     topic_fetches = [TopicFetch.new("test2", partition_fetches)]
     @connection.fetch(1000, 0, topic_fetches)
   end
-  
+
   it 'sends and parsers offset requests' do
     partition_offset_requests = [PartitionOffsetRequest.new(0,-1,1000)]
     offset_topic_requests = [TopicOffsetRequest.new("test2", partition_offset_requests)]

data/spec/integration/simple/multiple_brokers_spec.rb

@@ -1,6 +1,6 @@
 require 'integration/simple/spec_helper'
 
-describe "three brokers in cluster" do
+RSpec.describe "three brokers in cluster", :type => :request do
   describe "sending batches of 1 message" do
     it "sends messages to all brokers" do
     end

data/spec/integration/simple/simple_producer_and_consumer_spec.rb

@@ -1,6 +1,6 @@
 require 'integration/simple/spec_helper'
 
-describe "simple producer and consumer" do
+RSpec.describe "simple producer and consumer", :type => :request do
 
   describe "writing and consuming one topic" do
     it "fetches produced messages" do
@@ -17,7 +17,7 @@ describe "simple producer and consumer" do
       messages = @consumer.fetch
       expect(messages.last.value).to eq("Hello World")
 
-      @producer.shutdown
+      @producer.close
     end
 
     it "fetches only messages since the last offset" do
@@ -81,21 +81,21 @@ describe "simple producer and consumer" do
 
       @consumer = PartitionConsumer.new("test_consumer", "localhost", 9092,
                                         "topic_simple_producer_and_consumer", 0, -2)
-      
+
       messages = []
       2000.times do
         messages << MessageToSend.new("topic_simple_producer_and_consumer",'KcjNyFBtqfSbpwjjcGKckMKLUCWz83IVcp21C8FQzs8JJKKTTrc4OLxSjLpYc5z7fsncX59te2cBn0sWDRaYmRuZyttRMLMHvXrM5o3QReKPIYUKzVCFahC4cb3Ivcbb5ZuS98Ohnb7Io42Bz9FucXwwGkQyFhJwyn3nD3BYs5r8TZM8Q76CGR2kTH1rjnFeB7J3hrRKukztxCrDY3smrQE1bbVR80IF3yWlhzkdfv3cpfwnD0TKadtt21sFJANFmORAJ0HKs6Z2262hcBQyF7WcWypC2RoLWVgKVQxbouVUP7yV6YYOAQEevYrl9sOB0Yi6h1mS8fTBUmRTmWLqyl8KzwbnbQvmCvgnX26F5JEzIoXsVaoDT2ks5eep9RyE1zm5yPtbYVmd2Sz7t5ru0wj6YiAmbF7Xgiw2l4VpNOxG0Ec6rFxXRXs0bahyBd2YtxpGyZBeruIK1RAN4n0t97xVXgZG5CGoVhL1oRDxw2pTbwEO1cvwHiiYXpXSqaxF7G9kiiPsQt24Vu7chXrJT7Xqv4RIg1aOT5Os5JVlISaJCmx8ZLtbC3OjAdGtF1ZkDuUeQHHohqeKh0qBJjw7Rv1oSDwcM0MRazjF36jijpYg26Qml9lSEnGYIFLQWHVDWKqqhl2GIntjxDXn1IyI')
       end
       expect(@producer.send_messages(messages)).to eq(true)
-      
+
       messages = @consumer.fetch
-      expect(messages.length).to be > 2 
-      
+      expect(messages.length).to be > 2
+
       @consumer = PartitionConsumer.new("test_consumer", "localhost", 9092,
                                         "topic_simple_producer_and_consumer", 0, -2)
       messages = @consumer.fetch(:max_bytes => 1400000)
       expect(messages.length).to be > 2
-    end 
+    end
 =end
   end
 

data/spec/integration/simple/truncated_messages_spec.rb

@@ -1,6 +1,6 @@
 require 'integration/simple/spec_helper'
 
-describe "truncated messages" do
+RSpec.describe "truncated messages", :type => :request do
   before(:each) do
     @s1 = "a" * 335
     @s2 = "b" * 338
@@ -8,7 +8,7 @@ describe "truncated messages" do
     @producer = Producer.new(["localhost:9092"],
                              "test_client",
                              :type => :sync)
-                             
+
     @producer.send_messages([Message.new(:topic => 'test_max_bytes', :value => @s1), Message.new(:topic => 'test_max_bytes', :value => @s2)])
   end
 
@@ -25,7 +25,7 @@ describe "truncated messages" do
       consumer = PartitionConsumer.new("test_consumer", "localhost", 9092,
                                        "test_max_bytes", 0, :earliest_offset)
 
-      messages = consumer.fetch(:max_bytes => n) 
+      messages = consumer.fetch(:max_bytes => n)
       expect(messages.size).to eq(1)
       expect(messages.first.value).to eq(@s1)
     end
@@ -36,7 +36,7 @@ describe "truncated messages" do
       consumer = PartitionConsumer.new("test_consumer", "localhost", 9092,
                                        "test_max_bytes", 0, :earliest_offset)
 
-      messages = consumer.fetch(:max_bytes => n) 
+      messages = consumer.fetch(:max_bytes => n)
       expect(messages.size).to eq(2)
       expect(messages.map(&:value)).to eq([@s1, @s2])
     end

data/spec/integration/simple/unavailable_broker_spec.rb

@@ -1,6 +1,6 @@
 require 'integration/simple/spec_helper'
 
-describe "unavailable broker scenarios:" do
+RSpec.describe "unavailable broker scenarios:", :type => :request do
   context "producer with a dead broker in bootstrap list" do
     before(:each) do
       @p = Producer.new(["localhost:9091","localhost:9092"], "test")

data/spec/spec_helper.rb

@@ -5,19 +5,13 @@
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
-
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = 'random'
 
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
-  end
+  config.disable_monkey_patching!
 end
 
 POSEIDON_PATH = File.absolute_path(File.dirname(__FILE__) + "/../")

data/spec/unit/broker_pool_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe BrokerPool do
+RSpec.describe BrokerPool do
   context "empty broker list" do
     it "raises UnknownBroker error when trying to produce data" do
       expect { BrokerPool.new("test_client", [], 10_000).execute_api_call(0, :produce) }.to raise_error(BrokerPool::UnknownBroker)
@@ -14,9 +14,9 @@ describe BrokerPool do
         @broker = double('Poseidon::Connection', :topic_metadata => nil)
 
         expected_args = ["localhost", "9092", "test_client", 2_000]
-        connection = stub('conn').as_null_object
+        connection = double('conn').as_null_object
 
-        Connection.should_receive(:new).with(*expected_args).and_return(connection)
+        expect(Connection).to receive(:new).with(*expected_args).and_return(connection)
 
         @broker_pool.fetch_metadata(Set.new)
       end
@@ -34,20 +34,20 @@ describe BrokerPool do
         @broker_pool = BrokerPool.new("test_client", ["first:9092","second:9092"], 10_000)
         @broker_1 = double('Poseidon::Connection_1', :topic_metadata => nil, :close => nil)
         @broker_2 = double('Poseidon::Connection_2', :topic_metadata => double('topic_metadata').as_null_object, :close => nil)
-        Connection.stub!(:new).and_return(@broker_1, @broker_2)
+        allow(Connection).to receive(:new).and_return(@broker_1, @broker_2)
       end
 
       context ", first doesn't have metadata" do
         it "asks the second" do
-          @broker_2.should_receive(:topic_metadata)
+          expect(@broker_2).to receive(:topic_metadata)
 
           @broker_pool.fetch_metadata(Set.new)
         end
       end
 
       it "cleans up its connections" do
-        @broker_1.should_receive(:close)
-        @broker_2.should_receive(:close)
+        expect(@broker_1).to receive(:close)
+        expect(@broker_2).to receive(:close)
 
         @broker_pool.fetch_metadata(Set.new)
       end
@@ -63,27 +63,27 @@ describe BrokerPool do
     describe "when executing a call" do
 
       it "creates a connection for the correct broker" do
-        c = stub('conn').as_null_object
+        c = double('conn').as_null_object
         expected_args = ["localhost", 9092, "test_client", 10_000]
 
-        Connection.should_receive(:new).with(*expected_args).and_return(c)
+        expect(Connection).to receive(:new).with(*expected_args).and_return(c)
         @broker_pool.execute_api_call(0, :produce)
       end
 
       it "it does so on the correct broker" do
-        c = stub('conn').as_null_object
-        Connection.stub(:new).and_return(c)
+        c = double('conn').as_null_object
+        allow(Connection).to receive(:new).and_return(c)
 
-        c.should_receive(:produce)
+        expect(c).to receive(:produce)
         @broker_pool.execute_api_call(0, :produce)
       end
     end
 
     describe "when executing two calls" do
       it "reuses the connection" do
-        c = stub('conn').as_null_object
+        c = double('conn').as_null_object
 
-        Connection.should_receive(:new).once.and_return(c)
+        expect(Connection).to receive(:new).once.and_return(c)
         @broker_pool.execute_api_call(0, :produce)
         @broker_pool.execute_api_call(0, :produce)
       end

data/spec/unit/cluster_metadata_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 include Protocol
-describe ClusterMetadata do
+RSpec.describe ClusterMetadata do
   describe "populated" do
     before(:each) do
       partitions = [

data/spec/unit/compression/gzip_codec_spec.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+require 'spec_helper'
+
+RSpec.describe Poseidon::Compression::GzipCodec do
+
+  let :data do
+    %({"a":"val1"}\n{"a":"val2"}\n{"a":"val3"})
+  end
+
+  it "should have an ID" do
+    expect(described_class.codec_id).to eq(1)
+  end
+
+  it "should compress" do
+    compressed = described_class.compress(data)
+    expect(compressed.size).to eq(41)
+    expect(compressed.encoding).to eq(Encoding::BINARY)
+  end
+
+  it "should decompress" do
+    original = described_class.decompress(described_class.compress(data))
+    expect(original).to eq(data)
+    expect(original.encoding).to eq(Encoding::UTF_8)
+  end
+
+  it "should decompress unicode messages" do
+    str = "\x1F\x8B\b\x00\x00\x00\x00\x00\x00\x00c`\x80\x03\xE3I\x91\xD3|\x19\x18\xFE\x03\x01\x90\xA7Z\xAD\x94\xA8d\xA5\x14Z\x92XP\xEC\xE9\xE3\xE1\xEB\x12Y\xEE\xE8\x98\x16\xA4\xA4\xA3\x94\x04\x14~6}\xE9\xB39k\x94j\xA1Z\x19A\xDAm\f\xD9\xEF\x10\xD0\x1E\x8C\xA6\x1D\x00\x96\x98\x1E\xB9~\x00\x00\x00".force_encoding(Encoding::BINARY)
+    buf = Protocol::ResponseBuffer.new(described_class.decompress(str))
+    msg = MessageSet.read_without_size(buf).flatten
+    expect(msg.size).to eq(2)
+    expect(msg[0].value).to eq(%({"a":"UtapsILHMDYwAAfR","b":"日本"}))
+  end
+
+end

data/spec/unit/compression/snappy_codec_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+require 'spec_helper'
+
+RSpec.describe Poseidon::Compression::SnappyCodec do
+
+  let :data do
+    %({"a":"val1"}\n{"a":"val2"}\n{"a":"val3"})
+  end
+
+  it "should have an ID" do
+    expect(described_class.codec_id).to eq(2)
+  end
+
+  it "should compress" do
+    compressed = described_class.compress(data)
+    expect(compressed.size).to eq(34)
+    expect(compressed.encoding).to eq(Encoding::BINARY)
+  end
+
+  it "should decompress" do
+    original = described_class.decompress(described_class.compress(data))
+    expect(original).to eq(data)
+  end
+
+  it "should decompress streams" do
+    str = "\x82SNAPPY\x00\x00\x00\x00\x01\x00\x00\x00\x01\x00\x00\x00\x1E#\x00\x00\x19\x01\\\x17\x8B\xA7x\xB9\x00\x00\xFF\xFF\xFF\xFF\x00\x00\x00\tPLAINDATA".force_encoding(Encoding::BINARY)
+    buf = Protocol::ResponseBuffer.new(described_class.decompress(str))
+    msg = MessageSet.read_without_size(buf).flatten
+    expect(msg.size).to eq(1)
+    expect(msg[0].value).to eq("PLAINDATA")
+  end
+
+  it "should decompress bulk streams" do
+    str = "\x82SNAPPY\x00\x00\x00\x00\x01\x00\x00\x00\x01\x00\x00\x00\xCA\xE8\x04\x00\x00\x19\x01\xA0L`\x9E\xD4(\x00\x00\xFF\xFF\xFF\xFF\x00\x00\x00>{\"a\":\"UtaaKYLHMCwiAA-l\",\"bF\x17\x00Dm\",\"c\":1389795881}\rW \x01\x00\x00\x00Ln\x14\x98\xA8zX\x00\x00nVX\x00\x00o^X\x00\x00\x02\x01X\b3\xF1\e~\xB0\x00\x00pVX\x00\x00q^X\x00\x00\x03\x01X\b.\xE5\x82~X\x00\x00tVX\x00\x00u^X\x00\x00\x04\x01X\b o\xCE~\b\x01\x00vVX\x00\x00w^X\x00\x00\x05\x01X\f\t\xD8)(z`\x01\x00xVX\x00\x00y^X\x00\x00\x06\x01X\f@\bf\xA6zX\x00\x00zVX\x00\x000BX\x00".force_encoding(Encoding::BINARY)
+    buf = Protocol::ResponseBuffer.new(described_class.decompress(str))
+    msg = MessageSet.read_without_size(buf).flatten
+    expect(msg.size).to eq(7)
+    expect(msg[0].value).to eq(%({"a":"UtaaKYLHMCwiAA-l","b":"UtaaKYLHMCwiAA-m","c":1389795881}))
+  end
+
+  it "should decompress unicode messages" do
+    str = "\x82SNAPPY\x00\x00\x00\x00\x01\x00\x00\x00\x01\x00\x00\x00:?\x00\x00\x19\x01\xCC3\xBA?\x91\xFA\x00\x00\xFF\xFF\xFF\xFF\x00\x00\x00%{\"a\":\"UtaitILHMDAAAAfU\",\"b\":\"\xE6\x97\xA5\xE6\x9C\xAC\"}".force_encoding(Encoding::BINARY)
+    buf = Protocol::ResponseBuffer.new(described_class.decompress(str))
+    msg = MessageSet.read_without_size(buf).flatten
+    expect(msg.size).to eq(1)
+    expect(msg[0].value).to eq(%({"a":"UtaitILHMDAAAAfU","b":"日本"}))
+  end
+
+end

data/spec/unit/compression_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Compression do
+RSpec.describe Compression do
   it 'returns GzipCompessor for codec_id of 1' do
     codec = Compression.find_codec(1)
     expect(codec).to eq(Compression::GzipCodec)

data/spec/unit/connection_spec.rb

@@ -1,4 +1,4 @@
 require 'spec_helper'
 
-describe Connection do
+RSpec.describe Connection do
 end

data/spec/unit/fetched_message_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe FetchedMessage do
+RSpec.describe FetchedMessage do
   it "provides access to topic,value,key,offset" do
     mts = FetchedMessage.new("hello_topic", "Hello World", "key", 0)
     expect(mts.topic).to eq("hello_topic")

data/spec/unit/message_conductor_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 include Protocol
-describe MessageConductor do
+RSpec.describe MessageConductor do
   context "two available partitions" do
     before(:each) do
       partitions = [

data/spec/unit/message_set_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe MessageSet do
+RSpec.describe MessageSet do
   describe "converting to a compressed message" do
     before(:each) do
       ms = MessageSet.new([Message.new(:value => "I will be compressed", :topic => "test")])

data/spec/unit/message_spec.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 require 'spec_helper'
 
-describe Message do
+RSpec.describe Message do
   describe "when constructing a new message" do
     it 'raises an ArgumentError on unknown options' do
       expect { Message.new(:cow => "dog") }.to raise_error(ArgumentError)
@@ -100,7 +100,7 @@ describe Message do
 
       resp_buf = Protocol::ResponseBuffer.new(req_buf.to_s)
 
-      expect(Message.read(resp_buf).value).to eq(s.force_encoding("ASCII-8BIT"))
+      expect(Message.read(resp_buf).value).to eq(s.force_encoding(Encoding::BINARY))
     end
   end
 

data/spec/unit/message_to_send_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe MessageToSend do
+RSpec.describe MessageToSend do
   it "provides access to topic,value,key" do
     mts = MessageToSend.new("hello_topic", "Hello World", "key")
     expect(mts.topic).to eq("hello_topic")

data/spec/unit/messages_for_broker_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
-describe MessagesForBroker do
+RSpec.describe MessagesForBroker do
   context "twos message one to broker 0, partition 0, another to partition 1" do
     before(:each) do
       @messages = [ Message.new(:topic => "topic1",:value => "hi0"),
                     Message.new(:topic => "topic1",:value => "hi1")]
 
-      @compression_config = stub('compression_config',
+      @compression_config = double('compression_config',
                                  :compression_codec_for_topic => nil)
 
       @mfb = MessagesForBroker.new(0)
@@ -37,7 +37,7 @@ describe MessagesForBroker do
 
     context "and topic is compressed" do
       it "builds the protocol object correctly" do
-        @compression_config.stub!(:compression_codec_for_topic => Compression::GzipCodec)
+        allow(@compression_config).to receive_messages(:compression_codec_for_topic => Compression::GzipCodec)
         protocol_object = @mfb.build_protocol_objects(@compression_config)
 
         messages_for_topics = [

data/spec/unit/messages_to_send_batch_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-describe MessagesToSendBatch do
+RSpec.describe MessagesToSendBatch do
   context "messages sent to two different brokers" do
     before(:each) do
-      message_conductor = stub('message_conductor')
-      message_conductor.stub!(:destination).and_return([0,0],[1,1])
+      message_conductor = double('message_conductor')
+      allow(message_conductor).to receive(:destination).and_return([0,0],[1,1])
 
       @messages = [
         Message.new(:topic => "topic1", :value => "hi"),
@@ -19,7 +19,7 @@ describe MessagesToSendBatch do
 
     it "has all messages in the returned message brokers" do
       messages = @batch.messages_for_brokers.map(&:messages).flatten
-      expect(messages.to_set).to eq(@messages.to_set) 
+      expect(messages.to_set).to eq(@messages.to_set)
     end
   end
 end