polishgeeks-dev-tools 1.2.1 → 1.3.0

data/spec/lib/polish_geeks/dev_tools/commands/rspec_spec.rb

@@ -0,0 +1,106 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Commands::Rspec do
+  subject { described_class.new }
+
+  describe '#execute' do
+    let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
+
+    context 'when we run rspec' do
+      before do
+        allow(PolishGeeks::DevTools::Shell).to receive(:new) { instance }
+        expect(instance).to receive(:execute)
+          .with('bundle exec rspec spec')
+      end
+
+      it { subject.execute }
+    end
+  end
+
+  describe '#valid?' do
+    context 'when there are failures' do
+      before { subject.instance_variable_set(:@output, '2 failures') }
+
+      it { expect(subject.valid?).to eq false }
+    end
+
+    context 'when there are no failures' do
+      before { subject.instance_variable_set(:@output, '0 failures') }
+
+      it { expect(subject.valid?).to eq true }
+    end
+
+    context 'when there are no failures' do
+      let(:config) { double }
+
+      context 'and disallow pending false' do
+        before do
+          expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
+          expect(config).to receive(:rspec_disallow_pending?) { false }
+          subject.instance_variable_set(:@output, '0 failures, 2 pending')
+        end
+
+        it { expect(subject.valid?).to eq true }
+      end
+
+      context 'and disallow pending true' do
+        before do
+          expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
+          expect(config).to receive(:rspec_disallow_pending?) { true }
+        end
+
+        context 'and there are pendings' do
+          before do
+            subject.instance_variable_set(:@output, '0 failures, 2 pending')
+          end
+
+          it { expect(subject.valid?).to eq false }
+        end
+
+        context 'and there are no pendings' do
+          before do
+            subject.instance_variable_set(:@output, '0 failures, 0 pending')
+          end
+
+          it { expect(subject.valid?).to eq true }
+        end
+      end
+    end
+  end
+
+  describe '#label' do
+    context 'when we run rspec' do
+      let(:label) { '10 examples, 5 failures, 2 pending' }
+
+      before { subject.instance_variable_set(:@output, label) }
+
+      it { expect(subject.label).to eq 'Rspec (10 ex, 5 fa, 2 pe)' }
+    end
+  end
+
+  describe '#examples_count' do
+    before { subject.instance_variable_set(:@output, '10 examples') }
+
+    it { expect(subject.send(:examples_count)).to eq(10) }
+  end
+
+  describe '#failures_count' do
+    before { subject.instance_variable_set(:@output, '10 failures') }
+
+    it { expect(subject.send(:failures_count)).to eq(10) }
+  end
+
+  describe '#pending_count' do
+    before { subject.instance_variable_set(:@output, '10 pending') }
+
+    it { expect(subject.send(:pending_count)).to eq(10) }
+  end
+
+  describe '.generator?' do
+    it { expect(described_class.generator?).to eq false }
+  end
+
+  describe '.validator?' do
+    it { expect(described_class.validator?).to eq true }
+  end
+end

data/spec/lib/polish_geeks/dev_tools/commands/rubocop_spec.rb

@@ -0,0 +1,131 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Commands::Rubocop do
+  subject { described_class.new }
+  let(:config) { double }
+  before { allow(PolishGeeks::DevTools::Config).to receive(:config) { config } }
+
+  describe '#execute' do
+    let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
+    let(:path) { '/' }
+
+    before do
+      expect(ENV)
+        .to receive(:[])
+        .with('BUNDLE_GEMFILE')
+        .and_return(path)
+        .at_least(:once)
+      allow(PolishGeeks::DevTools::Shell).to receive(:new) { instance }
+    end
+
+    context 'when app config exists' do
+      let(:cmd) do
+        "bundle exec rubocop #{PolishGeeks::DevTools.app_root}" \
+        " -c #{subject.class.config_manager.path}" \
+        ' --require rubocop-rspec'
+      end
+
+      before do
+        expect(config).to receive(:rubocop_rspec?) { true }
+        allow(subject.class.config_manager).to receive(:application?) { true }
+        allow(subject.class.config_manager).to receive(:application_path) { path }
+        expect(instance).to receive(:execute).with(cmd)
+      end
+
+      it { subject.execute }
+    end
+
+    context 'when app config does not exist' do
+      let(:path) { Dir.pwd }
+      let(:cmd) do
+        "bundle exec rubocop #{PolishGeeks::DevTools.app_root} " \
+        "-c #{subject.class.config_manager.path}"
+      end
+
+      before do
+        allow(PolishGeeks::DevTools).to receive(:gem_root).and_return(path)
+        expect(config).to receive(:rubocop_rspec?) { false }
+        allow(subject.class.config_manager).to receive(:application?) { false }
+        allow(subject.class.config_manager).to receive(:local_path) { path }
+        expect(instance).to receive(:execute).with(cmd)
+      end
+
+      it { subject.execute }
+    end
+  end
+
+  describe '#valid?' do
+    context 'when offenses count is equal 0' do
+      before do
+        expect(subject)
+          .to receive(:offenses_count)
+          .and_return(0)
+      end
+
+      it 'returns true' do
+        expect(subject.valid?).to eq true
+      end
+    end
+
+    context 'when offenses count is different from 0' do
+      before do
+        expect(subject)
+          .to receive(:offenses_count)
+          .and_return(100)
+      end
+
+      it 'returns false' do
+        expect(subject.valid?).to eq false
+      end
+    end
+  end
+
+  describe '#label' do
+    before do
+      expect(subject).to receive(:files_count) { 10 }
+      expect(subject).to receive(:offenses_count) { 5 }
+    end
+
+    context 'when we run rubocop' do
+      before { expect(config).to receive(:rubocop_rspec?) { false } }
+      it { expect(subject.label).to eq 'Rubocop (10 files, 5 offenses)' }
+    end
+
+    context 'when we run rubocop with rspec' do
+      before { expect(config).to receive(:rubocop_rspec?) { true } }
+      it { expect(subject.label).to eq 'Rubocop with RSpec (10 files, 5 offenses)' }
+    end
+  end
+
+  describe '#files_count' do
+    context 'when we count files' do
+      before do
+        subject.instance_variable_set(:@output, '10 files inspected')
+      end
+
+      it 'returns a proper value' do
+        expect(subject.send(:files_count)).to eq 10
+      end
+    end
+  end
+
+  describe '#offenses_count' do
+    context 'when we count offenses' do
+      before do
+        subject.instance_variable_set(:@output, '5 offenses detected')
+      end
+
+      it 'returns a proper value' do
+        expect(subject.send(:offenses_count)).to eq 5
+      end
+    end
+  end
+
+  describe '.generator?' do
+    it { expect(described_class.generator?).to eq false }
+  end
+
+  describe '.validator?' do
+    it { expect(described_class.validator?).to eq true }
+  end
+end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/rubycritic_spec.rb

@@ -4,14 +4,16 @@ RSpec.describe PolishGeeks::DevTools::Commands::Rubycritic do
   subject { described_class.new }
 
   describe '#execute' do
+    let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
+
     context 'when we run rubycritic' do
       before do
-        expect_any_instance_of(PolishGeeks::DevTools::Shell)
-          .to receive(:execute)
+        allow(PolishGeeks::DevTools::Shell).to receive(:new) { instance }
+        expect(instance).to receive(:execute)
           .with('bundle exec rubycritic ./app ./lib/')
       end
 
-      it 'should execute the command' do
+      it 'executes the command' do
         subject.execute
       end
     end

data/spec/lib/polish_geeks/dev_tools/commands/simplecov_spec.rb

@@ -0,0 +1,136 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Commands::Simplecov do
+  context 'class' do
+    subject { described_class }
+
+    describe '#validators' do
+      it 'works only when we have Simplecov' do
+        expect(subject.validators).to eq [PolishGeeks::DevTools::Validators::Simplecov]
+      end
+    end
+  end
+
+  context 'instance' do
+    subject { described_class.new }
+
+    let(:label) { '(95.00%) covered' }
+    let(:config) { double }
+
+    describe '#to_f' do
+      context 'when we run simplecov' do
+        before do
+          subject.instance_variable_set(:@output, label)
+        end
+
+        it 'returns number of coverage as a float value' do
+          expect(subject.to_f).to eq 95.00
+        end
+      end
+    end
+
+    describe '#execute' do
+      context 'when we run simplecov' do
+        let(:output) { OpenStruct.new(rspec: label) }
+
+        before do
+          subject.instance_variable_set(:@stored_output, output)
+        end
+
+        it 'executes the command' do
+          expect(subject.execute).to eq label
+        end
+      end
+    end
+
+    describe '#valid?' do
+      context 'when cc level is greater or equal than expected' do
+        before do
+          expect(subject)
+            .to receive(:to_f)
+            .and_return(95.0)
+          expect(PolishGeeks::DevTools::Config)
+            .to receive(:config)
+            .and_return(config)
+          expect(config)
+            .to receive(:simplecov_threshold)
+            .and_return(65.0)
+        end
+
+        it 'returns true' do
+          expect(subject.valid?).to eq true
+        end
+      end
+
+      context 'when cc level is less than expected' do
+        before do
+          expect(subject)
+            .to receive(:to_f)
+            .and_return(65.0)
+          expect(PolishGeeks::DevTools::Config)
+            .to receive(:config)
+            .and_return(config)
+          expect(config)
+            .to receive(:simplecov_threshold)
+            .and_return(95.0)
+        end
+
+        it 'returns false' do
+          expect(subject.valid?).to eq false
+        end
+      end
+    end
+
+    describe '#label' do
+      context 'when we run simplecov and cc is greater or equal than expected' do
+        before do
+          expect(subject)
+            .to receive(:to_f)
+            .and_return(95.0)
+          expect(PolishGeeks::DevTools::Config)
+            .to receive(:config)
+            .and_return(config)
+          expect(config)
+            .to receive(:simplecov_threshold)
+            .and_return(65.0)
+        end
+
+        it 'returns the label' do
+          expect(subject.label).to eq 'SimpleCov covered 95.0%, required 65.0%'
+        end
+      end
+    end
+
+    describe '#error_message' do
+      context 'when we run simplecov and cc is less than expected' do
+        before { allow(subject).to receive(:to_f) { 65.0 } }
+
+        context 'and threshold is 95%' do
+          before { allow(subject).to receive(:threshold) { 95.0 } }
+
+          it 'returns the error message' do
+            expect(subject.error_message)
+              .to eq 'SimpleCov coverage level needs to be 95.0% or more, was 65.0%'
+          end
+        end
+
+        context 'and threshold is 100%' do
+          before { allow(subject).to receive(:threshold) { 100.0 } }
+
+          it 'returns the error message' do
+            expect(subject.error_message)
+              .to eq 'SimpleCov coverage level needs to be 100.0%, was 65.0%'
+          end
+        end
+      end
+    end
+
+    describe '.generator?' do
+      it { expect(described_class.generator?).to eq false }
+    end
+
+    describe '.validator?' do
+      it { expect(described_class.validator?).to eq true }
+    end
+  end
+end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/tasks_files_names_spec.rb

@@ -68,12 +68,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::TasksFilesNames do
       )
     end
 
-    it 'should not be empty' do
-      expect(subject.send(:files, dummy_type)).to_not be_empty
+    it 'does not be empty' do
+      expect(subject.send(:files, dummy_type)).not_to be_empty
     end
 
-    it 'should not contain directories' do
-      expect(subject.send(:files, dummy_type)).to_not include('command')
+    it 'does not contain directories' do
+      expect(subject.send(:files, dummy_type)).not_to include('command')
     end
   end
 
@@ -93,16 +93,16 @@ RSpec.describe PolishGeeks::DevTools::Commands::TasksFilesNames do
         .and_return(example_rake_files)
     end
 
-    it 'should set counter' do
+    it 'sets counter' do
       expected = example_cap_files.count + example_rake_files.count
       subject.execute
       expect(subject.counter).to eq expected
     end
 
-    it 'should mark all inapropriate files' do
+    it 'marks all inapropriate files' do
       subject.execute
-      expect(subject.output).to_not include('test.cap')
-      expect(subject.output).to_not include('test.rake')
+      expect(subject.output).not_to include('test.cap')
+      expect(subject.output).not_to include('test.rake')
     end
   end
 end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/yard_spec.rb

@@ -4,17 +4,17 @@ RSpec.describe PolishGeeks::DevTools::Commands::Yard do
   subject { described_class.new }
 
   describe '#execute' do
+    let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
+
     context 'when we run yard' do
       before do
-        expect(subject)
-          .to receive(:options)
-          .and_return('--list-undoc')
-        expect_any_instance_of(PolishGeeks::DevTools::Shell)
-          .to receive(:execute)
+        expect(subject).to receive(:options) { '--list-undoc' }
+        allow(PolishGeeks::DevTools::Shell).to receive(:new) { instance }
+        expect(instance).to receive(:execute)
           .with('bundle exec yard stats --list-undoc')
       end
 
-      it 'should execute the command' do
+      it 'executes the command' do
         subject.execute
       end
     end
@@ -26,7 +26,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::Yard do
         subject.instance_variable_set(:@output, 'OK')
       end
 
-      it 'should return true' do
+      it 'returns true' do
         expect(subject.valid?).to eq true
       end
     end
@@ -36,7 +36,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::Yard do
         subject.instance_variable_set(:@output, 'warn')
       end
 
-      it 'should return false' do
+      it 'returns false' do
         expect(subject.valid?).to eq false
       end
     end
@@ -46,7 +46,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::Yard do
         subject.instance_variable_set(:@output, 'undocumented objects')
       end
 
-      it 'should return false' do
+      it 'returns false' do
         expect(subject.valid?).to eq false
       end
     end
@@ -70,7 +70,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::Yard do
           .and_return('--private')
       end
 
-      it 'should return lines with options' do
+      it 'returns lines with options' do
         expect(subject.send(:options)).to eq '--private --list-undoc'
       end
     end