polishgeeks-dev-tools 1.2.1 → 1.3.0

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/examples_comparator_spec.rb

@@ -27,7 +27,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     context 'when compared files structure is the same' do
       let(:compare_result) { true }
 
-      it 'should put a successful message into output' do
+      it 'puts a successful message into output' do
         subject.execute
 
         expect(subject.output).to include 'success'
@@ -37,7 +37,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     context 'when compared files structure is not the same' do
       let(:compare_result) { false }
 
-      it 'should put a failed message into output' do
+      it 'puts a failed message into output' do
         subject.execute
         expect(subject.output).to include 'failed'
       end
@@ -49,7 +49,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
       "#{File.expand_path(PolishGeeks::DevTools.app_root + '/config')}/**/*.yml.example"
     end
 
-    it 'should be equal to expected message' do
+    it 'is equal to expected message' do
       expect(subject.send(:config_path)).to eq expected
     end
   end
@@ -58,7 +58,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     let(:compare_header) { rand.to_s }
     let(:expected) { "\e[32m success\e[0m - #{compare_header}\n" }
 
-    it 'should be equal to expected message' do
+    it 'is equal to expected message' do
       expect(subject.send(:successful_compare, compare_header)).to eq expected
     end
   end
@@ -67,7 +67,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     let(:compare_header) { rand.to_s }
     let(:expected) { "\e[31m failed\e[0m - #{compare_header} - structure not equal\n" }
 
-    it 'should be equal to expected message' do
+    it 'is equal to expected message' do
       expect(subject.send(:failed_compare, compare_header)).to eq expected
     end
   end
@@ -75,7 +75,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
   describe '#compare_header' do
     let(:expected) { "#{File.basename(example_file)} and #{File.basename(dedicated_file)}" }
 
-    it 'should be equal to expected message' do
+    it 'is equal to expected message' do
       expect(subject.send(:compare_header, example_file, dedicated_file)).to eq expected
     end
   end
@@ -145,7 +145,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
         subject.instance_variable_set(:@output, 'OK')
       end
 
-      it 'should return true' do
+      it 'returns true' do
         expect(subject.valid?).to eq true
       end
     end
@@ -155,7 +155,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
         subject.instance_variable_set(:@output, 'failed')
       end
 
-      it 'should return false' do
+      it 'returns false' do
         expect(subject.valid?).to eq false
       end
     end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/expires_in_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExpiresIn do
   let(:config) { double }
 
   describe '#execute' do
-    it 'should execute the command' do
+    it 'executes the command' do
       subject.execute
     end
   end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/final_blank_line_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
         subject.execute
       end
 
-      it 'should set appropriate variables' do
+      it 'sets appropriate variables' do
         expect(subject.output).to eq []
         expect(subject.counter).to eq(files.count)
       end
@@ -43,7 +43,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
         subject.execute
       end
 
-      it 'should set appropriate variables' do
+      it 'sets appropriate variables' do
         expect(subject.output).to eq files
         expect(subject.counter).to eq(files.count)
       end
@@ -157,49 +157,6 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
     end
   end
 
-  describe '#files_from_path' do
-    let(:app_root) { PolishGeeks::DevTools.app_root }
-
-    context 'path is a directory' do
-      let(:path) { rand.to_s }
-      let(:file_in_path) { "#{app_root}/#{rand}" }
-      let(:dir_in_path) { "#{app_root}/#{rand}" }
-      before do
-        expect(File)
-          .to receive(:file?)
-          .with("#{app_root}/#{path}")
-          .and_return(false)
-
-        expect(Dir)
-          .to receive(:glob)
-          .with("#{app_root}/#{path}")
-          .and_return([file_in_path, dir_in_path])
-
-        expect(File)
-          .to receive(:file?)
-          .with(file_in_path)
-          .and_return(true)
-
-        expect(File)
-          .to receive(:file?)
-          .with(dir_in_path)
-          .and_return(false)
-      end
-      it { expect(subject.send(:files_from_path, path)).to eq [file_in_path] }
-    end
-
-    context 'path is a file' do
-      let(:path) { rand.to_s }
-      before do
-        expect(File)
-          .to receive(:file?)
-          .with("#{app_root}/#{path}")
-          .and_return(true)
-      end
-      it { expect(subject.send(:files_from_path, path)).to eq ["#{app_root}/#{path}"] }
-    end
-  end
-
   describe '#sanitize' do
     let(:file) { rand.to_s }
     let(:app_root) { PolishGeeks::DevTools.app_root }

data/spec/lib/polish_geeks/dev_tools/commands/gemfile_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Commands::Gemfile do
+  subject { described_class.new }
+
+  describe '#execute' do
+    let(:wrong_gem) { rand.to_s }
+    let(:gemfile) { double }
+    let(:output) { [rand.to_s] }
+
+    before do
+      expect(File)
+        .to receive(:join)
+        .with(::PolishGeeks::DevTools.app_root, 'Gemfile')
+        .and_return(gemfile)
+    end
+
+    context 'gemfile file exists' do
+      before do
+        expect(File)
+          .to receive(:exist?)
+          .with(gemfile)
+          .and_return(true)
+
+        expect(IO)
+          .to receive(:readlines)
+          .with(gemfile)
+          .and_return([wrong_gem])
+
+        expect(wrong_gem)
+          .to receive(:match)
+          .with(described_class::CHECKED_REGEXP)
+          .and_return(true)
+      end
+
+      it 'set wrong gems to output' do
+        subject.execute
+        expect(subject.output).to eq [wrong_gem]
+      end
+    end
+
+    context 'gemfile file does not exist' do
+      before do
+        expect(File)
+          .to receive(:exist?)
+          .with(gemfile)
+          .and_return(false)
+      end
+
+      it 'set empty array to output' do
+        subject.execute
+        expect(subject.output).to eq []
+      end
+    end
+  end
+
+  describe '#label' do
+    it { expect(subject.label).to eq 'Gemfile checking' }
+  end
+
+  describe '#error_message' do
+    let(:output) { [rand.to_s, rand.to_s] }
+
+    before do
+      subject.instance_variable_set('@output', output)
+    end
+
+    it 'contains output with wrong gems' do
+      expect(subject.error_message)
+        .to eq "Gemfile contains gems from local path: \n#{output.join('')}"
+    end
+  end
+
+  describe '#valid?' do
+    context 'when output is empty' do
+      before do
+        subject.instance_variable_set('@output', [])
+      end
+
+      it { expect(subject.valid?).to be true }
+    end
+
+    context 'when output is not empty' do
+      before do
+        subject.instance_variable_set('@output', [rand.to_s])
+      end
+
+      it { expect(subject.valid?).to be false }
+    end
+  end
+end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/haml_lint_spec.rb

@@ -4,25 +4,22 @@ RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
   subject { described_class.new }
 
   describe '#execute' do
+    let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
     let(:path) { '/' }
+
     before do
-      expect(ENV)
-        .to receive(:[])
-        .with('BUNDLE_GEMFILE')
-        .and_return(path)
+      expect(ENV).to receive(:[]).with('BUNDLE_GEMFILE') { path }
+      allow(PolishGeeks::DevTools::Shell).to receive(:new) { instance }
     end
 
     context 'when app config exists' do
       before do
-        expect(File)
-          .to receive(:exist?)
-          .and_return(true)
-        expect_any_instance_of(PolishGeeks::DevTools::Shell)
-          .to receive(:execute)
+        expect(File).to receive(:exist?) { true }
+        expect(instance).to receive(:execute)
           .with("bundle exec haml-lint -c #{path}.haml-lint.yml app/views")
       end
 
-      it 'should execute the command' do
+      it 'executes the command' do
         subject.execute
       end
     end
@@ -30,18 +27,13 @@ RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
     context 'when app config does not exist' do
       let(:path) { Dir.pwd }
       before do
-        expect(PolishGeeks::DevTools)
-          .to receive(:gem_root)
-          .and_return(path)
-        expect(File)
-          .to receive(:exist?)
-          .and_return(false)
-        expect_any_instance_of(PolishGeeks::DevTools::Shell)
-          .to receive(:execute)
+        expect(PolishGeeks::DevTools).to receive(:gem_root) { path }
+        expect(File).to receive(:exist?) { false }
+        expect(instance).to receive(:execute)
           .with("bundle exec haml-lint -c #{path}/config/haml-lint.yml app/views")
       end
 
-      it 'should execute the command' do
+      it 'executes the command' do
         subject.execute
       end
     end
@@ -53,7 +45,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
         subject.instance_variable_set('@output', '[W] SpaceInsideHashAttributes')
       end
 
-      it 'should be false' do
+      it 'is false' do
         expect(subject.valid?).to eq false
       end
     end
@@ -63,7 +55,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
         subject.instance_variable_set('@output', '')
       end
 
-      it 'should be true' do
+      it 'is true' do
         expect(subject.valid?).to eq true
       end
     end

data/spec/lib/polish_geeks/dev_tools/commands/required_files_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Commands::RequiredFiles do
+  subject { described_class.new }
+
+  let(:config) { double }
+
+  describe '#execute' do
+    context 'when required_files_include is set' do
+      let(:required_files_include) { 'REVIEW.md' }
+      let(:config) do
+        double(
+          required_files_include: [required_files_include]
+        )
+      end
+
+      before do
+        expect(PolishGeeks::DevTools)
+          .to receive(:config)
+          .and_return(config)
+        subject.execute
+      end
+
+      it { expect(subject.error_message.match(/REVIEW.md not exist/)).not_to be_nil }
+    end
+
+    context 'when required_files_include is empty' do
+      it { expect(subject.error_message).to be_nil }
+    end
+  end
+
+  describe '#valid?' do
+    context 'when file exist' do
+      before { subject.instance_variable_set('@output', []) }
+
+      it { expect(subject.valid?).to be true }
+    end
+  end
+
+  describe '#error_message' do
+    context 'when output is not empty' do
+      let(:file_name) { rand.to_s }
+      let(:output) { [file_name] }
+      let(:expected) { "Following files does not exist or are empty:\n#{file_name}\n" }
+      before do
+        subject.instance_variable_set('@output', output)
+      end
+      it { expect(subject.error_message).to eq expected }
+    end
+  end
+end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/rspec_files_names_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesNames do
     context 'when we dont have invalid files' do
       let(:files) { ['test_spec.rb'] }
 
-      it 'should set appropriate variables' do
+      it 'sets appropriate variables' do
         expect(subject.output).to eq []
         expect(subject.counter).to eq(described_class::CHECKED_DIRS.count * files.count)
       end
@@ -42,7 +42,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesNames do
     context 'when we have invalid files' do
       let(:files) { ['test_spe.rb'] }
 
-      it 'should set appropriate variables' do
+      it 'sets appropriate variables' do
         expect(subject.output).to eq(files * described_class::CHECKED_DIRS.count)
         expect(subject.counter).to eq(described_class::CHECKED_DIRS.count * files.count)
       end

data/spec/lib/{polishgeeks/dev-tools → polish_geeks/dev_tools}/commands/rspec_files_structure_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'tempfile'
 
 RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
   subject { described_class.new }
@@ -17,7 +18,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
         .and_return(analyzed_files_result)
 
       expect(subject)
-        .to receive(:rspec_files)
+        .to receive(:analyzed_rspec_files)
         .exactly(2).times
         .and_return(rspec_files_result)
 
@@ -30,7 +31,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
         .and_return(substract_rspec_result)
     end
 
-    it 'should be subtraction' do
+    it 'is subtraction' do
       subject.execute
 
       expect(subject.instance_variable_get(:@output)).to eq expected
@@ -47,35 +48,25 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
         .at_least(:once)
     end
 
-    it { expect(subject.send(:analyzed_files)).to_not be_empty }
+    it { expect(subject.send(:analyzed_files)).not_to be_empty }
 
     context 'when we gather files for analyze' do
-      let(:file) { double }
+      let(:file) { Tempfile.new }
       let(:files_collection) { [file] }
 
-      before do
-        expect(described_class::FILES_CHECKED)
-          .to receive(:map)
-          .and_return(files_collection)
-      end
-
-      it 'should flatten, uniq and sanitize' do
-        expect(files_collection)
-          .to receive(:flatten!)
-
-        expect(files_collection)
-          .to receive(:uniq!)
+      before { expect(subject).to receive(:checked_files) { files_collection } }
 
-        expect(subject)
-          .to receive(:sanitize)
-          .with(file)
+      it 'flatten,s uniq and sanitize' do
+        expect(files_collection).to receive(:flatten!)
+        expect(files_collection).to receive(:uniq!)
+        expect(subject).to receive(:sanitize).with(file)
 
         subject.send(:analyzed_files)
       end
     end
   end
 
-  describe '#rspec_files' do
+  describe '#analyzed_rspec_files' do
     let(:config) { double(rspec_files_structure_ignored: nil) }
 
     before do
@@ -85,19 +76,15 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
         .at_least(:once)
     end
 
-    it { expect(subject.send(:rspec_files)).to_not be_empty }
+    it { expect(subject.send(:analyzed_rspec_files)).not_to be_empty }
 
     context 'when we gather rspec files' do
       let(:file) { double }
       let(:files_collection) { [file] }
 
-      before do
-        expect(described_class::RSPEC_FILES)
-          .to receive(:map)
-          .and_return(files_collection)
-      end
+      before { expect(subject).to receive(:rspec_files) { files_collection } }
 
-      it 'should flatten, uniq and sanitize' do
+      it 'flatten,s uniq and sanitize' do
         expect(files_collection)
           .to receive(:flatten!)
 
@@ -108,7 +95,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
           .to receive(:sanitize)
           .with(file)
 
-        subject.send(:rspec_files)
+        subject.send(:analyzed_rspec_files)
       end
     end
   end
@@ -141,7 +128,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
           .and_return(analyzed_files_result)
       end
 
-      it 'should return the label' do
+      it 'returns the label' do
         expected = "Rspec files structure (#{analyzed_files_result.count} checked)"
         expect(subject.label).to eq expected
       end
@@ -161,7 +148,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
           .and_return(message)
       end
 
-      it 'should return the error message' do
+      it 'returns the error message' do
         expect(subject.error_message).to eq expected
       end
     end
@@ -241,7 +228,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       subject.instance_variable_set(:@output, output)
     end
 
-    it 'should return the error message' do
+    it 'returns the error message' do
       expect(subject.send(:files_error_message))
         .to eq "Following files don't have corresponding Rspec files:\n\ntest.rb\n"
     end
@@ -254,7 +241,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       subject.instance_variable_set(:@output, output)
     end
 
-    it 'should return the error message' do
+    it 'returns the error message' do
       expect(subject.send(:rspec_error_message))
         .to eq "\n\nFollowing Rspec don't have corresponding files:\n\ntest_rspec_spec.rb\n"
     end