pod4 0.10.6 → 1.0.0

data/spec/mri/sequel_encrypting_spec.rb

@@ -46,7 +46,7 @@ describe "(writing encrypted data via sequel_interface)" do
       include Pod4::Encrypting
 
       encrypted_columns :name, :ailment
-      set_key           "dflkasdgklajndgnalkghlgasdgasdghaalsdg"
+      set_key           "dflkasdgklajndgn"
       set_iv_column     :nonce
     end
   end

data/spec/mri/sequel_interface_spec.rb

@@ -1,16 +1,28 @@
-require 'pod4/sequel_interface'
+require "pod4/sequel_interface"
 
-require 'sequel'
-require 'date'
-require 'time'
-require 'bigdecimal'
+require "sequel"
+require "date"
+require "time"
+require "bigdecimal"
 
-require_relative '../common/shared_examples_for_interface'
+require_relative "../common/shared_examples_for_interface"
 
 
 
 describe "SequelInterface" do
 
+  def fill_data(ifce)
+    data.each{|r| ifce.create(r) }
+  end
+
+  def fill_product_data(ifce)
+    ifce.create( {code: "foo", name: "bar"} )
+  end
+
+  def list_contains(ifce, id)
+    ifce.list.find {|x| x[ifce.id_fld] == id }
+  end
+
   let(:sequel_interface_class) do
     Class.new SequelInterface do
       set_table :customer
@@ -22,14 +34,14 @@ describe "SequelInterface" do
     Class.new SequelInterface do
       set_schema :public
       set_table  :customer
-      set_id_fld :id
+      set_id_fld :id, autoincrement: true
     end
   end
 
   let(:prod_interface_class) do
     Class.new SequelInterface do
       set_table  :product
-      set_id_fld :code
+      set_id_fld :code, autoincrement: false
     end
   end
 
@@ -45,43 +57,32 @@ describe "SequelInterface" do
     end
   end
 
-
-
   let(:data) do
     d = []
-    d << { name:      'Barney',
+    d << { name:      "Barney",
            level:     1.23,
            day:       Date.parse("2016-01-01"),
-           timestamp: Time.parse('2015-01-01 12:11'),
+           timestamp: Time.parse("2015-01-01 12:11"),
            flag:      true,
            price:     BigDecimal("1.24") }
 
-    d << { name:      'Fred',
+    d << { name:      "Fred",
            level:     2.34,
            day:       Date.parse("2016-02-02"),
-           timestamp: Time.parse('2015-01-02 12:22'),
+           timestamp: Time.parse("2015-01-02 12:22"),
            flag:      false,
            price:     BigDecimal("2.35") }
 
-    d << { name:      'Betty',
+    d << { name:      "Betty",
            level:     3.45,
            day:       Date.parse("2016-03-03"),
-           timestamp: Time.parse('2015-01-03 12:33'),
+           timestamp: Time.parse("2015-01-03 12:33"),
            flag:      nil,
            price:     BigDecimal("3.46") }
 
     d
   end
 
-  def fill_data(ifce)
-    data.each{|r| ifce.create(r) }
-  end
-
-  def fill_product_data(ifce)
-    ifce.create( {code: "foo", name: "bar"} )
-  end
-
-
   # This is stolen almost verbatim from the Sequel Readme. We use an in-memory
   # sqlite database, and we assume that Sequel is sane and behaves broadly the
   # same for our limited purposes as it would when talking to TinyTDS or Pg.
@@ -110,15 +111,13 @@ describe "SequelInterface" do
   let(:interface)      { sequel_interface_class.new(db) }
   let(:prod_interface) { prod_interface_class.new(db) }
 
-  before do
+  before(:each) do
     fill_data(interface)
   end
 
-  ##
 
 
-  it_behaves_like 'an interface' do
-
+  it_behaves_like "an interface" do
     let(:interface) do
       db2 = Sequel.sqlite
       db2.create_table :customer do
@@ -134,109 +133,113 @@ describe "SequelInterface" do
       sequel_interface_class.new(db2)
     end
 
-    let(:record)    { {name: 'Barney', price: 1.11} }
+    let(:record) { {name: "Barney", price: 1.11} }
   end
-  ##
 
 
-  describe 'SequelInterface.set_schema' do
-    it 'takes one argument' do
+  describe "SequelInterface.set_schema" do
+
+    it "takes one argument" do
       expect( sequel_interface_class ).to respond_to(:set_schema).with(1).argument
     end
+
   end
-  ##
 
 
-  describe 'SequelInterface.schema' do
-    it 'returns the schema' do
+  describe "SequelInterface.schema" do
+
+    it "returns the schema" do
       expect( schema_interface_class.schema ).to eq :public
     end
 
-    it 'is optional' do
+    it "is optional" do
       expect{ sequel_interface_class.schema }.not_to raise_exception
       expect( sequel_interface_class.schema ).to eq nil
     end
+
   end
-  ##
 
 
-  describe 'SequelInterface.set_table' do
-    it 'takes one argument' do
+  describe "SequelInterface.set_table" do
+
+    it "takes one argument" do
       expect( sequel_interface_class ).to respond_to(:set_table).with(1).argument
     end
+
   end
-  ##
 
 
-  describe 'SequelInterface.table' do
-    it 'returns the table' do
+  describe "SequelInterface.table" do
+
+    it "returns the table" do
       expect( sequel_interface_class.table ).to eq :customer
     end
+
   end
-  ##
 
 
-  describe 'SequelInterface.set_id_fld' do
-    it 'takes one argument' do
+  describe "SequelInterface.set_id_fld" do
+
+    it "takes one argument" do
       expect( sequel_interface_class ).to respond_to(:set_id_fld).with(1).argument
     end
+
+    it "takes an optional second 'autoincrement' argument" do
+      expect{ prod_interface_class.set_id_fld(:foo, autoincrement: false) }.not_to raise_error
+    end
+
   end
-  ##
 
 
-  describe 'SequelInterface.id_fld' do
-    it 'returns the ID field name' do
+  describe "SequelInterface.id_fld" do
+
+    it "returns the ID field name" do
       expect( sequel_interface_class.id_fld ).to eq :id
     end
-  end
-  ##
-
 
-  describe '#new' do
+  end
 
-    it 'requires a Sequel DB object' do
-      expect{ sequel_interface_class.new        }.to raise_exception ArgumentError
-      expect{ sequel_interface_class.new(nil)   }.to raise_exception ArgumentError
-      expect{ sequel_interface_class.new('foo') }.to raise_exception ArgumentError
 
-      expect{ sequel_interface_class.new(db) }.not_to raise_exception
-    end
+  describe "#new" do
+    # See also common/sequel_interface_pg_spec
 
-    it 'requires the table and id field to be defined in the class' do
+    it "requires the table and id field to be defined in the class" do
       expect{ SequelInterface.new(db) }.to raise_exception Pod4Error
       expect{ bad_interface_class1.new(db)   }.to raise_exception Pod4Error
       expect{ bad_interface_class2.new(db)   }.to raise_exception Pod4Error
     end
 
-  end
-  ##
+  end # of #new
 
 
-  describe '#quoted_table' do
+  describe "#quoted_table" do
 
-    it 'returns just the table when the schema is not set' do
+    it "returns just the table when the schema is not set" do
       expect( interface.quoted_table ).to eq( %Q|`customer`| )
     end
 
-    it 'returns the schema plus table when the schema is set' do
+    it "returns the schema plus table when the schema is set" do
       ifce = schema_interface_class.new(db)
       expect( ifce.quoted_table ).to eq( %|`public`.`customer`| )
     end
 
-  end
-  ##
+  end # of #quoted_table
 
 
-  describe '#create' do
+  describe "#create" do
+    let(:hash) { {name: "Bam-Bam", price: 4.44} }
+    let(:ot)   { Octothorpe.new(name: "Wilma", price: 5.55) }
 
-    let(:hash) { {name: 'Bam-Bam', price: 4.44} }
-    let(:ot)   { Octothorpe.new(name: 'Wilma', price: 5.55) }
+    it "raises a Pod4::DatabaseError if anything goes wrong" do
+      expect{ interface.create(one: "two") }.to raise_exception DatabaseError
+    end
 
-    it 'raises a Pod4::DatabaseError if anything goes wrong' do
-      expect{ interface.create(one: 'two') }.to raise_exception DatabaseError
+    it "raises an ArgumentError if ID field is missing in hash and not AI" do
+      hash = {name: "bar"}
+      expect{ prod_interface.create(Octothorpe.new hash) }.to raise_error ArgumentError
     end
 
-    it 'creates the record when given a hash' do
+    it "creates the record when given a hash" do
       # kinda impossible to seperate these two tests
       id = interface.create(hash)
 
@@ -245,7 +248,7 @@ describe "SequelInterface" do
       expect( interface.read(id).to_h ).to include hash
     end
 
-    it 'creates the record when given an Octothorpe' do
+    it "creates the record when given an Octothorpe" do
       id = interface.create(ot)
 
       expect( id ).not_to be_nil
@@ -253,26 +256,26 @@ describe "SequelInterface" do
       expect( interface.read(id).to_h ).to include ot.to_h
     end
 
-    it 'does not freak out if the hash has symbol values' do
+    it "does not freak out if the hash has symbol values" do
       # Which, Sequel does
       expect{ interface.create(name: :Booboo) }.not_to raise_exception
     end
 
-    it 'shouldn\'t have a problem with record values of nil' do
-      record = {name: 'Ranger', price: nil}
+    it "has no problem with record values of nil" do
+      record = {name: "Ranger", price: nil}
       expect{ interface.create(record) }.not_to raise_exception
       id = interface.create(record)
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldn\'t have a problem with strings containing special characters' do
+    it "has no problem with strings containing special characters" do
       record = {name: "T'Challa[]", price: nil}
       expect{ interface.create(record) }.not_to raise_exception
       id = interface.create(record)
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       hash = {code: "foo", name: "bar"}
       id = prod_interface.create( Octothorpe.new(hash) )
 
@@ -281,56 +284,65 @@ describe "SequelInterface" do
       expect( prod_interface.read("foo").to_h ).to include hash
     end
 
-  end
-  ##
+    it "copes with an OT with the ID field in it when the ID field autoincrements" do
+      h = {id: nil, name: "Bam-Bam", price: 4.44}
+      expect{ interface.create(h) }.not_to raise_error
+
+      id = interface.create(h)
+      expect( id ).not_to be_nil
+      expect{ interface.read(id) }.not_to raise_exception
+      expect( interface.read(id).to_h ).to include( {name: "Bam-Bam", price: 4.44} )
+    end
 
+  end # of #create
 
-  describe '#read' do
 
-    it 'returns the record for the id as an Octothorpe' do
-      expect( interface.read(2).to_h ).to include(name: 'Fred', price: 2.35)
+  describe "#read" do
+
+    it "returns the record for the id as an Octothorpe" do
+      expect( interface.read(2).to_h ).to include(name: "Fred", price: 2.35)
     end
 
-    it 'raises a Pod4::CantContinue if the ID is bad' do
+    it "raises a Pod4::CantContinue if the ID is bad" do
       expect{ interface.read(:foo) }.to raise_exception CantContinue
     end
 
-    it 'returns an empty Octothorpe if no record matches the ID' do
+    it "returns an empty Octothorpe if no record matches the ID" do
       expect{ interface.read(99) }.not_to raise_exception
       expect( interface.read(99) ).to be_a_kind_of Octothorpe
       expect( interface.read(99) ).to be_empty
     end
 
-    it 'returns real fields as Float' do
+    it "returns real fields as Float" do
       level = interface.read(1).>>.level
 
       expect( level ).to be_a_kind_of Float
       expect( level ).to be_within(0.001).of( data.first[:level] )
     end
 
-    it 'returns date fields as Date' do
+    it "returns date fields as Date" do
       date = interface.read(1).>>.day
 
       expect( date ).to be_a_kind_of Date
       expect( date ).to eq data.first[:day]
     end
 
-    it 'returns datetime fields as Time' do
+    it "returns datetime fields as Time" do
       timestamp = interface.read(1).>>.timestamp
 
       expect( timestamp ).to be_a_kind_of Time
       expect( timestamp ).to eq data.first[:timestamp]
     end
 
-    it 'returns numeric fields as BigDecimal' do
+    it "returns numeric fields as BigDecimal" do
       price = interface.read(1).>>.price
 
       expect( price ).to be_a_kind_of BigDecimal
       expect( price ).to eq data.first[:price]
     end
 
-    # Not sure how this passes since SQLite doesn't have a boolean class, but, Sequel handles it.
-    it 'returns boolean fields as boolean' do
+    # Not sure how this passes since SQLite doesn"t have a boolean class, but, Sequel handles it.
+    it "returns boolean fields as boolean" do
       [1,2,3].each do |i|
         flag = interface.read(i).>>.flag
         expect( [true, false, nil].include? flag ).to be true
@@ -338,7 +350,7 @@ describe "SequelInterface" do
       end
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       # this is a 100% overlap with the create test above...
       fill_product_data(prod_interface)
 
@@ -346,19 +358,17 @@ describe "SequelInterface" do
       expect( prod_interface.read("foo").to_h ).to include(code: "foo", name: "bar")
     end
 
-  end
-  ##
-
+  end # of #read
 
 
-  describe '#list' do
+  describe "#list" do
 
-    it 'has an optional selection parameter, a hash' do
+    it "has an optional selection parameter, a hash" do
       # Actually it does not have to be a hash, but FTTB we only support that.
-      expect{ interface.list(name: 'Barney') }.not_to raise_exception
+      expect{ interface.list(name: "Barney") }.not_to raise_exception
     end
 
-    it 'returns an array of Octothorpes that match the records' do
+    it "returns an array of Octothorpes that match the records" do
       arr = interface.list.map {|ot| x = ot.to_h}
 
       expect( arr.size ).to eq(data.size)
@@ -371,47 +381,42 @@ describe "SequelInterface" do
         expect( r[:timestamp] ).to eq d[:timestamp]
         expect( r[:qty]       ).to eq d[:qty]
       end
-
     end
 
+    it "returns a subset of records based on the selection parameter" do
+      expect( interface.list(name: "Fred").size ).to eq 1
 
-    it 'returns a subset of records based on the selection parameter' do
-      expect( interface.list(name: 'Fred').size ).to eq 1
-
-      expect( interface.list(name: 'Betty').first.to_h ).
-        to include(name: 'Betty', price: 3.46)
+      expect( interface.list(name: "Betty").first.to_h ).
+        to include(name: "Betty", price: 3.46)
 
     end
 
-    it 'returns an empty Array if nothing matches' do
-      expect( interface.list(name: 'Yogi') ).to eq([])
+    it "returns an empty Array if nothing matches" do
+      expect( interface.list(name: "Yogi") ).to eq([])
     end
 
-    it 'raises DatabaseError if the selection criteria is nonsensical' do
-      expect{ interface.list('foo') }.to raise_exception Pod4::DatabaseError
+    it "raises DatabaseError if the selection criteria is nonsensical" do
+      expect{ interface.list("foo") }.to raise_exception Pod4::DatabaseError
     end
 
-    it 'returns an empty array if there is no data' do
+    it "returns an empty array if there is no data" do
       interface.list.each {|x| interface.delete(x[interface.id_fld]) }
       expect( interface.list ).to eq([])
     end
 
-    it 'does not freak out if the hash has symbol values' do
+    it "does not freak out if the hash has symbol values" do
       # Which, Sequel does
       expect{ interface.list(name: :Barney) }.not_to raise_exception
     end
 
-
-  end
-  ##
+  end # of #list
   
 
-  describe '#update' do
-
+  describe "#update" do
     let(:id) { interface.list.first[:id] }
 
-    it 'updates the record at ID with record parameter' do
-      record = {name: 'Booboo', price: 99.99}
+    it "updates the record at ID with record parameter" do
+      record = {name: "Booboo", price: 99.99}
       interface.update(id, record)
 
       booboo = interface.read(id)
@@ -419,203 +424,195 @@ describe "SequelInterface" do
       expect( booboo.>>.price.to_f ).to eq( record[:price] )
     end
 
-    it 'raises a CantContinue if anything weird happens with the ID' do
-      expect{ interface.update(99, name: 'Booboo') }.
+    it "raises a CantContinue if anything weird happens with the ID" do
+      expect{ interface.update(99, name: "Booboo") }.
         to raise_exception CantContinue
 
     end
 
-    it 'raises a DatabaseError if anything weird happensi with the record' do
-      expect{ interface.update(id, smarts: 'more') }.
+    it "raises a DatabaseError if anything weird happens with the record" do
+      expect{ interface.update(id, smarts: "more") }.
         to raise_exception DatabaseError
 
     end
 
-    it 'does not freak out if the hash has symbol values' do
+    it "does not freak out if the hash has symbol values" do
       # Which, Sequel does
       expect{ interface.update(id, name: :Booboo) }.not_to raise_exception
     end
 
-    it 'shouldnt have a problem with record values of nil' do
-      record = {name: 'Ranger', price: nil}
+    it "has no problem with record values of nil" do
+      record = {name: "Ranger", price: nil}
       expect{ interface.update(id, record) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldnt have a problem with strings containing special characters' do
+    it "has no problem with strings containing special characters" do
       record = {name: "T'Challa[]", price: nil}
       expect{ interface.update(id, record) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       fill_product_data(prod_interface)
       expect{ prod_interface.update("foo", name: "baz") }.not_to raise_error
       expect( prod_interface.read("foo").to_h[:name] ).to eq "baz"
     end
 
-  end
-  ##
-
+  end # of #update
 
-  describe '#delete' do
 
-    def list_contains(ifce, id)
-      ifce.list.find {|x| x[ifce.id_fld] == id }
-    end
+  describe "#delete" do
 
     let(:id) { interface.list.first[:id] }
 
-    it 'raises CantContinue if anything hinky happens with the ID' do
+    it "raises CantContinue if anything hinky happens with the ID" do
       expect{ interface.delete(:foo) }.to raise_exception CantContinue
       expect{ interface.delete(99)   }.to raise_exception CantContinue
     end
 
-    it 'makes the record at ID go away' do
+    it "makes the record at ID go away" do
       expect( list_contains(interface, id) ).to be_truthy
       interface.delete(id)
       expect( list_contains(interface, id) ).to be_falsy
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       fill_product_data(prod_interface)
       expect( list_contains(prod_interface, "foo") ).to be_truthy
       prod_interface.delete("foo")
       expect( list_contains(prod_interface, "foo") ).to be_falsy
     end
 
-  end
-  ##
+  end # of #delete
 
 
-  describe '#execute' do
+  describe "#execute" do
 
-    let(:sql) { 'delete from customer where price < 2.0;' }
+    let(:sql) { "delete from customer where price < 2.0;" }
 
-    it 'requires an SQL string' do
+    it "requires an SQL string" do
       expect{ interface.execute      }.to raise_exception ArgumentError
       expect{ interface.execute(nil) }.to raise_exception ArgumentError
       expect{ interface.execute(14)  }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.execute('delete from not_a_table') }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.execute("delete from not_a_table") }.
         to raise_exception Pod4Error
 
     end
 
-    it 'executes the string' do
+    it "executes the string" do
       expect{ interface.execute(sql) }.not_to raise_exception
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
     end
 
-  end
-  ##
+  end # of #execute
 
 
-  describe '#select' do
+  describe "#select" do
 
-    it 'requires an SQL string' do
+    it "requires an SQL string" do
       expect{ interface.select      }.to raise_exception ArgumentError
       expect{ interface.select(nil) }.to raise_exception ArgumentError
       expect{ interface.select(14)  }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.select('select * from not_a_table') }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.select("select * from not_a_table") }.
         to raise_exception Pod4Error
 
     end
 
-    it 'returns the result of the sql' do
-      sql1 = 'select name from customer where price < 2.0;'
-      sql2 = 'select name from customer where price < 0.0;'
+    it "returns the result of the sql" do
+      sql1 = "select name from customer where price < 2.0;"
+      sql2 = "select name from customer where price < 0.0;"
 
       expect{ interface.select(sql1) }.not_to raise_exception
-      expect( interface.select(sql1) ).to eq( [{name: 'Barney'}] )
+      expect( interface.select(sql1) ).to eq( [{name: "Barney"}] )
       expect( interface.select(sql2) ).to eq( [] )
     end
 
-    it 'works if you pass a non-select' do
+    it "works if you pass a non-select" do
       # By which I mean: still executes the SQL; returns []
-      sql = 'delete from customer where price < 2.0;'
+      sql = "delete from customer where price < 2.0;"
       ret = interface.select(sql)
 
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
       expect( ret ).to eq( [] )
     end
 
-  end
-  ##
+  end # of #select
 
 
   describe "#executep" do
     # For the time being lets assume that Sequel does its job and the three modes we are calling
     # actually work
 
-    let(:sql) { 'delete from customer where price < ?;' }
+    let(:sql) { "delete from customer where price < ?;" }
 
-    it 'requires an SQL string and a mode' do
+    it "requires an SQL string and a mode" do
       expect{ interface.executep                 }.to raise_exception ArgumentError
       expect{ interface.executep(nil)            }.to raise_exception ArgumentError
       expect{ interface.executep(14, :update)    }.to raise_exception ArgumentError
       expect{ interface.executep(14, :update, 2) }.to raise_exception ArgumentError
     end
 
-    it 'requires the mode to be valid' do
+    it "requires the mode to be valid" do
       expect{ interface.executep(sql, :foo, 2) }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.executep('delete from not_a_table where thingy = ?', :delete, 14) }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.executep("delete from not_a_table where thingy = ?", :delete, 14) }.
         to raise_exception Pod4Error
 
     end
 
-    it 'executes the string' do
+    it "executes the string" do
       expect{ interface.executep(sql, :delete, 2.0) }.not_to raise_exception
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
     end
 
-  end
+  end # of #executep
 
 
   describe "#selectp" do
 
-    it 'requires an SQL string' do
+    it "requires an SQL string" do
       expect{ interface.selectp      }.to raise_exception ArgumentError
       expect{ interface.selectp(nil) }.to raise_exception ArgumentError
       expect{ interface.selectp(14)  }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.selectp('select * from not_a_table where thingy = ?', 14) }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.selectp("select * from not_a_table where thingy = ?", 14) }.
         to raise_exception Pod4Error
 
     end
 
-    it 'returns the result of the sql' do
-      sql = 'select name from customer where price < ?;'
+    it "returns the result of the sql" do
+      sql = "select name from customer where price < ?;"
 
       expect{ interface.selectp(sql, 2.0) }.not_to raise_exception
-      expect( interface.selectp(sql, 2.0) ).to eq( [{name: 'Barney'}] )
+      expect( interface.selectp(sql, 2.0) ).to eq( [{name: "Barney"}] )
       expect( interface.selectp(sql, 0.0) ).to eq( [] )
     end
 
-    it 'works if you pass a non-select' do
+    it "works if you pass a non-select" do
       # By which I mean: still executes the SQL; returns []
-      sql = 'delete from customer where price < ?;'
+      sql = "delete from customer where price < ?;"
       ret = interface.selectp(sql, 2.0)
 
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
       expect( ret ).to eq( [] )
     end
 
-  end
+  end # of #selectp
 
 
 end