pod4 0.10.6 → 1.0.0

data/spec/common/null_interface_spec.rb

@@ -1,152 +1,175 @@
-require 'pod4/null_interface'
+require "pod4/null_interface"
 
-require_relative 'shared_examples_for_interface'
+require_relative "shared_examples_for_interface"
 
 
 describe NullInterface do
 
+  def list_contains(id)
+    interface.list.find {|x| x[interface.id_fld] == id }
+  end
+
+  # An autoincrementing interface
   let(:data) do
-    [ {name: 'Barney', price: 1.11},
-      {name: 'Fred',   price: 2.22},
-      {name: 'Betty',  price: 3.33} ]
+    [ {id: 1, name: "Barney", price: 1.11},
+      {id: 2, name: "Fred",   price: 2.22},
+      {id: 3, name: "Betty",  price: 3.33} ]
   end
+  let (:interface) { NullInterface.new(:id, :name, :price, data) }
 
-  let (:interface) { NullInterface.new(:name, :price, data) }
+  # A non-autoincrementing interface
+  let(:data2) do
+    [ {code: "foo", level: 1},
+      {code: "bar", level: 2},
+      {code: "baz", level: 3} ]
+  end
 
-  ##
+  let (:interface2) do
+    i = NullInterface.new(:code, :level, data2)
+    i.id_ai = false
+    i
+  end
 
 
   it_behaves_like "an interface" do
-    let(:record)    { {name: 'barney', price:1.11} }
-    let(:interface) { NullInterface.new( :name, :price, [record] ) }
+    let(:record)    { {name: "barney", price:1.11} }
+    let(:interface) { NullInterface.new( :id, :name, :price, [record]) }
   end
 
 
-  describe '#new' do
+  describe "#new" do
 
-    it 'requires a list of columns and an array of hashes' do
+    it "requires a list of columns and an array of hashes" do
       expect{ NullInterface.new        }.to raise_exception ArgumentError
       expect{ NullInterface.new(nil)   }.to raise_exception ArgumentError
-      expect{ NullInterface.new('foo') }.to raise_exception ArgumentError
+      expect{ NullInterface.new("foo") }.to raise_exception ArgumentError
 
       expect{ NullInterface.new(:one, [{one:1}]) }.not_to raise_exception
     end
 
-  end
-  ##
+    it "defaults autoincrement to true" do
+      expect( interface.id_ai ).to eq true
+    end
 
+    it "allows you to set autoincrement to false" do
+      ni = NullInterface.new(:one, [{one:1}])
+      ni.id_ai = false
+      expect( ni.id_ai ).to eq false
+    end
 
-  describe '#create' do
+  end # of #new
 
-    let(:hash) { {name: 'Bam-Bam', price: 4.44} }
-    let(:ot)   { Octothorpe.new(name: 'Wilma', price: 5.55) }
 
-    it 'creates the record when given a hash' do
+  describe "#create" do
+
+    let(:hash) { {name: "Bam-Bam", price: 4.44} }
+    let(:ot)   { Octothorpe.new(name: "Wilma", price: 5.55) }
+
+    it "creates the record when given a hash" do
       id = interface.create(hash)
 
       expect{ interface.read(id) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include hash
     end
 
-    it 'creates the record when given an Octothorpe' do
+    it "creates the record when given an Octothorpe" do
       id = interface.create(ot)
 
       expect{ interface.read(id) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include ot.to_h
     end
 
-  end
-  ##
+    it "raises an ArgumentError when the key is not AI and the record is missing the key" do
+      expect{ interface2.create(level: 55) }.to raise_error ArgumentError
+    end
 
+    it "sets the ID field to the correct integer when autoincrement is true" do
+      count = interface.list.size
+      id = interface.create(ot)
+      expect( id ).to eq(count + 1)
+    end
+
+    it "sets the ID field to whatever you set in the record when autoincrement is false" do
+      id = interface2.create Octothorpe.new(code: "flong", level: 9)
+      expect( id ).to eq "flong"
+    end
+
+  end # of #create
 
-  describe '#read' do
 
-    it 'returns the record for the id as an Octothorpe' do
-      expect( interface.read('Barney')      ).to be_a_kind_of Octothorpe
-      expect( interface.read('Fred').to_h ).
-        to include(name: 'Fred', price: 2.22)
+  describe "#read" do
 
+    it "returns the record for the id as an Octothorpe" do
+      expect( interface.read(1)      ).to be_a_kind_of Octothorpe
+      expect( interface.read(2).to_h ).to include(name: "Fred", price: 2.22)
     end
 
-    it 'returns an empty Octothorpe if no record matches the ID' do
+    it "returns an empty Octothorpe if no record matches the ID" do
       expect{ interface.read(:foo) }.not_to raise_exception
       expect( interface.read(:foo) ).to be_a_kind_of Octothorpe
       expect( interface.read(:foo) ).to be_empty
     end
 
-  end
-  ##
+  end # of #read
 
 
-  describe '#list' do
+  describe "#list" do
 
-    it 'has an optional selection parameter, a hash' do
+    it "has an optional selection parameter, a hash" do
       expect{ interface.list }.not_to raise_exception
-      expect{ interface.list(name: 'Barney') }.not_to raise_exception
+      expect{ interface.list(name: "Barney") }.not_to raise_exception
     end
 
-    it 'returns an array of Octothorpes that match the records' do
+    it "returns an array of Octothorpes that match the records" do
       arr = interface.list.map(&:to_h)
       expect( arr ).to match_array data
     end
 
-    it 'returns a subset of records based on the selection parameter' do
-      expect( interface.list(name: 'Fred').size ).to eq 1
+    it "returns a subset of records based on the selection parameter" do
+      expect( interface.list(name: "Fred").size ).to eq 1
 
-      expect( interface.list(name: 'Betty').first.to_h ).
-        to include(name: 'Betty', price: 3.33)
+      expect( interface.list(name: "Betty").first.to_h ).
+        to include(name: "Betty", price: 3.33)
 
     end
 
-    it 'returns an empty Array if nothing matches' do
-      expect( interface.list(name: 'Yogi') ).to eq([])
+    it "returns an empty Array if nothing matches" do
+      expect( interface.list(name: "Yogi") ).to eq([])
     end
 
-    it 'returns an empty array if there is no data' do
+    it "returns an empty array if there is no data" do
       interface.list.each {|x| interface.delete(x[interface.id_fld]) }
       expect( interface.list ).to eq([])
     end
 
-  end
-  ##
+  end # of #list
   
 
-  describe '#update' do
-
-    let(:id) { interface.list.first[:name] }
+  describe "#update" do
 
-    it 'updates the record at ID with record parameter' do
+    it "updates the record at ID with record parameter" do
       record = {price: 99.99}
-      interface.update(id, record)
+      interface.update(1, record)
 
-      expect( interface.read(id).to_h ).to include(record)
+      expect( interface.read(1).to_h ).to include(record)
     end
 
-  end
-  ##
-
-
-  describe '#delete' do
-  
-    def list_contains(id)
-      interface.list.find {|x| x[interface.id_fld] == id }
-    end
+  end # of #update
 
-    let(:id) { interface.list.first[:name] }
 
-    it 'raises CantContinue if anything hinky happens with the ID' do
+  describe "#delete" do
+    it "raises CantContinue if anything hinky happens with the ID" do
       expect{ interface.delete(:foo) }.to raise_exception CantContinue
       expect{ interface.delete(99)   }.to raise_exception CantContinue
     end
 
-    it 'makes the record at ID go away' do
-      expect( list_contains(id) ).to be_truthy
-      interface.delete(id)
-      expect( list_contains(id) ).to be_falsy
+    it "makes the record at ID go away" do
+      expect( list_contains(1) ).to be_truthy
+      interface.delete(1)
+      expect( list_contains(1) ).to be_falsy
     end
 
-  end
-  ##
+  end # of #delete
 
 
 end

data/spec/common/sequel_interface_pg_spec.rb

@@ -2,16 +2,48 @@
 # Supplemental test for Sequel -- tests using PG gem in MRI, jeremyevans-postgres-pg under jruby?
 #
 
-require 'pod4/sequel_interface'
+require "pod4/sequel_interface"
 
-require 'sequel'
-require 'date'
-require 'time'
-require 'bigdecimal'
+require "sequel"
+require "date"
+require "time"
+require "bigdecimal"
 
 
 describe "SequelInterface (Pg)" do
 
+  def fill_data(ifce, data)
+    data.each{|r| ifce.create(r) }
+  end
+
+  def fill_product_data(ifce)
+    ifce.create( {code: "foo", name: "bar"} )
+  end
+
+  def list_contains(ifce, id)
+    ifce.list.find {|x| x[ifce.id_fld] == id }
+  end
+
+  def db_setup(db)
+    db.run %Q|
+      drop table if exists customer;
+      drop table if exists product;
+
+      create table customer (
+        id        serial primary key,
+        name      text,
+        level     real      null,
+        day       date      null,
+        timestamp timestamp null,
+        price     money     null,
+        qty       numeric   null );
+    
+      create table product (
+        code text,
+        name text );|
+
+  end
+
   let(:sequel_interface_class) do
     Class.new SequelInterface do
       set_table :customer
@@ -30,115 +62,139 @@ describe "SequelInterface (Pg)" do
   let(:prod_interface_class) do
     Class.new SequelInterface do
       set_table  :product
-      set_id_fld :code
+      set_id_fld :code, autoincrement: false
     end
   end
 
-
   let(:data) do
     d = []
-    d << { name:      'Barney',
+    d << { name:      "Barney",
            level:     1.23,
            day:       Date.parse("2016-01-01"),
-           timestamp: Time.parse('2015-01-01 12:11'),
+           timestamp: Time.parse("2015-01-01 12:11"),
            qty:       BigDecimal("1.24"),
            price:     BigDecimal("1.24") }
 
-    d << { name:      'Fred',
+    d << { name:      "Fred",
            level:     2.34,
            day:       Date.parse("2016-02-02"),
-           timestamp: Time.parse('2015-01-02 12:22'),
+           timestamp: Time.parse("2015-01-02 12:22"),
            qty:       BigDecimal("2.35"),
            price:     BigDecimal("2.35") }
 
-    d << { name:      'Betty',
+    d << { name:      "Betty",
            level:     3.45,
            day:       Date.parse("2016-03-03"),
-           timestamp: Time.parse('2015-01-03 12:33'),
+           timestamp: Time.parse("2015-01-03 12:33"),
            qty:       BigDecimal("3.46"),
            price:     BigDecimal("3.46") }
 
     d
   end
 
-  def fill_data(ifce)
-    data.each{|r| ifce.create(r) }
-  end
-
-  def fill_product_data(ifce)
-    ifce.create( {code: "foo", name: "bar"} )
-  end
-
-
-  let (:db) do
-    db = Sequel.connect('postgres://pod4test:pod4test@centos7andy/pod4_test?search_path=public')
-
-    db.run %Q|
-      drop table if exists customer;
-      drop table if exists product;
-
-      create table customer (
-        id        serial primary key,
-        name      text,
-        level     real      null,
-        day       date      null,
-        timestamp timestamp null,
-        price     money     null,
-        qty       numeric   null );
-    
-      create table product (
-        code text,
-        name text );|
+  let(:db_url) { "postgres://pod4test:pod4test@centos7andy/pod4_test?search_path=public" }
 
+  let(:db) do
+    db = Sequel.connect(db_url)
+    db_setup(db)
     db
   end
 
   let(:interface)      { sequel_interface_class.new(db) }
   let(:prod_interface) { prod_interface_class.new(db) }
 
-
-
   before do
     interface.execute %Q|
       truncate table customer restart identity;
       truncate table product;|
 
-    fill_data(interface)
+    fill_data(interface, data)
   end
 
   after do
     db.disconnect
   end
 
-  ##
 
+  describe "#new" do
+     
+    context "when passed a Sequel DB object" do
+      let(:ifce) { sequel_interface_class.new(Sequel.connect db_url) }
+
+      it "uses it to create a connection" do
+        expect( ifce._connection ).to be_a Connection
+        expect( ifce._connection.interface_class ).to eq sequel_interface_class
+      end
+      
+      it "calls Connection#client on first use" do
+        expect( ifce._connection ).to receive(:client).with(ifce).and_call_original
+        ifce.list
+      end
+    end
+
+    context "when passed a String" do
+      let(:ifce) { sequel_interface_class.new(db_url) }
+
+      it "uses it to create a connection" do
+        expect( ifce._connection ).to be_a Connection
+        expect( ifce._connection.interface_class ).to eq sequel_interface_class
+      end
+      
+      # Normally we'd expect on _every_ use, but Sequel is different
+      it "calls Connection#client on first use" do
+        expect( ifce._connection ).to receive(:client).with(ifce).and_call_original
+        ifce.list
+      end
+    end
+
+    context "when passed a Connection object" do
+      let(:conn) { Connection.new(interface: sequel_interface_class) }
+      let(:ifce) { sequel_interface_class.new(conn) }
+
+      it "uses that as its connection object" do
+        expect( ifce._connection ).to be_a Connection
+        expect( ifce._connection ).to eq conn
+        expect( ifce._connection.interface_class ).to eq sequel_interface_class
+      end
+    
+      # Normally we'd expect on _every_ use, but Sequel is different
+      it "calls Connection#client on first use" do
+        # When we pass a connection object we are expected to set the data layer option
+        conn.data_layer_options = Sequel.connect(db_url)
 
-  describe '#quoted_table' do
+        expect( ifce._connection ).to receive(:client).with(ifce).and_call_original
 
-    it 'returns just the table when the schema is not set' do
+        ifce.list
+      end
+    end
+    
+  end # of #new
+
+  describe "#quoted_table" do
+
+    it "returns just the table when the schema is not set" do
       expect( interface.quoted_table.downcase ).to eq( %Q|"customer"| )
     end
 
-    it 'returns the schema plus table when the schema is set' do
+    it "returns the schema plus table when the schema is set" do
       ifce = schema_interface_class.new(db)
       expect( ifce.quoted_table.downcase ).to eq( %|"public"."customer"| )
     end
 
-  end
-  ##
+  end # of #quoted_table
 
 
-  describe '#create' do
+  describe "#create" do
 
-    let(:hash) { {name: 'Bam-Bam', qty: 4.44} }
-    let(:ot)   { Octothorpe.new(name: 'Wilma', qty: 5.55) }
+    let(:hash) { {name: "Bam-Bam", qty: 4.44} }
+    let(:ot)   { Octothorpe.new(name: "Wilma", qty: 5.55) }
 
 
-    it 'raises a Pod4::DatabaseError if anything goes wrong' do
-      expect{ interface.create(one: 'two') }.to raise_exception DatabaseError
+    it "raises a Pod4::DatabaseError if anything goes wrong" do
+      expect{ interface.create(one: "two") }.to raise_exception DatabaseError
     end
 
-    it 'creates the record when given a hash' do
+    it "creates the record when given a hash" do
       # kinda impossible to seperate these two tests
       id = interface.create(hash)
 
@@ -147,26 +203,26 @@ describe "SequelInterface (Pg)" do
       expect( interface.read(id).to_h ).to include hash
     end
 
-    it 'creates the record when given an Octothorpe' do
+    it "creates the record when given an Octothorpe" do
       id = interface.create(ot)
 
       expect{ interface.read(id) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include ot.to_h
     end
 
-    it 'does not freak out if the hash has symbol values' do
+    it "does not freak out if the hash has symbol values" do
       # Which, Sequel does
       expect{ interface.create(name: :Booboo) }.not_to raise_exception
     end
 
-    it 'shouldnt have a problem with record values of nil' do
-      record = {name: 'Ranger', price: nil}
+    it "has no problem with record values of nil" do
+      record = {name: "Ranger", price: nil}
       expect{ interface.create(record) }.not_to raise_exception
       id = interface.create(record)
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldnt have a problem with strings containing special characters' do
+    it "has no problem with strings containing special characters" do
       # Note that in passing we retest that create returns the ID for identity columns
       
       record = {name: "T'Challa[]", price: nil}
@@ -175,7 +231,7 @@ describe "SequelInterface (Pg)" do
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       # Note that in passing we retest that create returns the ID for non-identity columns
 
       hash = {code: "foo", name: "bar"}
@@ -186,55 +242,64 @@ describe "SequelInterface (Pg)" do
       expect( prod_interface.read("foo").to_h ).to include hash
     end
 
-  end
-  ##
+    it "copes with an OT with the ID field in it when the ID field autoincrements" do
+      h = {id: nil, name: "Bam-Bam", qty: 4.44}
+      expect{ interface.create(h) }.not_to raise_error
 
+      id = interface.create(h)
+      expect( id ).not_to be_nil
+      expect{ interface.read(id) }.not_to raise_exception
+      expect( interface.read(id).to_h ).to include( {name: "Bam-Bam", qty: 4.44} )
+    end
 
-  describe '#read' do
+  end # of #create
 
-    it 'returns the record for the id as an Octothorpe' do
-      expect( interface.read(2).to_h ).to include(name: 'Fred', qty: 2.35)
+
+  describe "#read" do
+
+    it "returns the record for the id as an Octothorpe" do
+      expect( interface.read(2).to_h ).to include(name: "Fred", qty: 2.35)
     end
 
-    it 'raises a Pod4::CantContinue if the ID is bad' do
+    it "raises a Pod4::CantContinue if the ID is bad" do
       expect{ interface.read(:foo) }.to raise_exception CantContinue
     end
 
-    it 'returns an empty Octothorpe if no record matches the ID' do
+    it "returns an empty Octothorpe if no record matches the ID" do
       expect{ interface.read(99) }.not_to raise_exception
       expect( interface.read(99) ).to be_a_kind_of Octothorpe
       expect( interface.read(99) ).to be_empty
     end
 
-    it 'returns real fields as Float' do
+    it "returns real fields as Float" do
       level = interface.read(1).>>.level
 
       expect( level ).to be_a_kind_of Float
       expect( level ).to be_within(0.001).of( data.first[:level] )
     end
 
-    it 'returns date fields as Date' do
+    it "returns date fields as Date" do
       date = interface.read(1).>>.day
 
       expect( date ).to be_a_kind_of Date
       expect( date ).to eq data.first[:day]
     end
 
-    it 'returns datetime fields as Time' do
+    it "returns datetime fields as Time" do
       timestamp = interface.read(1).>>.timestamp
 
       expect( timestamp ).to be_a_kind_of Time
       expect( timestamp ).to eq data.first[:timestamp]
     end
 
-    it 'returns numeric fields as BigDecimal' do
+    it "returns numeric fields as BigDecimal" do
       qty = interface.read(1).>>.qty
 
       expect( qty ).to be_a_kind_of BigDecimal
       expect( qty ).to eq data.first[:qty]
     end
 
-    it 'returns money fields as bigdecimal' do
+    it "returns money fields as bigdecimal" do
       pending "Sequel/PG returns a string for Money type"
 
       price = interface.read(1).>>.price
@@ -243,7 +308,7 @@ describe "SequelInterface (Pg)" do
       expect( price ).to eq data.first[:price]
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       # this is a 100% overlap with the create test above...
       fill_product_data(prod_interface)
 
@@ -251,14 +316,12 @@ describe "SequelInterface (Pg)" do
       expect( prod_interface.read("foo").to_h ).to include(code: "foo", name: "bar")
     end
 
-  end
-  ##
-
-
+  end # of #read
+  
 
-  describe '#list' do
+  describe "#list" do
 
-    it 'returns an array of Octothorpes that match the records' do
+    it "returns an array of Octothorpes that match the records" do
       arr = interface.list.map {|ot| x = ot.to_h}
 
       expect( arr.size ).to eq(data.size)
@@ -274,43 +337,40 @@ describe "SequelInterface (Pg)" do
  
     end
 
-    it 'returns a subset of records based on the selection parameter' do
-      expect( interface.list(name: 'Fred').size ).to eq 1
+    it "returns a subset of records based on the selection parameter" do
+      expect( interface.list(name: "Fred").size ).to eq 1
 
-      expect( interface.list(name: 'Betty').first.to_h ).
-        to include(name: 'Betty', qty: 3.46)
+      expect( interface.list(name: "Betty").first.to_h ).
+        to include(name: "Betty", qty: 3.46)
 
     end
 
-    it 'returns an empty Array if nothing matches' do
-      expect( interface.list(name: 'Yogi') ).to eq([])
+    it "returns an empty Array if nothing matches" do
+      expect( interface.list(name: "Yogi") ).to eq([])
     end
 
-    it 'raises DatabaseError if the selection criteria is nonsensical' do
-      expect{ interface.list('foo') }.to raise_exception Pod4::DatabaseError
+    it "raises DatabaseError if the selection criteria is nonsensical" do
+      expect{ interface.list("foo") }.to raise_exception Pod4::DatabaseError
     end
 
-    it 'returns an empty array if there is no data' do
+    it "returns an empty array if there is no data" do
       interface.list.each {|x| interface.delete(x[interface.id_fld]) }
       expect( interface.list ).to eq([])
     end
 
-    it 'does not freak out if the hash has symbol values' do
+    it "doesn't freak out if the hash has symbol values" do
       # Which, Sequel does
       expect{ interface.list(name: :Barney) }.not_to raise_exception
     end
 
-
-  end
-  ##
+  end # of #list
   
 
-  describe '#update' do
-
+  describe "#update" do
     let(:id) { interface.list.first[:id] }
 
-    it 'updates the record at ID with record parameter' do
-      record = {name: 'Booboo', qty: 99.99}
+    it "updates the record at ID with record parameter" do
+      record = {name: "Booboo", qty: 99.99}
       interface.update(id, record)
 
       booboo = interface.read(id)
@@ -318,203 +378,199 @@ describe "SequelInterface (Pg)" do
       expect( booboo.>>.qty.to_f ).to eq( record[:qty] )
     end
 
-    it 'raises a CantContinue if anything weird happens with the ID' do
-      expect{ interface.update(99, name: 'Booboo') }.
+    it "raises a CantContinue if anything weird happens with the ID" do
+      expect{ interface.update(99, name: "Booboo") }.
         to raise_exception CantContinue
 
     end
 
-    it 'raises a DatabaseError if anything weird happensi with the record' do
-      expect{ interface.update(id, smarts: 'more') }.
+    it "raises a DatabaseError if anything weird happensi with the record" do
+      expect{ interface.update(id, smarts: "more") }.
         to raise_exception DatabaseError
 
     end
 
-    it 'does not freak out if the hash has symbol values' do
+    it "doesn't freak out if the hash has symbol values" do
       # Which, Sequel does
       expect{ interface.update(id, name: :Booboo) }.not_to raise_exception
     end
 
-    it 'shouldn\'t have a problem with record values of nil' do
-      record = {name: 'Ranger', qty: nil}
+    it "has no problem with record values of nil" do
+      record = {name: "Ranger", qty: nil}
       expect{ interface.update(id, record) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldn\'t have a problem with strings containing special characters' do
+    it "has no problem with strings containing special characters" do
       record = {name: "T'Challa[]", qty: nil}
       expect{ interface.update(id, record) }.not_to raise_exception
       expect( interface.read(id).to_h ).to include(record)
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       fill_product_data(prod_interface)
       expect{ prod_interface.update("foo", name: "baz") }.not_to raise_error
       expect( prod_interface.read("foo").to_h[:name] ).to eq "baz"
     end
 
-  end
-  ##
-
-
-  describe '#delete' do
+  end # of #update
 
-    def list_contains(ifce, id)
-      ifce.list.find {|x| x[ifce.id_fld] == id }
-    end
 
+  describe "#delete" do
     let(:id) { interface.list.first[:id] }
 
-    it 'raises CantContinue if anything hinky happens with the ID' do
+    it "raises CantContinue if anything hinky happens with the ID" do
       expect{ interface.delete(:foo) }.to raise_exception CantContinue
       expect{ interface.delete(99)   }.to raise_exception CantContinue
     end
 
-    it 'makes the record at ID go away' do
+    it "makes the record at ID go away" do
       expect( list_contains(interface, id) ).to be_truthy
       interface.delete(id)
       expect( list_contains(interface, id) ).to be_falsy
     end
 
-    it 'shouldn\'t have a problem with non-integer keys' do
+    it "has no problem with non-integer keys" do
       fill_product_data(prod_interface)
       expect( list_contains(prod_interface, "foo") ).to be_truthy
       prod_interface.delete("foo")
       expect( list_contains(prod_interface, "foo") ).to be_falsy
     end
 
-  end
-  ##
-
+  end # of #delete
 
-  describe '#execute' do
 
-    let(:sql) { 'delete from customer where qty < 2.0;' }
+  describe "#execute" do
+    let(:sql) { "delete from customer where qty < 2.0;" }
 
-    it 'requires an SQL string' do
+    it "requires an SQL string" do
       expect{ interface.execute      }.to raise_exception ArgumentError
       expect{ interface.execute(nil) }.to raise_exception ArgumentError
       expect{ interface.execute(14)  }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.execute('delete from not_a_table') }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.execute("delete from not_a_table") }.
         to raise_exception Pod4Error
 
     end
 
-    it 'executes the string' do
+    it "executes the string" do
       expect{ interface.execute(sql) }.not_to raise_exception
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
     end
 
-  end
-  ##
+  end # of #execute
 
 
-  describe '#select' do
+  describe "#select" do
 
-    it 'requires an SQL string' do
+    it "requires an SQL string" do
       expect{ interface.select      }.to raise_exception ArgumentError
       expect{ interface.select(nil) }.to raise_exception ArgumentError
       expect{ interface.select(14)  }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.select('select * from not_a_table') }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.select("select * from not_a_table") }.
         to raise_exception Pod4Error
 
     end
 
-    it 'returns the result of the sql' do
-      sql1 = 'select name from customer where qty < 2.0;'
-      sql2 = 'select name from customer where qty < 0.0;'
+    it "returns the result of the sql" do
+      sql1 = "select name from customer where qty < 2.0;"
+      sql2 = "select name from customer where qty < 0.0;"
 
       expect{ interface.select(sql1) }.not_to raise_exception
-      expect( interface.select(sql1) ).to eq( [{name: 'Barney'}] )
+      expect( interface.select(sql1) ).to eq( [{name: "Barney"}] )
       expect( interface.select(sql2) ).to eq( [] )
     end
 
-    it 'works if you pass a non-select' do
+    it "works if you pass a non-select" do
       # By which I mean: still executes the SQL; returns []
-      sql = 'delete from customer where qty < 2.0;'
+      sql = "delete from customer where qty < 2.0;"
       ret = interface.select(sql)
 
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
       expect( ret ).to eq( [] )
     end
 
-  end
-  ##
+  end # of #select
 
 
   describe "#executep" do
     # For the time being lets assume that Sequel does its job and the three modes we are calling
     # actually work
 
-    let(:sql) { 'delete from customer where qty < ?;' }
+    let(:sql) { "delete from customer where qty < ?;" }
 
-    it 'requires an SQL string and a mode' do
+    it "requires an SQL string and a mode" do
       expect{ interface.executep                 }.to raise_exception ArgumentError
       expect{ interface.executep(nil)            }.to raise_exception ArgumentError
       expect{ interface.executep(14, :update)    }.to raise_exception ArgumentError
       expect{ interface.executep(14, :update, 2) }.to raise_exception ArgumentError
     end
 
-    it 'requires the mode to be valid' do
+    it "requires the mode to be valid" do
       expect{ interface.executep(sql, :foo, 2) }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.executep('delete from not_a_table where thingy = ?', :delete, 14) }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.executep("delete from not_a_table where thingy = ?", :delete, 14) }.
         to raise_exception Pod4Error
 
     end
 
-    it 'executes the string' do
+    it "executes the string" do
       expect{ interface.executep(sql, :delete, 2.0) }.not_to raise_exception
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
     end
 
-  end
+  end # of #executep
 
 
   describe "#selectp" do
 
-    it 'requires an SQL string' do
+    it "requires an SQL string" do
       expect{ interface.selectp      }.to raise_exception ArgumentError
       expect{ interface.selectp(nil) }.to raise_exception ArgumentError
       expect{ interface.selectp(14)  }.to raise_exception ArgumentError
     end
 
-    it 'raises some sort of Pod4 error if it runs into problems' do
-      expect{ interface.selectp('select * from not_a_table where thingy = ?', 14) }.
+    it "raises some sort of Pod4 error if it runs into problems" do
+      expect{ interface.selectp("select * from not_a_table where thingy = ?", 14) }.
         to raise_exception Pod4Error
 
     end
 
-    it 'returns the result of the sql' do
-      sql = 'select name from customer where qty < ?;'
+    it "returns the result of the sql" do
+      sql = "select name from customer where qty < ?;"
 
       expect{ interface.selectp(sql, 2.0) }.not_to raise_exception
-      expect( interface.selectp(sql, 2.0) ).to eq( [{name: 'Barney'}] )
+      expect( interface.selectp(sql, 2.0) ).to eq( [{name: "Barney"}] )
       expect( interface.selectp(sql, 0.0) ).to eq( [] )
     end
 
-    it 'works if you pass a non-select' do
+    it "works if you pass a non-select" do
       # By which I mean: still executes the SQL; returns []
-      sql = 'delete from customer where qty < ?;'
+      sql = "delete from customer where qty < ?;"
       ret = interface.selectp(sql, 2.0)
 
       expect( interface.list.size ).to eq(data.size - 1)
-      expect( interface.list.map{|r| r[:name] } ).not_to include 'Barney'
+      expect( interface.list.map{|r| r[:name] } ).not_to include "Barney"
       expect( ret ).to eq( [] )
     end
 
-  end
+  end # #selectp
+
+
+  #
+  # We'll not be testing #new_connection or #close_connection since for Sequel, they basically do
+  # nothing.
+  #
 
 
 end