pmacs-activerecord-oracle_enhanced-adapter 1.4.2.rc1

data/spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe "OracleEnhancedAdapter logging dbms_output from plsql" do
+  include LoggerSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    ActiveRecord::Base.connection.execute <<-SQL
+    CREATE or REPLACE
+    FUNCTION MORE_THAN_FIVE_CHARACTERS_LONG (some_text VARCHAR2) RETURN INTEGER
+    AS
+      longer_than_five INTEGER;
+    BEGIN
+      dbms_output.put_line('before the if -' || some_text || '-');
+      IF length(some_text) > 5 THEN
+        dbms_output.put_line('it is longer than 5');
+        longer_than_five := 1;
+      ELSE
+        dbms_output.put_line('it is 5 or shorter');
+        longer_than_five := 0;
+      END IF;
+      dbms_output.put_line('about to return: ' || longer_than_five);
+      RETURN longer_than_five;
+    END;
+    SQL
+  end
+
+  after(:all) do
+    ActiveRecord::Base.connection.execute "DROP FUNCTION MORE_THAN_FIVE_CHARACTERS_LONG"
+  end
+
+  before(:each) do
+    set_logger
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+  end
+
+  after(:each) do
+    clear_logger
+  end
+
+  it "should NOT log dbms output when dbms output is disabled" do
+    @conn.disable_dbms_output
+
+    @conn.select_all("select more_than_five_characters_long('hi there') is_it_long from dual").should == [{'is_it_long'=>1}]
+
+    @logger.output(:debug).should_not match(/^DBMS_OUTPUT/)
+  end
+
+  it "should log dbms output lines to the rails log" do
+    @conn.enable_dbms_output
+
+    @conn.select_all("select more_than_five_characters_long('hi there') is_it_long from dual").should == [{'is_it_long'=>1}]
+    
+    @logger.output(:debug).should match(/^DBMS_OUTPUT: before the if -hi there-$/)
+    @logger.output(:debug).should match(/^DBMS_OUTPUT: it is longer than 5$/)
+    @logger.output(:debug).should match(/^DBMS_OUTPUT: about to return: 1$/)
+  end
+
+  it "should log dbms output lines to the rails log" do
+    @conn.enable_dbms_output
+
+    @conn.select_all("select more_than_five_characters_long('short') is_it_long from dual").should == [{'is_it_long'=>0}]
+    
+    @logger.output(:debug).should match(/^DBMS_OUTPUT: before the if -short-$/)
+    @logger.output(:debug).should match(/^DBMS_OUTPUT: it is 5 or shorter$/)
+    @logger.output(:debug).should match(/^DBMS_OUTPUT: about to return: 0$/)
+  end
+end

data/spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb

@@ -0,0 +1,141 @@
+require 'spec_helper'
+
+if ActiveRecord::Base.method_defined?(:changed?)
+
+  describe "OracleEnhancedAdapter dirty object tracking" do
+
+    before(:all) do
+      ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+      @conn = ActiveRecord::Base.connection
+      @conn.execute "DROP TABLE test_employees" rescue nil
+      @conn.execute "DROP SEQUENCE test_employees_seq" rescue nil
+      @conn.execute <<-SQL
+        CREATE TABLE test_employees (
+          id            NUMBER PRIMARY KEY,
+          first_name    VARCHAR2(20),
+          last_name     VARCHAR2(25),
+          job_id        NUMBER(6,0) NULL,
+          salary        NUMBER(8,2),
+          comments      CLOB,
+          hire_date     DATE
+        )
+      SQL
+      @conn.execute <<-SQL
+        CREATE SEQUENCE test_employees_seq  MINVALUE 1
+          INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
+      SQL
+      class TestEmployee < ActiveRecord::Base
+      end
+    end
+  
+    after(:all) do
+      Object.send(:remove_const, "TestEmployee")
+      @conn.execute "DROP TABLE test_employees"
+      @conn.execute "DROP SEQUENCE test_employees_seq"
+      ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
+    end  
+
+    it "should not mark empty string (stored as NULL) as changed when reassigning it" do
+      @employee = TestEmployee.create!(:first_name => '')
+      @employee.first_name = ''
+      @employee.should_not be_changed
+      @employee.reload
+      @employee.first_name = ''
+      @employee.should_not be_changed
+    end
+
+    it "should not mark empty integer (stored as NULL) as changed when reassigning it" do
+      @employee = TestEmployee.create!(:job_id => '')
+      @employee.job_id = ''
+      @employee.should_not be_changed
+      @employee.reload
+      @employee.job_id = ''
+      @employee.should_not be_changed
+    end
+
+    it "should not mark empty decimal (stored as NULL) as changed when reassigning it" do
+      @employee = TestEmployee.create!(:salary => '')
+      @employee.salary = ''
+      @employee.should_not be_changed
+      @employee.reload
+      @employee.salary = ''
+      @employee.should_not be_changed
+    end
+
+    it "should not mark empty text (stored as NULL) as changed when reassigning it" do
+      @employee = TestEmployee.create!(:comments => nil)
+      @employee.comments = nil
+      @employee.should_not be_changed
+      @employee.reload
+      @employee.comments = nil
+      @employee.should_not be_changed
+    end
+
+    it "should not mark empty text (stored as empty_clob()) as changed when reassigning it" do
+      @employee = TestEmployee.create!(:comments => '')
+      @employee.comments = ''
+      @employee.should_not be_changed
+      @employee.reload
+      @employee.comments = ''
+      @employee.should_not be_changed
+    end
+
+    it "should mark empty text (stored as empty_clob()) as changed when assigning nil to it" do
+      @employee = TestEmployee.create!(:comments => '')
+      @employee.comments = nil
+      @employee.should be_changed
+      @employee.reload
+      @employee.comments = nil
+      @employee.should be_changed
+    end
+
+    it "should mark empty text (stored as NULL) as changed when assigning '' to it" do
+      @employee = TestEmployee.create!(:comments => nil)
+      @employee.comments = ''
+      @employee.should be_changed
+      @employee.reload
+      @employee.comments = ''
+      @employee.should be_changed
+    end
+
+    it "should not mark empty date (stored as NULL) as changed when reassigning it" do
+      @employee = TestEmployee.create!(:hire_date => '')
+      @employee.hire_date = ''
+      @employee.should_not be_changed
+      @employee.reload
+      @employee.hire_date = ''
+      @employee.should_not be_changed
+    end
+
+    it "should not mark integer as changed when reassigning it" do
+      @employee = TestEmployee.new
+      @employee.job_id = 0
+      @employee.save!.should be_true
+      
+      @employee.should_not be_changed
+
+      @employee.job_id = '0'
+      @employee.should_not be_changed
+    end
+
+    it "should not update unchanged CLOBs" do
+      @employee = TestEmployee.create!(
+          :comments => "initial"
+      )
+      @employee.save!.should be_true
+      @employee.reload
+      @employee.comments.should == 'initial'
+
+      oci_conn = @conn.instance_variable_get('@connection')
+      class << oci_conn
+         def write_lob(lob, value, is_binary = false); raise "don't do this'"; end
+      end
+      @employee.save!.should_not raise_exception(RuntimeError, "don't do this'")
+      class << oci_conn
+        remove_method :write_lob
+      end
+    end
+
+  end
+
+end

data/spec/active_record/connection_adapters/oracle_enhanced_emulate_oracle_adapter_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe "OracleEnhancedAdapter emulate OracleAdapter" do
+
+  before(:all) do
+    if defined?(ActiveRecord::ConnectionAdapters::OracleAdapter)
+      @old_oracle_adapter = ActiveRecord::ConnectionAdapters::OracleAdapter
+      ActiveRecord::ConnectionAdapters.send(:remove_const, :OracleAdapter)
+    end
+  end
+
+  it "should be an OracleAdapter" do
+    @conn = ActiveRecord::Base.establish_connection(CONNECTION_PARAMS.merge(:emulate_oracle_adapter => true))
+    ActiveRecord::Base.connection.should_not be_nil
+    ActiveRecord::Base.connection.is_a?(ActiveRecord::ConnectionAdapters::OracleAdapter).should be_true
+  end
+
+  after(:all) do
+    if @old_oracle_adapter
+      ActiveRecord::ConnectionAdapters.send(:remove_const, :OracleAdapter)
+      ActiveRecord::ConnectionAdapters::OracleAdapter = @old_oracle_adapter
+    end
+  end
+
+end

data/spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb

@@ -0,0 +1,378 @@
+require 'spec_helper'
+
+require 'ruby-plsql'
+
+describe "OracleEnhancedAdapter custom methods for create, update and destroy" do
+  include LoggerSpecHelper
+  
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    plsql.activerecord_class = ActiveRecord::Base
+    @conn.execute("DROP TABLE test_employees") rescue nil
+    @conn.execute <<-SQL
+      CREATE TABLE test_employees (
+        employee_id   NUMBER(6,0) PRIMARY KEY,
+        first_name    VARCHAR2(20),
+        last_name     VARCHAR2(25),
+        hire_date     DATE,
+        salary        NUMBER(8,2),
+        description   CLOB,
+        version       NUMBER(15,0),
+        create_time   DATE,
+        update_time   DATE,
+        created_at    DATE,
+        updated_at    DATE
+      )
+    SQL
+    @conn.execute("DROP SEQUENCE test_employees_s") rescue nil
+    @conn.execute <<-SQL
+      CREATE SEQUENCE test_employees_s  MINVALUE 1
+        INCREMENT BY 1 CACHE 20 NOORDER NOCYCLE
+    SQL
+    @conn.execute <<-SQL
+      CREATE OR REPLACE PACKAGE test_employees_pkg IS
+        PROCEDURE create_employee(
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2,
+            p_employee_id   OUT NUMBER);
+        PROCEDURE update_employee(
+            p_employee_id   NUMBER,
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2);
+        PROCEDURE delete_employee(
+            p_employee_id   NUMBER);
+      END;
+    SQL
+    @conn.execute <<-SQL
+      CREATE OR REPLACE PACKAGE BODY test_employees_pkg IS
+        PROCEDURE create_employee(
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2,
+            p_employee_id   OUT NUMBER)
+        IS
+        BEGIN
+          SELECT test_employees_s.NEXTVAL INTO p_employee_id FROM dual;
+          INSERT INTO test_employees (employee_id, first_name, last_name, hire_date, salary, description,
+                                      version, create_time, update_time)
+          VALUES (p_employee_id, p_first_name, p_last_name, p_hire_date, p_salary, p_description,
+                                      1, SYSDATE, SYSDATE);
+        END create_employee;
+        
+        PROCEDURE update_employee(
+            p_employee_id   NUMBER,
+            p_first_name    VARCHAR2,
+            p_last_name     VARCHAR2,
+            p_hire_date     DATE,
+            p_salary        NUMBER,
+            p_description   VARCHAR2)
+        IS
+            v_version       NUMBER;
+        BEGIN
+          SELECT version INTO v_version FROM test_employees WHERE employee_id = p_employee_id FOR UPDATE;
+          UPDATE test_employees
+          SET first_name = p_first_name, last_name = p_last_name,
+              hire_date = p_hire_date, salary = p_salary, description = p_description,
+              version = v_version + 1, update_time = SYSDATE
+          WHERE employee_id = p_employee_id;
+        END update_employee;
+        
+        PROCEDURE delete_employee(
+            p_employee_id   NUMBER)
+        IS
+        BEGIN
+          DELETE FROM test_employees WHERE employee_id = p_employee_id;
+        END delete_employee;
+      END;
+    SQL
+
+    ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_dates_by_column_name = true
+  end
+
+  after(:all) do
+    @conn = ActiveRecord::Base.connection
+    @conn.execute "DROP TABLE test_employees"
+    @conn.execute "DROP SEQUENCE test_employees_s"
+    @conn.execute "DROP PACKAGE test_employees_pkg"
+  end
+
+  before(:each) do
+    class ::TestEmployee < ActiveRecord::Base
+      if self.respond_to?(:primary_key=)
+        self.primary_key = :employee_id
+      else
+        set_primary_key :employee_id
+      end
+
+      validates_presence_of :first_name, :last_name, :hire_date
+      
+      # should return ID of new record
+      set_create_method do
+        plsql.test_employees_pkg.create_employee(
+          :p_first_name => first_name,
+          :p_last_name => last_name,
+          :p_hire_date => hire_date,
+          :p_salary => salary,
+          :p_description => "#{first_name} #{last_name}",
+          :p_employee_id => nil
+        )[:p_employee_id]
+      end
+
+      # return value is ignored
+      set_update_method do
+        plsql.test_employees_pkg.update_employee(
+          :p_employee_id => id,
+          :p_first_name => first_name,
+          :p_last_name => last_name,
+          :p_hire_date => hire_date,
+          :p_salary => salary,
+          :p_description => "#{first_name} #{last_name}"
+        )
+      end
+
+      # return value is ignored
+      set_delete_method do
+        plsql.test_employees_pkg.delete_employee(
+          :p_employee_id => id
+        )
+      end
+
+      private
+
+      def raise_make_transaction_rollback
+        raise "Make the transaction rollback"
+      end
+    end
+
+    @today = Date.new(2008,6,28)
+    @buffer = StringIO.new
+  end
+
+  after(:each) do
+    Object.send(:remove_const, "TestEmployee")
+    ActiveRecord::Base.clear_cache! if ActiveRecord::Base.respond_to?(:"clear_cache!")
+  end
+
+  it "should create record" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    @employee.first_name.should == "First"
+    @employee.last_name.should == "Last"
+    @employee.hire_date.should == @today
+    @employee.description.should == "First Last"
+    @employee.create_time.should_not be_nil
+    @employee.update_time.should_not be_nil
+  end
+
+  it "should rollback record when exception is raised in after_create callback" do
+    TestEmployee.after_create :raise_make_transaction_rollback
+
+    @employee = TestEmployee.new(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    employees_count = TestEmployee.count
+    lambda {
+      @employee.save
+    }.should raise_error("Make the transaction rollback")
+    @employee.id.should == nil
+    TestEmployee.count.should == employees_count
+  end
+
+  it "should update record" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today,
+      :description => "description"
+    )
+    @employee.reload
+    @employee.first_name = "Second"
+    @employee.save!
+    @employee.reload
+    @employee.description.should == "Second Last"
+  end
+
+  it "should rollback record when exception is raised in after_update callback" do
+    TestEmployee.after_update :raise_make_transaction_rollback
+
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today,
+      :description => "description"
+    )
+    empl_id = @employee.id
+    @employee.reload
+    @employee.first_name = "Second"
+    lambda {
+      @employee.save
+    }.should raise_error("Make the transaction rollback")
+    @employee.reload
+    @employee.first_name.should == "First"
+  end
+
+  it "should not update record if nothing is changed and partial updates are enabled" do
+    return pending("Not in this ActiveRecord version") unless TestEmployee.respond_to?(:partial_updates=)
+    TestEmployee.partial_updates = true
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    @employee.save!
+    @employee.reload
+    @employee.version.should == 1
+  end
+
+  it "should update record if nothing is changed and partial updates are disabled" do
+    return pending("Not in this ActiveRecord version") unless TestEmployee.respond_to?(:partial_updates=)
+    TestEmployee.partial_updates = false
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    @employee.save!
+    @employee.reload
+    @employee.version.should == 2
+  end
+
+  it "should delete record" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    empl_id = @employee.id
+    @employee.destroy
+    @employee.should be_frozen
+    TestEmployee.find_by_employee_id(empl_id).should be_nil
+  end
+
+  it "should delete record and set destroyed flag" do
+    return pending("Not in this ActiveRecord version (requires >= 2.3.5)") unless TestEmployee.method_defined?(:destroyed?)
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    @employee.destroy
+    @employee.should be_destroyed
+  end
+
+  it "should rollback record when exception is raised in after_destroy callback" do
+    set_logger
+    TestEmployee.after_destroy :raise_make_transaction_rollback
+
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    empl_id = @employee.id
+    lambda {
+      @employee.destroy
+    }.should raise_error("Make the transaction rollback")
+    @employee.id.should == empl_id
+    TestEmployee.find_by_employee_id(empl_id).should_not be_nil
+  end
+
+  it "should set timestamps when creating record" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.created_at.should_not be_nil
+    @employee.updated_at.should_not be_nil
+  end
+
+  it "should set timestamps when updating record" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.reload
+    @employee.created_at.should be_nil
+    @employee.updated_at.should be_nil
+    @employee.first_name = "Second"
+    @employee.save!
+    @employee.created_at.should be_nil
+    @employee.updated_at.should_not be_nil
+  end
+
+  it "should log create record" do
+    set_logger
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @logger.logged(:debug).last.should match(/^TestEmployee Create \(\d+\.\d+(ms)?\)  custom create method$/)
+  end
+
+  it "should log update record" do
+    (TestEmployee.partial_updates = false) rescue nil
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    set_logger
+    @employee.save!
+    @logger.logged(:debug).last.should match(/^TestEmployee Update \(\d+\.\d+(ms)?\)  custom update method with employee_id=#{@employee.id}$/)
+  end
+
+  it "should log delete record" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    set_logger
+    @employee.destroy
+    @logger.logged(:debug).last.should match(/^TestEmployee Destroy \(\d+\.\d+(ms)?\)  custom delete method with employee_id=#{@employee.id}$/)
+  end
+
+  it "should validate new record before creation" do
+    @employee = TestEmployee.new(
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.save.should be_false
+    @employee.errors[:first_name].should_not be_blank
+  end
+
+  it "should validate existing record before update" do
+    @employee = TestEmployee.create(
+      :first_name => "First",
+      :last_name => "Last",
+      :hire_date => @today
+    )
+    @employee.first_name = nil
+    @employee.save.should be_false
+    @employee.errors[:first_name].should_not be_blank
+  end
+  
+end