picturehouse_uk 3.0.14 → 5.0.0

data/test/live/integration_test.rb

@@ -1,7 +1,9 @@
 require 'minitest/autorun'
 require 'minitest/reporters'
-reporter_options = { color: true, slow_count: 5 }
-Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]
+
+Minitest::Reporters.use! [
+  Minitest::Reporters::DefaultReporter.new(color: true)
+]
 
 require File.expand_path('../../../lib/picturehouse_uk.rb', __FILE__)
 
@@ -12,57 +14,38 @@ describe PicturehouseUk::Cinema do
     subject { described_class.all }
 
     it 'returns an Array of CineworldUK::Cinemas' do
-      subject.must_be_instance_of(Array)
+      _(subject).must_be_instance_of(Array)
       subject.each do |value|
-        value.must_be_instance_of(PicturehouseUk::Cinema)
+        _(value).must_be_instance_of(PicturehouseUk::Cinema)
       end
     end
 
     it 'returns the correctly sized array' do
-      subject.size.must_be :>, 18
+      _(subject.size).must_be :>, 18
     end
 
     it 'returns the right cinemas' do
-      subject.first.name.must_equal 'Clapham Picturehouse'
-      subject.last.name.must_equal 'City Screen Picturehouse'
-    end
-  end
-end
-
-describe PicturehouseUk::Film do
-  let(:described_class) { PicturehouseUk::Film }
-
-  describe '.at(cinema_id)' do
-    subject { described_class.at('Duke_Of_Yorks') }
-
-    it 'returns an array of films' do
-      subject.must_be_instance_of(Array)
-      subject.each do |film|
-        film.must_be_instance_of(PicturehouseUk::Film)
-      end
-    end
-
-    it 'returns a decent number of films' do
-      subject.count.must_be :>, 5
+      _(subject.first.name).must_equal 'Little Theatre Cinema'
+      _(subject.last.name).must_equal 'City Screen York'
     end
   end
 end
 
-describe PicturehouseUk::Screening do
-  let(:described_class) { PicturehouseUk::Screening }
+describe PicturehouseUk::Performance do
+  let(:described_class) { PicturehouseUk::Performance }
 
   describe '.at(cinema_id)' do
     subject { described_class.at('Duke_Of_Yorks') }
 
     it 'returns an array of screenings' do
-      subject.must_be_instance_of(Array)
-      subject.each do |screening|
-        screening.must_be_instance_of(PicturehouseUk::Screening)
+      _(subject).must_be_instance_of(Array)
+      subject.each do |performance|
+        _(performance).must_be_instance_of(PicturehouseUk::Performance)
       end
     end
 
     it 'returns correct number of screenings' do
-      subject.count.must_be :>, 10
+      _(subject.count).must_be :>, 10
     end
   end
 end

data/test/support/fake_api.rb

@@ -0,0 +1,16 @@
+require 'json'
+
+# Fake API client for reading JSON fixtures from disk
+class FakeApi
+  def get_movies(cinema_id, _date = 'show_all_dates')
+    JSON.parse(read_file("../../fixtures/#{cinema_id}/get_movies.json"))
+  rescue Errno::ENOENT
+    { 'response' => 'error', 'movies' => [] }
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+end

data/test/support/fake_website.rb

@@ -0,0 +1,24 @@
+# Fake website for reading fixtures from disk
+class FakeWebsite
+  def home
+    read_file('../../fixtures/home.html')
+  end
+
+  def cinemas
+    read_file('../../fixtures/cinemas.html')
+  end
+
+  def cinema(cinema_id)
+    read_file("../../fixtures/#{cinema_id}/cinema.html")
+  end
+
+  def information(cinema_id)
+    read_file("../../fixtures/#{cinema_id}/information.html")
+  end
+
+  private
+
+  def read_file(filepath)
+    File.read(File.expand_path(filepath, __FILE__))
+  end
+end

data/test/test_helper.rb

@@ -1,8 +1,19 @@
+require 'simplecov'
+SimpleCov.start
+
 require 'minitest/autorun'
 require 'minitest/reporters'
-reporter_options = { color: true, slow_count: 5 }
-Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]
+
+Minitest::Reporters.use! [
+  Minitest::Reporters::DefaultReporter.new(color: true, slow_count: 5)
+]
+
+require 'webmock/minitest'
+WebMock.allow_net_connect!
 
 require 'webmock/minitest'
 
 require File.expand_path('../../lib/picturehouse_uk.rb', __FILE__)
+
+require_relative 'support/fake_api'
+require_relative 'support/fake_website'

metadata

@@ -1,29 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: picturehouse_uk
 version: !ruby/object:Gem::Version
-  version: 3.0.14
+  version: 5.0.0
 platform: ruby
 authors:
 - Andy Croll
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-17 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +38,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,13 +52,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -81,21 +66,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: tzinfo
+  name: cinebase
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: tzinfo-data
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -108,60 +93,63 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: An API to pull movie information from the picturehouse.co.uk website
+description: API pulling information from picturehouse.com
 email:
 - andy@goodscary.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
+- ".github/workflows/release.yml"
 - ".gitignore"
-- ".rdoc_options"
-- ".travis.yml"
+- ".ruby-version"
 - ".yardopts"
 - CHANGELOG.md
+- COMM-LICENSE
 - Gemfile
-- LICENSE.txt
+- LICENSE
 - README.md
 - Rakefile
 - lib/picturehouse_uk.rb
 - lib/picturehouse_uk/cinema.rb
-- lib/picturehouse_uk/film.rb
+- lib/picturehouse_uk/internal/api.rb
 - lib/picturehouse_uk/internal/parser/address.rb
 - lib/picturehouse_uk/internal/parser/screenings.rb
 - lib/picturehouse_uk/internal/title_sanitizer.rb
 - lib/picturehouse_uk/internal/website.rb
-- lib/picturehouse_uk/screening.rb
+- lib/picturehouse_uk/performance.rb
 - lib/picturehouse_uk/version.rb
 - picturehouse_uk.gemspec
-- test/fixture_updater.rb
-- test/fixtures/cinema/Duke_Of_Yorks.html
-- test/fixtures/cinema/Dukes_At_Komedia.html
-- test/fixtures/cinema/National_Media_Museum.html
-- test/fixtures/cinema/Phoenix_Picturehouse.html
+- rake/fixture_creator.rb
+- test/fixtures/cinemas.html
+- test/fixtures/duke-of-york-s-picturehouse/cinema.html
+- test/fixtures/duke-of-york-s-picturehouse/get_movies.json
+- test/fixtures/duke-of-york-s-picturehouse/information.html
+- test/fixtures/duke-s-at-komedia/cinema.html
+- test/fixtures/duke-s-at-komedia/get_movies.json
+- test/fixtures/duke-s-at-komedia/information.html
 - test/fixtures/home.html
-- test/fixtures/info/Duke_Of_Yorks.html
-- test/fixtures/info/Dukes_At_Komedia.html
-- test/fixtures/info/Phoenix_Picturehouse.html
-- test/fixtures/whats_on/Duke_Of_Yorks.html
-- test/fixtures/whats_on/Dukes_At_Komedia.html
-- test/fixtures/whats_on/National_Media_Museum.html
-- test/fixtures/whats_on/Phoenix_Picturehouse.html
+- test/fixtures/phoenix-picturehouse/cinema.html
+- test/fixtures/phoenix-picturehouse/get_movies.json
+- test/fixtures/phoenix-picturehouse/information.html
 - test/lib/picturehouse_uk/cinema_test.rb
-- test/lib/picturehouse_uk/film_test.rb
-- test/lib/picturehouse_uk/internal/parser/address_parser_test.rb
+- test/lib/picturehouse_uk/internal/api_test.rb
+- test/lib/picturehouse_uk/internal/parser/address_test.rb
 - test/lib/picturehouse_uk/internal/parser/screenings_test.rb
 - test/lib/picturehouse_uk/internal/title_sanitizer_test.rb
 - test/lib/picturehouse_uk/internal/website_test.rb
-- test/lib/picturehouse_uk/screening_test.rb
+- test/lib/picturehouse_uk/performance_test.rb
 - test/lib/picturehouse_uk/version_test.rb
 - test/live/integration_test.rb
+- test/support/fake_api.rb
+- test/support/fake_website.rb
 - test/test_helper.rb
 homepage: ''
 licenses:
+- AGPL
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -176,33 +164,30 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: It's a scraper, but a nice one
 test_files:
-- test/fixture_updater.rb
-- test/fixtures/cinema/Duke_Of_Yorks.html
-- test/fixtures/cinema/Dukes_At_Komedia.html
-- test/fixtures/cinema/National_Media_Museum.html
-- test/fixtures/cinema/Phoenix_Picturehouse.html
+- test/fixtures/cinemas.html
+- test/fixtures/duke-of-york-s-picturehouse/cinema.html
+- test/fixtures/duke-of-york-s-picturehouse/get_movies.json
+- test/fixtures/duke-of-york-s-picturehouse/information.html
+- test/fixtures/duke-s-at-komedia/cinema.html
+- test/fixtures/duke-s-at-komedia/get_movies.json
+- test/fixtures/duke-s-at-komedia/information.html
 - test/fixtures/home.html
-- test/fixtures/info/Duke_Of_Yorks.html
-- test/fixtures/info/Dukes_At_Komedia.html
-- test/fixtures/info/Phoenix_Picturehouse.html
-- test/fixtures/whats_on/Duke_Of_Yorks.html
-- test/fixtures/whats_on/Dukes_At_Komedia.html
-- test/fixtures/whats_on/National_Media_Museum.html
-- test/fixtures/whats_on/Phoenix_Picturehouse.html
+- test/fixtures/phoenix-picturehouse/cinema.html
+- test/fixtures/phoenix-picturehouse/get_movies.json
+- test/fixtures/phoenix-picturehouse/information.html
 - test/lib/picturehouse_uk/cinema_test.rb
-- test/lib/picturehouse_uk/film_test.rb
-- test/lib/picturehouse_uk/internal/parser/address_parser_test.rb
+- test/lib/picturehouse_uk/internal/api_test.rb
+- test/lib/picturehouse_uk/internal/parser/address_test.rb
 - test/lib/picturehouse_uk/internal/parser/screenings_test.rb
 - test/lib/picturehouse_uk/internal/title_sanitizer_test.rb
 - test/lib/picturehouse_uk/internal/website_test.rb
-- test/lib/picturehouse_uk/screening_test.rb
+- test/lib/picturehouse_uk/performance_test.rb
 - test/lib/picturehouse_uk/version_test.rb
 - test/live/integration_test.rb
+- test/support/fake_api.rb
+- test/support/fake_website.rb
 - test/test_helper.rb
-has_rdoc: 

data/.rdoc_options

@@ -1,16 +0,0 @@
---- !ruby/object:RDoc::Options
-encoding: UTF-8
-static_path: []
-rdoc_include:
-- .
-charset: UTF-8
-exclude: 
-hyperlink_all: false
-line_numbers: false
-main_page: 
-markup: tomdoc
-show_hash: false
-tab_width: 8
-title: 
-visibility: :protected
-webcvs: 

data/.travis.yml

@@ -1,5 +0,0 @@
-language: ruby
-rvm:
-  - 2.0.0
-  - 2.1.3
-script: "rake && rake live"

data/lib/picturehouse_uk/film.rb

@@ -1,59 +0,0 @@
-module PicturehouseUk
-  # A film on the Picturehouse UK website
-  class Film
-    include Comparable
-
-    # @return [String] the name of the film
-    attr_reader :name
-    # @return [String] the normalized slug derived from the film name
-    attr_reader :slug
-
-    # @param [String] name the film name
-    # @return [PicturehouseUk::Film]
-    def initialize(name)
-      @name = name
-      @slug = name.downcase.gsub(/[^0-9a-z ]/, '').gsub(/\s+/, '-')
-    end
-
-    # Films at a single cinema
-    # @param [String] cinema_id the id of the cinema
-    # @return [Array<PicturehouseUk::Film>]
-    def self.at(cinema_id)
-      screenings(cinema_id).map { |hash| new hash[:film_name] }.uniq
-    end
-
-    # Allows sort on objects
-    # @param [PicturehouseUk::Film] other another film object
-    # @return [Integer] -1, 0 or 1
-    def <=>(other)
-      slug <=> other.slug
-    end
-
-    # Check an object is the same as another object.
-    # @param [PicturehouseUk::Film] other another film
-    # @return [Boolean] True if both objects are the same exact object, or if
-    #   they are of the same type and share an equal slug
-    # @note Guided by http://woss.name/2011/01/20/equality-comparison-and-ordering-in-ruby/
-    def eql?(other)
-      self.class == other.class && self == other
-    end
-
-    # Generates hash of slug in order to allow two records of the same type and
-    # id to work with something like:
-    #
-    #   [ Film.new('AB'), Film.new('EF') ] & [ Film.new('EF'), Film.new('GH') ]
-    #   #=> [ Film.new('EF') ]
-    #
-    # @return [Integer] hash of slug
-    # @note Guided by http://woss.name/2011/01/20/equality-comparison-and-ordering-in-ruby/
-    def hash
-      slug.hash
-    end
-
-    private
-
-    def self.screenings(cinema_id)
-      PicturehouseUk::Internal::Parser::Screenings.new(cinema_id).to_a
-    end
-  end
-end

data/lib/picturehouse_uk/screening.rb

@@ -1,70 +0,0 @@
-module PicturehouseUk
-  # A single screening of a film on the Picturehouse UK website
-  class Screening
-    # @return [String] the booking URL on the cinema website
-    attr_reader :booking_url
-    # @return [String] the cinema name
-    attr_reader :cinema_name
-    # @return [String] 2d or 3d
-    attr_reader :dimension
-    # @return [String] the film name
-    attr_reader :film_name
-
-    # @param [Hash] options
-    def initialize(options)
-      @booking_url = options.fetch(:booking_url, nil)
-      @cinema_name = options.fetch(:cinema_name)
-      @cinema_id   = options.fetch(:cinema_id)
-      @dimension   = options.fetch(:dimension, '2d')
-      @film_name   = options.fetch(:film_name)
-      @time        = options.fetch(:time)
-      @variant     = options.fetch(:variant, [])
-    end
-
-    # Screenings at a single cinema
-    # @param [String] cinema_id the id of the cinema
-    # @return [Array<PicturehouseUk::Screening>]
-    def self.at(cinema_id)
-      screenings(cinema_id).map do |attributes|
-        new cinema_hash(cinema_id).merge(attributes)
-      end.uniq
-    end
-
-    # The UTC time of the screening
-    # @return [Time]
-    def showing_at
-      @showing_at ||= begin
-        if @time.utc?
-          @time
-        else
-          TZInfo::Timezone.get('Europe/London').local_to_utc(@time)
-        end
-      end
-    end
-
-    # The date of the screening
-    # @return [Date]
-    def showing_on
-      showing_at.to_date
-    end
-
-    # The kinds of screening
-    # @return <Array[String]>
-    def variant
-      @variant.map(&:downcase).sort
-    end
-
-    private
-
-    def self.cinema_hash(cinema_id)
-      {
-        cinema_id: cinema_id,
-        cinema_name: PicturehouseUk::Cinema.find(cinema_id).name
-      }
-    end
-
-    def self.screenings(cinema_id)
-      PicturehouseUk::Internal::Parser::Screenings.new(cinema_id).to_a
-    end
-  end
-end

data/test/fixture_updater.rb

@@ -1,73 +0,0 @@
-require File.expand_path('../../lib/picturehouse_uk.rb', __FILE__)
-
-def fixture(name)
-  File.expand_path("../fixtures/#{name}.html", __FILE__)
-end
-
-File.open(fixture('home'), 'w') do |file|
-  puts '* Homepage'
-  file.write PicturehouseUk::Internal::Website.new.home
-end
-
-# DUKE OF YORKS
-
-File.open(fixture('cinema/Duke_Of_Yorks'), 'w') do |file|
-  puts '* Duke of Yorks'
-  file.write PicturehouseUk::Internal::Website.new.cinema('Duke_Of_Yorks')
-end
-
-File.open(fixture('info/Duke_Of_Yorks'), 'w') do |file|
-  puts '* Duke of Yorks Information'
-  file.write PicturehouseUk::Internal::Website.new.info('Duke_Of_Yorks')
-end
-
-File.open(fixture('whats_on/Duke_Of_Yorks'), 'w') do |file|
-  puts '* Duke of Yorks Whats On'
-  file.write PicturehouseUk::Internal::Website.new.whats_on('Duke_Of_Yorks')
-end
-
-# KOMEDIA
-
-File.open(fixture('cinema/Dukes_At_Komedia'), 'w') do |file|
-  puts '* Dukes at Komedia'
-  file.write PicturehouseUk::Internal::Website.new.cinema('Dukes_At_Komedia')
-end
-
-File.open(fixture('info/Dukes_At_Komedia'), 'w') do |file|
-  puts '* Dukes at Komedia Information'
-  file.write PicturehouseUk::Internal::Website.new.info('Dukes_At_Komedia')
-end
-
-File.open(fixture('whats_on/Dukes_At_Komedia'), 'w') do |file|
-  puts '* Dukes at Komedia Whats On'
-  file.write PicturehouseUk::Internal::Website.new.whats_on('Dukes_At_Komedia')
-end
-
-# PHEONIX OXFORD
-
-File.open(fixture('cinema/Phoenix_Picturehouse'), 'w') do |file|
-  puts '* Pheonix Oxford'
-  file.write PicturehouseUk::Internal::Website.new.cinema('Phoenix_Picturehouse')
-end
-
-File.open(fixture('info/Phoenix_Picturehouse'), 'w') do |file|
-  puts '* Pheonix Oxford Information'
-  file.write PicturehouseUk::Internal::Website.new.info('Phoenix_Picturehouse')
-end
-
-File.open(fixture('whats_on/Phoenix_Picturehouse'), 'w') do |file|
-  puts '* Pheonix Oxford Whats On'
-  file.write PicturehouseUk::Internal::Website.new.whats_on('Phoenix_Picturehouse')
-end
-
-# NATIONAL MEDIA MUSEUM (IMAX)
-
-File.open(fixture('cinema/National_Media_Museum'), 'w') do |file|
-  puts '* National Media Museum'
-  file.write PicturehouseUk::Internal::Website.new.cinema('National_Media_Museum')
-end
-
-File.open(fixture('whats_on/National_Media_Museum'), 'w') do |file|
-  puts '* National Media Museum Whats On'
-  file.write PicturehouseUk::Internal::Website.new.whats_on('National_Media_Museum')
-end