picturehouse_uk 3.0.14 → 5.0.0

data/test/lib/picturehouse_uk/cinema_test.rb

@@ -2,251 +2,222 @@ require_relative '../../test_helper'
 
 describe PicturehouseUk::Cinema do
   let(:described_class) { PicturehouseUk::Cinema }
-  let(:website) { MockWebsite.new }
+  let(:website) { FakeWebsite.new }
 
-  before do
-    WebMock.disable_net_connect!
-  end
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
   describe '.all' do
     subject { described_class.all }
 
     it 'returns an Array of CineworldUK::Cinemas' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.must_be_instance_of(Array)
+        _(subject).must_be_instance_of(Array)
         subject.each do |value|
-          value.must_be_instance_of(PicturehouseUk::Cinema)
+          _(value).must_be_instance_of(PicturehouseUk::Cinema)
         end
       end
     end
 
     it 'returns the correctly sized array' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.size.must_equal 22
+        _(subject.size).must_equal 25
       end
     end
 
     it 'returns the right cinemas' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.first.name.must_equal 'Clapham Picturehouse'
-        subject.last.name.must_equal 'City Screen Picturehouse'
+        _(subject.first.name).must_equal 'Little Theatre Cinema'
+        _(subject.last.name).must_equal 'City Screen York'
       end
     end
   end
 
-  describe '.find(id)' do
-    subject { described_class.find(id) }
-
-    let(:id) { 'Duke_Of_Yorks' }
-
-    it 'returns a cinema' do
-      PicturehouseUk::Internal::Website.stub :new, website do
-        subject.must_be_instance_of(PicturehouseUk::Cinema)
-
-        subject.id.must_equal id
-        subject.brand.must_equal 'Picturehouse'
-        subject.name.must_equal "Duke of York's Picturehouse"
-        subject.slug.must_equal 'duke-of-yorks-picturehouse'
-        subject.url.must_equal "http://www.picturehouses.com/cinema/#{id}"
-      end
-    end
-  end
-
-  describe '.new(options)' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
-
-    subject { described_class.new(options) }
+  describe '.new(id)' do
+    subject { described_class.new('duke-s-at-komedia') }
 
     it 'stores id, name, slug and url' do
-      subject.id.must_equal 'Dukes_At_Komedia'
-      subject.brand.must_equal 'Picturehouse'
-      subject.name.must_equal "Duke's At Komedia"
-      subject.slug.must_equal 'dukes-at-komedia'
-      subject.url.must_equal 'http://www.picturehouses.com/cinema/Dukes_At_Komedia'
+      _(subject).must_be_instance_of(PicturehouseUk::Cinema)
     end
   end
 
   describe '#adr' do
-    let(:options) do
-      {
-        id:   'Phoenix_Picturehouse',
-        name: "Pheonix Picturehouse",
-        url:  '/cinema/Phoenix_Picturehouse'
-      }
-    end
+    subject { described_class.new(id).adr }
 
-    describe '#adr' do
-      subject { described_class.new(options).adr }
+    describe 'no region' do
+      let(:id) { 'phoenix-picturehouse' }
 
       it 'returns address hash' do
         PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal(
+          _(subject).must_equal(
             street_address:   '57 Walton Street',
             extended_address: nil,
             locality:         'Oxford',
             region:           nil,
             postal_code:      'OX2 6AE',
-            country:          'United Kingdom'
+            country_name:     'United Kingdom'
           )
         end
       end
     end
-  end
-
-  describe 'integration-y address tests' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
 
-    describe '#adr' do
-      subject { described_class.new(options).adr }
+    describe 'with region' do
+      let(:id) { 'duke-s-at-komedia' }
 
       it 'returns address hash' do
         PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal(
+          _(subject).must_equal(
             street_address:   '44–47 Gardner Street',
             extended_address: nil,
             locality:         'Brighton',
             region:           'East Sussex',
             postal_code:      'BN1 1UN',
-            country:          'United Kingdom'
+            country_name:     'United Kingdom'
           )
         end
       end
     end
+  end
+
+  describe '#address' do
+    subject { described_class.new(id).address }
 
-    describe '#street_address' do
-      subject { described_class.new(options).street_address }
+    describe 'no region' do
+      let(:id) { 'phoenix-picturehouse' }
 
-      it 'returns first line of address' do
+      it 'returns address hash' do
         PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('44–47 Gardner Street')
+          _(subject).must_equal(
+            street_address:   '57 Walton Street',
+            extended_address: nil,
+            locality:         'Oxford',
+            region:           nil,
+            postal_code:      'OX2 6AE',
+            country_name:     'United Kingdom'
+          )
         end
       end
     end
+  end
 
-    describe '#extended_address' do
-      subject { described_class.new(options).extended_address }
+  describe '#brand' do
+    subject { described_class.new(id).brand }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal(nil)
-        end
+    let(:id) { 'duke-s-at-komedia' }
+
+    it 'returns Picturehouse' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('Picturehouse')
       end
     end
+  end
 
-    describe '#locality' do
-      subject { described_class.new(options).locality }
+  describe '#country_name' do
+    subject { described_class.new(id).country_name }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('Brighton')
-        end
+    let(:id) { 'duke-s-at-komedia' }
+
+    it 'returns country' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('United Kingdom')
       end
     end
+  end
 
-    describe '#region' do
-      subject { described_class.new(options).region }
+  describe '#extended_address' do
+    subject { described_class.new(id).extended_address }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('East Sussex')
-        end
+    let(:id) { 'duke-s-at-komedia' }
+
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('')
       end
     end
+  end
+
+  describe '#full_name' do
+    subject { described_class.new(id).full_name }
 
-    describe '#postal_code' do
-      subject { described_class.new(options).postal_code }
+    let(:id) { 'duke-s-at-komedia' }
 
-      it 'returns second line of address' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_equal('BN1 1UN')
-        end
+    it 'returns full name (same as name)' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal("Duke's at Komedia")
+        _(subject).must_equal(described_class.new(id).name)
       end
     end
   end
 
-  describe '#films' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
+  describe '#locality' do
+    subject { described_class.new(id).locality }
 
-    subject { described_class.new(options).films }
+    let(:id) { 'duke-s-at-komedia' }
 
-    it 'calls out to Film object' do
-      PicturehouseUk::Film.stub :at, [:film] do
-        subject.must_equal([:film])
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('Brighton')
       end
     end
   end
 
-  describe '#full_name' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
+  describe '#name' do
+    subject { described_class.new(id).name }
 
-    subject { described_class.new(options).full_name }
+    let(:id) { 'duke-s-at-komedia' }
 
-    it 'returns the cinema name' do
-      subject.must_equal "Duke's At Komedia"
+    it 'returns full name (same as name)' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal("Duke's at Komedia")
+      end
     end
   end
 
-  describe '#screenings' do
-    let(:options) do
-      {
-        id:   'Dukes_At_Komedia',
-        name: "Duke's At Komedia",
-        url:  '/cinema/Dukes_At_Komedia'
-      }
-    end
+  describe '#postal_code' do
+    subject { described_class.new(id).postal_code }
 
-    subject { described_class.new(options).screenings }
+    let(:id) { 'duke-s-at-komedia' }
 
-    it 'calls out to Screening object' do
-      PicturehouseUk::Screening.stub :at, [:screening] do
-        subject.must_equal([:screening])
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('BN1 1UN')
       end
     end
   end
 
-  private
+  describe '#region' do
+    subject { described_class.new(id).region }
 
-  class MockWebsite
-    def home
-      read_file('../../../fixtures/home.html')
-    end
+    let(:id) { 'duke-s-at-komedia' }
 
-    def cinema(filename)
-      read_file("../../../fixtures/cinema/#{filename}.html")
+    it 'returns second line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('East Sussex')
+      end
     end
+  end
 
-    def info(filename)
-      read_file("../../../fixtures/info/#{filename}.html")
+  describe '#slug' do
+    subject { described_class.new(id).slug }
+
+    let(:id) { 'duke-s-at-komedia' }
+
+    it 'returns downcased' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('dukes-at-komedia')
+      end
     end
+  end
+
+  describe '#street_address' do
+    subject { described_class.new(id).street_address }
 
-    private
+    let(:id) { 'duke-s-at-komedia' }
 
-    def read_file(filepath)
-      File.read(File.expand_path(filepath, __FILE__))
+    it 'returns first line of address' do
+      PicturehouseUk::Internal::Website.stub :new, website do
+        _(subject).must_equal('44–47 Gardner Street')
+      end
     end
   end
 end

data/test/lib/picturehouse_uk/internal/api_test.rb

@@ -0,0 +1,92 @@
+require_relative '../../../test_helper'
+
+describe PicturehouseUk::Internal::Api do
+  let(:described_class) { PicturehouseUk::Internal::Api }
+
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
+
+  describe '#get_movies' do
+    let(:client) { described_class.new }
+    let(:cinema_id) { 'duke-s-at-komedia' }
+
+    it 'makes POST request to correct endpoint' do
+      stub_request(:post, 'https://www.picturehouses.com/api/get-movies-ajax')
+        .with do |request|
+          request.body.include?('start_date=show_all_dates') &&
+            request.body.include?("cinema_id=#{cinema_id}")
+        end
+        .to_return(
+          status: 200,
+          body: '{"response":"success","movies":[]}',
+          headers: { 'Content-Type' => 'application/json' }
+        )
+
+      result = client.get_movies(cinema_id)
+
+      _(result).must_be_instance_of(Hash)
+      _(result['response']).must_equal 'success'
+    end
+
+    it 'accepts custom date parameter' do
+      stub_request(:post, 'https://www.picturehouses.com/api/get-movies-ajax')
+        .with do |request|
+          request.body.include?('start_date=2024-11-01') &&
+            request.body.include?("cinema_id=#{cinema_id}")
+        end
+        .to_return(
+          status: 200,
+          body: '{"response":"success","movies":[]}',
+          headers: { 'Content-Type' => 'application/json' }
+        )
+
+      result = client.get_movies(cinema_id, '2024-11-01')
+
+      _(result['response']).must_equal 'success'
+    end
+
+    it 'returns empty hash on HTTP error' do
+      stub_request(:post, 'https://www.picturehouses.com/api/get-movies-ajax')
+        .to_return(status: 500, body: 'Internal Server Error')
+
+      result = client.get_movies(cinema_id)
+
+      _(result).must_equal({})
+    end
+
+    it 'returns empty hash on network error' do
+      stub_request(:post, 'https://www.picturehouses.com/api/get-movies-ajax')
+        .to_raise(StandardError.new('Network error'))
+
+      result = client.get_movies(cinema_id)
+
+      _(result).must_equal({})
+    end
+
+    it 'parses JSON response' do
+      response_body = {
+        'response' => 'success',
+        'movies' => [
+          {
+            'Title' => 'Test Film',
+            'ScheduledFilmId' => '12345',
+            'movie_times' => []
+          }
+        ]
+      }.to_json
+
+      stub_request(:post, 'https://www.picturehouses.com/api/get-movies-ajax')
+        .to_return(
+          status: 200,
+          body: response_body,
+          headers: { 'Content-Type' => 'application/json' }
+        )
+
+      result = client.get_movies(cinema_id)
+
+      _(result).must_be_instance_of(Hash)
+      _(result['movies']).must_be_instance_of(Array)
+      _(result['movies'].first['Title']).must_equal 'Test Film'
+    end
+  end
+end

data/test/lib/picturehouse_uk/internal/parser/{address_parser_test.rb → address_test.rb}

@@ -12,13 +12,13 @@ describe PicturehouseUk::Internal::Parser::Address do
       let(:html) { nil }
 
       it 'returns hash of nils' do
-        subject.must_be_instance_of(Hash)
-        subject.must_equal(street_address:   nil,
+        _(subject).must_be_instance_of(Hash)
+        _(subject).must_equal(street_address:   nil,
                            extended_address: nil,
                            locality:         nil,
                            region:           nil,
                            postal_code:      nil,
-                           country:          "United Kingdom")
+                           country_name:     "United Kingdom")
       end
     end
 
@@ -26,13 +26,13 @@ describe PicturehouseUk::Internal::Parser::Address do
       let(:html) { '' }
 
       it 'returns hash of nils' do
-        subject.must_be_instance_of(Hash)
-        subject.must_equal(street_address:   nil,
+        _(subject).must_be_instance_of(Hash)
+        _(subject).must_equal(street_address:   nil,
                            extended_address: nil,
                            locality:         nil,
                            region:           nil,
                            postal_code:      nil,
-                           country:          "United Kingdom")
+                           country_name:     "United Kingdom")
       end
     end
 
@@ -40,13 +40,13 @@ describe PicturehouseUk::Internal::Parser::Address do
       let(:html) { 'not an address' }
 
       it 'returns hash of nils' do
-        subject.must_be_instance_of(Hash)
-        subject.must_equal(street_address:   nil,
+        _(subject).must_be_instance_of(Hash)
+        _(subject).must_equal(street_address:   nil,
                            extended_address: nil,
-                           locality:         "not an address",
+                           locality:         nil,
                            region:           nil,
-                           postal_code:      "not an address",
-                           country:          "United Kingdom")
+                           postal_code:      nil,
+                           country_name:     "United Kingdom")
       end
     end
   end

data/test/lib/picturehouse_uk/internal/parser/screenings_test.rb

@@ -2,71 +2,123 @@ require_relative '../../../../test_helper'
 
 describe PicturehouseUk::Internal::Parser::Screenings do
   let(:described_class) { PicturehouseUk::Internal::Parser::Screenings }
+  let(:api_client) { FakeApi.new }
 
-  let(:website) { Minitest::Mock.new }
+  before { WebMock.disable_net_connect! }
+  after { WebMock.allow_net_connect! }
 
-  before do
-    WebMock.disable_net_connect!
-  end
+  describe '#to_a' do
+    subject { described_class.new('duke-s-at-komedia').to_a }
 
-  %w(Duke_Of_Yorks Dukes_At_Komedia Phoenix_Picturehouse).each do |cinema|
-    describe "#{cinema}: #to_a" do
-      subject { described_class.new(cinema).to_a }
-
-      before { website.expect(:whats_on, html(cinema), [cinema]) }
-
-      it 'returns an non-zero array of hashes' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_be_instance_of(Array)
-          subject.size.must_be :>, 0
-
-          subject.each do |element|
-            element.must_be_instance_of(Hash)
-            element.keys.must_equal([:film_name, :dimension, :variant, :booking_url, :time])
-            element[:film_name].must_be_kind_of(String)
-            element[:dimension].must_match(/\A[23]d\z/)
-            if element[:booking_url]
-              element[:booking_url].must_match(/\Ahttps?\:\/\//)
-              element[:booking_url].must_match(/ticketing/)
-              element[:booking_url].must_match(/visSelectTickets\.aspx\?cinemacode=\d+\&txtSessionId=\d+/)
-            end
-            element[:time].must_be_kind_of(Time)
-          end
-
-          variants = subject.flat_map { |e| e[:variant] }.uniq
-          %w(arts baby senior).each do |expected| # also kids
-            variants.must_include(expected)
-          end
+    it 'returns an array of hashes' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        _(subject).must_be_instance_of(Array)
+        subject.each do |element|
+          _(element).must_be_instance_of(Hash)
         end
       end
     end
-  end
 
-  %w(National_Media_Museum).each do |cinema|
-    describe "#{cinema}: #to_a" do
-      subject { described_class.new(cinema).to_a }
+    it 'has correct hash keys' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        subject.each do |element|
+          _(element.keys.sort).must_equal([:booking_url, :dimension, :film_name, :starting_at, :variant].sort)
+        end
+      end
+    end
 
-      before { website.expect(:whats_on, html(cinema), [cinema]) }
+    it 'has valid film names' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        film_names = subject.map { |s| s[:film_name] }.uniq
+        _(film_names).must_include 'The Holdovers'
+        _(film_names).must_include 'The Marvels'
+      end
+    end
 
-      it 'returns an non-zero array of hashes with imax variants' do
-        PicturehouseUk::Internal::Website.stub :new, website do
-          subject.must_be_instance_of(Array)
-          subject.size.must_be :>, 0
+    it 'correctly identifies dimensions' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        subject.each do |element|
+          _(element[:dimension]).must_match(/\A[23]d\z/)
+        end
+      end
+    end
+
+    it 'generates booking URLs with correct format' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        subject.each do |element|
+          _(element[:booking_url]).must_match(%r{\Ahttps://web\.picturehouses\.com/order/showtimes/})
+          _(element[:booking_url]).must_match(%r{/duke-s-at-komedia-\d+/seats\z})
+        end
+      end
+    end
 
-          variants = subject.flat_map { |e| e[:variant] }.uniq
-          variants.must_include('imax')
+    it 'parses starting_at as Time objects' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        subject.each do |element|
+          _(element[:starting_at]).must_be_kind_of(Time)
+          _(element[:starting_at]).wont_equal Time.utc(1970, 1, 1, 0, 0)
         end
       end
     end
+
+    it 'extracts variant arrays' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        variants = subject.flat_map { |e| e[:variant] }.uniq
+        _(variants).must_include('kids')
+        _(variants).must_include('senior')
+        _(variants).must_include('arts')
+      end
+    end
+
+    it 'identifies 3D films from title' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        three_d_films = subject.select { |s| s[:dimension] == '3d' }
+        _(three_d_films).wont_be_empty
+        three_d_films.each do |screening|
+          _(screening[:film_name]).must_match(/Marvels/i)
+        end
+      end
+    end
+
+    it 'skips sold out screenings' do
+      PicturehouseUk::Internal::Api.stub :new, api_client do
+        # Our fixture has 9 total screenings but none with SoldoutStatus == 2
+        _(subject.count).must_equal 8
+      end
+    end
   end
 
-  private
+  describe 'with empty response' do
+    let(:empty_client) do
+      Class.new do
+        def get_movies(_cinema_id, _date = 'show_all_dates')
+          { 'response' => 'error', 'movies' => [] }
+        end
+      end.new
+    end
 
-  def read_file(filepath)
-    File.read(File.expand_path(filepath, __FILE__))
+    it 'returns empty array for error response' do
+      PicturehouseUk::Internal::Api.stub :new, empty_client do
+        result = described_class.new('nonexistent').to_a
+        _(result).must_equal []
+      end
+    end
   end
 
-  def html(cinema)
-    read_file("../../../../../fixtures/whats_on/#{cinema}.html")
+  describe 'with missing movies key' do
+    let(:missing_movies_client) do
+      Class.new do
+        def get_movies(_cinema_id, _date = 'show_all_dates')
+          { 'response' => 'success' }
+        end
+      end.new
+    end
+
+    it 'returns empty array when movies key missing' do
+      PicturehouseUk::Internal::Api.stub :new, missing_movies_client do
+        result = described_class.new('test').to_a
+        _(result).must_equal []
+      end
+    end
   end
 end