picky 4.19.4 → 4.19.5

data/spec/lib/query/indexes_check_spec.rb

@@ -11,7 +11,7 @@ describe Picky::Query::Indexes::Check do
     ]
     backends.each do |backend|
       it 'does not raise on the same type' do
-        index = stub :index, backend: backend
+        index = double :index, backend: backend
         described_class.check_backends [index, index]
       end
     end
@@ -20,8 +20,8 @@ describe Picky::Query::Indexes::Check do
     #
     combinations = backends.combination 2
     combinations.each do |backend1, backend2|
-      let(:index1) { stub :index1, backend: backend1 }
-      let(:index2) { stub :index2, backend: backend2 }
+      let(:index1) { double :index1, backend: backend1 }
+      let(:index2) { double :index2, backend: backend2 }
       it 'raises on multiple types' do
         expect do
           described_class.check_backends [index1, index2]
@@ -35,9 +35,9 @@ describe Picky::Query::Indexes::Check do
     end
     combinations = backends.combination 3
     combinations.each do |backend1, backend2, backend3|
-      let(:index1) { stub :index1, backend: backend1 }
-      let(:index2) { stub :index2, backend: backend2 }
-      let(:index3) { stub :index2, backend: backend3 }
+      let(:index1) { double :index1, backend: backend1 }
+      let(:index2) { double :index2, backend: backend2 }
+      let(:index3) { double :index2, backend: backend3 }
       it 'raises on multiple types' do
         expect do
           described_class.check_backends [index1, index2, index3]

data/spec/lib/query/indexes_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Picky::Query::Indexes do
 
   before(:each) do
-    Picky::Query::Indexes::Check.stub! :check_backends
+    Picky::Query::Indexes::Check.stub :check_backends
   end
 
   3.times do |i|
@@ -13,7 +13,7 @@ describe Picky::Query::Indexes do
 
   let(:indexes) do
     indexes = described_class.allocate
-    indexes.stub! :map_categories
+    indexes.stub :map_categories
     indexes.send :initialize, index1, index2, index3
     indexes
   end
@@ -87,20 +87,20 @@ describe Picky::Query::Indexes do
 
   describe 'prepared_allocations_for' do
     before(:each) do
-      @allocations = stub :allocations
-      indexes.stub! :allocations_for => @allocations
+      @allocations = double :allocations
+      indexes.stub :allocations_for => @allocations
     end
     it 'calls the right method in order' do
-      # @allocations.should_receive(:uniq!).once.ordered.with()
+      # @allocations.should_receive(:uniq!).once.ordered.with no_args
       @allocations.should_receive(:calculate_score).once.ordered.with(:some_weights)
-      @allocations.should_receive(:sort!).once.ordered.with()
+      @allocations.should_receive(:sort!).once.ordered.with no_args
 
       indexes.prepared_allocations_for :some_tokens, :some_weights
     end
     it 'calls the right method in order' do
-      # @allocations.should_receive(:uniq!).once.ordered.with()
+      # @allocations.should_receive(:uniq!).once.ordered.with no_args
       @allocations.should_receive(:calculate_score).once.ordered.with({})
-      @allocations.should_receive(:sort!).once.ordered.with()
+      @allocations.should_receive(:sort!).once.ordered.with no_args
 
       indexes.prepared_allocations_for :some_tokens
     end

data/spec/lib/query/solr_spec.rb

@@ -10,7 +10,7 @@
 #     describe 'execute' do
 #       context 'error cases' do
 #         before(:each) do
-#           @tokens = stub :tokens
+#           @tokens = double :tokens
 #         end
 #         context 'tokens are malformed' do
 # 
@@ -20,10 +20,10 @@
 #         end
 #         context 'server raises' do
 #           before(:each) do
-#             @server.stub! :select => lambda { raise Solr::RequestError }
+#             @server.stub :select => lambda { raise Solr::RequestError }
 #           end
 #           it 'should not fail' do
-#             @tokens.stub! :to_solr_query => ''
+#             @tokens.stub :to_solr_query => ''
 # 
 #             lambda { @server.execute(@tokens) }.should_not raise_error
 #           end
@@ -34,8 +34,8 @@
 # 
 #   context 'with connected Server' do
 #     before(:each) do
-#       @server = stub :server
-#       RSolr.stub! :connect => @server
+#       @server = double :server
+#       RSolr.stub :connect => @server
 #     end
 #   end
 # 

data/spec/lib/query/token_spec.rb

@@ -75,8 +75,8 @@ describe Picky::Query::Token do
     let(:token) { described_class.processed 'similar~', 'Similar~' }
     context 'with similar' do
       before(:each) do
-        @bundle   = stub :bundle, :similar => ['array', 'of', 'similar']
-        @category = stub :category, :bundle_for => @bundle
+        @bundle   = double :bundle, :similar => ['array', 'of', 'similar']
+        @category = double :category, :bundle_for => @bundle
       end
       it 'returns a list of tokens' do
         token.similar_tokens_for(@category).each do |token|
@@ -102,8 +102,8 @@ describe Picky::Query::Token do
     end
     context 'without similar' do
       before(:each) do
-        @bundle   = stub :bundle, :similar => []
-        @category = stub :category, :bundle_for => @bundle
+        @bundle   = double :bundle, :similar => []
+        @category = double :category, :bundle_for => @bundle
       end
       it 'returns an empty list' do
         token.similar_tokens_for(@category).should == []
@@ -375,12 +375,12 @@ describe Picky::Query::Token do
     it "should be blank if the token text itself is blank" do
       token = described_class.processed ''
 
-      token.blank?.should be_true
+      token.blank?.should be_truthy
     end
     it "should be non-blank if the token text itself is non-blank" do
       token = described_class.processed 'not empty'
 
-      token.blank?.should be_false
+      token.blank?.should be_falsy
     end
   end
 

data/spec/lib/query/tokens_spec.rb

@@ -19,9 +19,9 @@ describe Picky::Query::Tokens do
 
     describe 'possible_combinations_in' do
       before(:each) do
-        @token1 = stub :token1
-        @token2 = stub :token2
-        @token3 = stub :token3
+        @token1 = double :token1
+        @token2 = double :token2
+        @token3 = double :token3
 
         @tokens = described_class.new [@token1, @token2, @token3], true
       end
@@ -164,9 +164,9 @@ describe Picky::Query::Tokens do
 
   describe 'possible_combinations_in' do
     before(:each) do
-      @token1 = stub :token1
-      @token2 = stub :token2
-      @token3 = stub :token3
+      @token1 = double :token1
+      @token2 = double :token2
+      @token3 = double :token3
 
       @tokens = described_class.new [@token1, @token2, @token3]
     end
@@ -229,15 +229,15 @@ describe Picky::Query::Tokens do
   def self.it_should_forward name
     describe name do
       before(:each) do
-        @internal_tokens = mock :internal_tokens
+        @internal_tokens = double :internal_tokens
         @tokens = described_class.new @internal_tokens
       end
       it "should forward #{name} to the internal tokens" do
-        proc_stub = lambda {}
+        proc_double = lambda {}
 
-        @internal_tokens.should_receive(name).once.with &proc_stub
+        @internal_tokens.should_receive(name).once.with no_args, &proc_double
 
-        @tokens.send name, &proc_stub
+        @tokens.send name, &proc_double
       end
     end
   end

data/spec/lib/rack/harakiri_spec.rb

@@ -8,8 +8,8 @@ require 'picky/rack/harakiri'
 
 describe Rack::Harakiri do
   before(:each) do
-    @app = stub :app
-    Process.stub! :kill # not taking any chances
+    @app = double :app
+    Process.stub :kill # not taking any chances
   end
   context "defaults" do
     before(:each) do
@@ -44,11 +44,11 @@ describe Rack::Harakiri do
     end
     describe "call" do
       before(:each) do
-        @app.stub! :call
-        @app.stub! :harakiri
+        @app.stub :call
+        @app.stub :harakiri
       end
       it "calls harakiri" do
-        @ronin.should_receive(:harakiri).once.with
+        @ronin.should_receive(:harakiri).once.with no_args
 
         @ronin.call :env
       end

data/spec/lib/results/exact_first_spec.rb

@@ -3,9 +3,9 @@ require 'spec_helper'
 describe Picky::Results::ExactFirst do
 
   before(:each) do
-    @exact    = stub :exact
-    @partial  = stub :partial
-    @category = stub :category, :exact => @exact, :partial => @partial
+    @exact    = double :exact
+    @partial  = double :partial
+    @category = double :category, :exact => @exact, :partial => @partial
     @category.extend described_class
   end
 
@@ -37,71 +37,71 @@ describe Picky::Results::ExactFirst do
 
   describe 'ids' do
     it "uses first the exact, then the partial ids" do
-      @exact.stub!   :ids => [1,4,5,6]
-      @partial.stub! :ids => [2,3,7]
+      @exact.stub   :ids => [1,4,5,6]
+      @partial.stub :ids => [2,3,7]
 
-      @category.ids(stub(:token, :text => :anything, :partial? => true)).should == [1,4,5,6,2,3,7]
+      @category.ids(double(:token, :text => :anything, :partial? => true)).should == [1,4,5,6,2,3,7]
     end
     it "uses only the exact ids" do
-      @exact.stub!   :ids => [1,4,5,6]
-      @partial.stub! :ids => [2,3,7]
+      @exact.stub   :ids => [1,4,5,6]
+      @partial.stub :ids => [2,3,7]
 
-      @category.ids(stub(:token, :text => :anything, :partial? => false)).should == [1,4,5,6]
+      @category.ids(double(:token, :text => :anything, :partial? => false)).should == [1,4,5,6]
     end
   end
 
   describe 'weight' do
     context "exact with weight" do
       before(:each) do
-        @exact.stub! :weight => 0.12
+        @exact.stub :weight => 0.12
       end
       context "partial with weight" do
         before(:each) do
-          @partial.stub! :weight => 1.23
+          @partial.stub :weight => 1.23
         end
         it "uses the higher weight" do
-          @category.weight(stub(:token, :text => :anything, :partial? => true)).should == 1.23
+          @category.weight(double(:token, :text => :anything, :partial? => true)).should == 1.23
         end
         it "uses the exact weight" do
-          @category.weight(stub(:token, :text => :anything, :partial? => false)).should == 0.12
+          @category.weight(double(:token, :text => :anything, :partial? => false)).should == 0.12
         end
       end
       context "partial without weight" do
         before(:each) do
-          @partial.stub! :weight => nil
+          @partial.stub :weight => nil
         end
         it "uses the exact weight" do
-          @category.weight(stub(:token, :text => :anything, :partial? => true)).should == 0.12
+          @category.weight(double(:token, :text => :anything, :partial? => true)).should == 0.12
         end
         it "uses the exact weight" do
-          @category.weight(stub(:token, :text => :anything, :partial? => false)).should == 0.12
+          @category.weight(double(:token, :text => :anything, :partial? => false)).should == 0.12
         end
       end
     end
     context "exact without weight" do
       before(:each) do
-        @exact.stub! :weight => nil
+        @exact.stub :weight => nil
       end
       context "partial with weight" do
         before(:each) do
-          @partial.stub! :weight => 0.12
+          @partial.stub :weight => 0.12
         end
         it "uses the partial weight" do
-          @category.weight(stub(:token, :text => :anything, :partial? => true)).should == 0.12
+          @category.weight(double(:token, :text => :anything, :partial? => true)).should == 0.12
         end
         it "uses the exact weight" do
-          @category.weight(stub(:token, :text => :anything, :partial? => false)).should == nil
+          @category.weight(double(:token, :text => :anything, :partial? => false)).should == nil
         end
       end
       context "partial without weight" do
         before(:each) do
-          @partial.stub! :weight => nil
+          @partial.stub :weight => nil
         end
         it "is nil" do
-          @category.weight(stub(:token, :text => :anything, :partial? => true)).should == nil
+          @category.weight(double(:token, :text => :anything, :partial? => true)).should == nil
         end
         it "is nil" do
-          @category.weight(stub(:token, :text => :anything, :partial? => false)).should == nil
+          @category.weight(double(:token, :text => :anything, :partial? => false)).should == nil
         end
       end
     end

data/spec/lib/results_spec.rb

@@ -4,10 +4,10 @@ describe Picky::Results do
 
   describe "from" do
     before(:each) do
-      @results = stub :results
-      described_class.stub! :new => @results
+      @results = double :results
+      described_class.stub :new => @results
 
-      @results.stub! :prepare!
+      @results.stub :prepare!
     end
     it "should generate a result" do
       described_class.from("some query", 20, 0, @allocations).should == @results
@@ -16,7 +16,7 @@ describe Picky::Results do
 
   describe "ids" do
     before(:each) do
-      @allocations = stub :allocations
+      @allocations = double :allocations
       @results = described_class.new :unimportant, :amount, :unimportant, @allocations
     end
     it "forwards" do
@@ -40,8 +40,8 @@ describe Picky::Results do
 
   describe 'to_s' do
     before(:each) do
-      time = stub :time, :strftime => '2011-08-16 10:07:33'
-      Time.stub! :now => time
+      time = double :time, :strftime => '2011-08-16 10:07:33'
+      Time.stub :now => time
     end
     context 'without results' do
       before(:each) do
@@ -53,12 +53,12 @@ describe Picky::Results do
     end
     context 'with results' do
       before(:each) do
-        @allocations = stub :allocations,
+        @allocations = double :allocations,
                             :process! => nil,
                             :size => 12
 
         @results = described_class.new "some_query", 20, 1234, @allocations
-        @results.stub! :duration => 0.1234567890,
+        @results.stub :duration => 0.1234567890,
                        :total    => 12345678
       end
       it 'should output a specific log' do
@@ -72,7 +72,7 @@ describe Picky::Results do
       @results = described_class.new
     end
     it 'should do it correctly' do
-      @results.stub! :to_hash => :serialized
+      @results.stub :to_hash => :serialized
 
       @results.to_json.should == '"serialized"'
     end
@@ -80,7 +80,7 @@ describe Picky::Results do
 
   describe 'to_hash' do
     before(:each) do
-      @allocations = stub :allocations, :process! => nil, :to_result => :allocations, :total => :some_total
+      @allocations = double :allocations, :process! => nil, :to_result => :allocations, :total => :some_total
 
       @results = described_class.new :unimportant, :some_results_amount, :some_offset, @allocations
       @results.duration = :some_duration

data/spec/lib/scheduler_spec.rb

@@ -8,7 +8,7 @@ describe Picky::Scheduler do
 
     context 'without forking' do
       before(:each) do
-        scheduler.stub! :fork? => false
+        scheduler.stub :fork? => false
       end
       context 'non-stubbed forking' do
         it 'works correctly' do
@@ -33,15 +33,15 @@ describe Picky::Scheduler do
     describe 'fork?' do
       context 'OS can fork' do
         it 'returns false' do
-          scheduler.fork?.should be_false
+          scheduler.fork?.should be_falsy
         end
       end
       context 'OS cannot fork' do
         before(:each) do
-          Process.stub! :fork => nil
+          Process.stub :fork => nil
         end
         it 'returns false' do
-          scheduler.fork?.should be_false
+          scheduler.fork?.should be_falsy
         end
       end
     end
@@ -59,7 +59,7 @@ describe Picky::Scheduler do
         scheduler.schedule { sleep 0.01 }
       end
       it 'works correctly' do
-        scheduler.scheduler.should_receive(:schedule).any_number_of_times.and_yield
+        scheduler.scheduler.should_receive(:schedule).at_least(1).and_yield
 
         called = 0
 

data/spec/lib/search_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 describe Picky::Search do
 
   before(:each) do
-    @type      = stub :type
-    @index     = stub :some_index,
+    @type      = double :type
+    @index     = double :some_index,
                       :internal_indexed => @type,
                       :each_category    => [],
                       :backend          => Picky::Backends::Memory.new
@@ -15,8 +15,8 @@ describe Picky::Search do
   describe 'tokenized' do
     let(:search) { described_class.new }
     it 'forwards to the tokenizer' do
-      tokenizer = stub :tokenizer
-      search.stub! :tokenizer => tokenizer
+      tokenizer = double :tokenizer
+      search.stub :tokenizer => tokenizer
 
       tokenizer.should_receive(:tokenize).once.with(:some_text).and_return [['some_text'], [:some_original]]
 
@@ -55,7 +55,7 @@ describe Picky::Search do
       end
     end
     context 'tokenizer predefined' do
-      let(:predefined) { stub(:tokenizer, :tokenize => nil) }
+      let(:predefined) { double(:tokenizer, :tokenize => nil) }
       context 'by way of DSL' do
         let(:search) { pre = predefined; described_class.new { searching pre } }
         it 'returns the predefined tokenizer' do
@@ -89,28 +89,28 @@ describe Picky::Search do
       @search = described_class.new
     end
     it "forwards to search_with correctly" do
-      @search.stub! :tokenized => :tokens
+      @search.stub :tokenized => :tokens
 
       @search.should_receive(:search_with).once.with :tokens, 20, 10, :text, nil
 
       @search.search :text, 20, 10
     end
     it "forwards to search_with correctly" do
-      @search.stub! :tokenized => :tokens
+      @search.stub :tokenized => :tokens
 
       @search.should_receive(:search_with).once.with :tokens, 20, 0, :text, nil
 
       @search.search :text, 20, 0
     end
     it "forwards to search_with correctly" do
-      @search.stub! :tokenized => :tokens
+      @search.stub :tokenized => :tokens
 
       @search.should_receive(:search_with).once.with :tokens, 20, 0, :text, true
 
       @search.search :text, 20, 0, unique: true
     end
     it "uses the tokenizer" do
-      @search.stub! :search_with
+      @search.stub :search_with
 
       @search.should_receive(:tokenized).once.with :text
 
@@ -122,7 +122,7 @@ describe Picky::Search do
     let(:search) { described_class.new @index }
     context 'by default' do
       it 'is falsy' do
-        search.ignore_unassigned.should be_false
+        search.ignore_unassigned.should be_falsy
       end
     end
     context 'set to nothing' do
@@ -130,7 +130,7 @@ describe Picky::Search do
         search.ignore_unassigned_tokens
       end
       it 'is truey' do
-        search.ignore_unassigned.should be_true
+        search.ignore_unassigned.should be_truthy
       end
     end
     context 'set to true' do
@@ -138,7 +138,7 @@ describe Picky::Search do
         search.ignore_unassigned_tokens true
       end
       it 'is truey' do
-        search.ignore_unassigned.should be_true
+        search.ignore_unassigned.should be_truthy
       end
     end
     context 'set to false' do
@@ -146,7 +146,7 @@ describe Picky::Search do
         search.ignore_unassigned_tokens false
       end
       it 'is falsy' do
-        search.ignore_unassigned.should be_false
+        search.ignore_unassigned.should be_falsy
       end
     end
   end
@@ -154,7 +154,7 @@ describe Picky::Search do
   describe 'initializer' do
     context 'with tokenizer' do
       before(:each) do
-        tokenizer = stub :tokenizer, :tokenize => [['some_text'], ['some_original']]
+        tokenizer = double :tokenizer, :tokenize => [['some_text'], ['some_original']]
         @search = described_class.new @index do
           searching tokenizer
         end
@@ -167,7 +167,7 @@ describe Picky::Search do
 
   describe 'to_s' do
     before(:each) do
-      @index.stub! :name => :some_index, :each_category => []
+      @index.stub :name => :some_index, :each_category => []
     end
     context 'without indexes' do
       before(:each) do

data/spec/lib/solr/schema_generator_spec.rb

@@ -4,14 +4,14 @@
 # describe Solr::SchemaGenerator do
 # 
 #   before(:each) do
-#     @types = stub :types
-#     @configuration = stub :configuration, :types => @types
+#     @types = double :types
+#     @configuration = double :configuration, :types => @types
 #     @generator = Solr::SchemaGenerator.new @configuration
 #   end
 # 
 #   describe 'bound_field_names' do
 #     before(:each) do
-#       @generator.stub! :combine_field_names => :some_field_names
+#       @generator.stub :combine_field_names => :some_field_names
 #     end
 #     it 'should bind field_names' do
 #       b = @generator.bound_field_names
@@ -22,18 +22,18 @@
 # 
 #   describe 'generate' do
 #     before(:each) do
-#       @generator.stub! :bound_field_names
-#       @generator.stub! :generate_schema_for
+#       @generator.stub :bound_field_names
+#       @generator.stub :generate_schema_for
 #     end
 #     it 'should receive generate_schema_for once with the result of extract_binding' do
-#       @generator.stub! :bound_field_names => :some_binding
+#       @generator.stub :bound_field_names => :some_binding
 # 
 #       @generator.should_receive(:generate_schema_for).once.with :some_binding
 # 
 #       @generator.generate
 #     end
 #     it 'should extract the binding' do
-#       @generator.should_receive(:bound_field_names).once.with
+#       @generator.should_receive(:bound_field_names).once.with no_args
 # 
 #       @generator.generate
 #     end

data/spec/lib/tokenizer_spec.rb

@@ -110,7 +110,7 @@ ERROR
           expect { tokenizer.normalize_with_patterns('any') }.to_not raise_error
         end
         it 'should define a method normalize_with_patterns does nothing' do
-          unchanging = stub :unchanging
+          unchanging = double :unchanging
 
           tokenizer.normalize_with_patterns(unchanging).should == unchanging
         end
@@ -167,7 +167,7 @@ ERROR
 
     describe "splits_text_on" do
       it 'handles nonbroken arguments' do
-        expect { tokenizer.splits_text_on("hello") }.to_not raise_error(ArgumentError)
+        expect { tokenizer.splits_text_on("hello") }.to_not raise_error
       end
       it 'handles broken arguments' do
         expect { tokenizer.splits_text_on(:gnorf) }.to raise_error(ArgumentError)
@@ -220,7 +220,7 @@ ERROR
           expect { tokenizer.remove_illegals('any') }.to_not raise_error
         end
         it 'should define a method remove_illegals that does nothing' do
-          unchanging = stub :unchanging
+          unchanging = double :unchanging
 
           tokenizer.remove_illegals unchanging
         end