picky 4.19.4 → 4.19.5

data/spec/lib/category_indexed_spec.rb

@@ -6,19 +6,19 @@ describe Picky::Category do
     @index = Picky::Index.new :some_index do
       source []
     end
-    @partial_strategy    = stub :partial, :each_partial => nil, :use_exact_for_partial? => false
-    @weight_strategy     = stub :weights, :saved? => true, :weight_for => :some_weight
-    @similarity_strategy = stub :similarity, :encode => nil, :prioritize => nil
+    @partial_strategy    = double :partial, :each_partial => nil, :use_exact_for_partial? => false
+    @weight_strategy     = double :weights, :saved? => true, :weight_for => :some_weight
+    @similarity_strategy = double :similarity, :encode => nil, :prioritize => nil
 
-    @exact   = stub :exact, :dump => nil
-    @partial = stub :partial, :dump => nil
+    @exact   = double :exact, :dump => nil
+    @partial = double :partial, :dump => nil
 
     @category = described_class.new :some_name, @index, :partial    => @partial_strategy,
                                                         :weight     => @weight_strategy,
                                                         :similarity => @similarity_strategy,
                                                         :qualifiers => [:q, :qualifier]
 
-    @category.stub! :exclaim
+    @category.stub :exclaim
   end
 
   describe 'partial' do
@@ -28,7 +28,7 @@ describe Picky::Category do
       end
       context 'with a partial strategy that uses the exact index' do
         before(:each) do
-          @partial_strategy.stub! :use_exact_for_partial? => true
+          @partial_strategy.stub :use_exact_for_partial? => true
         end
         it 'returns the partial index' do
           @category.partial.should be_kind_of(Picky::Bundle)
@@ -49,7 +49,7 @@ describe Picky::Category do
       end
       context 'with a partial strategy that uses the exact index' do
         before(:each) do
-          @partial_strategy.stub! :use_exact_for_partial? => true
+          @partial_strategy.stub :use_exact_for_partial? => true
         end
         it 'returns the partial index' do
           @category.partial.should be_kind_of(Picky::Bundle)
@@ -64,14 +64,14 @@ describe Picky::Category do
   end
 
   describe 'weight' do
-    let(:token) { stub :token, :text => :some_text }
+    let(:token) { double :token, :text => :some_text }
     context 'without range' do
       before :each do
-        token.stub! :range => nil
+        token.stub :range => nil
       end
       context 'partial bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @partial
+          @category.stub :bundle_for => @partial
         end
         it 'should receive weight with the token text' do
           @partial.should_receive(:weight).once.with :some_text
@@ -81,7 +81,7 @@ describe Picky::Category do
       end
       context 'exact bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @exact
+          @category.stub :bundle_for => @exact
         end
         it 'should receive weight with the token text' do
           @exact.should_receive(:weight).once.with :some_text
@@ -92,11 +92,11 @@ describe Picky::Category do
     end
     context 'with range' do
       before :each do
-        token.stub! :range => [1, 3]
+        token.stub :range => [1, 3]
       end
       context 'partial bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @partial
+          @category.stub :bundle_for => @partial
         end
         it 'should receive weight with the token text' do
           @partial.should_receive(:weight).once.times.with(1).and_return(1)
@@ -115,7 +115,7 @@ describe Picky::Category do
       end
       context 'exact bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @exact
+          @category.stub :bundle_for => @exact
         end
         it 'should receive weight with the token text' do
           @exact.should_receive(:weight).once.times.with(1).and_return(1)
@@ -129,12 +129,12 @@ describe Picky::Category do
   end
 
   describe 'ids' do
-    let(:token) { stub :token, :text => :some_text }
+    let(:token) { double :token, :text => :some_text }
     context 'without range' do
-      before(:each) { token.stub! :range => nil }
+      before(:each) { token.stub :range => nil }
       context 'partial bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @partial
+          @category.stub :bundle_for => @partial
         end
         it 'should receive ids with the token text' do
           @partial.should_receive(:ids).once.with :some_text
@@ -144,7 +144,7 @@ describe Picky::Category do
       end
       context 'exact bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @exact
+          @category.stub :bundle_for => @exact
         end
         it 'should receive ids with the token text' do
           @exact.should_receive(:ids).once.with :some_text
@@ -154,10 +154,10 @@ describe Picky::Category do
       end
     end
     context 'with range' do
-      before(:each) { token.stub! :range => [1, 3] }
+      before(:each) { token.stub :range => [1, 3] }
       context 'partial bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @partial
+          @category.stub :bundle_for => @partial
         end
         it 'should receive ids with the token text' do
           @partial.should_receive(:ids).once.with(1).and_return [1]
@@ -169,7 +169,7 @@ describe Picky::Category do
       end
       context 'exact bundle' do
         before(:each) do
-          @category.stub! :bundle_for => @exact
+          @category.stub :bundle_for => @exact
         end
         it 'should receive ids with the token text' do
           @exact.should_receive(:ids).once.with(1).and_return [1]
@@ -185,7 +185,7 @@ describe Picky::Category do
   # describe 'combination_for' do
   #   context 'no weight for token' do
   #     before(:each) do
-  #       @category.stub! :weight => nil
+  #       @category.stub :weight => nil
   #     end
   #     it 'should return nil' do
   #       @category.combination_for(:anything).should == nil
@@ -193,8 +193,8 @@ describe Picky::Category do
   #   end
   #   context 'weight for token' do
   #     before(:each) do
-  #       @token = stub :token, :text => :some_text
-  #       @category.stub! :weight => :some_weight, :bundle_for => :bundle
+  #       @token = double :token, :text => :some_text
+  #       @category.stub :weight => :some_weight, :bundle_for => :bundle
   #     end
   #     it 'should return a new combination' do
   #       @category.combination_for(@token).should be_kind_of(Picky::Query::Combination)
@@ -209,8 +209,8 @@ describe Picky::Category do
 
   context 'stubbed exact/partial' do
     before(:each) do
-      @category.stub! :exact => (@exact = stub :exact)
-      @category.stub! :partial => (@partial = stub :partial)
+      @category.stub :exact => (@exact = double :exact)
+      @category.stub :partial => (@partial = double :partial)
     end
 
     describe 'load' do

data/spec/lib/category_indexing_spec.rb

@@ -4,9 +4,9 @@ describe Picky::Category do
 
   before(:each) do
     @index  = Picky::Index.new :some_index
-    @source = stub :some_given_source, :each => nil
+    @source = double :some_given_source, :each => nil
   end
-  let(:category) { described_class.new(:some_category, @index, :source => @source).tap { |c| c.stub! :timed_exclaim } }
+  let(:category) { described_class.new(:some_category, @index, :source => @source).tap { |c| c.stub :timed_exclaim } }
 
   context "unit specs" do
     let(:exact) { category.exact }
@@ -14,8 +14,8 @@ describe Picky::Category do
 
     describe 'clear' do
       it 'forwards to both bundles' do
-        exact.should_receive(:clear).once.with()
-        partial.should_receive(:clear).once.with()
+        exact.should_receive(:clear).once.with no_args
+        partial.should_receive(:clear).once.with no_args
 
         category.clear
       end
@@ -23,16 +23,16 @@ describe Picky::Category do
 
     describe 'dump' do
       before(:each) do
-        exact.stub! :dump
-        partial.stub! :dump
+        exact.stub :dump
+        partial.stub :dump
       end
       it 'should dump the exact index' do
-        exact.should_receive(:dump).once.with
+        exact.should_receive(:dump).once.with no_args
 
         category.dump
       end
       it 'should dump the partial index' do
-        partial.should_receive(:dump).once.with
+        partial.should_receive(:dump).once.with no_args
 
         category.dump
       end
@@ -40,9 +40,9 @@ describe Picky::Category do
 
     describe 'cache' do
       it 'should call multiple methods in order' do
-        category.should_receive(:empty).once.with().ordered
-        category.should_receive(:retrieve).once.with().ordered
-        category.should_receive(:dump).once.with().ordered
+        category.should_receive(:empty).once.with(no_args).ordered
+        category.should_receive(:retrieve).once.with(no_args).ordered
+        category.should_receive(:dump).once.with(no_args).ordered
 
         category.cache
       end
@@ -50,14 +50,14 @@ describe Picky::Category do
 
     describe 'retrieve' do
       it 'call the right thing' do
-        prepared = stub :prepared
-        prepared.should_receive(:retrieve).any_number_of_times
+        prepared = double :prepared
+        prepared.should_receive(:retrieve).at_least(1)
                                           .and_yield(1, :some_token)
                                           .and_yield(2, :some_token)
                                           .and_yield(3, :some_token)
                                           .and_yield(4, :some_token)
                                           .and_yield(5, :some_token)
-        category.stub! :prepared => prepared
+        category.stub :prepared => prepared
 
         category.should_receive(:add_tokenized_token).once.with(1, :some_token, :<<, nil)
         category.should_receive(:add_tokenized_token).once.with(2, :some_token, :<<, nil)
@@ -84,7 +84,7 @@ describe Picky::Category do
         end
         context 'it has an index' do
           before(:each) do
-            category.instance_variable_set :@index, stub(:index, :key_format => :yet_another_key_format)
+            category.instance_variable_set :@index, double(:index, :key_format => :yet_another_key_format)
           end
           it 'returns that key_format' do
             category.key_format.should == :yet_another_key_format
@@ -101,7 +101,7 @@ describe Picky::Category do
         end
       end
       context 'without explicit source' do
-        let(:category) { described_class.new(:some_category, @index.tap{ |index| index.stub! :source => :index_source }) }
+        let(:category) { described_class.new(:some_category, @index.tap{ |index| index.stub :source => :index_source }) }
         it 'returns the right source' do
           category.source.should == :index_source
         end
@@ -110,8 +110,8 @@ describe Picky::Category do
 
     describe "index" do
       before(:each) do
-        @indexer = stub :indexer, :index => nil
-        category.stub! :indexer => @indexer
+        @indexer = double :indexer, :index => nil
+        category.stub :indexer => @indexer
       end
       it "tells the indexer to index" do
         @indexer.should_receive(:prepare).once

data/spec/lib/extensions/module_spec.rb

@@ -16,7 +16,7 @@ describe Module do
         end
       end
       it 'should send each a bli' do
-        bli = stub :bli
+        bli = double :bli
         delegating = klass.new [bli, bli, bli, bli]
 
         bli.should_receive(:bli).exactly(4).times
@@ -49,7 +49,7 @@ describe Module do
         end
       end
       it 'should send each a bli' do
-        bli = stub :bli
+        bli = double :bli
         delegating = klass.new bli
 
         bli.should_receive(:bli).exactly(1).times

data/spec/lib/extensions/object_spec.rb

@@ -9,7 +9,7 @@ describe Object do
 
     describe "timed_exclaim" do
       it "should exclaim right" do
-        Time.stub! :now => Time.parse('07-03-1977 12:34:56')
+        Time.stub :now => Time.parse('07-03-1977 12:34:56')
         object.should_receive(:exclaim).once.with "12:34:56: bla"
 
         object.timed_exclaim 'bla'

data/spec/lib/generators/partial/default_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Picky::Generators::Partial::Default do
+describe 'Picky::Generators::Partial::Default' do
   
   let(:default) { Picky::Generators::Partial::Default }
   

data/spec/lib/generators/partial/postfix_spec.rb

@@ -6,8 +6,8 @@ describe Picky::Generators::Partial::Postfix do
     let(:generator) { described_class.new }
 
     describe 'use_exact_for_partial?' do
-      it 'returns false' do
-        described_class.new.use_exact_for_partial?.should == false
+      it 'is correct' do
+        generator.use_exact_for_partial?.should be_falsy
       end
     end
     describe 'from' do

data/spec/lib/generators/similarity/phonetic_spec.rb

@@ -9,7 +9,7 @@ describe Picky::Generators::Similarity::Phonetic do
   it "raises when you don't have the text gem" do
     instance = Class.new(described_class).allocate
 
-    instance.should_receive(:require).any_number_of_times.and_raise LoadError
+    instance.should_receive(:require).at_least(1).and_raise LoadError
     
     Picky.logger.should_receive(:warn).once.with <<-EXPECTED
 Warning: text gem missing!

data/spec/lib/index_indexed_spec.rb

@@ -21,18 +21,18 @@ describe Picky::Index do
 
   context "with stubbed categories" do
     before(:each) do
-      @categories = stub :categories
+      @categories = double :categories
 
       @index = described_class.new :some_name
       @index.category :some_category_name1
       @index.category :some_category_name2
 
-      @index.stub! :categories => @categories
+      @index.stub :categories => @categories
     end
 
     describe "load" do
       it "forwards to each category" do
-        @categories.should_receive(:load).once.with
+        @categories.should_receive(:load).once.with no_args
 
         @index.load
       end

data/spec/lib/index_indexing_spec.rb

@@ -4,7 +4,7 @@ describe Picky::Index do
 
   describe 'tokenizer' do
     context 'with tokenizer' do
-      let(:tokenizer) { stub :tokenizer, :tokenize => '' }
+      let(:tokenizer) { double :tokenizer, :tokenize => '' }
       let(:index) do
         the_tokenizer = tokenizer
         described_class.new :some_name do
@@ -59,7 +59,7 @@ describe Picky::Index do
       end
 
       it 'does things in order' do
-        scheduler = stub :scheduler, :fork? => false, :finish => nil
+        scheduler = double :scheduler, :fork? => false, :finish => nil
 
         index.should_receive(:prepare).once.with(scheduler).ordered
         index.should_receive(:cache).once.with(scheduler).ordered
@@ -69,7 +69,7 @@ describe Picky::Index do
     end
     context 'with non#each source' do
       it 'raises' do
-        the_source = stub :source, :harvest => nil
+        the_source = double :source, :harvest => nil
         expect {
           described_class.new :some_name do
             source the_source
@@ -94,7 +94,7 @@ ERROR
     end
     describe 'source' do
       it 'can be set with this method' do
-        source = stub :source, :each => [].each
+        source = double :source, :each => [].each
 
         @index.source source
 
@@ -111,7 +111,7 @@ ERROR
       end
       context 'with categories' do
         before(:each) do
-          @index.category :some_name, :source => stub(:source)
+          @index.category :some_name, :source => double(:source)
         end
         it 'returns it if found' do
           @index[:some_name].should_not == nil

data/spec/lib/index_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 describe Picky::Index do
 
-  let(:some_source) { stub :source, :each => nil, :inspect => 'some_source' }
+  let(:some_source) { double :source, :each => nil, :inspect => 'some_source' }
 
   context 'initializer' do
     it 'works' do
@@ -24,7 +24,7 @@ describe Picky::Index do
       expect { described_class.new :some_index_name do source { [] } end }.to_not raise_error
     end
     it 'evaluates the source every time' do
-      expector = stub :expector
+      expector = double :expector
 
       data = described_class.new :some_index_name do
         source do
@@ -32,7 +32,7 @@ describe Picky::Index do
         end
       end
 
-      expector.should_receive(:call).twice.with()
+      expector.should_receive(:call).twice.with no_args
 
       data.prepare
     end

data/spec/lib/indexed/wrappers/bundle/calculation_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Picky::Wrappers::Bundle::Calculation do
 
   before(:each) do
-    @bundle = stub :bundle
+    @bundle = double :bundle
     @calculation = described_class.new @bundle
   end
 

data/spec/lib/indexed/wrappers/bundle/wrapper_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Picky::Wrappers::Bundle::Wrapper do
 
   before(:each) do
-    @bundle = stub :bundle
+    @bundle = double :bundle
 
     @calculation = described_class.new @bundle
   end

data/spec/lib/indexers/base_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Picky::Indexers::Base do
 
-  let(:some_index_or_category) { stub :some_index_or_category, :name => 'some_index_or_category' }
+  let(:some_index_or_category) { double :some_index_or_category, :name => 'some_index_or_category' }
   let(:indexer) { described_class.new some_index_or_category }
 
   describe 'index_or_category' do
@@ -13,14 +13,14 @@ describe Picky::Indexers::Base do
 
   describe 'source' do
     it 'forwards it to the index or category' do
-      some_index_or_category.should_receive(:source).once.with
+      some_index_or_category.should_receive(:source).once.with no_args
 
       indexer.source
     end
     it 'raises when none is there' do
-      some_index_or_category.should_receive(:source).any_number_of_times.and_return nil
+      some_index_or_category.should_receive(:source).at_least(1).and_return nil
 
-      indexer.stub! :process
+      indexer.stub :process
 
       expect {
         indexer.prepare Picky::Categories.new
@@ -30,19 +30,19 @@ describe Picky::Indexers::Base do
 
   describe 'prepare' do
     before(:each) do
-      some_index_or_category.should_receive(:source).any_number_of_times.and_return :some_source
+      some_index_or_category.should_receive(:source).at_least(1).and_return :some_source
     end
     it 'processes' do
-      categories = stub :categories, :empty => nil, :cache => nil
+      categories = double :categories, :empty => nil, :cache => nil
 
       indexer.should_receive(:process).once.with :some_source, categories, anything
 
       indexer.prepare categories
     end
     it 'calls the right methods on the categories' do
-      indexer.stub! :process
+      indexer.stub :process
 
-      categories = stub :categories
+      categories = double :categories
 
       categories.should_receive(:empty).once.ordered
 

data/spec/lib/indexers/parallel_spec.rb

@@ -5,9 +5,9 @@ describe Picky::Indexers::Parallel do
   thing = Struct.new :id, :text
 
   before(:each) do
-    @index = Picky::Index.new(:test) # stub :index, :name => :some_index, :source => @source, :backend => stub(:backend)
+    @index = Picky::Index.new(:test) # double :index, :name => :some_index, :source => @source, :backend => double(:backend)
     @indexer = described_class.new @index
-    @indexer.stub! :timed_exclaim
+    @indexer.stub :timed_exclaim
   end
   
   context 'with untokenized category' do
@@ -24,8 +24,8 @@ describe Picky::Indexers::Parallel do
 
     describe 'flush' do
       it 'flushes to joined cache to the file and clears it' do
-        cache = stub :cache
-        file  = stub :file
+        cache = double :cache
+        file  = double :file
 
         cache.should_receive(:join).once.and_return :joined
         file.should_receive(:write).once.with(:joined).and_return :joined
@@ -59,8 +59,8 @@ describe Picky::Indexers::Parallel do
 
     describe 'flush' do
       it 'flushes to joined cache to the file and clears it' do
-        cache = stub :cache
-        file  = stub :file
+        cache = double :cache
+        file  = double :file
 
         cache.should_receive(:join).once.and_return :joined
         file.should_receive(:write).once.with(:joined).and_return :joined

data/spec/lib/indexers/serial_spec.rb

@@ -3,15 +3,15 @@ require 'spec_helper'
 describe Picky::Indexers::Serial do
 
   before(:each) do
-    @tokenizer = stub :tokenizer
-    @source  = stub :source
-    @category  = stub :category,
+    @tokenizer = double :tokenizer
+    @source  = double :source
+    @category  = double :category,
                       :identifier => :some_identifier,
                       :tokenizer => @tokenizer,
                       :source => @source
 
     @indexer = described_class.new @category
-    @indexer.stub! :timed_exclaim
+    @indexer.stub :timed_exclaim
   end
 
   describe "source" do

data/spec/lib/indexes_class_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Picky::Indexes do
 
   before(:each) do
-    @index   = stub :some_index, :name => :some_index
+    @index   = double :some_index, :name => :some_index
     @indexes = described_class.instance
   end
 

data/spec/lib/indexes_indexed_spec.rb

@@ -15,8 +15,8 @@ describe Picky::Indexes do
   describe 'methods' do
     let(:indexes) { described_class.new }
     before(:each) do
-      @index1 = stub :index1, :name => :index1
-      @index2 = stub :index2, :name => :index2
+      @index1 = double :index1, :name => :index1
+      @index2 = double :index2, :name => :index2
       indexes.register @index1
       indexes.register @index2
     end
@@ -50,8 +50,8 @@ describe Picky::Indexes do
     end
     describe 'load' do
       it 'calls load on each in order' do
-        @index1.should_receive(:load).once.with.ordered
-        @index2.should_receive(:load).once.with.ordered
+        @index1.should_receive(:load).once.with(no_args).ordered
+        @index2.should_receive(:load).once.with(no_args).ordered
 
         indexes.load
       end

data/spec/lib/indexes_indexing_spec.rb

@@ -14,14 +14,14 @@ describe Picky::Indexes do
   describe 'methods' do
     let(:indexes) { described_class.new }
     before(:each) do
-      @index1 = stub :index1, :name => :index1
-      @index2 = stub :index2, :name => :index2
+      @index1 = double :index1, :name => :index1
+      @index2 = double :index2, :name => :index2
       indexes.register @index1
       indexes.register @index2
     end
     describe 'index' do
       it 'prepares and caches each' do
-        scheduler = stub :scheduler, :fork? => false, :finish => nil
+        scheduler = double :scheduler, :fork? => false, :finish => nil
 
         @index1.should_receive(:prepare).once.with(scheduler).ordered
         @index2.should_receive(:prepare).once.with(scheduler).ordered
@@ -47,8 +47,8 @@ describe Picky::Indexes do
     def self.it_forwards_each name
       describe name do
         it "calls #{name} on each in order" do
-          @index1.should_receive(name).once.with.ordered
-          @index2.should_receive(name).once.with.ordered
+          @index1.should_receive(name).once.with(no_args).ordered
+          @index2.should_receive(name).once.with(no_args).ordered
 
           indexes.send name
         end

data/spec/lib/indexes_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 describe Picky::Indexes do
 
-  let(:index) { stub :some_index,   :name => :some_index }
-  let(:index2) { stub :some_index2, :name => :some_index }
+  let(:index) { double :some_index,   :name => :some_index }
+  let(:index2) { double :some_index2, :name => :some_index }
 
   context 'with instance' do
     let(:indexes) { Picky::Indexes.new }