pennmarc 1.0.30 → 1.0.32

data/lib/pennmarc/helpers/genre.rb

@@ -8,7 +8,7 @@ module PennMARC
       # Genre values for searching. We're less picky about what is included here to enable discovery via any included
       # 655 data.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of genre values for search
       def search(record)
         record.fields('655').map { |field|
@@ -26,7 +26,7 @@ module PennMARC
       # @todo subfields e and w do not appear in the documentation for 655, but we give them special consideration here,
       #       what gives?
       # @note legacy method returns a link object
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of genre values for display
       def show(record)
         record.fields(%w[655 880]).filter_map { |field|
@@ -46,7 +46,7 @@ module PennMARC
       # Genre values for faceting. We only set Genre facet values for movies (videos) and manuscripts(?)
       # @todo the Genre facet in Franklin is pretty ugly. It could be cleaned up by limiting the subfields included
       #       here and cleaning up punctuation.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def facet(record)
         format_code = record.leader[6] || ' '
@@ -61,8 +61,8 @@ module PennMARC
 
       private
 
-      # @param [MARC::DataField] field
-      # @return [TrueClass, FalseClass]
+      # @param field [MARC::DataField]
+      # @return [Boolean]
       def allowed_genre_field?(field)
         field.indicator2.in?(%w[0 4]) || subfield_value_in?(field, '2', PennMARC::HeadingControl::ALLOWED_SOURCE_CODES)
       end

data/lib/pennmarc/helpers/identifier.rb

@@ -6,7 +6,7 @@ module PennMARC
     class << self
       # Get Alma MMS ID value
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [String]
       def mmsid(record)
         record.fields('001').first.value
@@ -16,7 +16,7 @@ module PennMARC
       # {https://www.oclc.org/bibformats/en/0xx/020.html 020 field}, and subfield 'a', 'l', and 'z' of the
       # the {https://www.oclc.org/bibformats/en/0xx/020.html 022 field}.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def isxn_search(record)
         record.fields(%w[020 022]).filter_map { |field|
@@ -31,7 +31,7 @@ module PennMARC
       # Get ISBN values for display from the {https://www.oclc.org/bibformats/en/0xx/020.html 020 field}
       # and related {https://www.oclc.org/bibformats/en/8xx/880.html 880 field}.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def isbn_show(record)
         values = record.fields('020').filter_map do |field|
@@ -45,7 +45,7 @@ module PennMARC
       # Get ISSN values for display from the {https://www.oclc.org/bibformats/en/0xx/022.html 022 field} and related
       # {https://www.oclc.org/bibformats/en/8xx/880.html 880 field}.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def issn_show(record)
         values = record.fields('022').filter_map do |field|
@@ -58,7 +58,7 @@ module PennMARC
 
       # Get numeric OCLC ID of first {https://www.oclc.org/bibformats/en/0xx/035.html 035 field}
       # with an OCLC ID defined in subfield 'a'.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [String, nil]
       def oclc_id_show(record)
         ids = Array.wrap(record.fields('035')
@@ -81,7 +81,7 @@ module PennMARC
 
       # Retrieve valid and invalid numeric OCLC IDs from {https://www.oclc.org/bibformats/en/0xx/035.html 035 field}
       # for search.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def oclc_id_search(record)
         record.fields('035').flat_map { |field|
@@ -108,7 +108,7 @@ module PennMARC
       # {https://www.oclc.org/bibformats/en/8xx/880.html 880 field}. We do not return DOI values stored in 024 ǂ2,
       # see {PennMARC::Identifier.doi_show} for parsing DOI values.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<string>]
       def publisher_number_show(record)
         record.fields(%w[024 028 880]).filter_map { |field|
@@ -126,7 +126,7 @@ module PennMARC
       # Get publisher issued identifiers for searching of a record. Values extracted from fields
       # {https://www.oclc.org/bibformats/en/0xx/024.html 024} and {https://www.oclc.org/bibformats/en/0xx/028.html 028}.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def publisher_number_search(record)
         record.fields(%w[024 028]).filter_map { |field|
@@ -136,7 +136,7 @@ module PennMARC
       end
 
       # Retrieve fingerprint for display from the {https://www.oclc.org/bibformats/en/0xx/026.html 026} field
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def fingerprint_show(record)
         record.fields('026').map { |field|
@@ -146,7 +146,7 @@ module PennMARC
 
       # Retrieve DOI values stored in {https://www.oclc.org/bibformats/en/0xx/024.html 024}.
       # Penn MARC records give the first indicator a value of '7' and ǂ2 a value of 'doi' to denote that ǂa is a doi.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def doi_show(record)
         record.fields('024').filter_map { |field|
@@ -161,7 +161,7 @@ module PennMARC
 
       # Gets any Host record MMS ID values from an Enriched::Pub::RELATED_RECORD_TAG field added during Alma enrichment.
       # This aids in our handling of "bound with" records.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def host_record_id(record)
         record.fields(Enriched::Pub::RELATED_RECORD_TAGS).filter_map { |field|
@@ -175,19 +175,19 @@ module PennMARC
 
       # Determine if subfield 'a' is an OCLC id.
       #
-      # @param [MARC::Subfield]
-      # @return [TrueClass, FalseClass]
+      # @param subfield [MARC::Subfield]
+      # @return [Boolean]
       def subfield_a_is_oclc?(subfield)
         subfield.code == 'a' && subfield_is_oclc?(subfield)
       end
 
-      # @param [MARC::Subfield]
-      # @return [TrueClass, FalseClass]
+      # @param subfield [MARC::Subfield]
+      # @return [Boolean]
       def subfield_is_oclc?(subfield)
         (subfield.value =~ /^\(OCoLC\).*/).present?
       end
 
-      # @param [MARC::Subfield]
+      # @param subfield [MARC::Subfield]
       # @return [MatchData, nil]
       def match_oclc_number(subfield)
         /^\s*\(OCoLC\)[^1-9]*([1-9][0-9]*).*$/.match(subfield.value)
@@ -197,8 +197,8 @@ module PennMARC
       # Converts ISBN10 (ten-digit) to validated ISBN13 (thirteen-digit) and returns both values. If passed
       # ISBN13 parameter, only returns validated ISBN13 value.
       #
-      #  @param [String] isbn
-      #  @return [Array<String, String>, nil]
+      # @param isbn [String]
+      # @return [Array<String, String>, nil]
       def normalize_isbn(isbn)
         StdNum::ISBN.allNormalizedValues(isbn)
       end

data/lib/pennmarc/helpers/inventory.rb

@@ -18,7 +18,7 @@ module PennMARC
 
     class << self
       # Hash of Physical holdings information
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array, nil]
       def physical(record)
         source = enrichment_source(record)
@@ -30,7 +30,7 @@ module PennMARC
       end
 
       # Hash of Electronic inventory information
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array, nil]
       def electronic(record)
         source = enrichment_source(record)
@@ -42,14 +42,14 @@ module PennMARC
       end
 
       # Count of all electronic portfolios
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Integer]
       def electronic_portfolio_count(record)
         record.count { |field| field.tag.in? %w[AVE prt] }
       end
 
       # Count of all physical holdings
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Integer]
       def physical_holding_count(record)
         record.count { |field| field.tag.in? %w[AVA hld] }
@@ -58,7 +58,7 @@ module PennMARC
       private
 
       # Determine the source of the MARC inventory enrichment
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Symbol, nil]
       def enrichment_source(record)
         if pub_enrichment_tags?(record)
@@ -70,7 +70,7 @@ module PennMARC
 
       # Does the record include tags from Publishing inventory enrichment?
       # @todo move to Util?
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Boolean]
       def pub_enrichment_tags?(record)
         record.tags.intersect?(
@@ -80,7 +80,7 @@ module PennMARC
 
       # Does the record include tags from API inventory enrichment?
       # @todo move to Util?
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Boolean]
       def api_enrichment_tags?(record)
         record.tags.intersect?(

data/lib/pennmarc/helpers/inventory_entry/base.rb

@@ -6,8 +6,8 @@ module PennMARC
     class Base
       attr_reader :source, :field, :mapper
 
-      # @param [MARC::DataField] inventory_field
-      # @param [Symbol] source
+      # @param inventory_field [MARC::DataField]
+      # @param source [Symbol]
       def initialize(inventory_field, source)
         @source = source
         @field = inventory_field

data/lib/pennmarc/helpers/language.rb

@@ -12,7 +12,7 @@ module PennMARC
     class << self
       # Get language values for display from the {https://www.oclc.org/bibformats/en/5xx/546.html 546 field} and
       # related 880.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] language values and notes
       def show(record)
         values = record.fields('546').map do |field|
@@ -31,9 +31,9 @@ module PennMARC
       #   multilingual items, items that involve translation, and items where the medium of communication is a sign
       #   language. https://www.loc.gov/marc/bibliographic/bd041.html
       #
-      # @param [MARC::Record] record
-      # @param [Hash] iso_639_2_mapping iso-639-2 spec hash for language code translation
-      # @param [Hash] iso_639_3_mapping iso-639-3 spec hash for language code translation
+      # @param record [MARC::Record]
+      # @param iso_639_2_mapping [Hash] iso-639-2 spec hash for language code translation
+      # @param iso_639_3_mapping [Hash] iso-639-3 spec hash for language code translation
       # @return [Array<String>] array of language values
       def values(record, iso_639_2_mapping: Mappers.iso_639_2_language, iso_639_3_mapping: Mappers.iso_639_3_language)
         values = record.fields('041').filter_map { |field|

data/lib/pennmarc/helpers/link.rb

@@ -6,12 +6,12 @@ module PennMARC
     class << self
       # @todo the legacy code here is a hot mess for a number of reasons, what do we need this field to do?
       # @note port the needed parts from get_offsite_display, don't return HTML
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Object]
       def offsite(record); end
 
       # Full text links from MARC 856 fields.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array] array of hashes
       def full_text_links(record)
         indicator2_options = %w[0 1]
@@ -19,7 +19,7 @@ module PennMARC
       end
 
       # Web text links from MARC 856 fields.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array] array of hashes
       def web_links(record)
         indicator2_options = ['2', ' ', '']
@@ -30,7 +30,7 @@ module PennMARC
 
       # Extract subfield 3 and z/y depending on the presence of either. Extract link url and assemble array
       # with text and link.
-      # @param [MARC::Field] field
+      # @param field [MARC::Field]
       # @return [Array]
       def link_text_and_url(field)
         subfield3 = subfield_values(field, 3)
@@ -42,8 +42,8 @@ module PennMARC
 
       # Assemble array of link text, link URL values from 856 fields. Ensure indicator1 (access method)
       # is always 4 (HTTP) and indicator2 (relationship) can be specified by caller method.
-      # @param [MARC::Record] record
-      # @param [Array] indicator2_options
+      # @param record [MARC::Record]
+      # @param indicator2_options [Array]
       # @return [Array]
       def links_from_record(record, indicator2_options)
         record.fields('856').filter_map do |field|

data/lib/pennmarc/helpers/location.rb

@@ -12,8 +12,8 @@ module PennMARC
       # {PennMARC::Enriched} maps enriched marc fields and subfields created during Alma publishing.
       # @see https://developers.exlibrisgroup.com/alma/apis/docs/bibs/R0VUIC9hbG1hd3MvdjEvYmlicy97bW1zX2lkfQ==/
       #   Alma documentation for these added fields
-      # @param [MARC::Record] record
-      # @param [Hash] location_map hash with location_code as key and location hash as value
+      # @param record [MARC::Record]
+      # @param location_map [Hash] hash with location_code as key and location hash as value
       # @return [Array<String>] Array of library locations retrieved from location_map
       def library(record, location_map: Mappers.location)
         location(record: record, location_map: location_map, display_value: 'library')
@@ -25,8 +25,8 @@ module PennMARC
       # {PennMARC::Enriched} maps enriched marc fields and subfields created during Alma publishing.
       # @see https://developers.exlibrisgroup.com/alma/apis/docs/bibs/R0VUIC9hbG1hd3MvdjEvYmlicy97bW1zX2lkfQ==/
       #   Alma documentation for these added fields
-      # @param [MARC::Record] record
-      # @param [Hash] location_map hash with location_code as key and location hash as value
+      # @param record [MARC::Record]
+      # @param location_map [Hash] hash with location_code as key and location hash as value
       # @return [Array<String>] Array of specific locations retrieved from location_map
       def specific_location(record, location_map: Mappers.location)
         location(record: record, location_map: location_map, display_value: 'specific_location')
@@ -37,9 +37,9 @@ module PennMARC
       # {PennMARC::Enriched} maps enriched marc fields and subfields created during Alma publishing.
       # @see https://developers.exlibrisgroup.com/alma/apis/docs/bibs/R0VUIC9hbG1hd3MvdjEvYmlicy97bW1zX2lkfQ==/
       #   Alma documentation for these added fields
-      # @param [MARC::Record] record
-      # @param [Symbol | String] display_value field in location hash to retrieve
-      # @param [Hash] location_map hash with location_code as key and location hash as value
+      # @param record [MARC::Record]
+      # @param display_value [Symbol | String] field in location hash to retrieve
+      # @param location_map [Hash] hash with location_code as key and location hash as value
       # @return [Array<String>]
       def location(record:, display_value:, location_map:)
         # get enriched marc location tag and relevant subfields
@@ -71,7 +71,7 @@ module PennMARC
 
       # Determine enriched marc location tag, location code subfield, and call number subfield,
       # giving priority to using 'itm', 'AVA', or 'AVE' fields.
-      # @param [MARC::Record]
+      # @param record [MARC::Record]
       # @return [Hash<String, String>] containing location tag and subfield code
       # - `:tag` (String): The enriched marc location tag
       # - `:location_code_sf` (String): The subfield code where location code is stored
@@ -111,8 +111,8 @@ module PennMARC
       # map, we ignore it, for faceting purposes. We also ignore the location code 'web'. We don't facet for 'web'
       # which is the 'Penn Library Web' location used in Voyager. This location should eventually go away completely
       # with data cleanup in Alma.
-      # @param [location_map] location_map hash with location_code as key and location hash as value
-      # @param [location_code] location_code retrieved from record
+      # @param location_map [location_map] hash with location_code as key and location hash as value
+      # @param location_code [location_code] retrieved from record
       # @return [Boolean]
       def location_code_to_ignore?(location_map, location_code)
         location_map.key?(location_code.to_sym) == false || location_code == WEB_LOCATION_CODE
@@ -120,10 +120,10 @@ module PennMARC
 
       # Retrieves a specific location override based on location code and call number. Specific location overrides are
       # located in `location_overrides.yml`.
-      # @param [String | Symbol] display_value
-      # @param [String] location_code
-      # @param [MARC::Field] field
-      # @param [String] call_num_sf
+      # @param display_value [String | Symbol]
+      # @param location_code [String]
+      # @param field [MARC::Field]
+      # @param call_num_sf [String]
       # @return [String, Nil]
       def specific_location_override(display_value:, location_code:, field:, call_num_sf:)
         return unless display_value.to_sym == :specific_location

data/lib/pennmarc/helpers/note.rb

@@ -172,7 +172,7 @@ module PennMARC
       end
 
       # Retrieve "With" notes for display from field {https://www.loc.gov/marc/bibliographic/bd501.html 501}
-      # @param record [Marc::Record]
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def bound_with_show(record)
         record.fields('501').filter_map { |field| join_subfields(field, &subfield_in?(['a'])).presence }.uniq
@@ -183,7 +183,7 @@ module PennMARC
       # For system details: extract subfield ǂ3 plus other subfields as specified by passed-in block. Pays special
       # attention to punctuation, joining subfield ǂ3 values with a colon-space (': ').
       # @param field [MARC::DataField]
-      # @param & [Proc]
+      # @yieldparam & [Proc]
       # @return [String]
       def sub3_and_other_subs(field, &)
         sub3 = field.filter_map { |sf| trim_trailing('period', sf.value) if sf.code == '3' }.join(': ')

data/lib/pennmarc/helpers/production.rb

@@ -109,8 +109,8 @@ module PennMARC
       # {https://www.loc.gov/marc/bibliographic/bd245.html 245},
       # {https://www.loc.gov/marc/bibliographic/bd260.html 260}-262 and their linked alternates,
       # and {https://www.loc.gov/marc/bibliographic/bd264.html 264} and its linked alternate.
-      # @param [MARC::Record] record
-      # @param [Boolean] with_year: return results with publication year if true
+      # @param record [MARC::Record]
+      # @param with_year [Boolean] return results with publication year if true
       # @return [Array<String>]
       def publication_citation_show(record, with_year: true)
         values = record.fields('245').first(1).flat_map { |field| subfield_values(field, 'f') }
@@ -131,14 +131,14 @@ module PennMARC
       end
 
       # Returns the place of publication for RIS
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def publication_ris_place_of_pub(record)
         get_publication_ris_values(record, 'a')
       end
 
       # Returns the publisher for RIS
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def publication_ris_publisher(record)
         get_publication_ris_values(record, 'b')
@@ -202,8 +202,9 @@ module PennMARC
       end
 
       # Returns the publication value of the given subfield
-      # @param [MARC::Record] record
-      # @param [String] subfield
+      # @param record [MARC::Record]
+      # @param subfield [String]
+      # @return [Array<String>]
       def get_publication_ris_values(record, subfield)
         values = record.fields('245').first(1).flat_map { |field| subfield_values(field, 'f') }
 

data/lib/pennmarc/helpers/relation.rb

@@ -13,7 +13,7 @@ module PennMARC
       # Get values for "{https://www.oclc.org/bibformats/en/7xx/773.html Host Item}" for this record. Values contained
       # in this field should be sufficient to locate host item record.
       #
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] contained in values for display
       def contained_in_show(record)
         record.fields('773').map { |field|
@@ -23,21 +23,21 @@ module PennMARC
 
       # Get "chronology" information from specially-prefixed 650 (subject) fields
       # @todo why do we stuff chronology data in a 650 field?
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array] array of chronology values
       def chronology_show(record)
         prefixed_subject_and_alternate(record, CHRONOLOGY_PREFIX)
       end
 
       # Get notes for Related Collections from {https://www.oclc.org/bibformats/en/5xx/544.html MARC 544}.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def related_collections_show(record)
         datafield_and_linked_alternate(record, '544')
       end
 
       # Get notes for "Publication About" from {https://www.oclc.org/bibformats/en/5xx/581.html MARC 581}.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def publications_about_show(record)
         datafield_and_linked_alternate(record, '581')
@@ -45,8 +45,8 @@ module PennMARC
 
       # Get related work from {RELATED_WORK_FIELDS} in the 7XX range. Require presence of sf t (title) and absence of
       # an indicator2 value. Prefix returned values with sf i value. Also map relator codes found in sf 4. Ignore sf 0.
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array]
       def related_work_show(record, relator_map: Mappers.relator)
         fields = record.fields(RELATED_WORK_FIELDS)
@@ -71,8 +71,8 @@ module PennMARC
       # "Analytical Entry" meaning that the record is contained by the matching field. Map relator codes in sf 4. Ignore
       # values in sf 0, 5, 6, and 8.
       # @todo is it okay to include 880 $4 here? Legacy includes untranslated $4, why?
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>]
       def contains_show(record, relator_map: Mappers.relator)
         fields = record.fields(CONTAINS_FIELDS)
@@ -93,7 +93,7 @@ module PennMARC
 
       # Get "Constituent Unit" values from {https://www.oclc.org/bibformats/en/7xx/774.html MARC 774}. Include
       # subfield values in i, a, s and t.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def constituent_unit_show(record)
         values = record.fields('774').filter_map do |field|
@@ -105,7 +105,7 @@ module PennMARC
 
       # Get "Has Supplement" values from {https://www.oclc.org/bibformats/en/7xx/770.html MARC 770}. Ignore
       # subfield values in 6 and 8.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def has_supplement_show(record)
         datafield_and_linked_alternate(record, '770')
@@ -114,10 +114,10 @@ module PennMARC
       private
 
       # Handle common behavior when a relator field references a title in subfield i
-      # @param [MARC::DataField] field
-      # @param [String, nil] relator_term_sf subfield that holds relator term
-      # @param [Hash, nil] relator_map map relator in sf4 using this map, optional
-      # @param [Proc] join_selector
+      # @param field [MARC::DataField]
+      # @param relator_term_sf [String, nil] subfield that holds relator term
+      # @param relator_map [Hash, nil] map relator in sf4 using this map, optional
+      # @param join_selector [Proc]
       # @return [String] extracted and processed values from field
       def values_with_title_prefix(field, relator_term_sf: nil, relator_map: nil, &join_selector)
         subi = remove_paren_value_from_subfield_i(field) || ''

data/lib/pennmarc/helpers/series.rb

@@ -18,8 +18,8 @@ module PennMARC
       DISPLAY_TAGS = %w[800 810 811 830 400 410 411 440 490].freeze
 
       # Fields for display that pertain to series information.
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>] array of series information
       def show(record, relator_map: Mappers.relator)
         tags_present = DISPLAY_TAGS.select { |tag| record[tag].present? }
@@ -36,8 +36,8 @@ module PennMARC
       end
 
       # Values from series fields for display.
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>] array of series values
       def values(record, relator_map: Mappers.relator)
         series_8x = record.fields(%w[800 810 811 830]).first
@@ -48,7 +48,7 @@ module PennMARC
       end
 
       # Series fields for search.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of series values
       def search(record)
         values = record.fields(%w[400 410 411]).filter_map do |field|
@@ -83,7 +83,7 @@ module PennMARC
       # is generated from this field, the introductory term or phrase may be generated based on the value in the second
       # indicator position for display.
       # https://www.loc.gov/marc/bibliographic/bd780.html
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] continues fields string
       def get_continues_show(record)
         continues(record, '780').uniq
@@ -93,7 +93,7 @@ module PennMARC
       # generated from this field, the introductory phrase may be generated based on the value in the second indicator
       # position for display.
       # https://www.loc.gov/marc/bibliographic/bd785.html
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] continued by fields string
       def get_continued_by_show(record)
         continues(record, '785').uniq
@@ -104,9 +104,9 @@ module PennMARC
       # If any of these values: 800 810 811 400 410 411 are present, return a string with series information and
       # appended values.
       # @note added 2017/04/10: filter out 0 (authority record numbers) added by Alma
-      # @param [MARC::Record] record
-      # @param [String] first_tag
-      # @param [Hash] relator_mapping
+      # @param record [MARC::Record]
+      # @param first_tag [String]
+      # @param relator_mapping [Hash]
       # @return [Array<Hash>] array of author show entry hashes
       def author_show_entries(record, first_tag, relator_mapping)
         record.fields(first_tag).map do |field|
@@ -126,8 +126,8 @@ module PennMARC
 
       # If any of these values: 830 440 490 are present, return a string with series information and appended values.
       # @note added 2017/04/10: filter out 0 (authority record numbers) added by Alma
-      # @param [MARC::Record] record
-      # @param [String] first_tag
+      # @param record [MARC::Record]
+      # @param first_tag [String]
       # @return [Array<String>] array of author show entry strings
       def title_show_entries(record, first_tag)
         record.fields(first_tag).map do |field|
@@ -139,8 +139,8 @@ module PennMARC
 
       # Assemble an array of hashes that includes the remaining show entries.
       # @note added 2017/04/10: filter out 0 (authority record numbers) added by Alma
-      # @param [MARC::Record] record
-      # @param [Array<String>] tags_present
+      # @param record [MARC::Record]
+      # @param tags_present [Array<String>]
       # @return [Array<Hash>] array of remaining show entry hashes
       def remaining_show_entries(record, tags_present)
         record.fields(tags_present.drop(1)).map do |field|
@@ -156,7 +156,7 @@ module PennMARC
       # is linked to the associated regular field by subfield $6 (Linkage). A subfield $6 in the associated field also
       # links that field to the 880 field. The data in field 880 may be in more than one script. This function exists
       # because it differs than the tradition use of linked_alternate.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def series_880_fields(record)
         record.fields('880').filter_map do |field|
@@ -168,8 +168,8 @@ module PennMARC
 
       # Assemble a formatted string of a given field.
       # @note added 2017/04/10: filter out 0 (authority record numbers) added by Alma
-      # @param [MARC::Field] field
-      # @param [Hash] relator_mapping
+      # @param field [MARC::Field]
+      # @param relator_mapping [Hash]
       # @return [String] series 4xx field
       def series_field(field, relator_mapping)
         subfields = if field.tag.start_with? '4'
@@ -189,8 +189,8 @@ module PennMARC
       end
 
       # Get subfields from a given field (continues or continued_by).
-      # @param [MARC::Record] record
-      # @param [String] tag
+      # @param record [MARC::Record]
+      # @param tag [String]
       # @return [Array<String>] joined subfields
       def continues(record, tag)
         record.fields.filter_map do |field|