pennmarc 1.0.30 → 1.0.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '07810ba2a6de07713ce40a1cfbe7fc33d5497eec834011a0098ce2cbd74bc5ff'
-  data.tar.gz: 45c3f0002e46be338a63be2109153f7603d9ebf8b1814d825b4c889c7f7237b4
+  metadata.gz: 529930d44585a1ba459c533cd6906bbc910a3b73c2a09bc57c0eb1f2739772b7
+  data.tar.gz: 1570743e970c564ece0d3eefa40fd51a720cf920f44cf97fca866770e21785bd
 SHA512:
-  metadata.gz: 9a214837d1f061611a13ea7d09b13ae41d7f6f7df8f08d03da3d98d8969849aacb0edfd45a3fea231acb1e53f8c06c4e4793db49cf5274063d6c59d7b7043212
-  data.tar.gz: 1a6dd99e562ef38b301e49ac17b6ec211eb0af1e7bdccc6a0d98c15683163f9c4168e51b8560296282a42d6dacdbfbb5d8856628af7000614e48961cbcb6b19c
+  metadata.gz: 97e6db5b2bccfde42421db0276b890b9ec0ea81bd9862679b1b948ba692d44f0dd23bd54dde788f042908c4dfb6c22f1016109f3ae449711a9c09fba98729aa8
+  data.tar.gz: 8dc0c53f5f491f2c403b392fb0edf69ed61fd193e131a118c0ea2f4b3f2d33b24eca1412207d2791320f69475f57fd08e74928d888b5fafba6907f9a6e5251b1

data/Gemfile

@@ -5,7 +5,6 @@ source 'https://rubygems.org'
 gem 'activesupport', '~> 7'
 gem 'library_stdnums', '~> 1.6'
 gem 'marc', '~> 1.2'
-gem 'multi_string_replace', '~> 2.0'
 gem 'nokogiri', '~> 1.15'
 gem 'rake', '~> 13.0'
 gem 'upennlib-rubocop', require: false

data/Gemfile.lock

@@ -19,7 +19,6 @@ GEM
       scrub_rb (>= 1.0.1, < 2)
       unf
     minitest (5.18.0)
-    multi_string_replace (2.0.2)
     nokogiri (1.15.2-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.15.2-x64-mingw-ucrt)
@@ -114,7 +113,6 @@ DEPENDENCIES
   activesupport (~> 7)
   library_stdnums (~> 1.6)
   marc (~> 1.2)
-  multi_string_replace (~> 2.0)
   nokogiri (~> 1.15)
   rake (~> 13.0)
   rspec (~> 3.12)

data/lib/pennmarc/heading_control.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'multi_string_replace'
-
 module PennMARC
   # Shared tools and values for controlling handling of subject or genre headings
   class HeadingControl
@@ -10,6 +8,9 @@ module PennMARC
     ALLOWED_SOURCE_CODES = %w[aat cct fast ftamc gmgpc gsafd homoit jlabsh lcgft lcsh lcstt lctgm
                               local/osu mesh ndlsh nli nlksh rbbin rbgenr rbmscv rbpap rbpri rbprov rbpub rbtyp].freeze
 
+    REMOVE_TERM_REGEX = /#{Mappers.headings_to_remove&.join('|')}/i
+    REPLACE_TERM_REGEX = /(#{Mappers.heading_overrides.keys.join('|')})/i
+
     class << self
       # Replace or remove any terms in provided values pursuant to the configuration in remove and override mappers.
       # Used to remove or replace offensive or otherwise undesirable subject headings.
@@ -18,10 +19,13 @@ module PennMARC
       def term_override(values)
         values.filter_map do |value|
           # Remove values if they contain a remove term
-          next nil if value.match?(/#{Mappers.headings_to_remove&.join('|')}/i)
+          next nil if value.match?(REMOVE_TERM_REGEX)
+
+          # return early if theres no terms to replace
+          next value if value.match(REPLACE_TERM_REGEX).nil?
 
-          # Replace values using multi_string_replace gem
-          MultiStringReplace.replace value, Mappers.heading_overrides
+          # lookup and perform replacement
+          value.sub(::Regexp.last_match.to_s, Mappers.heading_overrides[::Regexp.last_match.to_s.downcase])
         end
       end
     end

data/lib/pennmarc/helpers/access.rb

@@ -12,7 +12,7 @@ module PennMARC
       # electronic access or has physical holdings, and is therefore "Online" or "At the library". If a record is "At
       # the library", but has a link to a finding aid in the 856 field (matching certain criteria), also add 'Online' as
       # an access method.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def facet(record)
         values = record.filter_map do |field|
@@ -30,14 +30,14 @@ module PennMARC
       private
 
       # Does the record have added electronic holding info?
-      # @param [MARC::Field] field
+      # @param field [MARC::Field]
       # @return [Boolean]
       def electronic_holding_tag?(field)
         field.tag.in? [Enriched::Pub::ELEC_INVENTORY_TAG, Enriched::Api::ELEC_INVENTORY_TAG]
       end
 
       # Does the record have added physical holding info?
-      # @param [MARC::Field] field
+      # @param field [MARC::Field]
       # @return [Boolean]
       def physical_holding_tag?(field)
         field.tag.in? [Enriched::Pub::PHYS_INVENTORY_TAG, Enriched::Api::PHYS_INVENTORY_TAG]
@@ -51,7 +51,7 @@ module PennMARC
       # See: https://www.loc.gov/marc/bibliographic/bd856.html
       # @note Some electronic records do not have Portfolios in Alma, so we rely upon the Resource Link in the 856 to
       #       get these records included in the Online category.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Boolean]
       def resource_link?(record)
         record.fields('856').filter_map do |field|

data/lib/pennmarc/helpers/citation.rb

@@ -10,7 +10,7 @@ module PennMARC
       # abbreviations, etc.). The actual text of a published description is not recorded in field 510 but rather in
       # field 520 (Summary, Etc. Note).
       # https://www.loc.gov/marc/bibliographic/bd510.html
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of citations and any linked alternates
       def cited_in_show(record)
         datafield_and_linked_alternate(record, '510').uniq
@@ -21,7 +21,7 @@ module PennMARC
       # each is recorded in a separate occurrence of field 524. The note is sometimes displayed and/or printed with an
       # introductory phrase that is generated as a display constant based on the first indicator value.
       # https://www.loc.gov/marc/bibliographic/bd524.html
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of citation of described materials note and any linked alternates
       def cite_as_show(record)
         datafield_and_linked_alternate(record, '524').uniq

data/lib/pennmarc/helpers/classification.rb

@@ -25,7 +25,7 @@ module PennMARC
       # its title in a single string. See {PennMARC::Enriched} and {PennMARC::Enriched::Api} for more
       # information on the enriched MARC fields.
       # @see https://developers.exlibrisgroup.com/alma/apis/docs/bibs/R0VUIC9hbG1hd3MvdjEvYmlicy97bW1zX2lkfQ==/ AVA docs
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of classifications
       def facet(record)
         record.fields(TAGS).flat_map { |field|
@@ -45,7 +45,7 @@ module PennMARC
       private
 
       # Retrieve subfield code that stores the call number on enriched marc field
-      # @param [MARC::DataField] field
+      # @param field [MARC::DataField]
       # @return [String]
       def call_number_sf(field)
         return Enriched::Pub::ITEM_CALL_NUMBER if field.tag == Enriched::Pub::ITEM_TAG
@@ -54,7 +54,7 @@ module PennMARC
       end
 
       # Retrieve subfield code that stores call number type on enriched marc field
-      # @param [MARC::DataField] field
+      # @param field [MARC::DataField]
       # @return [String]
       def call_number_type_sf(field)
         return Enriched::Pub::ITEM_CALL_NUMBER_TYPE if field.tag == Enriched::Pub::ITEM_TAG
@@ -63,9 +63,9 @@ module PennMARC
       end
 
       # retrieve title of classification based on single char classification code and call number type
-      # @param[String] class_code classification code
-      # @param[String] call_number_type value from call number type subfield
-      # @return [String, NilClass]
+      # @param class_code [String] classification code
+      # @param call_number_type [String] value from call number type subfield
+      # @return [String, nil]
       def translate_classification(class_code, call_number_type)
         map = CLASSIFICATION_MAPS[call_number_type]
 
@@ -77,6 +77,9 @@ module PennMARC
       # format classification facet by joining single character classification code with its corresponding title.
       # Our Dewey mapping codes are single digit, so we must concatenate '00' to the class code to accurately reflect
       # Dewey class codes.
+      # @param class_code [String]
+      # @param call_number_type [String]
+      # @param title [String]
       # @return [String]
       def format_facet(class_code, call_number_type, title)
         return [class_code, title].join(' - ') if loc_call_number_type?(call_number_type)
@@ -85,7 +88,7 @@ module PennMARC
       end
 
       # Determine whether call number type is library of congress
-      # @param [String] call_number_type value from call number type subfield
+      # @param call_number_type [String] value from call number type subfield
       # @return [Boolean]
       def loc_call_number_type?(call_number_type)
         call_number_type == '0'

data/lib/pennmarc/helpers/creator.rb

@@ -86,9 +86,9 @@ module PennMARC
       end
 
       # Returns the list of authors with name (subfield $a) only
-      # @param [MARC::Record] record
-      # @param [Boolean] main_tags_only, if true, only use TAGS; otherwise use both TAGS and CONTRIBUTOR_TAGS
-      # @param [Boolean] first_initial_only: true to only use the first initial instead of first name
+      # @param record [MARC::Record]
+      # @param main_tags_only [Boolean] only use TAGS; otherwise use both TAGS and CONTRIBUTOR_TAGS
+      # @param first_initial_only [Boolean] only use the first initial instead of first name
       # @return [Array<String>] names of the authors
       def authors_list(record, main_tags_only: false, first_initial_only: false)
         tags = if main_tags_only
@@ -99,20 +99,19 @@ module PennMARC
 
         fields = record.fields(tags)
         fields.filter_map { |field|
-          if first_initial_only
-            abbreviate_name(field['a']) if field['a']
-          else
-            field['a']
+          if field['a'].present?
+            name = trim_trailing(:comma, field['a'])
+            first_initial_only ? abbreviate_name(name) : name
           end
         }.uniq
       end
 
       # Show the authors and contributors grouped together by relators with only names
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
-      # @param [Boolean] include_authors: true to include author fields TAGS
-      # @param [Boolean] name_only: true to include only the name subfield $a
-      # @param [Boolean] vernacular: true to include field 880 with subfield $6
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
+      # @param include_authors [Boolean] include author fields TAGS
+      # @param name_only [Boolean] include only the name subfield $a
+      # @param vernacular [Boolean] include field 880 with subfield $6
       # @return [Hash]
       def contributors_list(record, relator_map: Mappers.relator, include_authors: true, name_only: true,
                             vernacular: false)
@@ -131,10 +130,11 @@ module PennMARC
           relator = 'Contributor' if relator.blank?
           relator = trim_punctuation(relator).capitalize
 
+          name = trim_trailing(:comma, field['a'])
           name = if name_only
-                   field['a']
+                   name
                  else
-                   join_subfields(field, &subfield_in?(%w[a b c d j q u 3])) + ", #{relator}"
+                   "#{name} #{join_subfields(field, &subfield_in?(%w[b c d j q u 3]))}, #{relator}"
                  end
 
           if contributors.key?(relator)
@@ -294,7 +294,7 @@ module PennMARC
       private
 
       # @param record [MARC::Record]
-      # @param tags [Array] to consider
+      # @param tags [Array] tags to consider
       # @param relator_map [Hash]
       # @return [Array<String>] name values from given tags
       def name_search_values(record:, tags:, relator_map:)
@@ -328,7 +328,7 @@ module PennMARC
         relator_term_sf = relator_term_subfield(field)
         name = field.filter_map { |sf|
           if sf.code == 'a'
-            should_convert_name_order ? convert_name_order(sf.value) : sf.value
+            should_convert_name_order ? convert_name_order(sf.value) : trim_trailing(:comma, sf.value)
           elsif sf.code == relator_term_sf
             next
           elsif NAME_EXCLUDED_SUBFIELDS.exclude?(sf.code)
@@ -348,6 +348,7 @@ module PennMARC
       # @param name [String] value for processing
       # @return [String]
       def convert_name_order(name)
+        name = trim_trailing(:comma, name)
         return name unless name.include? ','
 
         after_comma = join_and_squish([trim_trailing(:comma, substring_after(name, ', '))])
@@ -356,16 +357,17 @@ module PennMARC
       end
 
       # Convert "Lastname, First" to "Lastname, F"
-      # @param [String] name
+      # @param name [String]
+      # @return [String]
       def abbreviate_name(name)
-        name_parts = name.split(', ')
-        return '' if name_parts.empty?
-
-        first_name_parts = name_parts.last.split
-        temp_name = "#{name_parts.first}, #{first_name_parts.first[0, 1]}."
-        first_name_parts.shift
-        temp_name += " #{first_name_parts.join(' ')}" unless first_name_parts.empty?
-        temp_name
+        name = trim_trailing(:comma, name)
+        return name unless name.include? ','
+
+        after_comma = join_and_squish([trim_trailing(:comma, substring_after(name, ','))])
+        before_comma = substring_before(name, ',')
+        abbrv = "#{before_comma},"
+        abbrv += " #{after_comma.first.upcase}." if after_comma.present?
+        abbrv
       end
 
       # Parse creator facet value from given creator field and desired subfields

data/lib/pennmarc/helpers/database.rb

@@ -16,8 +16,8 @@ module PennMARC
       # Retrieves database subtype (subfield 'b') from
       # {https://upennlibrary.atlassian.net/wiki/spaces/ALMA/pages/323912493/Local+9XX+Field+Use+in+Almalocal
       # local field 944}. Only returns database subtype if Penn's Database facet value is present in subfield 'a'.
-      # @param [Marc::Record]
-      # @return [Array<string>] Array of types
+      # @param record [MARC::Record]
+      # @return [Array<String>] Array of types
       def type_facet(record)
         record.fields('944').filter_map { |field|
           # skip unless specified database format type present
@@ -32,8 +32,8 @@ module PennMARC
       # {https://upennlibrary.atlassian.net/wiki/spaces/ALMA/pages/323912493/Local+9XX+Field+Use+in+Almalocal
       # local field 943}. Only returns database subject category if Penn's Community of Interest code is present in
       # subfield '2'.
-      # @param [Marc::Record]
-      # @return [Array<string>] Array of categories
+      # @param record [MARC::Record]
+      # @return [Array<String>] Array of categories
       def category_facet(record)
         return [] unless curated_db?(record)
 
@@ -53,8 +53,8 @@ module PennMARC
       # local field 943}. Only returns subcategory if Penn's Community of Interest code is present in subfield '2'.
       # @note return value differs from legacy implementation. This version only returns ["category--subcategory"] or
       #   an empty array.
-      # @param [Marc::Record]
-      # @return [Array<string>] Array of "category--subcategory"
+      # @param record [MARC::Record]
+      # @return [Array<String>] Array of "category--subcategory"
       def subcategory_facet(record)
         return [] unless curated_db?(record)
 
@@ -79,8 +79,8 @@ module PennMARC
       private
 
       # Determines if Database format type is format type used to facet databases
-      # @param [Marc::Record]
-      # @return [TrueClass, FalseClass]
+      # @param record [MARC::Record]
+      # @return [Boolean]
       def curated_db?(record)
         record.fields('944').any? { |field| subfield_value?(field, 'a', /#{DATABASES_FACET_VALUE}/o) }
       end

data/lib/pennmarc/helpers/date.rb

@@ -7,7 +7,7 @@ module PennMARC
       # Retrieve publication date (Date 1) from {https://www.loc.gov/marc/bibliographic/bd008a.html 008 field}.
       # Publication date is a four-digit year found in position 7-10 and may contain 'u' characters to represent
       # partially known dates. We replace any occurrences of 'u' with '0' before converting to DateTime object.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Time, nil] The publication date, or nil if date found in record is invalid
       def publication(record)
         record.fields('008').filter_map { |field|
@@ -22,7 +22,7 @@ module PennMARC
       # Retrieve date added (subfield 'q') from enriched marc 'itm' field.
       # {PennMARC::Enriched} maps enriched marc fields and subfields created during Alma publishing. The enriched
       # metadata provided by the Alma API does not include the date created value, so we can't work with that here.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Time, nil] The date added, or nil if date found in record is invalid
       def added(record)
         record.fields(Enriched::Pub::ITEM_TAG).flat_map { |field|
@@ -46,7 +46,7 @@ module PennMARC
       # Retrieve date last updated from {https://www.loc.gov/marc/bibliographic/bd005.html 005 field}.
       # Date last updated is a sixteen character String recorded in
       # {https://www.iso.org/iso-8601-date-and-time-format.html ISO 8601} format.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Time, nil] The date last updated, or nil if date found in record is invalid
       def last_updated(record)
         record.fields('005').filter_map { |field|
@@ -69,8 +69,8 @@ module PennMARC
       private
 
       # Sanitizes a partially known date string by replacing any 'u' occurrences with a specified replacement value.
-      # @param [String] date The date string in '%Y' format, potentially containing 'u' characters.
-      # @param [String] replacement The value with which to replace 'u' occurrences in the date string.
+      # @param date [String] The date string in '%Y' format, potentially containing 'u' characters.
+      # @param replacement [String] The value with which to replace 'u' occurrences in the date string.
       # @return [String, nil] The sanitized date string with 'u' characters replaced by the replacement value,
       #   or nil if the date string does not match the expected format.
       def sanitize_partially_known_date(date, replacement)

data/lib/pennmarc/helpers/edition.rb

@@ -11,7 +11,7 @@ module PennMARC
       # sequential edition statements such as 1st- ed. This type of information is contained in field 362 (Dates of
       # Publication and/or Volume Designation).
       # https://www.loc.gov/marc/bibliographic/bd250.html
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] array of editions and their alternates
       def show(record, with_alternate: true)
         editions = record.fields('250').map do |field|
@@ -23,8 +23,8 @@ module PennMARC
       end
 
       # Edition values for display in search results. Just grab the first 250 field.
-      # @param [MARC::Record] record
-      # @return [String, NilClass] string of all first 250 subfields, excluding 6 and 8
+      # @param record [MARC::Record]
+      # @return [String, nil] string of all first 250 subfields, excluding 6 and 8
       def values(record)
         edition = record.fields('250').first
         return if edition.blank?
@@ -36,8 +36,8 @@ module PennMARC
       # from this field, the introductory phrase Other editions available: may be generated based on the field tag for
       # display.
       # https://www.loc.gov/marc/bibliographic/bd775.html
-      # @param [MARC::Record] record
-      # @param [Hash] relator_map
+      # @param record [MARC::Record]
+      # @param relator_map [Hash]
       # @return [Array<String>] array of other edition strings
       def other_show(record, relator_map: Mappers.relator)
         values = record.fields('775').filter_map do |field|
@@ -57,8 +57,8 @@ module PennMARC
       private
 
       # Assemble a string of relevant edition information.
-      # @param [MARC::DataField] field
-      # @param [Hash] relator_map
+      # @param field [MARC::DataField]
+      # @param relator_map [Hash]
       # @return [String (frozen)] assembled other version string
       def other_edition_value(field, relator_map)
         subi = remove_paren_value_from_subfield_i(field) || ''

data/lib/pennmarc/helpers/format.rb

@@ -33,7 +33,7 @@ module PennMARC
       # 254, 255, 310, 342, 352, 362 or {https://www.oclc.org/bibformats/en/3xx/340.html 340} field. based on the source
       # field, different subfields are used.
       # @note ported from get_format_display
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] format values for display
       def show(record)
         results = record.fields('300').map { |f| join_subfields(f, &subfield_not_in?(%w[3 6 8])) }
@@ -70,13 +70,9 @@ module PennMARC
       # 5. Media Type values from {https://www.oclc.org/bibformats/en/3xx/337.html#subfielda 337 ǂa}
       # Additional fields are considered for many of the formats. Much of this logic has been moved to private methods
       # to keep this method from becoming too unwieldy.
-      # @todo is the conditional structure here still best practice? see the "Thesis on Microfilm" case in the specs
-      #       for this helper method
       # @note ported from get_format
-      # @param [MARC::Record] record
-      # @param [Hash] location_map
+      # @param record [MARC::Record]
       # @return [Array<String>] format values for faceting
-
       def facet(record)
         formats = []
         format_code = leader_format(record.leader)
@@ -113,7 +109,7 @@ module PennMARC
 
       # Show "Other Format" values from {https://www.oclc.org/bibformats/en/7xx/776.html 776} and any 880 linkage.
       # @todo is 774 an error in the linked field in legacy? i changed to 776 here
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>] other format values for display
       def other_show(record)
         values = record.fields('776').filter_map do |field|
@@ -130,7 +126,7 @@ module PennMARC
 
       # Retrieve cartographic reference data for map/atlas formats for display from
       # {https://www.oclc.org/bibformats/en/2xx/255.html 255} and {https://www.oclc.org/bibformats/en/3xx/342.html 342}
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array<String>]
       def cartographic_show(record)
         record.fields(%w[255 342]).map { |field|
@@ -139,7 +135,7 @@ module PennMARC
       end
 
       # Check if leader format code is either 't', 'f', or 'd'
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def include_manuscripts?(format_code)
         format_code.first.in? %w[t f d]
@@ -149,7 +145,7 @@ module PennMARC
 
       # Get Call Numbers for holdings using the 'Classification part' which can contain strings like
       # 'Microfilm'. Look in enriched tags used by both Alma Publishing and API.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def call_nums(record)
         if field_defined?(record, Enriched::Pub::PHYS_INVENTORY_TAG)
@@ -169,7 +165,7 @@ module PennMARC
       # Get 'Curated' format from.
       # {https://upennlibrary.atlassian.net/wiki/spaces/ALMA/pages/323912493/Local+9XX+Field+Use+in+Alma local field
       # 944} ǂa, as long as it is not a numerical value.
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Array]
       def curated_format(record)
         record.fields('944').filter_map { |field|
@@ -180,57 +176,57 @@ module PennMARC
         }.uniq
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def image?(format_code)
         format_code.in?(%w[km kd])
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def datafile?(format_code)
         format_code == 'mm'
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def journal_periodical?(format_code)
         format_code.in?(%w[as gs])
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def three_d_object?(format_code)
         format_code.start_with?('r')
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def sound_recording?(format_code)
         format_code.in?(%w[im jm jc jd js])
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def graphical_media?(format_code)
         format_code == 'gm'
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def map_atlas?(format_code)
         format_code&.start_with?('e') || format_code == 'fm'
       end
 
-      # @param [String] format_code
+      # @param format_code [String]
       # @return [Boolean]
       def musical_score?(format_code)
         format_code.in?(%w[ca cb cc cd cm cs dc dm])
       end
 
-      # @param [String] format_code
-      # @param [Array<String>] media_type
-      # @param [MARC::Record] record
+      # @param format_code [String]
+      # @param media_type [Array<String>]
+      # @param record [MARC::Record]
       # @return [Boolean]
       def book?(format_code, media_type, record)
         title_forms = subfield_values_for tag: '245', subfield: :k, record: record
@@ -239,17 +235,17 @@ module PennMARC
           media_type.none? { |val| val =~ /micro/i }
       end
 
-      # @param [Array<String>] f006_forms
-      # @param [String] format_code
+      # @param f006_forms [Array<String>]
+      # @param format_code [String]
       # @return [Boolean]
       def website_database?(f006_forms, format_code)
         format_code&.end_with?('i') ||
           (format_code == 'am' && f006_forms.include?('m') && f006_forms.include?('s'))
       end
 
-      # @param [String] f008
-      # @param [MARC::Record] record
-      # @param [String] format_code
+      # @param f008 [String]
+      # @param record [MARC::Record]
+      # @param format_code [String]
       # @return [Boolean]
       def government_document?(f008, record, format_code)
         # is a 260 entry present, and does it have a b that matches 'press'
@@ -259,31 +255,31 @@ module PennMARC
         %w[c d i j].exclude?(format_code[0]) && f008[28].in?(%w[f i o]) && !f260press
       end
 
-      # @param [String] f008
-      # @param [String] format_code
+      # @param f008 [String]
+      # @param format_code [String]
       # @return [Boolean]
       def newspaper?(f008, format_code)
         format_code == 'as' && (f008[21] == 'n' || f008[22] == 'e')
       end
 
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Boolean]
       def conference_event?(record)
         record.fields('111').any? || record.fields('711').any? # TODO: use field_present helper here and below?
       end
 
-      # @param [MARC::Record] record
-      # @param [String] format_code
+      # @param record [MARC::Record]
+      # @param format_code [String]
       # @return [Boolean]
       def thesis_or_dissertation?(format_code, record)
         record.fields('502').any? && format_code.in?(%w[am tm dm])
       end
 
-      # @param [Array<String>] call_nums
-      # @param [Array<String>] f007
-      # @param [String] f008
-      # @param [Array<String>] title_medium
-      # @param [Array<String>] media_type
+      # @param call_nums [Array<String>]
+      # @param f007 [Array<String>]
+      # @param f008 [String]
+      # @param title_medium [Array<String>]
+      # @param media_type [Array<String>]
       # @return [Boolean]
       def micro_or_microform?(call_nums, f007, f008, media_type, title_medium)
         [f008[23], f008[29]].any? { |v| v.in?(%w[a b c]) } ||
@@ -296,7 +292,7 @@ module PennMARC
       # Determine archive format by checking if {https://www.loc.gov/marc/bibliographic/hd852.html 852} and
       # {PennMARC::Enriched} Publishing Tag 'ITM' have values that match any of the following archive locations:
       # archarch, musearch, scfreed, univarch, archivcoll
-      # @param [MARC::Record] record
+      # @param record [MARC::Record]
       # @return [Boolean]
       def archive?(record)
         enriched_tag = Enriched::Pub::ITEM_TAG
@@ -311,7 +307,7 @@ module PennMARC
       end
 
       # Consider {https://www.loc.gov/marc/bibliographic/bd007g.html 007} to determine graphical media format
-      # @param [Array<String>] f007
+      # @param f007 [Array<String>]
       # @return [String (frozen)]
       def graphical_media_type(f007)
         if f007.any? { |v| v.start_with?('g') }
@@ -321,7 +317,7 @@ module PennMARC
         end
       end
 
-      # @param [String] leader
+      # @param leader [String]
       # @return [String]
       def leader_format(leader)
         leader[6..7] || '  '