pennmarc 0.0.2 → 1.0.1

data/spec/lib/pennmarc/helpers/title_spec.rb

@@ -20,7 +20,9 @@ describe 'PennMARC::Title' do
     end
   end
 
-  xdescribe '.search_aux'
+  describe '.search_aux' do
+    it 'returns search aux values', pending: 'Not implemented yet'
+  end
 
   describe '.show' do
     let(:record) { marc_record fields: [marc_field(tag: '245', subfields: subfields)] }

data/spec/lib/pennmarc/marc_util_spec.rb

@@ -20,11 +20,11 @@ describe 'PennMARC::Util' do
     let(:field) { marc_field subfields: { a: '123' } }
 
     it 'returns true if the specified subfield value matches the regex' do
-      expect(util.subfield_value?(field, 'a', /123/)).to be_truthy
+      expect(util).to be_subfield_value(field, 'a', /123/)
     end
 
     it 'returns false if the subfield value does not match the regex' do
-      expect(util.subfield_value?(field, 'a', /\D/)).to be_falsey
+      expect(util).not_to be_subfield_value(field, 'a', /\D/)
     end
   end
 
@@ -66,12 +66,12 @@ describe 'PennMARC::Util' do
     let(:field) { marc_field subfields: { a: 'Defined' } }
 
     it 'returns true if subfield is present on a field' do
-      expect(util.subfield_defined?(field, :a)).to be_truthy
-      expect(util.subfield_defined?(field, 'a')).to be_truthy
+      expect(util).to be_subfield_defined(field, :a)
+      expect(util).to be_subfield_defined(field, 'a')
     end
 
     it 'returns false if a subfield is not present on a field' do
-      expect(util.subfield_defined?(field, :b)).to be_falsey
+      expect(util).not_to be_subfield_defined(field, :b)
     end
   end
 
@@ -79,12 +79,12 @@ describe 'PennMARC::Util' do
     let(:field) { marc_field subfields: { a: 'Defined' } }
 
     it 'returns true if subfield is not present on a field' do
-      expect(util.subfield_undefined?(field, :b)).to be_truthy
-      expect(util.subfield_undefined?(field, 'b')).to be_truthy
+      expect(util).to be_subfield_undefined(field, :b)
+      expect(util).to be_subfield_undefined(field, 'b')
     end
 
     it 'returns false if a subfield is present on a field' do
-      expect(util.subfield_undefined?(field, :a)).to be_falsey
+      expect(util).not_to be_subfield_undefined(field, :a)
     end
   end
 
@@ -173,6 +173,7 @@ describe 'PennMARC::Util' do
 
   describe '.remove_paren_value_from_subfield_i' do
     let(:field) { marc_field(tag: '666', subfields: { i: 'Test(Remove).' }) }
+
     it 'removes the parentheses value from subfield i' do
       expect(util.remove_paren_value_from_subfield_i(field)).to eq('Test')
     end

data/spec/lib/pennmarc/parser_spec.rb

@@ -3,11 +3,32 @@
 describe PennMARC::Parser do
   include MarcSpecHelpers
 
-  let(:record) { record_from 'test.xml' }
-
   subject(:parser) { described_class.new }
 
+  let(:record) { record_from 'test.xml' }
+
   it 'delegates to helper modules properly' do
-    expect { parser.title_show(record) }.not_to raise_exception
+    expect(parser.language_search(record)).to eq 'English'
+  end
+
+  it 'delegates to helper modules properly with extra params' do
+    bogus_map = { eng: 'American' }
+    expect(parser.language_search(record, language_map: bogus_map)).to eq 'American'
+  end
+
+  it 'raises an exception if the method call is invalid' do
+    expect { parser.title(record) }.to raise_error NoMethodError
+    expect { parser.title_nope(record) }.to raise_error NoMethodError
+  end
+
+  describe '#respond_to?' do
+    it 'returns true if a helper has the expected method' do
+      expect(parser).to respond_to :language_search
+    end
+
+    it 'returns false if a helper does not have the expected method' do
+      expect(parser).not_to respond_to :language_nope
+      expect(parser).not_to respond_to :nope
+    end
   end
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 
 $LOAD_PATH.unshift(__dir__) unless $LOAD_PATH.include?(__dir__)
 
-Dir[File.join(__dir__, 'support', '**', '*.rb')].sort.each { |f| require f }
+Dir[File.join(__dir__, 'support', '**', '*.rb')].each { |f| require f }
 
 require 'pennmarc'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pennmarc
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 1.0.1
 platform: ruby
 authors:
 - Mike Kanning
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-17 00:00:00.000000000 Z
+date: 2023-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -68,20 +68,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.15'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
 description: |-
   This gem provides methods for parsing a Penn Libraries MARCXML record into string, array and date
                      objects for use in discovery or preservation applications.
@@ -92,13 +78,12 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - README.md
-- legacy/indexer.rb
-- legacy/marc.rb
-- legacy/test_file_output.json
 - lib/pennmarc.rb
 - lib/pennmarc/encoding_level.rb
 - lib/pennmarc/enriched_marc.rb
@@ -121,6 +106,7 @@ files:
 - lib/pennmarc/helpers/series.rb
 - lib/pennmarc/helpers/subject.rb
 - lib/pennmarc/helpers/title.rb
+- lib/pennmarc/mappers.rb
 - lib/pennmarc/mappings/language.yml
 - lib/pennmarc/mappings/locations.yml
 - lib/pennmarc/mappings/relator.yml
@@ -141,6 +127,7 @@ files:
 - spec/lib/pennmarc/helpers/note_spec.rb
 - spec/lib/pennmarc/helpers/production_spec.rb
 - spec/lib/pennmarc/helpers/relation_spec.rb
+- spec/lib/pennmarc/helpers/series_spec.rb
 - spec/lib/pennmarc/helpers/subject_spec.rb
 - spec/lib/pennmarc/helpers/title_spec.rb
 - spec/lib/pennmarc/marc_util_spec.rb
@@ -150,7 +137,8 @@ files:
 homepage: https://gitlab.library.upenn.edu/dld/catalog/pennmarc
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: