pennmarc 0.0.2 → 1.0.1

data/spec/lib/pennmarc/helpers/creator_spec.rb

@@ -9,7 +9,7 @@ describe 'PennMARC::Creator' do
   describe '.search' do
     let(:record) { marc_record fields: fields }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Surname, Name', '0': 'http://cool.uri/12345',
                                              e: 'author', d: '1900-2000' }),
@@ -17,21 +17,21 @@ describe 'PennMARC::Creator' do
       end
 
       it 'contains the expected search field values for a single author work' do
-        expect(helper.search(record, mapping)).to eq ['Name Surname http://cool.uri/12345 author 1900-2000.',
-                                                      'Surname, Name http://cool.uri/12345 author 1900-2000.',
-                                                      'Alternative Surname']
+        expect(helper.search(record, relator_map: mapping)).to eq ['Name Surname http://cool.uri/12345 author 1900-2000.',
+                                                                   'Surname, Name http://cool.uri/12345 author 1900-2000.',
+                                                                   'Alternative Surname']
       end
     end
 
-    context 'for a corporate author record' do
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Group of People', b: 'Annual Meeting', '4': 'aut' }),
          marc_field(tag: '880', subfields: { '6': '110', a: 'Alt. Group Name', b: 'Alt. Annual Meeting' })]
       end
 
       it 'contains the expected search field values for a corporate author work' do
-        expect(helper.search(record, mapping)).to eq ['Group of People Annual Meeting Author.',
-                                                      'Alt. Group Name Alt. Annual Meeting']
+        expect(helper.search(record, relator_map: mapping)).to eq ['Group of People Annual Meeting Author.',
+                                                                   'Alt. Group Name Alt. Annual Meeting']
       end
     end
   end
@@ -39,26 +39,26 @@ describe 'PennMARC::Creator' do
   describe '.values' do
     let(:record) { marc_record fields: fields }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Author', c: 'Fancy', d: 'active 24th century AD', '4': 'aut' }),
          marc_field(tag: '880', subfields: { '6': '100', a: 'Alt Author', c: 'Alt Fanciness' })]
       end
 
       it 'returns values for the author, including mapped relator code from ǂ4' do
-        values = helper.values(record, mapping)
+        values = helper.values(record, relator_map: mapping)
         expect(values).to contain_exactly 'Author Fancy active 24th century AD, Author.'
         expect(values.join.downcase).not_to include 'alt'
       end
     end
 
-    context 'for a corporate author record' do
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Annual Report', b: 'Leader', e: 'author', '4': 'aut' })]
       end
 
       it 'returns values for the corporate author, including mapped relator code from ǂ4' do
-        expect(helper.values(record, mapping)).to contain_exactly 'Annual Report Leader author, Author.'
+        expect(helper.values(record, relator_map: mapping)).to contain_exactly 'Annual Report Leader author, Author.'
       end
     end
   end
@@ -66,12 +66,13 @@ describe 'PennMARC::Creator' do
   describe '.show' do
     let(:record) { marc_record fields: fields }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Surname, Name', '0': 'http://cool.uri/12345', d: '1900-2000',
                                              e: 'author', '4': 'http://cool.uri/vocabulary/relators/aut' }),
          marc_field(tag: '880', subfields: { a: 'Surname, Alternative', '6': '100' })]
       end
+
       it 'returns single author values with no URIs anywhere' do
         values = helper.show(record)
         expect(values).to contain_exactly 'Surname, Name 1900-2000', 'Surname, Alternative'
@@ -79,11 +80,12 @@ describe 'PennMARC::Creator' do
       end
     end
 
-    context 'for a corporate author record' do
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Group of People', b: 'Annual Meeting', '4': 'aut' }),
          marc_field(tag: '880', subfields: { '6': '110', a: 'Alt. Group Name', b: 'Alt. Annual Meeting' })]
       end
+
       it 'returns corporate author values with no URIs anywhere' do
         values = helper.show(record)
         expect(values).to contain_exactly 'Alt. Group Name Alt. Annual Meeting', 'Group of People Annual Meeting'
@@ -110,7 +112,7 @@ describe 'PennMARC::Creator' do
     let(:record) { marc_record fields: fields }
     let(:values) { helper.facet(record) }
 
-    context 'for a single author record' do
+    context 'with a single author record' do
       let(:fields) do
         [marc_field(tag: '100', subfields: { a: 'Author, Great', d: '1900-2000' }),
          marc_field(tag: '700', subfields: { a: 'Co-Author, Great', d: '1900-2000' }),
@@ -121,7 +123,8 @@ describe 'PennMARC::Creator' do
         expect(values).to contain_exactly 'Author, Added', 'Author, Great 1900-2000', 'Co-Author, Great 1900-2000'
       end
     end
-    context 'for a corporate author record' do
+
+    context 'with a corporate author record' do
       let(:fields) do
         [marc_field(tag: '110', subfields: { a: 'Group of People', b: 'Annual Meeting' }),
          marc_field(tag: '710', subfields: { a: 'A Publisher', e: 'publisher' }),
@@ -134,7 +137,8 @@ describe 'PennMARC::Creator' do
                                           'Group of People Annual Meeting'
       end
     end
-    context 'for a meeting author record' do
+
+    context 'with a meeting author record' do
       let(:fields) do
         [marc_field(tag: '111', subfields: { a: 'Conference on Things', c: 'Earth' }),
          marc_field(tag: '711', subfields: { a: 'Thing Institute', j: 'sponsoring body' }),
@@ -156,7 +160,7 @@ describe 'PennMARC::Creator' do
     end
 
     it 'returns conference name information for display, ignoring any linked 880 fields' do
-      expect(helper.conference_show(record, mapping)).to eq ['MARC History Symposium, Author.']
+      expect(helper.conference_show(record, relator_map: mapping)).to eq ['MARC History Symposium, Author.']
     end
   end
 
@@ -178,6 +182,37 @@ describe 'PennMARC::Creator' do
     end
   end
 
-  xdescribe '.conference_search'
-  xdescribe '.search_aux'
+  describe '.contributor_show' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '700', subfields: { a: 'Name', b: 'I', c: 'laureate', d: '1968', e: 'author',
+                                            j: 'pseud', q: 'Fuller Name', u: 'affiliation', '3': 'materials',
+                                            '4': 'aut' }),
+        marc_field(tag: '700', subfields: { a: 'Ignore' }, indicator2: '1'),
+        marc_field(tag: '700', subfields: { i: 'Ignore' }),
+        marc_field(tag: '710', subfields: { a: 'Corporation', b: 'A division', c: 'Office', d: '1968', e: 'author',
+                                            u: 'affiliation', '3': 'materials',
+                                            '4': 'aut' }),
+        marc_field(tag: '880', subfields: {  '6': '700', a: 'Alt Name', b: 'Alt num', c: 'Alt title',
+                                             d: 'Alt date', e: 'Alt relator', j: 'Alt qualifier', q: 'Alt Fuller Name',
+                                             u: 'Alt affiliation', '3': 'Alt materials' }),
+        marc_field(tag: '880', subfields: { '6': '710', a: 'Alt Corp Name', b: 'Alt unit', c: 'Alt location',
+                                            d: 'Alt date', e: 'Alt relator', u: 'Alt Affiliation',
+                                            '3': 'Alt materials' }),
+        marc_field(tag: '880', subfields: { i: 'Ignore', '6': '700' })
+      ]
+    end
+
+    it 'returns expected contributor values' do
+      expect(helper.contributor_show(record, relator_map: mapping)).to contain_exactly(
+        'Name I laureate 1968 pseud Fuller Name author affiliation materials, Author',
+        'Corporation A division Office 1968 author affiliation materials, Author',
+        'Alt Name Alt num Alt title Alt date Alt qualifier Alt Fuller Name Alt relator Alt affiliation Alt materials',
+        'Alt Corp Name Alt unit Alt location Alt date Alt relator Alt Affiliation Alt materials'
+      )
+    end
+  end
+
+  # describe '.conference_search'
+  # describe '.search_aux'
 end

data/spec/lib/pennmarc/helpers/date_spec.rb

@@ -27,7 +27,7 @@ describe 'PennMARC::Date' do
   end
 
   describe '.added' do
-    context "with date formatted '%Y-%m-%d' " do
+    context "with date formatted '%Y-%m-%d'" do
       let(:fields) { [marc_field(tag: 'itm', subfields: { q: '2023-06-28' })] }
 
       it 'returns expected value' do
@@ -70,9 +70,9 @@ describe 'PennMARC::Date' do
       end
 
       it 'outputs error message' do
-        expect do
+        expect {
           helper.added(record)
-        end.to output("Error parsing date in date added subfield: invalid date - invalid date\n").to_stdout
+        }.to output("Error parsing date in date added subfield: invalid date - invalid date\n").to_stdout
       end
     end
   end
@@ -96,9 +96,9 @@ describe 'PennMARC::Date' do
       end
 
       it 'outputs error message' do
-        expect do
+        expect {
           helper.last_updated(record)
-        end.to output("Error parsing last updated date: invalid date - invalid date\n").to_stdout
+        }.to output("Error parsing last updated date: invalid date - invalid date\n").to_stdout
       end
     end
   end

data/spec/lib/pennmarc/helpers/edition_spec.rb

@@ -10,7 +10,7 @@ describe 'PennMARC::Edition' do
                          marc_field(tag: '880', subfields: { '6': '250', b: 'رمستر' }),
                          marc_field(tag: '775', subfields: { i: 'Other Edition (Remove)',
                                                              h: 'Cool Book',
-                                                             t: 'aut'}),
+                                                             t: 'aut' }),
                          marc_field(tag: '880', subfields: { '6': '775', i: 'Autre Editione' })]
   end
 
@@ -28,11 +28,9 @@ describe 'PennMARC::Edition' do
 
   describe '.other_show' do
     it 'returns other edition values' do
-      expect(helper.other_show(record, mapping)).to contain_exactly('Autre Editione',
-                                                                    'Other Edition: Author. (Cool Book)')
+      expect(helper.other_show(record, relator_map: mapping)).to(
+        contain_exactly('Autre Editione', 'Other Edition: Author. (Cool Book)')
+      )
     end
   end
 end
-
-
-

data/spec/lib/pennmarc/helpers/format_spec.rb

@@ -7,9 +7,9 @@ describe 'PennMARC::Format' do
 
   describe '.facet' do
     let(:map) { location_map }
-    let(:formats) { helper.facet(record, map) }
+    let(:formats) { helper.facet(record, location_map: map) }
 
-    context 'for an "Archive"' do
+    context 'with an "Archive"' do
       let(:map) do
         { musearch: { specific_location: 'Penn Museum Archives',
                       library: 'Penn Museum Archives',
@@ -19,7 +19,7 @@ describe 'PennMARC::Format' do
                       display: 'Barbara Bates Center for History of Nursing - Fagin Hall 2U' } }
       end
 
-      context 'for a record in "Penn Museum Archives (musearch)"' do
+      context 'with a record in "Penn Museum Archives (musearch)"' do
         let(:record) { marc_record fields: [marc_field(tag: 'hld', subfields: { c: 'musearch' })] }
 
         it 'returns format values of "Archive" for a record with holdings located in "musearch"' do
@@ -27,7 +27,7 @@ describe 'PennMARC::Format' do
         end
       end
 
-      context 'for a record in "Nursing Archives (nursarch)"' do
+      context 'with a record in "Nursing Archives (nursarch)"' do
         let(:record) { marc_record fields: [marc_field(tag: 'hld', subfields: { c: 'nursarch' })] }
 
         it 'returns format values of without "Archive" for a record with a holding in "nursarch"' do
@@ -36,7 +36,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for a "Newspaper"' do
+    context 'with a "Newspaper"' do
       let(:record) do
         marc_record leader: '      as',
                     fields: [marc_control_field(tag: '008', value: '                     n')]
@@ -50,7 +50,7 @@ describe 'PennMARC::Format' do
     # TODO: confirm this as desired functionality
     # Inspired by https://franklin.library.upenn.edu/catalog/FRANKLIN_999444703503681
     # which appears to be a thesis on microfilm, but only has microfilm as a format.
-    context 'for a "Thesis" on "Microfilm"' do
+    context 'with a "Thesis" on "Microfilm"' do
       let(:record) do
         marc_record leader: '      tm',
                     fields: [
@@ -65,7 +65,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for Microformats as determined by the holding call numbers' do
+    context 'with Microformats as determined by the holding call numbers' do
       let(:record) do
         marc_record fields: [marc_field(tag: 'hld', subfields: { h: 'AB123', i: '.456 Microfilm' })]
       end
@@ -75,7 +75,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for a "Book"' do
+    context 'with a "Book"' do
       let(:record) do
         marc_record leader: '      aa',
                     fields: [marc_field(tag: '245', subfields: { k: 'blah' })]
@@ -86,7 +86,7 @@ describe 'PennMARC::Format' do
       end
     end
 
-    context 'for a "Projected Graphic"' do
+    context 'with a "Projected Graphic"' do
       let(:record) do
         marc_record leader: '      gm',
                     fields: [marc_control_field(tag: '007', value: 'go hkaaa ')]
@@ -180,8 +180,28 @@ describe 'PennMARC::Format' do
     end
   end
 
+  describe 'cartographic_show' do
+    let(:record) do
+      marc_record fields: [marc_field(tag: '255', subfields: {
+                                        a: ' Scale 1:2,534,400. 40 mi. to an in.', b: 'polyconic projection',
+                                        c: '(E 74⁰--E 84⁰/N 20⁰--N 12⁰).', d: 'Declination +90° to -90°',
+                                        e: 'equinox 1950, epoch 1949-1958'
+                                      }),
+                           marc_field(tag: '342', subfields: { a: 'Polyconic', g: '0.9996', h: '0', i: '500,000',
+                                                               j: '0' })]
+    end
+
+    it 'returns expected cartographic values' do
+      expect(helper.cartographic_show(record)).to contain_exactly(
+        'Polyconic 0.9996 0 500,000 0',
+        'Scale 1:2,534,400. 40 mi. to an in. polyconic projection (E 74⁰--E 84⁰/N 20⁰--N 12⁰). Declination +90° to
+         -90° equinox 1950, epoch 1949-1958'.squish
+      )
+    end
+  end
+
   describe '.includes_manuscript?' do
-    context 'with a manuscript location incldued' do
+    context 'with a manuscript location included' do
       let(:locations) { ['Van Pelt', 'Kislak Center for Special Collections - Manuscripts Storage'] }
 
       it 'returns true' do

data/spec/lib/pennmarc/helpers/genre_spec.rb

@@ -43,13 +43,13 @@ describe 'PennMARC::Genre' do
   end
 
   describe '.facet' do
-    let(:values) { helper.facet(record, location_map) }
+    let(:values) { helper.facet(record, location_map: location_map) }
     let(:location_map) do
       { manu: { specific_location: 'Secure Manuscripts Storage' },
         vanp: { specific_location: 'Van Pelt' } }
     end
 
-    context 'for a non-video, non-manuscript record' do
+    context 'with a non-video, non-manuscript record' do
       let(:fields) do
         [marc_control_field(tag: '007', value: 'x'),
          marc_field(tag: 'hld', subfields: { c: 'vanp' }),
@@ -61,7 +61,7 @@ describe 'PennMARC::Genre' do
       end
     end
 
-    context 'for a video record' do
+    context 'with a video record' do
       let(:fields) do
         [marc_control_field(tag: '007', value: 'v'),
          marc_field(tag: 'hld', subfields: { c: 'vanp' }),
@@ -74,7 +74,7 @@ describe 'PennMARC::Genre' do
       end
     end
 
-    context 'for a manuscript-located record' do
+    context 'with a manuscript-located record' do
       let(:fields) do
         [marc_control_field(tag: '007', value: 'x'),
          marc_field(tag: 'hld', subfields: { c: 'manu' }),

data/spec/lib/pennmarc/helpers/identifer_spec.rb

@@ -84,6 +84,7 @@ describe 'PennMARC::Identifier' do
         marc_field(tag: '880', subfields: { a: '006680200B', b: 'Island', '6': '028' })
       ]
     end
+
     it 'returns expected show values' do
       expect(helper.publisher_number_show(record)).to contain_exactly('602537854325',
                                                                       'B002086600 Island Def Jam Music Group',
@@ -98,8 +99,22 @@ describe 'PennMARC::Identifier' do
         marc_field(tag: '028', subfields: { a: 'B002086600', b: 'Island Def Jam Music Group' })
       ]
     end
+
     it 'returns expected search values' do
       expect(helper.publisher_number_search(record)).to contain_exactly('602537854325', 'B002086600')
     end
   end
+
+  describe '.fingerprint_show' do
+    let(:record) do
+      marc_record fields: [
+        marc_field(tag: '026', subfields: { a: 'dete nkck', b: 'vess lodo', c: 'Anno Domini MDCXXXVI', d: '3',
+                                            '2': 'fei', '5': 'penn' })
+      ]
+    end
+
+    it 'returns expected fingerprint values' do
+      expect(helper.fingerprint_show(record)).to contain_exactly('dete nkck vess lodo Anno Domini MDCXXXVI 3')
+    end
+  end
 end

data/spec/lib/pennmarc/helpers/language_spec.rb

@@ -18,7 +18,7 @@ describe 'PennMARC::Language' do
 
   describe '.search' do
     it 'returns the expected display value' do
-      expect(helper.search(record, mapping)).to eq 'English'
+      expect(helper.search(record, language_map: mapping)).to eq 'English'
     end
   end
 

data/spec/lib/pennmarc/helpers/location_spec.rb

@@ -13,7 +13,7 @@ describe 'PennMARC::Location' do
       it 'returns expected value' do
         expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')
-        expect(helper.location(record:, location_map: mapping,
+        expect(helper.location(record: record, location_map: mapping,
                                display_value: 'specific_location')).to contain_exactly('LIBRA')
       end
     end
@@ -34,6 +34,7 @@ describe 'PennMARC::Location' do
         marc_record(fields: [marc_field(tag: 'itm', subfields: { g: 'stor' }),
                              marc_field(tag: 'hld', subfields: { c: 'dent' })])
       end
+
       it 'returns item location' do
         expect(helper.location(record: record, location_map: mapping,
                                display_value: :library)).to contain_exactly('LIBRA')

data/spec/lib/pennmarc/helpers/note_spec.rb

@@ -199,7 +199,7 @@ describe 'PennMARC::Note' do
 
     let(:fields) do
       [
-        marc_field(tag: '545', subfields: { a: 'A Creator', b: 'Additional Info', 'u': 'URI' }),
+        marc_field(tag: '545', subfields: { a: 'A Creator', b: 'Additional Info', u: 'URI' }),
         marc_field(tag: '880', subfields: { a: 'Alt Bio', b: 'Alt Info', u: 'Alt URI', '6': '545' })
       ]
     end
@@ -217,7 +217,7 @@ describe 'PennMARC::Note' do
 
     let(:fields) do
       [
-        marc_field(tag: '520', subfields: { a: 'An Abstract', b: 'Additional Summary', 'c': 'ProQuest' }),
+        marc_field(tag: '520', subfields: { a: 'An Abstract', b: 'Additional Summary', c: 'ProQuest' }),
         marc_field(tag: '880', subfields: { a: 'Alt Abstract', b: 'Alt Additional Summary', c: 'Alt ProQuest',
                                             '6': '520' })
       ]
@@ -229,5 +229,70 @@ describe 'PennMARC::Note' do
       expect(values).to contain_exactly('An Abstract Additional Summary ProQuest',
                                         'Alt Abstract Alt Additional Summary Alt ProQuest')
     end
+
+    describe '.arrangement_show' do
+      let(:record) { marc_record(fields: fields) }
+
+      let(:fields) do
+        [
+          marc_field(tag: '351', subfields: { a: 'Organized into five subseries', b: 'Arrangement pattern', c: 'Series',
+                                              '3': 'materials' }),
+          marc_field(tag: '880', subfields: { a: 'Alt organization', b: 'Alt arrangement', c: 'Alt hierarchical level',
+                                              '3': 'Alt materials', '6': '351' })
+        ]
+      end
+
+      let(:values) { helper.arrangement_show(record) }
+
+      it 'returns expected values from 351 and its linked alternate' do
+        expect(values).to contain_exactly('Organized into five subseries Arrangement pattern Series materials',
+                                          'Alt organization Alt arrangement Alt hierarchical level Alt materials')
+      end
+    end
+
+    describe '.system_details_show' do
+      let(:record) { marc_record(fields: fields) }
+
+      let(:fields) do
+        [
+          marc_field(tag: '538', subfields: { a: 'Blu-ray, region A, 1080p High Definition, full screen (1.33:1)',
+                                              i: 'display text for URI', u: 'http://www.universal.resource/locator ',
+                                              '3': ['Blu-ray disc.', '2015'] }),
+          marc_field(tag: '344', subfields: { a: 'digital', b: 'optical', c: '1.4 m/s', g: 'stereo',
+                                              h: 'digital recording', '3': 'audio disc' }),
+          marc_field(tag: '345', subfields: { a: '1 film reel (25 min.)', b: '24 fps', '3': 'Polyester print' }),
+          marc_field(tag: '346', subfields: { a: 'VHS', b: 'NTSC', '3': 'original videocassette' }),
+          marc_field(tag: '347', subfields: { a: 'video file', b: 'DVD video', e: 'region', '3': 'DVD' }),
+          marc_field(tag: '880', subfields: { a: 'Alt system details', i: 'Alternative display text', u: 'Alt URI',
+                                              '3': 'Alt materials.', '6': '538' }),
+          marc_field(tag: '880', subfields: { a: 'Alt recording', b: 'Alt medium', c: 'Alt playing speed',
+                                              g: 'Alt channel',
+                                              h: 'Alt characteristic', '3': 'Alt materials.',
+                                              '6': '344' }),
+          marc_field(tag: '880', subfields: { a: 'Alt presentation format', b: 'Alt projection speed',
+                                              '3': 'Alt materials.', '6': '345' }),
+          marc_field(tag: '880', subfields: { a: 'Alt video format', b: 'Alt broadcast', '3': 'Alt materials.',
+                                              '6': '346' }),
+          marc_field(tag: '880', subfields: { a: 'Alt file type', b: 'Alt encoding', '3': 'Alt materials.',
+                                              '6': 'Alt region' })
+
+        ]
+      end
+
+      let(:values) { helper.system_details_show(record) }
+
+      it 'returns expected from 5xx and 3xx fields and their linked alternates' do
+        expect(values).to contain_exactly(
+          'Blu-ray disc: 2015 Blu-ray, region A, 1080p High Definition, full screen (1.33:1) display
+text for URI http://www.universal.resource/locator'.squish,
+          'audio disc digital optical 1.4 m/s stereo digital recording', 'Polyester print 1 film reel (25 min.) 24 fps',
+          'original videocassette VHS NTSC', 'DVD video file DVD video region',
+          'Alt materials Alt system details Alternative display text Alt URI',
+          'Alt materials Alt recording Alt medium Alt playing speed Alt channel Alt characteristic',
+          'Alt materials Alt presentation format Alt projection speed',
+          'Alt materials Alt video format Alt broadcast'
+        )
+      end
+    end
   end
 end

data/spec/lib/pennmarc/helpers/relation_spec.rb

@@ -65,7 +65,7 @@ describe 'PennMARC::Relation' do
     end
 
     it 'returns specified subfield values from specified field with blank indicator2' do
-      values = helper.related_work_show record, relator_map
+      values = helper.related_work_show record, relator_map: relator_map
       expect(values).to contain_exactly 'Translation of: Some Author Aphorisms, Translator',
                                         'Alt. Prefix: Alt. Author Alt. Aphorisms'
       expect(values).not_to include 'Ignored'
@@ -81,7 +81,7 @@ describe 'PennMARC::Relation' do
     end
 
     it "returns specified subfield values from specified field with '2' in indicator2" do
-      values = helper.contains_show record, relator_map
+      values = helper.contains_show record, relator_map: relator_map
       expect(values).to contain_exactly 'Alt. Prefix: Alt. Name', 'Container of: Some Author Works, Author'
       expect(values).not_to include 'Ignored'
     end

data/spec/lib/pennmarc/helpers/series_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+describe 'PennMARC::Series' do
+  include MarcSpecHelpers
+
+  let(:helper) { PennMARC::Series }
+  let(:mapping) { { aut: 'Author' } }
+  let(:record) do
+    marc_record fields: [marc_field(tag: '490', subfields: { a: 'Teachings of the feathered pillow' }),
+                         marc_field(tag: '880', subfields: { '6': '490', a: 'Учения пернатой подушки' }),
+                         marc_field(tag: '800', subfields: { a: 'Bean Bagatolvski', d: '1997-', v: 'bk. 1' }),
+                         marc_field(tag: '780', subfields: { a: 'National Comfort Association' }),
+                         marc_field(tag: '785', subfields: { a: 'NCA quarterly comfortology bulletin' })]
+  end
+  let(:empty_record) do
+    marc_record fields: [marc_field(tag: '666', subfields: { a: 'test' })]
+  end
+
+  describe '.show' do
+    it 'returns the series' do
+      expect(helper.show(record, relator_map: mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1',
+                                                              'Teachings of the feathered pillow',
+                                                              'Учения пернатой подушки')
+    end
+  end
+
+  describe '.values' do
+    it 'returns the values' do
+      expect(helper.values(record, relator_map: mapping)).to contain_exactly('Bean Bagatolvski 1997- bk. 1.')
+    end
+  end
+
+  describe '.search' do
+    it 'returns the search values' do
+      expect(helper.search(record)).to contain_exactly('Bean Bagatolvski 1997- bk. 1')
+    end
+
+    it 'returns an empty array if no values are found' do
+      expect(helper.search(empty_record)).to be_empty
+    end
+  end
+
+  describe '.get_continues_display' do
+    it 'gets continues for display' do
+      expect(helper.get_continues_display(record)).to contain_exactly('National Comfort Association')
+    end
+  end
+
+  describe '.get_continued_by_display' do
+    it 'gets continued by display' do
+      expect(helper.get_continued_by_display(record)).to contain_exactly('NCA quarterly comfortology bulletin')
+    end
+  end
+end

data/spec/lib/pennmarc/helpers/subject_spec.rb

@@ -10,7 +10,7 @@ describe 'PennMARC::Subject' do
 
   describe '.search' do
     let(:record) { marc_record fields: fields }
-    let(:values) { helper.search(record, relator_map) }
+    let(:values) { helper.search(record, relator_map: relator_map) }
 
     context 'with a mix of included and excluded tags' do
       let(:fields) do
@@ -61,11 +61,11 @@ describe 'PennMARC::Subject' do
   end
 
   describe '.facet' do
-    let(:record) { marc_record fields: }
+    let(:record) { marc_record fields: fields }
     let(:values) { helper.facet(record) }
 
     # TODO: find some more inspiring examples in the corpus
-    context 'for a record with poorly-coded heading values' do
+    context 'with a record with poorly-coded heading values' do
       let(:fields) { [marc_field(tag: '650', indicator2: '0', subfields: { a: 'Subject -   Heading' })] }
 
       it 'properly normalizes the heading value' do
@@ -73,7 +73,7 @@ describe 'PennMARC::Subject' do
       end
     end
 
-    context 'for a record with 650 headings with a ǂa that starts with PRO or CHR' do
+    context 'with a record with 650 headings with a ǂa that starts with PRO or CHR' do
       let(:fields) do
         [marc_field(tag: '650', indicator2: '4', subfields: { a: '%CHR 1998', '5': 'PU' }),
          marc_field(tag: '650', indicator2: '4', subfields: { a: 'PRO Potok, Adena (donor) (Potok Collection copy)',
@@ -85,7 +85,7 @@ describe 'PennMARC::Subject' do
       end
     end
 
-    context 'for a record with an indicator2 value of 3, 5 or 6' do
+    context 'with a record with an indicator2 value of 3, 5 or 6' do
       let(:fields) do
         [marc_field(tag: '650', indicator2: '3', subfields: { a: 'Nope' }),
          marc_field(tag: '650', indicator2: '5', subfields: { a: 'Nope' }),
@@ -97,7 +97,7 @@ describe 'PennMARC::Subject' do
       end
     end
 
-    context 'for a record with a valid tag, indicator2 and source specified' do
+    context 'with a record with a valid tag, indicator2 and source specified' do
       let(:fields) do
         [marc_field(tag: '650', indicator2: '7',
                     subfields: {
@@ -129,7 +129,7 @@ describe 'PennMARC::Subject' do
   end
 
   describe '.show' do
-    let(:record) { marc_record fields: }
+    let(:record) { marc_record fields: fields }
     let(:values) { helper.facet(record) }
 
     context 'with a variety of headings' do
@@ -145,8 +145,8 @@ describe 'PennMARC::Subject' do
       end
 
       it 'shows all valid subject headings without duplicates' do
-        expect(helper.show(record)).to match_array ['Nephrology--Periodicals', 'Nephrology',
-                                                    'Kidney Diseases', 'Local Heading']
+        expect(helper.show(record)).to contain_exactly('Nephrology--Periodicals', 'Nephrology', 'Kidney Diseases',
+                                                       'Local Heading')
       end
     end